| === chihchun_afk is now known as chihchun | ||
| pitti | Good morning | 04:38 |
|---|---|---|
| shrini | elfy: Thanks for merging my test cases | 06:39 |
| elfy | hi shrini - thanks for doing them :) | 06:51 |
| elfy | shrini: one quick comment - if there is a bug that you're doing the testcase for - please assign yourself to the bug :) | 06:52 |
| elfy | bug 1348639 | 06:52 |
| ubot5 | bug 1348639 in Ubuntu Manual Tests "Mugshot testcase calls for missing stock items" [High,Fix committed] https://launchpad.net/bugs/1348639 | 06:52 |
| elfy | check that one - you can see where I assigned it to me | 06:52 |
| shrini | elfy: oh. thanks. will do that | 06:53 |
| elfy | it's unlikely to happen - but it could be that more than person works on the same thing - and only one will get merged :) | 06:53 |
| elfy | and you'll get karma :) | 06:53 |
| === zequence_ is now known as zequence | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === DanChapman is now known as DanChapman|afk | ||
| === chihchun is now known as chihchun_afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === _salem is now known as salem_ | ||
| === stgraber_ is now known as stgraber | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| om26er | elopio, I wrote helpers for TextArea, its mostly copy paste https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/add_helpers_for_TextArea/+merge/228385 | 15:43 |
| elopio | om26er: I saw a little about it on friday. | 15:43 |
| elopio | I'll make the full review today. | 15:43 |
| elopio | what I saw is that you shouldn't duplicate all the tests. | 15:43 |
| balloons | om26er, awesome :-0 | 15:44 |
| elopio | you can either use scenarios to run the same tests for textfields and textareas | 15:44 |
| elopio | or you can just write a test that checks that textarea inherits from textfield. | 15:44 |
| om26er | elopio, one test to rule them all ? | 15:44 |
| om26er | elopio, well one of the methods couldn't be reused because TextArea does have a clear button | 15:45 |
| om26er | so it was check for hasClearButton causing failure | 15:45 |
| elopio | om26er: ok, that's good to know. I think the better strategy is to only test what changes between the base class and the child. | 15:46 |
| elopio | so one test for clear the text area, and one test to check it inherits from text field is good enough. | 15:47 |
| elopio | if you want to go the safer route, go with the scenarios solution to run all tests for both | 15:48 |
| elopio | and you can either skip hasClearButton on textArea, or move it to a textfield specific test case. | 15:48 |
| elopio | om26er: but as I said, I just gave it a quick look. | 15:48 |
| elopio | I have it on my todo. | 15:48 |
| === Ursinha-afk is now known as Ursinha | ||
| om26er | elopio, I think its fine to just check it inherits and a test for clear. | 15:50 |
| elopio | om26er: chose whatever you think best. So, please mark it as work in progress, and I'll get an email when it's ready again and review it. | 15:50 |
| om26er | elopio, done. | 15:51 |
| om26er | balloons, isn't it :) | 15:51 |
| pitti | balloons: could you live with http://paste.ubuntu.com/7885946/ ? | 15:57 |
| * balloons looks | 15:59 | |
| balloons | pitti, yes, I think after we spoke that's the most sane way of doing it | 15:59 |
| pitti | balloons: it only needs to be specified once, the next run won't need it any more | 16:00 |
| pitti | but I don't want to penalize all runs by always running it | 16:00 |
| pitti | balloons: well, it can always be improved later on, but with that one has at least a way to get on | 16:00 |
| balloons | pitti, right.. could you catch the 404 error automagically? | 16:01 |
| pitti | balloons: with some heuristics/parsing, I suppose so | 16:01 |
| pitti | it's not easy to wire between adt-run and the ssh script | 16:02 |
| === chihchun_afk is now known as chihchun | ||
| balloons | pitti, cool, but probably not the most important thing.. This is simple and gives a nice solution | 16:06 |
| elfy | afternoon balloons | 16:07 |
| elfy | and pitti et al | 16:07 |
| balloons | afternoon elfy | 16:07 |
| elopio | nice work om26er. I'll approve your text area branch and ask the team to get it merged. | 16:58 |
| om26er | elopio, thanks | 16:58 |
| elopio | oh, om26er, one thing. | 16:58 |
| om26er | hah | 16:58 |
| elopio | you need to do the mp agains staging. | 16:58 |
| elopio | *against | 16:58 |
| elopio | https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging | 16:58 |
| om26er | elopio, https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/add_helpers_for_TextArea/+merge/228542 | 17:01 |
| === Ursinha is now known as Ursinha-afk | ||
| === roadmr is now known as roadmr_afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === roadmr_afk is now known as roadmr | ||
| elfy | any testcase admins about - https://code.launchpad.net/~elfy/ubuntu-manual-tests/1348639/+merge/228307 | 19:02 |
| elfy | thanks :) | 19:02 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === alexabreu is now known as alex-abreu | ||
| balloons | elfy, on https://code.launchpad.net/~elfy/ubuntu-manual-tests/1348639/+merge/228307, why do you have extra unmerged revs in there? | 19:57 |
| elfy | mmm | 20:01 |
| elfy | no idea :( | 20:01 |
| elfy | it's bzr ... | 20:01 |
| balloons | left a comment | 20:03 |
| * elfy left an answer | 20:04 | |
| elfy | balloons: I've no idea where those other things have come from - though 279-281 are the Dia thing I merged and synced | 20:05 |
| balloons | elfy, yea, they are simply revisions from trunk | 20:05 |
| balloons | elfy, merged and synced | 20:10 |
| elfy | thanks boss - was the last one I checked | 20:10 |
| elfy | just been doing them prior to a test call | 20:10 |
| elfy | that was the last one I needed to change \o/ | 20:11 |
| balloons | :-) | 20:12 |
| elopio | ubuntu-qa and/or balloons: can I get a review here please? https://code.launchpad.net/~canonical-platform-qa/sudoku-app/clean_tests1/+merge/228236 | 20:23 |
| balloons | elopio, that's on my list, but anyone else feel free to jump on it in the interim | 20:24 |
| === Ursinha is now known as Ursinha-afk | ||
| elopio | thanks balloons. I hope somebody else jumps. We need more people making reviews. | 20:24 |
| thomi | elopio: too many whitespace changes :P | 20:25 |
| thomi | elopio: *ahaaaa*! *now* I know who keeps introducing this 'AppnameApp' anti-pattern :P | 20:27 |
| elopio | thomi: antipattern? We discussed for a long time about it. | 20:27 |
| elopio | tell me what don't you like | 20:27 |
| thomi | it's a nasty hack to work around this bug, which nobody reported till brendand asked us to look at a test last week: https://bugs.launchpad.net/autopilot/+bug/1348399 | 20:28 |
| ubot5 | Launchpad bug 1348399 in Autopilot "Autopilot does not honor the object cache when creating the root introspection object" [High,Confirmed] | 20:28 |
| thomi | SudokuApp should be a CPC | 20:28 |
| thomi | otherwise, when you call 'get_root_instance' from elsewhere in the tree you don't get a SudokuApp instance back, and you need to create another one, which is just silly :) | 20:29 |
| elopio | thomi: oh, I never thought about it as a bug. But anyway, once you fix it, I'll just have to change the base class. | 20:29 |
| elopio | and not pass the proxy as a parameter. That's nice. | 20:29 |
| thomi | elopio: yeah | 20:30 |
| thomi | elopio: anyway :) | 20:30 |
| elopio | subscribing myself to know when to use it that way. | 20:30 |
| balloons | interesting bug.. | 20:31 |
| === Ursinha-afk is now known as Ursinha | ||
| elopio | thomi: do you know if we can launch with upstart an application binary from the build directory? | 21:19 |
| thomi | elopio: I believe if you create an upstart override file you can | 21:19 |
| thomi | elopio: I think some of the test suites do that already | 21:19 |
| thomi | elopio: perhaps maalit? | 21:19 |
| elopio | thomi: what's that? the desktop file? | 21:19 |
| thomi | elopio: no | 21:19 |
| thomi | elopio: veebers knows how to do it | 21:19 |
| * elopio waits for veebers. | 21:20 | |
| veebers | elopio: hey, hmm I'll have to remember, but we've done it before | 21:20 |
| veebers | I think unity8 does something like that | 21:20 |
| * veebers checks | 21:20 | |
| thomi | it's a file in ~/.share/upstart/appname.override (I think), where you can specify an alternate path to launch | 21:20 |
| veebers | I thought ~/.cache/... | 21:22 |
| veebers | hmm no, unity8 upstart config allows you to pass BINARY, onto the next example | 21:23 |
| elopio | ~/.share doesn't exist here. ~/.cache has only the app logs. | 21:23 |
| veebers | elopio: oh, ~/.config | 21:24 |
| elopio | veebers: any idea what should I put there? | 21:25 |
| veebers | elopio: for instance: ~/.config/upstart/maliit-server.override | 21:25 |
| veebers | elopio: for instance for the maliit one it's putting: "exec maliit-server -testability" | 21:26 |
| veebers | this might be outdated information though and there may be a better way | 21:26 |
| elopio | veebers: yes, something like this in dialer-app.override does'nt seem to work: | 21:29 |
| elopio | exec workspace/canonical/dialer-app/bugs/fix1349582-number_format/src/dialer-app | 21:29 |
| elopio | veebers: do you know who to ask about this? | 21:29 |
| veebers | elopio: ted? Perhaps om26er, I'm pretty sure he's used the override stuff before | 21:30 |
| om26er | veebers, yeah, didn;t try recently but it used to work | 21:31 |
| om26er | elopio, so you want to start maliit always in testability ? | 21:31 |
| elopio | om26er: no, I want upstart to start the dialer app from the branch, not the installed one. | 21:31 |
| om26er | yeah then 'exec $bin' | 21:34 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!