| wgrant | cprov: Could you please have a look at https://code.launchpad.net/~wgrant/launchpad/nu-overrides-adapters/+merge/228619? | 11:56 |
|---|---|---|
| cprov | wgrant: yes, of course | 12:04 |
| cprov | wgrant: it means that now we can support PPA uploads to universe and properly override them ? | 12:17 |
| wgrant | cprov: PPAs deliberately override everything to main. | 12:18 |
| cprov | wgrant: I know, but is it still deliberately rejecting uploads targeted to other components. | 12:19 |
| wgrant | cprov: Ah, no, that was fixed in like 2008 :P | 12:20 |
| wgrant | But in an awful way that I can just about remove now. | 12:20 |
| wgrant | The methods that create SPPHs and BPPHs have an "if archive.is_ppa: component = main" hack. | 12:20 |
| cprov | wgrant: ah, it's in *PPHs ... I could not find it. | 12:21 |
| wgrant | Specifically, the get_component function in lp.soyuz.model.publishing | 12:21 |
| cprov | wgrant: it seems too hairy for changing in this MP. | 12:23 |
| wgrant | cprov: You'll see that I left XXXs in place in find_and_apply_overrides. Since archiveuploader applies overrides by mutating BPR and SPR, and we want to remember whether a PPA package had contrib or non-free in its Section field, we can't apply PPA overrides in NascentUpload -- we have to maintain the publish-time hack instead. | 12:25 |
| wgrant | But eventually PackageUpload will store overrides directly, and we can stop mutating the SPR and BPRs, and those hacks can go away. | 12:25 |
| cprov | wgrant: agreed | 12:26 |
| wgrant | cprov: Thanks. | 12:31 |
| * wgrant breaks the world. | 12:31 | |
| === matsubara is now known as matsubara-lunch | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| === matsubara-lunch is now known as matsubara | ||
| === Ursinha-afk is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!