[05:09] <elopio> ping mzanetti: if the dash is an app, why can't I launch it with ubuntu-launch-app ?
[07:49] <tsdgeos> Saviq: there?
[08:14] <Saviq> tsdgeos, here
[08:14] <Saviq> elopio, you should be able to
[08:15] <tsdgeos> Saviq: was wondering if base the scopes activation thing on dash overview or on plain trunk
[08:15] <Saviq> tsdgeos, overview
[08:15] <tsdgeos> ok
[08:15] <Saviq> tsdgeos, since it has exceptions for it
[08:16] <tsdgeos> Saviq: "on top of" or "inside" overview?
[08:16] <Saviq> tsdgeos, on top of please
[08:16] <tsdgeos> okidoki
[08:48] <Saviq> mzanetti, can you please have a think and list any cases where you think just url handling for scope:/// won't cut it?
[08:49] <Saviq> (in the MP that is)
[08:49] <mzanetti> ok
[08:50] <mzanetti> Saviq: what about line 261 in the diff? is that still wanted? I wasn't unsure
[08:50] <mzanetti> err. I was unsure :D
[08:51]  * Saviq looks
[08:51] <Saviq> mzanetti, 261 is a newline ;)
[08:53] <Saviq> mzanetti, ugh, wrong mp
[08:53] <Saviq> no, still newline :D
[08:54] <mzanetti> Saviq: 621, sorry
[08:54] <Saviq> mzanetti, yeah, nothing like that
[08:54] <Saviq> mzanetti, what's more
[08:55] <Saviq> http://paste.ubuntu.com/7893171/
[08:55] <Saviq> mzanetti, but not necessarily in your MP
[08:55] <mzanetti> ok
[08:56] <Saviq> mzanetti, basically we'll only be changing focus inside the dash if you press BFB or left-swipe
[08:57] <mzanetti> Saviq: atm we're using different animations when pressing the home button
[08:58] <mzanetti> Saviq: depending on whether the greeter is locked or not, we animate to home or not
[08:58] <Saviq> mzanetti, when dash isn't visible, there will be no animation inside it now
[08:58] <mzanetti> Saviq: ans also, on left edge swipe we reset it to the top, while we don't do on home button press
[09:00] <mzanetti> so well, I don't really care... can drop the whole communicator thing
[09:00] <mzanetti> but I'm afraid the url hadler is not in place yet, is it?
[09:00] <Saviq> mzanetti, sure it's not
[09:00] <Saviq> mzanetti, I'm not saying you should drop it now
[09:01] <Saviq> mzanetti, as we can't really drop it, we need to replace it with the handler
[09:01] <Saviq> mzanetti, but I just wanted to have a list of doubts to shoot down ;)
[09:01] <mzanetti> ok. so I'll find a place to write this down as a list
[09:01] <Saviq> thanks
[09:01] <mzanetti> not the MP, that'll vanish once merged
[09:01] <mzanetti> some doc or something
[09:02] <mzanetti> Saviq: didn't we patch Qt to read the QT_TESTABILTIY env var?
[09:02] <Saviq> mzanetti, QT_LOAD_TESTABILITY=1
[09:02] <mzanetti> or do I still need to read that manually in main.cc?
[09:03] <mzanetti> elopio complains it wouldn't work
[09:08] <tsdgeos> pstolowski: https://code.launchpad.net/~aacid/unity8/scopeActivatePreview/+merge/228624 this should be the activate/preview thing, no?
[09:08] <tsdgeos> Saviq: ↑
[09:10] <pstolowski> tsdgeos, the clickscope hack is still needed for applications; also, preview should be called for scope:// uris in scopes scope
[09:11] <tsdgeos> scopes scope does not exist anymore
[09:11] <tsdgeos> it's called dash overview
[09:11] <tsdgeos> and does not go thorugh this route
[09:12] <tsdgeos> pstolowski: so do it for scope:// and application:// ?
[09:12] <tsdgeos> or both store and click scope return application:// ?
[09:12]  * tsdgeos checks
[09:13] <pstolowski> tsdgeos, how do I get this new overview page? I flashed today but it's not there
[09:13] <tsdgeos> pstolowski: it's not merged yet
[09:13] <tsdgeos> but this branch depends on that one
[09:13] <tsdgeos> so for this branch purposes it is
[09:15] <tsdgeos> anyway i've brought back the clickscope hack
[09:20] <Saviq> tsdgeos, no, clickscope doesn't return urls yet
[09:20] <tsdgeos> Saviq: it does for me :D
[09:21] <Saviq> tsdgeos, for all apps?
[09:21] <tsdgeos> ah
[09:21] <tsdgeos> not sure
[09:21] <tsdgeos> for a few i clicked
[09:21] <Saviq> tsdgeos, basically click vs. not click is the important part
[09:21] <tsdgeos> oki
[09:23] <Saviq> tsdgeos, but yeah, if (clickscope || scope://) is good
[09:23] <pstolowski> tsdgeos, lgtm. can we have a silo with this and any dependencies?
[09:23] <tsdgeos> pstolowski: someone needs to review dash_overview :/
[09:23] <Saviq> pstolowski, I'll try and get a silo with overview and firends
[09:23] <tsdgeos> but sure it can be silo'ed
[09:23] <Saviq> tsdgeos, does preview in overview work? (and not work for non-scope:/// urls?)
[09:24] <pstolowski> tsdgeos, could you pls updated the commit message, it's entirely correct?
[09:26] <tsdgeos> pstolowski: updated
[09:30] <tsdgeos> Saviq: autopilot borked again
[09:30] <tsdgeos> any idea what ahppend?
[09:30] <tsdgeos> https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2766/console
[09:31] <Saviq> tsdgeos, humpf!
[09:31] <Saviq> tsdgeos, it didn't return the PID
[09:31] <Saviq> "unity8 start/running" should have ", process 2467"
[09:31] <Saviq> or so
[09:32] <Saviq> (it does here)\
[09:32] <tsdgeos> :/
[09:32] <tsdgeos> seems a pretty constant failure
[09:32] <Saviq> maybe it was too quick
[09:32] <tsdgeos> maybe it's a change somehwere?
[09:32] <Saviq> weeeeirds
[09:33] <Saviq> like even "start unity8" returns a PID
[09:33] <Saviq> tsdgeos, I'll have a look soon
[09:34] <tsdgeos> oki
[09:44] <Cimi> mzanetti, ping
[09:44] <mzanetti> Cimi: peng!
[09:44] <Cimi> mzanetti, :D
[09:44] <Cimi> mzanetti, I had a look at the count emblem
[09:45] <Cimi> want a reassurance on width: Math.min(root.itemWidth, Math.max(units.gu(2), countLabel.implicitWidth + units.gu(1)))
[09:45] <mzanetti> ok
[09:45] <mzanetti> what exactly?
[09:45] <mzanetti> want a test for it or what?
[09:45] <Cimi> itemWidth is always more than 2?
[09:46] <mzanetti> is it? this code wouldn't suggest that
[09:46] <Cimi> I am wondering if we could have a portrait like ubuntushape
[09:47] <cwayne> finally got a chance to checkout phone-right-edge ppa -- looks awesome! cant wait to see it in image
[09:47] <Cimi> in case itemWidth is less than 2gu
[09:47] <mzanetti> oh..
[09:47] <mzanetti> now I see your thought
[09:47] <mzanetti> let me check
[09:47] <Cimi> this piece of code changed and I was wondering why
[09:48] <mzanetti> Cimi: well, it didn't change much, I just decreased values from 2 gu's to 1 gu.
[09:48] <mzanetti> Cimi: ok... just checked the code
[09:49] <mzanetti> Cimi: yes, itemWidth is the size of the whole launcher icon
[09:49] <mzanetti> Cimi: so yes, that's always larger than 2 gus
[09:49] <Cimi> ok
[09:49] <mzanetti> Cimi: and if it isn't the launcher is so tiny that we need to shrink those emblems too
[09:52] <mzanetti> Saviq: can you give me a pointer on how the dash was loading fake scopes for AP tests so far?
[09:54] <Saviq> mzanetti, it exported QML2_IMPORT_PATH correctly
[09:54] <mzanetti> Saviq: so that should work just the same with the standalone dash app, right?
[09:57] <Cimi> mzanetti, label is not centered vertically but that is qml fault
[09:57] <Cimi> mzanetti, we could use an offset
[09:57] <Cimi> 1 pixel maybe
[09:57] <Saviq> mzanetti, yeah, just need to make sure you launch the standalone dash with the right import path set
[09:57] <mzanetti> Saviq: ack, thanks
[09:58] <mzanetti> Cimi: http://i.imgur.com/YFYv6De.png
[09:58] <mzanetti> I think it looks fine
[09:58] <Saviq> mzanetti, tests/autopilot/unity8/__init__.py
[09:58] <Cimi> mzanetti, nope
[09:58] <mzanetti> the 1 might be a bit off, but for instance the 5 works quite fine, no?
[09:58] <Cimi> mzanetti, it is at least 1px down
[09:58] <Saviq> mzanetti, they're all off
[09:59] <mzanetti> oh, vertically
[09:59] <Saviq> mzanetti, yes
[09:59] <mzanetti> hmm
[09:59] <Cimi> mzanetti, also I'd remove the border of the ubuntushape
[09:59] <Cimi> there is like an inset here
[09:59] <Cimi> doesn't look nice
[10:03] <Cimi> mzanetti, OK?
[10:04] <mzanetti> Cimi: http://i.imgur.com/3VZMgXZ.png <- better?
[10:04] <Cimi> mzanetti, ok for me
[10:04] <mzanetti> (thats a verticalCenterOffset of -units.dp(.5)
[10:04] <mzanetti> Saviq: is that ok? ^
[10:04] <mzanetti> units.dp(1) is too much
[10:05] <mzanetti> the theory would disagree :D
[10:05] <Cimi> mzanetti, also now that I see
[10:05] <Cimi> mzanetti, is there a separator between ubuntu dash button and the rest of launcher?
[10:05] <Cimi> mzanetti, we can remove it with this orange design
[10:06] <mzanetti> Cimi: dunno. need to talk to Vesa/Esti
[10:06] <mzanetti> Cimi: there is a separator, yes
[10:06] <Cimi> looks unneeded
[10:06] <Cimi> we can remove it in another branch
[10:07] <Saviq> mzanetti, in practice it should be a static fraction of font.pixelSize
[10:07] <mzanetti> Cimi: pushed the above
[10:07] <Saviq> (static assuming the font won't change that is) ;)
[10:07] <mzanetti> hmm...
[10:07] <Saviq> but really we should file a QTBUG
[10:08] <Saviq> that QML doesn't know about font centerLine or whatnot
[10:08] <Cimi> mzanetti, // FIXME too
[10:08] <mzanetti> Saviq: ok with having the units.dp(.5) offset workaround?
[10:09] <Cimi> with link of qt bug :D
[10:09] <Cimi> I can open it
[10:09] <Saviq> mzanetti, yeah, nothing better we can do really
[10:09] <mzanetti> Cimi: is there a bug already?
[10:09] <Cimi> writing it
[10:09] <mzanetti> Cimi: ah ok, cool
[10:09] <mzanetti> Cimi: yeah, when you have it, let me know and I'll add the fixme
[10:14] <Cimi> Saviq, mzanetti https://bugreports.qt-project.org/browse/QTBUG-40479
[10:22] <mzanetti> Cimi: thanks. I've pushed the FIXME
[10:23] <paulliu> dandrader: https://code.launchpad.net/~paulliu/unity8/reboot_140728/+merge/228485
[10:35] <Saviq> tsdgeos, mhr3, https://docs.google.com/a/canonical.com/document/d/1NmiM4UCnJgf6IEawmfyTOHRNAA5ZGrqpyrPqPOibwc8/edit?disco=AAAAAKGrPoI
[10:40] <tsdgeos> Saviq: looks ok to me
[10:40] <tsdgeos> actually
[10:41] <tsdgeos> Saviq: wouldn't it just be simpler to have threshold as a number not as a widget
[10:41] <tsdgeos> so i don't have to go over the list and find it
[10:41] <tsdgeos> what does it add being part of the list?
[10:41] <Saviq> tsdgeos, right
[10:41]  * Saviq fixes
[10:43] <Saviq> tsdgeos, done
[10:43] <tsdgeos> don't like the name :D
[10:43] <mhr3> pete-woods, you probably want to be at least aware of this ^^ ;)
[10:43] <tsdgeos> what is collapsed-widgets ?
[10:44] <tsdgeos> i mean doesn't feel very descriptive
[10:44] <Saviq> tsdgeos, better name welcome, but it's the number of widgets that are visible in a collapsed state
[10:44] <tsdgeos> ok
[10:45] <Saviq> (from the top, of course)
[10:45] <Saviq> tsdgeos, you need to remerge https://code.launchpad.net/~aacid/unity8/unfocusSearchEntryOnHistoryPick with the prerequisite
[10:45] <tsdgeos> so 0 means it's jst collapsed totally
[10:45] <tsdgeos> which is probably an invalid value
[10:45] <tsdgeos> no?
[10:45] <Saviq> tsdgeos, yeah, it is, has to be > 1
[10:45] <Saviq> erm
[10:45] <Saviq> >= 1
[10:46] <Saviq> tsdgeos, so we could say 0 default, but wanted to be more invalid ;)
[10:46] <tsdgeos> Saviq: sure
[10:46] <tsdgeos> Saviq: hmmm, don't get anything on unfocusSearch
[10:46] <tsdgeos> http://paste.ubuntu.com/7893898/
[10:46] <tsdgeos> seems as it's already merged
[10:47] <Saviq> hmm
[10:47] <tsdgeos> what do you get?
[10:47] <Saviq> tsdgeos, here's the order it was merging in https://ci-train.ubuntu.com/job/landing-005-1-build/197/console
[10:47] <Saviq> tsdgeos, maybe we just need to reorder?
[10:47] <tsdgeos> let me see
[10:47] <Saviq> it does complain about criss-cross though
[10:50] <tsdgeos> i guess scopeSearchHintText makes it weird too
[10:50] <tsdgeos> since it also has pageheaderqml
[10:51] <tsdgeos> give me a sec
[10:51] <Saviq> tsdgeos, let's see, I kicked it with explicit order, maybe that'll help
[10:51] <Saviq> tsdgeos, you might want to confirm bug #1313697 ;)
[10:52]  * Saviq must've been annoyed by the issue when I wrote that description :D
[10:53] <tsdgeos> Saviq: is https://code.launchpad.net/~unity-team/unity-scopes-shell/catch-no-search-hint/+merge/228288 part of the silo?
[10:53] <Saviq> tsdgeos, yes
[10:53] <tsdgeos> oki
[10:53] <Saviq> tsdgeos, http://people.canonical.com/~platform/citrain_dashboard/#?q=landing-005
[10:54] <Saviq> tsdgeos, I think it merged fine
[10:54] <Saviq> tsdgeos, with forced order
[10:54] <Saviq> ugh
[10:54] <Saviq> but then
[10:54] <Saviq> https://ci-train.ubuntu.com/job/landing-005-1-build/198/console
[10:54] <Saviq> overview
[10:55] <tsdgeos> arg
[10:55] <Saviq> tsdgeos, you're conflicting with yourself so much ;D
[10:55] <tsdgeos> i know
[10:55] <tsdgeos> stupid thing
[10:55] <Saviq> inception
[10:55] <tsdgeos> i didn't expect us to merge overview with the rest of things at the same time tbh
[10:56] <tsdgeos> want me to merge all the other branches to dash_overview?
[10:56] <tsdgeos> and make it be the last one that depends on the rest?
[10:57] <jgdx> larsu, hey, could you take a look at https://bugs.launchpad.net/gsettings-qt/+bug/1349787 ?
[10:57] <tsdgeos> Saviq: merge or not?
[10:58] <Saviq> tsdgeos, I think so yeah
[10:58] <tsdgeos> ok
[10:59] <tsdgeos> Saviq: but then it'll be quite difficult to review in launchpad
[10:59] <Saviq> tsdgeos, why, set the prereq?
[10:59] <tsdgeos> Saviq: can't set more than one, no?
[10:59] <Saviq> tsdgeos, but the other ones are depending on one another already?
[10:59] <tsdgeos> probably
[10:59] <Saviq> tsdgeos, you just need to prereq on the last one, no?
[10:59] <tsdgeos> ok, let's see
[10:59] <tsdgeos> there's also lp:~aacid/unity8/compile-scopes-v3
[11:00] <Saviq> unless it actually conflicts with two, then you need to chain them...
[11:00] <tsdgeos> which you don't really need in the silo if you have dash overview
[11:00] <tsdgeos> it was supposed to land them before
[11:00] <Saviq> k, can drop
[11:00] <tsdgeos> but no worries
[11:00] <tsdgeos> i'll just merge it too
[11:00] <Saviq> tsdgeos, if it's a conflict I'll drop it from the silo
[11:00] <Saviq> tsdgeos, no problem for me
[11:00] <tsdgeos> Saviq: leave it, i'll merge it
[11:00] <Saviq> tsdgeos, k
[11:06] <tsdgeos> Saviq: can you try again?
[11:06] <Saviq> tsdgeos, did you resubmit?
[11:06] <tsdgeos> push?
[11:06] <tsdgeos> yes
[11:06] <tsdgeos> ah not with the prereq
[11:07] <Saviq> tsdgeos, yeah, please change the prereq
[11:07] <Saviq> tsdgeos, and you probably want to merge it into scopeActivate (no need to resubmit there)
[11:07] <tsdgeos> done
[11:08] <tsdgeos> both
[11:08] <tsdgeos> let's see if it works
[11:08] <Saviq> got it
[11:11] <tsdgeos> gah
[11:11] <tsdgeos> no
[11:11] <tsdgeos> ah no still on it
[11:15] <tsdgeos> pfff
[11:15] <tsdgeos> all fails
[11:16] <tsdgeos> Saviq: failed at the previous error :S
[11:16] <Saviq> tsdgeos, ah crap
[11:16] <Saviq> forgot to force ordering
[11:16] <tsdgeos> Saviq: i'll chain scopeSearchHintText  after lp:~aacid/unity8/showSearchOnSearchQueryChange even if it's not really needed
[11:16] <tsdgeos> and then we have a single chain of things
[11:16] <Saviq> tsdgeos, should be fine now
[11:17] <tsdgeos> ok
[11:17]  * tsdgeos no touchy
[11:17] <Cimi> hello, my name is Andrea Cimitan and I text conflict
[11:21] <tsdgeos> Saviq: honestly i feel that all the other small fixes should go in before the dash_overview, makes it for a smaller and easier to control landing
[11:21] <tsdgeos> but if you prefer all together, all together it is :)
[11:22] <Saviq> tsdgeos, we might still split it out
[11:22] <Saviq> tsdgeos, Text conflict in qml/Dash/GenericScopeView.qml :|
[11:22] <tsdgeos> garg
[11:23] <tsdgeos> i think it's scopeSearchHintText
[11:23] <Saviq> it is
[11:23] <tsdgeos> so i'll make scopeSearchHintText depend on showSearchOnSearchQueryChange
[11:23] <tsdgeos> and then dash_overview on scopeSearchHintText
[11:23] <tsdgeos> and it's all nice and chained
[11:23] <Saviq> tsdgeos, easier → just make hint depend on the end no
[11:23] <Saviq> w
[11:24] <Saviq> tsdgeos, this way you only need to change one MP
[11:24] <tsdgeos> got lost
[11:24] <tsdgeos> make scopeSearchHintText depend on waht?
[11:24] <tsdgeos>  scopeActivatePreview  ?
[11:24] <Saviq> tsdgeos, yes
[11:24] <tsdgeos> ok that too
[11:25] <tsdgeos> but then it's chained after dash_overview forever
[11:25] <tsdgeos> oh well
[11:27] <tsdgeos> Saviq: ok, all pushed and resubmited
[11:35] <tsdgeos> "Silo ready to build packages" :)
[11:37] <tsdgeos> and gcc default is 4.9 now
[11:41] <mterry> mzanetti, does the infographic have any logic to change once the day/month changes?
[11:42] <mzanetti> mterry: I don't think so... I think I reported a bug for that a while back
[11:42] <mzanetti> mterry: not sure what happened in the meantime though
[11:44] <Saviq> tsdgeos, merged, building
[11:44] <Saviq> lunch
[11:46] <tsdgeos> mhr3: pete-woods|lunch: Saviq: what do you think of "threshold-index" instead of     "collapsed-widgets": 2 ?
[11:50] <facundobatista> Hola!
[11:51] <mzanetti> o/
[12:39] <larsu> jgdx: yeah sure
[13:00] <seb128> jgdx, hey, I saw you took over bug #1219793
[13:00] <seb128> jgdx, did you notice that there are some merge requests up for reset which are waiting for review?
[13:01] <seb128> jgdx, e.g https://code.launchpad.net/~laney/ubuntu-system-settings/reset-api/+merge/208661
[13:01] <seb128> jgdx, you might want to review that/base your work on it
[13:02] <jgdx> seb128, hey, looking
[13:02] <seb128> jgdx, it might be slightly orthogonal to the launcher specific case, but would still be nice to get reviewed
[13:13] <jgdx> seb128, right. Looks nice. It's of course very relevant to the second reset button. Do you know if there's a bug for that?
[13:13] <jgdx> seb128, cause that would be completely dependant on ^ that branch, as well as implementing the reset function in all plugins?
[13:13] <seb128> jgdx, bug for what?
[13:13] <jgdx> seb128, "Reset all system settings"
[13:13] <seb128> right
[13:15] <seb128> jgdx, no bug afaik
[13:16] <seb128> there is the bug you pointed and bug #1292932
[13:18] <tsdgeos> Saviq: we have a big problem with qmluitests not picking up all tests that fail
[13:18] <tsdgeos> we really need someone to have a  look at that
[13:18] <tsdgeos> otherwise we may as well not have or run the tests
[13:30] <Saviq> tsdgeos, right, I'll talk to fginther today
[13:30] <tsdgeos> Saviq: like trunk has 2 tests failing
[13:30] <tsdgeos> and we don't see them
[13:30] <tsdgeos> actually 3 i think
[13:31] <Saviq> tsdgeos, it's weird 'cause I run them locally and have no fails...
[13:32] <tsdgeos> Saviq: well xvfbtestListViewWithPageHeaderSection fails for sure
[13:32] <tsdgeos> at least i can reproduce and makes sense since it has leftovers from old headearless code
[13:32] <tsdgeos> proposing a MR for that one soon
[13:33] <Saviq> tsdgeos, think it only affects non-qml tests?
[13:33] <tsdgeos> maybe
[13:33] <tsdgeos> it's this and the cardcreator
[13:33] <Saviq> tsdgeos, does it write out an .xml file?
[13:34] <tsdgeos> sure
[13:34] <tsdgeos> -o /home/tsdgeos_work/phablet/unity8/unity8/builddir/ListViewWithPageHeaderSectionTest.xml,xunitxml
[13:35] <Saviq> well, is it there? does it have the fail reported?
[13:36] <tsdgeos> there == where?
[13:36] <Saviq> tsdgeos, /home/tsdgeos_work/phablet/unity8/unity8/builddir/ListViewWithPageHeaderSectionTest.xml
[13:37] <Saviq> whoa it takes a long time on xvfb...
[13:38] <tsdgeos> well 5 secs for each test
[13:38] <tsdgeos> it's doing tryCompare on something bad
[13:41] <tsdgeos> so fixing it will also make our CI faster :D
[13:43] <tsdgeos> https://code.launchpad.net/~aacid/unity8/fixListViewWithPageHeaderSectionTest/+merge/228679
[13:43] <tsdgeos> Saviq: what do you think of "threshold-index" instead of "collapsed-widgets": 2 ?
[13:44] <Saviq> tsdgeos, not that much better... mhr3 ↑
[13:44] <Saviq> tsdgeos, fwiw testListViewWithPageHeaderSection just hangs here...
[13:44] <tsdgeos> well beter than using collapsed which is consfusing since everything is actaully collapsed
[13:44] <mhr3> yea, not really more meaningful
[13:45] <tsdgeos> Saviq: ?
[13:45] <tsdgeos> Saviq: what are you running?
[13:45] <tsdgeos> Saviq: what are you running?
[13:45] <Saviq> tsdgeos, /home/michal/dev/canonical/unity8/repo/builddir/tests/plugins/Dash/ListViewWithPageHeaderSectionTestExec
[13:45] <tsdgeos> don't do that
[13:45] <tsdgeos> we have make targets for a reason
[13:46] <Saviq> tsdgeos, I started with a target first :P
[13:46] <tsdgeos> not sure if in this specific case it makes a difference or not
[13:46] <Saviq> tsdgeos, hanged just the same
[13:46] <tsdgeos> Saviq: are you sure it's not just the tryCompares being slow?
[13:46] <Saviq> tsdgeos, nothing happens for a minute...
[13:46] <tsdgeos> worksforme
[13:46] <tsdgeos> :D
[13:47] <tsdgeos> give me one hour so the run of test works
[13:47] <tsdgeos> and i can tell you if the file is there or not
[13:47] <Saviq> tsdgeos, so, the qmluitests job doesn't even run that test
[13:47] <tsdgeos> they do
[13:47] <tsdgeos> what you mean they don¡t
[13:48] <Saviq> ah n o
[13:48] <Saviq> it does
[13:50] <Saviq> tsdgeos, oh ok, so it takes so long because it fails all the time, and takes 5s or so to do the tryCompare, right?
[13:50] <tsdgeos> yes
[13:50] <Saviq> times 180
[13:51] <Saviq> 15 mins, cool beanz ;P
[13:52] <tsdgeos> yep
[13:52] <tsdgeos> approve the fix ;)
[14:19] <tsdgeos> Saviq: mhr3: pete-woods: when triggering a preview widget inside a collapsible widget, what do i do?
[14:19] <mhr3> the ids still need to be unique, so nothing special really
[14:20] <Saviq> tsdgeos, yeah, the id of the inner widget needs to be passed
[14:21] <tsdgeos> mhr3: well seems pretty special to me, until now there was just a widget what could be activated
[14:21] <tsdgeos> now you want the inner? the outer? both?
[14:21] <mhr3> tsdgeos, why would i care about the collapsible?
[14:22] <tsdgeos> i do not know
[14:22] <mhr3> it's just a container
[14:22] <tsdgeos> you care about things i don't always understand ;)
[14:22] <mhr3> :)
[14:23] <tsdgeos> ok, so inner widget out
[14:23] <mhr3> yea
[14:23] <mhr3> out as in, that's the one passed to the scope
[14:23] <tsdgeos> yes
[14:23] <tsdgeos> Saviq: the file is created and yes it contains the errors
[14:24] <Saviq> tsdgeos, yeah I saw that, so for some reason it's not picked up as a failure by jenkins
[14:28] <elopio> Saviq: you said I should be able to launch the dash-app with ubuntu-app-launch. But ubuntu-app-launch unity8-dash doesn't work.
[14:28] <elopio> am I doing it wrong?
[14:29] <Saviq> mzanetti, can you help elopio ↑?
[14:29] <mzanetti> sure
[14:29] <mzanetti> err, actually no... should work :P
[14:30] <mzanetti> tbh I've never used ubuntu-app-launch
[14:30] <tsdgeos> Saviq: so we are removeing expand/collapse habilities from PreviewTextSummary?
[14:30] <mzanetti> elopio: but why aren't you using upstart?
[14:30] <Saviq> tsdgeos, yes
[14:30] <tsdgeos> Saviq: i.e. if you need expand/collapse you need to use PreviewTextSummary + PreviewExpandable
[14:30] <tsdgeos> ok
[14:30] <elopio> mzanetti: we launch all the apps with ubuntu-app-launch. So that way we could reuse some of the helpers from autopilot.
[14:30] <Saviq> mzanetti, u-a-l is upstart ;)
[14:30] <elopio> I can do initctl start unity8-dash, but that will be a little more code.
[14:30] <mzanetti> well... it does *something* different
[14:31] <Saviq> elopio, but yeah, it's a custom upstart job
[14:31] <mzanetti> elopio: that's what happens in reality
[14:31] <mzanetti> but I don't see why it shouldn't be possible to use ual. Maybe there's some flag in the .desktop file?
[14:32] <mzanetti> maybe the NoDisplay=true prevents it or something
[14:32] <mzanetti> we also don't show it in the clickscope etc...
[14:42] <elopio> mzanetti: well, but don't worry about that now. I can launch it with testability now and you probably have other things to solve.
[14:42] <elopio> it seems that it will be really easy for the 20 tests in test_emulators.py.
[14:43] <elopio> the rest may be a bit of a problem.
[14:43] <mzanetti> elopio: well, I'm really just here any more to get as much as possible fixed in that dash-as-app branch so it can hopefully land while I'm away
[14:43] <mzanetti> well, with a bit luck QtComp won't have landed by then anyways, so...
[14:43] <mzanetti> greyback: ^:P
[14:44] <greyback> mzanetti: don't, just don't :P
[14:44] <mzanetti> :D
[14:44] <elopio> greyback: did you agree with thomi in a solution for the autopilot globalRect ?
[14:44] <mzanetti> greyback: trying it the other way round... turns out me being optimistic doesn't work
[14:44] <mzanetti> maybe its faster if I think it'll never land
[14:45] <greyback> elopio: I implemented a workaround for now, a discussion was opened in the Mir mailing list, from which I don't think a solution was agreed.
[14:45] <greyback> mzanetti: reverse psychology, that'll never work!
[14:45] <mzanetti> greyback: maybe you should just stop searching for more issues
[14:46] <elopio> ok, so no need to update tests for now. That's good, for me at least :)
[14:46] <greyback> mzanetti: oh like it's my fault now, is it?!
[14:46] <mzanetti> :D
[14:50] <tsdgeos> Saviq: do we have any visuals for the +/- of the expandable?
[15:02] <elopio> mzanetti: the unity geometry args are not going to work, right?
[15:03] <mzanetti> elopio: no, they aren't.
[15:03] <mzanetti> elopio: do you require that?
[15:03] <elopio> mzanetti: I have a way to resize a window, but is not as nice.
[15:04] <elopio> so, I don't require it to make the tests pass
[15:04] <elopio> I will probably require at some point a way to tell the size of the window for all apps.
[15:04] <tsdgeos> Saviq: mikenagle: i understand https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/store/3-previews/01_App_preview_04.jpg?attachauth=ANoY7cqnE02Er8KSSP_7r8w1JGFcnzXJzKqoqi1h5M_pQ7ASKbu2QUyHCiS1-PQPWoUNO1tTMXtUmUk--3nN7r1v1nqUimVSUr8-uxgUwtKH6R1UuHn7MP7A0S1gtQdeqvvjpd_5XYWrMaLlrrtmuqvIvnQ7Vt8fw-iEMR8KwJl_KRyAENCSjL31UtbgbKIVDiMk4M7dKMH7RyK73HdgMYDEGBW8IVQ8iexnz81U4W1KeFUfgwSTZT7gXO4KW5uiS2-3EZCXzlGh&attredirects=0 is old
[15:04] <tsdgeos> since it shows see more and not the expand?
[15:04] <mzanetti> elopio: fair point, yes
[15:05] <Saviq> tsdgeos, yes
[15:05] <mzanetti> elopio: well, let me know if I should add it.
[15:05] <Saviq> tsdgeos, https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/toolkit/14-previews/Scope%20Toolkit%20-%20Preview%20Widgets%20v1.jpg
[15:05] <Saviq> tsdgeos, that's the only recent visual I think
[15:06] <tsdgeos> Saviq: any idea what i should use for the +/- icons
[15:06] <tsdgeos> ?
[15:06] <Saviq> tsdgeos, I'll get you assets
[15:06] <tsdgeos> plz
[15:07] <elopio> mzanetti: not now. After RTM I'll ask around a way to do it and ideally it should not be specific to unity or mir.
[15:08] <mzanetti> elopio: ack. +1 on that.
[16:09] <Saviq> tsdgeos, found out why the tests don't report errors, the .xml files get overwritten
[16:09] <Saviq> -o /home/michal/dev/canonical/unity8/repo/builddir/Test.xml,xunitxml
[16:09] <Saviq> tsdgeos, yup, add_binary_qml_test broken
[16:10] <Saviq> tsdgeos, can you push http://paste.ubuntu.com/7896166/ to your fix test branch please
[16:11] <tsdgeos> then i'll have to fix more things :d
[16:11] <tsdgeos> doing
[16:13] <Saviq> tsdgeos, at least we'll know which
[16:15] <tsdgeos> Saviq: pushed
[16:16] <Cimi> dednick, https://bugs.launchpad.net/unity8/+bug/1349921
[16:16] <tsdgeos> tbh there simply should not be any Empty!
[16:27] <elopio> Saviq: looking at the updates I had to do to get the Dash tests working, they don't conflict with my three branches with autopilot helpers.
[16:27] <elopio> can we get them landed?
[16:28] <elopio> oh well, they will conflict. Nevermind, I'll finish this first.
[16:29] <elopio> it's just a little overlapping.
[16:31] <Saviq> elopio, yeah, we have a lot of that I'm afraid...
[16:31] <elopio> yes, I just got scared for this to land after next week.
[16:32] <elopio> that will mean a lot more manual testing that what we should do. But well, I'll just hurry with this so autopilot tests are not a blocker.
[18:17] <elopio> mzanetti: what kind of tests do you have for the integration between unity and the dash?
[18:18] <mzanetti> elopio: I don't think there is one...
[18:19] <mzanetti> elopio: there was one qmltest which I obviously had to split and mock out the communication part
[18:19] <mzanetti> elopio: I guess it would make sense to have an AP test for that
[18:19] <elopio> mzanetti: so currently the only thing that test the integration are the application lifecycle test
[18:19] <elopio> we discussed about moving them out of the unity project, but for now I'll try to make them run at least on the phone.
[18:19] <mzanetti> elopio: I don't think they test that
[18:20] <elopio> mzanetti: well, at least a little. They test that you can launch an app and that it gets the focus
[18:20] <elopio> an that when you swipe it out, the focus goes back to the dash.
[18:21] <mzanetti> elopio: right, but actually thats all what's happening in terms of communication between those two
[18:21] <elopio> mzanetti: so do you agree to keep them?
[18:22] <mzanetti> elopio: yeah, those make sense to stay around
[18:23] <mzanetti> elopio: at least as long dash and shell are in the same repo
[18:23] <mzanetti> I could imagine in the future we'd even split the repos. but that's far away in the future if happening at all
[18:23] <elopio> right. I'd like that.
[23:44] <Saviq> mzanetti, dude, go have your holidays and stop throwing bugs at unity8 that have little to do with it ;P
[23:45] <mzanetti> Saviq: I flashed my working phone for Heike to dogfood over the week
[23:45] <mzanetti> Saviq: there's a looot of work to do still :D
[23:45] <Saviq> mzanetti, why throwing everything at unity8 though :P
[23:46] <mzanetti> Saviq: which one in particular?
[23:46] <mzanetti> atm I'm reporting to online accounts
[23:46] <Saviq> mzanetti, no you're not
[23:46] <Saviq> mzanetti, the three you reported went to unity8
[23:46] <Saviq> mzanetti, remember, you press "report a bug" on the unity8 page, it reports it for unity8
[23:47] <mzanetti> Saviq: yeah... but the first three are related to unity8, no?
[23:47] <Saviq> mzanetti, the accounts ones? not at all
[23:47] <mzanetti> well, they're probably also related to online accounts
[23:47] <Saviq> mzanetti, unity8 has no idea about accounts
[23:48] <mzanetti> Saviq: but the error messages are displayed within unity
[23:48] <mzanetti> so maybe OA doesn't give you all related informations, but in the end we show the wrong thing
[23:48] <Saviq> mzanetti, if a 404 error message is displayed in your browser, does it mean there's a bug in it?
[23:48] <mzanetti> Saviq: that's the thing, its not a 404 error
[23:48] <Saviq> mzanetti, it's the click scope that tells us what to display
[23:49] <mzanetti> ah... hmm, right
[23:49] <Saviq> mzanetti, dash is oblivious
[23:49] <mzanetti> its the click scope
[23:49] <mzanetti> will reassign
[23:50] <Saviq> mzanetti, already did
[23:50] <Saviq> bug #1350090 bug #1350093 bug #1350096
[23:51] <Saviq> the last one was unity8 as well, which totally has nothing to do with it
[23:52] <mzanetti> Saviq: depends... might be click scope or download manager as well
[23:52] <mzanetti> Saviq: because OA setup isn't launched in that case
[23:53] <Saviq> how else is the account created?
[23:53] <Saviq> nothing else knows how to talk to U1
[23:53] <mzanetti> Saviq: it is created there, but when you then close it and try to install something with the already set up account
[23:53] <mzanetti> then you're in the scope, the scope thinks everything is fine and fails with a Network error
[23:53] <Saviq> mzanetti, right, so multiple bugs, really
[23:54] <mzanetti> yeah
[23:54] <mzanetti> well
[23:54] <Saviq> same bug, multiple projects
[23:54] <mzanetti> yes
[23:54] <Saviq> nothing in unity8 still ;)
[23:54] <mzanetti> yeah... you're right... sorry
[23:55] <mzanetti> Saviq: this one is tricky too:
[23:55] <mzanetti> creating an account with a german phone leads to a english confirmation mail which heike did barely understand
[23:55] <mzanetti> (I wasn't going to throw this at unity :D )
[23:56] <Saviq> ;)
[23:56] <mzanetti> but not sure if OA is the one here
[23:56] <Saviq> yeah it is
[23:56] <Saviq> it needs to tell U1 what language the account was created with