| mzanetti | Saviq: hah. now I have one for unity for real, I think... | 00:09 |
|---|---|---|
| mzanetti | well, not sure, might be click-scope again... | 00:10 |
| kgunn | how are you guys awake | 00:13 |
| Saviq | kgunn, coffee ;) | 00:14 |
| Darth-Apple | Coding stimulates insomnia | 00:15 |
| Saviq | that, too | 00:16 |
| Saviq | on that note | 00:16 |
| Saviq | o/ | 00:16 |
| Saviq | mzanetti, have a good time, see you in a week | 00:16 |
| mzanetti | Saviq: thanks. see you in a week | 00:17 |
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| jgdx | larsu, thanks for looking at it. I have clarified it with a comment. | 08:24 |
| tsdgeos | why is https://code.launchpad.net/~aacid/unity8/dash_overview/+merge/226449 marked as superseded? | 08:43 |
| tsdgeos | Saviq: ↑ any idea? | 08:43 |
| tsdgeos | ah right | 08:43 |
| * tsdgeos stupid | 08:43 | |
| tsdgeos | https://code.launchpad.net/~aacid/unity8/dash_overview/+merge/228649 is the correct one | 08:43 |
| tsdgeos | didn't we have links from old to new? | 08:44 |
| tsdgeos | Saviq: what do you mean "1.png: no bottom edge hint" ? | 08:51 |
| Saviq | tsdgeos, if you resubmitted there is a link | 08:53 |
| Saviq | tsdgeos, https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/dash-overview/hint-expanded.png | 08:54 |
| Saviq | tsdgeos, see the little tab at the bottom | 08:54 |
| tsdgeos | what | 08:54 |
| tsdgeos | that's new | 08:54 |
| tsdgeos | that wasn't there at all | 08:54 |
| tsdgeos | are we going to show that thing 100% of the time? | 08:54 |
| tsdgeos | is going to be a bit annoying no? | 08:54 |
| Saviq | tsdgeos, have a look at dialer or messaging, they show it on startup and then slide down a bit, I'll ask if that's what we should do | 08:56 |
| Saviq | tsdgeos, actually no, it's supposed to go in/out with the page header... | 09:00 |
| Saviq | tsdgeos, it's fine to be binary shown/hidden, but should be on screen whenever header is on screen and vice versa | 09:01 |
| Saviq | tsdgeos, and yeah, it was there for a long time ;) | 09:01 |
| * Saviq goes to ask how will that behave with the see less footer... | 09:02 | |
| tsdgeos | given taht google docs is a mess and it doesn't have proper history i can't prove it | 09:02 |
| tsdgeos | but i sincerely doubt so | 09:02 |
| tsdgeos | and honestly i can't fiigure out a nice interaction for it based on what you said | 09:03 |
| tsdgeos | are we going to do no animation show/hide depending if the header is somewhat visiible or not? | 09:03 |
| tsdgeos | that's going to be crap | 09:03 |
| tsdgeos | anyway, let's do it, where's the image for it? | 09:04 |
| Saviq | tsdgeos, let's wait for them to complete the visual review | 09:07 |
| tsdgeos | ok | 09:07 |
| tsdgeos | so do nothing for now then | 09:07 |
| tsdgeos | Saviq: btw https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/dash-overview/hint-expanded.png?attachauth=ANoY7coBsuHCr4FUnVZy-scE64bZHg8M6LG4PrLmgwzW5DG4AZS_h06hfaJC_5N6ouvEyGrLGjS8BtGL6oY-l0LO6XMOmjNx2ebflFHytgEme2KYjq1L-nWy65RO3BMbIdaYalbGVXnhxaAtaTxAAr0MLGDr3MAUHYX-LA43dZIJAOPvYXlmu_X6Tb0QsbcLmq4feBztKf61TxmdehwbQfxXykOCAlGgPOFYAyIPUKkPAHwPFOULfXvRPwybcpajZ4bPkuMNwNrI&attredirects=0 doesn't have the gradient at the | 09:08 |
| tsdgeos | beginning/end of categories | 09:08 |
| Saviq | tsdgeos, yeah, I know | 09:08 |
| Saviq | tsdgeos, gradient's supposed to go away anyway | 09:08 |
| Saviq | tsdgeos, but yeah, I'll find out why there isn't the divider at all | 09:09 |
| tsdgeos | Saviq: besides, docu says "The hint is always visible - never hidden or smaller (unlike hints used in apps)" | 09:10 |
| Saviq | tsdgeos, yeah, old, of course... | 09:10 |
| tsdgeos | which kind of disagrees with the shown when the header is shown | 09:10 |
| Saviq | tsdgeos, the "hide on scroll" was a req from above | 09:11 |
| Saviq | tsdgeos, I'll ask Mike to clarify on the page | 09:11 |
| tsdgeos | Saviq: also i don't think we should change ratio of cards at all in Favorites | 09:15 |
| tsdgeos | now they have exactly the ratio the dash has | 09:15 |
| tsdgeos | so it's the more natural and correct ratio you can expect there | 09:16 |
| tsdgeos | but i'm not a designer | 09:16 |
| Saviq | tsdgeos, TBH it doesn't feel like they do, they're too wide | 09:17 |
| tsdgeos | well the fact that i can put stuff from the dash inside them without any stretch or crop disagrees with your feeling | 09:18 |
| tsdgeos | ah wait | 09:20 |
| tsdgeos | that may just be in tryDash | 09:20 |
| tsdgeos | real thing uses images that may have the wrong sizes and break stuff | 09:20 |
| tsdgeos | i'll wait for silo 5 to build | 09:20 |
| larsu | jgdx: no problem. Patch coming in a bit | 09:34 |
| jgdx | larsu, thanks | 09:35 |
| tsdgeos | Saviq: i've installed silo5 | 09:37 |
| tsdgeos | and used a ruler to calculate the ratios | 09:37 |
| tsdgeos | well it's the only possible way to make the thing fade in properly | 09:46 |
| tsdgeos | no idea how am i supposed to fade in two things that have different sizes | 09:46 |
| Saviq | tsdgeos, somewhat simple - preserveaspectcrop or stretch | 09:49 |
| Saviq | tsdgeos, but I understand it's not that simple when you make it happen | 09:49 |
| Saviq | no Mike, gotta wait | 09:51 |
| tsdgeos | Saviq: there's something weird with qtcomp (i think) Ctrl+c no longer shutdowns unity8 | 09:52 |
| Saviq | tsdgeos, yeah, I saw that | 09:52 |
| Saviq | tsdgeos, do you get console output at all? | 09:52 |
| tsdgeos | neither | 09:52 |
| tsdgeos | start doesn't finish | 09:53 |
| tsdgeos | so the tail does not kick in | 09:53 |
| tsdgeos | that is pretty annoying | 09:56 |
| tsdgeos | can't debug anything anymore with printf | 09:56 |
| Saviq | tsdgeos, copy a unity8.conf in your .config/upstart without "expect stop" | 09:58 |
| Saviq | tsdgeos, or pkill -SIGSTOP unity8 | 09:58 |
| tsdgeos | ok | 09:59 |
| tsdgeos | is that a workaround or a fix? | 09:59 |
| mhr3 | Saviq, here's the interesting stuff http://bazaar.launchpad.net/~unity-team/unity-api/scopes-v4/revision/159 | 10:02 |
| Cimi | pete-woods, all good with infographics? | 10:07 |
| pete-woods | Cimi: still not got the thing reviewed :( | 10:08 |
| greyback | tsdgeos: https://code.launchpad.net/~gerboland/unity8/fix-run.sh-script/+merge/228817 - fancy giving it a whirl? | 10:37 |
| tsdgeos | greyback: sure | 10:38 |
| greyback | thanks | 10:38 |
| Saviq | tsdgeos, fyi, we're going for aspect ratio to match reality and assets that can cope with that | 10:40 |
| tsdgeos | Saviq: so no change in my side? | 10:40 |
| Saviq | tsdgeos, not in Favourites | 10:40 |
| Saviq | tsdgeos, but we need to force the aspect ratio in All and when searching | 10:41 |
| tsdgeos | why? | 10:41 |
| Saviq | tsdgeos, because otherwise they look different in Fav than in All | 10:41 |
| tsdgeos | they do in non search too, no? | 10:41 |
| tsdgeos | Saviq: or you mean when non searching? | 10:42 |
| Saviq | tsdgeos, that's why I said "All *and* when searching" | 10:42 |
| Saviq | tsdgeos, basically wherever there's a category with scopes, we need to force aspect ratio to reality | 10:42 |
| tsdgeos | i am confused now | 10:43 |
| Saviq | tsdgeos, wanna mumble? | 10:43 |
| tsdgeos | sure | 10:43 |
| facundobatista | Hola | 10:46 |
| === MacSlow is now known as MacSlow|lunch | ||
| tsdgeos | greyback: there's two qmluitests failing in trunk, can you fix them too? | 11:06 |
| tsdgeos | greyback: testRunningApplicationsGrid and testShell | 11:06 |
| greyback | tsdgeos: testRunningApplicationsGrid is being removed soon (MR approved) | 11:07 |
| greyback | that testShell test, I recall mzanetti telling me it'll be fixed by dash-as-an-app | 11:08 |
| tsdgeos | ok | 11:08 |
| greyback | i.e. there's no point fixing it as the code will change soon | 11:08 |
| tsdgeos | well there's the "let's make sure tests pass so if one fails i know it's my fault and not something that was there already" | 11:09 |
| tsdgeos | but yeah | 11:09 |
| tsdgeos | i understand what you mean | 11:09 |
| === alan_g is now known as alan_g|lunch | ||
| tsdgeos | Saviq: wow, much difference | 11:23 |
| tsdgeos | when using the ShaderEffectSource :D | 11:23 |
| tsdgeos | Saviq: i'll commit it so you can rebuild the ppa | 11:23 |
| tsdgeos | commited | 11:28 |
| === Estilanda_ is now known as Estilanda | ||
| tsdgeos | Saviq: any luck on my assets for +/- for the Expandable PReview Widget? | 11:46 |
| Saviq | tsdgeos, I feel they should come from the theme | 11:50 |
| tsdgeos | i feel the same | 11:50 |
| tsdgeos | but there's nothing i could find | 11:50 |
| Saviq | tsdgeos, let me ping Mathieu | 11:51 |
| === MacSlow|lunch is now known as MacSlow | ||
| === _salem is now known as salem_ | ||
| tsdgeos | cwayne: i just dropped that text in our test and still works :/ | 13:10 |
| tsdgeos | do you have a scope we can use? | 13:10 |
| cwayne | tsdgeos: just attached a click to the bug | 13:11 |
| === alan_g|lunch is now known as alan_g | ||
| tsdgeos | cwayne: i should probably know this, but cna i do something with that in the desktop? is it phone only? and how do i install it | 13:13 |
| * tsdgeos hides | 13:13 | |
| cwayne | tsdgeos: heh, hm, not sure actually, its compiled for armhf | 13:13 |
| tsdgeos | oh right | 13:14 |
| tsdgeos | silly me | 13:14 |
| cwayne | i could get an i386 one to use with the emulator if that's helpful? | 13:14 |
| tsdgeos | nah i'll just use the phone | 13:14 |
| tsdgeos | how do i install it? | 13:14 |
| cwayne | adb push it, then sudo -iu phablet, then pkcon install-local path-to.click | 13:16 |
| tsdgeos | sudo click install | 13:16 |
| tsdgeos | seems that did the trick | 13:16 |
| mhr3 | Saviq, does this look reasonable? https://code.launchpad.net/~unity-team/unity/split-schema-pkg/+merge/228845 | 13:20 |
| tsdgeos | cwayne: you're thing does not show up in the overview | 13:23 |
| tsdgeos | can't reach it | 13:24 |
| cwayne | tsdgeos: is there something different we need to do to get it in the overview? | 13:24 |
| cwayne | i see it in the scopes scope still | 13:24 |
| tsdgeos | nope :/ | 13:25 |
| tsdgeos | maybe it's just not running | 13:25 |
| cwayne | hm, i even just installed/launched it from the overview | 13:26 |
| Saviq | tsdgeos, + / - will be added to theme | 13:26 |
| cwayne | tsdgeos: try a reboot maybe? :/ | 13:27 |
| tsdgeos | cwayne: didn' help | 13:28 |
| tsdgeos | Saviq: ok, name? | 13:28 |
| Saviq | tsdgeos, you should also be able to export UNITY_SCOPES to force it to show up | 13:28 |
| Saviq | tsdgeos, TBD | 13:28 |
| cwayne | tsdgeos: what does 'sudo -iu phablet click list' show | 13:29 |
| Saviq | tsdgeos, tiheum's just finding out | 13:29 |
| popey | i always use pkcon-install, never click install.... | 13:29 |
| cwayne | oh tsdgeos did you just do click install? | 13:30 |
| tsdgeos | ah | 13:30 |
| tsdgeos | maybe was installed somewhere else | 13:30 |
| cwayne | well click install doesn't do the full bits | 13:30 |
| cwayne | youd need to do a click register as well | 13:31 |
| popey | adb push foo.click /tmp ; phablet-shell ; pkcon install-local /tmp/foo.click | 13:31 |
| popey | ^ do that | 13:31 |
| cwayne | but pkcon install-local does all of it | 13:31 |
| popey | phablet-shell > adb shell | 13:31 |
| tsdgeos | cwayne: ok, now | 13:31 |
| cwayne | popey++ | 13:31 |
| tsdgeos | cwayne: ok, can reproduce there | 13:32 |
| cwayne | whew, im not crazy! | 13:32 |
| cwayne | well, for this particular reason at least | 13:32 |
| tsdgeos | :D | 13:33 |
| cwayne | tsdgeos: let me know if you need any more debug info or the source or anything | 13:35 |
| cwayne | it is written in go, I hope that's not what's causing it :/ | 13:35 |
| Saviq | tsdgeos, "view-expand", "view-collapse" | 13:37 |
| tsdgeos | Saviq: ok | 13:37 |
| Saviq | cwayne, are you maybe passing us rich text (meaning there's html tags and stuff)? | 13:38 |
| Saviq | hmm I wonder if \r\n causes it... | 13:39 |
| cwayne | Saviq: yea | 13:39 |
| cwayne | i don't think there's any tags, but there's definitely \r\n all over the damn place | 13:39 |
| === pete-woods is now known as pete-woods|lunch | ||
| tsdgeos | cwayne: all your fault | 13:44 |
| cwayne | usually is | 13:44 |
| tsdgeos | go is evil | 13:44 |
| cwayne | lol | 13:44 |
| tsdgeos | cwayne: don't use a header to show text | 13:44 |
| tsdgeos | use text | 13:44 |
| tsdgeos | which is the thing you should use to use text | 13:44 |
| tsdgeos | showing all the text in the "subtitle" propety of a header | 13:45 |
| tsdgeos | is kind of evil | 13:45 |
| === pete-woods|lunch is now known as pete-woods | ||
| cwayne | holy crap i do not remember doing that, mustve been whatever scope i copied it from | 13:46 |
| * cwayne feels like an idiot | 13:46 | |
| tsdgeos | it's actually kind of funny | 13:46 |
| tsdgeos | since you're using text for what technically would be the header | 13:47 |
| tsdgeos | and header for what is the text | 13:47 |
| cwayne | that was a workaround because the title kept getting truncated tsdgeos | 13:48 |
| tsdgeos | right | 13:48 |
| tsdgeos | since title doesn't support wrapping | 13:49 |
| tsdgeos | :D | 13:49 |
| cwayne | a victor-suggested-workaround | 13:49 |
| cwayne | hah | 13:49 |
| tsdgeos | you could have thought the same here ;) | 13:49 |
| cwayne | well, i owe you at least 6 beers for putting up with my stupidity then :) | 13:49 |
| tsdgeos | it's ok, we all make mistakes | 13:49 |
| tsdgeos | team work fixes that! | 13:50 |
| cwayne | :P | 13:50 |
| Saviq | mhr3, v | 13:51 |
| Saviq | https://code.launchpad.net/~aacid/unity8/clickScopeForceArtShapeSize/+merge/228505 | 13:51 |
| === pete-woods is now known as pete-woods|lunch | ||
| tsdgeos | Saviq: did expandable, going to do table now | 14:19 |
| Saviq | tsdgeos, coolz | 14:22 |
| cwayne | tsdgeos: a table preview widget? | 14:28 |
| tsdgeos | cwayne: yes | 14:28 |
| cwayne | that's perfect, a scope I'mw riting right now is in desperate need of that | 14:29 |
| cwayne | Saviq: hey, I've noticed on a latest updated image, when I search in a scope that has a Pageheader color or image, it overruns the header and spills down into the body, known issue? | 14:52 |
| tsdgeos | cwayne: do you have a screenshot? | 14:56 |
| cwayne | tsdgeos: http://people.canonical.com/~cwayne/overflow.png | 14:57 |
| tsdgeos | hmmmm | 14:57 |
| tsdgeos | yeah that' a bug | 14:58 |
| tsdgeos | cwayne: can you file a bug? | 14:58 |
| cwayne | sure thing | 14:59 |
| tsdgeos | tx | 14:59 |
| Saviq | cwayne, yeah, bug | 15:05 |
| cwayne | Saviq: tsdgeos: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1350398 | 15:06 |
| ubot5 | Launchpad bug 1350398 in unity8 (Ubuntu) "Pageheader.Background overflows" [Undecided,New] | 15:06 |
| MacSlow | Saviq, the hangout was very laggy today on my side | 15:11 |
| MacSlow | Saviq, it unmuting without my action was a bit odd | 15:11 |
| === pete-woods|lunch is now known as pete-woods | ||
| Saviq | tsdgeos, https://code.launchpad.net/~tiheum/ubuntu-themes/suru-icons/+merge/226325 | 15:28 |
| tsdgeos | Saviq: nice | 15:28 |
| Saviq | tsdgeos, I stole the background bug from you, if you wanna fix before I get to it - please | 15:33 |
| tsdgeos | Saviq: i fixed it already | 15:33 |
| tsdgeos | er what happened | 15:34 |
| tsdgeos | right | 15:34 |
| tsdgeos | you stole me the bug | 15:34 |
| tsdgeos | and i linked it to the wrong bug | 15:34 |
| tsdgeos | being "first bug in my list is the bug i want to fix" | 15:34 |
| tsdgeos | and now i was totally confused | 15:35 |
| Saviq | :) | 15:35 |
| tsdgeos | so i'll steal it again | 15:36 |
| tsdgeos | Saviq: see if you can get from Mike the numbers of lines a collapsed text/table should show | 15:37 |
| Saviq | tsdgeos, he's in a mtg, but let's go for 3 for now | 15:38 |
| Saviq | tsdgeos, and I'll try and get an answer from him when he's out | 15:39 |
| tsdgeos | yeah i was using thati | 15:39 |
| tsdgeos | it's what wireframes use | 15:39 |
| Saviq | tsdgeos, yeah, go with that | 15:40 |
| tsdgeos | Saviq: the pacakges from https://code.launchpad.net/~tiheum/ubuntu-themes/suru-icons/+merge/226325 are lost? | 15:42 |
| tsdgeos | i'd like to use them | 15:42 |
| Saviq | tsdgeos, it should rebuild soon | 15:42 |
| tsdgeos | Saviq: still i don't know where to get them from the jobs | 15:42 |
| Saviq | tsdgeos, ah no it won't, 'cause it's top-acked already | 15:42 |
| tsdgeos | ok | 15:43 |
| Saviq | tsdgeos, I'll kick a build, mo | 15:43 |
| tsdgeos | just wait for this to land then? | 15:43 |
| Saviq | tsdgeos, http://s-jenkins.ubuntu-ci:8080/job/ubuntu-themes-ci/76/console | 15:43 |
| Saviq | tsdgeos, but yeah, we' | 15:43 |
| Saviq | ll land this with your branch | 15:43 |
| tsdgeos | sure i just want to be able to see them | 15:45 |
| tsdgeos | and seems building my own package takes a good while more than i expected | 15:45 |
| tsdgeos | something even crashed | 15:45 |
| Saviq | tsdgeos, right, because it optipngs them... total waste of builders time | 16:01 |
| tsdgeos | +1 | 16:02 |
| Saviq | tsdgeos, you can stop it by exporting NO_PNG_PKG_MANGLE=1 | 16:02 |
| tsdgeos | ultra tired today, sharp eod | 16:02 |
| Saviq | tsdgeos, I've that in .profile | 16:02 |
| Saviq | tsdgeos, o./ | 16:02 |
| === gatox is now known as gatox_lunch | ||
| Saviq | mterry, bug #1350348 btw | 16:24 |
| ubot5 | bug 1350348 in unity-system-compositor (Ubuntu) "Spinner not shown on shutdown" [Undecided,New] https://launchpad.net/bugs/1350348 | 16:24 |
| greyback | dandrader: time for a quick review? https://code.launchpad.net/~gerboland/qtmir/fix-unfocus-notification/+merge/228901 | 16:44 |
| * dandrader checks | 16:44 | |
| greyback | kgunn: ^^ | 16:45 |
| kgunn | sweet | 16:46 |
| greyback | dandrader: is for https://bugs.launchpad.net/unity-mir/+bug/1346367 | 16:46 |
| ubot5 | Launchpad bug 1346367 in unity-mir "Window stack reports app in focus even when lockscreen is up." [Critical,In progress] | 16:46 |
| === alan_g is now known as alan_g|EOD | ||
| === gatox_lunch is now known as gatox | ||
| Saviq | elopio, can I help with unlocking for dash-as-app? | 17:29 |
| Saviq | it shouldn't be any different than now, though | 17:30 |
| elopio | Saviq: yes. I'm not sure yet what's going on, so if you can dig at the same time that will be useful | 17:32 |
| elopio | my branch: https://code.launchpad.net/~unity-team/unity8/dash-as-app/+merge/228534 | 17:32 |
| elopio | when I run any test that starts unity, it gets stuck. The dash tests are working now because I made them only start the dash. | 17:32 |
| elopio | Saviq: for example: autopilot3 run unity8.shell.tests.test_lock_screen.TestLockscreen.test_can_unlock_pin_screen -> stuck | 17:33 |
| elopio | I'm debuging to find out where it stops. | 17:33 |
| elopio | subprocess.check_output(['/sbin/initctl', 'start', 'unity8']) never returns | 17:38 |
| elopio | Saviq: yes, this seems to be different. initctl start unity8 doesn't return. | 17:42 |
| Saviq | elopio, on desktop you mean? | 17:42 |
| elopio | Saviq: yes. | 17:42 |
| Saviq | elopio, that will be https://code.launchpad.net/~gerboland/unity8/fix-run.sh-script/+merge/228817 | 17:43 |
| Saviq | elopio, 'fraid with qtcomp we managed to break unity8 upstart integration under x11 | 17:43 |
| elopio | Saviq: let me try adding that branch as a prerequisite of mine. | 17:43 |
| elopio | Saviq: now this opens two unity windows | 17:47 |
| elopio | initctl start unity8 BINARY=/home/elopio/workspace/canonical/unity/unity8/experimental/dash-as-app-autopilot/builddir/install/bin/unity8 | 17:47 |
| elopio | initctl start unity8 wokrs fine. | 17:48 |
| Saviq | elopio, I think it's just wrong state, stop / kill them all and try again | 17:49 |
| elopio | Saviq: no. I have no unity8 process running and it still happens. | 17:50 |
| Saviq | elopio, hmm, let me try | 17:51 |
| Saviq | elopio, did you make install? | 17:58 |
| elopio | Saviq: yes I did. | 18:04 |
| elopio | without make install I would have been using the old one that doesn't return. | 18:04 |
| Saviq | elopio, correct, but that could've caused weirdness | 18:05 |
| Saviq | elopio, building now | 18:06 |
| elopio | all screen lock tests passing now. | 18:22 |
| Saviq | elopio, so you're good? | 18:25 |
| Saviq | elopio, I just confirmed the branch fixes stuff | 18:25 |
| elopio | Saviq: no, the two windows are not blocking me. | 18:32 |
| elopio | Saviq: but I just understood it a little better. One window is unity8 and the other is the dash app | 18:32 |
| elopio | can I launch unity8 without opening the dash? | 18:32 |
| Saviq | elopio, right, that makes sense ;D | 18:36 |
| Saviq | elopio, the upstart job makes it start on unity8 started | 18:36 |
| Saviq | elopio, so right now there's no way to do that, no | 18:37 |
| Saviq | elopio, and if we don't need to, it should stay that way :) | 18:37 |
| elopio | Saviq: the dash window is opened after the unity window, so it might get in the way. | 18:40 |
| elopio | I think I can stop the dash | 18:40 |
| Saviq | elopio, sure, you can | 18:40 |
| elopio | Saviq: one thing. I see that you have an assertUnityReady, that checks that the home scope is loaded. | 18:41 |
| elopio | is there another way to check that unity is ready? | 18:41 |
| Saviq | elopio, there has to be now, yeah | 18:43 |
| Saviq | elopio, the home scope loaded would be a check for the dash now | 18:44 |
| Saviq | elopio, let me find someplace | 18:44 |
| elopio | I might be able to just remove it. But it has a comment saying: big timeout for when running on VMs, I might break that. | 18:44 |
| Saviq | elopio, can we wait for a signal on an object? | 18:50 |
| Saviq | elopio, wait_select_single(objectName="greeterContentLoader") | 18:51 |
| Saviq | and either wait for the "loaded" signal | 18:51 |
| Saviq | or for .status == Loader.Ready | 18:51 |
| Saviq | or last resort .item != None | 18:51 |
| Saviq | elopio, or actually .progress == 1 could work, too | 18:51 |
| elopio | Saviq: we can listen to signals, but that's undocumented code that they have wanted to remove from autopilot for a long time | 18:53 |
| elopio | so it's not too safe. | 18:53 |
| elopio | Loader.Ready can work. | 18:53 |
| elopio | or .progress. Let me try. | 18:53 |
| Saviq | elopio, progress probably easier, as not sure how you'd know the enum value | 18:53 |
| elopio | all notifications tests passing. | 19:29 |
| elopio | Saviq: the way you launch unity on test_upstart is not working anymore. Are you still around to take a look? | 19:36 |
| jgdx | elopio, hey, got a minute | 19:49 |
| jgdx | ? | 19:49 |
| elopio | jgdx: yes. | 19:51 |
| jgdx | elopio, ref the discussion above, I am trying to click an qml object in a component loaded by a Loader | 19:52 |
| jgdx | elopio, even using wait select single gives me "Object not found" | 19:53 |
| elopio | jgdx: that's on system settings, right? | 19:53 |
| jgdx | elopio, yes | 19:53 |
| elopio | jgdx: many things can be happening. What I do is to put a break point before the select single | 19:54 |
| elopio | and open autopilot vis to inspec the status of the QML tree. | 19:54 |
| elopio | my most common mistakes are to use something like Loader instead of QQuickLoader, or not waiting enough, or that the component is lazily created so I have to swipe first. | 19:56 |
| elopio | jgdx: the tree is pretty big, so if you can't find anything useful, you can push the branch and I'll take a look. | 19:56 |
| jgdx | elopio, thanks! What do you mean when you have to swipe first+ | 19:57 |
| elopio | jgdx: like on qquicklists, not all the items are created at first. | 19:57 |
| elopio | as you swipe, some items are added to the tree and some are removed. | 19:58 |
| elopio | so if you want to click the last item of a big list, you first need to swipe. | 19:58 |
| elopio | we have helpers for that on the toolkit. | 19:58 |
| jgdx | elopio, ah right | 19:58 |
| jgdx | elopio, thanks, you've been very helpful.:) | 19:59 |
| elopio | np. | 20:01 |
| jgdx | elopio, I got the tree wrong. Fixed! :) | 20:04 |
| elopio | great | 20:06 |
| elopio | jgdx: let me know when the branch is ready and I'll review it. | 20:06 |
| jgdx | elopio, sure thing | 20:06 |
| elopio | Saviq: kgunn: the only remaining test on the desktop is the upstart one. I'm not sure what's going on there. | 20:10 |
| elopio | on the phone everything should just work :D I'll wait for jenkins to give me a package and confirm that. | 20:11 |
| Saviq | elopio, what's the failure? | 20:11 |
| elopio | Saviq: no failure, it just gets stuck trying to get the autopilot proxy object from the pid of the launched unity. | 20:12 |
| elopio | sometimes I see the window opening, sometime it doesn't open. | 20:12 |
| Saviq | elopio, sounds like it's stopped | 20:22 |
| Saviq | elopio, when it shouldn't | 20:23 |
| Saviq | elopio, which test? | 20:23 |
| elopio | Saviq: autopilot run unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_modal_sd_with_greeter unity8.shell.tests.test_upstart.UpstartIntegrationTests | 20:24 |
| Saviq | elopio, where's your branch fixing it? not proposed yet? | 20:28 |
| elopio | Saviq: https://code.launchpad.net/~canonical-platform-qa/unity8/dash-as-app-autopilot/+merge/228928 | 20:29 |
| Saviq | ah | 20:29 |
| Saviq | moving it out are ya | 20:29 |
| Saviq | ah no /me can't read | 20:29 |
| Saviq | elopio, so yeah, that's actually a bug | 20:44 |
| Saviq | elopio, http://paste.ubuntu.com/7908200/ is a better version of the test | 20:44 |
| Saviq | elopio, rework to match your py/ap knowledge | 20:44 |
| Saviq | elopio, and I'll fix unity in the mean time | 20:45 |
| elopio | Saviq: thanks! I'm going to a meeting right now, and then I'll copy your code. | 20:45 |
| Saviq | elopio, ok, so, it's not really a bug, but a change in behaviour, the code now checks whether the variable is set at all, not whether it's non-empty (which is more correct FWIW), but the test sets it to "", as patch_environment has no way to unset an env var... | 20:50 |
| Saviq | elopio, not sure how to tackle that properly | 20:50 |
| Saviq | elopio, like http://paste.ubuntu.com/7908261/ makes it pass, but not reliably if that var would ever be set for whatever reason | 20:51 |
| elopio | Saviq: we have a fixture to unset a variable, I think | 20:52 |
| Saviq | k, I'm off, elopio you should hopefully be set | 21:04 |
| elopio | Saviq: yes. Thanks and have a good night. | 21:08 |
| jgdx | elopio, here's the branch https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/1219793-reset/+merge/228954 (note that running tests will nuke your desktop launcher) | 22:20 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| Wellark | hmm.. what am I missing? I'm trying to run unity8 trunk autopilot tests on the desktop (under unity7) and it just gets stuck | 23:09 |
| Wellark | inside File "/usr/lib/python2.7/dist-packages/unity8/process_helpers.py", line 152, in restart_unity | 23:10 |
| Wellark | ok. getting unity8-autopilot from archive works just fine | 23:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
