[00:09] Saviq: hah. now I have one for unity for real, I think... [00:10] well, not sure, might be click-scope again... [00:13] how are you guys awake [00:14] kgunn, coffee ;) [00:15] Coding stimulates insomnia [00:16] that, too [00:16] on that note [00:16] o/ [00:16] mzanetti, have a good time, see you in a week [00:17] Saviq: thanks. see you in a week === _salem is now known as salem_ === salem_ is now known as _salem [08:24] larsu, thanks for looking at it. I have clarified it with a comment. [08:43] why is https://code.launchpad.net/~aacid/unity8/dash_overview/+merge/226449 marked as superseded? [08:43] Saviq: ↑ any idea? [08:43] ah right [08:43] * tsdgeos stupid [08:43] https://code.launchpad.net/~aacid/unity8/dash_overview/+merge/228649 is the correct one [08:44] didn't we have links from old to new? [08:51] Saviq: what do you mean "1.png: no bottom edge hint" ? [08:53] tsdgeos, if you resubmitted there is a link [08:54] tsdgeos, https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/dash-overview/hint-expanded.png [08:54] tsdgeos, see the little tab at the bottom [08:54] what [08:54] that's new [08:54] that wasn't there at all [08:54] are we going to show that thing 100% of the time? [08:54] is going to be a bit annoying no? [08:56] tsdgeos, have a look at dialer or messaging, they show it on startup and then slide down a bit, I'll ask if that's what we should do [09:00] tsdgeos, actually no, it's supposed to go in/out with the page header... [09:01] tsdgeos, it's fine to be binary shown/hidden, but should be on screen whenever header is on screen and vice versa [09:01] tsdgeos, and yeah, it was there for a long time ;) [09:02] * Saviq goes to ask how will that behave with the see less footer... [09:02] given taht google docs is a mess and it doesn't have proper history i can't prove it [09:02] but i sincerely doubt so [09:03] and honestly i can't fiigure out a nice interaction for it based on what you said [09:03] are we going to do no animation show/hide depending if the header is somewhat visiible or not? [09:03] that's going to be crap [09:04] anyway, let's do it, where's the image for it? [09:07] tsdgeos, let's wait for them to complete the visual review [09:07] ok [09:07] so do nothing for now then [09:08] Saviq: btw https://f966f709-a-c881af26-s-sites.googlegroups.com/a/canonical.com/unity8dash/scopes/dash-overview/hint-expanded.png?attachauth=ANoY7coBsuHCr4FUnVZy-scE64bZHg8M6LG4PrLmgwzW5DG4AZS_h06hfaJC_5N6ouvEyGrLGjS8BtGL6oY-l0LO6XMOmjNx2ebflFHytgEme2KYjq1L-nWy65RO3BMbIdaYalbGVXnhxaAtaTxAAr0MLGDr3MAUHYX-LA43dZIJAOPvYXlmu_X6Tb0QsbcLmq4feBztKf61TxmdehwbQfxXykOCAlGgPOFYAyIPUKkPAHwPFOULfXvRPwybcpajZ4bPkuMNwNrI&attredirects=0 doesn't have the gradient at the [09:08] beginning/end of categories [09:08] tsdgeos, yeah, I know [09:08] tsdgeos, gradient's supposed to go away anyway [09:09] tsdgeos, but yeah, I'll find out why there isn't the divider at all [09:10] Saviq: besides, docu says "The hint is always visible - never hidden or smaller (unlike hints used in apps)" [09:10] tsdgeos, yeah, old, of course... [09:10] which kind of disagrees with the shown when the header is shown [09:11] tsdgeos, the "hide on scroll" was a req from above [09:11] tsdgeos, I'll ask Mike to clarify on the page [09:15] Saviq: also i don't think we should change ratio of cards at all in Favorites [09:15] now they have exactly the ratio the dash has [09:16] so it's the more natural and correct ratio you can expect there [09:16] but i'm not a designer [09:17] tsdgeos, TBH it doesn't feel like they do, they're too wide [09:18] well the fact that i can put stuff from the dash inside them without any stretch or crop disagrees with your feeling [09:20] ah wait [09:20] that may just be in tryDash [09:20] real thing uses images that may have the wrong sizes and break stuff [09:20] i'll wait for silo 5 to build [09:34] jgdx: no problem. Patch coming in a bit [09:35] larsu, thanks [09:37] Saviq: i've installed silo5 [09:37] and used a ruler to calculate the ratios [09:46] well it's the only possible way to make the thing fade in properly [09:46] no idea how am i supposed to fade in two things that have different sizes [09:49] tsdgeos, somewhat simple - preserveaspectcrop or stretch [09:49] tsdgeos, but I understand it's not that simple when you make it happen [09:51] no Mike, gotta wait [09:52] Saviq: there's something weird with qtcomp (i think) Ctrl+c no longer shutdowns unity8 [09:52] tsdgeos, yeah, I saw that [09:52] tsdgeos, do you get console output at all? [09:52] neither [09:53] start doesn't finish [09:53] so the tail does not kick in [09:56] that is pretty annoying [09:56] can't debug anything anymore with printf [09:58] tsdgeos, copy a unity8.conf in your .config/upstart without "expect stop" [09:58] tsdgeos, or pkill -SIGSTOP unity8 [09:59] ok [09:59] is that a workaround or a fix? [10:02] Saviq, here's the interesting stuff http://bazaar.launchpad.net/~unity-team/unity-api/scopes-v4/revision/159 [10:07] pete-woods, all good with infographics? [10:08] Cimi: still not got the thing reviewed :( [10:37] tsdgeos: https://code.launchpad.net/~gerboland/unity8/fix-run.sh-script/+merge/228817 - fancy giving it a whirl? [10:38] greyback: sure [10:38] thanks [10:40] tsdgeos, fyi, we're going for aspect ratio to match reality and assets that can cope with that [10:40] Saviq: so no change in my side? [10:40] tsdgeos, not in Favourites [10:41] tsdgeos, but we need to force the aspect ratio in All and when searching [10:41] why? [10:41] tsdgeos, because otherwise they look different in Fav than in All [10:41] they do in non search too, no? [10:42] Saviq: or you mean when non searching? [10:42] tsdgeos, that's why I said "All *and* when searching" [10:42] tsdgeos, basically wherever there's a category with scopes, we need to force aspect ratio to reality [10:43] i am confused now [10:43] tsdgeos, wanna mumble? [10:43] sure [10:46] Hola === MacSlow is now known as MacSlow|lunch [11:06] greyback: there's two qmluitests failing in trunk, can you fix them too? [11:06] greyback: testRunningApplicationsGrid and testShell [11:07] tsdgeos: testRunningApplicationsGrid is being removed soon (MR approved) [11:08] that testShell test, I recall mzanetti telling me it'll be fixed by dash-as-an-app [11:08] ok [11:08] i.e. there's no point fixing it as the code will change soon [11:09] well there's the "let's make sure tests pass so if one fails i know it's my fault and not something that was there already" [11:09] but yeah [11:09] i understand what you mean === alan_g is now known as alan_g|lunch [11:23] Saviq: wow, much difference [11:23] when using the ShaderEffectSource :D [11:23] Saviq: i'll commit it so you can rebuild the ppa [11:28] commited === Estilanda_ is now known as Estilanda [11:46] Saviq: any luck on my assets for +/- for the Expandable PReview Widget? [11:50] tsdgeos, I feel they should come from the theme [11:50] i feel the same [11:50] but there's nothing i could find [11:51] tsdgeos, let me ping Mathieu === MacSlow|lunch is now known as MacSlow === _salem is now known as salem_ [13:10] cwayne: i just dropped that text in our test and still works :/ [13:10] do you have a scope we can use? [13:11] tsdgeos: just attached a click to the bug === alan_g|lunch is now known as alan_g [13:13] cwayne: i should probably know this, but cna i do something with that in the desktop? is it phone only? and how do i install it [13:13] * tsdgeos hides [13:13] tsdgeos: heh, hm, not sure actually, its compiled for armhf [13:14] oh right [13:14] silly me [13:14] i could get an i386 one to use with the emulator if that's helpful? [13:14] nah i'll just use the phone [13:14] how do i install it? [13:16] adb push it, then sudo -iu phablet, then pkcon install-local path-to.click [13:16] sudo click install [13:16] seems that did the trick [13:20] Saviq, does this look reasonable? https://code.launchpad.net/~unity-team/unity/split-schema-pkg/+merge/228845 [13:23] cwayne: you're thing does not show up in the overview [13:24] can't reach it [13:24] tsdgeos: is there something different we need to do to get it in the overview? [13:24] i see it in the scopes scope still [13:25] nope :/ [13:25] maybe it's just not running [13:26] hm, i even just installed/launched it from the overview [13:26] tsdgeos, + / - will be added to theme [13:27] tsdgeos: try a reboot maybe? :/ [13:28] cwayne: didn' help [13:28] Saviq: ok, name? [13:28] tsdgeos, you should also be able to export UNITY_SCOPES to force it to show up [13:28] tsdgeos, TBD [13:29] tsdgeos: what does 'sudo -iu phablet click list' show [13:29] tsdgeos, tiheum's just finding out [13:29] i always use pkcon-install, never click install.... [13:30] oh tsdgeos did you just do click install? [13:30] ah [13:30] maybe was installed somewhere else [13:30] well click install doesn't do the full bits [13:31] youd need to do a click register as well [13:31] adb push foo.click /tmp ; phablet-shell ; pkcon install-local /tmp/foo.click [13:31] ^ do that [13:31] but pkcon install-local does all of it [13:31] phablet-shell > adb shell [13:31] cwayne: ok, now [13:31] popey++ [13:32] cwayne: ok, can reproduce there [13:32] whew, im not crazy! [13:32] well, for this particular reason at least [13:33] :D [13:35] tsdgeos: let me know if you need any more debug info or the source or anything [13:35] it is written in go, I hope that's not what's causing it :/ [13:37] tsdgeos, "view-expand", "view-collapse" [13:37] Saviq: ok [13:38] cwayne, are you maybe passing us rich text (meaning there's html tags and stuff)? [13:39] hmm I wonder if \r\n causes it... [13:39] Saviq: yea [13:39] i don't think there's any tags, but there's definitely \r\n all over the damn place === pete-woods is now known as pete-woods|lunch [13:44] cwayne: all your fault [13:44] usually is [13:44] go is evil [13:44] lol [13:44] cwayne: don't use a header to show text [13:44] use text [13:44] which is the thing you should use to use text [13:45] showing all the text in the "subtitle" propety of a header [13:45] is kind of evil === pete-woods|lunch is now known as pete-woods [13:46] holy crap i do not remember doing that, mustve been whatever scope i copied it from [13:46] * cwayne feels like an idiot [13:46] it's actually kind of funny [13:47] since you're using text for what technically would be the header [13:47] and header for what is the text [13:48] that was a workaround because the title kept getting truncated tsdgeos [13:48] right [13:49] since title doesn't support wrapping [13:49] :D [13:49] a victor-suggested-workaround [13:49] hah [13:49] you could have thought the same here ;) [13:49] well, i owe you at least 6 beers for putting up with my stupidity then :) [13:49] it's ok, we all make mistakes [13:50] team work fixes that! [13:50] :P [13:51] mhr3, v [13:51] https://code.launchpad.net/~aacid/unity8/clickScopeForceArtShapeSize/+merge/228505 === pete-woods is now known as pete-woods|lunch [14:19] Saviq: did expandable, going to do table now [14:22] tsdgeos, coolz [14:28] tsdgeos: a table preview widget? [14:28] cwayne: yes [14:29] that's perfect, a scope I'mw riting right now is in desperate need of that [14:52] Saviq: hey, I've noticed on a latest updated image, when I search in a scope that has a Pageheader color or image, it overruns the header and spills down into the body, known issue? [14:56] cwayne: do you have a screenshot? [14:57] tsdgeos: http://people.canonical.com/~cwayne/overflow.png [14:57] hmmmm [14:58] yeah that' a bug [14:58] cwayne: can you file a bug? [14:59] sure thing [14:59] tx [15:05] cwayne, yeah, bug [15:06] Saviq: tsdgeos: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1350398 [15:06] Launchpad bug 1350398 in unity8 (Ubuntu) "Pageheader.Background overflows" [Undecided,New] [15:11] Saviq, the hangout was very laggy today on my side [15:11] Saviq, it unmuting without my action was a bit odd === pete-woods|lunch is now known as pete-woods [15:28] tsdgeos, https://code.launchpad.net/~tiheum/ubuntu-themes/suru-icons/+merge/226325 [15:28] Saviq: nice [15:33] tsdgeos, I stole the background bug from you, if you wanna fix before I get to it - please [15:33] Saviq: i fixed it already [15:34] er what happened [15:34] right [15:34] you stole me the bug [15:34] and i linked it to the wrong bug [15:34] being "first bug in my list is the bug i want to fix" [15:35] and now i was totally confused [15:35] :) [15:36] so i'll steal it again [15:37] Saviq: see if you can get from Mike the numbers of lines a collapsed text/table should show [15:38] tsdgeos, he's in a mtg, but let's go for 3 for now [15:39] tsdgeos, and I'll try and get an answer from him when he's out [15:39] yeah i was using thati [15:39] it's what wireframes use [15:40] tsdgeos, yeah, go with that [15:42] Saviq: the pacakges from https://code.launchpad.net/~tiheum/ubuntu-themes/suru-icons/+merge/226325 are lost? [15:42] i'd like to use them [15:42] tsdgeos, it should rebuild soon [15:42] Saviq: still i don't know where to get them from the jobs [15:42] tsdgeos, ah no it won't, 'cause it's top-acked already [15:43] ok [15:43] tsdgeos, I'll kick a build, mo [15:43] just wait for this to land then? [15:43] tsdgeos, http://s-jenkins.ubuntu-ci:8080/job/ubuntu-themes-ci/76/console [15:43] tsdgeos, but yeah, we' [15:43] ll land this with your branch [15:45] sure i just want to be able to see them [15:45] and seems building my own package takes a good while more than i expected [15:45] something even crashed [16:01] tsdgeos, right, because it optipngs them... total waste of builders time [16:02] +1 [16:02] tsdgeos, you can stop it by exporting NO_PNG_PKG_MANGLE=1 [16:02] ultra tired today, sharp eod [16:02] tsdgeos, I've that in .profile [16:02] tsdgeos, o./ === gatox is now known as gatox_lunch [16:24] mterry, bug #1350348 btw [16:24] bug 1350348 in unity-system-compositor (Ubuntu) "Spinner not shown on shutdown" [Undecided,New] https://launchpad.net/bugs/1350348 [16:44] dandrader: time for a quick review? https://code.launchpad.net/~gerboland/qtmir/fix-unfocus-notification/+merge/228901 [16:44] * dandrader checks [16:45] kgunn: ^^ [16:46] sweet [16:46] dandrader: is for https://bugs.launchpad.net/unity-mir/+bug/1346367 [16:46] Launchpad bug 1346367 in unity-mir "Window stack reports app in focus even when lockscreen is up." [Critical,In progress] === alan_g is now known as alan_g|EOD === gatox_lunch is now known as gatox [17:29] elopio, can I help with unlocking for dash-as-app? [17:30] it shouldn't be any different than now, though [17:32] Saviq: yes. I'm not sure yet what's going on, so if you can dig at the same time that will be useful [17:32] my branch: https://code.launchpad.net/~unity-team/unity8/dash-as-app/+merge/228534 [17:32] when I run any test that starts unity, it gets stuck. The dash tests are working now because I made them only start the dash. [17:33] Saviq: for example: autopilot3 run unity8.shell.tests.test_lock_screen.TestLockscreen.test_can_unlock_pin_screen -> stuck [17:33] I'm debuging to find out where it stops. [17:38] subprocess.check_output(['/sbin/initctl', 'start', 'unity8']) never returns [17:42] Saviq: yes, this seems to be different. initctl start unity8 doesn't return. [17:42] elopio, on desktop you mean? [17:42] Saviq: yes. [17:43] elopio, that will be https://code.launchpad.net/~gerboland/unity8/fix-run.sh-script/+merge/228817 [17:43] elopio, 'fraid with qtcomp we managed to break unity8 upstart integration under x11 [17:43] Saviq: let me try adding that branch as a prerequisite of mine. [17:47] Saviq: now this opens two unity windows [17:47] initctl start unity8 BINARY=/home/elopio/workspace/canonical/unity/unity8/experimental/dash-as-app-autopilot/builddir/install/bin/unity8 [17:48] initctl start unity8 wokrs fine. [17:49] elopio, I think it's just wrong state, stop / kill them all and try again [17:50] Saviq: no. I have no unity8 process running and it still happens. [17:51] elopio, hmm, let me try [17:58] elopio, did you make install? [18:04] Saviq: yes I did. [18:04] without make install I would have been using the old one that doesn't return. [18:05] elopio, correct, but that could've caused weirdness [18:06] elopio, building now [18:22] all screen lock tests passing now. [18:25] elopio, so you're good? [18:25] elopio, I just confirmed the branch fixes stuff [18:32] Saviq: no, the two windows are not blocking me. [18:32] Saviq: but I just understood it a little better. One window is unity8 and the other is the dash app [18:32] can I launch unity8 without opening the dash? [18:36] elopio, right, that makes sense ;D [18:36] elopio, the upstart job makes it start on unity8 started [18:37] elopio, so right now there's no way to do that, no [18:37] elopio, and if we don't need to, it should stay that way :) [18:40] Saviq: the dash window is opened after the unity window, so it might get in the way. [18:40] I think I can stop the dash [18:40] elopio, sure, you can [18:41] Saviq: one thing. I see that you have an assertUnityReady, that checks that the home scope is loaded. [18:41] is there another way to check that unity is ready? [18:43] elopio, there has to be now, yeah [18:44] elopio, the home scope loaded would be a check for the dash now [18:44] elopio, let me find someplace [18:44] I might be able to just remove it. But it has a comment saying: big timeout for when running on VMs, I might break that. [18:50] elopio, can we wait for a signal on an object? [18:51] elopio, wait_select_single(objectName="greeterContentLoader") [18:51] and either wait for the "loaded" signal [18:51] or for .status == Loader.Ready [18:51] or last resort .item != None [18:51] elopio, or actually .progress == 1 could work, too [18:53] Saviq: we can listen to signals, but that's undocumented code that they have wanted to remove from autopilot for a long time [18:53] so it's not too safe. [18:53] Loader.Ready can work. [18:53] or .progress. Let me try. [18:53] elopio, progress probably easier, as not sure how you'd know the enum value [19:29] all notifications tests passing. [19:36] Saviq: the way you launch unity on test_upstart is not working anymore. Are you still around to take a look? [19:49] elopio, hey, got a minute [19:49] ? [19:51] jgdx: yes. [19:52] elopio, ref the discussion above, I am trying to click an qml object in a component loaded by a Loader [19:53] elopio, even using wait select single gives me "Object not found" [19:53] jgdx: that's on system settings, right? [19:53] elopio, yes [19:54] jgdx: many things can be happening. What I do is to put a break point before the select single [19:54] and open autopilot vis to inspec the status of the QML tree. [19:56] my most common mistakes are to use something like Loader instead of QQuickLoader, or not waiting enough, or that the component is lazily created so I have to swipe first. [19:56] jgdx: the tree is pretty big, so if you can't find anything useful, you can push the branch and I'll take a look. [19:57] elopio, thanks! What do you mean when you have to swipe first+ [19:57] jgdx: like on qquicklists, not all the items are created at first. [19:58] as you swipe, some items are added to the tree and some are removed. [19:58] so if you want to click the last item of a big list, you first need to swipe. [19:58] we have helpers for that on the toolkit. [19:58] elopio, ah right [19:59] elopio, thanks, you've been very helpful.:) [20:01] np. [20:04] elopio, I got the tree wrong. Fixed! :) [20:06] great [20:06] jgdx: let me know when the branch is ready and I'll review it. [20:06] elopio, sure thing [20:10] Saviq: kgunn: the only remaining test on the desktop is the upstart one. I'm not sure what's going on there. [20:11] on the phone everything should just work :D I'll wait for jenkins to give me a package and confirm that. [20:11] elopio, what's the failure? [20:12] Saviq: no failure, it just gets stuck trying to get the autopilot proxy object from the pid of the launched unity. [20:12] sometimes I see the window opening, sometime it doesn't open. [20:22] elopio, sounds like it's stopped [20:23] elopio, when it shouldn't [20:23] elopio, which test? [20:24] Saviq: autopilot run unity8.shell.tests.test_notifications.InteractiveNotificationBase.test_modal_sd_with_greeter unity8.shell.tests.test_upstart.UpstartIntegrationTests [20:28] elopio, where's your branch fixing it? not proposed yet? [20:29] Saviq: https://code.launchpad.net/~canonical-platform-qa/unity8/dash-as-app-autopilot/+merge/228928 [20:29] ah [20:29] moving it out are ya [20:29] ah no /me can't read [20:44] elopio, so yeah, that's actually a bug [20:44] elopio, http://paste.ubuntu.com/7908200/ is a better version of the test [20:44] elopio, rework to match your py/ap knowledge [20:45] elopio, and I'll fix unity in the mean time [20:45] Saviq: thanks! I'm going to a meeting right now, and then I'll copy your code. [20:50] elopio, ok, so, it's not really a bug, but a change in behaviour, the code now checks whether the variable is set at all, not whether it's non-empty (which is more correct FWIW), but the test sets it to "", as patch_environment has no way to unset an env var... [20:50] elopio, not sure how to tackle that properly [20:51] elopio, like http://paste.ubuntu.com/7908261/ makes it pass, but not reliably if that var would ever be set for whatever reason [20:52] Saviq: we have a fixture to unset a variable, I think [21:04] k, I'm off, elopio you should hopefully be set [21:08] Saviq: yes. Thanks and have a good night. [22:20] elopio, here's the branch https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/1219793-reset/+merge/228954 (note that running tests will nuke your desktop launcher) === salem_ is now known as _salem === _salem is now known as salem_ === salem_ is now known as _salem [23:09] hmm.. what am I missing? I'm trying to run unity8 trunk autopilot tests on the desktop (under unity7) and it just gets stuck [23:10] inside File "/usr/lib/python2.7/dist-packages/unity8/process_helpers.py", line 152, in restart_unity [23:12] ok. getting unity8-autopilot from archive works just fine