| rick_h__ | woo! expenses filed. Only took 3 months | 00:34 |
|---|---|---|
| huwshimi | hehe | 00:38 |
| rick_h__ | now that vegas is filed I feel less obligated to file london ones :) | 00:40 |
| rick_h__ | huwshimi: hey, how goes? Wanted to check up on your branches | 00:40 |
| rick_h__ | and let you know that hatch and frankban are working on the 'deleting things' problems in the back end | 00:40 |
| huwshimi | rick_h__: I have a million things in progress :) | 00:40 |
| rick_h__ | so should be able to revisit that branch later on | 00:41 |
| rick_h__ | huwshimi: yea, seems like it. I wanted to see what was up, anything stuck you need a hand with, etc. | 00:41 |
| huwshimi | rick_h__: I talked to hatch about landing the deleted states (they just won't be visible) and then hooking them up when that's done (hence me moving the card back) | 00:42 |
| huwshimi | If you'd prefer me to wait I can | 00:42 |
| rick_h__ | huwshimi: hmm, ok. I trust you on it. | 00:42 |
| huwshimi | :) | 00:42 |
| rick_h__ | hah, poor huw was a photo target a bit https://www.flickr.com/photos/7508761@N03/14730078876/in/photostream/ | 01:21 |
| huwshimi | It's almost as if I was being followed :) | 01:24 |
| huwshimi | Nice photos! | 01:24 |
| rick_h__ | hah, yea I was following you around a lot | 01:25 |
| urulama | morning all | 06:22 |
| huwshimi | urulama: Morning | 06:28 |
| urulama | huwshimi: anything particular regarding your cards on the board that need review or are in coding (to pass the message to the daily call)? | 06:32 |
| huwshimi | urulama: Only that I need second reviews on a couple of them. Thanks! | 06:33 |
| urulama | huwshimi: ok, np | 06:35 |
| urulama | frankban: morning | 08:14 |
| frankban | urulama: hi | 08:14 |
| urulama | frankban: do you know if rogpeppe is out today? | 09:06 |
| rogpeppe | urulama: i'm around | 09:06 |
| urulama | rogpeppe: oh, hi, sorry :D | 09:06 |
| rogpeppe | urulama: np :-) | 09:06 |
| urulama | rogpeppe: any news regarding the change of core to charm.v2? | 09:07 |
| rogpeppe | urulama: i've been around for hours :-) | 09:07 |
| rogpeppe | urulama: core is blocked until its critical bugs are resolved | 09:07 |
| rogpeppe | urulama: so no branches are landing that aren't fixing those bugs | 09:07 |
| urulama | rogpeppe: ok, tnx for the info | 09:07 |
| rogpeppe | urulama: i've got approval to land it though | 09:07 |
| urulama | rogpeppe: \o/ | 09:08 |
| urulama | rogpeppe: didn't have time to ask before ... any sessions this week? | 09:12 |
| rogpeppe | urulama: this week and every week :-) | 09:14 |
| rogpeppe | urulama: tuesday night it was | 09:14 |
| rogpeppe | urulama: and absolutely rockin'! | 09:14 |
| urulama | rogpeppe: nice, glad to hear! | 09:15 |
| rogpeppe | urulama: it was good on the friday night in london actually. i presume you didn't try and fail to find it. | 09:15 |
| urulama | rogpeppe: we wanted to have a session today (with the gypsy swing band, and me cooking), but the weather is really bad :( well, after Nuremberg it is | 09:16 |
| rogpeppe | urulama: music and home cooking, the perfect combo :-) | 09:16 |
| urulama | rogpeppe: no, i was in the museum for nearly 4h ... i guess the sms didn't get through :( | 09:16 |
| rogpeppe | urulama: nope, i haven't got any sms messages from you since thursday | 09:17 |
| rogpeppe | afk for 10 minutes | 09:18 |
| * urulama lunches ... woke up early today | 09:18 | |
| urulama | rogpeppe: what do you have in mind for the charm refactoring? | 10:13 |
| rogpeppe | urulama: i'd doing exactly as i suggested in my email to juju-dev | 10:13 |
| rogpeppe | s/i'd/i'm. | 10:13 |
| urulama | rogpeppe: aaa, the URL/ReferenceURL, cool | 10:15 |
| rogpeppe | urulama: https://github.com/juju/charm/pull/31 | 10:24 |
| urulama | will take a look in 5min | 10:25 |
| rogpeppe | urulama: thanks | 10:26 |
| urulama | rogpeppe: found this work done by hazmat ... find it interesting https://github.com/kapilt/juju-tosca | 10:31 |
| rogpeppe | urulama: thanks for pointing to that | 10:33 |
| rick_h__ | morning | 10:47 |
| urulama | rick_h__: morning | 10:49 |
| frankban | rick_h__: morning | 10:58 |
| frankban | guihelp: I need reviews/QA for https://github.com/juju/juju-gui/pull/469 . Thanks! | 10:59 |
| * frankban lunches | 11:10 | |
| urulama | rogpeppe: i like how more uniform the code is now with new URL & referenceURL | 11:21 |
| rogpeppe | urulama: cool | 11:21 |
| urulama | rogpeppe: i see that you're already on the way to change the charmstore ... making charm.v2 obsolete (in a way) | 11:22 |
| rogpeppe | urulama: well, who knows who is already using charm.v2? :-) | 11:23 |
| * urulama makes a wild guess that all the users are mostly present here :D | 11:24 | |
| rogpeppe | urulama: i don't mind leaving v2 behind. we don't need to maintain it. | 11:28 |
| rogpeppe | urulama: i do think it's important to change the version number though. | 11:28 |
| rogpeppe | urulama: BTW i'm just investigating to see what the Resolve method does. There don't appear any tests for it, and it's only called once in the entire of juju-core | 11:29 |
| urulama | rogpeppe: let's welcome our new charm.v3 :) | 11:30 |
| rogpeppe | urulama: let's :-) | 11:30 |
| urulama | rogpeppe: regarding core - makes sense, they do depend on full URLs | 11:30 |
| bac | morning | 11:41 |
| hazmat | urulama, context?.. that's an in progress oasis std thingy.. | 11:46 |
| urulama | hazmat: i've done the voting for ODS talks and noticed your OASIS and Juju ... just passed the git url to rogpeppe as a curiosity | 11:47 |
| bac | hey rick_h__ can you decipher http://ci.jujugui.org:8080/job/jenkins-github-lander-merge/27/console | 11:47 |
| hazmat | urulama, oh.. nice | 11:49 |
| urulama | hazmat: are you targeting to make juju bundles easy to integrate into heat with tosca support? | 11:50 |
| hazmat | urulama, that's a secondary goal.. first goal.. is tosca import into juju.. outbound, we'll be an embedded an orchestrator... re heat i'd prefer to embed directly | 11:52 |
| urulama | hazmat: nice! | 11:53 |
| rick_h__ | bac: otp, looking | 11:53 |
| rick_h__ | bac: go into the workspace and do 'git fetch' and try to :shipit: again | 11:53 |
| bac | rt | 11:54 |
| rick_h__ | bac: the workspace for that, not sure why it's empty, but I think that's the answer | 11:54 |
| rick_h__ | frankban: will be 2min late here sec | 11:59 |
| frankban | rick_h__: np | 11:59 |
| bac | rick_h__, jcsackett: new jenkins-github-lander has been installed on both of our jenkins instances. | 12:15 |
| rick_h__ | bac: ty much | 12:16 |
| bac | rick_h__: it is not released anywhere, right? | 12:16 |
| rick_h__ | yay for safety | 12:17 |
| rick_h__ | bac: no, not currently | 12:17 |
| bac | rick_h__: does curtis use it? | 12:17 |
| rick_h__ | bac: can you ping mgz and let him know about the bug/update | 12:17 |
| bac | oh, ok | 12:17 |
| rick_h__ | bac: they're using it, but they've got a fork they're using | 12:17 |
| rick_h__ | with all the bug blocking landing/etc stuff | 12:17 |
| rick_h__ | I've not looked where they're keeping their fork | 12:17 |
| rogpeppe | jrwren: i haven't seen any return type comment from you, FYI | 12:57 |
| rogpeppe | jrwren: ha, it came in a different thread | 12:58 |
| rogpeppe | jrwren: ignore me :- | 12:58 |
| rogpeppe | ) | 12:58 |
| rogpeppe | jrwren: see http://godoc.org/labix.org/v2/mgo/bson#Getter | 12:58 |
| rogpeppe | jrwren: to implement an interface, the methods must have exactly the same type signature | 12:59 |
| rogpeppe | jrwren: so returning (string, error) would not work | 12:59 |
| jrwren | rogpeppe: oh, you are implementing some interface there? | 12:59 |
| jrwren | rogpeppe: I missed that bit. Is it a mgo interface? | 12:59 |
| rogpeppe | jrwren: it's mentioned in the doc comment for the method | 13:00 |
| rogpeppe | jrwren: bson.Getter | 13:00 |
| rogpeppe | jrwren: it's understood by the marshaling code that mgo uses to talk to mongodb | 13:00 |
| jrwren | ok. | 13:00 |
| jrwren | new to go and lack of coffee. It makes complete sense now. ty | 13:00 |
| rogpeppe | jrwren: np | 13:03 |
| urulama | rogpeppe: have you seen the comment from Casey about urls? | 13:07 |
| rogpeppe | urulama: yeah | 13:07 |
| rogpeppe | urulama: i've been chatting with him on #juju-dev about it | 13:08 |
| urulama | rogpeppe: tnx | 13:08 |
| rick_h__ | jcsackett: kadams54 around? can you guys take some time this morning to go through huw's branches please? | 13:18 |
| rick_h__ | he's got 5 in review atm | 13:19 |
| urulama | rick_h__: ah, yes, i talked to huw this morning and he asked for second reviews on his branches | 13:21 |
| rick_h__ | urulama: yep, we'll get those cleared out today one way or another. | 13:22 |
| bac | rogpeppe: on the charmstore charm review you mentioned the bug with godeps doing things in parallel. i thought you fixed that weeks ago. | 13:25 |
| rogpeppe | bac: no, i didn't change the default | 13:26 |
| bac | ah, ok. i misremembered that you did | 13:26 |
| rogpeppe | bac: (like a fool, i thought i'd have some time to investigate the actual issue :-]) | 13:26 |
| rick_h__ | rogpeppe: if we need the time we need to create a card and have it as something to get scheduled | 13:26 |
| rick_h__ | rogpeppe: is this something we can file a bug for and then add the bug as a card to the board's backlog to get scheduled up? | 13:27 |
| rogpeppe | rick_h__: given that there's a workaround, i'm not sure it's worth scheduling our time for | 13:27 |
| rick_h__ | rogpeppe: ok, is there a bug to document the issue/workaround? | 13:28 |
| rogpeppe | rick_h__: i've pushed a fix. the workaround is now in place for anyone that uses a fresh version of godeps | 13:28 |
| rogpeppe | rick_h__: (unless they explicitly use a -P flag) | 13:28 |
| rick_h__ | rogpeppe: oh gotcha | 13:28 |
| jcsackett | rick_h__: on it. | 13:40 |
| hazmat | the voting interface on ods is kinda of baroque | 13:40 |
| urulama | hazmat: :) | 13:40 |
| rick_h__ | jcsackett: <3 | 13:40 |
| urulama | hazmat: i've searched using names, opened all links in different tabs ... that helped a bit | 13:41 |
| hazmat | urulama, i just want a listing to scan titles.. seems obvious | 13:46 |
| hazmat | paging through one at a time through 2500 submissions is inane | 13:46 |
| hazmat | their basically encouraging author/company/topic specific voting by forcing search | 13:46 |
| hazmat | instead of browsing | 13:47 |
| urulama | hazmat: search for "at" or "of" ... you'll get list of all | 13:49 |
| urulama | well, list of all that have these words ;) | 13:49 |
| hazmat | urulama, nice trick | 13:52 |
| rogpeppe | frankban, bac, jrwren: here are the changes to make the charm store use the new charm.v3 API | 13:59 |
| rogpeppe | https://github.com/juju/charmstore/pull/49 | 13:59 |
| urulama | rogpeppe: tests failed | 14:01 |
| rogpeppe | urulama: yes, because charm.v3 hasn't landed yet | 14:01 |
| urulama | rogpeppe: how come? :D :D (just kidding) | 14:02 |
| urulama | jujugui: have to go now ... be back in 4h | 14:02 |
| rogpeppe | urulama: i am hoping that someone might get around to deciding that it looks ok | 14:02 |
| rick_h__ | urulama: have fun | 14:02 |
| urulama | rick_h__: tnx | 14:02 |
| bac | rick_h__: joining 1:1 now | 14:03 |
| hatch | frankban is the card you have in review the same as the one I have in starting? | 14:11 |
| hatch | I thought you were on the pending removal changes | 14:12 |
| frankban | hatch: it's not the same, but it's related: it handles the db and ecs name changes, not the deployment panle ones | 14:14 |
| frankban | hatch: would you like to review it? | 14:14 |
| hatch | sure - you should be able to add one line and do my card as well | 14:15 |
| hatch | :) | 14:15 |
| hatch | I'll look in a minute | 14:15 |
| hatch | rick_h__ oh I see the email that's why you moved my old card back into coding | 14:15 |
| hatch | I thought LK was broken again | 14:15 |
| hatch | rick_h__ it was also my intention not to make those changes we had talked about on the front end, but on the back end | 14:17 |
| hatch | that's going to be a lot of code to ship to the client for that usecase | 14:17 |
| hatch | or should I just do it? | 14:18 |
| rick_h__ | hatch: I thought per our conversation that was the work your card was going to be doing | 14:24 |
| rick_h__ | hatch: that's why it was the target/blocker on release. It's a UX issue we need to fix right away, and the client has the abliity to do it in a pure autocomplete sense | 14:24 |
| rick_h__ | hatch: and doing it server side is special casing the search needs for a single widget/component. | 14:24 |
| hatch | well we already hit a different endpoint for it | 14:25 |
| rick_h__ | hatch: I'd like us to get the client side updated for the best UX | 14:25 |
| rick_h__ | hatch: no, we don't | 14:25 |
| rick_h__ | hatch: we add a query string flag to the search endpoint | 14:25 |
| rick_h__ | that basically turns on 'prefix matching' | 14:25 |
| rick_h__ | and does not filter/process results | 14:25 |
| rick_h__ | hatch: call? | 14:25 |
| hatch | oh I thought it was a different endpoint because it had 'autocomplete' in the url | 14:26 |
| rick_h__ | it's just a query string flag onto the same endpoint | 14:26 |
| rick_h__ | and if we match on the start of a word is turned on/off based on that flag | 14:26 |
| hatch | ahh - well then that's broken | 14:26 |
| hatch | lol | 14:26 |
| hatch | the cf-mysql is in the matching results | 14:27 |
| rick_h__ | so I'd prefer we try to get the client side widget fix in asap to fix the issue and make mark s happy and the fastest/best way to do that is in the client result | 14:27 |
| rick_h__ | hatch: right, heh that's true. I think we broke that with ngraming | 14:27 |
| rick_h__ | because we needed to match somethingCMS via searching for CMS | 14:27 |
| frankban | jcsackett: can I have a second review from you for https://github.com/juju/juju-gui/pull/469 when you have time | 14:27 |
| hatch | ok I'll fix this up | 14:27 |
| frankban | ? | 14:27 |
| rick_h__ | hatch: ty | 14:27 |
| rick_h__ | hatch: Makyo kadams54 and jcsackett are helping with huw's reviews that are outstanding. I'd appreciate it if you guys could help as the seconds. | 14:28 |
| rick_h__ | mark the cards with the tags to prevent doubling up, but between the 4 of you guys should hopefully be able to move those 5 branches forward | 14:29 |
| rick_h__ | oh, 4, one is in landing now | 14:29 |
| hatch | yeah I just shipped one | 14:29 |
| hatch | just doing the review on frankban's branch now | 14:29 |
| hatch | frankban I don't think this technique is going to work | 14:32 |
| hatch | the deployer bar results are built from the ecs | 14:32 |
| hatch | if the ecs values dont' change until deploy then we can't update the deployer bar | 14:33 |
| hatch | we need to use the 'old' method and loop through and update the appropriate records when it changes | 14:33 |
| frankban | hatch: unless the deployer bar uses the db to retrieve the model starting from its id | 14:34 |
| hatch | right but that's not how it's done now - right now the deployer bar listens for a 'changeSetModified' event then loops through the changeset | 14:35 |
| frankban | hatch: I am really trying to avoid these kind of ecs mutations | 14:35 |
| rick_h__ | frankban: hatch so sounds like we need a matching update to the changelog rendering? | 14:35 |
| rick_h__ | to pull from db at render time to go with this change? | 14:36 |
| jcsackett | kadams54: you're looking at https://github.com/juju/juju-gui/pull/466 right? i'm trying to make sure the card and the PR are the same ones. | 14:36 |
| hatch | frankban yeah I agree but it feels like we are doing it half way | 14:36 |
| frankban | hatch: if we need to mutate the ecs as a consequence of a user input, than that seems to me a fail | 14:36 |
| kadams54 | jcsackett: correct | 14:36 |
| hatch | and we'll never be able to remmeber if we need to poll the db or the ecs | 14:36 |
| jcsackett | kadams54: awesome. | 14:36 |
| hatch | bbiab | 14:37 |
| kadams54 | Ah crap, forgot about the two review thing and just shipped the onboarding PR. | 14:37 |
| kadams54 | rick_h__: ^ should I come to standup prepared for the stocks and humiliation galore? | 14:40 |
| rick_h__ | kadams54: you've been shamed, carry on | 14:40 |
| kadams54 | :-) | 14:40 |
| rick_h__ | kadams54: if you had any questions or want feedback on your review bribe a friend to peek at the landing change please | 14:41 |
| * kadams54 ponders which mentor would be the cheapest to bribe. | 14:41 | |
| frankban | hatch: from my perspective, the db should be the single source of truth, and the idea of "changing a change in the changeset" doesn't feel so natural... I feel like it's going to be difficult to debug. | 14:42 |
| rick_h__ | frankban: +1, but hatch's feedback is good that this branch will break rendering. This branch needs to update that to follow this convention in order to land. Am I understanding this correctly? | 14:43 |
| frankban | rick_h__: rendering is already broken on trunk: name changes are not reflected on the panel | 14:44 |
| frankban | rick_h__: my branch affects how you will solve that | 14:44 |
| rick_h__ | frankban: ok, so existing bug. /me looks for a card for that | 14:44 |
| rick_h__ | frankban: ah, that's why hatch is noticing, that's a card he's tryinug to do | 14:44 |
| frankban | rick_h__: yes | 14:45 |
| rick_h__ | hatch: so why does frankban's changes not allow you to solve your cards with that in effect by repointing where the rendered names come from? | 14:45 |
| hatch | so my problem is that if we are going this direction (which I agree is a good one) the ecs needs to drop the extranious data and use the db as the source of truth on commit. The deployer bar then needs to listen to any changes in the db and then determine if it needs to update anything in it's list, and so-on | 14:46 |
| hatch | at the moment we are going only part-way there which is just going to get confusing and introduce potential bugs | 14:46 |
| hatch | I'd much rather get MV out the door then go back and fix things | 14:46 |
| rick_h__ | hatch: frankban ok, let's chat post-standup and plan a path that will work for this | 14:47 |
| frankban | rick_h__: sure | 14:47 |
| rick_h__ | otp atm and can't meet pre-call | 14:47 |
| hatch | np | 14:47 |
| jcsackett | frankban: safe to bet that you now don't need that second review? sounds like that PR may see some major changes. | 14:49 |
| hatch | maybe... | 14:49 |
| hatch | :) | 14:49 |
| hatch | jujugui call in 10 | 14:50 |
| jcsackett | kadams54: i see you've got a card in review, but there's no pr up yet--is PR coming, or has this already been reviewed? | 14:52 |
| kadams54 | Which card? | 14:52 |
| jcsackett | kadams54: "display services without machines ..." | 14:54 |
| jcsackett | is LK just not updating for me? | 14:54 |
| frankban | jcsackett: you are right I don't need that now. however, your I'd be interested in your opinion on the design decision if you want to take a look | 14:54 |
| jcsackett | frankban: ack, i'll take a look then. | 14:54 |
| kadams54 | jcsackett: hmm… that should have a PR… one moment… | 14:55 |
| frankban | jcsackett: thanks | 14:55 |
| rick_h__ | makyo_: call please | 15:00 |
| * makyo_ zooms back home | 15:12 | |
| bac | rick_h__: i just posted two vacation requests and a holiday for september. | 15:17 |
| rick_h__ | bac: cool loading | 15:22 |
| hatch | jujugui lf another review on https://github.com/juju/juju-gui/pull/465 | 15:28 |
| rogpeppe | Makyo: reviewed | 15:29 |
| frankban | hatch: why the change list shown when you click deploy and the one displayed when you click "X changes" are two different code paths? | 15:31 |
| frankban | hatch: UX reasons? | 15:32 |
| hatch | frankban I'm not sure I didn't write this | 15:38 |
| frankban | hatch: ok | 15:38 |
| rick_h__ | hatch: frankban ask jcsackett | 15:38 |
| rick_h__ | hatch: frankban there is some UX diff and such, I know there was some talk of reuse when it was added but don't recall the final fallout | 15:38 |
| jcsackett | rick_h__: i think that was "sprint to demo" fallout. | 15:38 |
| frankban | heh | 15:39 |
| rick_h__ | jcsackett: this is making the changes button work. That was after the sprint stuff | 15:39 |
| frankban | rick_h__, jcsackett: fine thanks | 15:39 |
| jcsackett | rick_h__: we've touched it since then, but i remember hitting the two paths before that. | 15:39 |
| frankban | rick_h__, jcsackett: refactoring that is a separate task | 15:39 |
| jcsackett | rick_h__: in any event, while there are some differences, you can probably extract that into something more common. | 15:40 |
| jcsackett | frankban: +1, it can def wait. | 15:40 |
| hatch | ok I just found this....live stream..... wowzers http://www.nasa.gov/multimedia/nasatv/index.html | 15:46 |
| rick_h__ | man, I want to chromecast that fullscreen | 15:46 |
| hatch | right??!?!?! | 15:47 |
| * rogpeppe pulls the $$merge$$ trigger on https://github.com/juju/juju/pull/253 | 15:49 | |
| rogpeppe | fingers crossed | 15:49 |
| jcsackett | kadams54: ping me when you've got a PR up for your card. | 15:50 |
| rogpeppe | hatch: cool! | 15:50 |
| kadams54 | Yup, writing up QA instructions right now. FYI, it'll require a real env. | 15:50 |
| hatch | rick_h__ people these days just don't seem to understand the amazeballsness of this stuff :) | 15:50 |
| jcsackett | frankban, hatch: y'all still dicussing the ecs/deployer issue? fwiw looking at frankban's PR i dig the approach, but i can see where it trips us up. i would like us to move in that direction though. | 15:52 |
| hatch | jcsackett sorry we already did | 15:52 |
| hatch | ended up with a good way forward | 15:52 |
| jcsackett | hatch: oh, i didn't want to be in the meeting, i just want to know the outcome. :p | 15:53 |
| hatch | oh ok then in that case... | 15:53 |
| hatch | when the deployer bar gets opened to list the tasks it will query the db when required for the real values instead of extracting them from the ecs | 15:53 |
| hatch | that way it doesn't actually have to listen to the db for changes | 15:53 |
| rick_h__ | woot! phone upgrades ftw. 4.4.4 finally | 15:53 |
| frankban | jcsackett: good to know, we will follow that approach, I will just add a commit to that branch to also handle the deployer panel | 15:53 |
| hatch | and we aren't live updating the dom anyways | 15:53 |
| jcsackett | hatch: so you are going to tackle that for your branch then? | 15:54 |
| hatch | rick_h__ nice - on the Moto? | 15:54 |
| hatch | jcsackett no frankban will add it to his | 15:54 |
| rick_h__ | hatch: yea, dev edition | 15:54 |
| hatch | nice | 15:54 |
| jcsackett | hatch: ah, ok. i'll take a look at frankban's PR when that commit hits then. | 15:54 |
| hatch | I'm not sure what I'm on (goes to grab phone) | 15:54 |
| jcsackett | well, take another look. | 15:54 |
| frankban | jcsackett: thanks, appreciated | 15:54 |
| rogpeppe | dammit, i missed my window of opportunity. juju-core is blocked again. | 15:55 |
| hatch | 4.4.2 here :) on the HTC One m7 retail edition :) | 15:55 |
| rick_h__ | rogpeppe: saw that :( | 15:55 |
| hatch | how does it get blocked? | 15:56 |
| hatch | fialing CI? | 15:56 |
| rick_h__ | hatch: yea | 15:56 |
| rick_h__ | when you're big enough that stuff has to be landable before a CI run can complete. | 15:56 |
| rick_h__ | may we never get that big :) | 15:57 |
| hatch | haha - their CI runs must take a while | 15:58 |
| rogpeppe | rick_h__: +1 | 16:00 |
| rick_h__ | rogpeppe: if you get some break time could you do us a favor as a juju-core friendly person? We need to generate the list/chart of containers that are valid for different machines/environments. | 16:02 |
| rick_h__ | rogpeppe: what does juju allow? Does it even know the rules? I know AMZ can only have an LXC, for instance. And an LXC (local) I think can only have a KVM, etc | 16:02 |
| rogpeppe | rick_h__: jeeze, i have little idea. last i looked, the only place containers worked reliably was on maas (and perhaps openstack) | 16:03 |
| rogpeppe | rick_h__: does networking now work between containers on ec2? | 16:03 |
| rogpeppe | rick_h__: i know there's been lots of work in that direction, but i don't know what the current status is | 16:04 |
| rick_h__ | rogpeppe: understood. I believe lxc containers should work. I know there was work for nested lxc on local. There's an email thread around that going on currently. | 16:04 |
| rick_h__ | rogpeppe: right, I assumed at some point juju would say yes/no when a request was made that the rules would be encoded there in core. | 16:04 |
| rick_h__ | rogpeppe: and you'd be best able to know where that might lie | 16:04 |
| rogpeppe | rick_h__: it's a rats' nest | 16:04 |
| rick_h__ | rogpeppe: oh yay | 16:05 |
| rogpeppe | rick_h__: i'm not even sure it forbids you from starting containers that may not work | 16:06 |
| rogpeppe | rick_h__: thumper's the man to speak to about this stuff | 16:06 |
| rick_h__ | rogpeppe: ok, my sadness levels are increasing. | 16:06 |
| rick_h__ | rogpeppe: ok, will do. I'll add a card and will see what we can figure out. Thanks | 16:07 |
| jcsackett | rick_h__: where should we create cards that are dependent on ditching the mv flag? that whole updated unit count thing we discussed can't be done until we can rip out all the old scaling stuff, which won't happen until mv is gone. | 16:17 |
| * frankban bbiab | 16:17 | |
| jcsackett | is that on deck, or further off? | 16:18 |
| hatch | frankban I updated your card on the board and deleted mine | 16:19 |
| rick_h__ | jcsackett: sorry, was looking elsewhere. What unit count thing? | 16:21 |
| hatch | jujugui I still need one more review for https://github.com/juju/juju-gui/pull/465 | 16:22 |
| jcsackett | rick_h__: maybe i didn't talk with you about this, just hatch. once we only have the new scale out there's a bunch of unit count handling we don't need to do anymore; i was starting in on killing it in the branch i just put up for review, and then realized it screwed up the w/o MV path. | 16:23 |
| jcsackett | basically: should refactors that depend on MV flag being gone go in on deck, or pool? that's the question. :p | 16:24 |
| rick_h__ | jcsackett: I've been moving them to on deck | 16:24 |
| jcsackett | rick_h__: awesome, thanks. | 16:24 |
| rick_h__ | jcsackett: but you're right, they're post-release cleanup cards | 16:24 |
| * jcsackett is excited to have that refactor done. | 16:24 | |
| hatch | jcsackett you forgot to run lint again | 16:30 |
| hatch | :P | 16:31 |
| jcsackett | i have a pre push hook that keeps telling me it's ok. | 16:35 |
| jcsackett | but it seems to not run, or something. | 16:35 |
| jcsackett | sure takes a long damn time for not running anything. | 16:36 |
| hatch | lol | 16:36 |
| hatch | jcsackett review done, I added a couple comments, I'll hold off on QA until you take a look | 16:36 |
| jcsackett | hatch: responded. | 16:38 |
| hatch | jcsackett annnnd replied | 16:43 |
| hatch | :) | 16:43 |
| hatch | *grumble grumble grumble* I think the cs is doing an ingestion again | 16:45 |
| Makyo | rick_h__, I got two +1s from rogpeppe and jrwren on jujusvg. Since we don't have CI hooked up, is that just a plain click-the-green-button merge, then? | 16:47 |
| Makyo | Just making sure I've got the process down | 16:47 |
| rogpeppe | Makyo: i'd say so | 16:47 |
| rogpeppe | Makyo: i'm guessing you made the changes i suggested? | 16:48 |
| Makyo | rogpeppe, yeah, and pushed. Thanks for the suggestions - much simpler now. | 16:48 |
| rogpeppe | Makyo: cool, thanks. | 16:48 |
| rogpeppe | listening to some stuff I hadn't listend to in years. man, the start of mahler 1, 4th movement is quite something. | 16:50 |
| Makyo | Mahler's dreamy~ | 16:50 |
| rogpeppe | Makyo: my grandmum gave me a tape of it when i was about 9; i don't think i've listened to it since the tape wore out about 10 years later :-) | 16:51 |
| rogpeppe | Makyo: i recently threw out a large box of tapes, but not before i made a copy of them all as a Spotify playlist... | 16:52 |
| Makyo | rogpeppe, yeah! I did that with a bunch of CDs a while back (though some I had to buy off iTunes or the like if they weren't on spotify) | 16:52 |
| jcsackett | hatch: so we can move it into addUnits, but we're going to have to call it once for every unit that's added, b/c it requires the service and there's no guarantee that we're adding units of just one service. | 16:53 |
| jcsackett | which seems like a lot of churn. | 16:53 |
| hatch | dont' we have to do that anyways now that we are manually updating the unit_count? | 16:53 |
| jcsackett | hatch: no, we can do a bunch of addUnit ops and then sync once per service. | 16:55 |
| hatch | hmm | 16:55 |
| jcsackett | hatch: but nevermind, given we're going to kill this as soon as remove the mv flag i think it's temporarily fine. | 16:55 |
| hatch | what I'm trying to avoid is the introduction of bugs because someone forgot to call some obscure method in another part of the app | 16:55 |
| jcsackett | hatch: yeah. | 16:56 |
| jcsackett | we run it for every call of onDelta--clearly it can't be hurting us that much. | 16:56 |
| hatch | good point | 16:56 |
| kadams54 | jcsackett: https://github.com/juju/juju-gui/pull/471 ready for QA and review. | 16:56 |
| jcsackett | hatch: of course now a ton of tests crap their pants. | 16:57 |
| jcsackett | hatch: i'll continue pursuing this after i review kadams54 branch. | 16:57 |
| hatch | jcsackett heh you should be able to just stub it out | 16:58 |
| jcsackett | hatch: yes. in like 90 places. | 16:58 |
| jcsackett | a *lot* of things deal with addUnits. :p | 16:58 |
| hatch | hmm, and you're saying that we will be removing this call in the near future? | 16:58 |
| jcsackett | hatch: ideally, but i can't guarantee a timeline. | 16:59 |
| jcsackett | i think you're right about moving it so we don't have a landmine for someone else. | 17:00 |
| jcsackett | and once we dig into this to remove it we may only be removing part of it. | 17:00 |
| jcsackett | kadams54: lint. | 17:00 |
| hatch | alright sounds good | 17:00 |
| kadams54 | jcsackett: yeah, fixing :-( | 17:00 |
| jrwren | I don't know Mahler's 1st. I only know 5th, 9th, and 10th. 1st is good eh? | 17:02 |
| jcsackett | kadams54: so, machineData.id is how we know if the machine has a service? | 17:06 |
| jcsackett | the check seems a little obtuse to me, as it's written. | 17:06 |
| kadams54 | I would switch it around… machineData.id is how we know if a service has a machine associated with it. | 17:07 |
| jcsackett | kadams54: no, it's fine, just making sure i understood. | 17:07 |
| jcsackett | obtuse to me doesn't always imply wrong. :p | 17:07 |
| kadams54 | And yes, that's why the check has comments above it :-) | 17:07 |
| jcsackett | kadams54: updating my live env to check yours QA could take a bit. | 17:11 |
| jcsackett | in the meantime, juju-gui, https://github.com/juju/juju-gui/pull/471 needs a second review. | 17:11 |
| jcsackett | er, jujugui ^ | 17:11 |
| rick_h__ | Makyo: +1, just make sure that tests pass before hitting that button please | 17:12 |
| rick_h__ | yay, meeting break. /me goes to get lunchables | 17:14 |
| jcsackett | kadams54: my local environment completely fubarred itself (nothing to do with your code) | 17:53 |
| jcsackett | i'm having to start up a new one, so further delays on QA. | 17:53 |
| kadams54 | jcsackett: While I'm relieved that my changes didn't do it, sorry this QA is so painful. | 17:54 |
| jcsackett | kadams54: i always have *really* bad luck setting the source for the gui charm. | 17:55 |
| jcsackett | i'd say there's a 1 in 3 chance it'll crap out and never recover for me. | 17:55 |
| kadams54 | guihelp: anyone know why juju websocket requests aren't showing up in Chrome's dev tools (Network tab, websocket filter enabled) for me? | 17:56 |
| rick_h__ | kadams54: reload the page? The network tab must be open at the start of the page load to get them | 17:57 |
| hatch | kadams54 quit using Canary? | 17:57 |
| hatch | sorry - had to | 17:57 |
| kadams54 | hatch: Hah! THe latest and greatest web dev tools is *why* I use Canary :-) | 17:57 |
| rick_h__ | +1 | 17:57 |
| rick_h__ | hatch: :P | 17:57 |
| kadams54 | rick_h__: I think that's likely the problem, thanks. | 17:58 |
| rogpeppe | jrwren: 1st is awesome. | 18:00 |
| rogpeppe | jrwren: but i might be biased 'cos it was the first i ever heard | 18:01 |
| jrwren | Melborn, Sydney or BBC ? | 18:02 |
| rick_h__ | kadams54: call? | 18:03 |
| kadams54 | rick_h__: ah yes, sorry, be right there in a minute | 18:03 |
| rogpeppe | bac, jrwren, urulama: https://github.com/juju/charmstore/pull/50 | 18:11 |
| rogpeppe | rick_h__: FYI i now have goahead on the charm.v3 changes. | 18:11 |
| rogpeppe | rick_h__: will push tomorrow | 18:11 |
| rogpeppe | g'night all | 18:12 |
| urulama | rogpeppe: good night | 18:12 |
| urulama | rogpeppe: excellent news on v3! | 18:12 |
| urulama | rogpeppe: c u tomorrow | 18:12 |
| rogpeppe | urulama: yup | 18:12 |
| rogpeppe | urulama: ttfn | 18:12 |
| rick_h__ | rogpeppe: woot | 18:13 |
| rick_h__ | night rogpeppe | 18:13 |
| jrwren | rogpeppe: i almost asked about params.Error in the last review. :) | 18:17 |
| hatch | bac you're running Ubuntu in Fusion right? Which version are you using? | 18:32 |
| bac | hatch: yes. let me look | 18:32 |
| bac | hatch: 6.0.4 | 18:32 |
| hatch | thanks, I have Parallels which runs windows 8 awesome but I'm hesitant to upgrade to support the latest Ubuntu because their current Ubuntu support is so poor | 18:33 |
| hatch | are there any issues with it? | 18:33 |
| bac | hatch: the ubikey does not work with it (though i haven't checked since the latest update) | 18:33 |
| bac | hatch: other than that, i've had great success | 18:34 |
| hatch | doesn't the ubikey just act as a keyboard? :) | 18:34 |
| bac | no | 18:35 |
| hatch | oh I thought tha'ts how it worked | 18:35 |
| bac | ccccccdiltlgcvgvvfibkllgcjfiujkdkhtiucinnlcl | 18:35 |
| hatch | case, point | 18:35 |
| hatch | :P | 18:35 |
| bac | hey, works here | 18:35 |
| bac | :) | 18:35 |
| hatch | haha | 18:35 |
| hatch | hey it's even cheaper to buy fusion than parallels | 18:35 |
| hatch | nice I'll try the demo | 18:36 |
| hatch | er...trial as they call it | 18:36 |
| hatch | :) | 18:36 |
| hatch | I really tried to get Ubuntu working on metal on this thing but with the discrete gpu the battery life is like 20% what it is in OSX heh | 18:37 |
| bac | hatch: according to this post, it should work again as of 6.0.3 | 18:38 |
| bac | https://communities.vmware.com/thread/462755?start=15&tstart=0 | 18:38 |
| hatch | ahh cool | 18:38 |
| hatch | does hotplugging thunderbolt ports work? | 18:38 |
| hatch | I guess I'll figure out myself tonight, but curious :) | 18:39 |
| bac | hatch: and it isn't just being a keyboard, but accepting the SSO programming that was the issue, i think. it was not being recognized. | 18:39 |
| hatch | SSO? | 18:39 |
| bac | hatch: ubuntu sso | 18:39 |
| hatch | ohh | 18:39 |
| bac | hatch: i don't have any thunderbolt devices i use within the VM | 18:40 |
| hatch | oh ok, my monitor is display port | 18:40 |
| hatch | guess I'll find out | 18:40 |
| bac | sadly i just stare at my laptop monitor | 18:40 |
| hatch | I've been doing that for a while but just switched back | 18:40 |
| hatch | need a 31" laptop monitor | 18:40 |
| bac | hatch: there is a display setting that make vmware use the retina properly. i didn't notice when the put it in and was looking at fuzzy display until frankban showed me last week. | 18:41 |
| hatch | oh cool I'll be sure to remember to look for that | 18:41 |
| urulama | hatch, bac: or just use parallels ... it's faster/better in all aspects, well, except the price tag ;) | 18:49 |
| hatch | urulama that's the problem though, Parallels has caused me nothing but pain with Ubuntu | 18:50 |
| urulama | hatch: really? it works as a charm for me ;) | 18:50 |
| hatch | and their support is absolute @#$%^ | 18:50 |
| bac | urulama: you charmed parallels? | 18:50 |
| urulama | :D | 18:50 |
| hatch | urulama what version of parallels are you on? | 18:50 |
| urulama | hatch: a, that is the trick ... always use latest | 18:51 |
| hatch | urulama when 14.04 came out no version of Parallels supported it, both virtualbox and fusion did | 18:51 |
| urulama | hatch: they did, all you had to do is rename some xorg.conf files coz compiz and parallels tools were out of sync | 18:52 |
| urulama | after that (3min job) all was fine ... i do admit that they should have fixed that asap | 18:52 |
| hatch | urulama if you have to hack xorg files when they had more than enough time to release a patch, even months after it was released, then something is wrong | 18:53 |
| hatch | I'm not sure I trust them inotherwords | 18:53 |
| urulama | hatch: i've been using them for 3 years, and i have to admit that version 9 is the worst one ... if the trend continues with v10, i'm also open for alternatives | 18:54 |
| hatch | that's good to know because I'm using 8, I think I'll give fusion a go | 18:54 |
| hatch | they are so focused on windows that they probably have one poor dev trying to make ubuntu work in their free time lol | 18:55 |
| * urulama sees "slack and low priority" kanban board ;) | 18:56 | |
| rick_h__ | jujugui going afk a bit until the AU calls. I'll be a bit late for those, swim class (if the rain stays away) please give huw the heads up later. We will have the AU calls though | 18:56 |
| hatch | urulama exactly!! Except we don't charge $99 for the GUI :P | 18:56 |
| hatch | rick_h__ sounds good | 18:56 |
| urulama | rick_h__: enjoy | 18:56 |
| bac | hatch: i got yubi to work in fusion | 19:12 |
| bac | hatch: the only issue is doing the personalization. to do that the VM has to recognize it as a USB device not a keyboard. once it is personalized it works as a keyboard in both OSs | 19:13 |
| hatch | interesting | 19:14 |
| hatch | I'll have to remember that | 19:14 |
| bac | hatch: and the key to that is adding a stanza to the .vmx file | 19:14 |
| bac | usb.generic.allowHID = "TRUE" | 19:14 |
| hatch | so you have to do that even running 6.0.4? | 19:14 |
| bac | sadly yes | 19:14 |
| bac | hatch: and doing that gives you the opportunity to steal laptop keyboard from os x. yikes. | 19:15 |
| bac | s/steal/steal the/ | 19:16 |
| hatch | not sure what you mean | 19:16 |
| bac | when you add that config, it makes the yubikey visible as a usb device that you can pick and assign to the VM. it *also* makes the in-built keyboard visible and assignable to the VM, blocking OS X from seeing the keyboard. not advised. | 19:17 |
| hatch | ohh yeah that wouldn't be advised heh | 19:19 |
| jcsackett | kadams54: i think you should find someone else to QA your branch--i have ascertained my juju is hosed, as it cannot bring up juju-gui locally or on ec2. | 19:20 |
| hatch | jcsackett you have the worst luck | 19:22 |
| kadams54 | jcsackett: ugh. Sorry man. So… who's up for QA on the cursed branch? | 19:34 |
| kadams54 | ;-) | 19:34 |
| kadams54 | jujugui: ^ | 19:34 |
| kadams54 | guihelp: how does the ECS send commands over to core when the deploy button is clicked? I'd assumed websocket to RPC, but I'm still seeing nothing in web inspector (and that's even in plain vanilla Chrome). | 19:59 |
| hatch | kadams54 via the gui backend | 20:00 |
| hatch | it just executes teh env calls | 20:00 |
| hatch | but yes it is via websocket to a real env | 20:00 |
| kadams54 | And the env function (at least in the case of go.js) makes the call via websockets to RPC, right? | 20:00 |
| hatch | correct | 20:00 |
| kadams54 | Grr. | 20:00 |
| hatch | RPC calls via WS | 20:00 |
| hatch__ | jujugui does anyone object to me excluding Oneric results from the autocomplete result list? | 20:48 |
| hatch__ | they would still be in the search results, but not in the autocomplete | 20:49 |
| bac | hatch__: +1 | 20:49 |
| hatch__ | bac what in the case where it's only oneric charms? | 20:49 |
| hatch__ | should I show then? or show nothing | 20:49 |
| hatch__ | I'm thinking nothing | 20:49 |
| hatch__ | 11.10 was a long a$$ time ago :) | 20:49 |
| hatch__ | and not even an LTS | 20:50 |
| hatch__ | and it's eol'd | 20:50 |
| hatch__ | so yeah, not even going to show oneric stuff | 20:50 |
| hatch__ | :) | 20:50 |
| bac | as long as they are in the full results i think it's ok | 20:50 |
| hatch__ | ok done thx | 20:51 |
| urulama | jrwren, rick_h__: added few cards for charmstore charm as suggested | 20:52 |
| urulama | g'night all | 21:01 |
| rick_h__ | kadams54: link me to what review you need | 21:08 |
| rick_h__ | kadams54: I can do it tonight and have it ready for you in the morning | 21:08 |
| kadams54 | rick_h__: https://github.com/juju/juju-gui/pull/471 | 21:09 |
| kadams54 | rick_h__: thanks | 21:09 |
| hatch__ | one test to go then this new AC result list is done | 21:11 |
| hatch__ | it's bumpin! | 21:11 |
| rick_h__ | woot | 21:11 |
| rick_h__ | happy dance worthy? | 21:11 |
| hatch__ | definitely | 21:11 |
| === hatch__ is now known as hatch | ||
| hatch | I think think there is something borked with the ngramming, maybe when I get a moment I'll try and take a look at it though, it's putting the wrong values on some fields I think | 21:17 |
| hatch | jujugui I need two reviews and qa https://github.com/juju/juju-gui/pull/472 plz and thanks | 21:30 |
| hatch | jcastro ^ I'm pretty sure you'll be happy with the autocomplete results from this branch | 21:31 |
| hatch | jcastro oneiric charms no longer show up in the autocomplete list and you only ever get the 'best possible' charms listed for what you're searching for - the full search results still contain all results of course too | 21:32 |
| hatch | jujugui anyone available for a review ? | 22:09 |
| jrwren | hatch: i'm afraid to review it. | 22:13 |
| hatch | haha - have you had the GUI up and running locally yet? | 22:14 |
| jrwren | no. | 22:14 |
| jrwren | The most GUI that I've run is what juju-quickstart gives me. | 22:14 |
| hatch | ahh then yeah this might be a bit of work for ya | 22:15 |
| hatch | but the hacking guide should be good enough | 22:15 |
| hatch | you should go through it and make notes of where it falls short | 22:15 |
| huwshimi | Morning | 22:20 |
| hatch | goooood morrow | 22:20 |
| hatch | I have a good review for you huwshimi https://github.com/juju/juju-gui/pull/472 | 22:20 |
| huwshimi | Ugh | 22:21 |
| huwshimi | hatch: By good, I think you meant, eye melting | 22:22 |
| hatch | lol, just hand wave over the algo bits | 22:22 |
| hatch | and do the qa :D | 22:22 |
| hatch | the qa is the important part anyways haha | 22:22 |
| huwshimi | ok :) | 22:24 |
| hatch | bac so I have a very odd problem, the background of the VM is only 1/5th the size of the screen, but everything else has good resolution.... | 22:25 |
| huwshimi | hatch, rick_h__: Are we doing an AUS call today? | 22:37 |
| hatch | huwshimi yes but rick is delayed | 22:38 |
| hatch | swimming lessons or something | 22:38 |
| huwshimi | Ah np | 22:38 |
| hatch | I plan on getting drunk at 5pm | 22:38 |
| hatch | so better hurry | 22:38 |
| hatch | lol jk | 22:38 |
| huwshimi | that would make an interesting stand up | 22:40 |
| huwshimi | or lean | 22:40 |
| hatch | haa | 22:41 |
| hatch | leanup | 22:41 |
| hatch | https://www.youtube.com/watch?v=Ywgync45Eis <--- lol funny kiteboarding vid | 22:41 |
| huwshimi | hatch: Weird we have a recommended mysql charm without an icon | 22:45 |
| hatch | the oneric one? | 22:45 |
| huwshimi | hatch: Nope precise | 22:45 |
| huwshimi | http://localhost:8888/precise/cf-mysql-1/:flags:/mv/?text=cf-mysql | 22:45 |
| hatch | ohh yeah | 22:45 |
| huwshimi | hatch: So when I do that search for mysql it suggests that one before the mysql one, seems wrong | 22:46 |
| hatch | yeah I think the ngramming is busted | 22:46 |
| rick_h__ | huwshimi: jujugui call in 2? | 22:53 |
| huwshimi | rick_h__: sure | 22:53 |
| huwshimi | hatch: So when I type "mysql" it shows cf-mysql then mysql and when I typ "cf-mysql" it shows the same (cf-mysql then mysql). That doesn't seem like a great ordering | 22:54 |
| jrwren | hatch: lol @ your node charm hooks. :) | 23:31 |
| hatch | whaaaat | 23:31 |
| hatch | :) | 23:31 |
| hatch | you can't handle their epicness? | 23:31 |
| jrwren | Yes, I think that is what made me chuckle. | 23:32 |
| hatch | they are really simple | 23:34 |
| hatch | huwshimi let me know if you need any more reviews so we can get some of your branches landed | 23:36 |
| jrwren | Yes, it was just a surprise. Probably, a reasonable node hook reference. Maybe could be used as a node template in charm-tools | 23:36 |
| hatch | the only issue we had in writing it was that node doesn't provide synchronous shell-out methods | 23:37 |
| hatch | so everything had to be in callbacks | 23:38 |
| hatch | it made things which required many shell-outs to get ugly | 23:38 |
| hatch | those have since been changed | 23:38 |
| hatch | this for example https://github.com/hatched/ghost-charm/blob/master/hooks/balancer-relation-changed | 23:38 |
| hatch | it has to do it in order, but the code is not in order | 23:39 |
| jrwren | That is always the nature of node or really any CPS system. | 23:39 |
| jrwren | you could make it in order by using inline functions everywhere. I'm sure it would get fun when you nest 10 deep. :) | 23:40 |
| hatch | haha definitely an antipattern | 23:41 |
| huwshimi | hatch: A second review on https://github.com/juju/juju-gui/pull/467 might be good, unless you want to wait till I fix that QA issue | 23:47 |
| hatch | huwshimi yeah I'll wait, I'll be around all night | 23:47 |
| hatch | so just ping whwnever you need one | 23:48 |
| huwshimi | hatch: Np | 23:48 |
| huwshimi | hatch: Do you need a real env review for you pr https://github.com/juju/juju-gui/pull/472 ? | 23:48 |
| huwshimi | (QA) | 23:48 |
| hatch | huwshimi well you can also hack the default series if you like | 23:50 |
| huwshimi | hatch: Ah that might be easier | 23:51 |
| hatch | app.js getEnvDefaultSeries() change it to return 'trusty' | 23:51 |
| hatch | hmm it doesn't look like I can install chrome in my new vm | 23:53 |
| hatch | odd | 23:53 |
| huwshimi | heh | 23:53 |
| hatch | will try the 32 bit | 23:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!