| duflu | AlbertA: Around? | 02:01 |
|---|---|---|
| === _mu is now known as Nothing_Much | ||
| === chihchun_afk is now known as chihchun | ||
| === tvoss is now known as tvoss|test | ||
| === tvoss|test is now known as tvoss | ||
| === renato is now known as Guest39756 | ||
| alan_g | alf_: fixed for mir_server_mesa_egl_native_display_is_valid() - is it OK now? https://code.launchpad.net/~alan-griffiths/mir/fix-mirplatformgraphics/+merge/228815 | 09:26 |
| alf_ | alan_g: looks good, (top) approved | 09:28 |
| alan_g | thanks | 09:28 |
| alan_g | greyback: does this capture all the "configuring Mir" issues we discussed a while back? https://bugs.launchpad.net/mir/+bug/1351255 | 10:17 |
| ubot5 | Launchpad bug 1351255 in Mir "[enhancement] It should be possible to customize configuration options without going via boost options and the commandline" [Wishlist,New] | 10:17 |
| greyback | alan_g: yep, thank you. I commented on what would work for us. See what you think | 10:34 |
| === vila is now known as vila-lunch | ||
| alf_ | alan_g: When we call mir_connection_release() the lifecycle callback for connection lost gets called... Do you know if this was done on purpose? | 10:54 |
| === vila-lunch is now known as vila | ||
| === chihchun is now known as chihchun_afk | ||
| alan_g | alf_: I've no recollection of the issues around that | 11:51 |
| alf_ | alan_g: thanks | 11:53 |
| === Stskeepz is now known as Stskeeps | ||
| === alan_g is now known as alan_g|lunch | ||
| === chihchun_afk is now known as chihchun | ||
| === alan_g|lunch is now known as alan_g | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| alan_g | greyback: if mo::DefaultConfiguration had a virtual function "bool accept_unparsed_arguments(vector<string> const&)" would that work for you? | 13:57 |
| === chihchun is now known as chihchun_afk | ||
| greyback | alan_g: not clear what that does. Do I pass it the env vars? What does the return value mean? | 14:00 |
| alan_g | You could override it with your own command-line processor logic | 14:00 |
| alan_g | @https://bugs.launchpad.net/mir/+bug/1351255/comments/1 | 14:01 |
| ubot5 | Launchpad bug 1351255 in Mir "[enhancement] It should be possible to customize configuration options without going via boost options and the commandline" [Wishlist,New] | 14:01 |
| alan_g | It isn't literally what you asked for, but would be easier to implement. | 14:02 |
| greyback | alan_g: so I need to give Mir a list of command line arguments to ignore? | 14:02 |
| alan_g | No. Anything Mir doesn't recognised is passed in the argument | 14:03 |
| alan_g | Anything Mir did process has been stripped | 14:04 |
| greyback | alan_g: ok I see. Let me think about it please | 14:05 |
| alan_g | Actually, maybe void is a better return type: if you're unhappy you can just throw an exception. | 14:06 |
| alan_g | void mo::DefaultConfiguration::handle_unparsed_arguments(vector<string> const& argv) | 14:07 |
| alan_g | greyback: Another option would for you to pass a function<void(vector<string> const& argv)> to the constructor | 14:10 |
| greyback | alan_g: I think either would work for me. What I'd have to do is pass argv into mir, and then based on the handle_unparsed_arguments calls, re-assemble the stripped argv to then pass to Qt | 14:12 |
| alan_g | greyback: yes. You'd prefer vector<char*>? (To use "tokens.size(), tokens.data()") | 14:14 |
| greyback | alan_g: yep, would prefer char* | 14:14 |
| alan_g | OK, so long as you can accept you don't control the lifetime of the pointee. | 14:15 |
| alan_g | A "function<>" would probably be the least coupled approach, does that cause any problems? | 14:16 |
| greyback | alan_g: not really, I can work with it | 14:17 |
| alan_g | greyback: OK one unparsed_arguments callback coming up | 14:18 |
| greyback | alan_g: thank you :) | 14:18 |
| === renato is now known as Guest43934 | ||
| === alan_g is now known as alan_g|EOW | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!