[05:52] morning [06:07] rick_h__: Morning [06:14] huwshimi: hey, funny running into you there [06:14] rick_h__: Yeah, strange to see you at this time :) [06:14] rick_h__: How was the travel? [06:17] huwshimi: you know, time in a tin can flying through the sky [06:17] hehe [06:17] working on catching up on sleep [07:10] mornin' all [07:14] Morning [07:21] morning all [07:35] urulama: hiya [13:19] anyone with good http-fu know what's going on at line 1503 here? http://golang.org/src/pkg/net/http/server.go#L1503 [14:45] Makyo: do you know if a unit would ever *not* have a state outside of being uncommitted? [14:46] jcsackett, units should always have a state, I believe. Is something going wrong? [14:46] Makyo: no, not at all. that's a good answer. :) [14:46] uncommitted units don't have agent_state, which makes sense. [14:46] urulama, jrwren: https://github.com/juju/charmstore/pull/52 [14:47] the QA issue you found was b/c the condition for identifying uncommitted units isn't correct once the service is deployed. [14:47] anyone know if frankban is around today? [14:47] but since they don't have state, we can use that. [14:47] and that's always accurate. [14:47] or bac [14:47] rogpeppe, frankban is out today on swap. [14:47] Makyo: ah, thanks [14:47] jcsackett, ah, yeah, that makes sense [14:48] rogpeppe: bac is in nuremburg. [14:48] Boo, forgot about that., [14:48] CI doesn't seem to be working for me. [14:48] jcsackett: ah, i'd forgotten about that [14:48] Maybe jenkins needs a kick in the pants [14:49] i guess i'm just not gonna land anything today [14:49] * rogpeppe goes to the pub :-) [14:50] * jcsackett laughs [14:50] rogpeppe: starved for reviews, or jenkins issues? [14:50] jcsackett: reviews [14:51] jcsackett: i think there's only one person around ( jrwren ) that can review the code, but i need two reviews for landing [14:52] rogpeppe: can Makyo or hatch sub in for today, or do you need deep knowledge of the code base? they're both go-literate, if memory serves. [14:52] (it's not ideal, but better than blocking) [14:54] jujugui call in 6 [14:55] rogpeppe: i'll try to do it [14:55] rogpeppe: but it's a huge one and with interruptions, it might take a while :) [14:55] urulama: if you could, that would be great. unfortunately, it's a bit of a bad of bits. [14:56] perhaps i should try to split it up [14:56] anyone know of a good tool for splitting up branches? [14:57] * urulama suggests an axe [14:57] lol [15:00] jujugui call now. [15:18] http://ci.jujugui.org:8080 its up [15:18] I have no answers for why it wasn't up. [15:19] jrwren, awesome, thanks [15:34] jcsackett: finished QAing your PR [15:35] Makyo: you mentioned running debug logging while setting the juju-gui-source… how do I do that? [15:35] juju debug-log [15:38] This is what I get: http://pastie.org/private/8kodvcgaorziu7fq9evxa [15:39] Seems to be an error right off the bat, maybe in fetching the new source from git? [15:44] guihelp: ^ [15:45] kadams54: thanks. [16:08] hey all, anyone know what's the status of hatch's card and potential gui release? [16:09] jujugui ^ [16:14] rick_h__, working on QAing now, then checking on some problems with the charm, then I'll see about starting release prep. [16:14] Makyo: awesome thanks. [16:14] Makyo: what's up with the charm? [16:15] rogpeppe: i've looked your PR ... it's huge, for last parts /v4/stats.go and stats_test.go i need more time ... [16:16] rick_h__, some folks are having trouble setting juju-gui-source - looks like it fails to start back up. [16:16] Going to research that. [16:16] urulama: yes, i'm sorry about that [16:16] urulama: i fixed lots of things in an organic way when trying to make the tests pass [16:16] Makyo: note that only works in trusty and not precise due to git changes [16:16] rogpeppe: yes, that's what i'm worried about [16:17] need to go to dinner [16:17] urulama: i could spend a few hours splitting it up [16:18] rick_h__, Aha! Good to note. kadams54 ^ [16:19] Makyo: yea, would love to get details on the series and the string used for that field to make sure it's supposed to work [16:19] Makyo: so trusty + 'develop' should be trunk and be good to test with [16:19] and should come up, if not there's a log file to check in /var/log/juju/all-? [17:16] rick_h__, Makyo: alas, I'm in trusty. [17:16] I didn't see anything obvious in the all-machines.log file, but I'm going to give it another go, this time tailing both that and running debug-log [17:20] * rogpeppe is done for the day [17:20] g'night all [17:38] Can't seem to deploy the charm at all, hmm. [17:40] rick_h__, Makyo: And of course, this time, it appears to have worked for me. FWIW, I confirmed that my card, bug #1341653, seems to be fixed. [17:40] kadams54, Woo! [17:40] I might be running into a juju bug, not sure. Trying on other computer. [17:42] I'm going to see if I can clear a few more cards out of the QA queue. [17:51] Yeah, seems to be something weird going on in tip, up and QAing juju-gui-source now. [18:09] Makyo juju-core is failing CI atm so you'd best to use a stable release [18:09] hatch, so I found. [18:09] Now go back to not working. [18:10] It's a holiday :) [18:10] haha I am not working :) I have to do html's and css's for my dads website....bleh, I wonder if I could convince huw to do this for me lol [18:10] right Monday Holiday [18:10] Provincial Day! [18:10] anyone in here familiar with the charmhelpers.contrib.jujugui python module? [18:11] jujugui https://twitter.com/FromAnEgg/status/496158671710466049 hahaha [18:11] i have a MR to remove it, wondering if anyone here cares [18:11] tvansteenburgh I've never even heard of it :) what does it do? [18:12] nothing any more! muwhahaha [18:12] lol w00t [21:09] hi there, jujugui [21:10] * urulama hears pings go all over the world ;) [21:10] haha hey urulama how goes ze Germans? [21:10] (little Top Gear reference there) [21:11] ze Germanz are fine ... at least their bear and pork products are ;) [21:11] s/bear/beer [21:12] * urulama now wonders what a bear tastes like [21:12] haha [21:12] tastes pretty gamey [21:12] you had one? [21:12] of course [21:12] elk deer, etc etc [21:13] I live in the North remember [21:13] north of the wall ;) [21:13] survival of the fittest :) [21:14] i had deer and boar and whatnot, but not bears ... and we have a lot of them, just not allowed to eat them [21:14] so how's it going? CI working now? [21:15] no idea, I'm off today [21:15] * kadams54 is going to start referring to hatch at "that wilder". [21:16] howdy all [21:16] urulama: I just landed a branch for juju-gui, so that CI seems to be working [21:16] rick_h__: hey there [21:17] hatch: remember the talk about being away from computer ... now's probably the time then :) [21:18] kadams54: ok, good news [21:19] Makyo: issues? no release it sounds like? [21:20] hey rick_h__ [21:21] urulama haha, I'm sitting in the back yard on the swingy chair with a beer working on my dads website.....it's pretty day-ofish :) [21:21] hey hatch [21:35] rick_h__, I think release is a go, pulling together changelog now. May actually go out tomorrow. [21:35] (was on the patio, sorry) [22:15] to submit forms on this vps I have to write a PHP script.... [22:16] I don't even think I remember how to write a form submission script in PHP any longer lol [22:17] I can't even write it in python.... [22:17] what kind of vps restricts to ONLY php [22:17] haha [22:38] Someone landed a branch while I was writing the change log and now there's a conflict >:/ [23:02] Morning [23:24] hatch: Morning, in a test I have a beforeEach that sets "placeUnit: utils.makeStubFunction()". How would I go about having one test that has the real function there? [23:24] jujugui GUI release is done. Going to get dinner prepped, then work on charm release. [23:24] Makyo: Yay! [23:25] On going through the change log, decided on 1.1.1, since much of our work was done behind a feature flag meant for a larger release. [23:25] huwshimi have a code sample? From that one there it looks like you're just passing in a fake stub not the actual ecs object? [23:25] Makyo +1 Thanks for doing the release! [23:26] hatch: Yeah, so it's stubbed out for all the tests, but it one test I don't want to stub it out... [23:26] huwshimi well it looks like your not stubbing it out but passing a mock ecs in? [23:27] hatch: https://github.com/juju/juju-gui/blob/develop/test/test_machine_view_panel.js#L223 [23:28] huwshimi ok yeah you're passing a mock in, you'll need to set the ecs to a real ecs object if you want to use the real placeUnit [23:28] hatch: Ah ok, so any ideas on how to do that? [23:28] Do we do this anywhere else? [23:28] you can't really 'just' use placeUnit because it relies on the ecs instance in a lot of places [23:28] well what are you testing? [23:29] hatch: OK, so I'm trying to test that a container token is created when placeUnit occurs [23:30] I'll push up my code [23:31] well you don't really need to do that [23:31] you just need to test that placeUnit is called with the proper data [23:31] then there should be a test which takes said data and makes sure placeUnit does the proper stuff with it [23:31] ^ huwshimi