| hatch | kadams54 hey u around? | 04:16 |
|---|---|---|
| kadams54 | hatch: yup | 04:16 |
| kadams54 | What's up? | 04:16 |
| hatch | I found a bug in the gui but I remmebr you doing some work on this area so wanted to check b4 I filed it | 04:16 |
| hatch | so if I D&D a charm, switch to the mv and then click 'auto place' then deploy/confirm | 04:17 |
| hatch | the machine doesn't get the service icon in it | 04:17 |
| hatch | I have to switch away from mv then back again | 04:17 |
| kadams54 | *sigh* | 04:23 |
| kadams54 | You've reproduced this in something other than Chrome? | 04:24 |
| kadams54 | It seems like we're constantly squashing "missing icon" bugs | 04:24 |
| kadams54 | Huw did some work today that may fix that | 04:25 |
| kadams54 | https://github.com/juju/juju-gui/pull/476 | 04:25 |
| kadams54 | Or rather, that PR landed today | 04:26 |
| hatch | kadams54 this was in chrome | 04:27 |
| hatch | it was this afternoon so running pretty new stuff | 04:27 |
| kadams54 | I remember noting when I QA'd it that the icon was added to the machine | 04:27 |
| kadams54 | Looks like he landed it at 23 hours ago | 04:28 |
| kadams54 | So I suspect we still have bugs to squash | 04:28 |
| kadams54 | Though I'd verify it in Safari first | 04:28 |
| kadams54 | Since I've seen missing icons only in Chrome | 04:28 |
| hatch | hmm ok, what's the new comingsoon url? | 04:28 |
| kadams54 | Damn you Chrome and your SVG bugginess | 04:28 |
| kadams54 | I have no clue | 04:28 |
| kadams54 | I didn't know there was a new URL until that discussion this afternoon | 04:29 |
| kadams54 | :-) | 04:29 |
| hatch | haha neither did i | 04:29 |
| hatch | ok I'll have to remember to test in the am | 04:30 |
| hatch | I have too many vm's spun up I don't want to risk hitting a kernel panick | 04:30 |
| hatch | panic even | 04:30 |
| kadams54 | I've had that happen multiple times this week. I kinda suspect that's due to water damage, though it seems to happen when I have multiple VMs going. | 04:34 |
| kadams54 | lxc within a full trusty virtualbox image + vagrant | 04:35 |
| hatch | I seem to have added an ubuntu juju vagrant image somehow and it's not shown in the vagrant box list | 04:50 |
| hatch | and now it's borking new vm's | 04:50 |
| hatch | argggg hah | 04:50 |
| hatch | yeah I think our default vagrant image installs and boots juju with the gui by default... | 04:54 |
| hatch | lazyPower you happen to be kicking around still? | 04:55 |
| hatch | ahah found it | 05:04 |
| urulama | rogpeppe1: morning | 07:08 |
| rogpeppe1 | urulama: hiya | 07:27 |
| frankban | hi rogpeppe1 | 08:20 |
| rogpeppe1 | frankban: hiya | 08:20 |
| rogpeppe1 | frankban: shall we continue? | 08:24 |
| frankban | rogpeppe1: sure, gogogo | 08:24 |
| rogpeppe1 | frankban: i'm there | 08:24 |
| rogpeppe1 | jrwren, bac, urulama, Makyo: https://github.com/juju/charmstore/pull/56 | 09:14 |
| urulama | rogpeppe1: LGTM, but go through comments, please | 09:59 |
| rogpeppe1 | urulama: "What do we do with it in the API?" - i don't understand the question | 10:02 |
| rogpeppe1 | urulama: thanks a lot for the review, BTW | 10:02 |
| urulama | so, what do we do with the errgo.Any? | 10:03 |
| urulama | rogpeppe1: it was fun to see the code and not just images and docs :) | 10:03 |
| rogpeppe1 | urulama: we allow resolveURL to return errors with a cause that's passed back to the caller. | 10:04 |
| rogpeppe1 | urulama: for example, resolveURL can return a not-found error | 10:04 |
| rogpeppe1 | urulama: which will end up as a 404 | 10:04 |
| urulama | rogpeppe1: oh, now i remember ... all clear ... sorry :) | 10:05 |
| rogpeppe1 | urulama: np | 10:05 |
| urulama | but it could end up as 404, just not in an as elegant way | 10:06 |
| rogpeppe1 | urulama: really? | 10:18 |
| rogpeppe1 | frankban: https://github.com/juju/charmstore/pull/57 | 10:20 |
| rogpeppe1 | urulama, jrwren, Makyo, bac: ^ | 10:21 |
| rogpeppe1 | frankban, bac, jrwren: https://github.com/juju/charm/pull/36/files | 10:43 |
| rogpeppe1 | frankban, jrwren: https://github.com/juju/charmstore/pull/58 | 10:58 |
| frankban | jrwren: thanks for your reviews! | 11:00 |
| * rogpeppe1 lunches | 11:44 | |
| * frankban lunches | 11:46 | |
| * jrwren breakfasts | 11:55 | |
| * bac has another tea | 12:00 | |
| frankban | rogpeppe1: ready when you are | 13:12 |
| urulama | hi frankban | 13:13 |
| urulama | how's it going? | 13:13 |
| frankban | urulama: very well, we are working on the pub api and we ended up working on some pre-req branches. | 13:14 |
| frankban | urulama: how is it foing in germany? | 13:14 |
| frankban | urulama: if you have time, https://github.com/juju/charm/pull/36 | 13:15 |
| urulama | frankban: lot of talking here :) | 13:16 |
| frankban | heh | 13:16 |
| urulama | frankban: good to hear publish api | 13:16 |
| urulama | frankban: add about in that sentence :) | 13:17 |
| urulama | frankban: i'll take a look | 13:17 |
| frankban | urulama: thanks | 13:17 |
| urulama | frankban: ah, yes, the question about that check was more about the consequences about somehow adding an unverified bundle to the store ... | 13:18 |
| urulama | and if we didn't use validation before, and there is a good reason that we didn't, it's fine. | 13:19 |
| frankban | urulama: we didn't use that before. the publish API will take care of validating the bundle with respect to charms also | 13:20 |
| urulama | frankban: all good then | 13:20 |
| frankban | urulama: cool | 13:20 |
| urulama | frankban, rogpeppe1: i'm just thinking ... as there is no client of v3, maybe we don't need v4 ... with this tempo, we'll end up with v192 before end of year :) | 13:22 |
| rogpeppe1 | urulama: that was frankban's inclination too | 13:22 |
| rogpeppe1 | urulama: perhaps you're right. we haven't published v3 yet. | 13:23 |
| urulama | i would say, until there is a usage of someone, do not increase version number | 13:23 |
| rogpeppe1 | urulama: but in general, i am wary of that approach | 13:23 |
| frankban | urulama: but we agreed is good to not cheat also to exercise this kind of procedure/api management | 13:23 |
| rogpeppe1 | urulama: we actually do not know that noone is using v3 | 13:23 |
| rogpeppe1 | urulama: and what frankban says. | 13:23 |
| rogpeppe1 | urulama: we need to get in the habit of doing this right. | 13:24 |
| rogpeppe1 | urulama: and if there's too much overhead from our procedures when doing this, then perhaps we need to think about how to improve that. | 13:24 |
| urulama | rogpeppe1, frankban: i agree that from the purity point of view, this is ok, just thinking about the clients ... they use v2, then v12, and then v24 (the only published versions). it looks confusing. | 13:25 |
| rogpeppe1 | urulama: all the versions are available and published, really | 13:25 |
| rogpeppe1 | urulama: we just haven't announced them. | 13:26 |
| rogpeppe1 | urulama: from the p.o.v. of the rest of the world, only the latest version matters, whether it's v1 or v4 | 13:26 |
| frankban | urulama, rogpeppe1: it seems to me that, given the current "go get" limitations, and given the decision of using gopkg.in as a workaround for API stability and ability to build a project, what we are doing is fine: a new version branch if the public API changes. we kind of agreed on those premises, and if not, we need to find another way IMHO. | 13:33 |
| rogpeppe1 | frankban, urulama: i agree with that. we should mostly be able to avoid breaking API changes, I hope. | 13:34 |
| urulama | rogpeppe1, frankban: sure. i'm just thinking if there's a better practice. for example. As we develop staff the charm API will change, and there is no guarantee that v5 will not hit in next hour. So. What if during "coding sprints" at which we know that they have high probability to change api, we work on a branch | 13:35 |
| urulama | accumulate all the changes and then push version upgrade | 13:35 |
| urulama | (unles gopkg.in cant do that) | 13:35 |
| jrwren | urulama: I like that. | 13:35 |
| rogpeppe1 | urulama: i have actually come to like the explicit import-path-version-implies-compatible API approach | 13:37 |
| rogpeppe1 | urulama: it means that tip is always go-gettable | 13:37 |
| rogpeppe1 | urulama: (although it's true that v4 charmstore cannot currently be "go getted" | 13:38 |
| rogpeppe1 | ) | 13:38 |
| urulama | rogpeppe1: sure, i said i like the purity. just not the implications of changing multiple versions in short periods during developments of same end features (it's a different story when new features are rewuired) ... need to think about it | 13:40 |
| * urulama needs to go to room for the power plug ... | 13:40 | |
| rogpeppe1 | urulama: yeah, i'm not entirely sure either. | 13:43 |
| rogpeppe1 | urulama: i thought we could try applying the rigorous rule to start with and see how it turned out | 13:44 |
| rogpeppe1 | jrwren: for the record, I don't dislike $@ - it's the only way to properly pass through a script or function's arguments to another command. i don't like it when it's not quoted though. | 13:47 |
| jrwren | :) | 13:48 |
| jrwren | I'm lucky package names can't have spaces in them. | 13:49 |
| urulama | rogpeppe1: so i've talked about this with Gustavo, and he agrees about branches. we all agree with you that having branches in some way breaks the sole purpose of versions, and there you're right | 13:49 |
| urulama | rogpeppe1: so my suggestion is this. let's try with branches and accumulated changes into one version | 13:49 |
| urulama | and if it is too painful to use, let's just inc versions | 13:49 |
| urulama | rogpeppe1: he uses branches as well | 13:50 |
| urulama | or we can say v3-dev version and mark that it's in changing? | 13:50 |
| rogpeppe1 | urulama: that's a good idea | 13:50 |
| urulama | which one :) | 13:50 |
| urulama | dev? | 13:50 |
| rogpeppe1 | urulama: yeah | 13:51 |
| urulama | rogpeppe1, frankban, jrwren: ok, let's agree on the -dev one and this is a message to user that it is not stable. You all ok with this? | 13:51 |
| rogpeppe1 | urulama: we can just mark on the branch somewhere (perhaps in the package doc at the top level) that the API at that version is currently unstable | 13:51 |
| rogpeppe1 | urulama: we can't have -dev as part of the import path | 13:51 |
| urulama | rogpeppe1: sorry ... v3/dev? | 13:52 |
| === alexpilotti_ is now known as alexpilotti | ||
| rogpeppe1 | urulama: my suggestion is just to write in the package documentation that the API is unstable. When we decide to publish it, we remove that remark from the doc. | 13:53 |
| rogpeppe1 | urulama: but that would not require any clients to change | 13:54 |
| urulama | rogpeppe1: +! | 13:54 |
| urulama | ah | 13:54 |
| urulama | rogpeppe1: +1 | 13:54 |
| frankban | urulama, rogpeppe1: what about using a "develop" branch for development. when required, we merge develop into the latest "v*" branch. if develop breaks the API, then we create the next version branch | 13:54 |
| rogpeppe1 | frankban: i'd prefer to use the actual versioned import paths | 13:55 |
| rogpeppe1 | frankban: for one thing, it makes it trivial to update with govers | 13:55 |
| frankban | rogpeppe1: you still use the import path | 13:55 |
| rogpeppe1 | frankban: if you use a different branch, then go get can't work | 13:56 |
| rogpeppe1 | jrwren: are you still making changes to the charmstore charm? | 13:58 |
| frankban | rogpeppe1: I know that. I was just suggesting that, rather than working directly on the latest "v*" branch, we could decide to treat those branches as published versions, and work on develop. when develop is ready to be published, we create or update a "v*" branch. clients always use versioned imports | 13:58 |
| jrwren | rogpeppe1: not beyond what is already there. I want to move on. | 13:59 |
| hatch | morning all | 14:01 |
| frankban | hi hatch | 14:02 |
| hatch | frankban have you seen that email from Makyo about the release? Any idea on the error? I'm just about to start on it | 14:02 |
| frankban | hatch: I didn't | 14:03 |
| frankban | hatch: to gui peeps? | 14:03 |
| hatch | oh hah he only sent it to me :D | 14:03 |
| hatch | sec I'll forward to u | 14:03 |
| frankban | ok | 14:04 |
| hatch | ok sent | 14:04 |
| frankban | hatch: so, did he release the trusty one? | 14:07 |
| hatch | apparently so | 14:07 |
| urulama | rogpeppe1, frankban, jrwren: the best practice of using gopkg.in is not here ... we should find one. let's experiment | 14:08 |
| frankban | hatch: yes he did | 14:08 |
| rogpeppe1 | frankban: charmstore is a client | 14:08 |
| frankban | hatch: I'd suggest to retry running the precise tests, that error can be spurious | 14:09 |
| rogpeppe1 | frankban: in our recent situation, what would we have done? | 14:09 |
| hatch | frankban ok thanks I'll start there | 14:09 |
| frankban | rogpeppe1: 1) update charm develop. 2) realize there is client code needing the last changes we made 3) start a charm release process 4) check what needs to be released, does it break the API? 5) if so, release a new version branch, if not update the latest version branch 6) update the client | 14:11 |
| rogpeppe1 | frankban: how would that change the workflow we just did? | 14:13 |
| rogpeppe1 | frankban: after all, charmstore is a client, and needed the changes we made in v3 | 14:13 |
| rogpeppe1 | frankban: so in the workflow above, we'd have released a new v3 version. and then the same would have applied to v4. | 14:14 |
| frankban | rogpeppe1: it does not change the "v*" workflow, it changes how the process is managed. developers know where trunk lives (develop) so they can create their branches form there. creating/updating version branches is now a process per-se, not part of a feature branch. so you have a card for releasing a new version, and everyone knows you are doing that. crazy clients that want to live on the edge can also import th | 14:17 |
| frankban | e develop branch directly | 14:17 |
| urulama | frankban, rogpeppe1: ok, let's step back and look at the http://labix.org/gopkg.in | 14:18 |
| frankban | rogpeppe1: right now it is like 1) let's add this feature, 2) oh man, I need to change the public API 3) I'll just push "vX" to "vX+1", then propose gainst it. at the same time, another developer could do the same. | 14:19 |
| rogpeppe1 | frankban: they could, but they would immediately be aware of a problem, because their push would fail | 14:20 |
| rogpeppe1 | frankban: i'm just concerned that your proposed workflow makes things more complex (i'm still don't understand how go get would work) and doesn't seem to address urulama's concern about version numbers that increase more frequently than necessary | 14:22 |
| urulama | rogpeppe1, frankban: ok, what about having v2. adding changes in the development like v2.0.x, v2.0.x+1 ... for small features | 14:22 |
| rogpeppe1 | frankban: i'm suggesting that every new API version branch is created as a "development" version. | 14:23 |
| urulama | and when we finish we either bump that to v2.1 or if change is huge, push it to v3 | 14:23 |
| rogpeppe1 | urulama: i don't think that helps | 14:23 |
| rogpeppe1 | urulama: we're specifically talking about changes that break the API here | 14:23 |
| rogpeppe1 | urulama: for changes that don't break the API, we can just push to the latest version anyway | 14:23 |
| rogpeppe1 | urulama: with no need for point versions | 14:24 |
| frankban | rogpeppe1: I share your concern about complexity of that approach, I'd just like to make the process more clear, by separating the feature branch work from the "new version release" one. | 14:24 |
| urulama | rogpeppe1: for me v2 to v3 is a huge api change, with old api-s being depricated, not just one ... | 14:24 |
| urulama | esp. due to the fact that they happened in bulk | 14:25 |
| rogpeppe1 | frankban: my proposal is just to have a "// DEVELOPMENT VERSION." comment in the README | 14:25 |
| rogpeppe1 | urulama: i don't quite understand. v2 to v3 was just the Reference change, right? | 14:26 |
| frankban | rogpeppe1: yeah, what I am saying is that usually people knows that a "develop" branch in github is the development version of that project | 14:26 |
| rogpeppe1 | frankban: but if we use a "develop" branch, then we can't make it go-gettable AFAICS. | 14:27 |
| frankban | urulama: any public API change should increase the major version number (at least if we believe in semantic versioning) | 14:27 |
| rogpeppe1 | frankban: not quite | 14:28 |
| rogpeppe1 | frankban: any *backwardly-incompatible* API changes should increase the major version number | 14:28 |
| frankban | rogpeppe1: yeah, and that's the rule we are following now | 14:29 |
| rogpeppe1 | frankban: agreed. but i'm trying to go along with urulama's suggestion that when there's a new version and we're developing the package in response to feature development in another repository, we might not need to increase the version every time we break the API | 14:30 |
| urulama | ^^^ | 14:30 |
| urulama | rogpeppe1: ok, is version v3d allowed? | 14:31 |
| rogpeppe1 | urulama: i don't think so | 14:31 |
| urulama | rogpeppe1: from the short specs i thought so, needed to ask | 14:31 |
| rogpeppe1 | urulama: and anyway, i don't think we necessarily want to change the import paths when an API is published | 14:31 |
| rogpeppe1 | urulama: the way i think about that is that we "bless" a branch, and from then on we can't change it in a backwardly incompatible way. | 14:32 |
| urulama | rogpeppe1: ok ... let's end this ... too much time :) let's mark the version as development in the docs as suggested for now | 14:32 |
| rogpeppe1 | urulama: ok, so we'll stick with v3 for the time being, and mark the v3 branch as in development | 14:33 |
| rogpeppe1 | urulama, frankban: sgty? | 14:33 |
| urulama | rogpeppe1: at least for now ... i'll try to catch Gustavo and talk about it a bit more | 14:33 |
| rogpeppe1 | urulama: good plan | 14:33 |
| frankban | rogpeppe1: not really, we should make v4 the first development version IMHO | 14:33 |
| rogpeppe1 | urulama: i believe we can retrospectively apply the rule here :-) | 14:34 |
| rogpeppe1 | oops | 14:34 |
| rogpeppe1 | frankban: ^ | 14:34 |
| rogpeppe1 | frankban: after all, we are 99.9999% certain no-one else is using v3 | 14:34 |
| rogpeppe1 | frankban: i'm in gogogo | 14:35 |
| * urulama deletes v3 from disk ... | 14:35 | |
| urulama | :D | 14:35 |
| rogpeppe1 | urulama: you don't count :-) | 14:35 |
| frankban | rogpeppe1: ok, I don't have a real preference, I am just worried about clients starting to use the dev version (like charmstore) and developers keeping changing the API without releasing a new version because, you know, this is a dev version... | 14:35 |
| rogpeppe1 | i should probably have said "no other packages are using v3" | 14:35 |
| jrwren | isn't there an open PR for juju to use v3? | 14:35 |
| urulama | rogpeppe1: i was going for another 9! | 14:35 |
| rogpeppe1 | jrwren: actually v2, but yes | 14:35 |
| rogpeppe1 | frankban: i agree, that's definitely a potential issue. | 14:36 |
| jrwren | Ah, v2. ok. | 14:36 |
| rogpeppe1 | frankban: let's keep an eye on that | 14:37 |
| urulama | frankban: yes, but the only client could be core ... and we'll talk about this later today ... so. if we don't "bless" new version, it is not stable | 14:37 |
| rogpeppe1 | frankban: luckily the charm store isn't usable yet :-) | 14:37 |
| urulama | frankban: and if it turns out to be PITA, then inc(vers) on every api break will come into practice if no better alternative exists | 14:37 |
| rogpeppe1 | urulama: when creating a new version, we'll always add a "WARNING: UNSTABLE DEVELOPMENT VERSION" to the README. | 14:38 |
| urulama | ^^^ | 14:38 |
| rogpeppe1 | urulama: so, when retargeted to v3 and with that warning added, does the charm branch LGTY? | 14:39 |
| urulama | and if it's README.md with # prefix even | 14:39 |
| rogpeppe1 | urulama: SGTM, i think (what does the # prefix mean in markdown?) | 14:39 |
| urulama | rogpeppe1: title | 14:39 |
| urulama | large bold letters | 14:39 |
| frankban | scary bloody letters | 14:40 |
| frankban | time for a coffee... then gogogo | 14:40 |
| rogpeppe1 | frankban: ok | 14:41 |
| rogpeppe1 | urulama: i've re-pushed the branch. https://github.com/juju/charm/pull/36 | 14:44 |
| urulama | rogpeppe1: so the branch will stay at v4? | 14:47 |
| rogpeppe1 | urulama: v3 | 14:47 |
| urulama | rogpeppe wants to merge 2 commits into juju:v4 from rogpeppe:012-no-verify-on-bundle-read | 14:48 |
| rogpeppe1 | urulama: ah, i guess the PR needs to be retargetted at v3 | 14:48 |
| rogpeppe1 | urulama: will retarget | 14:48 |
| rogpeppe1 | urulama: i'll make a new PR | 14:49 |
| rogpeppe1 | urulama: if you post a LGTM on the original, i think that should be good enough | 14:49 |
| jrwren | frankban: on https://github.com/CanonicalLtd/charmstore-charm/pull/1 do you feel strongly about the file write v. writelines or can I get a LGTY? | 14:51 |
| rogpeppe1 | urulama, frankban: https://github.com/juju/charm/pull/37 | 14:52 |
| urulama | rogpeppe1: i commented on the #36 ... | 14:53 |
| rogpeppe1 | urulama: thanks | 14:53 |
| frankban | jrwren: just merge it, I was more interested in having unit tests, but as I mentioned, this can be done in another branch | 14:54 |
| hatch | jujugui call in 6 | 14:54 |
| rogpeppe1 | "What if we also add this in a new line? The latest stable version is v2." | 14:54 |
| rogpeppe1 | urulama: i don't understand that | 14:54 |
| urulama | rogpeppe1: i would add "The latest stable version is v2." sentence in a new line after the warning | 14:55 |
| rogpeppe1 | urulama: FWIW, i still think the distinction between v2 and v3 is worth it, because they are quite distinct API changes and I don't want to lump the changes for both together when changing juju-core | 14:55 |
| rogpeppe1 | urulama: ah! | 14:55 |
| urulama | v2 vs v3 is ok | 14:55 |
| rogpeppe1 | urulama: will do. | 14:55 |
| urulama | tnx | 14:55 |
| rogpeppe1 | urulama: LGTY otherwise? | 14:55 |
| urulama | rogpeppe1: sure ... it's in #37 | 14:56 |
| urulama | jrwren, frankban: the details are important, I agree, but could we focus on pushing functionally working charm out, so that we can do proper testing? | 14:58 |
| jrwren | urulama: i just pushed it and moved card. | 14:59 |
| hatch | jujugui call in 1 | 14:59 |
| urulama | jrwren: \o/ | 15:01 |
| lazyPower | hatch: o/ | 15:08 |
| hatch | ahoy | 15:08 |
| lazyPower | something i can help with still, or did you resolve it? | 15:08 |
| jcsackett | jujugui: wifi died; i was on my phone, outside where i get slightly better signal. my connectivity today may be spotty. | 15:09 |
| hatch | oh I resolved it - for some reason my trusty vagrant images were pulling down the juju image | 15:09 |
| hatch | jcsackett ohh, party at your place? | 15:09 |
| jcsackett | hatch: neighbors place. students are starting to move back into the neighborhood, but classes haven't started yet. | 15:10 |
| hatch | ohh - are you like that guy in that movie with the frat house next door? :) | 15:10 |
| hatch | crap now I cn't remmeber what it is called | 15:10 |
| jcsackett | not really; they tend to be reasonable about not partying a lot late at night, we try to be reasonable about not getting grumpy other times. | 15:11 |
| lazyPower | hatch: ah, ok :) | 15:12 |
| hatch | lazyPower I did have a question about a charm which always pulls from HEAD being a promoted charm | 15:13 |
| hatch | there is a thing called Stellar (you may have heard about it, a new currency) | 15:13 |
| hatch | so I was looking at charming up stellard | 15:13 |
| hatch | but their iterating so fast that one has to pull from HEAD | 15:14 |
| hatch | but that unfortunately means that it's likely not stable... | 15:14 |
| jrwren | jcsackett: do you live in East Lansing? | 15:14 |
| lazyPower | I dont think there's a problem with the charm being configured to deploy HEAD - ideally we'd rather it be configurable so you can deploy HEAD or a revisionno. | 15:14 |
| lazyPower | as thats pretty simple to implement. but HEAD as a default is perfectly acceptable. | 15:14 |
| jcsackett | jrwren: i must admit i do not get your reference. | 15:15 |
| hatch | lazyPower even as a 'promoted' charm? Because currently their get up and running guide is 'git clone, vagrant up' so it would definitely need to be promoted so it could just be `juju deploy stellard` | 15:16 |
| rogpeppe1 | urulama, jrwren, bac, Makyo: simple PR: https://github.com/juju/charmstore/pull/59 | 15:16 |
| hatch | rogpeppe1 Makyo isn't in for the rest of the week fyi | 15:16 |
| rogpeppe1 | hatch: ah, ok | 15:16 |
| jrwren | jcsackett: Ooops, I'm getting your geoloc confused with someone else. | 15:16 |
| jcsackett | jrwren: dig. :) | 15:17 |
| lazyPower | hatch: i'd have to see the charm code before i can commit to anything | 15:17 |
| lazyPower | but wrt just deploying head - thats not a blocker. give me config options so i can configure which rev its deploying and you're g2g on that front. | 15:18 |
| hatch | lazyPower ok cool thanks | 15:19 |
| jrwren | pretty simple copy from old w/ tiny change to make work with new: https://github.com/juju/charmstore/pull/60 | 15:22 |
| hatch | jcsackett can you take a look at the gui CI...it looks like it's failing on every branch with a isBrowserSupported error - which is usually just a spurious one | 15:24 |
| jcsackett | hatch: sure. | 15:39 |
| hatch | jcsackett thanks - it's failing all over the darn place :/ | 15:40 |
| urulama_ | jrwren: mayber PR #60 should be v4 API adapted first before being pushed from _old? | 15:48 |
| urulama_ | s/mayber/maybe | 15:48 |
| jrwren | urulama_: it is. I mean, all it does is call NewServer with V4 as a parameter. | 15:49 |
| urulama_ | jrwren: sorry, missed it | 15:51 |
| urulama_ | frankban, rogpeppe1: could you please take a look at https://github.com/juju/charmstore/pull/60 so that jrwren continues? | 15:55 |
| urulama_ | frankban, rogpeppe1: sorry, I know that you are in "go go go" mode :) | 15:56 |
| rogpeppe1 | urulama_: :-) | 15:56 |
| rogpeppe1 | urulama_: yeah, we are finally free to move forward... | 15:56 |
| bac | hi jcsackett | 15:58 |
| jcsackett | hi bac. | 15:59 |
| hatch | bac welcome! | 15:59 |
| bac | jcsackett: i see ci is a mess. are you working on it? did you upgrade jenkins? | 15:59 |
| jcsackett | bac: i just started looking at it, and i don't have the juju bits for it so about all i can do is check the machine itself. | 16:00 |
| bac | it's all pertier now | 16:00 |
| hatch | bac oh I thought that's what you did | 16:00 |
| hatch | lol | 16:00 |
| hatch | since the pretty update I don't think anything has landed | 16:00 |
| hatch | well who the heck updated it haha | 16:00 |
| bac | hatch: i *may* have. rick and i talked about it but i can't recall exactly | 16:01 |
| jcsackett | ah, it is indeed updated; perhaps rick did it? | 16:01 |
| bac | jcsackett: so you can ssh. | 16:01 |
| hatch | yeah it's been broken since the update I think | 16:01 |
| jcsackett | yeah, i'm on the machine now. | 16:01 |
| bac | jcsackett: ok. | 16:02 |
| bac | jcsackett: i'm surprised the 'post build step' is not marked 'Run script only if all previous steps were successful' | 16:02 |
| bac | jcsackett: but that's not why it is failing | 16:03 |
| hatch | urulama so I bought parallels | 16:04 |
| hatch | it has some cool features over fusion, but it has the same delay so it must be an ubuntu thing... | 16:04 |
| jcsackett | hatch: so it looks like it's just failed on two branches? that may just be the spurious biting you more often than you would like. | 16:05 |
| hatch | I can trigger them again I guess | 16:05 |
| jcsackett | hatch: i'm running the build again. | 16:06 |
| jcsackett | (not the merge job, just the regular test run) | 16:06 |
| hatch | ohh ok, well I'll try and land one again, see if it's still spurious | 16:06 |
| jcsackett | ok | 16:06 |
| hatch | it's just odd that there were so many failures in a row | 16:06 |
| bac | hatch: in both jobs | 16:07 |
| hatch | right | 16:07 |
| bac | hatch, jcsackett: what does 'git branch' -> *(no branch) mean | 16:08 |
| jcsackett | i hadn't seen all the failures in merge; this does seem a bit odder. | 16:08 |
| jcsackett | bac: wehre do you see that? | 16:08 |
| bac | from ~jenkins/workspace/juju-gui-merge | 16:08 |
| jcsackett | huh. i have no idea. | 16:11 |
| jcsackett | presumably it's checking something out in headless, i think? | 16:11 |
| BradCrittenden | jcsackett: so my assumption is a) the tests pass locally b) they don't pass on jenkins because the workspace is screwed up | 16:12 |
| hatch | *sigh* | 16:13 |
| BradCrittenden | jcsackett: there are also a ton of branches there. looks like we're never cleaning up. certainly not the problem. | 16:13 |
| === BradCrittenden is now known as bac | ||
| jcsackett | bac: possibly | 16:16 |
| jcsackett | ...can we just blow away the dir's contents? | 16:17 |
| jcsackett | bac: ^ will jenkins rebuild it, since it checks stuff out? | 16:17 |
| bac | jcsackett: probably. there is a button to destroy the workspace on the gui | 16:17 |
| jcsackett | votes on whether or not to give it a try? | 16:17 |
| bac | but it would be nice to possibly figureout what is actually wrong. | 16:18 |
| jcsackett | bac: i don't how to investigate a busted git situation properly. we could give hatch ssh access, as he's our git-ish person, i guess. :p | 16:18 |
| bac | jcsackett: why don't you do it on the juju-gui job and not the -merge job | 16:18 |
| jcsackett | bac: that was my plan. | 16:18 |
| hatch | I am thinking it might be a sauce labs issue | 16:19 |
| hatch | did they update their stuff recently? | 16:19 |
| hatch | it always fails in chrome with the isBrowserSupported error | 16:19 |
| hatch | http://ci.jujugui.org:8080/job/juju-gui-merge/545/console | 16:19 |
| bac | hatch: can you run them locally? | 16:19 |
| hatch | bac I'm not set up to run them locally - working on it but new vm and all that | 16:20 |
| hatch | it'l take me a while | 16:20 |
| bac | well, if anyone can try 'make ci-check' to see | 16:20 |
| jcsackett | what entails being setup? | 16:21 |
| jcsackett | i have an lxc for gui, so i can thrash that, but i don't know what else needs setting up. | 16:21 |
| hatch | http://sauceio.com/index.php/2014/07/sauce-labs-selenium-chrome-updates-august-2/ | 16:21 |
| hatch | ^ there is our issue jcsackett bac | 16:21 |
| jcsackett | new version of selenium? | 16:22 |
| hatch | it seems that way | 16:22 |
| hatch | and new chrome and chrome driver | 16:23 |
| hatch | which might not have the isBrowserSupported option | 16:23 |
| bac | jcsackett, hatch: my battery is about to die and i don't have an outlet available. | 16:23 |
| jcsackett | so, it looks like we can a) update our test suite or b) try forcing selenium version. | 16:23 |
| bac | good night and good luck. | 16:23 |
| hatch | bac ok we can take over, have a good night | 16:23 |
| jcsackett | bac: night dude. | 16:23 |
| hatch | yeh lets force it to use the old version | 16:24 |
| hatch | we are low on man power this week so lets just get it up and running and we can investigate the fix next week or so | 16:24 |
| jcsackett | ok, where's our selenium config in the tree? | 16:24 |
| hatch | I thought you knew? :P | 16:24 |
| hatch | browser.py maybe... | 16:26 |
| jcsackett | hatch: ok, i'll dig into this. | 16:27 |
| hatch | thanks | 16:27 |
| hatch | chrome keeps blacking out when I drag the window in Ubuntu, looks like I'm switching to Firefox | 16:31 |
| rogpeppe1 | jrwren: for future reference, we don't push the big green button to merge branches into the charm store | 16:39 |
| rogpeppe1 | jrwren: instead, add a comment with the sacred rune :shipit: | 16:39 |
| rogpeppe1 | jrwren: (we missed a few issues from your PR, which doesn't actually build correctly, unfortunately) | 16:41 |
| hatch | its the shibolith | 16:43 |
| jrwren | rogpeppe1: yeah, i realized ci system does it AFTER I pushed that tempting shiny green button. | 16:47 |
| rogpeppe1 | jrwren: https://github.com/juju/charmstore/pull/61 | 17:03 |
| jrwren | rogpeppe1: ah, i missed adding the old config.go, which is what I was going to do. #fail. | 17:04 |
| kadams54 | Anyone know if the pending attribute on a Service is a reliable indicator of uncommitted/ghosted state? | 17:50 |
| kadams54 | guihelp: ^ | 17:50 |
| hatch | kadams54 it will be being changed to be isUncommitted or something | 17:52 |
| hatch | so that everything can use the same key | 17:52 |
| kadams54 | Can I use it as is? | 17:52 |
| kadams54 | Or rather, what's the best way currently to know, within a Service instance, if it's in an uncommitted state? | 17:53 |
| hatch | yeah I believe so | 17:54 |
| hatch | best is to test it though | 17:54 |
| kadams54 | yup | 17:55 |
| hatch | jcsackett hey any luck with the CI? | 18:38 |
| jcsackett | hatch: i think so--browser.py was indeed the place to set things, and i've gotten to a state where i can replicate the error locally. i'm locally testing the fix. | 18:59 |
| jcsackett | or i guess "a fix" since i don't know if it works yet. | 19:00 |
| hatch | excellent | 19:00 |
| hatch | thanks for doing this! | 19:00 |
| hatch | ugh still downloading the precise charm repo | 19:09 |
| hatch | this thing is massssssive | 19:09 |
| hatch | make that the trusty charm | 19:09 |
| jrwren | you did a getall? | 19:12 |
| hatch | I followed the instructions | 19:23 |
| hatch | bzr branch lp: .... | 19:23 |
| hatch | :) | 19:23 |
| jrwren | i wonder if that is why the juju charm tools has getall. | 19:32 |
| hatch | jcsackett so.....diditwork?huhhuhdidit?didithuh? | 20:10 |
| jcsackett | hatch: no. | 20:11 |
| jcsackett | hatch: it creates a new error. | 20:11 |
| hatch | *sadface* | 20:11 |
| jcsackett | it just flat out aborts, claiming the settings conflict with firefox. since the update post only references chrome, i'm trying it only setting the selenium version for chrome, and leaving firefox alone. | 20:12 |
| jcsackett | given they test such an old v of firefox by default, perhaps they're pinning an older version of selenium for it. | 20:13 |
| jcsackett | ...and i just got the results back, and it fails that way. | 20:13 |
| jcsackett | ok, i need to read more docs to figure out why setting selenium breaks firefox; b/c clearly the old version *was* working for it once upon a time. | 20:15 |
| hatch | jcsackett ok darn, anything I can do to help | 20:27 |
| hatch | ? | 20:28 |
| jcsackett | hatch: i'm beginning to think this isn't about selenium. | 20:28 |
| hatch | no? because it seems to happen in the exact same space with the same error | 20:29 |
| jcsackett | well, it's an error on selenium tests, sure. | 20:29 |
| hatch | and the only changes I can see are the ones from sauce | 20:29 |
| kadams54 | jujugui: looking for reviews and QA on: https://github.com/juju/juju-gui/pull/480 | 20:31 |
| jcsackett | hatch: right, but the chrome change isn't the issue (b/c the error occurs on firefox) and it's starting to look like firefox was already using a diff selenium version. | 20:31 |
| jcsackett | hatch: i haven't got concrete proof yet. just sharing my suspicions. | 20:32 |
| hatch | hmm right I suppose - but didn't they also change the selenium version across the map? | 20:32 |
| hatch | are we using a version of FF that's too old? Maybe we should update it | 20:32 |
| hatch | kadams54 review done | 20:35 |
| hatch | I'll hold off on QA until you respond to the comments | 20:36 |
| jcsackett | hatch: we're using version 25; not too old, but as long as i'm in here i can bump it to 30 (the current stable) | 20:37 |
| jcsackett | er, 32 | 20:37 |
| jcsackett | dammit, i can't type. | 20:37 |
| jcsackett | 31. | 20:37 |
| jcsackett | there. | 20:37 |
| hatch | haha | 20:37 |
| hatch | jcsackett so the method isBrowserSupported is defined in the index.html file - as you can see in the saucelabs vid https://saucelabs.com/jobs/9b4a430af5744fd68fbbbea228b5838c the GUI is loaded so there should be no reason why that method is not defined | 20:41 |
| jcsackett | hatch: yeah. | 20:41 |
| hatch | unless of course there is a syntax error | 20:41 |
| hatch | you were able to run it locally? Was there such error? | 20:41 |
| kadams54 | hatch: thanks. Replies posted. | 20:41 |
| jcsackett | i think firefox 25 may just load a selenium version that is > 2.30.0 and < the new default. | 20:42 |
| hatch | jcsackett I wonder if there was a change in chrome where it doesn't auto assign the isBrowserSupported to window if it's a global | 20:42 |
| hatch | maybe try changing it to window.isBrowserSupported = ... | 20:42 |
| jcsackett | hatch: the error is occuring in firefox. | 20:42 |
| jcsackett | so it's not a chrome specific issue. | 20:42 |
| hatch | oh? FF is passing fine in the latest CI run | 20:43 |
| jcsackett | well great, then i'm not able to actually recreate what CI sees. | 20:44 |
| hatch | kadams54 thanks, i'll qa shortly | 20:44 |
| hatch | jcsackett http://ci.jujugui.org:8080/job/juju-gui-merge/545/console FF passes just before it fails in Chrome | 20:44 |
| jcsackett | so, locally ff fails in the same way. | 20:45 |
| jcsackett | well, "locally" | 20:45 |
| hatch | well then... | 20:46 |
| hatch | jcsackett so you set the selenium version back to 2.30.0? (just trying to get up to speed) | 20:48 |
| jcsackett | hatch: i have: | 20:48 |
| jcsackett | 1) set the selenium version to 2.30.0, with the result that firefox tests abort b/c the selenium version is too old for the firefox and os version. | 20:48 |
| jcsackett | 2) set the selenium version for *just* chrome, with the result that firefox fails on the isBrowserSupported thing. | 20:49 |
| jcsackett | i am currently: | 20:49 |
| jcsackett | 1) trying to isolate what version between 2.30.0 and 2.42.0 will actually work. | 20:49 |
| hatch | *sigh* sorry this sucks | 20:49 |
| jcsackett | yeah. | 20:50 |
| hatch | lemme know if I can assist in any way | 20:50 |
| jcsackett | and i'm basically a monkey hitting this with a branch to see what happens. | 20:50 |
| hatch | lol | 20:50 |
| jcsackett | i'm not really sure how i became backup CI guy. :p | 20:50 |
| hatch | you touched it once | 20:51 |
| * kadams54 makes a note to NEVER touch the CI server. | 20:52 | |
| jcsackett | i didn't, actually. :p i touched other CI stuff. | 20:52 |
| hatch | jcsackett maybe it's something dumb as upping the timout from 20-30s on wait_for_script ? | 20:53 |
| jcsackett | maybe, but i don't understand why that would come up now. | 20:53 |
| jcsackett | i'll put it on my list of places to hit CI with a branch, though. | 20:53 |
| hatch | sounds good :) | 20:53 |
| hatch | jcsackett the other thing you could do is put a hook in there so you can pause it and check the window obj yourself | 20:54 |
| kadams54 | Maybe the problem is you're hitting it with a branch when you should be threatening it with an RPG. | 20:54 |
| hatch | to see if all of our defined methods aren't there | 20:54 |
| hatch | haha | 20:54 |
| jcsackett | kadams54: this is not planet of the apes. monkeys don't have RPGs. :p | 20:54 |
| jcsackett | hatch: how do i look at this through a hook, since it's being run by sauce? | 20:55 |
| hatch | jcsackett it'll send u a url | 20:55 |
| hatch | you can visit that url | 20:55 |
| jcsackett | ah, ok. | 20:55 |
| hatch | then click on it to take over | 20:55 |
| hatch | or something along those lines | 20:55 |
| jcsackett | just so i'm not really being stupid, is there any setup required for `make ci-check` to work? | 21:00 |
| jcsackett | i read the docs, and it didn't say anything about preconditions. | 21:00 |
| jcsackett | hatch ^ ? | 21:03 |
| hatch | jcsackett well you need to have the dependencies installed but that's it | 21:03 |
| jcsackett | ok. | 21:03 |
| hatch | running into an issue? | 21:04 |
| hatch | kadams54 some qa notes | 21:05 |
| jcsackett | hatch: are you in a position to run ci-check? | 21:24 |
| jcsackett | i just want to see if you see ff failing for you, outside of CI. | 21:24 |
| hatch | I'm getting close to being | 21:24 |
| hatch | jcsackett probably 15-20mins I can | 21:26 |
| jcsackett | ...ok, nevermind. nothing will ever work on my setup, b/c i don't have sauce connect installed. this is the sort of thing i was looking for insofar as "other prep" | 21:27 |
| jcsackett | :p | 21:27 |
| hatch | I didn't think you needed sauce connect unless you were behind a firewall | 21:27 |
| hatch | if it is indeed required it should be added to the hacking docs | 21:27 |
| jcsackett | i think, by default, lxc's and vms are bridged. | 21:28 |
| jcsackett | which is effectively a proxy. | 21:28 |
| hatch | ok i'm trying to run it | 21:30 |
| hatch | and it failed... | 21:30 |
| hatch | heh | 21:30 |
| hatch | hmm | 21:30 |
| hatch | oh missing pkgs | 21:31 |
| hatch | ok it appears to be runnin gnow.... | 21:32 |
| jcsackett | hatch: if you see only chrome failing, i'll tell you how to set selenium version for just chrome. | 21:33 |
| hatch | ok it got most of the way through then ran into more missing pkgs | 21:33 |
| jcsackett | :p | 21:34 |
| hatch | not sure how long this will take if this keeps happening lol | 21:34 |
| hatch | and agian! | 21:34 |
| jcsackett | ok, i've gotten sc running, so i'm trying again. | 21:37 |
| hatch | excellent I'm still running into dep issues | 21:39 |
| hatch | i'll let you know when I get somewhere on it | 21:39 |
| jcsackett | ok, *with* sc running, still FF failure. | 21:39 |
| jcsackett | i have no idea now. | 21:40 |
| jcsackett | i can't actually make saucelabs work from my lxc. | 21:40 |
| jcsackett | this would have been good to know hours ago. :p | 21:40 |
| hatch | lol | 21:41 |
| hatch | time to spin up an ec2 instance | 21:41 |
| jcsackett | which is a thing to do tomorrow, as there's no way i'll get that working before EoD. | 21:42 |
| hatch | it's running here | 21:42 |
| hatch | I think... | 21:42 |
| hatch | in FF | 21:43 |
| hatch | will see if it fails | 21:43 |
| hatch | yup it fails | 21:43 |
| hatch | ^ jcsackett | 21:43 |
| jcsackett | hatch: hit the url saucelabs gave you and make sure you're not seeing a lack of connection issue. | 21:43 |
| hatch | trying | 21:44 |
| hatch | apparently I need flash | 21:44 |
| hatch | jcsackett oh I'm getting connection refused in the vid but the console is saying isBrowserSupported error | 21:45 |
| jcsackett | hatch: yeah, that error is a lie. | 21:46 |
| jcsackett | it's what errors when the test doesn't work. | 21:46 |
| jcsackett | period. | 21:46 |
| jcsackett | so: tomorrow morning i'll spin up ec2 and try there. | 21:46 |
| hatch | I'll try with sauce connect | 21:47 |
| hatch | oh wait | 21:47 |
| hatch | that requires a ton of setup | 21:47 |
| hatch | ok forget it | 21:47 |
| jcsackett | yeah, we're blocked for tonight. | 21:48 |
| jcsackett | unless you're going to bring up ec2 tonight--i don't have time to work post EoD today. | 21:48 |
| hatch | I still need to get this release out :) | 21:49 |
| hatch | hopefully | 21:49 |
| jcsackett | this doesn't block release, right? | 21:49 |
| hatch | I don't think so - I do need the tests to run | 21:51 |
| hatch | but Makyo was running into a different error | 21:51 |
| hatch | so we'll see :) | 21:51 |
| hatch | Trusty charm release has already been done | 21:51 |
| jcsackett | hatch: if you get to a point where you want to monkey with selenium issue, https://github.com/jaycee/juju-gui/blob/set-selenium-version/test/browser.py#L125 | 21:54 |
| jcsackett | that's how you set it. | 21:55 |
| jcsackett | i've gotta to go start making dinner. | 21:55 |
| jcsackett | i'll continue on this tomorrow morning, barring any news. | 21:55 |
| hatch | jcsackett ok thanks | 21:55 |
| hatch | I'll email with news (if any) | 21:55 |
| jcsackett | cool. | 21:55 |
| jcsackett | have a good evening. :) | 21:55 |
| hatch | u 222 | 21:56 |
| hatch | morning huwshimi | 22:54 |
| huwshimi | Morning | 22:54 |
| hatch | so CI is all sorts busted | 22:55 |
| hatch | that's why your stuff hasn't landed | 22:55 |
| huwshimi | hatch: Ah right, I was wondering what was going on :) | 22:56 |
| hatch | hopefully that won't block you too much | 22:57 |
| huwshimi | it's all good | 22:57 |
| hatch | huwshimi have you seen GSS ? | 23:01 |
| huwshimi | hatch: What's that? | 23:01 |
| hatch | http://gridstylesheets.org/ | 23:02 |
| hatch | there is a video which does a better job of explaining it, but it's using a different type of language and interpreter to do page layout than CSS | 23:02 |
| huwshimi | Oh yeah, I think I did see that | 23:04 |
| hatch | it's pretty cool - CSS can't get any worse so I'm all for something new :) | 23:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!