/srv/irclogs.ubuntu.com/2014/08/11/#juju-gui.txt

rogpeppe1mornin' all07:14
=== rogpeppe1 is now known as rogpeppe
rogpeppefrankban: hiya09:29
rogpeppefrankban: https://github.com/juju/charmstore/pull/6609:29
frankbanrogpeppe: morning, on it09:37
rogpeppefrankban: ta09:37
frankbanrogpeppe: LGTM09:40
rogpeppefrankban: ta!09:40
rogpeppefrankban: next up: https://github.com/juju/charmstore/pull/6710:24
rogpeppefrankban, dimitern, TheMue, jrwren: a little fix: https://github.com/juju/charm/pull/3810:52
TheMuerogpeppe: one moment, meeting10:54
rogpeppeTheMue: np10:56
TheMuerogpeppe: quickly done, has been nicely small10:57
rogpeppeTheMue: ta!10:59
frankbanrogpeppe: done11:08
rogpeppefrankban: thank you11:08
rogpeppefrankban: there's no CI set up on the charm package, is there?11:09
frankbanrogpeppe: AFAIK there isn't11:10
* frankban lunches11:14
rogpeppefrankban, TheMue, dimitern, jrwren, fwereade: update juju-core to use charm.v3: https://github.com/juju/juju/pull/48911:40
dimiternrogpeppe, reviewed11:43
rogpeppedimitern: thanks!11:43
TheMueah, I can step out, just started with review11:43
TheMuefirst shrugged about the number of files :)11:44
rogpeppeTheMue: it's almost all just import path changes11:53
TheMuerogpeppe: yeah, I’ve seen, additionally only those parts where the API changed11:58
rogpeppeTheMue: yup11:58
frankbanrogpeppe, jrwren: could you please review https://github.com/juju/charmstore/pull/68 ? thanks12:12
rogpeppefrankban: looking12:12
frankbanty12:12
rogpeppefrankban: reviewed12:20
rogpeppelc12:20
frankbanrogpeppe: thanks12:20
rogpeppefrankban, jrwren: would appreciate a review of https://github.com/juju/juju/pull/489 please12:21
rogpeppefrankban: (the charm.v2 branch finally landed!)12:21
frankbanrogpeppe: cool, and this is v312:21
rogpeppefrankban: yup12:21
frankbanrogpeppe: do we want core to use unstable v3?12:21
rogpeppefrankban: once core starts using it, it will no longer be unstable12:21
frankbanrogpeppe: ok12:22
jrwrenrogpeppe: done. I had looked earlier, but given its core, I didn't think I should +1.12:24
rogpeppejrwren: please add your +1 - i'll wait for frankban's review too12:25
jrwrenrogpeppe: done.12:25
frankbanrogpeppe: done12:25
rogpeppejrwren, frankban: thanks12:25
rogpeppeoh shit12:26
rogpeppedarn, forgot to update dependencies.tsv12:26
rogpeppeit won't land12:26
frankbanrogpeppe: heh12:27
* rogpeppe wishes there was some way of cancelling a jenkins job that's already started12:27
rogpeppeha, no need, it's failed already12:27
frankbanjrwren: I tried to not fully duplicate the manifest logic on the test side: that's probably the reason why you are confused12:28
jrwrenfrankban: Sounds good. I commented because I wanted to make sure it wasn't accidental.12:28
frankbanjrwren: cool12:29
* rogpeppe wants a merge tool that is a bit cleverer about go imports12:32
jrwrenI didn't notice until now that running tests spins up its own mongod to run. Cool.12:48
* rogpeppe goes for lunch13:43
hatchfrankban can you remind me how I go about qa'ing your precise branch? 14:17
hatchI can't remember the best practice for pulling it down14:18
frankbanhatch: thanks for looking at it14:18
frankbanhatch: do you have a charm GUI shared repo?14:18
frankbanGUI charm even14:18
hatchfrankban I don't14:18
hatchcan I check out just HEAD somehow?14:19
frankbanhatch: so, time to create one ;-)14:19
frankbanhatch: bzr init-repo juju-gui-charm14:19
hatchlol *sigh* I haven't had to set my vm up for bzr stuff again in a while14:19
frankbanhatch: cd juju-gui-charm14:19
hatchok got that far :)14:20
frankbanhatch: bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk trunk14:20
hatchthat's gona take a while :D14:21
hatchsee u in 10 years :P14:21
frankbanhatch: bzr checkout --lightweight trunk sandbox14:21
hatchI do that after it's done downloading the entire repo, correct?14:22
frankbanhatch: bzr branch lp:~frankban/charms/trusty/juju-gui/fix-legacy-server14:22
frankbanyes14:22
frankbanhatch: cd sandbox14:22
frankbanhatch: bzr switch ../fix-legacy-server14:22
hatchkadams54 looks like your branch has a test failure14:22
frankbanmake14:22
jcsackettkadams54: you need a second review, right?14:33
kadams54_jcsackett: yeah, and to figure out why one test is failing.14:33
jcsackettkadams54_: shall i wait till you've got that fixed?14:34
kadams54_jcsackett: I think it's safe to QA.14:34
jcsackettkadams54_: ok, i'll start reviewing now then.14:34
kadams54_jcsackett: thanks14:35
hatchjcsackett which view actually renders the charm details tabview when you click on the url?14:41
jcsacketthatch: i don't understand your question. you mean the charm url in the inspector?14:42
hatchwhen you click the charm url in the inspector14:42
hatchit opens a view14:42
hatchwhich view is that14:42
jcsacketthatch: it uses showViewelet to open the charmDetails viewlet.14:42
jcsackettwhich, in turn, uses browsercharmview...which in turn uses browserentitydetails, ircc.14:42
jcsackettturtles, all the way down.14:43
luca__when Juju is bootstrapped does the user have to define a name for it?14:45
hatchluca__ it is in the environments.yaml14:46
hatchwe use that name in the GUI14:46
luca__hatch: I see, thanks.14:46
luca__hatch: and the user can have any name they want14:46
luca__hatch: ?14:47
hatchyep14:47
hatchit's used as the key to the environment config14:47
hatchso for example I have a `juju bootstrap ec2-precise` 14:47
hatchwhich is an ec2 env using precise as the default series 14:47
hatchthere is also an ec2-trusty 14:47
hatchetc14:47
hatchjcsackett so why didn't you just prevent any click event on the anchor tags in the headers from bubbling from the tabview?14:48
jcsacketthatch: b/c we want it to dispatch to set the hash.14:49
jcsackettwith the new dispatch model there's no reason those should be special cased from the other version of charm details.14:50
hatchright, but a hash should just be able to be added to the end of the url all easy like14:51
hatchjujugui call in 1014:51
jcsacketthatch: that's not how it appears to work in charm details land off the charmbrowser.14:52
hatchI was under the impression that the issue was that pjax was picking up the click and re dispatching?14:52
jcsacketthatch: talk after the call?14:53
hatchwhen it really should just be able to update the hash in the url, 14:53
hatchyeah sure14:53
hatchsince we can't load the inspector in a real env I'm not sure how we can qa most of this anyways :)14:53
jcsackettwe can't load the inspector in a real env?14:56
* jcsackett thinks he missed something.14:56
jcsackettand anyway, this was a bug with fakebackend too.14:56
hatchnope it opens to a white sidebar and the charm details pane open - also blank14:56
jcsackettwhen did that start happening?14:57
jcsackett(you can still qa this against fakebackend--a real env wasn't necessary to create the bug)14:57
hatchyou were fixing it, and stopped because we were trying to get something else done....or something along those lines14:57
hatch:)14:57
* jcsackett blinks.14:57
jcsacketti haven't seen this happen in a real env, and don't recall what you're talking about.14:57
jcsacketti recall a bug about this awhile ago, but i recall fixing that.14:58
hatchif you visit a /inspector url in a real env you'll see it14:58
hatchyou fixed something in there by adding a retry 14:59
hatchbut this was something else i remeber you saying14:59
jcsackettdo we have a bug/card? b/c the only thing i recall related to this was quite old.14:59
hatchyeah I can find it14:59
jcsackettkadams54_: is your bug only about the deploy summary? the changelog is still showing individual everything.15:00
hatchhttps://bugs.launchpad.net/juju-gui/+bug/134956515:00
kadams54_jcsackett: Correct. Deploy summary is condensed, changelog shows everything.15:00
jcsackettkadams54_: cool.15:01
kadams54_That's what hatch and I decided after talking through the bug.15:01
luca__hatch: have you finished the new scale up journey15:14
luca__hatch: ?15:14
hatchluca__ in the inspector?15:15
hatchor in the machine view?15:15
luca__hatch: in the inspector15:15
hatchyes that's done with the exception of Huw's branch in review which adds the "1 unit (3 uncommitted)"15:16
hatchstuff15:16
hatchthat should be landing during his day as there are a couple issues with it atm15:16
hatchfrankban how do I check what branches I have/ what branch I'm on?15:18
frankbanhatch: bzr info15:19
hatchthanks15:20
hatch:)15:20
frankbanhatch: also bzr branches can help15:21
hatchfrankban so what does the bzr switch do? Is it like a merge?15:24
rogpeppehatch: bzr switch is a cobzr extension (unless the native bzr has it now)15:24
rogpeppehatch: it's just like git checkout15:25
hatchoh ok - native bzr must have it because I didn't install cobzr15:25
frankbanhatch: it switches to another branch, so that you can always work on sandbox15:26
hatchfrankban ok so make has been completed so now I can just deploy this as a normal charm?15:27
frankbanhatch: now you can follow the instructions on my MP15:27
frankbanhatch: in particular, make deploy lets you deploy what's on sandbox without having to setup a local juju repo15:27
hatchgreat 15:28
frankbanhatch: and from now on, you can "bzr branch" GUI charm branches from inside the shared repo, and it will be cheap and fast15:28
hatchnote to self- DO NOT DELETE FOLDER15:29
hatch:)15:29
frankbanhatch: for instance, if you want to work on a new GUI charm branch, you: 1) cd to sandbox 2) ensure there are no uncommitted changes 3) bzr switch ../trunk 4) bzr pull and 5) bzr switch -b my-feature-branch15:30
hatchsounds a lot like how bzr should work by default :)15:30
frankbanhatch: it supports lightweight checkouts by default actually, no need for cobzr or stuff like that15:31
frankbanhatch: all my bzr repos are set up like that. lightweight checkouts are not as fast as git named branches, but they are good enough15:32
frankbanguihelp: any of you do use zsh? I'd like to give it a try15:33
kadams54_I do, though I'm not really a power user15:34
hatchfrankban rick does, I did but it kept borking with my tmux stuff15:34
hatchnow that I'm back working in Ubuntu full time I will likely give it a go again15:34
frankbanhatch: hmm, I also use tmux15:34
frankbanhatch: it seems autocomplete, hostory search and such work much better15:35
hatchfrankban I think the issue was that there are just so many layers running when you have zsh and tmux that they clashed for me because I kept customizing them15:35
frankbankadams54_: ^^^15:35
frankbanI am taking a look at https://github.com/robbyrussell/oh-my-zsh15:36
kadams54_Yeah, that's what I use15:36
kadams54_https://github.com/kadams54/dotfiles - feel free to poke around in my zshrc15:36
frankbankadams54_: great thanks15:37
hatchI find the hardest thing to do is colouring15:38
hatchterminal + zsh + tmux = colour hell15:39
kadams54_I agree: colouring = hell. Coloring, on the other hand, is as easy as pie.15:40
kadams54_;-)15:41
jrwrenI don't use zsh, how does it affect colour?15:41
hatchlol15:41
hatchjrwren because you can set themes in it15:42
hatchso you have three things setting colours so when something is wrong it's hard to track down what is setting the colour15:42
jrwrenWhat is there to theme other than a prompt?15:42
hatchtypical linux boy15:42
hatch:P15:42
jrwrenIts true, as I sit at my OSX terminal :)15:43
hatchhahaha15:43
hatchlemme guess it's iterm2 isn't it?15:43
jrwrenyes.15:43
jrwrenYou win a prize!15:43
hatchman I wish Ubuntu had an iterm2 clone15:43
kadams54_frankban: https://github.com/scrogson/dotfiles is a friend of mine who does a lot more with tmux and zsh.15:43
jrwrenhatch: quake key is built in!15:44
hatchjrwren not quite the same :)15:44
hatchatm I'm really struggling with the font rendering in Ubuntu, trying to find something to make it prettier 15:45
hatchjujugui does anyone know how to hide the comments in a PR on GH?15:49
rogpeppehatch: rebase :-)15:49
hatchlol15:50
kadams54_OK, driving back home. Be back online in about two hours.15:51
hatchfrankban "unable to get bundle deployment statuses" notification and the juju-gui charm has no icon16:15
hatchare these to be expected on the legacy server?16:15
frankbanhatch: yes16:15
hatchcool16:15
hatch+1'd shippppit16:16
hatchjcsackett qa issue with your branch 16:20
hatchrepro instructions in the pr16:20
frankbanhatch: thanks!16:27
jcsacketthatch: huh.16:28
jcsacketthatch: well, that's annoying.16:28
hatch:) sorry16:28
jcsacketti'll figure it out post-lunch.16:28
jcsackettall good, better to catch it now than after landing. :p16:28
frankbanhatch: I am starting the process for a new charm release16:33
hatchthanks a lot! 16:33
hatchthese charm releases are kind of a pita :)16:34
rick_h__guten tag17:02
rick_h__frankban: zsh <317:02
rick_h__frankban: I'll try to get you some sample stuff sometime.https://github.com/mitechie/zshrc17:07
rick_h__frankban: ^ is a lighting talk I gave long ago on some reasons to <3 zsh17:07
frankbanrick_h__: nice thanks!17:07
rick_h__frankban: but when I get back can get my zshrc out if you need anything17:08
frankbanrick_h__: cool17:11
hatchrick_h__ AHOY!17:13
rick_h__hatch: howdy!17:19
rick_h__train wifi is stinky on this return trip17:19
hatchchoo choo17:19
rick_h__and now the train is stopped...hmmm17:19
rick_h__hatch: how goes?17:19
rick_h__sent an email to the list, basically a big high-five17:19
hatchit's going, saw your mountain picture, still jealous NBD!17:20
hatch:)17:20
rick_h__MV almost done :P 17:21
hatchslowly but surely 17:21
hatchdoing a lot of reviews and qa's so something must be getting done :)17:21
rick_h__damn net keeps dropping17:26
rick_h__anyway, reminder I'm afk for a bit. Uros can answer stuff tomorrow but not much to say for now. 17:27
hatchyep np, you go enjoy your vacation17:28
* rogpeppe is done for the day18:08
rogpeppeg'night all18:08
* kadams54 is back18:18
jcsacketthatch: i just realized i didin't commit and push my qa-fix. so i've done that, if you want to look at the PR again. :p19:25
hatchhaha sure ok19:25
jrwrenhttps://github.com/CanonicalLtd/charmstore-charm/pull/219:25
jrwrenerr..19:25
hatchjcsackett big fix lol19:27
jcsacketthatch: right?19:27
jcsackettjust huge. :p19:28
hatchhaha19:29
hatchjcsackett so I see you set rendered to false in the charm details....that means that we are using the same instance of charm details all the time?19:30
hatchafter a class has been 'destroyed' typically you don't revive it again19:31
jcsacketthatch: yeah, instead we keep creating new browsercharmdetail views.19:32
jcsacketthatch: i believe this is true predating this branch; i think it's something to do with how we're creating viewlets, mixed with how inspector has evolved.19:33
jcsackett1 more for the "we need to clean up slots/viewlets" pile.19:33
hatchohh so the issue is that the pointer to the charmView to check if it should create new or update is still pointing to the destroyed version19:33
jcsacketthatch: where? happy to fix that now.19:33
hatchjcsackett I added a comment to the line I THINK is the right place19:34
hatchbasically you are having to set rendered to false when something is destroyed when really we should just be checking if it was destroyed 19:35
jcsacketthatch: i find it non-intuitive that a "destroyed" object still exists so i can check it.19:36
jcsackett:p19:36
hatchjcsackett haha blame javascript19:37
jcsackettoh, i do. i do.19:38
jcsackett:p19:38
hatchin python when you destroy a class instance does it destroy all references to it as well?19:38
jcsackettfor so *many* things.19:38
hatchI guess python has NATIVE classes though19:38
* jcsackett nods19:38
hatchjcsackett we could always switch to Dart :) 19:38
jcsacketti don't know enough about Dart to immediately nix that, but i'm going to guess it's not worth the rewrite. :p19:39
hatchhaha no, no it's not19:41
hatchbut if we were starting new I would seriously consider it19:41
hatchthe GUI is now sufficiently complicated I can no longer keep its execution flow in my head19:41
hatch*sadface*19:41
jcsacketthatch: i hear that.19:42
hatchtime to go pick up a copy of visio and graph it all :P19:44
hatchjcsackett +1'd with trivials, lemme know if the test request makes sense19:46
jcsacketthatch: i may have to keep the 'rendered' in destroy hack; doing it with checking 'destroyed' is leading to the pane opening with no content on the second click.19:46
jcsacketti think the slot system doesn't clean up after itself right this way--we're forcing it do things it's not really built for.19:46
hatchson-of-a19:47
hatchok then, I think my test request still holds19:48
jcsacketthatch: do you mean add a test showing that it handles the destructor thing? because this path doesn't involve the destruction cycle.19:48
jcsackettthis, for example, might be clicking one tab and then another.19:48
jcsackettif you mean "update the test to include seeing what destroy does" +1, if you mean something else, i don't follow. :)19:49
hatchyeah sorry - I meant test the destructor cycle, because we had to add that into there to make sure it did what it was supposed to do19:50
jcsacketthatch: and i can now confirm that showViewlet is reviving the "destroyed" viewlet, so rendered needs to be set to false. i'll add an XXX to explain that the viewlet stuff isn't destroying things properly.19:51
hatchexcellent thanks19:51
hatchubuntu looks about 1M x better on a non-retina screen :)19:51
hatchI wonder who I poke to see about getting that fixed19:51
hatchthe font rendering that is19:52
hatchjujugui do we have any UI for removing units from machines? 20:31
kadams54I don't think so20:31
hatchkadams54 so the only way atm to remove a unit is via the services inspector?20:34
kadams54Yes20:34
hatchhmm then the lazy remove unit method is incorrect20:35
hatch*sigh*20:35
hatchin fact, I don't see how it was ever right hah20:35
hatchactually kadams54  looks like you wrote it....do you remember when you wrote the remove unit method in the ECS? 20:37
kadams54Sure20:37
hatchok one sec 20:38
hatchkadams54 https://github.com/juju/juju-gui/blob/develop/app/utils/environment-change-set.js#L691 so right here you assign args[0] to service then use it as a service.....but args[0] was always an array of units to remove...20:39
hatchor am I missing something20:39
hatchI'll create a follow-up card to fix this but atm there is no way this could work to remove ghost units....at least I don't see how it could20:41
hatchweird it does work20:42
hatchlol20:42
kadams54I see what you mean, but I'm not sure why it wouldn't work20:43
kadams54It seems like it would, just maybe not with the API it should have20:43
hatchwell because args[0] is an array20:45
hatchand you're checking if command.args[0] === args[0] 20:45
hatchso it can only ever remove a single unit if a single unit was added20:45
hatchit'll work for a real unit, but not for ghosted stuff20:46
hatchdoes that sound right?20:46
kadams54No?20:47
kadams54Seems to me like it'll work for a single unit but not multiple. Ghosted or not doesn't matter.20:47
kadams54Ah, OK, I see… that comparison only happens when checking for ghosted.20:48
hatchwell the real units it would just pass to the changeset and execute the args via the backend20:48
hatchyeah20:48
hatch:)20:48
kadams54But if you only pass a single ghosted, that should still work20:48
hatchyeah ok I'll file a bug/card so we don't forget about this and release it20:49
hatchheh20:49
hatchkadams54 https://bugs.launchpad.net/juju-gui/+bug/135544020:51
hatchdoes that make sense? :) 20:51
hatchcard created in project 1 - if it doesn't please update it 20:52
jcsackettjujugui: i need another review on https://github.com/juju/juju-gui/pull/487 21:20
hatchdon't everyone jump at once ;)21:33
hatchjcsackett do you know when matt is back?21:48
hatchjujugui does anyone else get a drop error when trying to drag and drop in chrome on ubuntu?21:54
hatchhappens about 50% of the time for me21:54
hatchI have to drag and drop fast for it to not it seems21:55
huwshimiMorning23:01
hatchmorning huwshimi 23:02
huwshimihatch: How's things?23:04
hatchtruckin along, spent a lot of time today doing qa heh23:04
hatchI looked at your branch and was getting a failure in a totally different spot than you mentioned23:04
hatchso I figured I better wait to see what you said23:04
huwshimioh dear23:05
huwshimihatch: What error did you get?23:05
hatchsame one that's listed in the CI failure23:05
huwshimihatch: Yeah, that's the same thing, I just pointed to where the tests are actually failing23:08
hatchoh....damn23:08
hatchhuwshimi ok so I can look into this when I get back in a couple hours, have to go run some errands and whatnot23:11
huwshimihatch: sure, no problems. Much appreciated.23:12
hatchbbl cya23:12
jcsacketthatch: https://bugs.launchpad.net/juju-gui/+bug/132392423:14

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!