=== chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun === shuduo is now known as shuduo_afk [06:51] Good Morning :) [07:19] good morning [07:21] good morning :) [07:23] where can I help for the dutch translation ? [07:23] O was running dutch on my phone but I didn't even notice because there was so much english [07:27] https://translations.launchpad.net/ubuntu-touch-preview [07:27] https://translations.launchpad.net/ubuntu-phone-coreapps [07:28] thx dholbach [07:51] I'm getting a lot of timeout errors on launchpad === chriadam is now known as chriadam|away [07:58] dholbach: the dash on the phone shows up as an app in the app overview but unlike the other apps you can't close it whit swiping up, but you also don't get a notification about it, found it rather confusing [07:58] where should I report that ? [07:58] on unity8 perhaps? [08:01] i think thats the wanted design [08:01] ok did that :) [08:01] (i agree it is confusing at first) [08:01] I can understand that that is the wanted design [08:02] but yea, you should than get a notification about it at least [08:02] maybe even prevent the movenment [08:03] yes, thats what i would do [08:04] make it immovable to confuse less [08:04] indeed [08:04] maybe even both [08:04] immovable and a small notification that you can't close it [08:34] Good morning all; happy Monday, and happy Ingersoll Day! :-D [08:52] dholbach: fixed [08:53] mzanetti, approved [08:53] dholbach: cheers [08:54] rock on! [08:55] t1mp: hey, ToobarItems.back doesn't seem to work for me... Is that a known bug? I tried to override the back icon just like the exampe in the docs, didn't change a thing [09:03] mzanetti: do you have the url for those docs at hand? [09:03] mzanetti: are you sure you want to be implementing a toolbar? [09:03] t1mp: I pressed F1 on ToolbarItems in qtc [09:04] t1mp: ToolbarItems has (according to the docs if you press F1) a "back" property which points to the back button [09:05] popey: ping [09:05] t1mp: the doc example overrides it with a cancel button which is pretty much what I wanted to do [09:05] t1mp: but whatever I did with that "back" property, it wouldn't matter [09:05] mzanetti: the example works for me, see https://www.dropbox.com/s/49phikdl26yrkko/Screenshot%202014-08-11%2011.05.05.png [09:05] nik90: pong [09:06] mzanetti: it is not aligned pretty, and it doesn't look pretty to put a "normal" button in a toolbar (and toolbars are deprecated), but it does what it should [09:07] t1mp: hmm... I see [09:07] t1mp: useDeprecatedToolbar: false :) [09:07] popey: hey did you get an update from ev about the geonames situation? [09:07] popey: I am working now on implementing the feature in the new clock app and need the data to be extended to include timezoneid as mentioned in the bug report [09:07] mzanetti: do you want to get a toolbar or header? [09:08] t1mp: well, header, with actions, and I would like to override the back action [09:08] mzanetti: with the header, I recommend to use the new API that is here http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.PageHeadConfiguration/ [09:08] mzanetti: if you don't want to switch to that yet and use the old (ToolbarItems API) with the new header, [09:09] mzanetti: then define the back button using an action. So back: Button { action: Action { text: "cancel" }} [09:10] nik90: no, i need to look at that again today [09:10] mzanetti: code + screenshot: https://www.dropbox.com/s/jtg8l4375aa6ufp/Screenshot%202014-08-11%2011.10.02.png [09:10] t1mp: hmm... ok... I'll try again... I wouldn't mind using the new api, but I didn't succeed with that either... but I need to try more to be certain what's wrong [09:10] popey: ok [09:11] t1mp: I'm very sure I tried this... but ok... seems its working. thanks a lot [09:11] t1mp: btw, new fahrplan app now seems to support netherlands if you're still interested (I remember we talked about this like a year ago :D) [09:11] mzanetti: new API is like this: https://www.dropbox.com/s/q9kfsbdo49cjq8r/Screenshot%202014-08-11%2011.11.32.png [09:12] mzanetti: I just move to spain 4 days ago :) [09:12] ah ok :) [09:12] mzanetti: I'll check it out when I'm in Netherlands :) if I remember [09:12] t1mp: oh, that's how you use the new one! that looks good, thanks! will move over to the really new one then [09:12] mzanetti: ooh thnx for that. I can use it :D [09:12] nik90: :) [09:12] mzanetti: how the hell did you get the API for 9292ov.nl. I have been looking for a long time [09:13] mzanetti: sure. Let me know if you get stuck with it, I should be able to help [09:13] t1mp: well, now that I know it *is* working and have a code example I'm sure I'll find my way. thanks again. [09:13] nik90: wasn't me... I just do the ubuntu ui [09:14] mzanetti: ah ok [09:14] nik90: this app has been rated as one of the top 10 BBX apps of 2013 :D [09:14] while in ubuntu it has one rating with 1 star... [09:14] * mzanetti wonders if he messed up so hard with the ui :D [09:15] mzanetti: wow it returns the results that I expect :) This is awesome [09:15] nik90: you can see the code yourself, it's at https://launchpad.net/ubuntu-geonames - there's a script there which sets it up [09:15] mzanetti: where do I report bugs? [09:15] mzanetti: perhaps ubuntu users are more critical, and 1 star is super good ;) [09:15] popey: sweet. I will look into it [09:17] nik90: https://github.com/smurfy/fahrplan [09:20] nik90: if you report bugs related to the ubuntu ui, please ping me too. I'm not really watching that github project all the time [09:21] mzanetti: will do. I would like to contribute too :) [09:21] nik90: ah ok, sure... that guy is really open to contributions. [09:21] nik90: one thing that would be great: [09:21] mzanetti: is it easy to get it and build it? [09:22] nik90: the backend code supports location stuff. so it autoselects stations according to location. I didn't add that in the ubuntu ui yet [09:22] nik90: just clone it, open it in qtc and run it (desktop only) [09:22] nik90: for the phone there's a run_on_ubuntu_touch.sh script [09:22] nik90: to create a click package use run_on_ubuntu_touch.sh -c [09:22] mzanetti: ah ok [09:23] nik90: but finish off tht clock app first... RTM is close ;) [09:23] mzanetti: hehe ofc :) [09:24] mzanetti: only 1 feature away from completion which is a wip [09:24] nik90: and then I'm going to test it - muahahaha :D [09:24] lol [09:25] nik90: reminds me... started to use the alarm now in production mode... turns out it doesn't support snoozing [09:25] will that come with the reboot? [09:25] mzanetti: yup, its being worked by charles kerr. It will land in indicator-datetime and then come in the clock reboot [09:25] mzanetti: ETA ~1-2 weeks [09:25] awesome === chihchun is now known as chihchun_afk [09:54] anyone up for reviewing https://code.launchpad.net/~nik90/ubuntu-clock-app/add-multiselection-mode/+merge/230140, it adds a nice multiselect mode for alarms :D [09:57] popey, o/ this landed \o/ https://code.launchpad.net/~andrew-hayzen/music-app/listitem-actions-take-2/+merge/229536 [09:57] \o/ [09:57] time for a store update? ☻ [09:57] popey, yep :) [09:57] popey, we updated the .pot as well [09:58] sweet, will set some time aside to update the app in a little bit [09:58] popey, thanks [09:58] no, thank *you* ! [09:58] popey, now onto bottom edge and ap refactor :) [09:58] popey, hah no problem just glad to get it merged after 2-3months lol [09:59] ☻ [09:59] popey, how to extend it in the future with multiselect etc but it has feature parity to what we had before so we merged :) [09:59] *going to extend [10:01] popey, oh and FYI, as u weren't in the meeting last wk, the last thing we are waiting for before content-hub support lands is https://code.launchpad.net/~jamesh/mediascanner2/model-auto-update/+merge/229903 [10:01] popey, bug tracking here https://bugs.launchpad.net/music-app/+bug/1347444 [10:02] Ubuntu bug 1347444 in Ubuntu Music App "Music app does not expose download handler" [High,In progress] [10:03] thanks === chihchun_afk is now known as chihchun [10:57] nik90: got a click? ☻ [10:57] popey: not yet. one min [11:00] hi everyone [11:02] popey: https://www.dropbox.com/s/bih4zlrun7f7yyc/com.ubuntu.clock.devel_0.1_all.click [11:03] hey nik90, do you know if the package branch got anywhere? [11:03] nik90, does it fully work for you now? [11:03] dholbach: I asked sergiusens to look at it on friday to finish any remaining bits. I haven't heard from him yet :/ [11:04] maybe we should start pinging other folks [11:04] maybe Mr Zanetti can help [11:04] or anyone else [11:04] dholbach: I don't know who else is familiar with cmake [11:04] is https://bugs.launchpad.net/ubuntu-clock-app/+bugs?field.tag=reboot a good reflection of what still doesn't work with the branch? [11:04] nik90: thanks [11:05] dholbach: I think it is better to ask someone to take your branch and then fix the necessary stuff to get it to build a deb and click successfully. [11:06] dholbach: deb part is complete. I guess so only the cmake stuff needs fixing to get the click packaging done. I can report bugs about it not finding the backend when running a device [11:06] on device* [11:06] nik90: love the bounce when you choose alarms to delete [11:06] nik90, that would be good [11:06] nik90, I updated https://bugs.launchpad.net/ubuntu-clock-app/+bug/1354377 [11:06] Ubuntu bug 1354377 in Ubuntu Clock App "Unbreak 'make autopilot'" [Medium,Confirmed] [11:07] we need a BOOIINNNNGGGG sound effect [11:07] balloons, ^ do you think you can help find somebody who can try to fix the bug? [11:07] popey: lol [11:07] nik90: it doesn't actually delete them when I select and then tap delete [11:07] popey, it'd be good if we could find somebody else who can fix the remainder of https://bugs.launchpad.net/ubuntu-clock-app/+bugs?field.tag=reboot to make https://code.launchpad.net/~dholbach/ubuntu-clock-app/reboot-packaging work [11:07] popey, I think I did all I could so far [11:08] popey: wat, it doesn't delete? let me try again on my end [11:08] k [11:08] oh, i lied, it probably does but the app locked up [11:08] probably because I have another clock reboot app open [11:09] yeah, it did, no alarms left [11:09] * nik90 sighs a relief [11:10] popey: btw your bug about alarms showing 00:00 has been approved. Will start on it soon [11:11] popey: I might need to report a bug about showing an activity indication when an alarm operation is being done. [11:14] dholbach: btw balloons suggested some changes to the ap-setup for trunk. Could you check if it will merge into your branch as well without much conflicts. [11:15] dholbach: I can first merge to trunk which you can then update to get it automatically if you want [11:19] nik90, let me check [11:20] I'll merge it [11:21] ok, it lgtm. Shall I approve and merge to trunk first? [11:22] popey: goto blue fin via big ben at midday :) [11:22] wat wat? [11:23] you'll be able to get a nice recording of the boooooiiiinnnnngggggggssss [11:24] popey: can you approve (device testing) https://code.launchpad.net/~nik90/ubuntu-clock-app/add-multiselection-mode/+merge/230140 and https://code.launchpad.net/~nik90/ubuntu-clock-app/add-vibration-support/+merge/229327 [11:24] popey: you already tested those branches [11:24] I will find someone to do the qml code review and merge it when top approved [11:24] popey: like this http://www.youtube.com/watch?v=juT1zsim6es [11:25] nik90: done [11:25] popey: thnx [11:26] popey: is that the kinda boing you were thinking of [11:26] no [11:26] thats bong, not boing [11:27] https://www.youtube.com/watch?v=Tnh8IGwvL9U [11:30] popey: there is bound to be a boing in here you can use [11:30] http://www.youtube.com/watch?v=PMpu8jH1LE8 [11:30] popey: oh for that boing you just need a mouth harp [11:31] popey: if you want I can release a special clock reboot click which does that for you :P [11:31] haha [11:31] no. [11:31] ☻ [11:31] Thank you. [11:36] popey: thanks for bug prioritize :) [11:37] is there a way to make a ListItem element use an UbuntuShaped icon? [11:37] rather than a square one [11:40] seb128, do you mean like the music app does? [11:40] ahayzen, not sure, I've not been trying the music application [11:40] seb128: are you referrring to the icon in a listitem to use the ubuntushape? [11:40] nik90, yes [11:41] seb128: doesn't it use the ubuntushape automatically? [11:41] ah yes [11:41] seb128: either way there is a property called "iconFrame". Set that to true if you want the ubuntushape border around the icon [11:42] nik90, thanks [11:42] that does it [11:42] seb128: yw [11:43] if that property is false then the icons are squared [11:43] yes indeed [11:44] nik90: you can't reboot popey ;) [11:44] davmor2: wat nonsense...you didnt try with sudo :P [11:45] nik90: hahahaha [11:53] nik90, I merged it - bug http://91.189.93.70:8080/job/generic-mediumtests-utopic/1466/console doesn't look like it's fixed by merging the branch yet [11:54] dholbach: ack. I expected it just remove some hacks for the OSK and improve local test runs. [11:54] ok [11:56] nik90, unrelated, but when I run "make autopilot" in the autopkgtest, I get this: http://paste.ubuntu.com/8016541/ [11:56] dholbach: on utopic? [11:56] yes [11:56] shall I file a bug for it? [11:57] dholbach: sure, but I think it is a autopilot related error and not due to the clock app [11:57] ok, should be good to get an autopilot expert on it [11:57] yes [11:58] we use dbus in our Alarm.Settings plugin, however that doesn't even get loaded in those tests. [11:58] I have no idea [11:59] report the bug and I will check with elopio and balloons about it [12:00] done === _salem is now known as salem_ [12:40] mzanetti: quick question. Is there a way I can detect when the jsonModel request is fully received? My use case is to show a activity indicator when the data is being gatthered and hide it when it is finished receiving everything. [12:40] mzanetti: should I emit a signal in the networkReplyFinished() function? [12:42] nik90: yeah, the replyFinished is the one that tells you when its finished [12:42] nik90: but I'd do this: [12:42] nik90: add a Q_PROPERTY(bool loading ...) [12:43] nik90: so you don't have to deal with signals in the ui [12:43] nik90: but just can do activityIndicator.running: backend.loading [12:43] mzanetti: ah ok. and set loading as false in the replyFinished part. [12:43] mzanetti: sweetr [12:43] mzanetti: thnx [12:43] nik90: yeah, you need to do a emit loadingChanged() in order to tell QML that the property has changed [12:44] nik90: but yeah, inside QML just use the property, not the signal [12:44] mzanetti: yeah as usual . [12:44] yep [12:59] popey, have u got a moment just to try an early prototype? no worries if u haven't [12:59] ahayzen: does it need rw phone? [12:59] popey, just a click for music app bottom edge support [13:00] oh sweet, sure [13:00] popey, https://docs.google.com/file/d/0B3XynHVKfrvMM1B3OXlWQ0wxdHc/edit [13:00] popey, i've only just moved it from experimental to development so it has some rough edges but u'll get the idea :) [13:00] * ahayzen hopes it works [13:00] lets see... [13:02] ahayzen: thats quite neat! [13:02] \o/ [13:03] popey, a found bounds a mouse areas need tweaking but it is getting there [13:03] * ahayzen hopes victor approves of his hacks to reparent the same page [13:30] popey, yey https://code.launchpad.net/~andrew-hayzen/music-app/bottom-edge-implementation-001/+merge/230303 \o/ we'll see what jenkins thinks of that === chihchun is now known as chihchun_afk [14:20] dholbach: can we add an option to click-reviewers-tools to only spit out warnings/errors? [14:40] popey: ping [14:40] popey: this seems to be an ancient bug, and I guess it is not valid anymore... https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1206870 [14:40] Ubuntu bug 1206870 in Ubuntu UI Toolkit "OSK doesn't automatically hide when fields no longer on screen" [Undecided,New] [14:42] popey, yes, it should be easy to write a script which does that [14:43] maybe you can file bug report? [14:52] zsombi: will take a look [14:52] dholbach: already done ㋛ [14:52] dholbach: https://bugs.launchpad.net/click-reviewers-tools/+bug/1355215 [14:52] Ubuntu bug 1355215 in Canonical Click Reviewers tools "Should have an option to only show errors/warnings" [Undecided,New] [14:53] great [15:20] balloons, do you think some QA hero could take lp:~dholbach/ubuntu-clock-app/reboot-packaging and make autopilot bits, autopkgtest and everything related to that work? [15:20] balloons, I did as much as I could, but I just don't know how to proceed [15:21] https://bugs.launchpad.net/ubuntu-clock-app/+bugs?field.tag=reboot being the list of related bugs I know of [15:21] hey dholbach :-) I actually did an MP that nik90 was going to review last week to make launching work a bit saner. I believe it landed [15:21] dholbach, making your branch ubuntu-clock-dev might be helpful and I contrib straight to that branch [15:21] balloons: he tried it with your branch as well. I told dholbach about it [15:22] but yea, definitely can help [15:24] balloons, bug 1354377 and bug 1355145 [15:24] bug 1354377 in Ubuntu Clock App "Unbreak 'make autopilot'" [Medium,Confirmed] https://launchpad.net/bugs/1354377 [15:24] bug 1355145 in Ubuntu Clock App ""make autopilot" fails in autopkgtest" [Undecided,New] https://launchpad.net/bugs/1355145 [15:25] balloons, I merged your branch [15:25] balloons, ... with a very small modification (using 1355145() in tests/autopilot/ubuntu_clock_app/tests/__init__.py) [15:26] sorry, ... using find_local_path() in tests/autopilot/ubuntu_clock_app/tests/__init__.py [15:26] dholbach, yea, I saw that and wasn't sure how I felt about it.. it's an interesting issue with local [15:27] balloons, the problem is that "builddir" is not what is used during the deb package build [15:27] dholbach, yea, we should talk about it after our call if you have a moment [15:27] sure [15:30] nik90, do you plan on merging down stuff or you wanting to land dholbach's mp first? [15:31] balloons: I was thinking of merging your branch since daniel already merged your branch into his [15:31] I was thinking that it'd be nice if stuff was working and then could be merged into trunk [15:31] but I'm not sure - maybe it'll help to get stuff fixed if it's trunk already :) [15:31] dholbach: so what's the verdict? Should I wait or merge? [15:31] :) [15:32] nik90, it's your project :) [15:32] I don't see any harm in pushing dholbach's change before merging [15:32] dholbach: well I don't want your life even more harder by changing trunk so frequently (atleast the parts that afffect you) [15:33] balloons: I cannot merge dholbach's branch into trunk yet since that breaks the click packaging. I would no longer be able to test on device. [15:34] nik90, can you file a bug tagged with 'reboot' about how it breaks click packaging? [15:34] nik90, ahh.. this is something we want to fix before merging then eh? [15:34] I'm saying while we have dholbach helping out it makes sense to square everything away [15:34] balloons: definitely. I am still implementing some features and testing on device is crucial for me [15:34] dholbach: sure, let me test again [15:34] cool [15:35] dholbach, balloons: Can we quickly make a decision on balloons's ap-setup branch. Wait or push? [15:35] nik90, sure - feel free to merge [15:35] dholbach: ok [15:49] balloons: merged. Can you ping me later in the evening when you are free? I want to merge 2 other branches I have. [15:59] thank god we have the unstoppable balloons! [15:59] haha.. nik90 dholbach is going to finish his magic and I think we'll be good to go [16:00] * nik90 is puzzled [16:00] what magic happened? [16:01] dholbach, btw, those hardcoded paths were supposed to die, ohh I don't know, last July? :-) [16:01] balloons, they weren't my idea [16:01] :) [16:01] so ideas for more elegant ways to do this are welcome from you [16:02] well, the idea is we intended to upstream this complexity, but it's never really fit for various reasons [16:02] we have cmake and autopkgtest now.. in theory it's more doable to change the setup [16:02] and nik90 is used to being the guinea pig for these experiments [16:02] :-0 [16:03] balloons, added my work-flow to https://bugs.launchpad.net/ubuntu-clock-app/+bug/1354377 [16:03] Ubuntu bug 1354377 in Ubuntu Clock App "Unbreak 'make autopilot'" [Medium,Confirmed] [16:03] balloons: I am kinda out of sync with what's happening :P [16:03] but yes :D [16:03] nik90, ^ too - if you should ever want to test autopkgtest, etc [16:03] dholbach, ahh you are testing it still as a deb.. interesting [16:04] dholbach: oh new way to run ap test. [16:04] balloons, yeah, generate a source package from the branch, then feed it into autopkgtest [16:04] dholbach, so pitti added support for running clicks directly.. Let me also comment on the bug [16:04] balloons, hum, this is not in the click mode [16:04] dholbach, right, but again, pretend this wasn't debian packaged.. we can still run it [16:05] which is something we couldn't do before.. and it's why we don't need to package tests anymore [16:05] balloons, sure, it'll exercise a second path of the code [16:08] * balloons checks his workflow, well, works [16:12] so anyways, let's look at the output of http://91.189.93.70:8080/job/generic-mediumtests-utopic/1466/ [16:13] so the -autopilot package looks good.. sticks stuff into /usr/lib/python3/dist-packages/ubuntu_clock_app/ [16:15] bah-hah.. so dholbach you have been foiled by jenkins.. Notice it's running the tests as python2 [16:15] that's the only issue methinks [16:15] oh? === gatox is now known as gatox_lunch [16:17] balloons, how and where do I fix it? :) [16:20] dholbach, well from the jenkins side, that's for CI to run.. but I need to check something [16:22] dholbach, just for kicks, is it possible for you to package python2 tests as well? [16:22] balloons, where do we have python2 tests in the branch? [16:22] assuming they are compatible, etc, etc [16:22] aka, the same tests [16:24] balloons, how would they be different then? [16:25] you mean, there should be one package ubuntu-clock-app-autopilot-python2 shipping files in /usr/lib/python2...... and another one for python3? [16:25] dholbach, they wouldn't.. I was just going to check on the other apps to see how the packaging was going [16:25] dholbach, yes.. jenkins would work as-is if we put them in /usr/lib/python2 [16:25] maybe not even 2 packages.. anyways I need to check [16:25] notes-app-autopilot uses ./usr/lib/python3/dist-packages/notes_app/...... [16:26] yes, dholbach technically jenkins should be updated to run as py3 [16:26] they all should be running as py3, but I see many are not [16:26] hum [16:26] maybe we should ask somebody from the the team [16:27] yea, seems like the packaging is also python2 on the other core apps [16:27] anyways, yes the solution is to have CI update the jenkins job [16:27] ok, I see [16:28] all right - I think with that I call it a day now :) [16:28] thanks for helping getting this fixed! [16:28] dholbach, for sure.. thanks. I think everything is good. I'll fix jenkins [16:28] rock and roll :-D [16:29] nik90, do you think you can still file this other bug with your click work-flow? [16:29] nik90, maybe with instructions for how you use it [16:29] dholbach: yeah, sry was triaging bugs [16:29] awesome, thanks! [16:29] have a great rest of your day - see you tomorrow! :-) [16:30] dholbach: cu tomorrow :) [16:36] mzanetti: hey finished implementing https://code.launchpad.net/~nik90/ubuntu-clock-app/json-search-ui/+merge/230339 based on your whereyourissisat. The bool loading property did the trick with showing the activity indicator. [16:36] mzanetti: try searching for cities to see if you get results === bfiller is now known as bfiller_afk [16:51] fginther, can you switch clock-app jenkins merges to rn as python3 instead of python2? [16:52] balloons: are we sure the old clock app tests pass with python3? [16:53] balloons: or is it possible to only change to python3 for the reboot branch alone? [16:55] nik90, that's what I was going to ask you.. if the old clock branch will receive any development or not [16:56] balloons: not by me atleast..I have been marking certain bugs as Won't fix for the old clock app simply because we fixed in the new clock app and cannot backport due to lack of time [16:56] balloons: so to me, old clock app is frozen. I will need to talk to popey about it in my meeting this week [16:57] as far as the tests go they do run py3 [16:57] ok [16:59] balloons, o/ [16:59] ahayzen, allo [17:00] balloons, FYI listitem actions landed!...so now may be the time to start the ap refactor [17:00] balloons, the only 'big' landing i see is the bottom edge stuff i'm working on...but that has only broken 3 tests (which i think are all due to it not waiting for animations to complete) [17:01] balloons, how would i go about starting this rewrite? [17:04] ahayzen, yes I saw the bottom edge bit [17:04] :) bottom edge is fun [17:04] ahayzen, I would take a Page at a time and redo the tests [17:04] balloons, should i copy a structure from somewhere? eg clock tests? [17:05] pull them out of test_music.py and make a seperate file. Then make a helper class inside emulator.py. I would also rename emulators to helpers. [17:05] balloons, i was gonna make it owned by ~music-app-devs so any of us could work on it [17:05] there's a few other cleanups you can do, but redoing the tests themselves is a good start [17:05] ahayzen, brillant [17:05] ahayzen, reminders is even newer than clock [17:05] I suppose I would copy it [17:05] balloons, ok i'll look into doing that... shall i just convert one test and then send to u so u can tell me what i'm doing right/wrong ? === chihchun_afk is now known as chihchun [17:06] ahayzen, if you put it into a branch we can all touch, feel free to ping [17:06] balloons, awesome thanks :) ... once we have migrated the tests i wanna add more for url-handler as well ... do u know if we can do ap tests for content-hub? [17:07] balloons, ...and would we be able to emulate a blank library? [17:07] balloons, ^^ are the places the current tests don't cover [17:08] ahayzen, feel free to file some bugs so we know about those gaps if you haven't done so [17:08] ahayzen, reminders has the urldispatcher tests in it you might find interesting [17:09] balloons, we have some old bugs... but basically this is my list of references/things to do at the moment https://trello.com/c/2p7zUffL/278-music-refactor-ap-tests-to-use-python3-correct-objectname-test-var-names [17:09] balloons, awesome i'll check them out as well [17:13] balloons: ping! [17:13] mihir, pong [17:17] balloons: this MR should be ready , but as per kunal last comment , [17:17] https://mail.google.com/mail/u/0/#inbox/14721a12ea11cf5e === gatox_lunch is now known as gatox [17:17] i have que, why onExpandedChanged is not getting tirgged on OptionSelector [17:17] any ida? === bfiller_afk is now known as bfiller [17:23] mihir: you do realise we do not have access to your gmail account :D [17:24] nik90: sorry , forgot to paste the code, http://paste.ubuntu.com/8018891/ [17:25] I am trying when openSelector get expanded hide the OSK [17:30] balloons, can you provide a link to a job or build that needs to be changed? I just want to be certain on which clock tests to chane [17:30] change [17:45] fginther, sure. http://91.189.93.70:8080/job/generic-mediumtests-utopic/1466/, http://91.189.93.70:8080/job/ubuntu-clock-dev-ubuntu-clock-app-utopic-3.0-ci/ [17:45] mihir, :-) so you think what you have in the MP should work as-is? I wasn't sure [17:45] The pickers work on the device again [17:46] balloons: okay , let me know when you have time we can test my MR on device. [17:46] mihir, I can do it now.. let me try [17:47] balloons: okay, but i guess , onExpandedChanged is not working as expected [17:57] balloons: sorry got dc [18:04] mihir, no worries [18:14] nik90: heh, you missed part of my inline comment before :) [18:15] nik90: technically it was 2 inline comments, although just one sentence [18:17] mzanetti: the inline comments feature is a bit confusing and goes away after I do a push. But luckily I didn't refresh the page, so I caught the second part of your inline comments :) [18:17] nik90: there's a combobox above the diff where you can go back to previous versions and inline comments [18:18] nik90: but I agree it's not totally awesome yet [18:18] mzanetti: oh I totally missed that..nice [18:25] balloons: got some time to spare? [18:49] nik90, sure thing [18:53] balloons: can you top approve https://code.launchpad.net/~nik90/ubuntu-clock-app/add-vibration-support/+merge/229327 and https://code.launchpad.net/~nik90/ubuntu-clock-app/add-multiselection-mode/+merge/230140 [18:54] balloons: they were tested by me and popey and device [18:55] nik90, that was simple :-0 done [18:56] balloons: :-) [19:04] \o/ [19:10]