[07:01] <dholbach> good morning
[13:19] <ginggs_> Hi all.  I subscribed ubuntu-sponsors to LP: #1311975 and LP: #1354704, but I'd really like someone to review these two debdiffs before I upload them, please.
[13:27] <rbasak> ginggs_: for bug 1354704, in general a backport of a newer upstream release is not acceptable, because they contain unrelated changes, carry more regression risk and are harder for the SRU team to review.
[13:27] <rbasak> From https://wiki.ubuntu.com/StableReleaseUpdates#Procedure: "...the patch in the bug report, a detailed and user-readable changelog, and no other unrelated changes."
[13:27] <rbasak> Your debdiff has many unrelated changes.
[13:27] <rbasak> I can't speak for the SRU team, but I think it's unlikely they'll accept your debdiff as-is.
[13:28] <rbasak> If you want to fix --mtu only (as this is the bug), then best to cherry-pick that particular fix from upstream VCS.
[13:33] <ginggs_> rbasak: thanks. yes, I understand that this is not usual, but there weren't many changes from 2.0.19 to 2.0.20, and no new features.
[13:48] <rbasak> ginggs_: well, you can upload and see what the SRU team say. At a minimum I'd at least explain that you understand it's not unusually and provide your justification, though.
[13:49] <ginggs_> rbasak: thanks, i'll explain in more detail.  if the upload is rejected, won't that prevent further uploads with a lower version number?
[13:51] <rbasak> ginggs_: no - the upload doesn't "count" until it's accepted (in this case by the SRU team).
[14:05] <ginggs_> rbasak: ok, that's good.  thanks again!
[14:19] <Zhenech> 1/wi3