=== chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk === _salem is now known as salem_ === salem_ is now known as _salem === chihchun_afk is now known as chihchun === _salem is now known as salem_ === salem_ is now known as _salem === _salem is now known as salem_ === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === chihchun is now known as chihchun_afk === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha [17:51] balloons: can you please take a look here to see if you like how I'm launching the app? [17:51] https://code.launchpad.net/~canonical-platform-qa/dialer-app/custom_proxy_objects/+merge/230687 [17:53] * balloons looks [17:55] mm.. you check for a local binary, otherwise just launch from installed. I like the simplification, but I'm concerned about what happens if you specify a different build directory than you local path. [17:55] om26er: I'm wondering if we should move the ofono helpers to the telephony project or something like that. [17:56] balloons: if you specify a different build directory and it has a binary, it will launch it. [17:56] if there is no binary, you will get a message saying that it doesn't exist. [17:56] ahh right, it's a relative path [17:56] so I'd have to also change the relative path to break it :-) [17:57] balloons: if you are running it with make, as the HACKING file suggests, it will take care of finding the binary. [17:57] elopio, not on top of my head, where are they living right now ? [17:57] om26er: there's one copy on dialer-app and one on messaging app. [17:57] maybe we should have only one. [17:57] elopio, I started doing something similar to this for the clock app reboot [17:58] elopio, yeah, definitely. dialer-app is fine I think. [17:58] balloons: lets merge the style to have a standard way to do it. Should I copy something from your clock branch? [17:59] om26er: I don't think dialer is right, because we don't want the messaging app to depend on the dialer app. [17:59] elopio, I pulled your branch to investigate better. Yes, I'm happy to select on a style [17:59] elopio, I also played with the cmakepluginparser as I said [17:59] om26er: IMO, we need something like telephony-service-testability [18:00] my concern with this approach is incorporating it into qtcreator [18:00] the trouble I had was I wasn't able to build nicely outside of qtcreator [18:00] balloons: we need to tell Benjamin to expose the test-autopilot task on qtcreator. [18:01] the test task will just run the qml tests. [18:01] elopio, ok, we need to write some tests for those helpers then [18:02] om26er: yes. I think they must be tested on their own and they should be moved. [18:02] om26er: do you have spare time next week to do it? [18:02] elopio, I think I will have time, yes. [18:03] om26er: awesome. I'll create a card on trello for you. Thanks! [18:03] elopio, yep, once we have our ducks in a row (more crazy expressions for you) let's have a chat with zbenjamin [18:04] sounds like we should be able to sort things today [18:04] balloons: jeje, I like that one. [18:05] balloons: ok, please leave your comments on the branch if you would like me to change something, and then we will use it as the template. [18:09] perfecto elopio === Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === salem_ is now known as _salem === _salem is now known as salem_ === salem_ is now known as _salem