=== _salem is now known as salem_ === salem_ is now known as _salem [03:56] nik90: hey, sure! my hours just are a bit like this :) === chihchun_afk is now known as chihchun [06:22] good morning [06:54] Good Morning :) [07:09] morning mardy - if I include an authentication plugin inside a click package, what will the user experience be for authentication? Will the account appear in system settings to choose from? [07:09] dpm: hi! Yes, it will [07:10] ah, cool [07:10] Goeie morgen === chriadam is now known as chriadam|away === dkessel_ is now known as dkessel [07:44] dpm: sorry, moving conversation here [07:44] dpm: more appropriate [07:44] np :) [07:45] nerochiaro, that looks good to me. What is is you're mentioned you did differently as originally suggested? [07:47] dpm: essentially the problem was that i was looking for .in.in.h in / instead of /po, so i fixed it as in here: http://bazaar.launchpad.net/~phablet-team/camera-app/camera-app-desktop-translation/revision/288 [07:47] dpm: the rest was all ok [07:48] popey: Your application SensorsStatus has completed the approval process. It is now available to the world from Ubuntu Software Center. \o/ [07:48] nerochiaro, ah, that's what I was mentioning that "RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}" on the line above should be "RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}/po" [07:48] dpm: right, different ways to fix the same problem i guess [07:49] dpm: i can use your solution if you want, but i think this is more clear (at least to me). more explicit === Guest75668 is now known as wgrant === wgrant is now known as Guest89446 [07:51] nerochiaro, the only reason I suggested that was because those paths are put in the .pot file and shown to translators, and by convention they are relative to the po/ folder [07:51] dpm: ok, i can change it that way then, if you prefer [07:52] nerochiaro, if that's ok with you, I would still suggest to make it relative to po/ to be consistent with all other core apps and for translators [07:52] nerochiaro, also, I'm not sure if the .pot file in the MP is up-to-date, but it does not contain the .desktop file translations yet [07:53] ybon: sweet! [07:53] dpm: ok, let's do those [07:53] cool, thanks [07:53] mihir: ping [07:53] ybon, just tried your app, really cool :) [07:53] thanks :) [07:54] Made that initially as a helper for me, then thought it could be a helper for everyone :) === Guest89446 is now known as wgrant [07:55] zsombi_: pong [07:55] mihir: you're with Calendar app, right? [07:55] btw, I wonder why when you put your phone on a table without moving it the accelerometer values are not equal to 0, and they keep changing [07:55] zsombi_: yes [07:55] mihir: I've some suggestion for you for the DatePicker [07:55] Maybe because Earth is moving? :p [07:56] mihir: like on how to use it [07:56] zsombi_: sure , suggestions are always welcome :) [07:56] mihir: we are implementing the focus grabbing on teh components and I saw something in the NewEvent.qml that causes some problems [07:57] mihir: I saw you were using TextField for the date and time fields [07:57] zsombi_: yup, we are using it for creating new event , and time [07:57] mihir: it's not the best idea, especially that you are not making those textfields read-only... [07:57] zsombi_: they are readonly , [07:57] mihir: I'd rather do some custom component instead of using that [07:58] zsombi_: it pop up Date & TIme picker at bottom of screen [07:58] mihir: I don't see any readonly setting of it... [07:59] mihir: startDateInput is set to RO where? [08:00] zsombi_: I see , we have used MouseArea, http://bazaar.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/trunk/view/head:/NewEvent.qml#L396 [08:00] mihir: but that's the smallest issue. The bigger one is the MouseArea that you place over it [08:01] zsombi_: hmmm , i see that now, zsombi_ we were using custom component previously developed by Kunal , but after we got this into SDK we start using this. [08:01] dpm: i don't get it. if i use relative to po then it will find the .in.in.h but it won't find the QML files anymore [08:01] dpm: i don't understand how it can find them in the core apps [08:01] mihir: but the thing is that teh component is too heavy for the purpos you need it [08:02] zsombi_: to match the design guidelines [08:02] mihir: beside, highlighted property will be soon deprecated, teh new design does not have that functionality anymore [08:02] zsombi_: oops, :| [08:02] nerochiaro, in the core apps, in here we add a line to look for in the build dir too -> http://bazaar.launchpad.net/~phablet-team/camera-app/camera-app-desktop-translation/view/head:/po/CMakeLists.txt#L15 [08:03] mihir: I do get it, but the problem is that you shoudl always challenge design, especially if the page loading seems slow, or the content seems crowded ;) [08:03] zsombi_: what would you recommended then , custom component would be too heavy task to match our design . [08:03] nerochiaro, i.e. [08:03] -D ${CMAKE_CURRENT_SOURCE_DIR} [08:03] -D ${CMAKE_CURRENT_BINARY_DIR} [08:03] mihir: perhaps revisit the design with teh designer [08:03] zsombi_: yup true. [08:04] nerochiaro, and in here: http://bazaar.launchpad.net/~phablet-team/camera-app/camera-app-desktop-translation/view/head:/po/CMakeLists.txt#L18 - you'll need to add --keyword=N_ too [08:04] zsombi_: there is no way we can utilize SDK datePicker or Datepicker panel ? [08:04] mihir: because this text field would be useful if the OSK would have the ability to open the DatePicker, or, more if the user would be able to enter the date manually [08:04] in this way it cannot [08:04] mihir: of course you can! [08:05] mihir: you can invoke PickerPanel.openDatePicker() from any omponent, AbsttactButton, Button, whatever [08:05] *component [08:06] dpm: are you sure you are linking to the right file ? i don't see -D ${CMAKE_CURRENT_BINARY_DIR} anywhere in the file you just linked [08:06] nerochiaro, that's the camera file, it needs to be added there [08:07] zsombi_: hmmm i see.. we have calendar meeting today with popey will have discussion of this [08:07] mihir: if you need same design, you can do that with a custom component derived from UbuntuShape + SharedSource to be able to render the content [08:07] mihir: please do [08:07] zsombi_: if we can make it work using readonlying textbox ? [08:07] mihir: also remember that lots of UbuntuShapes on a UI cause performance decrease [08:07] popey: ^^^ [08:08] mihir: no, you cannot :/ [08:08] dpm: why keyword "N_" ? where is it used ? I thought the desktop file used just "_" [08:08] mihir: the problem is that even if you make a textfield RO, it won't open the PickerPanel [08:08] nerochiaro, look at the generated .desktop.in.in.h file, it uses N_ [08:08] t1mp: Hey Good Morning, I am in the process of writing some unit tests for the clock app and I am wondering how to press the clear button in a textfield. At the moment I press on the right edge corner of the textfield. [08:08] zsombi_: hmmm , what about putting clickable label with some shadow and highlights ? [08:09] zsombi_: if user clicks , it opens same way and update label values , just a random thought [08:10] mihir: that's fine as well [08:10] zsombi_: thanks for this ,i'll bring up in today's meeting and will file bug for this too. [08:10] mihir: you can use a Stroke button for instance [08:11] nerochiaro, in summary, you'll need this: http://pastebin.ubuntu.com/8043322/ (in core apps we use CMAKE_CURRENT_* for the build and source dirs, not sure if it makes a difference) [08:11] mihir: that will kinda look nice and you will be able to set its label based on the DatePicker's response [08:11] dpm: check if it works for you now, just pushed a new commmit [08:11] mihir: thx dude :) [08:12] zsombi_: yeah, we can try stroke button. [08:12] mihir: it even looks better than a text field ;) [08:13] nerochiaro, looks good to me, thanks! [08:14] t1mp: I have some changes in the header on the focus handling, please check it https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/focus-handling-on-touch/+merge/230296 [08:20] zsombi_: for using button stroke , we just have to provide property for that ? i couldn't find in docs http://developer.ubuntu.com/api/qml/current/Ubuntu.Components.Button/ [08:21] mihir: wrong URL :) [08:23] mihir: http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.Button/ [08:23] mihir: there supposed to be a property called "strokeColor", but for some reason the doc doesn't have it... [08:24] mihir: perhaps the doc on the web is outdated a bit [08:24] mihir: do you use QtCreator? [08:25] zsombi_: yes i do i'll try that :) [08:26] mihir: then you should have context help, so if you open the help whil on Button, you will see the doc there [08:36] dpm: can you please work with oSoMoN to get that MR landed and approved ? [08:36] dpm: also, anything else I can help with in terms of desktop file translations ? [08:36] dpm, nerochiaro: which MR? [08:37] nerochiaro, yes, the dialer-app and messaging-app don't seem to load translations. I mentioned the details and findings on my e-mail [08:38] dpm: ok, i'll look into these later today [08:40] cool, thanks [08:41] oSoMoN, https://code.launchpad.net/~phablet-team/camera-app/camera-app-desktop-translation/+merge/223229 - nerochiaro, I think I'll have to leave it to you guys, I'm not sure I'm the best person to coordinate landings in system apps [08:42] dpm: can you please top approve the MR if you haven't done it already ? [08:42] nerochiaro, I can't, I'm not otherwise involved in system apps development and I'm not a member of the phablet-team [08:43] so no permissions to top-approve [08:43] nerochiaro, I’ll take a look in a moment [08:59] mardy, I'm setting up reminders to ship the authentication plugin in the .click. Does the hook for the account in the manifest need to have a specific name, or match any provider id, etc? I just named it "evernote-account-plugin" -> http://pastebin.ubuntu.com/8043589/ [09:29] mzanetti: hey, have you had the issue where a QTest passed when you run that specific testcase but fails when you run ctest -v ? I think I may have timing issues since adding a wait(2000) seems to do the trick. [09:30] mzanetti: I thought about using signalSpy but then it is a group of listitems that are clicked. So I don't know what the signal spy should target [09:30] nik90: use "tryCompare()" [09:30] nik90: that's the equivalent of AssertThat(Eventually()) [09:31] nik90: or well, let me see the code [09:31] mzanetti: but it is already outside the loop that presses on the listitem. [09:31] nik90: yeah... not sure exactly what the issue is atm. would need to see code [09:31] mzanetti: https://bazaar.launchpad.net/~nik90/ubuntu-clock-app/add-first-qmltest/revision/60 [09:32] mzanetti: line 80 // #FIXME: Without this wait, it fails when running ctest -V [09:34] I see [09:34] nik90: remove the wait(2000) [09:34] nik90: and add this as the first line of this test: [09:34] waitForRendering(alarmRepeatPage); [09:35] nik90: that once waits until the alarm page has finished rendering and then starts the test [09:35] passes fine here [09:35] mzanetti: ok that passes [09:35] nik90: in gernal waitForRendering(item) should be a good friend of yours when writing qmltests :) [09:35] mzanetti: do I add the waitRendering before each testcase? [09:35] dpm: it can have any name, because it will be renamed by the hook program [09:35] nik90: well, if its not needed, I wouldn't add it [09:36] nik90: but if you have some timing issues, waitForRendering should be the first thing you try [09:36] mzanetti: ok, this is kinda cool. I think I am getting comfortable with this :) [09:39] thanks mardy [09:39] nik90: i have updated my merge proposal for admin2, filed an RT, need to find someone to approve the merge. [09:39] popey: this is the same MP as the timezone one? [09:40] nik90: *\o/* [09:44] mardy, with this in the manifest, I'm getting an error (I believe it comes from the click review tools) "The apparmor path is missing in the manifest file"-> http://pastebin.ubuntu.com/8043589/ [09:45] mardy, does the account plugin hook need an apparmor entry? [09:47] dpm: I don't know, but it looks like it does :-) [09:47] dpm: just ask for network and accounts [09:47] nik90: yes [09:47] nik90: updated it. [09:48] nik90: thanks for cleaning up my typos :D [09:49] mzanetti: lol [09:49] how did you find that bug report anyways? [09:49] its in the main sdk page as the first bug report [09:50] mzanetti: is this the UI toolkit on the latest phone image as well that you are having issues with? or staging? [09:51] nik90: image. I don't use staging here [09:51] nik90: http://i.imgur.com/GDQUlxF.png :) [09:52] ybon: you might want to switch your sensors app to the new header.. [09:52] * nik90 tests [09:53] popey: damn, I though it was automatic [09:53] OH [09:53] I know [09:53] I need to switch useDeprecatedAction to false or something like that right? [09:53] ybon: affirmative [09:53] :) [09:54] * ybon prepares a 0.0.2 with that change [09:54] mzanetti: https://imgur.com/rKN4JE7 [09:54] mzanetti: why do you have the overflow button [09:55] nik90: because I wanted that. But because of the ugly popover I decided to publish it as is for now [09:55] nik90: I think the way it is atm is not really good for 2 reasons: [09:55] a) you don't need the add account buttons often enough to have them visible all the time [09:55] b) if they're in the popover you get the text explaining what the camera icon actually does [09:55] so I'd prefer it to have like in my screenshot [09:56] but obviously not as the popover is atm [09:56] hmm I am trying to test against other apps which have a overflow [09:56] nik90: well, the old clock app looks the same [09:56] http://i.imgur.com/lz4oQHC.png [09:57] mzanetti: that's because its background is purple [09:57] nik90: ^ [09:57] nik90: no [09:57] nik90: that's because the background is "dark" [09:57] mzanetti: check out the music app, its overflow is black [10:00] mzanetti: even in my app Flashback https://github.com/krnekhelesh/flashback/blob/master/Flashback.qml, I set the background color to UbuntuColors.coolGrey and the tab overflow menu looks black. [10:00] nik90: indeed... still broken though... text color should be white [10:00] mzanetti: yeah there is a bug for that [10:00] nik90: so why is the authenticator's one purple? [10:01] mzanetti: I am not sure, I suspect it could be because of the gradient [10:01] nik90: also the clock app's background purple and the overflow purple do not match [10:01] Good Morning all o/ [10:01] mzanetti: try removing that and setting only the background color [10:01] mzanetti: https://code.launchpad.net/~fboucault/ubuntu-ui-toolkit/better_visual_feedback/+merge/230121 [10:07] nik90: you're right [10:08] nik90: it only turns purple when there's a gradient [10:08] nik90: which explains why its the same purple in clock app and authenticator [10:08] mzanetti: lol [10:08] Saviq: fyi: ^ [10:08] mzanetti: I heard the SDK devs are deprecating gradient backgrounds [10:08] mzanetti: afaik all core apps were asked to move towards solid backgrounds instead [10:08] popey: you whould now have an ugrade :) [10:09] what about the name, btw? "Sensors Status" is what I was able to put out from my globish, but it's not that good [10:10] mzanetti, right, so it's a $random_color when gradient is used [10:10] Saviq: rather $purple, but yeah [10:11] Saviq: removing the gradient and only setting background color makes the popover black [10:11] blackish [10:11] with grey text I assume ;) [10:11] ofc [10:11] http://i.imgur.com/xGWiv98.png [10:12] mzanetti: both of these are fixed in the MP that I linked above [10:12] nik90: both? [10:12] what's the other issue? [10:12] an the gradient one [10:12] ? [10:12] mzanetti: the black box in your overflow [10:12] ybon: name is fine to me [10:13] nik90: oh really? I just wanted to report a bug [10:13] mardy, would you mind reviewing the branch for the migration of the Evernote account plugin into the click package? It's not a big change, but it'd be good check if the layout and the rest is as expected for the account to work inside the click -> https://code.launchpad.net/~dpm/reminders-app/account-click/+merge/230768 [10:13] nik90: that seems to be that iconSource is ignored in Action [10:13] mzanetti: yup, even reminders app had that issue [10:13] oh did it :D [10:13] popey: okey :) [10:13] * mzanetti starts losing track of all his apps [10:26] maybe the myapps bit for developers should have a thing to let you view by category/department [10:27] popey, have you come across any message similar to "Unable to exec 'reminders' in '/opt/click.ubuntu.com/.click/users/phablet/com.ubuntu.reminders': No such file or directory" when launching an app from the dash, after having installed the click package manually with pkcon? [10:27] The installation path seems wrong [10:29] dpm, hey :-) I was able to add bottomEdge to remiders app, only on phone mode, and it's awesome! I implemented the solution I think is 'cleaner' as possible, but I had to modify the BottomEdge component, and create a 'fake' bottomEdge. I'll explain all in today meeting, cause I want to hear mzanetti's opinion as well. [10:29] dpm, meanwhile, if you want to try it: https://code.launchpad.net/~rpadovani/reminders-app/bottomEdge [10:29] rpadovani, oh wow! nice work! [10:30] dpm: now I start to work on edit notebooks name [10:32] rpadovani: nice! [10:33] rpadovani: I also found a bug with the pulldown thingie [10:33] rpadovani: pull it down to make the text change to "release to refresh" [10:33] rpadovani: then drag it back up to the beginning and release [10:33] it still refreshes [10:33] should only if you release it below the threshold [10:33] dpm: nope [10:34] mzanetti, interesting, I'll take a look [10:35] mzanetti, rpadovani, also -> https://code.launchpad.net/~dpm/reminders-app/account-click/+merge/230768 [10:36] dpm: oh wow! didn't know that's possible now [10:36] great news [10:37] dpm: For some reason I don't understand, the binary fails to start with this error, where the layout is clearly wrong: "Unable to exec 'reminders' in '/opt/click.ubuntu.com/.click/users/phablet/com.ubuntu.reminders': No such file or directory" [10:37] mzanetti, indeed. However, with a caveat: the 'accounts' policy is still only limited to trusted apps, if I'm not mistaken, so it's not yet available for general use. I think there need to be some security improvements added before all app devs can use it, but mardy can probably expand on that [10:38] dpm: I guess that's because the reminders binary is in lib/armhf../bin/reminders [10:38] instead of the top level dir [10:38] mzanetti, yeah, but that's always been the case [10:38] dpm: you can either change the install dir of the binary, or update the .desktop file to launch it from where it is now [10:38] really? [10:39] mzanetti, yeah, I've just checked that on the Reminders click that comes preinstalled with the images. I'm a bit puzzled as well that the desktop file finds the binary at all [10:39] nik90: admin2 merged by ev! :D [10:39] popey: wow [10:40] popey: dpm: guys, who's with teh Settings app? [10:40] mzanetti, http://pastebin.ubuntu.com/8044258/ [10:40] zsombi_, I generally ping seb128 or Laney when I've got questions about u-s-s [10:41] dpm: /usr/armhf/bin vs /usr/x86/bin/ [10:41] seb128: pingus [10:42] Laney: ping U2 [10:42] mzanetti, where? [10:42] dpm: http://pastebin.ubuntu.com/8044162/ vs http://pastebin.ubuntu.com/8044258/ [10:43] dpm: stupid me... I meant /lib/... [10:43] not /usr [10:43] mzanetti, ah, got it, thanks. No idea how that got replaced by the wrong arch, well spotted, will fix! === MacSlow is now known as MacSlow|lunch [11:07] dpm, mzanetti: the accounts policy is limited as of now, but it won't be limited in the RTM [11:07] I see. thanks mardy [11:08] mzanetti, https://code.launchpad.net/~rpadovani/reminders-app/fixForReload/+merge/230775 [11:09] ok, thanks mardy. Do you have any ideas about why we're getting this errors when trying to migrate to the account in the click package? -> http://pastebin.ubuntu.com/8044372/ [11:09] *these [11:11] dpm: yes, the click hook should run that query for you; it's in my to-do list [11:12] mardy, oh, so this is not supposed to work yet? [11:12] dpm: meanwhile, I think that you can workaround it locally by running "account-console list" [11:12] dpm: try to close and re-open online accounts, that might fix it [11:14] mardy, it doesn't seem to: http://pastebin.ubuntu.com/8044459/ [11:14] i.e. it doesn't list the evernote account and when I open the app, it takes me to an empty Accounts page [11:17] oSoMoN: Elleo: can you guys please have a look at this merge request when you have time ? https://code.launchpad.net/~phablet-team/gallery-app/gallery-app-restrict-pick-content-type/+merge/230776 it is missing tests, but if you could start verifying that the code is good and the functionality works that would help speed things up considerably [11:18] dpm: it's weird that evernote is not there [11:18] nerochiaro: sure [11:19] dpm: what's in ~/.local/share/accounts/providers/ ? [11:20] mardy, $ ls .local/share/accounts/providers/ [11:20] com.ubuntu.reminders_evernote-account-plugin.provider [11:20] nerochiaro, I’ll put it on my list for today [11:21] oSoMoN: Elleo: and one unrelated question. do you guys usually build inside the same tree as your branch or in a separate directory ? [11:21] nerochiaro, that depends on the project, some support both, some support only out-of-source builds [11:22] nerochiaro: I typically do out-of-tree builds for anything that supports it [11:22] dpm: silly me, of course evernote is not listed by account-console until you create an account [11:23] zbenjamin_: zsombi_: hi folks, I need someone from the sdk team to help me understand just a couple things. first, I wanted to ask if qtc can 'Run' the app from a folder different than build-telegram-app-Desktop-Default/.ubuntu-sdk-deploy, as well as which step/component is actually responsible for creating that directory (which seems to be missing in my casE) [11:23] mardy, so we're in a chicken and egg situation? [11:24] Elleo: oSoMoN: ok, and in case of out of tree builds how do you normally run tests ? [11:24] dpm: no no, the problem is that an unconfined process needs to make a certain libaccounts call, in order to update the service list [11:24] kalikiana: hey buddy o/ any news on that ~/.config/qt-project s/qt-project/actual.app.domain fix? [11:24] (just trying to realign my workflow to current best practices) [11:24] dpm: online-accounts-ui does that, but I cannot remember in which scenario -- I'm checking the source [11:25] nerochiaro, what tests? unit or autopilot? [11:25] oSoMoN: both [11:25] karni: that directoy is created by the UbuntuSDK Click build step in the deploy configuration. Which is only present on a non desktop target [11:25] nerochiaro, usually for unit tests, just run ctest or "make test" from the build dir [11:25] karni: the app is not running from there, what happens is a real click package is created and isntalled on the phone, then we execute the installed app and remove it when its closed [11:26] karni: there is no other way to run the app on a device [11:26] nerochiaro, for AP tests, running them out of source might not always work, that depends on how clever the setUp() function is, for webbrowser-app for example it works only either in source, or installed system-wide [11:26] zbenjamin_: I see. I'm trying to run this on the desktop, and I get: QProcessPrivate::execChild() failed to chdir to /home/karni/src/canonical/telegram/build-telegram-app-Desktop-Default/.ubuntu-sdk-deploy [11:26] zbenjamin_: is it possible to make it clear to qtc that I'm really trying to run on a desktop and not a device (thus, no need for .ubuntu-sdk-deply directory? ) [11:27] karni: weird [11:27] oSoMoN: and to run these tests on the device what's the current recommended method ? [11:27] AP [11:27] dpm: try creating the evernote account from the system settings [11:27] karni: can i test that myself ? [11:27] zbenjamin_: this might be due to modified CMakeLists.txt ? or qtc solely bases it's "setup" on project configuration? or are these two bound? [11:28] karni: basically the configuration is based on the Kit type you use. If its a Ubuntu Kit the deploy will happen [11:28] nerochiaro, if it’s a click app look up an e-mail in your inbox sent by bfiller on May 28 titled "running autopilot tests for click" [11:28] nerochiaro, for a pure debian package, just install the corresponding -autopilot debs, and use phablet-test-run [11:28] oSoMoN: cheers [11:30] mardy, I think I tried it earlier and it did not work, but I cannot confirm, as now the online accounts app won't load at all from ubuntu-system-settings :/ [11:31] karni: failing on false negatives in ci I'm afraid (https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizationDomain/+merge/230085) [11:34] oSoMoN: what's the process for getting this into trunk ? https://code.launchpad.net/~phablet-team/gallery-app/gallery-app-remove-qmlproject/+merge/230665 (or to check that it's in the pipeline to get into trunk at some point) [11:38] hey mzanetti, there is a simpe way to use void setName(const QString &name); (notebook.h) from QML? [11:39] * mzanetti looks [11:39] mardy, so from the system settings I get evernote as an available account, but when I try to create it, it also lands me on a blank page [11:40] popey: do you happen to know when the geoname-lookup server gets updated? [11:40] nik90: i filed an RT today, and now the merge landed, I can push it, which I will with IS [11:40] no ETA yet [11:41] ack [11:42] mzanetti: hey, can you approve https://code.launchpad.net/~nik90/ubuntu-clock-app/json-search-backend/+merge/230338. You already did a code review of it. [11:42] mzanetti: I will tackle the issue of the QNetworkAcessManager in another MP. [11:43] nik90: yeah... as I said.... I wouldn't do much for the QNAM at the moment [11:43] nik90: it's probably not worth spending the efforts as it doesn't make a difference on the Ubuntu platform for now [11:43] nik90: and I'm not sure it ever will [11:43] mzanetti: yes but I will need your help to tackle that in the near future since I will need to do another json request in another plugin for the user location [11:44] mzanetti: which will end up with two QNAM in the same app. [11:44] nik90: yeah... just create a new QNAM in that plugin too for now [11:44] mzanetti: ok [11:44] nik90: again, it doesn't matter on Ubuntu (would matter on MeeGo or Sailfish though) [11:44] got it [11:45] nerochiaro, as usual, a landing request needs to be filed with this MR. Given the nature of this MR, it would be worth grouping it with other non-conflicting small MRs [11:45] nik90: approved [11:45] oSoMoN: ok, i've never filed one so far, that's why I am asking about the process [11:46] mzanetti: thnx [12:02] dpm: fyi, the accounts policy group should be a 'common' policy group very soon. dbarth and mardy have been working to make that happen and I think code for it may hit a silo soon === MacSlow|lunch is now known as MacSlow === chihchun is now known as chihchun_afk === _salem is now known as salem_ [12:34] renatu: artmello: oSoMoN: Elleo: do we know of any app that is already doing AP integration tests with the content hub ? I would like to add some to the gallery but if I can start with some examples that would make things a lot quicker [12:34] nerochiaro, I do not know, I am sure that address-book does not have that yet [12:35] nerochiaro: have a chat with ken when he gets on, he's just created a test peer that can be used for autopilot tests [12:35] nerochiaro: as at the moment autopilot doesn't handle cases where you need to switch between apps very well, so the test peer can be configured to just instantly return various types of content or to accept content without any user interaction [12:36] Elleo: do you have an example of that ? [12:36] dpm: I reviewed your MP and left some comments. It is all good just for some few corrections that need to be made. [12:37] Elleo: what i'd like to do is to have content hub request gallery some stuff, and verify that gallery displays the right UI and filters the data properly [12:37] nerochiaro: not yet; it only got merged this week, so there's nothing using it yet; kenvandine should be able to tell you how it works though [12:37] nik90, yeah, I saw it thanks, I've been looking at reminders today, and I've not yet had the chance to address those, but I will [12:37] dpm: np [12:37] Elleo: ok, I'll ask ken when he comes in later [12:37] Elleo: thanks [12:37] nerochiaro: also, rhuddie is planning on using the new test peer to write some AP tests for various apps, so you might want to co-ordinate with him as it might already be something he's working on [12:44] dpm, can you land https://code.launchpad.net/~dholbach/ubuntu-sdk-tutorials/updates/+merge/230791 maybe? [12:45] or mhall119 [12:45] looks like I don't have the necessary powers [12:45] and maybe add me to https://launchpad.net/~ubuntu-sdk-tutorials-dev as well :) [13:05] balloons: I have rebuilt the clicks for _all_ the core apps, could you please upload en-masse? [13:06] popey, sounds like fun :-) [13:07] dholbach: want me to top-approve that MP? [13:09] balloons: Good Morning :) [13:09] mihir, morning [13:09] dholbach, I've added you to the team [13:09] balloons: because of new change in Yearview we have break in AP , so we [13:09] have to fix that. [13:10] mhall119, yeah, that'd be nice [13:10] I finished the tweaks I wanted to https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1188819/+merge/230554 [13:10] h no, dpm did [13:11] dholbach: yeah, I just saw that [13:11] thanks guys! [13:12] balloons: yes i saw that balloons i am yet to understand that and then i'll fix in office right now will do that by tonight, my long weekend starts from today :D [13:12] I just went through the ubuntu-developerportal bugs and that was one of them === chihchun_afk is now known as chihchun [13:14] zsombi_: ping [13:14] mihir: pong [13:14] zsombi_: could you join #ubuntu-touch-meeting for a while ? [13:15] balloons, when you've got a minute, would you mind looking at https://code.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/require-screenlock-password/+merge/230058 again? It seems there are some Jenkins failures and the jobs need to be retriggered [13:16] hmm.. I don't see my push from yesterday.. interesting [13:17] balloons, perhaps you pushed to another branch? [13:17] who knows [13:24] popey, I think everything should have a new version uploaded now [13:30] thanks balloons [13:30] mzanetti, joining the reminders hangout? === gatox is now known as gatox_lunch === charles_ is now known as charles === chihchun is now known as chihchun_afk [14:32] bzoltan: I think you might like this -> https://www.youtube.com/watch?v=PBpCykbmqs8&feature=youtu.be [14:54] balloons, so the tests passed for file manager \o/ - are you happy with them, and comfortable with landing it as it is? [15:02] balloons: can you join the clock app meeting in another hour and a half? I would like to discuss together what it would take to make the replacement. [15:03] and then we can take some workitems and get them done [15:04] nik90, sure can do [15:04] hangout? [15:04] balloons: not sure yet, normally I ask popey at the start of the meeting. Either way I will keep you informed [15:05] dpm, I'm wanting to potentially change some things, but I would not hold the mp for it, as I know it's important. [15:05] dpm, and I'd much prefer doing an mp with the changes against trunk, instead of making this one longer === gatox_lunch is now known as gatox [16:11] daker: you might want to update your airbnb app with their new logo [16:11] daker: just installed it on my #189 mako and it refuses to start here.. just get the loading screen [16:12] popey: ok [16:17] nik90: beautiful background you have :) [16:17] bzoltan: :) [16:19] nik90: I am at 2 minutes, but I love that video already! You rock! [16:19] bzoltan: I wanted to do it earlier but was waiting for the UI workflow to stabilize. Also some devs kept asking how to run their apps after the recent update. [16:36] popey: https://myapps.developer.ubuntu.com/dev/click-apps/246/feedback/ [16:40] dpm, i18n.tr doesn't work with single quote? I mean, i18n.tr('Translate this') doesn't work? [16:40] daker: looks like dholbach beat me to it ☻ [16:40] rpadovani, i ran into that one [16:40] rpadovani, I've no idea, I would have thought it should. What's not working? [16:40] popey, sorry [16:40] ☻ [16:40] :) [16:41] dpm, I'm looking at this MR... it's odd [16:41] https://code.launchpad.net/~vrruiz/reminders-app/i18n-strings/+merge/230838 [16:41] I mean, makes sense, but why? [16:41] popey: let's if it works, i know it will show the android ads [16:43] rpadovani, ah, it might be that the string is not extracted by xgettext because it interprets the .qml file as a .c or .cpp file and expects strings to be " [16:43] xgettext has no direct support for qml [16:43] dpm, thanks for the explanation! [16:46] np :) [16:59] popey: the "Travel" section on the store still shows the old one [17:05] Does the apparmor_parser process take *forever* for anyone else when 'Allowing autopilot to play well with apparmor' or on a first boot after upgrading an image? or is it just my device? [17:05] ahayzen, a minute yes [17:06] ...or two or three... [17:06] ahayzen, that sounds a bit long [17:06] but :-) it has to recompile everything [17:06] oh god :/ guess it is proportional to num of apps installed as well then? [17:07] ahayzen, lolololololol.. [17:07] did you go crazy with apps? [17:07] done! [17:07] god probably took like 4-5 mins [17:07] balloons, no not many probably +10 to standard [17:08] balloons, also do u have time today to help me with the music-app ap refactor? ... [17:08] daker: cached maybe? [17:09] balloons, i would really appreciate it if u could help me do the first 1/2 test transitions to make sure i set it up correctly etc...then i can do the rest [17:09] ahayzen, I will in a bit.. trying to finish something up [17:09] ahayzen: takes 20 mins on my nexus 7 [17:09] popey, jesus! [17:09] ahayzen: but I have 380 clicks installed [17:09] indeed! [17:09] popey, are there any plans to improve this? [17:09] ahayzen, I can certainly answer questions as you go.. feel free to ping [17:09] ahayzen, they did some work to improve the speed, lol [17:09] balloons, thanks i'll probably start after dinner so in like 1-2hrs [17:09] but honestly, it's a dev thing, so [17:09] balloons, but it runs after u upgrade? [17:09] ahayzen: it's known ☻ [17:10] balloons, and it sits at 'Google' for *ages* i have been thinking the upgrades have been failing recently because of it [17:10] if the shell in at that time u can see like ~4 of them all using 100% cpu [17:11] popey, is there a bug to track? [17:12] davmor2: so to fill you in, we will be doing the replacement once we have the next promoted image since the clock reboot needs the latest SDK which is not available in the previous promotoed image (179) [17:12] ahayzen: the understated bug 1350598 [17:12] davmor2: so definitely by monday [17:12] bug 1350598 in apparmor (Ubuntu) "apparmor_parser takes a long time" [Undecided,Confirmed] https://launchpad.net/bugs/1350598 [17:12] popey, that title is perfect :) [17:13] ah 'This will not normally affect consumers because neither the kernel nor the policy will change during the system image update process.' [17:13] ^^ as I said, 'dev' thing :-) [17:13] nik90: hahahaha you think they'll be a promoted image Monday ah bless ;) [17:14] davmor2, . . . [17:14] yeah but i guess if someone moved their phone from 14.10 -> 15.04 then they would experience it [17:14] but only once so not to bad :) [17:14] davmor2: you are not instilling much confidence in me :P [17:14] nik90: blame popey he keeps finding bugs [17:14] * ahayzen wants the new media-hub in a promoted image [17:16] davmor2: well me and popey are in the same page, so he will understand what needs to be done :D [17:19] yeah, don't listen to him ☻ [17:21] popey: i think yes [17:22] :P [17:25] popey: in image 189 can you see if the indicator datetime shows you any thing? For me it blank..no alarms, no calendar events..really strange [17:25] nik90: see now you're finding bugs how do we stand a chance [17:26] davmor2: well this bug is so alarming that I cannot ignore it :P [17:26] davmor2: how does it look for you? [17:26] nik90: well quite obviously it isn't alarming and that's the problem :P [17:26] davmor2: lol. [17:27] nik90: howdy sir [17:27] I think for me the datetime service crashes because the time it shows is also incorrect [17:27] nik90: I see the alram notification, but I see nothing in the indicator [17:27] zsombi: hello :) [17:27] davmor2: yup me too [17:27] davmor2: time will go out of sync as well [17:27] nik90: will you have time tomorrow to check the alarm-switch thing? [17:27] zsombi: I did and I got stuck :D [17:28] zsombi: tell me you will swoop in and save the day again [17:28] nik90: I know, I saw your post, just had no time to check it [17:28] nik90: ;) [17:28] I blame that nik90 for this demanding changes for the alarms ;) [17:28] nik90: do you have some sample? [17:28] zsombi: yeah 1 sec [17:28] nik90: I know you had, just lost the pastebin [17:28] zsombi: http://paste.ubuntu.com/8027116/ [17:31] nik90: was this pastebing a delegate of a listview? [17:31] zsombi: yup [17:31] nik90: do you eventually have a broader code pastebin? [17:31] zsombi: I had a local branch I was working on. I could push that for you [17:32] nik90: pls, txh [17:32] thx [17:35] zsombi: lp:~nik90/ubuntu-clock-app/implement-alarm-status [17:35] nik90: thx! I'll try to see whether we can get somewhere with this [17:35] zsombi: https://bazaar.launchpad.net/~nik90/ubuntu-clock-app/implement-alarm-status/view/head:/app/alarm/AlarmDelegate.qml [17:36] nik90: have you tested with memory manager as well? [17:36] zsombi: I will be online tomorrow early. Ping me and I will join you with it. [17:36] zsombi: no I haven't tested with memory manager.,.only EDS [17:36] nik90: ok, let's see [17:36] nik90: I think I did back few months ago, and it had the same issue [17:37] zsombi: the code I wrote was taken from the sdk sample code. [17:37] nik90: even worst, as that is much faster, so it took the switch back almost instantly [17:37] nik90: I know... sorry for that :/ it doesn't work properly, and it's because of th eswitch [17:38] nik90: we had a branch with teh CheckBox - having teh same issue, I have to check that, perhaps we can do some API change to come over this issue [17:38] zsombi: no worries, I have a potential other issue related to this, so hopefully fixing this will help with that [17:38] nik90: ok, let's hope [17:39] zsombi: how do you read an alarm, update it and wait for the alarm operation to be completed before doing anything. [17:39] zsombi: because when creating an alarm I create the Alarm{} object. Where i monitor the status signal. [17:39] zsombi: but while reading alarms I do, var tempAlarm = alarmModel.get(index) [17:39] zsombi: hence that confuses things for me [17:40] nik90: yeah, agree, it's a but confusing, perhaps the model should only return roles, not objects... [17:40] yeah I think so [17:40] nik90: the Alarm{} is a helper to create alarms, you can use it to create several alarms if you clear the alarm once got saved [17:41] nik90: then alarmModel.get(index) returns an alarm from teh model's given index. The index has no relation with the Alarm itself, so that's why is confusing [17:42] nik90: there's a ccokie in teh Alarm internal which could be used as ID, however that is platform (adaptation) specific [17:42] yeah [17:43] nik90: and that cookie is really bad one.. [17:43] zsombi: I am hoping something can be done within the clock app side of things since the SDK takes too long to update, but let's see what happens [17:44] nik90: there is some gles hassle in the CI than needs to be sorted so we can land... [17:44] zsombi: yes I was tracking the sdk update for the past 2-3 days since I desperately needed those 2 critical bug fixes for alarms. [17:45] nik90: like the two bugs around the alarm sound and the clear() crash are fixed, landed in staging, but the silo is dying all the time [17:45] yup [17:46] zsombi: hey atleast I can now make install any SDK branch without blockage due to EDS :) [17:46] nik90: ;) === nerochiaro is now known as nerochiaro_dinne [17:59] nik90: yes, i have stuff in mine [18:00] popey: does the time in the panel update for you? [18:00] popey: and are you runnign 189? [18:00] popey: clean wipe or just update? [18:00] sry too many questions :D [18:00] nik90: i lie, wrong phone, no i see no notifications in upcoming [18:01] nik90: and no, time is 17:08 (it's 19:00) [18:01] so indicator-datetime needs a bug i think? [18:01] popey: yup...I am discussing with charles atm. [18:01] so i see, lemme know if you need anything from me [18:02] well I wanted to ask you to test my custom-alarm-sound branch tonite. but we can't do it anymore [18:02] since I doubt alarms will ring [18:58] nik90: this is a really great video [19:00] nik90: can we embed it on developer.u.c? [19:10] mhall119: do you want me to edit it a bit? like adding titles and so on? [19:12] nik90: that would be great if you have time, but I'm happy to add it as-is, it's a huge help [19:13] what video is this? [19:13] popey: https://www.youtube.com/watch?v=PBpCykbmqs8&feature=youtu.be [19:14] popey: it's brilliant [19:16] ooh [19:17] popey: nik90: http://developer.ubuntu.com/start/ubuntu-sdk/using-device-kits/ [19:18] mhall119: awesome thnx [19:19] no man, thank you, this is great stuff [19:21] :) [19:30] popey: hey I pushed to test click for https://code.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/+merge/225812 in dropbox [19:30] popey: can you test on 189, it works for me. What you need to test is check when editing an alarm if you see the ringtone you chose. [19:31] popey: and ofc that the alarm rings with the ringtone you chose [19:39] balloons: i have merged the branch , thanks for your help [19:39] mihir, ohh excellent. you arre welcome [19:41] balloons: here is MR link , https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1188819/+merge/230554 [19:43] balloons: btw the MR with the qml tests is at https://code.launchpad.net/~nik90/ubuntu-clock-app/add-first-qmltest/+merge/230702. [19:44] balloons: I will update the readme files with the necessary info to run the qml test as elopio suggested. [19:45] nik90: sure [19:46] popey: btw don't look at the datetime indicator time before setting the alarm :) [19:46] uh, okay [19:46] nik90, awesome [19:50] nik90: do we need any PPA for UbuntuComponents on utopic ? [19:51] nik90: it doesn't play the sound when I choose one, I mean, when selecting the alarm sound to be used - i would expect it to [19:51] mihir: no [19:51] otherwise I dont know what noise will come out when the alarm goes off [19:51] popey: +1. I have a bug about that. Unfortunately I need design spec for that. [19:51] nik90: i am just trying to run Gallery app , and getting this in console , file:///home/mihir/Documents/apps/gallery/ubuntu-ui-toolkit/examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml:18 module "Ubuntu.Components" plugin "UbuntuComponents" not found [19:51] popey: for instance where to show the stop button and so on [19:52] mihir: how did you run it? Through Qtcreator? [19:52] nik90: yup [19:52] i wouldn't show a stop button [19:52] other phones dont [19:52] popey: our system settings app does [19:52] just press the button, noise comes out until you choose a different one [19:55] that can be implemented [20:00] nik90: tested... [20:00] not sure it used the tone I chose [20:00] but it wasnt those dammed harps [20:00] ah ok. Yeah I had to use the sytem settings app to hear the ringtone and then chose it in the clock app :) [20:01] But yes we have to add previewing system sounds in the clock app [20:02] nik90: by saying gallery, I meant ubuntu-ui-toolkit application [20:03] mihir: yeah I know..I can't understand why since it works for me on my utopic vm. I choose gallery from the Tools->Ubuntu->ShowCase Gallery [20:04] mihir: on my utopic vm I have no PPAs installed [20:19] nik90: it did work now , thanks for help [20:19] balloons: ping [20:20] balloons: i still see some errors in AP , is it because of some assert issues , http://91.189.93.70:8080/job/generic-mediumtests-utopic/1531/testReport/junit/calendar_app.tests.test_new_event/NewEventTestCase/test_delete_event_must_remove_it_from_day_view_with_mouse_/ ? [20:20] mihir: ah, awesome [20:20] i did run test cases on my machine and it did passed flawlessley [20:21] nik90: yes, set a few alarms with different sounds and they work [20:21] popey: do you want me to add support for previewing sounds in this MP or a new one? [20:21] separately [20:22] ok [20:22] on it [20:23] balloons: mind doing a code review of https://code.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/+merge/225812 when you are free. popey has tested green on image 189. [20:25] nik90, do you underscore in qml for a specific reason? aka _soundModel [20:26] balloons: nope, I just use it similar to in python indicating it is a internal variable [20:27] balloons: I am going to add a bit of comments to the code in a bit === salem_ is now known as _salem [20:37] balloons: it seems a same problem , it is not able to find the event after deleation [20:40] nik90, kk [20:41] * balloons watches video [20:42] I think you are seeing an issue in trunk though mihir [20:42] ahh yes indeed [20:42] balloons: didn't get you :| [20:43] mihir, https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1350605 [20:43] Ubuntu bug 1350605 in Ubuntu Calendar App "Existing Event can be "Hidden" when adding new events" [High,Triaged] [20:44] basically there is a display issue going on with events, and that's what we are partially seeing. The other issue is timing.. the page hasn't loaded yet and it tries to grab the object but it doesn't exist [20:44] your desktop is fast, so no weird issues and it runs fine [20:45] balloons: ohhh I see, I was trying to fail that test case on machine and couldn't [20:46] balloons: as we have added bug workaround in AP it should refresh the view righ t? [20:48] mihir, yes and you can see it dies.. but right after refreshing it checks for the object and fails.. you can just see the spinner on the dayview pag [20:48] when the video ends. the page is still loading [20:49] balloons: hmm I see that. [21:09] balloons, let me know when ur free [22:07] balloons: it seems there is a flaw in our autopilot test for alarms. It doesn't test the value of the alarm sound. As a result the test doesn't fail if the alarm sound cannot be chosen [22:10] nik90, the sound selection is new thought correct? [22:10] balloons: no it was there before this MP [22:10] ahayzen, sorry I've gotten stuck on this mp for some time [22:10] nik90, ahh, we should have included it then.. [22:10] balloons, no worries i'm just playing about attempting things ;) [22:10] balloons: the issue there is that the alarm sound chosen is not shown in the UI in the Alarm List page [22:10] balloons: so how do we tests its value if we cannot retrieve it via the UI? [22:10] balloons: unit tests? [22:11] balloons: are you stuck in my MP? [22:11] nik90, lp wouldn't let me comment on your mp, lol [22:11] weird [22:17] nik90, if the property is set we can read the value if needed [22:18] balloons: the property seems to be set in the EditAlarmPage where we don't do any verfication yet. We do the verification once the alarm is saved in the main Alarm Page where the alarm sound property cannot be read. [22:18] balloons: I will add a verify function in the EditAlarmPage for this [22:20] balloons: ah looks like carla did add a verify function in the EditAlarmPage... [22:20] * nik90 investigates why that didnt trigger the failure [22:23] balloons: can you look at https://bazaar.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/view/head:/tests/autopilot/ubuntu_clock_app/emulators.py#L225 [22:23] balloons: that's the verify function which wait for the alarmSound text to match the given sound name [22:23] balloons: why doesn't it fail? [22:28] balloons: in the emulator.py file, how do you check if two strings are the same and if not it fails the test [22:28] balloons: I can't use assert statements in the emulator.py file [22:35] nik90, need just a bit longer [22:35] sure [22:45] balloons: I fixed it [22:46] balloons: AP now fails if incorrect alarm sound is chosen [22:47] balloons, nik90, any reason/preference why the reminders app has a BaseTestCaseWithTempHome and then a RemindersAppTestCase but the clock app just has ClockAppTestCase ? [22:48] ahayzen: you got a link to BaseTestCaseWithTempHome? [22:48] nik90, http://bazaar.launchpad.net/~reminders-app-dev/reminders-app/trunk/view/head:/tests/autopilot/reminders/tests/__init__.py [22:48] nik90, note the RemindersAppTestCase at the bottom which inherits [22:50] no idea [22:50] hah [22:50] nik90, so should i just do MusicAppTestCase ? [22:50] soooo; before ubuntu ships the rtm [22:50] well frankly I never wrote the __init__.py fiel for either of the clock apps. So not the right person to ask [22:51] is there any apps that need shoring up? [22:51] I have some free time i can throw their way [22:51] nik90, hah no worries then i'll continue playing about :) [22:51] Akiva-Thinkpad: do you have a device to test apps? [22:52] Akiva-Thinkpad, are you interested in any particular area? coding/design/testing? [22:52] nik90, unfortunately not. [22:52] and that ^^ [22:53] ahayzen, core apps I have experience with, but I would be happy doing something new too. [22:53] * Akiva-Thinkpad still needs to finish my own app :S -- First though he needs a custom keyboard layout [22:54] Akiva-Thinkpad: your best bet would be core apps since the other system apps get enough attention with full time devs working on them :) [22:54] nik90, any one in particular that needs more work than the others? [22:55] nik90, ahayzen also; has the design for the tablet mode of Unity8 been planned yet? [22:55] Akiva-Thinkpad: I personally think the order is calendar app -> music app -> clock app. [22:55] clock and music ;) hehe ... no vested interest at all there right nik90 ? [22:55] Akiva-Thinkpad: calendar requires the most [22:55] yeah agreed calendar [22:56] thanks [22:56] whats the lp? [22:56] calender-app? [22:56] Akiva-Thinkpad: https://launchpad.net/ubuntu-calculator-app [22:56] Akiva-Thinkpad: lp:ubuntu-calculator-app [22:57] o_O [22:57] calculator app? [22:57] for the calender? [22:57] you are pulling my leg, right? [22:57] Akiva-Thinkpad: crap, sry [22:57] ha ha [22:57] Akiva-Thinkpad: https://launchpad.net/ubuntu-calendar-app [22:57] okay thanks [22:58] * Akiva-Thinkpad branches [22:58] to many apps starting with C lol [22:58] Akiva-Thinkpad: its 01:00 AM here, a bit sleepy :P [22:58] heh [22:58] ahayzen: yup [22:58] Clock, Calendar, Calculator....CMusic...anything else :D [22:58] CMusic \o/ [22:59] ha [23:00] nik90, how are you doing with the clock-reboot? [23:00] ahayzen: good..hoping for a replacement after the next promoted image since we need the latest sdk bits. [23:00] ahayzen: we are actually a position to do the replacement but have to wait for ^^ [23:01] OMG \o/ well done :) [23:01] thnx :) awfully tired but finally finally there ;) [23:01] hah ...i've been playing with the click from the store and love the transitions and animations :) [23:02] ahayzen: how's your bottom edge implementation going? [23:02] ahayzen: ETA on its landing? [23:02] nik90, ETA = when victor says it is ready [23:02] ahayzen: I think https://launchpad.net/ubuntu-clock-app/+milestone/rtm says part of the story [23:02] ahayzen: lol [23:03] nik90, he has done a first review and i've fixed that so will hopefully get another tonight :) https://code.launchpad.net/~andrew-hayzen/music-app/bottom-edge-implementation-001/+merge/230303 [23:03] ahayzen: oh cool [23:03] nik90, thats nearly as big as ur list at ... no thats getting old ;) [23:04] ahayzen: i am gonna kill you :P [23:04] hehe [23:04] nik90, but seriously awesome work :) [23:05] thnx mate [23:06] nik90, just wondering...as me and victor were discussing the other day....how are u going to handle rtm...are u gonna have a separate branch for rtm then a devel branch? or have u not decided yet? [23:06] ahayzen: separate branches I think [23:07] nik90, so then 2 clicks in the store? [23:07] ahayzen: I already have a separate branch for reboot, so it ain't that difficult [23:07] ahayzen: hmm clicks.. [23:07] nik90, hah but at one point i didn't think u could have two click with the same namespace but with different versions [23:08] yeah :/ [23:08] nik90, whatever we do i feel the coreapps need to be consistent otherwise it is gonna be confusing going between each of them [23:08] I personally think that multiple branches is the way for the following reasons, [23:09] 1. Say you migrate to ms3 and framework 15.04. What happens to the people using framework 14.10 and ms2? We would be abandoning them. [23:09] that is the biggest one ^^ [23:09] this is not acceptable for rtm since it is a public device after all [23:10] I remember beuno saying that they would perhaps add support for multiple click versions in the store. But no ETA on that. [23:10] if we raise this as a critical bug, then we might be get that feature landed [23:11] nik90, ahayzen ok I'm here.. perhaps briefly, but here [23:11] I am sure once 15.04 development starts, they will bump framework version and if we want to use that while at the same time supporting the old framework, we need multiple branches (and multiple clicks) [23:11] nik90, yeah maybe i think we need to all have a discussion with dpm and popey about it [23:11] ahayzen: +1000 [23:12] balloons, this is a non-working (i know why i think)...diff of the music-app autopilto tests...could u tell me if i'm heading in the right direction or not? http://pastebin.ubuntu.com/8049152/ [23:12] hah RemindersAppTestCase ... how did that get there... [23:13] balloons, i think i need to move the stuff from MusicApp into MainView? [23:13] balloons, thats what the clock app has [23:16] ahayzen, yes, looks good. Keep methods useful.. no 'get_first_track', instead 'get_track' and pass a number to get [23:16] so try and avoid the get_X mantra and you'll be fine [23:16] balloons, ah yes thanks [23:17] balloons, i think i understand how it works... [23:17] balloons, like with a class for the objects...eg having a class for Page etc [23:17] balloons, but haven't got it running yet still linking things up :) [23:17] ahayzen: also keep your tests as short as possible. All the hard work should be done in the emulators.py (or helpers.py). [23:18] ahayzen: look at the old clock app tests for example. [23:18] nik90, thats the plan .... so run_test() ? hehe [23:18] lol [23:19] balloons, should i be transitioning to py3 as well? [23:19] balloons, or are we py3 already... [23:19] balloons: jenkins is cruel...it makes me wait for long before telling me that I have pep8 errors and fails the integration :/ [23:20] long a.k.a 4 mins [23:20] nik90, run pep8/pyflakes locally ;) [23:21] ahayzen: I changed 3 lines of code at most...didnt occur I might make a pep8 error there :P [23:21] nik90, hah u'd think [23:21] nik90, I get burned all the time.. wlecome to the club [23:21] ahayzen, yes py3 all the way [23:22] balloons, cool i'll transition over...am i best just deleting all the old code? [23:22] balloons, then slowly building it back up [23:22] balloons, otherwise i have to think of alternate names for 'emulator' and 'test_music' [23:22] ahayzen, you can take either approach. For music, I would do a page at a time.. transition a page, and leave the rest [23:23] balloons, most of our tests use multiple pages though :/ [23:23] commits will be easier to read as well.. it won't be a giant replacement [23:23] balloons, which makes it tricky [23:23] balloons, but but but i like my 2.5K+ diffs [23:23] try and take small bites :-) [23:23] * balloons rolls eyes [23:24] balloons, ok but i would still end up with one large mp at the end no? [23:24] ahayzen, no I would propose as you go.. As I said, convert a page, and then use those new methods in the tests for that page [23:24] split out the tests into new files corresponding to the page [23:24] each one should be it's own mp [23:24] that's the theory.. [23:25] balloons, and then merge that into trunk....hmm ok so i guess i would need a separate emulators.py ? and __init__.py ? [23:25] reality might be harsher, but see if you can work along those lines [23:25] ahayzen, nope you shouldn't need a seperate [23:25] balloons, hmmm ok i'll try [23:26] ahayzen, yep, don't fret so much on what the mp will be.. try and bite off small chunks as I said.. it should come together [23:26] balloons, ok i'll try and convert 1-3 tests over the next day and mp that ...then let u have a look :) [23:27] ahayzen, sound sgreat [23:27] :) [23:28] balloons, thanks for ur help :) [23:29] ahayzen, sorry to bug you; but calender app uses a qml project file; is this a new type of project file? I am used to seeing cmakelists and qt .pro files [23:29] just curious [23:30] Akiva-Thinkpad, we use cmakelists in music-app but yeah qml projects can be used i don't know how new they are? [23:30] Akiva-Thinkpad, we did use qml project before :) nothing wrong with them [23:31] ahayzen, just curious now which of the templates use this... [23:31] errrr Simple and Tabbed did at one point IIRC ? [23:31] the template I used for my project in the new projects wizard, used cmakelists, and its annoying to configure. [23:31] ahayzen, yep right on the money [23:32] yey [23:32] Akiva-Thinkpad, what issues you having with cmake? [23:32] * Akiva-Thinkpad finds an excuse not to learn cmake!! [23:32] hooray! [23:32] ahayzen, icon setting [23:32] Hell I went so far to put an icon in every folder, and it still wouldn't show up. [23:32] pah [23:32] Akiva-Thinkpad, the only issue i have is that for ubuntu-sdk to work with autocomplete i have to open a qml project for qtcreator to index it ?! [23:33] hrm [23:33] Akiva-Thinkpad, i spot this line in music set(ICON_FILE images/music-app@30.png) [23:33] thanks I'll take a look at it. [23:34] Akiva-Thinkpad, this is our cmake http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/view/head:/CMakeLists.txt [23:34] Akiva-Thinkpad, other than ^^ issue i stated i have no issues with it [23:34] Akiva-Thinkpad, it just doesn't feel as integrated with qtcreator [23:34] ^ [23:34] Akiva-Thinkpad, eg with qml project u can right click and do 'Add new file' [23:35] yes! [23:35] geez; that is such an annoyance [23:35] Akiva-Thinkpad, yeah :/ [23:35] Akiva-Thinkpad, wish it was better [23:35] could be worse [23:35] hah [23:36] Akiva-Thinkpad, it was referred to as cbreak while we were transitioning ;) [23:36] ha ha [23:36] lol [23:36] * Akiva-Thinkpad gets to debugging the calender [23:37] \o/ [23:53] balloons: I am of to sleep. Can we talk about enabling the unit tests in jenkins tomorrow. Let me know if you find something about that. [23:53] balloons: I finished the custom alarm sound branch. Any further improvements, I will reserve to another MP. [23:54] \o/ sleep [23:55] nik90, good night. We can chat tomorrow. I pinged fginther about it earlier, I'll track him down tomorrow [23:56] nite :)