[01:56] elopio, thanks to you, they're in silo, hopefully for release soon === _salem is now known as salem_ === salem_ is now known as _salem === Cimi_ is now known as Cimi === Malsasa_ is now known as Malsasa [07:14] morning [07:20] Saviq, scope settings review :P [07:52] Saviq, what is "alt nav"? [08:54] bug with dash and manta [08:54] open sidestage, close [08:54] then dash becomes unresponsive [08:55] in reality is processing things but the texture is not updated [08:55] greyback, ? [08:56] Cimi: log a bug please [09:11] Cimi, yeah, need to crwbar-open the eyes first [09:12] Saviq, saw you worked till late [09:14] Cimi, till early, rather [09:15] hah [09:15] but! [09:15] check this out http://s-jenkins.ubuntu-ci:8080/job/unity-phablet-qmluitests-utopic/895/ [09:15] cannot, stupid vpn [09:16] no vpn for you [09:16] https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/895/ [09:16] Cimi, ↑ [09:16] @_@ [09:16] wow [09:16] was used to red [09:17] yikes autopilot failed on that completely, though :| [09:19] * Saviq worried something got seriously wrong [09:27] Saviq, eyes working now? [09:28] Saviq, so what is Alt Navigation? [09:28] Cimi, https://drive.google.com/drive/#folders/0B32jwBcbaPloR1IyRF91ZWs0bFE [09:28] Cimi, see ebay [09:35] Saviq, Alt means secondary? [09:35] Cimi, alternative [09:35] Saviq, we never shortened variable names so far, btw [09:36] Cimi, I know [09:36] we should have called Alternative [09:36] Cimi, but they are all long enough already [09:36] AlternativeNavigationFOo [09:36] So what? [09:36] is consistency... [09:36] I assumed it meant the Alt key [09:36] either Alt key or a shortened for Alternative [09:36] Cimi, the Alt key means Alternative, so you assumed kinda right ;) [09:37] hah [09:37] dednick, speaking of shortening, in your indicator polishing branch, you used id: ani instead animation, as well as other shortening, can you not shorten? [09:37] Cimi, I understand your concern, but unless you come up with a better shorter alternative (pun intended), I think we should deal with Alt === vrruiz_ is now known as rvr [09:38] Saviq, SecondNavigation [09:38] Cimi, except it's the first one! [09:38] ;) [09:39] left-to-right that is [09:39] AlternateNavigation :P [09:39] Primary then [09:39] or First [09:39] Cimi: yeah. just add it to your comments. [09:39] Cimi, well, no, because it's neither first, nor primary either [09:39] Cimi, Alternate isn't much better [09:39] 2 letters [09:40] Saviq, anyway I commented that we need ellipsis [09:40] Cimi, sure, you could even review it [09:40] I was reviewing [09:40] :) [09:40] with the exception that I redo half of it in https://code.launchpad.net/~saviq/unity8/header-customizations/+merge/230719 [09:40] to improve visuals and such [09:41] I wanted to review your small branches (so lazy I am), then I realised they are all dependent so I was starting from the first one [09:41] Cimi, good thinking :D [09:42] Saviq, they are tricky, you see they are 100 diff lines, you claim the review, and then you realise you're now in big trouble :D [09:42] glad it doesn't depend on split greeter [09:42] Cimi, gotcha [09:43] Saviq, do we want to have this alt navigation in? [09:44] Cimi, yeah, I'll take it over [09:44] Saviq, then address those in your header customisation? [09:44] Cimi, or I can take Albert's branch over [09:44] Saviq, be aware that there are tags in that branch, so we need to delete them asap they got merged [09:44] Saviq, then you have to rebase your branches though [09:45] Cimi, just the first one [09:45] Cimi, since it's a chain [09:47] Cimi, I think I'll rebase and actually bring a bunch of the changes over, no point in having the branches split [09:48] Saviq, up to you, but would be best [09:48] I still have a look now [09:49] Cimi, I might need to re-chain them though (put alt nav last) in that case [09:49] * Saviq doesn't want to :| [09:58] Saviq: you won't believe it :D [09:58] Saviq: current state of my device: touch input broken, mouse input working :D [09:58] or rather :( [10:00] mzanetti, sounds like you're it [10:00] bug #1295623 [10:00] bug 1295623 in Unity 8 "Sometimes input breaks and only edges are responsive" [Critical,Triaged] https://launchpad.net/bugs/1295623 [10:01] mzanetti, I think this is the time to 'apt install qtdeclarative5-dbg qtcore5-dbg unity8-dbsym unity8-private-dbgsym` [10:01] mzanetti, and step on it [10:01] mzanetti, one thing [10:01] Saviq: I rebooted already [10:01] mzanetti, NOOOOOOOOOOO [10:01] Saviq: and what I said is that its the other way round [10:02] mzanetti, well, still [10:02] Saviq: edges were broken and apps were working [10:02] Saviq: anyways.. seems I'm getting this more often again lately [10:02] yesterday I had it twice [10:02] mzanetti, so you were stuck to one app basically? [10:02] Saviq: yep, system-settings and indicators :) [10:02] that's it [10:02] indicators? [10:02] indicators are touch too [10:02] yeah... the panel is 2 gu's tall [10:03] in which area you can also pull it by mouse [10:03] hmm can you [10:03] mzanetti, no you can't [10:03] mzanetti, the whole 2gu is touch [10:04] Saviq: err, yeah... the panel is more [10:04] the 2 gu is touch, the rest mouse [10:04] mzanetti, ok, the whole panel is touch [10:04] ah wait [10:04] maybe I'm locked and that's why [10:04] anyways... it was working, but no launcher and no spread [10:04] mzanetti, hmm without -mousetouch I can't do anything with indicators on desktop [10:05] mzanetti, and I really believe the whole panel is touch [10:05] so maybe some other issue [10:05] sounds like the edge areas got stuck somewhat [10:05] I have a feeling that the lockscreen plays bad on me every once in a while [10:05] or maybe went under the app [10:05] mzanetti, btw https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/895/? [10:06] thanks again [10:06] * mzanetti gets out his pom poms [10:06] *\o/* [10:06] mzanetti, there's a butt [10:06] mzanetti, https://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3411/? [10:06] but I very much doubt related [10:06] oh man... [10:06] waiting for some other run after this got merged [10:06] ok... all fail... so there's chances its some single thing that breaks it [10:07] mzanetti, well, half of 'em [10:07] but I ran them all yesterday on mako and got all OK [10:07] before landing the silo [10:07] the other device is currently broken totally, so that failed [10:08] Saviq, reviewed https://code.launchpad.net/~aacid/unity8/alt_nav_support/+merge/230054 [10:10] Any chance that the AppIndicator's API will change with Unity 8? I see limitations that the indicators are now traditional menus (e.g., in Chrome's new Notification Icon). Windows and OS X got it right. [10:10] This concerns especially the desktop part. [10:11] laze1989, we're still quite far away from desktop implementation, there's no extensive design for the next iteration of Unity on desktops [10:12] laze1989, but please file a bug against ubuntu-ux so that we don't misplace your concern [10:20] Saviq: 180 + // only way to convert string to color 181 + var c = Qt.lighter(arguments[k], 1.0); [10:20] seriously? [10:20] Cimi, ideas welcome [10:21] this is in C++ right? [10:21] Cimi, that's JS [10:21] Saviq, so we can write a parser [10:21] Cimi, no we can't [10:21] Saviq, I meant, Qt.lighter is C++? [10:21] Cimi, yes, it is [10:21] the algorithm [10:21] yeah [10:21] so there is no benefit of writing a parser [10:22] Cimi, you can't even write a parser, how do you parse "white"? [10:22] Cimi, this needs to go through QColor [10:22] Cimi, this is basically a no-op [10:22] ]I see [10:22] just ugly [10:22] but probably best thing [10:22] Cimi, it will do QColor() and multiply its .v by 1.0 [10:22] Cimi, and return it [10:27] Cimi, I *could* just make this whole function C++ though [10:27] Saviq, it is probably faster [10:27] and maybe even use .v directly, having checked that it's a good enough value for us [10:28] Cimi, how about a TODO then [10:29] can we use shaders for those color operations? [10:30] feel free to offend me [10:30] I don't know much about shaders :) [10:43] I tried to articulate myself :-) https://bugs.launchpad.net/ubuntu-ux/+bug/1356816 [10:43] Ubuntu bug 1356816 in Ubuntu UX "[indicators] change current indicator design for the desktop" [Undecided,New] === MacSlow is now known as MacSlow|lunch [11:13] Hola === FJKong is now known as FJKong_CW [11:21] Cimi, ugh, I need to reorder the branches, managed to do something real weird to them [11:23] I think I pushed to the wrong branch at some point [11:23] yeah [11:28] Cimi: done with review [11:28] fixed i mean [11:28] dednick, thx [11:36] dednick, next step is potfiles for that [11:36] dednick, different branch though [11:37] dednick, if we are going to have a horizontal listview in the indicators, we cannot stay with the sound slider issue [11:37] Cimi: yeah [11:37] dednick, either add a mousearea around it eating those events [11:37] or follow up with sdk [11:37] Cimi: the menus aren't interactive, only the header is [11:37] it is in the examples [11:38] Cimi: yeah, i know [11:38] dednick, so if is just examples - fine [11:38] but if it will be in unity8, nope [11:38] Cimi: it's just the examples [11:38] anyway let's make them aware [11:38] Saviq: do you know if something regarding SIM pin unlocking landed in the indicators? [11:39] mzanetti, not recently no [11:39] Saviq: hmmm... the button to open the unlock dialog doesn't seem to show up any more here [11:39] will investigate [11:39] mzanetti, wfm [11:40] Saviq: hmm... maybe I blocked it [11:40] and it just fails to ask for the PUK [11:40] dednick, can we bump UC to 1.1? [11:41] Cimi: why? [11:41] Cimi: oh, you mean dependency? [11:42] dednick, in the files [11:42] dednick, I want to make sure we use the latest [11:46] dednick, the wobbly animation on the icon in MessageComponents only work on expansion [11:46] dednick, is that wanted? [11:46] yes [11:46] ok [11:46] dednick, also is always on for unexpandable ones [11:46] ya [11:46] ok [11:46] well rest is fine [11:47] dednick, I'd just bump to 1.1 as said [11:47] for the file we touch [11:48] Cimi, https://code.launchpad.net/~cimi/unity8/scope-settings/+merge/230182/comments/560879 looks like a valid fail [11:48] even though at first glance you're not touching anything there... [11:48] Saviq, which failure? [11:49] maybe a compare() instead of tryCompare [11:49] of the two? [11:49] Cimi, hmm let's see another run [11:49] I can try locally [11:50] Saviq, I also merged trunk lately [11:51] Cimi, well, yeah, but at least after my fix-foo branch it passed, maybe something else in the recent landing [11:51] testDash works here [11:51] Cimi: ok, updated to 1.1 [11:52] Saviq, QML AbstractButton: Binding loop detected for property "implicitWidth" so annoying [11:52] Cimi, yeah, guess where that is ;) [11:52] Saviq, yep :P [11:53] Saviq, both tests pass here [11:53] * dednick is hungry! [11:53] Cimi, ok, let's see, there's more qmluitest runs incoming [11:54] dednick, http://theburgerlist.tumblr.com/post/94443927060/le-bourguinon-bun-le-bun-riverside-feast-battersea === alan_g is now known as alan_g|lunch === MacSlow|lunch is now known as MacSlow [12:10] Saviq, did you see my comments in the previous review? [12:11] Cimi, they shouldn't be lost [12:11] Saviq, ok [12:11] they are not [12:13] not lost or lost? [12:13] jeez that's a chain [12:13] now someone needs to start reviewing the beginning of it... [12:15] Saviq: thanks for landing horizontal-list so quickly :) [12:15] cwayne, got even more goodness in store https://drive.google.com/drive/#folders/0B32jwBcbaPloR1IyRF91ZWs0bFE [12:15] cwayne, just now we've like 7 branches dependant on each other that need to be reviewed ;) [12:16] :D [12:16] i saw those last night, super excited about it [12:16] cwayne, do you know if any of the scopes try to send preview button color? I couldn't find any [12:16] Saviq: if it's this chain it's okay https://www.youtube.com/watch?v=v1iuSmZHcwY [12:16] Saviq: none of ours do yet [12:17] Saviq: im happy to whip one up though if its helpful [12:17] cwayne, nah, is fine [12:18] davmor2, I'm not sure our chain's as nice as this one [12:18] davmor2, I fear ours is more like http://www.hoax-slayer.com/images/mother-teresa-novena-chain-1.jpg [12:18] nice url... [12:19] davmor2, or well, right now it's more like http://yazminmedia.com/wp-content/uploads/2010/08/blog-broken-chains.jpg [12:20] @unity I need volunteers to review https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 https://code.launchpad.net/~unity-team/unity8/seeLessStuckBottom/+merge/230786 [12:20] there's some free karma in: [12:20] https://code.launchpad.net/~saviq/unity8/grey-from-palette/+merge/230603 [12:20] https://code.launchpad.net/~saviq/unity8/move-pageheader/+merge/230609 [12:20] Saviq, I can do table preview [12:21] Cimi, claim it! [12:21] Saviq, it is automatic to mhr3 [12:22] Cimi, as long as there's no "unity team" in the reviewers list it's fine [12:23] Saviq, I am lost [12:23] Saviq, which one is the first??? [12:23] https://code.launchpad.net/~saviq/unity8/grey-from-palette/+merge/230603 ? [12:23] seems like [12:24] Cimi, yes === _salem is now known as salem_ [12:43] https://code.launchpad.net/~saviq/unity8/update-qmltypes/+merge/230737 and https://code.launchpad.net/~saviq/unity8/grey-from-palette/+merge/230603 [12:43] Saviq: ^ [12:44] mzanetti, thanks, on the ScopesOverview button... it should really use SDK's Button, I think Albert didn't see the support for an outlined one [12:45] ah feck it, same branch [12:45] * mzanetti got lost... but I'm sure you'll just fix it [12:45] :D [12:47] ohnoes [12:47] the stroked button does not allow for font color changes /facepalm [12:48] jeezuz [12:49] :D === alan_g|lunch is now known as alan_g [12:54] run_on_device working for you guys? [12:58] bug #1356864 [12:58] bug 1356864 in ubuntu-ui-toolkit (Ubuntu) "Button with strokeColor does not change font colour" [Undecided,New] https://launchpad.net/bugs/1356864 [12:58] mzanetti, it can't work too well with separate dash [12:59] mzanetti, i.e. it will launch the system dash [12:59] I've a branch that should've fixed that, but doesn't... [12:59] Saviq: I'm ok with that [12:59] Saviq: doesn't start unity at all here [12:59] just hangs [12:59] mzanetti, status unity8? [13:00] Saviq: this is the output: http://paste.ubuntu.com/8045193 [13:00] hangs here at the end [13:00] it says "start/running" if asking for status in another shell [13:00] mzanetti, so no PID [13:00] mzanetti, looks like it's in a crash loo[ [13:00] loop [13:00] hmm [13:00] interesting [13:01] indeed [13:01] what(): Unknown command line options: -qmljsdebugger=port:3768 [13:01] well, not in a loop, but just stuck here [13:03] and bug #1356866 [13:03] bug 1356866 in ubuntu-ui-toolkit (Ubuntu) "Button with strokeColor's border looks wrong" [Undecided,New] https://launchpad.net/bugs/1356866 [13:03] hmm.. removing that arg makes it start... [13:03] mzanetti, new mir I believe [13:03] mzanetti, we need to eat that arg before it gets to mir [13:04] * mzanetti still thinks libraries should not bail out on arguments they don't know [13:04] why would mir prevent me to add some cmdline arg [13:04] doesn't make sense to me [13:04] if it can't use it, ignore it [13:08] mzanetti: Mir got a new API to allow us to stop mir bailing on args it doesn't recognise, but qtmir hasn't implemented it yet [13:09] an API for that? :) [13:09] yeah [13:09] why would anyone want to enable that? [13:09] or better: not want to disable it [13:10] is there a nice way a library can filter out the cmd line args it accepts? [13:10] don't think so... [13:11] ultimately we don't want a mis-spelled cmd line arg being ignored [13:11] hmm... I'd say yes, better that then not starting at all. but even if we agree on that, its imo the applications responsibility to do that [13:12] so this is an idea we had. Pass all cmd line args to Mir, mir filters out the ones it does accept, I pass the rest to Qt/the app [13:12] not one of the libs it loads [13:12] we let Qt do it. Qt is a lib [13:13] qt doesn't assert if there's an argument it doesn't know [13:13] sure, that's the mir default behaviour. We can (and will) override that [13:14] greyback_, do you recall why do we have "PKGCONFIG += mircommon mirclient" in the ubuntumirclient QPA? It's supposed to talk just to platform-api... [13:14] dandrader: nope, I don't recall [13:14] wonder if it's a leftover. couldn't find any references to mir in the code... [13:14] we most've missed it so [13:14] must've [13:38] @unity more free karma https://code.launchpad.net/~saviq/unity8/update-deps/+merge/230803 [13:41] Saviq: approved [13:41] do you need top approval? [13:41] Wellark, sneaky! ;) [13:41] Wellark, generally yes :) [13:43] mzanetti, I am reviewing this https://code.launchpad.net/~mzanetti/unity8/new-lockscreen-design/+merge/230478 [13:44] mzanetti, do you want to add https://bugs.launchpad.net/unity8/+bug/1169615 ? [13:44] Ubuntu bug 1169615 in Ubuntu UX "[greeter] Welcome screen AM/PM text is unnecessary big" [Medium,Triaged] [13:47] I'm getting the Hello Box o' Doom (ie, the lockscreen) when trying to log into the Unity8 desktop session now. r1150 looks suspicious to me in causing this behavior, but I'm not 100% sure. [13:54] greyback_: I saw your findings in https://bugs.launchpad.net/ubuntu/+source/unity8-desktop-session/+bug/1353041. Thanks and sorry to blame qtmir:) [13:54] Ubuntu bug 1353041 in unity8-desktop-session (Ubuntu) "Logging out of the Unity8 desktop preview session hangs" [High,Confirmed] [13:54] ChrisTownsend: no worries! I'll see if I can whip up a quick patch fori it anyway [13:54] greyback_: Cool, and thanks! [13:56] mzanetti, fixed all your concerns [13:59] do you guys use any extension for chrome to organise tabs? [14:01] Cimi: I guess I can add that [14:01] Cimi: have lots of conflicts now anyways after mterry's branch is merged [14:01] Saviq: I approved the grey one already [14:01] will check the other now === gatox is now known as gatox_lunch [14:05] Saviq: for "dash as app", is console.log() still works when do ./run.sh? [14:06] Saviq, good to merge https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/indicator-polishing/+merge/229083 [14:08] Saviq: anyway. I found the solution. Watch ~/.cache/upstart/unity8-dash.log === charles_ is now known as charles === alan_g is now known as alan_g|tea [14:26] Saviq, using style delegates in unity is not nice [14:26] Saviq, kinda kills the idea of themability [14:26] Cimi, no it doesn't, if the style depends on the theme [14:27] Cimi, which it does wherever it can right now [14:27] Saviq, nope because if I ship my own theme, I still need Ambiance [14:27] Cimi, it's there because scopes can override the default theme [14:27] Cimi, you do understand we have virtually no themeability in the SDK currently? [14:28] Saviq, why that? we have themes [14:28] Cimi, doesn't mean they actually work properly [14:28] Cimi, or are thought out [14:28] it is not full, right [14:29] but I can have squared buttons if I want [14:29] Cimi, basically our design team doesn't want to *allow* themeability to the extent we're used to it [14:29] Saviq, that's false [14:29] Cimi, talk to them [14:29] Saviq, what we want is to provide our theme [14:29] Saviq, and support that [14:29] Cimi, talk to them [14:29] as well as allowing some changes for operators [14:30] Cimi, aaanyway [14:30] Cimi, the styling component for the dash is a requirement [14:30] Cimi, but [14:30] Cimi, as you can see, it tries to base off of the theme where possible [14:31] Cimi, but the theme is just lacking information in a few places, or is plain incompatible with the dash design [14:31] dednick, standup === alan_g|tea is now known as alan_g [14:44] Saviq, how do we try qml/Hud/HudParametrizedActionsPage.qml ? [14:44] on https://code.launchpad.net/~saviq/unity8/move-pageheader/+merge/230609 [14:44] Cimi, tryHud [14:45] Cimi, but really just make sure testHud works, if we ever bring this back we'll have to fix tons of things there anyway [14:46] Saviq, yes, but not good reason to regress :) [14:46] but yeah don't worry about it [14:56] Saviq, approved, waiting CI [14:57] Saviq, should be fine, I grep for PageHeader all around [14:58] on https://code.launchpad.net/~saviq/unity8/header-customizations/+merge/230719 now [14:58] MacSlow, you still looking for reviews? [14:59] pete-woods, any update on the fix? [14:59] Cimi: it will be rolled out with our next scopes release [15:00] which should be "real soon now" [15:02] Cimi, yes [15:03] Cimi, take any of the top ten from https://code.launchpad.net/~macslow, which isn't claimed yet... [15:04] Cimi, e.g. https://code.launchpad.net/~macslow/sync-monitor/fix-1350282 [15:05] MacSlow, no thanks :D [15:06] MacSlow, I thought you were looking to do reviews [15:06] MacSlow, I have already few for today [15:06] Cimi, sure... that too... but I would want to focus on Dash-related bits as Saviq suggested during the stand-up [15:09] Saviq, speaking of Dash-related MPs... any favourite ones reviewers should focus on? [15:10] Cimi, you're doing the customization ones and table, right? [15:10] Saviq, one at a time [15:10] Cimi, you're assigned to all of them ;) [15:11] hah yeah [15:11] Cimi, give one up to MacSlow :) [15:11] Cimi: any updated ETA on settings landing? [15:13] cwayne, talk to Saviq :P [15:14] cwayne, it's waiting review [15:14] cwayne, looks fine on my side [15:14] cwayne, hopefully by Monday [15:14] cwayne, there is though a bug on backend side [15:14] cwayne, if all else fails, I'll have everything related in silo for Monday [15:16] Saviq, can we have luminance in C++ ? [15:16] or well, a generic color util [15:16] would be nice to have in SDK though [15:17] Cimi, yeah, 90% of this needs to go into SDK [15:17] Cimi, and no, you can't atm [15:17] not worth it [15:24] Saviq, https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/903/? [15:24] still broken on a different branch, might be trunk then [15:26]