/srv/irclogs.ubuntu.com/2014/08/15/#ubuntu-app-devel.txt

Akiva-ThinkpadPing any calender app devs? been a few months since I have proposed anything for merging. Was wondering if anyone wanted to give this branch a review:01:13
Akiva-Thinkpadhttp://bazaar.launchpad.net/~akiva/ubuntu-calendar-app/ubuntu-calendar-app/revision/394?start_revid=394#NewEvent.qml01:13
Akiva-Thinkpador rather this one: https://code.launchpad.net/~akiva/ubuntu-calendar-app/ubuntu-calendar-app01:15
Akiva-ThinkpadDo I wait for someone to review it before proposing it for a merge?01:15
Akiva-Thinkpadah hold on; need to recommit; forgot one expandable01:24
Akiva-Thinkpadokay done :)01:32
Akiva-Thinkpadand my computer just crashed01:38
Akiva-Thinkpad>:/ why do all the developers have to be sleeping at this hour!01:38
=== chihchun_afk is now known as chihchun
fgintherballoons, you around?02:45
fgintherballoons, I must have missed your ping02:45
dholbachgood morning06:13
Akiva-Thinkpaddholbach, hey good morning06:49
Akiva-Thinkpaddholbach, are you working on the calender app? I submitted a patch/merge, and its been awhile since I did it.06:50
Akiva-ThinkpadJust wondering if you would mind taking a look at the proposal, and tell me if I did it right?06:50
Akiva-Thinkpadfeel free to say "busy" :)06:51
Akiva-Thinkpadhttps://code.launchpad.net/~akiva/ubuntu-calendar-app/ubuntu-calendar-app06:53
=== greyback__ is now known as greyback
dholbachAkiva-Thinkpad, I don't work on calendar, sorry07:40
Akiva-Thinkpadnp07:40
dholbachpopey should know who to ping about an MP07:40
Akiva-Thinkpadthanks07:40
Akiva-Thinkpadwhen he gets up then :P07:40
nik90Good morning :-)07:55
Akiva-Thinkpadnik90, morning07:55
Akiva-Thinkpadnik90, you work on the calender app right?07:55
Akiva-Thinkpador did you just point me in that direction :P07:56
nik90Akiva-Thinkpad: no, I work on the clock app. But sure what's up?07:56
Akiva-Thinkpadnik90, oh its just been a few months since I did the ol merge thing; can you give my merge proposal a look, and just tell me if I did it right?07:56
Akiva-Thinkpadhttps://code.launchpad.net/~akiva/ubuntu-calendar-app/ubuntu-calendar-app07:56
nik90Akiva-Thinkpad: first thing can you rename your branch? You can do so by pushig the branch again to launchpad07:57
nik90Akiva-Thinkpad: bzr push lp:~launchpadid/ubuntu-calendar-app/branch-name07:57
Akiva-Thinkpadwhy do I need to rename it?07:57
Akiva-Thinkpadand what should I name it to?07:57
nik90Akiva-Thinkpad: because ubuntu-calendar-app is your current branch name which is a bit confusing.07:58
Akiva-Thinkpadokay07:58
nik90just to help the calendar devs quickly see what the branch is about07:58
nik90Akiva-Thinkpad: in the branch link, there is a link called "Propose for merging". Click on that, add the description, commit message and press propose. That's about it.07:59
Akiva-Thinkpadokay great advice07:59
Akiva-Thinkpadnik90, even though it hasnt been reviewed?07:59
Akiva-Thinkpador does the review happen when I propose it?07:59
nik90Akiva-Thinkpad: the review happens when you propose a merge07:59
nik90Akiva-Thinkpad: it is similar to a pull request in github07:59
Akiva-Thinkpadnik90, and should I set the status from "Development" to something else?07:59
nik90Akiva-Thinkpad: nah, what it says by default should be fine08:00
nik90Akiva-Thinkpad: these are the current MPs for calendar app for example08:00
Akiva-Thinkpadnik90, bzr: ERROR: Permission denied: "~akiva/ubuntu-calender-app/new-event-pan-flickable-down/": : Project 'ubuntu-calender-app' does not exist.08:02
Akiva-Thinkpadusing bzr explorer08:02
nik90Akiva-Thinkpad: did bzr push  lp:~akiva/ubuntu-calendar-app/branch-name not work?08:03
Akiva-Thinkpadnik90, no08:03
Akiva-Thinkpadwell08:03
Akiva-Thinkpadwait; i'll do it in terminal08:03
Akiva-Thinkpadnik90, yep worked08:06
Akiva-Thinkpad!cookie08:06
ubot5Wow! You're such a great helper, you deserve a cookie!08:06
Akiva-Thinkpad:)08:06
nik90hehe08:06
popeyMorning all08:08
Akiva-Thinkpadpopey, Hey busy fellow; Chris is Badmouthing ubuntu, and you arent there to defend it !08:09
Akiva-Thinkpad:O08:09
popeyyeah, he's a silly rabbit08:09
* Akiva-Thinkpad assumes you are swamped with the rtm08:09
popeyjust a tiny bit08:09
Akiva-Thinkpad;)08:10
popeyAkiva-Thinkpad: akiva/ubuntu-calender-app/new-event-pan-flickable-down/ didn't work because of a typo, you typed calender instead of calendar, that's all08:11
Akiva-Thinkpadha ha shucks :P08:11
popeyeasily done08:12
popeybut thank you for the contribution!08:12
Akiva-Thinkpad:P08:12
popeyso at https://code.launchpad.net/~akiva/ubuntu-calendar-app/new-event-pan-flickable-down if you're happy with the merge then click "propose for merging"08:12
nik90Akiva-Thinkpad: you will need to propose it08:13
popeythen it will get reviewed08:13
Akiva-Thinkpadyep; doing it right now08:13
Akiva-Thinkpad:)08:13
popeyWinner.08:13
popeyWhat an excellent way to start a friday.08:13
DanChapmanMorning all o/08:14
nik90DanChapman: Morning :)08:14
Akiva-Thinkpadnik90, https://code.launchpad.net/~akiva/ubuntu-calendar-app/new-event-pan-flickable-down/+merge/23093508:15
Akiva-Thinkpaddoes that look good?08:15
Laneyis there a mailing list for "app developers" or is it just ubuntu-phone?08:16
nik90Akiva-Thinkpad: do add a commit message otherwise jenkins will fail you :D08:16
Akiva-Thinkpadnik90, ah shucks; guess I have to recommit08:16
nik90Laney: just ubuntu-phone and ubuntu-core-apps08:16
nik90Akiva-Thinkpad: no no08:16
nik90Akiva-Thinkpad: in the MP itself08:16
nik90Akiva-Thinkpad: there must a set commit message for the MP08:16
Akiva-Thinkpadoh I think I did.08:16
nik90Akiva-Thinkpad: no you set the Description of the Change not the commit message08:17
Akiva-Thinkpadoh wait08:17
Akiva-Thinkpadshould I just make it the same as my description?08:17
Akiva-ThinkpadI used to have a formal way of doing commit messages, but DPM just told me to avoid it.08:18
Akiva-Thinkpadjust be brief08:18
nik90Akiva-Thinkpad: just be brief would be fine.08:18
Akiva-Thinkpadokay08:19
Akiva-Thinkpaddone08:19
Akiva-Thinkpadthanks for the help08:19
Akiva-Thinkpad!cookie08:19
ubot5Wow! You're such a great helper, you deserve a cookie!08:19
nik90Akiva-Thinkpad: now we wait for a calendar app dev to review it. I will test it on the device a bit later08:19
Akiva-Thinkpadnik90, neato08:20
Akiva-Thinkpadpopey, Just curious; http://i.imgur.com/ZTnhvR7.png < This has been around for awhile; has there been any discussion in regards to fixing this?08:21
Akiva-Thinkpadthe little aesthetic flaw where things in the list escape outside the ubuntu shape?08:21
Akiva-Thinkpadnik90, or maybe you can answer that question08:22
nik90Akiva-Thinkpad: I am not sure, but it is annoying to see that though08:22
nik90Akiva-Thinkpad: calendar app dev -----> Mirv08:22
nik90bah08:22
nik90mihir ^^08:22
Akiva-Thinkpadnik90, its in the showcase too.08:22
nik90I know08:22
Mirv:)08:23
seb128speaking of calendar app, should it work on unity7 desktops on utopic?08:23
Akiva-Thinkpadha ha08:23
mihirnik90: hey good morning all :)08:23
seb128seems to hang/not display an ui here08:23
Akiva-Thinkpadmorning08:23
mihirseb128: it does run on utopic08:23
Akiva-Thinkpadseb128, I have it working on mine08:23
mihirseb128: but we don't have UI change if we resize08:23
Akiva-Thinkpadwell okay, running; I havn't tested the functionality extensively.08:23
seb128hum, I wonder why it's not display anything here08:24
seb128e_cal_client_get_view: assertion 'E_IS_CAL_CLIENT (client)' failed08:24
seb128wonder if that's the issue08:24
mihirseb128: you running from trunk ?08:24
mihirnik90: btw , I have fixed the Icon MR , you can review whenever you get time :) thanks for that08:25
seb128mihir, 0.6bzr390 from the core apps ppa, should be similar08:25
nik90seb128: I think that's a EDS error, not really sure how to fix it. I think it may cause the clock app to not start as well if you have the error08:26
seb128k08:26
* seb128 tries a guest session08:26
seb128works with another user08:28
popeyAkiva-Thinkpad: i had never seen that08:28
mihirhow much usually it takes to start an emulator ??08:28
mihiron utopic, vm08:28
ybonvery first run takes a lot08:28
ybonlike 20 minutes last time for me, then it's faster for other runs of the same image08:29
mihirybon: hmm okay , when i try to run from QT creator it does nothing , but when i do it from terminal it starts.08:30
mihirhow can we change scale using Terminal ?08:30
JamesTaitGood morning all; happy Friday, and happy Relaxation Day! :-D08:30
nik90mihir: hey can you check if icon-location@18.png and icon-contacts@8.png , avatar@8.png are required? If yes replace them with suru icons?08:30
Akiva-Thinkpadpopey, for what its worth; filed a bug : https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/135723808:34
ubot5Ubuntu bug 1357238 in Ubuntu UI Toolkit "Ubuntu Shape corners escape " [Undecided,New]08:34
popeythanks Akiva-Thinkpad08:34
Akiva-Thinkpad:)08:35
popeybtw ybon I'm seeing a couple of apparmor failures in osmtouch...08:35
popey[Fri Aug 15 09:31:09 2014] type=1400 audit(1408091469.359:230): apparmor="DENIED" operation="chmod" profile="me.yohanboniface.osmtouch_OSMTouch_0.1.3" name="/run/user/32011/" pid=4344 comm="qmlscene" requested_mask="w" denied_mask="w" fsuid=32011 ouid=3201108:35
* mihir looks for the icons usage in calendar08:35
popey[Fri Aug 15 09:31:09 2014] type=1400 audit(1408091470.090:231): apparmor="DENIED" operation="mkdir" profile="me.yohanboniface.osmtouch_OSMTouch_0.1.3" name="/home/phablet/.cache/QtLocation/" pid=4344 comm="qmlscene" requested_mask="c" denied_mask="c" fsuid=32011 ouid=3201108:35
ybonpopey: humm, thanks08:35
ybonI'm afraid it explains why we don't have tile caching anymore08:36
ybonAm I missing a securicy-policy group?08:36
* ybon on http://developer.ubuntu.com/publish/apps/security-policy-for-click-packages/08:38
mihirnik90: it is done.08:39
ybonoh, I see a "sensors" policy group, but I've not add it to Sensors Status, and I can still access to accelerometer or gyroscope08:42
ybonJust in case, I'm adding it08:43
popeyybon: you'll probably need to cache somewhere else, that you have write access to08:46
ybonpopey: I'm not sure I can control that :/08:46
ybonIIRC, it's one of the QtLocation internal settings that are not exposed08:47
ybonbut I will check that again08:47
dpmt1mp, kalikiana, if I want to show a popup dialog before an app shows its main UI, what's the best way to do it? I've tried to use a PopupUtils.open() call inside the MainView's Component.onCompleted handler, but that does not seem to work.08:47
ybonbtw, I remember asking if .cache was safe, and being answered yes :)08:48
nik90mihir: any reason why you guys are showing the save and cancel button in the bottom instead of as header buttons?08:48
popeyybon: might want to ping jdstrand, he's the apparmor guru08:48
ybonpopey: thanks :)08:48
nik90mihir: that will save some precious vertical space and declutter the new event page a little08:48
ybonjdstrand: if you are around, I may need a bit of help to understand what's wrong on OSMTouch cache :)08:48
mihirnik90: you meant to say they should be on top right corner right ?08:49
kalikianadpm: t1mp: how do you mean "before" exactly? you need to display something on screen, so normally that would mean pop over on top of your MainView08:49
nik90mihir: yes08:49
dpmkalikiana, sorry, I wasn't clear. What you're describing is exactly what I mean08:50
mihirnik90:  i guess this was decided in Malta spring , so I am not much aware about that, popey any comments ? ^^08:50
nik90mihir: the save button should be in the top right. The cancel button should replace the back button in the header.08:50
kalikianadpm: do you have a test snippet I could have a look at?08:50
popeyI don't follow?08:51
nik90popey: in the new event page, the buttons save and cancel are shown in the bottom toolbar.08:51
nik90popey: any reason why this shouldnt be header buttons like the other core apps do?08:52
popeyoh, yes, totally should.08:52
nik90mihir: ^^08:52
mihirnik90: noted :)08:52
popeygood call, this solves another issue with those buttons obscuring content08:52
nik90mihir: it should be an easy fix. I could do it but I don't want to mess with calendar app AP tests08:52
mihirnik90: yup , i know we have to change AP accoridngly too :)08:53
nik90mihir: make it look like https://docs.google.com/presentation/d/1Kkl7xT8BYo9mT8i3IXh6rPrDlNg6cBxTajahlRYIGlI/edit#slide=id.g18587dd40_07708:53
* mihir looks at presentation slides08:54
dpmkalikiana, I don't, I've got a full-blown app, but I think this should illustrate what I'm trying to do: http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/require-password-screenlock/view/head:/src/app/qml/ubuntu-terminal-app.qml#L1808:55
mihirtrivial MR review  , https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1357216/+merge/23094008:56
dpmkalikiana, if I put that PopupUtils.open() call in another handler, e.g. here http://bazaar.launchpad.net/~ubuntu-terminal-dev/ubuntu-terminal-app/require-password-screenlock/view/head:/src/app/qml/ubuntu-terminal-app.qml#L52 it does show up08:56
dpmonly on Component.onCompleted handlers it seems it doesn't08:56
nik90mihir: hmm did you push anything into it. It looks empty to me, both MR and branch08:57
mihirnik90: yeah , i just saw that, the push got intrrupted re-pushing that08:57
nik90ah08:58
dholbachpopey,  yo yo - how's life over there?08:59
popeydholbach: super (on hangout)09:02
mihirnik90: it should be done now , https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/1357216/+merge/230942 ?09:04
t1mpdpm: how does calling the popup open from mainview not work?09:11
nerochiarodpm: I fixed one of the two apps that still had wrong desktop translations. let me know if this works for you: https://code.launchpad.net/~phablet-team/dialer-app/desktop-translation-fixes/+merge/23094409:11
mihirnik90: have you ever used Stroke Button >09:11
mihir?09:11
nik90no09:12
nik90its quite new I think so I havent09:12
mihirnik90: hmm yup , we have to replace date textbox as we are using highligted property of that ,and it is going to deprciate09:13
nik90mihir: isn't it just a normal button with strokecolor?09:13
t1mpdpm:  the PageStack + contents is being completed before the MainView09:14
t1mpdpm: so if you want the PageStack to be loaded later, you'll need to put it inside a Loader09:14
t1mpnik90: yes09:14
mihirnik90: i am not sure .09:15
nik90mihir: ^^ it shouldn't be difficult09:15
nik90mihir: check API docs in QtC :)09:15
t1mp    /*!09:16
t1mp      \since Ubuntu.Components 1.109:16
t1mp      If set to a color, the button has a stroke border instead of a filled shape.09:16
t1mp    */09:16
t1mp    property color strokeColor: Qt.rgba(0.0, 0.0, 0.0, 0.0)09:16
t1mphmm, docs for this are not on the webpage yet09:16
nik90t1mp: yeah mhall119 has to update the docs in the webpage09:16
t1mpmhall119: can you trigger an update for http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.Button/ ?09:16
t1mpmhall119: actually for the full uitk docs :)09:16
nik90t1mp: I always first look at QtC docs which get updated with every sdk update09:16
nik90mhall119: I think you should have a script for this to update automatically with every sdk update09:17
Akiva-ThinkpadHey I recorded a 100kb (Tiny) video demonstrating a bug; how do you think should I upload it? Filebin? Youtube? This is for a bug report on the calender app.09:18
nik90Akiva-Thinkpad: you should be able to upload the video directly as an attachment in the bug report09:18
Akiva-Thinkpadnik90, okay great09:18
Akiva-Thinkpadwill do09:18
popeybeuno: "Changes can not be accepted and published at this time. Please try again later."09:19
popeyis there a deployment happening? How do I always seem to hit those?09:19
* nik90 is away from irc to do some coding...09:19
popeyo/09:19
=== nik90 is now known as nik90|BusyCoding
mihirt1mp: got it thanks for09:20
mihirt1mp: i was referring docs on website instead of QTC09:20
mihirpopey: what do you think for bug , https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1357255 ?09:21
ubot5Ubuntu bug 1357255 in Ubuntu Calendar App "Year view has day names too condensed" [Undecided,New]09:21
mihirpopey: do we need to handle that small resoultion  as well ?09:21
nik90|BusyCodingpopey: quick question, when you click on an alarm sound to choose it, do you want it do a playback loop of the sound? Or just play it once?09:26
popeynik90|BusyCoding: once09:29
popeynik90|BusyCoding: and tapping a second stops the first and plays second.09:30
popeymihir: looking...09:30
nik90|BusyCodingjhodapp: ping09:35
=== nik90|BusyCoding is now known as nik90
mihirpopey: thanks :)09:39
Akiva-ThinkpadFor the calender, are new events supposed to show up in the agenda?09:41
Akiva-Thinkpador is that not implimented yet?09:42
Akiva-Thinkpador do I need to be connected to google or something?09:42
mihirAkiva-Thinkpad: it is supposed to be show up in agenda09:44
Akiva-Thinkpadmihir, okay; I made a quick video showing my debug too;. will submit a bug report09:45
mihirAkiva-Thinkpad: sure , thanks..btw i see list of up coming events on my agenda view.09:45
Akiva-Thinkpadmihir, screenshot?09:46
Akiva-Thinkpadmihir, https://bugs.launchpad.net/ubuntu-calendar-app/+bug/135728009:46
ubot5Ubuntu bug 1357280 in Ubuntu Calendar App "Creating New Event does not show up on "Upcoming Events"" [Undecided,New]09:46
* mihir tests agenda view09:50
nik90jdstrand: ping09:55
Akiva-Thinkpadmihir, hey; bug was actually my issue09:59
Akiva-ThinkpadI did not have "Personal" or "Birthdays" enabled.09:59
Akiva-Thinkpadmihir, Given my confusion, if the list is empty, do you think it might be a good idea to add a quick tip to an empty agenda?10:00
Akiva-Thinkpadsay "No Upcoming Events" + <br> + "Make sure you have Calendars enabled"?10:02
Akiva-ThinkpadAnyways; gonna head out. I marked the bug as invalid.10:05
Akiva-Thinkpado/ later all10:06
nik90mihir: Does calendar support Trusty?10:06
nik90mihir: You guys are using still using toolbar items instead of the new Header API10:07
nik90which requires Utopic10:07
nik90popey: can you add me to the calendar-app-dev, I want to create a RTM milestone and put all important bugs there.10:19
popeyawesome10:20
popeydone10:20
nik90popey: thnx10:20
mihirnik90: yes it does work on trusty my machine, but haven't tested all the functionalties \10:21
mihirnik90: did it break anything fo you ?10:22
nik90mihir: no it works on trusty10:22
nik90mihir: but I think you guys should move to the new headers which will requires utopic10:23
mihirnik90: hmmm   okay :)10:23
* mihir files a bug 10:24
nerochiarodpm: messaging app should also be fixed here: https://code.launchpad.net/~phablet-team/messaging-app/more-desktop-translation-fixes/+merge/23095310:28
nerochiarodpm: i'll email you about those two as well10:28
davmor2nik90: there was a bug for the datetime indicator issue right? my lp foo is failing me10:35
nik90davmor2: yeah it doesn't show the contents anymore.. UI broke10:36
davmor2nik90: but was there a bug?10:37
nik90davmor2: charles is trying to debug it.10:37
nik90davmor2: not that I know of...will check now..1 sec10:37
davmor2I couldn't find one but I'm sure there was mention of one10:37
davmor2maybe it was just discussions10:38
nik90davmor2: I couldn't find it either...I remember popey asking if he should report one.10:38
nik90popey: did you ^^10:38
davmor2popey: didn't he was asking me for the number :)10:38
davmor2popey: do you want to file it or should I, I think I must of seen charles talk about this issue and throw out a bug number for another bug10:39
nik90charles was debugging the issue and I provided some logs..dont recollect seeing a bug report10:40
popeygah10:40
mihirnik90: is there any way we can control text alignment of Button directly ?10:42
nik90mihir: no10:42
nik90mihir: doesn't it do it automatically?10:42
mihirnik90: it does set in center by default , and no other way to controll it10:43
popeydavmor2: nik90 bug 135730710:43
ubot5bug 1357307 in indicator-datetime (Ubuntu) "Datetime indicator no longer shows events, time not updated" [Undecided,New] https://launchpad.net/bugs/135730710:43
nik90mihir: btw do you have permission to set bug priority for calendar app?10:43
mihirnik90: yup i do have10:43
nik90mihir: ok in which case please do set the status and triage the bugs as you submit them pls. This way we can focus on the important ones quicker.10:44
nik90mihir: also move them to the rtm milestone if they are important10:44
mihirnik90: sure got it, i do confirm bugs if they are reporducable on desktop as of now.10:44
mihirfor other bugs i ask popey or dpm to confirm it10:44
popeywill do10:45
nik90davmor2, popey: I have a feeling that the datetime-indicator bug started with qtmir 0.610:45
dpmnerochiaro, awesome, thanks! I've reviewed the MP ad added a few comments10:45
nik90davmor2, popey: Which iimage did that land in?10:45
nik90because I remember charles looking at the 189 changelog and seeing absolutely no changes that could cause the bug10:45
nik90which makes me suspect that it could have originated in 18810:45
nik90or 18710:45
davmor2nik90: 189 was when we all saw it10:46
davmor2could of landed in 18810:46
mihirpopey: you have done it few days back , and there are no more to confirm i can see , thanks for tha t10:47
nerochiarodpm: i haven't worked on any of these apps, i think renatu, boiko and tiago will know how to fix these comments10:47
nerochiarodpm: i don't know what these strings refer to10:47
mihirpopey: ping10:50
mihirpopey: for the bug ,https://bugs.launchpad.net/ubuntu-calendar-app/+bug/131519910:50
ubot5Ubuntu bug 1315199 in Ubuntu Calendar App "[Desktop] Running the Calendar app from the command line (calendar-app) uses the old icon" [Low,Triaged]10:50
popeyi marked it low, "phone > desktop" in terms of priority10:51
mihirpopey: i dig out into all the way , and i couldn't find anywhere the old icon is being used, is there any other location it comes in Ubuntu Desktop?10:51
popeyprobably the debian package points to it10:51
popeywhich is separate from the click package config10:51
popeyat a guess10:51
popeybut it's low, so I wouldn't worry too much.10:51
mihirpopey: it should be something out of the click package , though .10:51
mihirpopey: okay.10:51
dpmt1mp, thanks. So all I want is that before showing any pagestack pages, a popup dialog is shown. Would it just be a matter of putting the pagestack inside the Loader (I've never used those)? Where should the PopupUtils.open() call should be invoked, then?11:07
t1mpdpm: what about putting pageStack.push(terminalPage) after                 console.log("Authenticated for full access") ?11:08
t1mpor after that whole if-statement if that's what you want11:09
dpmt1mp, so I tried this for testing purposes: http://pastebin.ubuntu.com/8052914/ - but that does not load the popup, either11:11
zygahey, I'm looking for anyone willing to do code reviews for my QML code for chcekbox-touch11:15
zygaI'm still learing basics and I'd love pointers and criticism from more experienced developers11:15
t1mpdpm: weird that it doesn't open the popover. Is mview initialized? You can also call  open() without a second parameter to have a centered popover (not pointing to an Item)11:16
zygaif anyone willing to spend a few minutes looking at the stuff I'm writing please ping me11:16
nik90zyga: link11:16
zyganik90: thanks, all of the code is in in lp:checkbox, let me give you a link http://bazaar.launchpad.net/~checkbox-dev/checkbox/trunk/files/head:/checkbox-touch/11:17
zyganik90: we had a prototype but we're writing stuff from scratch, what you see there is just the main page really11:17
zyganik90: now the code I'm working on here aims to introduce a simple list of items that you can select/deselect11:17
zyganik90: each item is a simple string11:17
nik90zyga: If you can create a MP for it, I'd be willing to review and add comments to it.11:18
zyganik90: ok11:18
zyganik90: thanks!11:18
nik90zyga: say thnx after I do the review..I could ditch you ;P11:18
dpmt1mp, I don't know if mview is initialized, I just noticed that if I put the .open() call inside the Component.onCompleted() handler for either mainview or pagestack, it won't load the popup. Also removing mview as the caller from the .open() function does not help11:18
t1mpzyga: to get all the latest UITK features, import Ubuntu.Components 1.1 (utopic only)11:19
mihirzsombi_: ping11:20
zsombi_mihir: pong11:20
mihirzsombi_: can we change text color of button ?11:20
t1mpzsombi_: dpm's popover issue^ is it possible that the rootItem is not valid yet in onCompleted of an item?11:21
zsombi_mihir: lemme check, there were thing sadded recently to it...11:21
t1mpdpm: if you can reproduce this problem with a simple (as small as possible) test program, I can play around with it11:21
mihirzsombi_: i couldn't see anything in doc , along with that alingment of text is also not there11:21
mihirzsombi_: bug https://bugs.launchpad.net/ubuntu-calendar-app/+bug/135730311:22
ubot5Ubuntu bug 1357303 in Ubuntu Calendar App "Use different component instead of using Textbox or custom component instead of textbox. " [High,Confirmed]11:22
zsombi_mihir: nope, not possible :(11:22
t1mpdpm: the behavior seems not intuitive, so if you can reproduce it with a test program, perhaps file a bug for it11:22
mihirzsombi_: hmm thats bad :( for calendar :|11:22
mihirzsombi_: any workaround woudl you suggest ?11:23
zsombi_mihir: there11:23
zsombi_mihir: there's non really... :(11:23
mihirzsombi_: :(11:23
ahayzenpopey, we just had this bug 1357324, are we expected to do export support as well before rtm? as we only have import as WIP at the moment?11:23
ubot5bug 1357324 in Ubuntu Music App "Content hub integration as source/destination of music" [Undecided,New] https://launchpad.net/bugs/135732411:23
zsombi_mihir: I'd rather file a bug against UITK11:23
mihiri just did for alignment https://bugs.launchpad.net/ubuntu-calendar-app/+bug/135730311:24
ubot5Ubuntu bug 1357303 in Ubuntu Calendar App "Use different component instead of using Textbox or custom component instead of textbox. " [High,Confirmed]11:24
mihirzsombi_: wrong link , https://bugs.launchpad.net/bugs/135732311:24
ubot5Ubuntu bug 1357323 in Ubuntu UI Toolkit "There is no way to control text alignment of the button" [Undecided,New]11:24
mihircould you confirm and make it possible done before RTM ?11:24
popeyahayzen: wishlist11:24
ahayzenpopey, ok shall i change that bug to track exporting then? and use the other one as importing11:25
mihirzsombi_: bug https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/135733211:25
ubot5Ubuntu bug 1357332 in Ubuntu UI Toolkit "There is no way to control text color of Button" [Undecided,New]11:25
ahayzenpopey, this one for importing https://bugs.launchpad.net/music-app/+bug/134744411:25
ubot5Ubuntu bug 1347444 in Ubuntu Music App "Music app does not expose download handler" [High,In progress]11:25
popeyyeah, keep the two things separate bugs11:25
ahayzenpopey, cool :) and i see a silo for ms2 \o/11:26
zsombi_mihir: is this text color bug an issue needed for rtm?11:26
popeyswet11:26
popey+e11:26
mihirzsombi_: both of them actually11:26
mihirzsombi_: i would say first , Color then alignment11:27
mihirzsombi_: the reason is it will break consitetency of Event Page11:27
zsombi_mihir: I see11:27
zygat1mp: thanks!11:27
zygat1mp: does that inclue U.C.ListItems, we get those still at 1.0?11:28
dpmt1mp, something like that? -> http://bazaar.launchpad.net/~dpm/+junk/popupapp/view/head:/main.qml#L2611:28
mihirzsombi_: this is how it looks like currently ,http://imgur.com/MKGhCJm11:29
mihirpopey: http://imgur.com/MKGhCJm11:29
t1mpzyga: listitems are still at 1.011:29
zygak11:29
dpmt1mp, on that test app, I can actually see the popup for a split second before it gets hidden by the page loaded11:29
zsombi_t1mp: if the popover is created the same time as the rest of the app's components, then it can be that during onCompleted the rootItem is not yet valid11:30
mihirzsombi_: the text needs to be left aligned , and the color should be changed according to the other component11:30
nik90zsombi_, mihir: I didnt follow the issue fully, but why not use abstract button instead?11:31
zsombi_mihir: actually nik90 has a point... you can use abstractButton instead11:32
zsombi_mihir: of course in that case you need to make all teh layout, all the shading, the pressed efects ASO11:33
ahayzenIs the datetime indicator not showing the correct time on image 189 a known issue? seems to be totally frozen11:33
zsombi_dpm, t1mp: so what was the issue?11:34
mihirzsombi_: nik90 can I control color,alignment in AbstractButton ?11:35
nik90mihir: abstractButton is basically like an Item{}11:35
dpmzsombi_, here's a test app: http://bazaar.launchpad.net/~dpm/+junk/popupapp/view/head:/main.qml - in summary, I try to load a popup above the mainview that prevents seeing the UI below, but if I use PopupUtils.open() inside Component.onComplete, it seems the popup is loaded, but it ends up behind the main page11:35
zsombi_mihir: AbstractButton has nothing,11:35
nik90mihir: it offers a container where you can put the button items11:35
mihirzsombi_: nik90 i see11:36
nik90mihir: so you set the layout, color, size and son etc.11:36
* mihir tries Abstract Button11:36
zsombi_mihir: but AbstractButton ia also stylable, so you could try to use the ButtonStyle for it...11:37
nik90ahayzen: yup known bug11:38
zsombi_dpm: yes, as said before, the problem you're facing is that the rootItem is not yet set by the QML system, that's why it goes like that11:38
zsombi_dpm: but a workaround ;)11:38
nik90ahayzen: https://launchpad.net/bugs/135730711:38
ubot5Ubuntu bug 1328646 in Unity 8 "duplicate for #1357307 Clock out of sync on resume from suspend" [Critical,Triaged]11:38
nik90ahayzen: woops wrong bug11:38
zsombi_dpm: var popup = PopupUtils.open(.....); popup.parent = idOfTheMainView11:39
nik90ahayzen: nvr mind tht's the correct bug11:39
ahayzennik90, hah but it is known at least :)11:39
zsombi_dpm where idOfYourMainView is what it says, so you need to give an ID to your MainView :)11:39
ahayzennik90, confusing using the term 'clock' lol..not clock app but clock in the indicator11:40
dpmzsombi_, I did add it, I just removed it after t1mp's suggestion11:40
zsombi_dpm: and didn't work?!11:40
nik90ahayzen: hehe11:40
zsombi_dpm: hehh...11:41
zsombi_dpm: keep it and set popup.z = Number.MAX_VALUE11:42
zygawhat is the best non-visual component to use for a composition of other non-visual components11:43
zygaapparently QtObject cannot be used as it (?) cannot hold children11:43
* zyga was looking at http://qt-project.org/doc/qt-5/qml-qtqml-qtobject.html11:43
nik90zyga: what kind of non-visual components?11:44
nik90zyga: js functions?11:44
zyganik90: a python handle (pyotherside's Python compoent) + a whole collection of high-level "handles" (other non-visual components that expose APIs of python-side objects to QML)11:44
zyganik90: so for a pyotherside-based address book that might be something like11:45
zyganik90: Component { Python { ... } AddressBookManager { ... } AddressBookSynchronizationMagic { ... } }11:45
ahayzenpopey, hmmm the ms2 in the silo claims that 'non-existent property "onFilled"' ... but we are using that with trunk11:45
zyganik90: the idea is that you then put AddressBook {  } in your code and you can use various exposed APIs to talk to internals (say, find a contact by name or initialize synchronization)11:46
zyganik90: it's not really an address book, I'm just using that as an example11:46
zyganik90: should I just use Component?11:46
ahayzenpopey, and that onFilled was added with the streaming models ...so unless they have removed it?!11:46
nik90zyga: Component{} are similar to defining those components in a separate file11:46
nik90zyga: they delay the loading of those children until they are actually needed11:47
zyganik90: hmm, ok so maybe to rephrase, what is the difference between Component and QtObject?11:47
dpmzsombi_, I tried your suggestion: http://bazaar.launchpad.net/~dpm/+junk/popupapp/view/head:/main.qml#L30 - but still I can see the popup for a split second, to be covered by the main page afterwards11:47
=== MacSlow is now known as MacSlow|lunch
zyganik90: in C++ I'd just subclass QtObject and shove all my other non-visual objects there11:48
nik90zyga: QtObject is sort of like a structure where you can store properties, functions etc that you want to access11:48
zyganik90: but not children?11:48
popeyahayzen: check their merge?11:48
zyga(or did I miss something while reading QtObject QML docsw)11:48
ahayzenpopey, FYI if that lands it will break our trunk in its current state11:48
nik90zyga: not children11:48
ahayzenpopey, yeah i will it is like it has gone backwards lol11:48
popeyheh11:48
zyganik90: right, so for children-capable non-visual class I should go to... Component?11:49
nik90zyga: give it a try, although I am not that convinced11:49
zyganik90: hmm, Components cannot declare new properties11:49
nik90zyga: here is an example of qtobject https://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/head:/app/alarm/AlarmUtils.qml11:49
popeyogra_: seems ms2 might break the music app...11:49
ahayzenpopey, i was hoping it was gonna let us land content-hub support but seems they have changed something...i'm scanning the diff at the moment11:50
ogra_popey, bah11:50
nik90zyga: can I look at the code of your non-visual components in paste.ubuntu.com or somewhere. I am trying to get a better idea of it11:51
zyganik90: maybe my approach is wrong, I don't want to write any C++, 90% of the code is in python, I want to provide QML interfaces to that via pyotherside, it's mostly straightforward when you just use pyotherside directly (instantiate Python and call py functions through its API), what I want to do is build a layer that hides pyotherside and just exposes my application objects as if they were from a "native" QML extension11:51
zygasure11:51
zygahttp://paste.ubuntu.com/8053127/11:51
ahayzenpopey, they have set/getStatus() now with Ready and Loading states...i assume this is what has been changed from the filled property being set to true11:52
zygathat's CheckboxStack, the high-level component that apps will use to use our testing library11:52
dpmpopey, could you initiate a file manager upload to land the security checks feature?11:52
ahayzenpopey, yep it is that11:52
zyganik90: then other bits are mostly going to be something I call PythonHandle, a small class that has a handle to something we got from pyotherside (basically cross-runtime lifecycle manager) with a way to call methods on it11:53
nik90zyga: ah ok that makes better sense now11:53
zyganik90: so all our boring python API objects are going to have a subclass of PythonHandle11:53
zyganik90: that natively exposes the API as QML11:53
zyganik90: (with API stability etc etc)11:53
nik90zyga: let me try to edit that and show an example11:53
zyganik90: thanks11:53
popeydpm: yup11:53
zyganik90: feel free to rip out pyotherside11:53
zyganik90: as that part works, I'm just struggling with raw qml11:54
zyganik90: none of those components are visual11:54
jdstrandybon: the chmod denial is weird and others have reported seeing it. it is a legitimate denial (ie, I won't be adding policy for it)11:54
ahayzenpopey, how urgent is that ms2 landing? as i'll fix that when i get from work...and then we need to test the content-hub stuff as well11:54
zyganik90: they are mostly models of some sort11:54
nik90ack11:54
zyganik90: test definition objects, test sessions, test results, etc11:54
ybonjdstrand: so you mean QtLocation should not be writting on ~/.cache/ ?11:55
popeyahayzen: well, i don't know, but we need to block the ms2 landing if it breaks apps.11:55
popeyogra_: how do we do that? ^11:55
ahayzenpopey, yep we need todo that11:56
popeyybon: jdstrand you may be interested in bug 135732711:56
ubot5bug 1357327 in usensord (Ubuntu) "One app blocks anothers access to sensors" [Undecided,New] https://launchpad.net/bugs/135732711:56
ogra_ahayzen, popey, did that land already ? else simply dont land it11:56
yboninteresting popey11:56
popeyogra_: its in a silo, which one ahayzen ?11:56
jdstrandybon: the .cache/QtLocation denial is also a legitimate apparmor denial (ie, I can't add policy for it). my guess is that either your application isn't setting 'applicationName' in your qml correctly (or setOrganizationName/setApplicationName in qt) or QtLocation isn't properly honoring these11:56
ahayzenpopey, ogra_ 00211:57
ogra_popey, so mark that silo as not ready11:57
ogra_then it wont land11:57
ybonjdstrand: okay, thanks for making this clear, I will investigate a bit more11:57
popeyahayzen: got a link? I don't have it open or even have the url11:57
ahayzenpopey, is music-app in the ms2 test plan? as they broke us before, if it isn't then it should be ...even if it is just check that the app starts/ap runs11:57
ybonI remember QtLocation was not honoring those settings time ago, but I know this was to be fixed11:57
ogra_popey, ahayzen, probably add something to the comments11:57
ybonNeed to check out the code of QtLocation actually used11:58
ahayzenpopey, http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu&q=landing-00211:58
popeyta11:58
nik90zyga: http://paste.ubuntu.com/8053157/11:58
zyganik90: thanks11:58
zyganik90: so visual Item, ok, I'll just use that :)11:58
zyganik90: one thing I want to ask about as well, separately from the rest is: project code organization:  http://paste.ubuntu.com/8053159/11:58
zyganik90: if you look at lines 12-1411:59
popeyogra_: I don't actually know what to edit to do that... the spreadsheet at https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AuDk72Lpx8U5dFVHQ3FuMDJGLUZCamJfSjYzbWh3Wnc#gid=0 ?11:59
zyganik90: Components there is a symlink to ./components11:59
jdstrandybon: if you narrow it down to a bug in QtLocation, can you ping me with the bug-- I'd like to subscribe to it since other apps may also be affected and I can refer people to it11:59
karniwho's responsible for playing a sound on incoming SMS? it's not in messaging-app nor history-service, I can't find it.11:59
jdstrandnik90: hi11:59
zyganik90: on lines 354+11:59
nik90zyga: 1 sec11:59
zyganik90: how should I arrange that so that my main.qml sees the qmldir inside11:59
zygak11:59
popeyogra_: i have only view access on that sheet11:59
zyganik90: currently I just run qmlscene -I . main.qml11:59
ogra_popey, well, the lander of ms2 should do that ... i thought thats ahayzen12:00
nik90jdstrand: https://code.launchpad.net/~nik90/ubuntu-clock-app/play-sound-preview/+merge/23095912:00
popeyno, ms2 is ours, jamesh and pete-woods12:00
ybonjdstrand: ok12:00
popeythostr owns it12:00
nik90zyga: you can import components in your main.qml by relative paths12:01
ahayzenogra_, i do the music-app and was testing 'upstream' mediascanner212:01
nik90zyga: so something like import "../../components" as Components12:01
popeyahayzen: maybe leave a comment on the merge at least.12:02
nik90jdstrand: hey I am having an apparmor issue with regards to media-hub playing the alarm ringtones from the /usr/share/sounds folder12:02
ahayzenpopey, ok i'll add a comment for now... would you be able to chase up?...i should be able to fix it when i get back from work quite easily12:02
karninik90: good timing, I'd like to play a sound from my app, and for some reason, no worky :(12:02
jdstrandnik90: what is the denial?12:03
zyganik90: oh, let me try, thanks!12:03
nik90jdstrand: https://code.launchpad.net/~nik90/ubuntu-clock-app/play-sound-preview/+merge/230959/comments/56144012:03
zyganik90: will that respect the qmldir inside?12:03
popeysure ahayzen12:03
nik90zyga: Do you have c++ code or is this all qml and py?12:03
ogra_popey, ahayzen, i assume you talk about line 35 ... thats not set to "testing done", talk to jamesh and pete-woods12:03
jdstrandnik90: can you paste the contents of /usr/bin/media-hub-server?12:03
zyganik90: all qml and py12:04
nik90jdstrand: sure, 1 sec12:04
nik90zyga: you dont need a qmldir then12:04
zyganik90: though we'd like API declarations (versioning of components)12:04
popeyyes ogra_ can you unset that, because i cant12:04
nik90zyga: ah12:04
zyganik90: it's not required yet, I'm just toying with it12:04
nik90zyga: I don't have experience with that yet I am afraid. the sdk does it quite nicelt12:04
zyganik90: later on we'd like to make the checkbox stack library a drop-in thing you can add to apps12:04
nik90nicely12:05
zyganik90: yeah, the SDK is preinstalled though in where QML modules are looked for12:05
zyganik90: so maybe I should just add it to lib/$triplet12:05
zygaeven as symlinks12:05
ahayzenpopey, i've commented on the mp12:05
* zyga tries12:05
popeythanks12:05
zygathough that will only work on the device12:05
zyga(ubuntu-app-launch is the part that understands lib/triplet)12:05
zyganik90: thanks, I got enough to work with for a while now :-)12:05
ahayzenogra_, yes line 3512:06
nik90zyga: :) I will think about it12:06
nik90jdstrand: not sure I follow12:06
ogra_ahayzen, right, so conact the landers listed there :)12:06
nik90jdstrand: the file is present there in that folder12:06
ahayzenogra_, i gotta go back to work :/ popey can u ping them?12:06
jdstrandnik90: what is the output of 'cat /etc/apparmor.d/usr.bin.media-hub-server'12:06
nik90ah12:07
zyganik90: :-)12:07
popeyya ahayzen12:07
ahayzenpopey, thanks12:07
* ahayzen hugs popey12:07
nik90jdstrand: http://paste.ubuntu.com/8053241/12:07
jdstrandah12:09
jdstrandwe have this rule:owner /tmp/orcexec* m,12:10
jdstrandbut it is overriden by this: audit deny owner /** m,12:10
jdstrandnik90: can you file a bug against media-hub?12:10
nik90jdstrand: sure. So basically the bug is about media-hub not being to read the /usr/share/sounds folder?12:11
karninik90: is it possible to play a sound at all using MediaPlayer? or is there a known problem with that12:11
jdstrandnik90: well, the denial you have in https://code.launchpad.net/~nik90/ubuntu-clock-app/play-sound-preview/+merge/230959/comments/561440 is about mmap access to /tmp/orcexec.CLp5yf12:11
jdstrandthat would prevent playback12:12
nik90jdstrand: ok I will file at media-hub stating permission issues :)12:12
nik90karni: not sure12:13
nik90karni: actually no it should work for you12:13
nik90karni: the jupiterbroadcasting app in ubuntu touch uses media hub and works fine12:13
karninik90: I see my solution was almost same, besides I'm playing my own file, and with MediaPlayer12:13
jdstrandnik90: you can test if this is the problem by doing: 'sudo mount -o remount,rw /' then adjusting /etc/apparmor.d/usr.bin.media-hub-server to remove/comment out 'audit deny owner /** m,', then doing 'sudo mount -o remount,ro /', then loading the profile with 'sudo apparmor_parser -r /etc/apparmor.d/usr.bin.media-hub-server'12:13
karninik90: I would only need media-hub to play an external file, right?12:13
nik90karni: i suppose yes12:13
nik90jdstrand: ok will give it a try12:13
* nik90 first files a bug12:14
jdstrandnik90: thanks, please ping with the bug number12:14
nik90jdstrand: bug 135734812:17
ubot5bug 1357348 in Media Hub "Cannot play sound files in /usr/share/sound/** folder due to apparmor permission issue" [Undecided,New] https://launchpad.net/bugs/135734812:17
nik90jdstrand: hmm that doesn't work12:22
nik90jdstrand: i tried your solution, while I don't see the denial I still dont hear the playback12:23
jdstrandnik90: do you see another denial?12:28
nik90jdstrand: no I don't see the denial12:28
nik90jdstrand: it work on desktop though..12:28
jdstrandnik90: it sounds like two different issues then. you could try rebooting the device/restarting media-hub-service12:29
jdstrandnik90: I will still get the apparmor denial fixed though12:29
nik90jdstrand: ok12:30
nik90jhodapp:12:30
nik90jhodapp: need some help debugging an issue12:30
jdstrandnik90: I'm quite glad you pinged me on this. mediascanner2 also suffers from this, and I hadn't noticed the override deny rule12:30
nik90jdstrand: :)12:31
nik90jdstrand: Is http://paste.ubuntu.com/8053359/ the same denial I got earlier?12:31
nik90jdstrand: hard to see since the time stamp seems all wrong12:31
jdstrandnik90: it is not the same denial, but it is caused by the same rule and will be fixed by the same update12:34
nik90ah ok12:34
jdstrandnik90: media-hub uploaded with your fix12:41
nik90jdstrand: thnx12:41
nik90jdstrand: how is it so fast fix-committed?12:42
nik90jdstrand: we still need to wait for this to land on the image?12:42
jdstrandnik90: I did a direct upload (no code changes)12:42
nik90jdstrand: oh12:42
jdstrandnik90: I marked it as Fix Committed manually12:42
jdstrand(since it is building in -propsed)12:43
nik90jdstrand: sweet..will test again in the next image since it should be there then12:44
=== dholbach_ is now known as dholbach
dholbachpopey, can you review my app? :)13:12
dholbachI fixed it!13:12
=== MacSlow|lunch is now known as MacSlow
popeydholbach: Changes can not be accepted and published at this time. Please try again later.13:19
popey13:19
popeysame I had later13:19
popeys/later/earlier/13:20
dholbachwow13:20
=== chihchun is now known as chihchun_afk
karninik90: yeah, got the same AppArmor AccessDenied, because it's qmlscene that wants to access core.ubuntu.media.Service13:50
karnihappy fix for that bug moved forward so fast13:50
nik90karni: that bug fix alone doesnt fix the issue for me13:51
nik90karni: there is some other component that need fixing as well13:51
karnio rly, dang. what's wrong ?13:51
karniI see13:51
karninik90: is there an easy way to query media hub for notification sounds only?13:51
karninik90: I think you were talking about that today, right?13:51
karniabout selecting a notification sound13:52
nik90karni: not that I know..you need to give media-hub the url to the notification sounds13:52
karninik90: you mentioned being able to select an alarm sound -- is this implemented somewhere already?13:54
nik90karni: https://code.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/+merge/22581213:54
karninik90: thanks a bunch man13:55
nik90np13:55
nik90balloons: Is https://code.launchpad.net/~nik90/ubuntu-clock-app/add-custom-sound-backend/+merge/225812 ready for merge?14:20
nik90balloons: I want to push out a store update after it is in trunk.14:20
nik90popey: it looks http://geoname-lookup.ubuntu.com/?query=Farnborough&release=utopic is currently down. Does that mean the migration is happening atm :D?14:22
nik90nvr mind it is backup now14:22
popeyi get 500 here14:22
popeyno admin2 tho14:23
nik90yeah no admin2 or timezoneid14:23
* nik90 waits longer14:23
popeynik90: every other refresh I get a 500 error14:28
nik90popey: the first time I get a 500 error, but after refreshing it works again. not sure what is happening14:29
popeyasked the IS guy but he's afk14:29
popeyso dunno if he's doing it, or what14:29
mhall119t1mp: updating now14:30
mhall119nik90: automating is the goal, it's pretty close already14:30
nik90hmm I am hoping this is in before the weekend..would love to merge that branch in14:30
nik90mhall119: ok14:30
mhall119nik90: I have scripts already that pull the new docs package and process it14:30
mhall119I just need to setup a server where I can schedule it to run regularly14:31
nik90nice14:32
popeynik90: on it with him now14:33
nik90popey: ty14:33
zyganik90: https://code.launchpad.net/~zkrynicki/checkbox/touch-app/+merge/23098714:38
zyganik90: criticism and other feedback welcome! :-)14:38
zyganik90: going patch-by-patch is probably easier to understand14:39
nik90zyga: :)14:40
zyganik90: feel free to ignore all of the python parts if you don't care about that14:41
zyganik90: the readme should help you to get this to work if you want to try it out14:41
nik90yup saw it14:41
zyganik90: it's pretty easy on the desktop, a bit more annoying (for now) on devices, there's a MP for getting that right but it's not ready to land yet14:41
nik90will test and see how it runs14:41
zyganik90: thanks!14:42
nik90I will comment there directly when I am doe14:42
nik90done*14:42
t1mpmhall119: thanks~14:42
t1mp!14:42
mhall119t1mp: done14:44
t1mpmhall119: looks good, thanks14:48
mhall119np14:48
nik90zyga: when I press "start testing" is it supposed to do anything yet?14:49
zyganik90: nope14:51
zyganik90: not yet14:51
nik90ack14:51
zyganik90: I have the next bits but I wanted to know the approach is good14:51
zyganik90: specifically all the QML component separation14:52
nik90zyga: ah ok. got it14:52
zyganik90: I'm also totally not sure how to write tests for anything but that's (for now) ok as we want to do a manually tested 1.0 and iterate14:52
zyga(1.0 is still a few big UI screens away :-)14:52
nik90zyga: you can test using QTest or Autopilot. I am guessing you will prefer autopilot since it is python14:53
brendandzyga, autopilot autopilot :P14:53
zyganik90: :-)14:53
nik90brendand: now I know which side you are on :D14:53
zygabrendand: I'll do autopilot for sure14:54
zyganik90: though I'll probably do both, we'll have a moderate amount of js code as well14:54
brendandnik90, well qmltest has a purpose as well14:54
zygabrendand: qmltest?14:55
brendandnik90, people seem to think they do the same thing but they really don't14:55
zygaooooh14:55
nik90yes, QTest help with unit tests quite well14:55
zygaI love that14:55
zygaqmltestrunner14:55
zyga\o/14:55
zygaI have to enable that in our CI14:55
brendandnik90, QTest is for C++ though14:55
nik90brendand: there is a qml version for it now which is what the sdk, unity8, (recently the clock app) uses14:56
brendandnik90, you mean this right? http://qt-project.org/doc/qt-5/qtquick-qtquicktest.html14:57
nik90brendand: yup14:57
* zyga looks14:57
zygathanks for the tips guys! :_)14:57
brendandzyga, if you need some help with autopilot let me know. the right way to do it is not totally obvious, so best to look at a few existing app tests rather than trying to parse it from the documentation14:58
zygabrendand: I'd love to try to add trivial autopilot tests once we get to the second screen (next week for sure)14:59
zygabrendand: one thing I totally don't know is what to test14:59
zygabrendand: like "I click on the 'start testing' and I go to another screen?"14:59
zygabrendand: what's the right angle on that15:00
zygabrendand: so yeah, I'll definitely ask for advice15:00
brendandzyga, do you know what the page object model is?15:01
zygabrendand: a little, yeah15:02
zygabrendand: I read some of the sources15:02
zygabrendand: because they were much better than documentation15:02
brendandzyga, you want to write classes which represent each of your screens15:02
brendandzyga, and have functions that represent actual behaviour15:02
brendandzyga, so WelcomeScreen.continue15:03
brendandzyga, and that has the code to press the button and everything15:03
zygabrendand: what do I write those classes in? Javascript?15:03
brendandzyga, that way if the way of pressing the button changes, you just fix it there15:03
brendandzyga, no - python - this is in autopilot15:03
zygaoh15:03
zygaohhhhh15:03
zyga:D15:03
brendandzyga, it's like a wrapper around the autopilot code15:03
zygaI I had a tail, it would wiggle now :>15:03
zygaif*15:04
brendandzyga, the advantage is that if the way of 'continuing' changes - to a different button or something, or the button name changes15:04
brendandzyga, then you fix it in the page objects method, rather than in every single test15:04
zygabrendand: right, that makes sense15:05
zygabrendand: and we can run those tests on devices and such, right?15:05
brendandzyga, well absolutely15:05
zygabrendand: can we somehow jump on part of the CI train to test our branches wrt autopilot tests on devices?15:05
brendandzyga, yes - you need to register your project in the 'cupstream2-distro' project15:06
brendandzyga, although that's changing - eventually15:06
brendandzyga, but for now that's how you do it15:06
zygabrendand: https://launchpad.net/cupstream2-distro ?15:06
zyga404 for me15:06
brendandzyga, sorry it was one word -https://launchpad.net/cupstream2distro15:07
zygabrendand: I don't want to do it yet (nothing to test) but I'll ask you about how that works sometime next week or the one after, depending on our dev speed15:08
nik90zyga: typing up my review comments atm.15:09
nik90zyga: actually shall I rather just propose a MP into your MP?15:11
zyga:-)15:11
zyganik90: whatever works better for you15:11
zyganik90: I use git locally so you can push to that if you prefer git15:11
zyganik90: (I can publish my native branch)15:11
nik90oh no ... I am a bzr guy :)15:11
zygasure ;)15:11
zyga:-)15:11
nik90I will push my changed and propose an MP in 5 mins15:11
zygathank you15:12
zyganik90: perfect, thanks15:14
zyganik90: I'll apply your changes and see how it works15:14
nik90zyga: quick question..you planning to show any other element in the welcome page other than welcome and the button?15:17
zyganik90: no, though the welcome text can be longer15:18
zyganik90: it will typically be a paragraph or two15:18
nik90zyga: ok15:19
zyganik90: I tried your quick code and it doesn't look right as the button is not at the bottom of the page, I'll see if I can make it be there somehow15:19
nik90zyga: wait which code?15:19
nik90zyga: I didnt propose anything yet15:19
zyganik90: Layout.fillHeight: true15:19
zygaoohh15:19
zyganik90: heh, look at the merge request :)15:19
zyganik90: I got another review and I thought that was you :)15:19
zyganik90: :>15:20
nik90zyga: that's mzanetti15:20
nik90mzanetti: I am fixing the code atm :D15:20
mzanetti?15:20
zygamzanetti: thanks for your review :-)15:20
nik90zyga: I will address his comments as well15:20
nik90mzanetti: https://code.launchpad.net/~zkrynicki/checkbox/touch-app/+merge/23098715:20
mzanettiright15:20
nik90hehe15:20
mzanettiwhat is checkbox btw?15:22
mzanettigoogling for checkbox only brings up the obvious, which I think is unrelated to this15:22
zygamzanetti: it's a testing application for ubuntu15:22
zygahttps://code.launchpad.net/checkbox-project/15:23
zygaer15:23
zygahttps://launchpad.net/checkbox-project/15:23
zygathe name is very old by now15:23
mzanettiso what is "a testing application" ? :D15:23
zygamzanetti: it's an application that you can feed some tests (manual or automatic) and execute15:24
nik90mzanetti: btw it is installed by default on the ubuntu desktop15:25
zygamzanetti: there's a UI to pick what you want to test and a large collection of existing tests for hardwre15:25
nik90mzanetti: search for system testing15:25
zyga(that UI is horrible, I take no responsibility ;)15:25
mzanettimy ubuntu desktop might be a bit special :D15:25
nik90lol15:25
* nik90 lols to both statements :P15:25
zygacheckbox-touch is just a new "sane" touch UI for phablets, later on we'll scale it for desktops and discard checkbox-gui (the thing that is preinstalled)15:26
zygaif you want to know more look at the diagram here: http://checkbox.readthedocs.org/en/latest/stack.html15:26
nik90zyga: enjoy https://code.launchpad.net/~nik90/checkbox/clean-qml-code/+merge/23099115:36
zyganik90: thank you :-)15:36
nik90yw15:36
bob__I've got a text file containing a hexdump that I want to byteswap15:52
bob__surely there is some nice command line tool to do this right?15:53
zygabob__: what's the word size?15:54
bob__2byte words15:54
zygabob__: I can write a py3k program that does that if you want15:57
bob__ahh no worries thanks15:57
zyganik90, mzanetti: so quick question to both of you: why should I (or should not) use a ColumnLayout inside a Page?15:57
mzanettizyga: you can... but you don't have to15:57
nik90zyga: you can, just that in your case you only had a label and a button15:57
zygain the end the code by nik90 didn't have the extra layout15:57
zygaah15:58
zygais there an implicit layout on the page?15:58
mzanettizyga: so what often happens is that you end up adding tons of anchors.whatnot properties15:58
mzanettizyga:  and with a Layout you can considerably simplify things15:58
zygaI see15:58
mzanettias nik90 said, with only 2 components its not a big deal15:58
zygaok15:58
zygathanks, I've merged your improvements in :)15:59
mzanettibut imagine having 5, you'd grow white hair typing all the anchors stuff15:59
zygacredits given :-)15:59
nik90hehe15:59
zygaI've pushed --overwrite over the original branch15:59
nik90zyga: if you have more components use a column and it will automatically adjust the height based on the visibility of each component.15:59
mzanettinik90: actually I'd say even ColumnLayout in this case16:00
mzanettinik90: because you can say Layout.fillWidth/Height on one of the items and it'll expand16:00
zygaoh, niec16:00
zyganice16:00
nik90mzanetti: I haven't used the Qt Layouts yet in my code, but that's looks great16:01
nik90will look into it16:01
zygaour UI is - so far - relatively simple, a few static screens, a few lists and a few interactions here and there16:01
mzanettinik90: with a Column you can't do that and often end up with weird "height: parent.height - something.height - somethingElse.height" constructs16:01
nik90mzanetti: yup16:01
zygashould I switch to the layout then? I wonder if I make the text very long, will it hide the button or not?16:02
mzanettizyga: well.. in your case it just doesn't make that much of a difference to bother right now :D I just added that comment so next UI you write you know the possibilties you have16:03
zygamzanetti: ok :)16:03
popeynik90: http://geoname-lookup.ubuntu.com/?query=Farnborough16:11
nik90popey: woohoo!16:11
nik90popey: I will fire up a click to test it16:12
nik90mhall119: hey, quick question. In http://geoname-lookup.ubuntu.com/?query=Springfield what entries do you need to different two springfield within the same state?16:18
popeyi looked through that and they have different names16:21
nik90popey: I notice that sometime admin1 or admin2 is empty. While at some times they are both there. This is not the fault of the server but rather the location.16:22
popeye.g. there's two in Virginia, Springfield and North Springfield16:22
nik90popey: actually there's 3 in Virginia16:23
nik90but in those cases, there is no need to differentiate since in Virginia the timezone will be the same16:23
popeyyeah, different names16:23
popeywest, north, and virginia16:23
popeyyou'd know which one you're in, surely?16:23
nik90exactly16:24
popeyTake me home, country road... West Virgina...16:24
* popey sings16:24
nik90hehe16:24
nik90I am bit confused at what to show..let me look at the old clock app code16:24
nik90how hard is it for people to come up with different names for cities16:25
popeyheh16:27
=== gatox is now known as gatox_lunch
nik90popey: added click to test. The design spec didn't include the admin1 and admin2 being shown. So I supervised a little.16:42
nik90popey: but that shouldn't be hard to change once we get design spec for that16:43
popeykk16:43
nik90mzanetti: hey, is there a way to stop QNetworkAcessManger's request? My usecase is that sometime the user clears the string which then default to local search mode. at that point any request being made should be stopped to save bandwidth.16:48
mzanettinik90: I think you can call cancel() on the QNetworkReply* you get as the return value of the get() call16:49
ybonpopey: as I see there is an ubuntu.com geoname server, what about a photon one? http://photon.komoot.de/ :)16:50
nik90mzanetti: ok16:50
popeyooh16:51
ahayzenpopey, thanks for the messages :)16:57
nik90ahayzen: which city do you live in?16:57
nik90sry just testing something :D16:57
ahayzennik90, at the moment Welwyn Garden City ...16:57
popeyahayzen: see the mail from jouni ? ☻16:58
ahayzennik90, when at university, Oxford16:58
nik90ahayzen: found it16:58
ahayzenpopey, errr... when was it sent?16:58
popey5 mins16:58
ahayzenpopey, ah my mail server is sometimes slow...or the gmail forwarder is16:58
popeyah16:58
* ahayzen blames google sending emails to NSA16:59
ahayzenpopey, did ms2 make the image? or is it in the next one?17:00
popeyno, not in teh current image17:00
* popey pops out, brb17:00
ahayzenok17:01
ahayzennik90, so what were you testing with my location?17:01
nik90ahayzen: online world city search in the clock reboot17:01
ahayzennik90, or are u just tracking my movements...17:01
ahayzennik90, \o/ cool was WGC in there then?17:02
nik90the latter would be a appropriate response...damn why i didnt say that17:02
nik90yup WGC was there ;)17:02
nik90I can't believe it found my parent's hometown as well..some remote place in india17:02
ahayzennik90, yey i sometimes have to search for luton or st albans if it can't find my hometown17:03
ahayzennik90, magic :) what service are you using?17:03
nik90ahayzen: http://geoname-lookup.ubuntu.com/?query=Springfield&release=utopic17:03
davmor2ahayzen: you didn't fool for that too did you that's both of us he's tracking ;)17:04
ahayzendavmor2, yeah i did :( 'testing clock-reboot' yeah right17:04
nik90davmor2: what's your town?17:04
ahayzennik90, was that an ubuntu subdomain before or did you request for it?17:04
nik90or u not gonna tell me17:04
nik90ahayzen: it is the same domain used by the ubuntu installer17:05
davmor2nik90: wolverhampton normally but currently I'm in shrewsbury17:05
ahayzennik90, that was gonna be my next question ;)17:05
nik90ahayzen: it is being there for a while by the looks...popey had to append data to it recently like the timezone info17:05
nik90davmor2: tracking you now17:05
ahayzennik90, seems to have found everything i've thrown at it so far17:06
nik90ahayzen: i know ... its pretty awesome.17:06
nik90weather app will also use it17:06
ahayzennik90, assume ur handling the case where multiple places come back from many countries?17:06
davmor2nik90: leek17:06
ahayzennik90, which fields are you showing in the UI?17:06
nik90ahayzen: I show the city name, state, country17:06
davmor2nik90: bishops castle17:06
ahayzennik90, cool17:06
davmor2nik90: wyre piddle17:07
davmor2nik90: wool17:07
davmor2nik90: brewood17:07
nik90davmor2: found all except for wyre piddle17:07
ahayzenpopey, just got the mail \o/17:07
davmor2nik90: https://maps.google.com/maps/u/0/ms?ie=UTF8&t=h&oe=UTF8&msa=0&msid=209408201867918462117.0004dfe5344545b9ace8f&dg=feature it exists though17:10
nik90davmor2: lol I didnt doubt you..17:10
* davmor2 files a bug that the clock can't find wyre piddle17:11
* nik90 is amused17:12
ahayzen_davmor2, trust you to break it ;)17:15
davmor2ahayzen_: it's what I do17:15
nik90davmor2: btw I always figured I can challenge you to find bugs in clock reboot...the above is not valid :D17:16
davmor2ahayzen_: there is upper and lower piddle too but those don't even show in google maps :D17:16
davmor2nik90: hahahahaha17:16
nik90davmor2: and already reported bugs don't countr17:16
nik90count*17:16
popey\o/17:16
nik90davmor2: so you see these recent blockers are a ploy to give me more time to fix stuff17:17
ybonthere is no Gyroscope sensor yet, right?17:17
ybonI just noticed that I've made a typo on Sensors Status, and using an Accelerometer in the Gyroscope page, shame on me; but now that I'm using a proper Gyroscope class, it doesn't seem connected to backend17:20
ybon(On Nexus 4)17:20
ybonttps://wiki.ubuntu.com/Touch/SdkFeatureStatus not listed at all, bad news17:21
popeyybon: one for tvoss i think.17:22
ybonk :)17:24
ahayzen_popey, do you know if jouni has access to real devices as the music-app has changed quite a bit to the official designs?17:25
ahayzen_popey, as in would it be worth sending screenshots to him of the current app and maybe the current bottom edge prototype as 'food for thought'17:26
popeyahayzen_:  he has one, yes17:27
ahayzen_popey, ok so he'll likely be on devel with it? so not far behind :) but won't know of our bottom edge ideas hehe17:27
popeyyeah17:28
ahayzen_popey, content-hub nearly worked lol saw all the models refresh but something bad happened17:30
popeygah, will you have time to debug that?17:30
ahayzen_popey, gonna try and get it working tonight :)17:31
popey\o/17:31
ahayzen_popey, it needed a merge of trunk anyway :P17:31
ahayzen_popey, if i ping u a click if i get it working will u be able to test it?17:32
popeyahayzen_: sure17:34
popeyahayzen_: do you use dropbox?17:34
ahayzen_popey, thanks :) ...damn internet keeps dropping out17:34
ahayzen_popey, no :/ i use gdrive or webdav17:35
ybonOn Tabs, how do I make that the default Tab is not the #1?17:35
popeyk17:35
popeynp17:35
ahayzen_popey, any particular reason? ;)17:36
popeyno, just that nik90 has shared a clock folder with me, when he drops a click in, i spot it, get notified17:39
=== gatox_lunch is now known as gatox
ahayzen_popey, oh cool17:40
* ahayzen_ thinks u can do the same with gdrive...u can share direct with people and 'notify by email'17:40
popeywhatever it easiest ☻17:41
ahayzen_popey, something to try later ;)17:41
ahayzen__popey, got it to play something \o/ just gotta tidy up a few things and check a few dialogues are working...but i'm going out to play badminton then have dinner so will bbl to finish it o/17:47
ahayzen__popey, good news is that no more tweaks are required by any upstream peeps17:47
popeykk17:57
popeynik90: http://popey.mooo.com/screenshots/device-2014-08-15-192225.png18:22
popeynik90: looks like you're using admin1 not admin2?18:23
nik90popey: no I use them conditionally. If admin1 is available I use that, if not I use admin2 and vice versa18:23
popeyah18:23
nik90popey: there is no space for both of them,18:23
popeyas you see, not ideal.18:23
nik90yeah18:24
nik90I will talk to giorgio on Monday to see if he is okay with 3 rows18:24
popeyhttp://popey.mooo.com/screenshots/device-2014-08-15-192502.png18:25
popey^ weather18:25
popeyalthough that's got the admin1 and admin2 round the wrong way really18:25
popeylocations are hard, lets go shopping!18:25
nik90hehe18:32
nik90I will give that a try18:32
nik90but I will have to truncate the text in the main clock page18:32
zygahey, I want to load a list of items in the background18:38
zygabut while it's loading I'd like to display a spinner18:38
zygaI think States are what I can use to achieve that18:38
zygais there an example in any of the core apps that I can look at18:38
zygaI have all the loading working, signals and all of that18:38
zygait's just the state manipulation + transitions + Page component that holds all of this that I'm not sure about18:39
mhall119kenvandine: can you help http://askubuntu.com/questions/511645/error-while-exporting-picture-through-content-hub18:56
kenvandinemhall119, sure18:59
kenvandinemhall119, answered19:03
mhall119thanks kenvandine19:04
kenvandinenp19:05
nik90zyga: rather than the core apps, I think best resource would be http://qt-project.org/doc/qt-5/qtquick-statesanimations-states.html19:08
zygathanks19:09
zygaI looked at that too19:09
zygaok, I'll give it a go19:09
zyganik90: what I'm after is some sensible transition19:09
zyganik90: (I got a "bink" transition working)19:09
zyganik90: something like one fades out and then the other fades in19:09
nik90zyga: oh like that19:10
zygasomething that feels nice19:10
nik90zyga: I can make a sample app to help with the transition effect.19:10
nik90zyga: that requires design mockup first though19:11
zyganik90: if you have time then sure, if you can just point me at something I'm okay with that too :)19:11
zyganik90: well, we have a design but we don't have transitions specified19:11
nik90zyga: afaik the core apps don't have state animations..we do have animation but they more behaviour animations.19:12
zyganik90: it's just a list of things to pick but there's a latency to initially load the list itself19:12
zygaahh19:12
zygaI know what you meant by design now19:12
zygadid you mean that there are no "stock" designs for that that can be just used19:12
zyga?19:12
nik90yes, you can implement this in a variety of ways19:12
nik90zyga: best way would be to have a state that gets triggered when: loaded, and then do a property change of a UI element to change its opacity from 0 to 119:13
* zyga tries19:13
nik90zyga: you can then add a Behavior on Opacity { UbuntuNumberAnimation{} } which fades the element in and out gracefully19:14
zygathanks, I'll give that a try19:17
nik90popey: found a smarter way to fix the issue :)19:56
nik90popey: in the place where you search for cities, I show all the info (name, admin1, admin2, country) to avoid showing duplicate results.19:56
nik90popey: in the main clock page however I only show name, admin2, country19:57
ahayzen__nik90, i see the indicator-datetime bugs we were talking about earlier made the blocker list :/20:10
nik90ahayzen__: yeah :/20:11
ahayzen__nik90, slightly better news is i think i've got content-hub working for music-app :)20:11
nik90ahayzen__: wow that's awesome20:11
nik90ahayzen__: for importing music?20:11
ahayzen__nik90, just got one weird thing happening where u correctly go to the now playing then u incorrect get jumped back to the start20:12
ahayzen__nik90, yeah :)20:12
ahayzen__nik90, eg download a mp3 from the web browser and import then plays in music app :)20:12
nik90ahayzen__: does that mean the scopes like grooveshark will play in the music app now? or that is restricted by them?20:13
ahayzen__nik90, err i don't think so we are just a destination for when u get the 'Open With' dialogue20:13
ahayzen__nik90, for music20:13
nik90ahayzen__: ah like when download music from the browser. cool20:14
ahayzen__yep20:14
nik90popey: btw I updated the clock reboot in the store. pls approve when you have time. It has the custom alarm sound and the online world city search MPs as well.20:15
ahayzen__nik90, would export support be any use to u after rtm?20:15
nik90ahayzen__: yes20:15
nik90ahayzen__: for choosing a custom ringtone perhaps?20:15
ahayzen__nik90, eg being able to pick a mp3 for an alarm or something20:15
nik90yup exactly20:15
ahayzen__nik90, :)20:15
ahayzen__nik90, we have a bug for export but currently we are looking at doing after rtm20:16
ahayzen__nik90, just trying to think of use cases for it20:16
nik90ahayzen__: yeah I need to figure how to import the music from the music app :) but post-rtm it is20:16
ahayzen__nik90, yeah we'll be able todo that20:16
nik90ahayzen__: hey would you have time in the weekend to 1-2 reviews?20:17
ahayzen__nik90, maybe maybe not....i probably have a bit of time tonight inbetween writing ap tests20:17
ahayzen__nik90, add me as a reviewer and i'll do them if i have time :)20:18
nik90ahayzen__: ok20:18
ahayzen__nik90, ur asking me to review c++ code? ;)20:25
nik90ahayzen__: that's 6-10 lines of c++ code...sure :P20:25
* zyga can help :-)20:25
ahayzen__nik90, hah but i haven't done my c/c++ module yet ;) hehe ... that starts in september \o/20:26
ahayzen__nik90, no i've done C before it should be fine :) as u said only 6-10lines20:26
nik90zyga: its all QML except for 8 lines of C++ code :D. Have at it if you want https://code.launchpad.net/~nik90/ubuntu-clock-app/json-search-ui/+merge/23033920:27
=== nik90 is now known as nik90|Dinner
* zyga is better with C than QML20:29
zygathe C++ parts are a bit verbose20:32
nik90|Dinnerzyga: ah thnx. I will fix the inline comments20:50
zyganik90|Dinner: :-)20:54
zyganik90|Dinner: my pleasure20:54
zyganik90|Dinner: I'm not quite sure what's the Qt version of asnpritf is, what's the "pure" way to do string formatting20:55
=== nik90|Dinner is now known as nik90
zyganik90: I guess http://qt-project.org/doc/qt-5/qstring.html#arg20:55
zyganik90: so you can replace all of those + + with arg for easier reading20:56
nik90zyga: ah yes20:56
zygathough I suspect that proper, trully-type-safe version is not in until c+11 can be used20:56
zygabut whatever20:57
zygaQt was always on the borderline :)20:57
nik90:D20:57
popeynik90: will do21:02
popeynik90: approved21:03
nik90popey: thnx21:03
nik90zyga: I couldn't do if(admin1) since it says cannot convert QString to bool. I guess I have to to do admin1.isEmpty()21:04
zyganik90: yeah, I'm not a Qt developer so that code was more of a "guide" than a copy-paste solution21:04
nik90zyga: I was hoping Qt C++ would support.. I guess not21:05
nik90zyga: btw I don't check for country, since it was always available...should I still check to make sure?21:05
zyganik90: well, it depends on what you want21:06
zyganik90: what does asString() do when the json has some other type/value21:06
zyganik90: does it return empty strings or raises exceptions?21:07
zygabrb21:07
nik90zyga: asString() ?21:08
nik90zyga: well I explicit do the conversion toString(), if it can't I suppose it will raise an error21:08
nik90zyga: actually if QVariant cannot return to QString() it return an empty string according to the documentation21:09
nik90zyga: which if happens then I will "admin1, admin2,  "21:10
nik90where country is blank21:10
DanChapmannik90, howdy :-) I just had a cheeky peek at your jsontimezonemodel. One thing that's comes to my mind, are you always *guaranteed* to get a reply when requesting the url? As you have no handling there in the case of a QNetworkReply::NetworkError21:29
mzanettiogra_: hey, BlueBox doesn't seem to start any more21:30
nik90DanChapman: It comes from http://geoname-lookup.ubuntu.com/ which can go down. So yes I suppose I should add a handling for NetworkError.21:30
mzanettinik90: oops. sorry.. I missed that in the review21:33
DanChapmannik90 cool :-), thought i should double check.21:34
nik90mzanetti: ah don't worry. I suppose I will have to have another variable called error that I track in qml? If(error) display message21:34
nik90DanChapman: thnx for the catch :-)21:34
mzanettinik90: no... you can check the status in the finished slot21:34
mzanettiah right... yes...21:35
mzanettiI guess a propoerty status should do21:35
nik90mzanetti: similar to the loading property we have21:35
mzanettiwhich you change to Loading, Ready, Error21:35
mzanettiyeah, just make it an enum instead of a bool21:35
mzanettiso you can easily bind something to it...21:35
mzanettie.g. Label { text: "D'oh"; visible: model.status == TimezoneModel.Error }21:36
nik90mzanetti: ooh that will be cool21:36
mzanettiand ActivityIndicator { visible: model.status == TimezoneModel.Loading }21:37
* DanChapman is a fan of enums in qml21:37
nik90mzanetti: I will have to figure out how to use the enum in the c++ code21:37
DanChapmannik90, you just have to register it with Q_ENUMS and i presume you have already registered the TimeZOnemodel as a qml type21:38
nik90DanChapman: yeah I do..well the JsonTimeZoneModel atleast.21:38
nik90TimeZoneModel is a base class we derive from21:39
mzanettinik90: I suggest you add the enum in your base timezonemodel as in theory you can use the error state in all of them21:39
nik90mzanetti: ok21:40
mzanettiactually the whole property should be in the base class, so you don't have to duplicate that code in all models21:40
nik90mzanetti: yes, I will Q_ENUMS as a property in the base class and define enums {loading, ready, error} in proctected so I can use it in the derived classes21:41
nik90like this http://qt-project.org/doc/qt-5/qobject.html#Q_ENUMS I suppose21:41
mzanettinik90: what I meant is to also have the Q_PROPERTY(Status ...) in the base timeZonemodel21:42
nik90mzanetti: ah, will do21:42
mzanettiand a protected function setStatus(Status) in there which sets the property and does the emit21:42
mzanettithen you can just do setStatus(blabla) in the subclasses and that's it21:42
nik90mzanetti: that should be Q_ENUMS(Status) -> enum Status {Loading, Error, Ready} ?21:43
mzanettiyep21:43
nik90ok21:43
nik90I will have a separate MP for this since it touches all the timezone classes. Dont want to break everything here :)21:44
ogra_mzanetti, none  of the webkit apps start anymore ... there is a bug open about it22:36
=== salem_ is now known as _salem
ybonpopey: http://imgur.com/a/gQ3K9 #teasing23:44
ybon(but now one week of boat \o/)23:44

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!