| === greyback__ is now known as greyback | ||
| Cimi | morning | 07:19 |
|---|---|---|
| Cimi | Saviq, wohoo https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/919/ | 07:31 |
| mzanetti | Saviq: hey, do you know where I can get a Ubuntu One staging account? | 08:09 |
| Saviq_ | mzanetti, https://login.staging.ubuntu.com/ | 08:16 |
| Saviq | Cimi, yeah, I know... worst thing is this was weird because of a duplicate name: in CardTool's test... | 08:17 |
| Saviq | dandrader, thanks for your review and sorry for you having to look at this mess, it was a witch hunt initially 'cause of the dupe name: | 08:21 |
| Saviq | Cimi, re: can we have a card without a title, for real, no, but the code was triggered when templates and components were empty (so we might hit it on startup) | 08:24 |
| dandrader | Saviq, I figured you must have been too tired when you wrote it as it was quite late :) | 08:26 |
| Saviq | dandrader, yeah, and I was hunting for the actual failure because obviously it wasn't reproducible locally (when it really was, only different test suite :P) | 08:27 |
| Saviq | MacSlow, hey, what's the state of the fix for bug #1354406 ? | 08:31 |
| ubot5 | bug 1354406 in unity8 (Ubuntu) "PIN-locked phone becomes unresponsive after simultaneous alarms" [High,In progress] https://launchpad.net/bugs/1354406 | 08:31 |
| Cimi | Saviq, which timezone are you working? :) | 08:40 |
| Saviq | Cimi, ALL OF 'EM | 08:41 |
| Saviq | sometimes | 08:41 |
| Cimi | hah | 08:41 |
| Cimi | Saviq, alt nav requires a test though | 08:42 |
| Saviq | Cimi, yeah, just getting on that | 08:42 |
| dandrader | greyback, should I report a bug on mir asking for the surface type to be passed to PlacementStrategy::place()? | 08:53 |
| mzanetti | dednick: hey. I'd need help on trusted sessions | 08:56 |
| mzanetti | have a minute? | 08:56 |
| mzanetti | might be an hour though :D | 08:56 |
| greyback | dandrader: sure | 08:57 |
| Cimi | Saviq, https://code.launchpad.net/~saviq/unity8/preview-customizations/+merge/230736 | 08:57 |
| dednick | mzanetti: sure | 08:57 |
| Saviq | Cimi, nope | 08:57 |
| mzanetti | dednick: ok.. there's this bug that promptsessions are removed on focus change | 08:57 |
| mzanetti | dednick: I tracked it down to platforms/mirserver/promptsessionlistener.cpp | 08:57 |
| Saviq | Cimi, if (item.hasOwnProperty("scopeStyle")) item.scopeStyle = root.scopeStyle; | 08:57 |
| mzanetti | dednick: PromptSessionListener::prompt_provider_removed is called | 08:58 |
| mzanetti | dednick: but from here I'm not sure where to go | 08:58 |
| dednick | mzanetti: "bug" | 08:59 |
| dednick | ? | 08:59 |
| mzanetti | dednick: so what happens is that such a prompt session is opened | 08:59 |
| dednick | mzanetti: it's a "feature" actually | 08:59 |
| mzanetti | oh | 08:59 |
| Saviq | Cimi, hmm or by now all of them have one indeed | 08:59 |
| Saviq | Cimi, fixing | 08:59 |
| mzanetti | dednick: so opinions seem to differ on that: https://bugs.launchpad.net/qtmir/+bug/1355173 | 08:59 |
| dednick | mzanetti: prompt sessions are explicitly cancelled by qtmir when focus is switched | 09:00 |
| ubot5 | Ubuntu bug 1355173 in QtMir "Switching windows with a Trusted Prompt Session active looses the trusted prompt session" [Critical,New] | 09:00 |
| dednick | mzanetti: perhaps we don't want it anymore though | 09:00 |
| mzanetti | dednick: dunno... I got assigned this bug... I said I've no clue what's going on but I will look at it | 09:01 |
| dandrader | greyback, I meant the surface state. but having also surface type might be good as well | 09:01 |
| greyback | dandrader: the more info the better IMO | 09:01 |
| dandrader | yeah | 09:01 |
| mzanetti | dednick: hmm... so assuming this is the wanted behavor | 09:02 |
| mzanetti | dednick: should the thing that opens the trusted session be informed? | 09:02 |
| mzanetti | dednick: tedg says that the app still thinks the prompt is shown, its just visually not there any more | 09:02 |
| dednick | mzanetti: have you read the bug comments? :) | 09:02 |
| mzanetti | err, yes... | 09:02 |
| mzanetti | did I miss something? | 09:03 |
| * mzanetti rereads | 09:03 | |
| dednick | mzanetti: well, it explains things there. not a solution though | 09:03 |
| mzanetti | oh I see | 09:03 |
| mzanetti | right... so this needs to be removed (at least for now) I guess | 09:03 |
| dednick | mzanetti: teds problem is that the payments is not complete enough to deal with the behaviour | 09:04 |
| mzanetti | dednick: well, rather online accounts is not complete enough | 09:04 |
| mzanetti | but yes | 09:04 |
| dednick | mzanetti: so yeah. let me get a codepoint for you | 09:04 |
| dednick | mzanetti: anything that calls: | 09:05 |
| dednick | :/ | 09:05 |
| dednick | fek | 09:05 |
| dednick | http://bazaar.launchpad.net/~mir-team/qtmir/trunk/view/head:/src/modules/Unity/Application/application.cpp#L439 | 09:05 |
| dednick | mzanetti: ^ | 09:05 |
| dednick | actually, probably only the application::setState | 09:06 |
| mzanetti | I see | 09:06 |
| dednick | still want to close on app destruction | 09:06 |
| mzanetti | ok... I know my way around in applicationmanager... thank... I tought that call would come from mir | 09:06 |
| dednick | mzanetti: goes to mir | 09:07 |
| mzanetti | oh ok... explains things | 09:07 |
| dednick | mzanetti: generally unity8 shouldn't be worrying about stopping prompt sessions, but this was a requested feature for the time being | 09:08 |
| mzanetti | so I guess the "solution" for now is just to comment away that soptPromptSession call and add a FIXME on top to reenable it when UOA is ready for trusted sessions | 09:09 |
| * mzanetti tries | 09:09 | |
| dednick | mzanetti: yep. think so. although not sure how this is going to affect other things. | 09:09 |
| dandrader | greyback, https://bugs.launchpad.net/mir/+bug/1357259 | 09:09 |
| ubot5 | Ubuntu bug 1357259 in Mir "PlacementStrategy::place() should be given the surface type and state" [Undecided,New] | 09:09 |
| mzanetti | dednick: well, I think this is the only place that uses trusted session yet | 09:09 |
| mzanetti | or do you know about others? | 09:10 |
| greyback | dandrader: ta | 09:10 |
| dednick | mzanetti: it was more of a "guard" than a feature. since some prompt helpers may not support dealing with more than one prompt request at a time. | 09:10 |
| mzanetti | hmm... ok | 09:10 |
| dednick | mzanetti: actually, i think a number of things do. camera, maps, etc. | 09:10 |
| mzanetti | dednick: maps? | 09:11 |
| dednick | resource access requests. location-services to be exact. | 09:11 |
| mzanetti | we have maps? | 09:11 |
| dednick | osmtouch. | 09:11 |
| dednick | open street maps | 09:11 |
| dednick | mzanetti: browser google maps as well. | 09:11 |
| mzanetti | indeed... | 09:11 |
| mzanetti | the camera does | 09:11 |
| mzanetti | now that you say it, the dialog slides in from the bottom instead of just appearing | 09:12 |
| dednick | mzanetti: what is the camera requesting? | 09:12 |
| * mzanetti retries | 09:12 | |
| mzanetti | hmm... its gone | 09:12 |
| mzanetti | I think it was location | 09:13 |
| dednick | yeah, i think it only asks once, then remembers | 09:13 |
| mzanetti | I declined it, won't come back | 09:13 |
| mzanetti | so that means no geolocation for me any more until I --wipe the phone? | 09:14 |
| dednick | mzanetti: hm. there's a file you can delete which makes it ask again, but can't remember now. | 09:14 |
| mzanetti | heh | 09:14 |
| mzanetti | ok... no worries.. I don't think my camera should access GPS anyways | 09:14 |
| dednick | mzanetti: yeah, it's per app i think | 09:15 |
| dednick | mzanetti: but a way to test if it still works after removing the stop, is to try get two prompts on the screen at the same time for different apps | 09:18 |
| dednick | like one for camera and one for osmtouch. | 09:18 |
| mzanetti | I c | 09:18 |
| mzanetti | ok | 09:18 |
| dednick | mzanetti: but to be fair, i don't think that's as important as getting payments to work :) | 09:18 |
| mzanetti | yeah... I agree | 09:19 |
| dednick | i like money | 09:19 |
| dednick | although not giving it away | 09:19 |
| mzanetti | :D | 09:19 |
| mzanetti | yeah... so far I definitely made more money with apps then spent on them :D | 09:20 |
| mzanetti | still not much :D | 09:20 |
| Saviq | Cimi, pushed alt nav test | 09:34 |
| Cimi | Saviq, thx | 09:34 |
| Saviq | ah, wait, want to add another one | 09:34 |
| mzanetti | dednick: any chance you remember which file it is? can't find it | 09:42 |
| mzanetti | the one to reactivate the camera app's promptsession | 09:42 |
| dednick | mzanetti: uuu. give me a minute. i'll try find it. lost my note :( | 09:43 |
| dednick | mzanetti: rm -rf ~/.local/share/UbuntuLocationService | 09:46 |
| mzanetti | uh... interesting | 09:46 |
| dednick | mzanetti: think you need to restart the trust-store after that | 09:46 |
| dednick | mzanetti: presumably there will be a settings page where you can change these things at some point. | 09:48 |
| mzanetti | dednick: just figured there is a setting in the camera app | 09:49 |
| mzanetti | dednick: but once you declined that popup it breaks the setting | 09:49 |
| dednick | mzanetti: there might be one for camera as well. | 09:49 |
| dednick | not sure | 09:49 |
| dednick | i think it's per service rather than per type | 09:49 |
| dednick | mzanetti: per server per app i mean | 09:50 |
| dednick | mzanetti: it's a db lookup. servce->app = [yes/no] i think | 09:51 |
| dednick | so location->camera, or location->osmtouch | 09:51 |
| Saviq | Cimi, done | 09:53 |
| mzanetti | dednick: sqlite3 on that file and "delete from requests" does the job without restarting anything | 09:59 |
| mzanetti | well, restarting the camera-app ofc | 09:59 |
| dednick | mzanetti: cool | 10:00 |
| Saviq | mzanetti, bug #1357230 is without a pass / pin lock? | 10:09 |
| ubot5 | bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,New] https://launchpad.net/bugs/1357230 | 10:09 |
| mzanetti | Saviq: yep | 10:10 |
| mzanetti | dednick: yeah... as suspected, there are issues with the use case you said | 10:11 |
| mzanetti | expected | 10:11 |
| === shiznix_ is now known as shiznix | ||
| mzanetti | dednick: https://code.launchpad.net/~mzanetti/qtmir/workaround-1355173/+merge/230952 | 10:22 |
| mzanetti | dednick: thanks for your help | 10:24 |
| dednick | mzanetti: no worries. just want to talk to tvoss about it first. maybe something can be done about the multiple app thing at the same time. | 10:26 |
| mzanetti | dednick: yep | 10:26 |
| === dandrader is now known as dandrader|afk | ||
| greyback | dednick: am reviewing your prompt-surface-model stuff, it wouldn't be in a silo by any chance? | 10:30 |
| dednick | greyback: not yet. if you code review, can get a silo i guess | 10:33 |
| Saviq | paulliu, hey, I put a hopefully final review comment on your reboot branch | 10:41 |
| greyback__ | sodding wifi | 10:50 |
| mzanetti | greyback__: fair point... but I guess it might be not that easy to convert UOA to trust sessions | 10:57 |
| mzanetti | greyback__: but I don't agree that the "new" issue is as bad as the "old" one | 10:58 |
| Saviq | greyback__, can get it in 17 for you | 10:58 |
| Saviq | greyback__, assuming it can land soonish? | 10:58 |
| * greyback__ popular all of a sudden | 10:58 | |
| mzanetti | greyback__: chances are like 0 that you open two apps with the location question without confirming/declining it first | 10:59 |
| greyback__ | Saviq: no, I was just being lazy and hoping packages existed | 10:59 |
| mzanetti | greyback__: while chances that you click on install on an app before having set up your UOA account are much bigger | 10:59 |
| Saviq | greyback__, https://code.launchpad.net/~nick-dedekind/unity8/prompt-surface-model/+merge/230813/comments/561274 | 10:59 |
| Saviq | http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1010/artifact/work/output/*zip*/output.zip | 10:59 |
| greyback__ | Saviq: yes but for unity8 whic also changes | 11:00 |
| greyback__ | mzanetti: I don't like introducing one bug to fix another. | 11:00 |
| greyback__ | there must be a better option | 11:00 |
| Saviq | greyback__, does not compute, but also for qtmir you'd need to request they collect the packages, not sure why it doesn't | 11:01 |
| greyback__ | Saviq: oh sorry, I misread the link. Thought you were pointing me to qtmir packages which do build | 11:01 |
| Saviq | @unity, need volunteers for https://code.launchpad.net/~unity-team/unity8/seeLessStuckBottom/+merge/230948 https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 | 11:01 |
| mzanetti | mardy: hey, what's your opinion on https://bugs.launchpad.net/ubuntu-system-settings-online-accounts/+bug/1355173 ? | 11:06 |
| ubot5 | Ubuntu bug 1355173 in QtMir "Switching windows with a Trusted Prompt Session active looses the trusted prompt session" [Critical,New] | 11:06 |
| mzanetti | mardy: is there already some work ongoing to convert the UOA setup to a trusted prompt session? | 11:06 |
| mardy | mzanetti: it's in silo 13, we are testing it | 11:07 |
| mzanetti | oh! | 11:08 |
| mzanetti | that's good news | 11:08 |
| mardy | mzanetti: thanks for pointing me to that bug report, I was not aware of that | 11:08 |
| mzanetti | mardy: well, we just figured an hour ago that this is actually the issue | 11:08 |
| mzanetti | :) | 11:08 |
| mzanetti | at least I did | 11:08 |
| mzanetti | dednick: ^^ Hold off t | 11:08 |
| mzanetti | dednick: so seems the workaround is not required after all | 11:09 |
| === dandrader|afk is now known as dandrader | ||
| dednick | mzanetti: ah. ok. awesome! | 11:09 |
| mardy | mzanetti: wait a second, are we talking of one trusted session, or of two? | 11:10 |
| mzanetti | ? | 11:10 |
| mzanetti | mardy: err... one I guess | 11:10 |
| dednick | mzanetti: i got to go out for a bit. continue later. your solution has unfortunately been rejected. :) | 11:10 |
| mardy | mzanetti: OK, so the parties involved are only the client application and OA, right? | 11:10 |
| mzanetti | mardy: hmm... no | 11:11 |
| mzanetti | mardy: dash opens payment ui | 11:11 |
| mzanetti | mardy: payment ui opens UOA | 11:11 |
| mzanetti | but I don't think that should affect you... | 11:11 |
| dandrader | Saviq, I'll take https://code.launchpad.net/~unity-team/unity8/seeLessStuckBottom/+merge/230948 | 11:11 |
| Saviq | dandrader, thanks | 11:12 |
| mardy | mzanetti: does dash use a trusted session to open the payment UI? | 11:12 |
| mzanetti | mardy: yes | 11:12 |
| mardy | mzanetti: mmm... then we have two trusted sessions, because OA will also create its own | 11:12 |
| mzanetti | mardy: yeah... but unity can deal with that... not sure if UOA even knows about it | 11:13 |
| mardy | mzanetti: OA will create a trusted session having the payment UI as initiator, and the OA UI as dialog | 11:13 |
| mardy | mzanetti: ah OK, that's fine. No, OA won't know about it | 11:13 |
| dandrader | Saviq, But I will need your help. What's this "See less" thing? | 11:13 |
| Saviq | dandrader, expansion button below categories | 11:13 |
| Saviq | dandrader, let me find a scope for you :) | 11:13 |
| Saviq | dandrader, start unity8-dash BINARY=$PWD/builddir/src/Dash/unity8-dash ARGS=-mousetouch | 11:14 |
| dandrader | Saviq, yeah, I was looking for such buttons yesterday evening but couldn't find any in the UI | 11:14 |
| Saviq | dandrader, bottom-swipe to overview, go to Yahoo | 11:15 |
| dandrader | Saviq, right. see them there | 11:15 |
| Saviq | mzanetti, can I bother you for https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 | 11:16 |
| mzanetti | Saviq: yeah... didn't do my daily review today yet | 11:17 |
| Saviq | mzanetti, pushed a small fix there | 11:20 |
| mzanetti | ok | 11:20 |
| dandrader | mzanetti, speaking of which, https://code.launchpad.net/~dandrader/unity8/lifecycle/+merge/230090 has been updated as per your feedback :) | 11:20 |
| mzanetti | ok | 11:20 |
| Saviq | dandrader, you too, just pushed a s/"grey"/palette.baseText/ to seeLessStuckBottom | 11:21 |
| mzanetti | Saviq: is the right-edge-ppa still in use? | 11:21 |
| Saviq | mzanetti, no, it's all yours | 11:22 |
| mzanetti | cheers | 11:22 |
| mzanetti | Saviq: btw... regarding the hotfix for the user testing... I guess we should properly fix that behavor? | 11:22 |
| Saviq | mzanetti, yeah, please file a bug with ubuntu-ux and assign Vesa | 11:23 |
| Saviq | mzanetti, there's probably a few more cases where we need to have a closer look at this | 11:23 |
| mzanetti | mhm | 11:23 |
| mzanetti | ok | 11:23 |
| Saviq | /somefood | 11:23 |
| mzanetti | vesar: https://bugs.launchpad.net/ubuntu-ux/+bug/1357333 | 11:26 |
| ubot5 | Ubuntu bug 1357333 in Unity 8 "Launcher shouldn't hide on long left edge swipes in some circumstances" [Undecided,New] | 11:26 |
| mzanetti | I guess we should talk about this in our next weekly | 11:26 |
| dandrader | greyback_, https://code.launchpad.net/~dandrader/qtmir/lifecycle/+merge/230092 is updated. needs your review | 11:36 |
| greyback_ | dandrader: ack | 11:36 |
| facundobatista | Holas | 11:37 |
| Cimi | Saviq, http://paste.ubuntu.com/8053056/ | 11:39 |
| Cimi | Saviq, I think it looks fine, tested with all grey/all red and normal | 11:39 |
| Cimi | Saviq, we can tweak shade values a little when we will have real scopes to test | 11:39 |
| Saviq | Cimi, we have real scopes to test | 11:41 |
| Saviq | Cimi, just go to the overview, All | 11:42 |
| Saviq | Cimi, "#B2FFFFFF" | 11:42 |
| Saviq | Cimi, k, I'm applying that to my branch then | 11:43 |
| Cimi | Saviq, that was opacity of white line? | 11:44 |
| Saviq | Cimi, yes | 11:44 |
| Cimi | Saviq, 0.7 alpha? | 11:44 |
| Saviq | Cimi, yeah | 11:45 |
| Cimi | ok | 11:45 |
| Cimi | Saviq, ok so in the patch, you can try Qt.rgba(1.0, 1.0, 1.0, 1.0) instead 0.7 | 11:45 |
| Cimi | or maybe something little bit more, 0.8 | 11:45 |
| Cimi | which them multiplies for 0.6 global opacity of the rectangle | 11:46 |
| Cimi | I think 0.7 was too much on dark colours | 11:46 |
| Saviq | Cimi, it doesn't work with a solid background unfortunately, z-ordering is bad between header and content, need to talk with Albert about htis | 11:46 |
| Saviq | Cimi, the rectangle is full opacity | 11:46 |
| Saviq | ah there | 11:46 |
| Saviq | no it's not ok | 11:46 |
| Cimi | Saviq, the opacity of the divider is full because we have full color here, no? | 11:47 |
| === MacSlow is now known as MacSlow|lunch | ||
| Saviq | Cimi, it's full because we want it to be full | 11:47 |
| Cimi | Saviq, anyway you got the point of color manipulating | 11:48 |
| Cimi | we can always tweak them later | 11:48 |
| Saviq | Cimi, it's not like "I didn't get the point" ;) | 11:48 |
| Cimi | yeah whatever :) | 11:48 |
| Saviq | Cimi, it's "I GOT A DESIGN THAT DIDN'T HAVE IT" :P | 11:48 |
| Saviq | and even explicitly asked about it | 11:49 |
| Saviq | Cimi, if I"m honest, this doesn't work too well with any coloured divider, let me get you some shots | 11:50 |
| pete-woods | Saviq: if we release the new scopes (and shell plugin) to RTM, will that upset the version of unity8 in RTM? (i.e. does it have the v4 shell API there) | 11:52 |
| Saviq | pete-woods, it does, yes, and scopes shell, too | 11:52 |
| Saviq | pete-woods, I landed that in rtm | 11:52 |
| pete-woods | Saviq: awesome, thanks! | 11:53 |
| Saviq | Cimi, check out the "Zrzut ekranu..." ones in https://drive.google.com/drive/#folders/0B32jwBcbaPloR1IyRF91ZWs0bFE | 11:53 |
| Saviq | amazon looks ~ok | 11:53 |
| Cimi | I have those | 11:53 |
| Saviq | Cimi, k wait for it | 11:54 |
| Cimi | Saviq, what's wrong with those? | 11:54 |
| Saviq | Cimi, please tweak these to your liking http://paste.ubuntu.com/8053144/ | 11:55 |
| Cimi | Saviq, you want more contrast? | 11:55 |
| Saviq | Cimi, I can't see the inset at the top TBH | 11:55 |
| === alan_g is now known as alan_g|lunch | ||
| Saviq | mzanetti, with all your SIM cards, can you please have a look at bug #1357321 | 12:02 |
| ubot5 | bug 1357321 in Unity 8 "scope images do not load in HSDPA or 3G" [Undecided,Confirmed] https://launchpad.net/bugs/1357321 | 12:02 |
| mzanetti | ok | 12:02 |
| Cimi | Saviq, I bumped to http://paste.ubuntu.com/8053224/ | 12:05 |
| Saviq | Cimi, my diff was different, please rebase | 12:06 |
| Saviq | Cimi, no need to put it in the bottom container | 12:06 |
| Saviq | Cimi, http://paste.ubuntu.com/8053144/ | 12:06 |
| Cimi | Saviq, I prefered it as before for the normal headers, but this should work lil better with other combinations | 12:06 |
| Cimi | Saviq, just change 1.08 to 1.1 maybe? | 12:07 |
| Cimi | try it | 12:07 |
| Cimi | it's tastes... | 12:07 |
| Saviq | Cimi, that feels negligible | 12:07 |
| Cimi | Saviq, I see the difference :) | 12:07 |
| Cimi | Saviq, better than 1.08 | 12:08 |
| Saviq | Cimi, yeah, indeed | 12:08 |
| Cimi | Saviq, we can always tweak them next week | 12:08 |
| Saviq | Cimi, pushed | 12:08 |
| Cimi | I'm coming too if you are there | 12:09 |
| Saviq | uh oh | 12:09 |
| Saviq | ah, building helps | 12:10 |
| Saviq | ugh no it doesn't | 12:12 |
| Saviq | Cimi, it's actually slightly more complex in the nav branch, but I'll manage | 12:16 |
| Saviq | facundobatista, let's do it here | 12:17 |
| Saviq | facundobatista, somehow I'm getting a art:mascot mapping for recommendations | 12:17 |
| Saviq | facundobatista, and yes, no art == breakage | 12:18 |
| Saviq | so no title either | 12:18 |
| facundobatista | Saviq, the client scope scope may be changing it, in the log is clear that the server is returning art=art | 12:19 |
| Saviq | facundobatista, yeah, sure, as if I change the mapping to art:art in the scope tool, it works | 12:20 |
| Saviq | facundobatista, so unity-scope-scopes? | 12:20 |
| facundobatista | Saviq, the "related search" case is different, though... the server is returning mascot=mascot in the category, and a mascot in the result, but empty :/ | 12:20 |
| facundobatista | this is a server issue! | 12:20 |
| Saviq | I knew it! ;) | 12:20 |
| facundobatista | it's ok if in that case I return a mascot in the result (with a proper image) and mascot=mascot in the category component mapping? | 12:21 |
| Saviq | "art": { | 12:21 |
| Saviq | "field": "mascot", | 12:21 |
| Saviq | facundobatista, ↑ breakage | 12:21 |
| facundobatista | Saviq, yes, that breakage is in the recommendations | 12:21 |
| Saviq | facundobatista, it's like so: mascot is something the shell looks at, and the plugin maps from result based on the mapping | 12:22 |
| dandrader | Saviq, once dash loads a scope, it will never unload it? | 12:22 |
| Saviq | dandrader, the *dash* will not | 12:22 |
| Saviq | dandrader, overview will, as it destroys the temporary pages | 12:23 |
| Saviq | facundobatista, so whatever you set the mapping as, the plugin will try and map from the result to show the shell | 12:23 |
| dandrader | Saviq, what's overview? that thing from where you can access all scopes? | 12:23 |
| Saviq | dandrader, yes ;) | 12:23 |
| Saviq | facundobatista, so if you want the mascot in the shell to display what you send in the "mascot" field in the result | 12:23 |
| Saviq | facundobatista, you want mapping to be mascot:mascot indeed | 12:24 |
| facundobatista | right | 12:24 |
| facundobatista | thanks | 12:24 |
| Saviq | facundobatista, are you sending overlay color at all or are we fine with the 15% black we have everywhere? | 12:29 |
| facundobatista | Saviq, I think we're ok | 12:30 |
| Saviq | facundobatista, I'll drop the mapping then | 12:30 |
| facundobatista | Saviq, btw, don't bother about the URL I requested, I see oopses from what you surely tried (scopes scopes previews from PL) | 12:30 |
| Saviq | facundobatista, you got me ;) | 12:30 |
| Saviq | facundobatista, re: previews for results, I was told that there should be no preview for anything other than scopes, we'd have to clarify that | 12:32 |
| Saviq | facundobatista, the other thing I just read... "Note - the search results page uses a dark theme but any subsequent screens (including previews) are in the standard theme." | 12:33 |
| Saviq | that's not possible (for preview to be in a different theme than search page) | 12:33 |
| Saviq | so let's ignore that for now ;) | 12:33 |
| facundobatista | ok | 12:35 |
| Saviq | facundobatista, https://code.launchpad.net/~saviq/unity-scope-scopes/fix-overview-search-mapping/+merge/230966 | 12:37 |
| greyback | tedg: just an FYI, I've an MR up with basic LTTng tracepoints added. It'll take me more time however to actually see what might be slow | 12:42 |
| greyback | https://code.launchpad.net/~gerboland/qtmir/lttng/+merge/230967 | 12:43 |
| greyback | here is output from one test run: http://pastebin.ubuntu.com/8053449/ | 12:44 |
| === alan_g|lunch is now known as alan_g | ||
| Saviq | Cimi, hmm is the bottom highlight supposed to be over the divider still or below it, over the content? | 12:56 |
| Saviq | inside | 12:57 |
| Saviq | aaand remerge | 12:57 |
| Saviq | oh crap really? | 12:58 |
| Saviq | Notification center? | 12:58 |
| Saviq | mzanetti, how's that going to be in german ↑? | 12:58 |
| Saviq | seb128, french ↑? | 12:59 |
| * Saviq foresees ellipses | 13:00 | |
| seb128 | Saviq, Centre de notifications | 13:00 |
| Saviq | *maybe* | 13:00 |
| seb128 | I bet german is longer ;-) | 13:00 |
| Saviq | weeell must be someone thought it through, right? | 13:01 |
| mterry | MacSlow|lunch, poke, for when you get back, about notifications and placement on screen | 13:01 |
| Cimi | Saviq, I think should be over the content | 13:17 |
| Saviq | Cimi, then dots are not centered vertically | 13:17 |
| Cimi | Saviq, because is the lightening of the edge of the content | 13:17 |
| Saviq | Cimi, but anyway, because background is on top now anyway | 13:17 |
| Saviq | Cimi, let's leave above, when we fix z-ordering | 13:17 |
| Cimi | Saviq, dots are centered vertically now | 13:18 |
| Saviq | Cimi, we'll fix that too (offset dots by... .5dp) ;) | 13:18 |
| Saviq | Cimi, yes, because both darkening and lighting is *inside* the divider | 13:18 |
| Cimi | Saviq, is like a cast shadow on the divider, no? | 13:18 |
| Cimi | Saviq, lighting should be outside | 13:18 |
| Saviq | Cimi, yes, but can't be right now due to z-ordering | 13:18 |
| Cimi | Saviq, so you have to do fully opaque line | 13:19 |
| Saviq | Cimi, needs fixing in LVWPH | 13:19 |
| Cimi | under the lighting | 13:19 |
| === MacSlow|lunch is now known as MacSlow | ||
| MacSlow | mterry, what about notification positioning? | 13:19 |
| Cimi | put a rectangle line of opacity 1.0 using bg color | 13:20 |
| Saviq | Cimi, TBH I don't get why it should be non-opaque at all | 13:20 |
| Cimi | then on top the highlight | 13:20 |
| Cimi | Saviq, it should what? | 13:20 |
| Saviq | Cimi, don't get why it's 0.6 at all | 13:20 |
| Saviq | Cimi, unless it's to let the non-solid (image) background through | 13:21 |
| Cimi | Saviq, that one | 13:21 |
| Saviq | Cimi, anyway, can we fix after? I have to remerge 5 branches every time I change that one :P | 13:21 |
| Cimi | Saviq, sure | 13:21 |
| Saviq | Cimi, we'll sort out z and put it in the right place | 13:22 |
| Cimi | Saviq, was working before | 13:22 |
| Saviq | Cimi, no it wasn't, not with a solid background | 13:22 |
| Cimi | Saviq, on my patch, the lighting outside | 13:22 |
| Saviq | Cimi, no it didn't, not with a solid background | 13:22 |
| Saviq | Cimi, the red scope | 13:23 |
| Saviq | Cimi, in tryDash | 13:23 |
| Cimi | I'll merge and try your then | 13:23 |
| Saviq | Cimi, you and your ideas... now I need to try and find out the top color of the navigation background | 13:24 |
| Saviq | Cimi, which is impossible in the case when it's an image of course | 13:24 |
| kgunn | mzanetti: what was the "other use case" you'd break with the qtmir workaround for uoa using trusted prompts ? | 13:24 |
| Cimi | Saviq, we can use shader for that | 13:24 |
| Saviq | Cimi, sounds expensive for a stupid effect like that | 13:25 |
| Cimi | Saviq, it is :D | 13:25 |
| Saviq | Cimi, when 99.99999% of the time it's going to be solid | 13:25 |
| Cimi | I think we acn just approximate that | 13:25 |
| Cimi | Saviq, the highlight at the bottom of the divider is a punch in the eye | 13:27 |
| Cimi | Saviq, can we remove it for now? | 13:28 |
| Saviq | what's wrong with it? | 13:28 |
| Cimi | Saviq, try with open library | 13:28 |
| Cimi | 18 GU | 13:28 |
| Cimi | or yahoo finance | 13:28 |
| Saviq | ok yeah, not too great | 13:29 |
| Saviq | Cimi, ok, putting it outside, we don't have solid backgrounds anywhere anyway | 13:29 |
| Cimi | yeah | 13:29 |
| Cimi | Saviq, add TODO | 13:30 |
| Saviq | Cimi, check now | 13:33 |
| Saviq | before I start remerging again | 13:33 |
| Cimi | Saviq, did u push? | 13:33 |
| Saviq | Cimi, now | 13:33 |
| Cimi | Saviq, ok that looks nice | 13:34 |
| Cimi | apart weather channel | 13:34 |
| Cimi | but that's their fault | 13:34 |
| Cimi | the divider is supposed to be darker than the page | 13:35 |
| Cimi | because is a bottom layer | 13:35 |
| Saviq | Cimi, ok, anything more to fix in that branch? because I'm merging :P | 13:36 |
| Cimi | Saviq, text in overlay card is not aligned horizontally | 13:36 |
| Cimi | was it due to my card branch? | 13:37 |
| Saviq | it's even on your TODO | 13:37 |
| Cimi | my TODO? | 13:37 |
| Cimi | :D | 13:37 |
| Saviq | Cimi, yes, you put it on your TODO | 13:37 |
| Cimi | I suppose | 13:37 |
| Cimi | yeah | 13:37 |
| Cimi | yeah I can see it | 13:38 |
| Cimi | another issue overlay black texture does not fill the ubuntushape | 13:38 |
| Saviq | that's because it's a hack | 13:39 |
| Cimi | Saviq, http://i.imgur.com/DfTeszL.png | 13:39 |
| Saviq | Cimi, yeah, complain to Loïc :P | 13:39 |
| Saviq | jeez if only pushing one line wouldn't take 15s... | 13:40 |
| === Malinux_ is now known as Malinux | ||
| Saviq | I wonder what VCS we could be using instead that wouldn't have caused me to waste so much time | 13:40 |
| Saviq | OWAIT | 13:40 |
| Saviq | ... | 13:41 |
| Saviq | </talkingtomyself> | 13:41 |
| mzanetti | kgunn: see the linked branch | 14:06 |
| kgunn | ack | 14:09 |
| mzanetti | Saviq: where could I see the previewtable in action? | 14:11 |
| mzanetti | tryPreviewTable is bit minimalistic | 14:12 |
| Saviq | mzanetti, only in test currently | 14:12 |
| mzanetti | Saviq: https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 | 14:14 |
| mterry | Saviq, mzanetti: dynamically created qml objects can be reparented easily enough, I assume, yes? | 14:15 |
| Saviq | mterry, even non-dynamically created ones | 14:16 |
| Saviq | mterry, parent = foo | 14:16 |
| Saviq | mterry, dynamically created ones you can parent as you create them (arg to createObject on a component) | 14:16 |
| mterry | Saviq, right. And does re-parenting them move them around visually like I'd expect (i.e. place them under/over/with-siblings)? | 14:17 |
| Saviq | mterry, yes, they re-anchor, change coordinate space etc. | 14:17 |
| Saviq | mterry, that's what Repeater does for example, it parents all the created delegates to its own parent | 14:18 |
| Saviq | that's the only reason why Columns work around repeaters | 14:18 |
| mterry | Saviq, OK.. thanks makes sense | 14:18 |
| dednick | mzanetti: did you come to a consensus about the trust session issue? | 14:25 |
| mzanetti | dednick: yeah, seems the conversion of UOA to trusted session is in a silo already | 14:25 |
| mzanetti | dednick: which means the issue should go away soon for the proper solution | 14:26 |
| mzanetti | dednick: however, Saviq added a question on the bug report which I guess you can answer better than I can | 14:26 |
| dednick | mzanetti: i've also just commented on your branch. it wasn't a suitable solution for the issue in any case. | 14:29 |
| mzanetti | dednick: I rejected that branch already | 14:29 |
| dednick | mzanetti: yup. i know :) | 14:29 |
| mzanetti | mterry: nono... you won't get away with this one that easily: https://bugs.launchpad.net/unity8/+bug/1357230 | 14:31 |
| === cyphermox__ is now known as cyphermox | ||
| mzanetti | :P | 14:31 |
| ubot5 | Ubuntu bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] | 14:31 |
| mterry | mzanetti, interesting, OK | 14:32 |
| Saviq | cheap karma: | 14:38 |
| Saviq | https://code.launchpad.net/~saviq/unity8/preview-overview/+merge/230903 | 14:38 |
| Saviq | https://code.launchpad.net/~saviq/unity8/fix-notification-indicator-title/+merge/230971 | 14:38 |
| Saviq | https://code.launchpad.net/~saviq/unity8/fix-horizontal-list-activation/+merge/230985 | 14:38 |
| Saviq | @unity ↑ | 14:38 |
| mzanetti | Saviq: you didn't reply on that one: "Are we ok with reaching out of context for widgetData?" | 14:39 |
| mzanetti | Saviq: I guess we are | 14:39 |
| dednick | Saviq: you going to be in office next week? | 14:40 |
| kgunn | Saviq: so heard thru grapevine, on favorite/unfav....we're asking for some backend changes, so prob won't see that land till mid next week | 14:42 |
| Saviq | dednick, yes, Mon→Wed | 14:42 |
| kgunn | ? | 14:42 |
| Saviq | kgunn, yeah, Paweł will only be in on Monday, so then | 14:43 |
| kgunn | cool | 14:43 |
| Saviq | @unity and someone could take over https://code.launchpad.net/~mterry/unity8/dialer-in-greeter/+merge/230362 too | 14:43 |
| Saviq | I've settings to review still | 14:43 |
| Saviq | Cimi, you're doing proper review of alt nav then? | 14:44 |
| Cimi | Saviq, was reviewing header | 14:46 |
| Cimi | Saviq, which seems to be fine | 14:46 |
| Cimi | Saviq, I have to review alt test | 14:46 |
| Saviq | Cimi, right, you did have a look at it already, so should be good | 14:46 |
| Saviq | Cimi, one thing I still need to fix there is your freakin' highlight ;P | 14:46 |
| Cimi | hah | 14:46 |
| dednick | Saviq: yeah. i'll take it. | 14:47 |
| Saviq | dednick, thanks | 14:48 |
| * Saviq thinks anyone who has a devel branch can learn from us juggling 20 branches in a silo :P | 14:48 | |
| mzanetti | Saviq: I must admit its working out better than I expected indeed ^ | 14:52 |
| mzanetti | and yes, now it actually feels a devel branch would be a waste of time | 14:52 |
| Saviq | mzanetti, if only we used git... | 14:52 |
| * mzanetti is still ok with bzr :D | 14:52 | |
| Saviq | mzanetti, well, with 7 chained branches | 14:52 |
| Saviq | mzanetti, every time i have to touch the bottom one | 14:52 |
| mzanetti | ok yeah... that sucks. but would git help there? | 14:52 |
| Saviq | mzanetti, it takes me up to 10 minutes to get the other ones remerged | 14:53 |
| Saviq | mzanetti, yeah, it's faster all round, and less conflicts in case of criss-cross and such | 14:53 |
| Saviq | mzanetti, I wouldn't actually have to remerge | 14:53 |
| mzanetti | hmm ok. bzr does behave weird with merging sometimes | 14:53 |
| Saviq | mzanetti, as the top one would get rebased on the previous one, that on the one before etc. | 14:53 |
| Saviq | sure, if there's conflicts you need to rebase | 14:54 |
| Saviq | but bzr gets awry even if there are none (or well, maybe it's LP's fault actually) | 14:54 |
| Saviq | still I'd work 2x fast | 14:54 |
| greyback | then 1/2 of us would be out of a job | 14:55 |
| greyback | :) | 14:55 |
| mzanetti | yeah... not sure if saviq should work even faster | 14:55 |
| Saviq | well, just when remerging :P | 14:55 |
| * greyback takes away Saviq's QtCreator and hands him sed | 14:56 | |
| mzanetti | greyback: don't I'm sure he'll find a way to get even more productive with that | 14:56 |
| mzanetti | should have been: don't! I'm... | 14:57 |
| Saviq | greyback, I'm doing Vim mode in QtC, slows me down enough requiring to type every symbol's first letter twice... | 14:57 |
| Saviq | greyback_ you have a slower-down of your own today ;) | 15:00 |
| greyback_ | don't talk to me | 15:01 |
| greyback_ | bloody internet today is hopeless | 15:01 |
| Saviq | me talking to you on IRC saturates the connection eh? | 15:01 |
| greyback_ | not just me, mates wit hthe same ISP have found the speed plummeted | 15:01 |
| greyback_ | it's not funny. During Mumble, I was pinging a server, and mumble was breaking up until I stopped the pinging | 15:02 |
| Saviq | ... | 15:02 |
| Saviq | Cimi, very first instalment https://code.launchpad.net/~cimi/unity8/scope-settings/+merge/230182/comments/561558 | 15:04 |
| Saviq | Cimi, you broke preview opening | 15:04 |
| Cimi | "more to come" | 15:05 |
| Cimi | hah | 15:05 |
| Cimi | sounds like a menace | 15:05 |
| Cimi | Saviq, how do I set the focus? | 15:08 |
| Saviq | Cimi, .forceActiveFocus() | 15:09 |
| Cimi | ah | 15:09 |
| Cimi | Saviq, i was doing focus = true | 15:09 |
| Saviq | Cimi, not enough, more afternoon reading: http://qt-project.org/doc/qt-5/qtquick-input-focus.html ;) | 15:11 |
| Cimi | Saviq, it's friday! :D | 15:11 |
| dandrader_ | Saviq, got a lot of stuff for lp:~unity-team/unity8/seeLessStuckBottom. So I actually made a patch for it. Since that branch is on ~unity-team, can I just push to it and have you review my patch instead? Or you review my patch then I push to it | 15:11 |
| Saviq | dandrader_, sure, is fine | 15:12 |
| === dandrader_ is now known as dandrader | ||
| Saviq | Cimi, but please focus on the preview opening | 15:12 |
| Saviq | Cimi, that's the biggest issue so far | 15:12 |
| Cimi | Saviq, I fixed focus already | 15:12 |
| Saviq | sure | 15:12 |
| Cimi | Saviq, I am merging horizontal list now (which is just fixing test) | 15:13 |
| Saviq | Cimi, yups | 15:13 |
| dednick | Saviq: hm. indicator panel doesnt respond when you first boot phone. | 15:14 |
| Saviq | dednick, mzanetti reported bug | 15:14 |
| Saviq | bug #v | 15:14 |
| Saviq | 1357230 | 15:14 |
| dednick | Saviq: ah | 15:14 |
| Saviq | #1357230 | 15:14 |
| Saviq | bug #1357230 | 15:14 |
| ubot5 | bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] https://launchpad.net/bugs/1357230 | 15:14 |
| Saviq | daaamn ctrl | 15:14 |
| mzanetti | dude... you seem to struggle a lot wiht your keyboard lately | 15:14 |
| mzanetti | got a new one? | 15:15 |
| Saviq | mzanetti, new palm rest, yeah | 15:15 |
| mzanetti | heh | 15:15 |
| Saviq | the only thing that's not new in this laptop... is the screen I think | 15:15 |
| Cimi | Saviq, I have one fail but they all say pass | 15:16 |
| Saviq | and well, periphery like memory, ssd, expansion cards | 15:16 |
| dednick | hm. why don't we get an active call hint when the greeter is locked... | 15:16 |
| dednick | interesting | 15:16 |
| Saviq | Cimi, XFAIL? | 15:16 |
| Saviq | Cimi, that's expected fail == negative test == pass | 15:16 |
| dednick | can't get back to the dialer after lock/unlock phone | 15:16 |
| Cimi | Saviq, http://paste.ubuntu.com/8054471/ | 15:17 |
| Saviq | Cimi, hah | 15:17 |
| Saviq | XPASS : qmltestrunner::GenericScopeView::test_header_style(Default) 'Could not find the title image.' returned TRUE unexpectedly. () | 15:18 |
| Saviq | Cimi, XPASS is unexpected pass | 15:18 |
| Saviq | there's an expectedFail() that doesn't fail in that test | 15:18 |
| dednick | mterry: https://code.launchpad.net/~mterry/unity8/dialer-in-greeter/+merge/230362/comments/561563 | 15:19 |
| Saviq | Cimi, weird, though, they passed fine here after I merged | 15:19 |
| mterry | dednick, replied | 15:20 |
| dednick | mterry: er, not show the panel? | 15:21 |
| dednick | how do we know battery? | 15:21 |
| dednick | or time? | 15:21 |
| mterry | dednick, only when in call | 15:21 |
| mterry | dednick, not normal greeter mode | 15:21 |
| dednick | mterry: sorry, i don't get it? in normal greeter mode, we show panel? | 15:22 |
| mterry | dednick, again, they may be flexible on it, we can go back to them if we want | 15:22 |
| mterry | dednick, yeah we show the panel on the greeter. But if you're in a call while the greeter is active, we don't show it | 15:23 |
| dednick | mterry: i'm pretty sure i'm in greeter on a call, and i can see a panel | 15:23 |
| dednick | ah. but cannot drag | 15:24 |
| dednick | mterry: is that what you meant? | 15:24 |
| mterry | dednick, no | 15:25 |
| dednick | mterry: it doesn't show if you have the dialer-app screen up though. but it does in the greeter | 15:25 |
| mterry | dednick, right | 15:25 |
| mterry | dednick, but with that second branch I linked, you should always be in dialer-app screen when on a call with the greeter active | 15:26 |
| dednick | mterry: ah. i didn't see the link. | 15:26 |
| dednick | duh | 15:26 |
| dednick | well that's fine. if we're always in call then dont need active call hint :) | 15:27 |
| Cimi | Saviq, my pc is faster than yours | 15:27 |
| Saviq | Cimi, of course it is, I was testing in xvfb | 15:27 |
| Cimi | Saviq, I need to add a little wait and it works | 15:27 |
| Cimi | of course I am not adding a wait | 15:28 |
| Cimi | I want to find what tryCompare to put | 15:28 |
| mterry | dednick, yeah hopefully :) | 15:28 |
| Cimi | sth here http://paste.ubuntu.com/8054542/ if you have a clue Saviq | 15:28 |
| Cimi | replacing the verify with a tryCompare? | 15:29 |
| Saviq | Cimi, no, this is a negative test | 15:29 |
| Saviq | Cimi, which means in tryCompare it will pass, too, | 15:29 |
| Cimi | Saviq, without a wait(50) before that verify, it fails on my machine | 15:30 |
| Cimi | actually before even the verify | 15:30 |
| Saviq | Cimi, sure, but that just means you need to wait *before* the findChild | 15:30 |
| Cimi | yesh | 15:30 |
| Cimi | I put wait(50) here indeed | 15:30 |
| Cimi | but I hate wait | 15:31 |
| Cimi | can I put sth else? | 15:31 |
| Saviq | Cimi, you have a tendency of pasting three lines and expecting people understand what they mean | 15:33 |
| Saviq | Cimi, CONTEXT | 15:33 |
| Cimi | Saviq, http://paste.ubuntu.com/8054591/ | 15:33 |
| Cimi | Saviq, without that wait it XPASS | 15:34 |
| Cimi | of course forgot to put data http://paste.ubuntu.com/8054595/ | 15:34 |
| Saviq | Cimi, that's rather weird, what does console.debug(image) say before the wait()? | 15:38 |
| Saviq | and after, for that matter | 15:38 |
| Cimi | Saviq, QDEBUG : qmltestrunner::GenericScopeView::test_header_style(Default) qml: QQuickImage(0x303bec0, "titleImage" | 15:39 |
| Saviq | Cimi, iiinteresting, I wonder where it finds that image | 15:40 |
| Saviq | Cimi, and if you do: | 15:41 |
| Saviq | http://pastebin.ubuntu.com/8054662/ | 15:42 |
| Saviq | Cimi, can you add onSourceComponentChanged and onStyleChanged in Background.qml | 15:44 |
| Saviq | print the values of course | 15:44 |
| Cimi | Saviq, with the double print, the second one does is null | 15:45 |
| Saviq | Cimi, k, got a diff for you in a mo | 15:45 |
| Cimi | Saviq, it can be some async stuff | 15:46 |
| Saviq | Cimi, thank you | 15:46 |
| Saviq | Cimi, check this out | 15:47 |
| Saviq | http://paste.ubuntu.com/8054695/ | 15:47 |
| Cimi | Saviq, the darkening on the divider should be disabled in overview | 15:48 |
| Saviq | Cimi, is it visible there at all? | 15:48 |
| Cimi | Saviq, I think it is | 15:48 |
| Saviq | Cimi, right, just the highlight | 15:48 |
| Saviq | Cimi, the other is made invisible due to showSignatureLine | 15:49 |
| Saviq | k will fix | 15:49 |
| Cimi | Saviq, I saw a dark line iirc before | 15:49 |
| Cimi | I will test later | 15:49 |
| Saviq | Cimi, it's inside the divider which is invisible, so that dark line might've been the highlight is all | 15:49 |
| mzanetti | mterry: hey, I think this one is ready: https://code.launchpad.net/~mzanetti/unity8/new-lockscreen-design/+merge/230478 | 15:50 |
| mterry | mzanetti, ok will review after lunch | 15:51 |
| Cimi | Saviq, FAIL! : qmltestrunner::GenericScopeView::test_header_style(Default) property status | 15:54 |
| Cimi | Actual (): 1 | 15:54 |
| Cimi | this is before setting scope though | 15:55 |
| Saviq | Cimi, well, yeah, that's the idea | 15:55 |
| Saviq | Cimi, you can check on sourceComponent that it's null | 15:56 |
| Saviq | Cimi, basically you need to wait for the Background to unload from the previous scope | 15:56 |
| Cimi | Saviq, in cleanup? | 15:57 |
| Saviq | Cimi, nah, because that's the only test looking at the background | 15:57 |
| Saviq | Cimi, so just at the beginning of the test | 15:57 |
| Cimi | Saviq, it is not enough | 15:59 |
| Cimi | Saviq, despite that, I still have random failures | 15:59 |
| Cimi | Saviq, can I put a wait and a fixme? | 16:00 |
| Saviq | Cimi, it's not failing on jenkins, so just leave it be | 16:00 |
| Saviq | Cimi, does it fail for you under xvfb too? | 16:00 |
| Cimi | Saviq, no | 16:02 |
| Saviq | Cimi, so yeah, leave it be | 16:03 |
| Saviq | Cimi, does it fail in trunk too? | 16:04 |
| mterry | mzanetti, can you link me to the visual designs you based new-lockscreen-design off of? | 16:06 |
| Cimi | Saviq, wtf: if I run unity8 with run.sh, previews are fine | 16:10 |
| Cimi | Saviq, if i run with start unity8-dash BINARY=$PWD/builddir/src/Dash/unity8-dash ARGS=-mousetouch | 16:11 |
| Saviq | Cimi, yeah, and how's that weird? | 16:11 |
| Cimi | the index is not sent | 16:11 |
| Saviq | Cimi, run.sh results in system-wide dash being started | 16:11 |
| Cimi | oh fuck | 16:11 |
| Saviq | Cimi, it's like that since dash-as-app | 16:11 |
| Cimi | I had no idea | 16:12 |
| Saviq | there's a branch fixing this particular issue https://code.launchpad.net/~saviq/unity8/tweak-runscript | 16:12 |
| Saviq | Cimi, but not ready yet | 16:12 |
| Saviq | 'cause run_on_device doesn't work still | 16:12 |
| Cimi | Saviq, the index issue is the usual issue with bindings and loader | 16:17 |
| Cimi | Saviq, how do we workaround those problem? | 16:17 |
| Saviq | Cimi, what's "the usual issue with bindings and loader"? | 16:17 |
| Cimi | Saviq, currentIndex can be set from genericScopeView and from inside PrevireListView | 16:18 |
| Cimi | where sometimes we had a proxy | 16:18 |
| Cimi | basically what happens is that, when you click on an app | 16:19 |
| Cimi | 1) this sets the loader property currentIndex to the index of the app | 16:19 |
| Saviq | Cimi, not sure what you mean, but if you mean that sedding index doesn't "register" | 16:19 |
| Saviq | Cimi, because it's too early | 16:19 |
| Cimi | 2) then onLoaded it sets a binding to the item | 16:19 |
| Saviq | Cimi, and then it resets to 0 when model is loaded | 16:19 |
| Cimi | but inside previewListView, the currentIndex is set to 0 | 16:20 |
| Cimi | so it loses | 16:20 |
| Cimi | Saviq, pretty much | 16:20 |
| Cimi | Saviq, how do we deal with this issue? | 16:21 |
| Saviq | Cimi, then you need a "init" property in the PreviewListView or something, and a separate property for the initial index | 16:21 |
| Saviq | Cimi, and on model loaded you need to set it to that index | 16:21 |
| Cimi | I see | 16:21 |
| Saviq | Cimi, it's basically a lack in ListView API, it should have an initialIndex property | 16:22 |
| Cimi | and inside the listview, currentIndex : root.initialValue | 16:22 |
| Cimi | got it | 16:22 |
| Saviq | Cimi, yeah, something of the sort | 16:22 |
| Cimi | thanks | 16:22 |
| Saviq | Cimi, reviewed, only tests left | 16:24 |
| Cimi | Saviq, ok, monday :P | 16:25 |
| Saviq | Cimi, yeah, if you can fix the previews folks would be happy monday morning though | 16:25 |
| Cimi | Saviq, yeah | 16:26 |
| Cimi | Saviq, but your review seems long | 16:26 |
| Cimi | and I am frankly tired | 16:26 |
| Saviq | Cimi, tired is a state of mind ;) | 16:26 |
| Cimi | started quite early today too | 16:26 |
| Cimi | hah | 16:26 |
| Saviq | Cimi, yeah, ok, not a huge issue when you know about it | 16:26 |
| Cimi | Saviq, on model loaded? | 16:35 |
| Cimi | how? | 16:35 |
| Saviq | Cimi, onCountChanged > 0 probably | 16:35 |
| Saviq | Cimi, or > initialIndex for that matter | 16:35 |
| Saviq | Cimi, or onModelChanged can be enough | 16:36 |
| === gatox is now known as gatox_lunch | ||
| Cimi | Saviq, countChanged | 16:37 |
| Saviq | mterry, can I ask you for a blind ACK on https://code.launchpad.net/~saviq/unity8/fix-notification-indicator-title/+merge/230971 | 16:37 |
| Saviq | mterry, just look at your phone ;) | 16:38 |
| Cimi | Saviq, http://paste.ubuntu.com/8055088/ | 16:38 |
| Cimi | that seems to work | 16:38 |
| Saviq | Cimi, yeah, good enough | 16:39 |
| Cimi | Saviq, onModelChanged is too early | 16:39 |
| Saviq | Cimi, it's kinda wasteful 'cause it will load the first delegate and destroy it straight away | 16:39 |
| Cimi | Saviq, onCount works | 16:39 |
| mterry | Saviq, done | 16:39 |
| Saviq | Cimi, but what can you do... | 16:39 |
| Saviq | mterry, tx | 16:39 |
| Saviq | mterry, could use a less blind one of https://code.launchpad.net/~saviq/unity8/fix-horizontal-list-activation/+merge/230985 if you're up for it (and MacSlow isn't in the middle of it already?) | 16:40 |
| Cimi | Saviq, https://bugreports.qt-project.org/browse/QTBUG-12576 ? | 16:40 |
| MacSlow | Saviq, mterry: I'm not on that one | 16:41 |
| Saviq | Cimi, yeah, that assumes that model is static | 16:41 |
| Cimi | Saviq, in fact I tried and not works | 16:41 |
| Saviq | Cimi, if it's assigned anywhere after onCompleted, you're screwed | 16:41 |
| Saviq | Cimi, yeah, it wouldn't | 16:41 |
| mterry | Saviq, sure I can look | 16:41 |
| Saviq | Cimi, 'cause it's reset on model change (for good reasons) | 16:42 |
| Cimi | Saviq, ok I should have fixed also no overview in settings | 16:49 |
| Cimi | Saviq, next week cosmetic changes, but functionality is there | 16:49 |
| Saviq | Cimi, coolz, thanks, have a good weekend | 16:49 |
| Cimi | Saviq, when you arrive monday? | 16:49 |
| Saviq | Cimi, I'm in Sunday night | 16:50 |
| mterry | Saviq, how come tryGenericScopeView gives an empty view? (or is that something on my end?) | 16:50 |
| Saviq | mterry, yeah, there's no scope by default | 16:50 |
| Cimi | mterry, I fixed that in scope settings branch | 16:50 |
| Saviq | Cimi, sounds like maybe why the test started failing? ;) | 16:51 |
| mterry | Saviq, Cimi: thankks | 16:51 |
| Saviq | mterry, we generally do tryDash to get a more complete experience | 16:51 |
| Cimi | Saviq, I tried removing that | 16:51 |
| Cimi | Saviq, it doesn't make difference | 16:51 |
| Cimi | Saviq, I'll fix your review things then pop in to the office | 16:52 |
| Cimi | better to skip rush hour if I can | 16:52 |
| Saviq | Cimi, I imagine we'll be quite busy (there's actually a schedule!) | 16:52 |
| Saviq | Cimi, but yeah, see you there | 16:52 |
| Cimi | ah! | 16:52 |
| Cimi | ok | 16:52 |
| Cimi | Saviq, are we putting the latest revisions on silo 17? | 17:04 |
| Saviq | Cimi, yeah, I'll rebuild it soon | 17:04 |
| Saviq | Cimi, will just land already approved stuff through 18 first | 17:04 |
| Saviq | in an effort to get green CI again... | 17:05 |
| * greyback_ eow | 17:06 | |
| greyback_ | o/ | 17:06 |
| === alan_g is now known as alan_g|EOW | ||
| Saviq | facundobatista, can you top-ack https://code.launchpad.net/~saviq/unity-scope-scopes/fix-overview-search-mapping/+merge/230966 please? | 17:12 |
| facundobatista | Saviq, with top-ack you mean approve the merge proposal? | 17:13 |
| Saviq | facundobatista, yup :) | 17:13 |
| facundobatista | Saviq, I can't | 17:14 |
| Saviq | facundobatista, right, though so, will find another victim, thank you :) | 17:14 |
| facundobatista | (don't have launchpad permissions to do it) | 17:14 |
| Saviq | mzanetti, did you resolve the hang on run_on_device ? | 17:15 |
| mzanetti | Saviq: well, not resolve... I commented away the -jsdebugger arg | 17:16 |
| Saviq | ah that | 17:16 |
| MacSlow | mterry, btw that's the branch (lp:~macslow/unity-notifications/fix-1354406), which will allow exposing a notification's triggering app-name on the renderer-side. This is just the backend-portion needed to fix LP: #1354406. Adding the frontend (renderer) bits is very easy once this landed. | 17:29 |
| ubot5 | Launchpad bug 1354406 in unity8 (Ubuntu) "PIN-locked phone becomes unresponsive after simultaneous alarms" [High,In progress] https://launchpad.net/bugs/1354406 | 17:30 |
| MacSlow | mterry, should that turn out to be needed, I can provide that too | 17:30 |
| === gatox_lunch is now known as gatox | ||
| mterry | MacSlow, yeah if we implement it like design wants, we'll need that on frontend | 17:44 |
| === _morphis is now known as morphis | ||
| Saviq | mterry, did you see bug #1357230 btw? | 20:11 |
| ubot5 | bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] https://launchpad.net/bugs/1357230 | 20:11 |
| mterry | Saviq, working on it right now, I think it's because LightDM.Greeter.authenticated is nonNOTIFYable | 20:11 |
| Saviq | mterry, ktx, just wanted to make sure it's on your radar | 20:11 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
