=== greyback__ is now known as greyback [07:19] morning [07:31] Saviq, wohoo https://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/919/ [08:09] Saviq: hey, do you know where I can get a Ubuntu One staging account? [08:16] mzanetti, https://login.staging.ubuntu.com/ [08:17] Cimi, yeah, I know... worst thing is this was weird because of a duplicate name: in CardTool's test... [08:21] dandrader, thanks for your review and sorry for you having to look at this mess, it was a witch hunt initially 'cause of the dupe name: [08:24] Cimi, re: can we have a card without a title, for real, no, but the code was triggered when templates and components were empty (so we might hit it on startup) [08:26] Saviq, I figured you must have been too tired when you wrote it as it was quite late :) [08:27] dandrader, yeah, and I was hunting for the actual failure because obviously it wasn't reproducible locally (when it really was, only different test suite :P) [08:31] MacSlow, hey, what's the state of the fix for bug #1354406 ? [08:31] bug 1354406 in unity8 (Ubuntu) "PIN-locked phone becomes unresponsive after simultaneous alarms" [High,In progress] https://launchpad.net/bugs/1354406 [08:40] Saviq, which timezone are you working? :) [08:41] Cimi, ALL OF 'EM [08:41] sometimes [08:41] hah [08:42] Saviq, alt nav requires a test though [08:42] Cimi, yeah, just getting on that [08:53] greyback, should I report a bug on mir asking for the surface type to be passed to PlacementStrategy::place()? [08:56] dednick: hey. I'd need help on trusted sessions [08:56] have a minute? [08:56] might be an hour though :D [08:57] dandrader: sure [08:57] Saviq, https://code.launchpad.net/~saviq/unity8/preview-customizations/+merge/230736 [08:57] mzanetti: sure [08:57] Cimi, nope [08:57] dednick: ok.. there's this bug that promptsessions are removed on focus change [08:57] dednick: I tracked it down to platforms/mirserver/promptsessionlistener.cpp [08:57] Cimi, if (item.hasOwnProperty("scopeStyle")) item.scopeStyle = root.scopeStyle; [08:58] dednick: PromptSessionListener::prompt_provider_removed is called [08:58] dednick: but from here I'm not sure where to go [08:59] mzanetti: "bug" [08:59] ? [08:59] dednick: so what happens is that such a prompt session is opened [08:59] mzanetti: it's a "feature" actually [08:59] oh [08:59] Cimi, hmm or by now all of them have one indeed [08:59] Cimi, fixing [08:59] dednick: so opinions seem to differ on that: https://bugs.launchpad.net/qtmir/+bug/1355173 [09:00] mzanetti: prompt sessions are explicitly cancelled by qtmir when focus is switched [09:00] Ubuntu bug 1355173 in QtMir "Switching windows with a Trusted Prompt Session active looses the trusted prompt session" [Critical,New] [09:00] mzanetti: perhaps we don't want it anymore though [09:01] dednick: dunno... I got assigned this bug... I said I've no clue what's going on but I will look at it [09:01] greyback, I meant the surface state. but having also surface type might be good as well [09:01] dandrader: the more info the better IMO [09:01] yeah [09:02] dednick: hmm... so assuming this is the wanted behavor [09:02] dednick: should the thing that opens the trusted session be informed? [09:02] dednick: tedg says that the app still thinks the prompt is shown, its just visually not there any more [09:02] mzanetti: have you read the bug comments? :) [09:02] err, yes... [09:03] did I miss something? [09:03] * mzanetti rereads [09:03] mzanetti: well, it explains things there. not a solution though [09:03] oh I see [09:03] right... so this needs to be removed (at least for now) I guess [09:04] mzanetti: teds problem is that the payments is not complete enough to deal with the behaviour [09:04] dednick: well, rather online accounts is not complete enough [09:04] but yes [09:04] mzanetti: so yeah. let me get a codepoint for you [09:05] mzanetti: anything that calls: [09:05] :/ [09:05] fek [09:05] http://bazaar.launchpad.net/~mir-team/qtmir/trunk/view/head:/src/modules/Unity/Application/application.cpp#L439 [09:05] mzanetti: ^ [09:06] actually, probably only the application::setState [09:06] I see [09:06] still want to close on app destruction [09:06] ok... I know my way around in applicationmanager... thank... I tought that call would come from mir [09:07] mzanetti: goes to mir [09:07] oh ok... explains things [09:08] mzanetti: generally unity8 shouldn't be worrying about stopping prompt sessions, but this was a requested feature for the time being [09:09] so I guess the "solution" for now is just to comment away that soptPromptSession call and add a FIXME on top to reenable it when UOA is ready for trusted sessions [09:09] * mzanetti tries [09:09] mzanetti: yep. think so. although not sure how this is going to affect other things. [09:09] greyback, https://bugs.launchpad.net/mir/+bug/1357259 [09:09] Ubuntu bug 1357259 in Mir "PlacementStrategy::place() should be given the surface type and state" [Undecided,New] [09:09] dednick: well, I think this is the only place that uses trusted session yet [09:10] or do you know about others? [09:10] dandrader: ta [09:10] mzanetti: it was more of a "guard" than a feature. since some prompt helpers may not support dealing with more than one prompt request at a time. [09:10] hmm... ok [09:10] mzanetti: actually, i think a number of things do. camera, maps, etc. [09:11] dednick: maps? [09:11] resource access requests. location-services to be exact. [09:11] we have maps? [09:11] osmtouch. [09:11] open street maps [09:11] mzanetti: browser google maps as well. [09:11] indeed... [09:11] the camera does [09:12] now that you say it, the dialog slides in from the bottom instead of just appearing [09:12] mzanetti: what is the camera requesting? [09:12] * mzanetti retries [09:12] hmm... its gone [09:13] I think it was location [09:13] yeah, i think it only asks once, then remembers [09:13] I declined it, won't come back [09:14] so that means no geolocation for me any more until I --wipe the phone? [09:14] mzanetti: hm. there's a file you can delete which makes it ask again, but can't remember now. [09:14] heh [09:14] ok... no worries.. I don't think my camera should access GPS anyways [09:15] mzanetti: yeah, it's per app i think [09:18] mzanetti: but a way to test if it still works after removing the stop, is to try get two prompts on the screen at the same time for different apps [09:18] like one for camera and one for osmtouch. [09:18] I c [09:18] ok [09:18] mzanetti: but to be fair, i don't think that's as important as getting payments to work :) [09:19] yeah... I agree [09:19] i like money [09:19] although not giving it away [09:19] :D [09:20] yeah... so far I definitely made more money with apps then spent on them :D [09:20] still not much :D [09:34] Cimi, pushed alt nav test [09:34] Saviq, thx [09:34] ah, wait, want to add another one [09:42] dednick: any chance you remember which file it is? can't find it [09:42] the one to reactivate the camera app's promptsession [09:43] mzanetti: uuu. give me a minute. i'll try find it. lost my note :( [09:46] mzanetti: rm -rf ~/.local/share/UbuntuLocationService [09:46] uh... interesting [09:46] mzanetti: think you need to restart the trust-store after that [09:48] mzanetti: presumably there will be a settings page where you can change these things at some point. [09:49] dednick: just figured there is a setting in the camera app [09:49] dednick: but once you declined that popup it breaks the setting [09:49] mzanetti: there might be one for camera as well. [09:49] not sure [09:49] i think it's per service rather than per type [09:50] mzanetti: per server per app i mean [09:51] mzanetti: it's a db lookup. servce->app = [yes/no] i think [09:51] so location->camera, or location->osmtouch [09:53] Cimi, done [09:59] dednick: sqlite3 on that file and "delete from requests" does the job without restarting anything [09:59] well, restarting the camera-app ofc [10:00] mzanetti: cool [10:09] mzanetti, bug #1357230 is without a pass / pin lock? [10:09] bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,New] https://launchpad.net/bugs/1357230 [10:10] Saviq: yep [10:11] dednick: yeah... as suspected, there are issues with the use case you said [10:11] expected === shiznix_ is now known as shiznix [10:22] dednick: https://code.launchpad.net/~mzanetti/qtmir/workaround-1355173/+merge/230952 [10:24] dednick: thanks for your help [10:26] mzanetti: no worries. just want to talk to tvoss about it first. maybe something can be done about the multiple app thing at the same time. [10:26] dednick: yep === dandrader is now known as dandrader|afk [10:30] dednick: am reviewing your prompt-surface-model stuff, it wouldn't be in a silo by any chance? [10:33] greyback: not yet. if you code review, can get a silo i guess [10:41] paulliu, hey, I put a hopefully final review comment on your reboot branch [10:50] sodding wifi [10:57] greyback__: fair point... but I guess it might be not that easy to convert UOA to trust sessions [10:58] greyback__: but I don't agree that the "new" issue is as bad as the "old" one [10:58] greyback__, can get it in 17 for you [10:58] greyback__, assuming it can land soonish? [10:58] * greyback__ popular all of a sudden [10:59] greyback__: chances are like 0 that you open two apps with the location question without confirming/declining it first [10:59] Saviq: no, I was just being lazy and hoping packages existed [10:59] greyback__: while chances that you click on install on an app before having set up your UOA account are much bigger [10:59] greyback__, https://code.launchpad.net/~nick-dedekind/unity8/prompt-surface-model/+merge/230813/comments/561274 [10:59] http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1010/artifact/work/output/*zip*/output.zip [11:00] Saviq: yes but for unity8 whic also changes [11:00] mzanetti: I don't like introducing one bug to fix another. [11:00] there must be a better option [11:01] greyback__, does not compute, but also for qtmir you'd need to request they collect the packages, not sure why it doesn't [11:01] Saviq: oh sorry, I misread the link. Thought you were pointing me to qtmir packages which do build [11:01] @unity, need volunteers for https://code.launchpad.net/~unity-team/unity8/seeLessStuckBottom/+merge/230948 https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 [11:06] mardy: hey, what's your opinion on https://bugs.launchpad.net/ubuntu-system-settings-online-accounts/+bug/1355173 ? [11:06] Ubuntu bug 1355173 in QtMir "Switching windows with a Trusted Prompt Session active looses the trusted prompt session" [Critical,New] [11:06] mardy: is there already some work ongoing to convert the UOA setup to a trusted prompt session? [11:07] mzanetti: it's in silo 13, we are testing it [11:08] oh! [11:08] that's good news [11:08] mzanetti: thanks for pointing me to that bug report, I was not aware of that [11:08] mardy: well, we just figured an hour ago that this is actually the issue [11:08] :) [11:08] at least I did [11:08] dednick: ^^ Hold off t [11:09] dednick: so seems the workaround is not required after all === dandrader|afk is now known as dandrader [11:09] mzanetti: ah. ok. awesome! [11:10] mzanetti: wait a second, are we talking of one trusted session, or of two? [11:10] ? [11:10] mardy: err... one I guess [11:10] mzanetti: i got to go out for a bit. continue later. your solution has unfortunately been rejected. :) [11:10] mzanetti: OK, so the parties involved are only the client application and OA, right? [11:11] mardy: hmm... no [11:11] mardy: dash opens payment ui [11:11] mardy: payment ui opens UOA [11:11] but I don't think that should affect you... [11:11] Saviq, I'll take https://code.launchpad.net/~unity-team/unity8/seeLessStuckBottom/+merge/230948 [11:12] dandrader, thanks [11:12] mzanetti: does dash use a trusted session to open the payment UI? [11:12] mardy: yes [11:12] mzanetti: mmm... then we have two trusted sessions, because OA will also create its own [11:13] mardy: yeah... but unity can deal with that... not sure if UOA even knows about it [11:13] mzanetti: OA will create a trusted session having the payment UI as initiator, and the OA UI as dialog [11:13] mzanetti: ah OK, that's fine. No, OA won't know about it [11:13] Saviq, But I will need your help. What's this "See less" thing? [11:13] dandrader, expansion button below categories [11:13] dandrader, let me find a scope for you :) [11:14] dandrader, start unity8-dash BINARY=$PWD/builddir/src/Dash/unity8-dash ARGS=-mousetouch [11:14] Saviq, yeah, I was looking for such buttons yesterday evening but couldn't find any in the UI [11:15] dandrader, bottom-swipe to overview, go to Yahoo [11:15] Saviq, right. see them there [11:16] mzanetti, can I bother you for https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 [11:17] Saviq: yeah... didn't do my daily review today yet [11:20] mzanetti, pushed a small fix there [11:20] ok [11:20] mzanetti, speaking of which, https://code.launchpad.net/~dandrader/unity8/lifecycle/+merge/230090 has been updated as per your feedback :) [11:20] ok [11:21] dandrader, you too, just pushed a s/"grey"/palette.baseText/ to seeLessStuckBottom [11:21] Saviq: is the right-edge-ppa still in use? [11:22] mzanetti, no, it's all yours [11:22] cheers [11:22] Saviq: btw... regarding the hotfix for the user testing... I guess we should properly fix that behavor? [11:23] mzanetti, yeah, please file a bug with ubuntu-ux and assign Vesa [11:23] mzanetti, there's probably a few more cases where we need to have a closer look at this [11:23] mhm [11:23] ok [11:23] /somefood [11:26] vesar: https://bugs.launchpad.net/ubuntu-ux/+bug/1357333 [11:26] Ubuntu bug 1357333 in Unity 8 "Launcher shouldn't hide on long left edge swipes in some circumstances" [Undecided,New] [11:26] I guess we should talk about this in our next weekly [11:36] greyback_, https://code.launchpad.net/~dandrader/qtmir/lifecycle/+merge/230092 is updated. needs your review [11:36] dandrader: ack [11:37] Holas [11:39] Saviq, http://paste.ubuntu.com/8053056/ [11:39] Saviq, I think it looks fine, tested with all grey/all red and normal [11:39] Saviq, we can tweak shade values a little when we will have real scopes to test [11:41] Cimi, we have real scopes to test [11:42] Cimi, just go to the overview, All [11:42] Cimi, "#B2FFFFFF" [11:43] Cimi, k, I'm applying that to my branch then [11:44] Saviq, that was opacity of white line? [11:44] Cimi, yes [11:44] Saviq, 0.7 alpha? [11:45] Cimi, yeah [11:45] ok [11:45] Saviq, ok so in the patch, you can try Qt.rgba(1.0, 1.0, 1.0, 1.0) instead 0.7 [11:45] or maybe something little bit more, 0.8 [11:46] which them multiplies for 0.6 global opacity of the rectangle [11:46] I think 0.7 was too much on dark colours [11:46] Cimi, it doesn't work with a solid background unfortunately, z-ordering is bad between header and content, need to talk with Albert about htis [11:46] Cimi, the rectangle is full opacity [11:46] ah there [11:46] no it's not ok [11:47] Saviq, the opacity of the divider is full because we have full color here, no? === MacSlow is now known as MacSlow|lunch [11:47] Cimi, it's full because we want it to be full [11:48] Saviq, anyway you got the point of color manipulating [11:48] we can always tweak them later [11:48] Cimi, it's not like "I didn't get the point" ;) [11:48] yeah whatever :) [11:48] Cimi, it's "I GOT A DESIGN THAT DIDN'T HAVE IT" :P [11:49] and even explicitly asked about it [11:50] Cimi, if I"m honest, this doesn't work too well with any coloured divider, let me get you some shots [11:52] Saviq: if we release the new scopes (and shell plugin) to RTM, will that upset the version of unity8 in RTM? (i.e. does it have the v4 shell API there) [11:52] pete-woods, it does, yes, and scopes shell, too [11:52] pete-woods, I landed that in rtm [11:53] Saviq: awesome, thanks! [11:53] Cimi, check out the "Zrzut ekranu..." ones in https://drive.google.com/drive/#folders/0B32jwBcbaPloR1IyRF91ZWs0bFE [11:53] amazon looks ~ok [11:53] I have those [11:54] Cimi, k wait for it [11:54] Saviq, what's wrong with those? [11:55] Cimi, please tweak these to your liking http://paste.ubuntu.com/8053144/ [11:55] Saviq, you want more contrast? [11:55] Cimi, I can't see the inset at the top TBH === alan_g is now known as alan_g|lunch [12:02] mzanetti, with all your SIM cards, can you please have a look at bug #1357321 [12:02] bug 1357321 in Unity 8 "scope images do not load in HSDPA or 3G" [Undecided,Confirmed] https://launchpad.net/bugs/1357321 [12:02] ok [12:05] Saviq, I bumped to http://paste.ubuntu.com/8053224/ [12:06] Cimi, my diff was different, please rebase [12:06] Cimi, no need to put it in the bottom container [12:06] Cimi, http://paste.ubuntu.com/8053144/ [12:06] Saviq, I prefered it as before for the normal headers, but this should work lil better with other combinations [12:07] Saviq, just change 1.08 to 1.1 maybe? [12:07] try it [12:07] it's tastes... [12:07] Cimi, that feels negligible [12:07] Saviq, I see the difference :) [12:08] Saviq, better than 1.08 [12:08] Cimi, yeah, indeed [12:08] Saviq, we can always tweak them next week [12:08] Cimi, pushed [12:09] I'm coming too if you are there [12:09] uh oh [12:10] ah, building helps [12:12] ugh no it doesn't [12:16] Cimi, it's actually slightly more complex in the nav branch, but I'll manage [12:17] facundobatista, let's do it here [12:17] facundobatista, somehow I'm getting a art:mascot mapping for recommendations [12:18] facundobatista, and yes, no art == breakage [12:18] so no title either [12:19] Saviq, the client scope scope may be changing it, in the log is clear that the server is returning art=art [12:20] facundobatista, yeah, sure, as if I change the mapping to art:art in the scope tool, it works [12:20] facundobatista, so unity-scope-scopes? [12:20] Saviq, the "related search" case is different, though... the server is returning mascot=mascot in the category, and a mascot in the result, but empty :/ [12:20] this is a server issue! [12:20] I knew it! ;) [12:21] it's ok if in that case I return a mascot in the result (with a proper image) and mascot=mascot in the category component mapping? [12:21] "art": { [12:21] "field": "mascot", [12:21] facundobatista, ↑ breakage [12:21] Saviq, yes, that breakage is in the recommendations [12:22] facundobatista, it's like so: mascot is something the shell looks at, and the plugin maps from result based on the mapping [12:22] Saviq, once dash loads a scope, it will never unload it? [12:22] dandrader, the *dash* will not [12:23] dandrader, overview will, as it destroys the temporary pages [12:23] facundobatista, so whatever you set the mapping as, the plugin will try and map from the result to show the shell [12:23] Saviq, what's overview? that thing from where you can access all scopes? [12:23] dandrader, yes ;) [12:23] facundobatista, so if you want the mascot in the shell to display what you send in the "mascot" field in the result [12:24] facundobatista, you want mapping to be mascot:mascot indeed [12:24] right [12:24] thanks [12:29] facundobatista, are you sending overlay color at all or are we fine with the 15% black we have everywhere? [12:30] Saviq, I think we're ok [12:30] facundobatista, I'll drop the mapping then [12:30] Saviq, btw, don't bother about the URL I requested, I see oopses from what you surely tried (scopes scopes previews from PL) [12:30] facundobatista, you got me ;) [12:32] facundobatista, re: previews for results, I was told that there should be no preview for anything other than scopes, we'd have to clarify that [12:33] facundobatista, the other thing I just read... "Note - the search results page uses a dark theme but any subsequent screens (including previews) are in the standard theme." [12:33] that's not possible (for preview to be in a different theme than search page) [12:33] so let's ignore that for now ;) [12:35] ok [12:37] facundobatista, https://code.launchpad.net/~saviq/unity-scope-scopes/fix-overview-search-mapping/+merge/230966 [12:42] tedg: just an FYI, I've an MR up with basic LTTng tracepoints added. It'll take me more time however to actually see what might be slow [12:43] https://code.launchpad.net/~gerboland/qtmir/lttng/+merge/230967 [12:44] here is output from one test run: http://pastebin.ubuntu.com/8053449/ === alan_g|lunch is now known as alan_g [12:56] Cimi, hmm is the bottom highlight supposed to be over the divider still or below it, over the content? [12:57] inside [12:57] aaand remerge [12:58] oh crap really? [12:58] Notification center? [12:58] mzanetti, how's that going to be in german ↑? [12:59] seb128, french ↑? [13:00] * Saviq foresees ellipses [13:00] Saviq, Centre de notifications [13:00] *maybe* [13:00] I bet german is longer ;-) [13:01] weeell must be someone thought it through, right? [13:01] MacSlow|lunch, poke, for when you get back, about notifications and placement on screen [13:17] Saviq, I think should be over the content [13:17] Cimi, then dots are not centered vertically [13:17] Saviq, because is the lightening of the edge of the content [13:17] Cimi, but anyway, because background is on top now anyway [13:17] Cimi, let's leave above, when we fix z-ordering [13:18] Saviq, dots are centered vertically now [13:18] Cimi, we'll fix that too (offset dots by... .5dp) ;) [13:18] Cimi, yes, because both darkening and lighting is *inside* the divider [13:18] Saviq, is like a cast shadow on the divider, no? [13:18] Saviq, lighting should be outside [13:18] Cimi, yes, but can't be right now due to z-ordering [13:19] Saviq, so you have to do fully opaque line [13:19] Cimi, needs fixing in LVWPH [13:19] under the lighting === MacSlow|lunch is now known as MacSlow [13:19] mterry, what about notification positioning? [13:20] put a rectangle line of opacity 1.0 using bg color [13:20] Cimi, TBH I don't get why it should be non-opaque at all [13:20] then on top the highlight [13:20] Saviq, it should what? [13:20] Cimi, don't get why it's 0.6 at all [13:21] Cimi, unless it's to let the non-solid (image) background through [13:21] Saviq, that one [13:21] Cimi, anyway, can we fix after? I have to remerge 5 branches every time I change that one :P [13:21] Saviq, sure [13:22] Cimi, we'll sort out z and put it in the right place [13:22] Saviq, was working before [13:22] Cimi, no it wasn't, not with a solid background [13:22] Saviq, on my patch, the lighting outside [13:22] Cimi, no it didn't, not with a solid background [13:23] Cimi, the red scope [13:23] Cimi, in tryDash [13:23] I'll merge and try your then [13:24] Cimi, you and your ideas... now I need to try and find out the top color of the navigation background [13:24] Cimi, which is impossible in the case when it's an image of course [13:24] mzanetti: what was the "other use case" you'd break with the qtmir workaround for uoa using trusted prompts ? [13:24] Saviq, we can use shader for that [13:25] Cimi, sounds expensive for a stupid effect like that [13:25] Saviq, it is :D [13:25] Cimi, when 99.99999% of the time it's going to be solid [13:25] I think we acn just approximate that [13:27] Saviq, the highlight at the bottom of the divider is a punch in the eye [13:28] Saviq, can we remove it for now? [13:28] what's wrong with it? [13:28] Saviq, try with open library [13:28] 18 GU [13:28] or yahoo finance [13:29] ok yeah, not too great [13:29] Cimi, ok, putting it outside, we don't have solid backgrounds anywhere anyway [13:29] yeah [13:30] Saviq, add TODO [13:33] Cimi, check now [13:33] before I start remerging again [13:33] Saviq, did u push? [13:33] Cimi, now [13:34] Saviq, ok that looks nice [13:34] apart weather channel [13:34] but that's their fault [13:35] the divider is supposed to be darker than the page [13:35] because is a bottom layer [13:36] Cimi, ok, anything more to fix in that branch? because I'm merging :P [13:36] Saviq, text in overlay card is not aligned horizontally [13:37] was it due to my card branch? [13:37] it's even on your TODO [13:37] my TODO? [13:37] :D [13:37] Cimi, yes, you put it on your TODO [13:37] I suppose [13:37] yeah [13:38] yeah I can see it [13:38] another issue overlay black texture does not fill the ubuntushape [13:39] that's because it's a hack [13:39] Saviq, http://i.imgur.com/DfTeszL.png [13:39] Cimi, yeah, complain to Loïc :P [13:40] jeez if only pushing one line wouldn't take 15s... === Malinux_ is now known as Malinux [13:40] I wonder what VCS we could be using instead that wouldn't have caused me to waste so much time [13:40] OWAIT [13:41] ... [13:41] [14:06] kgunn: see the linked branch [14:09] ack [14:11] Saviq: where could I see the previewtable in action? [14:12] tryPreviewTable is bit minimalistic [14:12] mzanetti, only in test currently [14:14] Saviq: https://code.launchpad.net/~unity-team/unity8/tablePreviewWidget/+merge/230787 [14:15] Saviq, mzanetti: dynamically created qml objects can be reparented easily enough, I assume, yes? [14:16] mterry, even non-dynamically created ones [14:16] mterry, parent = foo [14:16] mterry, dynamically created ones you can parent as you create them (arg to createObject on a component) [14:17] Saviq, right. And does re-parenting them move them around visually like I'd expect (i.e. place them under/over/with-siblings)? [14:17] mterry, yes, they re-anchor, change coordinate space etc. [14:18] mterry, that's what Repeater does for example, it parents all the created delegates to its own parent [14:18] that's the only reason why Columns work around repeaters [14:18] Saviq, OK.. thanks makes sense [14:25] mzanetti: did you come to a consensus about the trust session issue? [14:25] dednick: yeah, seems the conversion of UOA to trusted session is in a silo already [14:26] dednick: which means the issue should go away soon for the proper solution [14:26] dednick: however, Saviq added a question on the bug report which I guess you can answer better than I can [14:29] mzanetti: i've also just commented on your branch. it wasn't a suitable solution for the issue in any case. [14:29] dednick: I rejected that branch already [14:29] mzanetti: yup. i know :) [14:31] mterry: nono... you won't get away with this one that easily: https://bugs.launchpad.net/unity8/+bug/1357230 === cyphermox__ is now known as cyphermox [14:31] :P [14:31] Ubuntu bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] [14:32] mzanetti, interesting, OK [14:38] cheap karma: [14:38] https://code.launchpad.net/~saviq/unity8/preview-overview/+merge/230903 [14:38] https://code.launchpad.net/~saviq/unity8/fix-notification-indicator-title/+merge/230971 [14:38] https://code.launchpad.net/~saviq/unity8/fix-horizontal-list-activation/+merge/230985 [14:38] @unity ↑ [14:39] Saviq: you didn't reply on that one: "Are we ok with reaching out of context for widgetData?" [14:39] Saviq: I guess we are [14:40] Saviq: you going to be in office next week? [14:42] Saviq: so heard thru grapevine, on favorite/unfav....we're asking for some backend changes, so prob won't see that land till mid next week [14:42] dednick, yes, Mon→Wed [14:42] ? [14:43] kgunn, yeah, Paweł will only be in on Monday, so then [14:43] cool [14:43] @unity and someone could take over https://code.launchpad.net/~mterry/unity8/dialer-in-greeter/+merge/230362 too [14:43] I've settings to review still [14:44] Cimi, you're doing proper review of alt nav then? [14:46] Saviq, was reviewing header [14:46] Saviq, which seems to be fine [14:46] Saviq, I have to review alt test [14:46] Cimi, right, you did have a look at it already, so should be good [14:46] Cimi, one thing I still need to fix there is your freakin' highlight ;P [14:46] hah [14:47] Saviq: yeah. i'll take it. [14:48] dednick, thanks [14:48] * Saviq thinks anyone who has a devel branch can learn from us juggling 20 branches in a silo :P [14:52] Saviq: I must admit its working out better than I expected indeed ^ [14:52] and yes, now it actually feels a devel branch would be a waste of time [14:52] mzanetti, if only we used git... [14:52] * mzanetti is still ok with bzr :D [14:52] mzanetti, well, with 7 chained branches [14:52] mzanetti, every time i have to touch the bottom one [14:52] ok yeah... that sucks. but would git help there? [14:53] mzanetti, it takes me up to 10 minutes to get the other ones remerged [14:53] mzanetti, yeah, it's faster all round, and less conflicts in case of criss-cross and such [14:53] mzanetti, I wouldn't actually have to remerge [14:53] hmm ok. bzr does behave weird with merging sometimes [14:53] mzanetti, as the top one would get rebased on the previous one, that on the one before etc. [14:54] sure, if there's conflicts you need to rebase [14:54] but bzr gets awry even if there are none (or well, maybe it's LP's fault actually) [14:54] still I'd work 2x fast [14:55] then 1/2 of us would be out of a job [14:55] :) [14:55] yeah... not sure if saviq should work even faster [14:55] well, just when remerging :P [14:56] * greyback takes away Saviq's QtCreator and hands him sed [14:56] greyback: don't I'm sure he'll find a way to get even more productive with that [14:57] should have been: don't! I'm... [14:57] greyback, I'm doing Vim mode in QtC, slows me down enough requiring to type every symbol's first letter twice... [15:00] greyback_ you have a slower-down of your own today ;) [15:01] don't talk to me [15:01] bloody internet today is hopeless [15:01] me talking to you on IRC saturates the connection eh? [15:01] not just me, mates wit hthe same ISP have found the speed plummeted [15:02] it's not funny. During Mumble, I was pinging a server, and mumble was breaking up until I stopped the pinging [15:02] ... [15:04] Cimi, very first instalment https://code.launchpad.net/~cimi/unity8/scope-settings/+merge/230182/comments/561558 [15:04] Cimi, you broke preview opening [15:05] "more to come" [15:05] hah [15:05] sounds like a menace [15:08] Saviq, how do I set the focus? [15:09] Cimi, .forceActiveFocus() [15:09] ah [15:09] Saviq, i was doing focus = true [15:11] Cimi, not enough, more afternoon reading: http://qt-project.org/doc/qt-5/qtquick-input-focus.html ;) [15:11] Saviq, it's friday! :D [15:11] Saviq, got a lot of stuff for lp:~unity-team/unity8/seeLessStuckBottom. So I actually made a patch for it. Since that branch is on ~unity-team, can I just push to it and have you review my patch instead? Or you review my patch then I push to it [15:12] dandrader_, sure, is fine === dandrader_ is now known as dandrader [15:12] Cimi, but please focus on the preview opening [15:12] Cimi, that's the biggest issue so far [15:12] Saviq, I fixed focus already [15:12] sure [15:13] Saviq, I am merging horizontal list now (which is just fixing test) [15:13] Cimi, yups [15:14] Saviq: hm. indicator panel doesnt respond when you first boot phone. [15:14] dednick, mzanetti reported bug [15:14] bug #v [15:14] 1357230 [15:14] Saviq: ah [15:14] #1357230 [15:14] bug #1357230 [15:14] bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] https://launchpad.net/bugs/1357230 [15:14] daaamn ctrl [15:14] dude... you seem to struggle a lot wiht your keyboard lately [15:15] got a new one? [15:15] mzanetti, new palm rest, yeah [15:15] heh [15:15] the only thing that's not new in this laptop... is the screen I think [15:16] Saviq, I have one fail but they all say pass [15:16] and well, periphery like memory, ssd, expansion cards [15:16] hm. why don't we get an active call hint when the greeter is locked... [15:16] interesting [15:16] Cimi, XFAIL? [15:16] Cimi, that's expected fail == negative test == pass [15:16] can't get back to the dialer after lock/unlock phone [15:17] Saviq, http://paste.ubuntu.com/8054471/ [15:17] Cimi, hah [15:18] XPASS : qmltestrunner::GenericScopeView::test_header_style(Default) 'Could not find the title image.' returned TRUE unexpectedly. () [15:18] Cimi, XPASS is unexpected pass [15:18] there's an expectedFail() that doesn't fail in that test [15:19] mterry: https://code.launchpad.net/~mterry/unity8/dialer-in-greeter/+merge/230362/comments/561563 [15:19] Cimi, weird, though, they passed fine here after I merged [15:20] dednick, replied [15:21] mterry: er, not show the panel? [15:21] how do we know battery? [15:21] or time? [15:21] dednick, only when in call [15:21] dednick, not normal greeter mode [15:22] mterry: sorry, i don't get it? in normal greeter mode, we show panel? [15:22] dednick, again, they may be flexible on it, we can go back to them if we want [15:23] dednick, yeah we show the panel on the greeter. But if you're in a call while the greeter is active, we don't show it [15:23] mterry: i'm pretty sure i'm in greeter on a call, and i can see a panel [15:24] ah. but cannot drag [15:24] mterry: is that what you meant? [15:25] dednick, no [15:25] mterry: it doesn't show if you have the dialer-app screen up though. but it does in the greeter [15:25] dednick, right [15:26] dednick, but with that second branch I linked, you should always be in dialer-app screen when on a call with the greeter active [15:26] mterry: ah. i didn't see the link. [15:26] duh [15:27] well that's fine. if we're always in call then dont need active call hint :) [15:27] Saviq, my pc is faster than yours [15:27] Cimi, of course it is, I was testing in xvfb [15:27] Saviq, I need to add a little wait and it works [15:28] of course I am not adding a wait [15:28] I want to find what tryCompare to put [15:28] dednick, yeah hopefully :) [15:28] sth here http://paste.ubuntu.com/8054542/ if you have a clue Saviq [15:29] replacing the verify with a tryCompare? [15:29] Cimi, no, this is a negative test [15:29] Cimi, which means in tryCompare it will pass, too, [15:30] Saviq, without a wait(50) before that verify, it fails on my machine [15:30] actually before even the verify [15:30] Cimi, sure, but that just means you need to wait *before* the findChild [15:30] yesh [15:30] I put wait(50) here indeed [15:31] but I hate wait [15:31] can I put sth else? [15:33] Cimi, you have a tendency of pasting three lines and expecting people understand what they mean [15:33] Cimi, CONTEXT [15:33] Saviq, http://paste.ubuntu.com/8054591/ [15:34] Saviq, without that wait it XPASS [15:34] of course forgot to put data http://paste.ubuntu.com/8054595/ [15:38] Cimi, that's rather weird, what does console.debug(image) say before the wait()? [15:38] and after, for that matter [15:39] Saviq, QDEBUG : qmltestrunner::GenericScopeView::test_header_style(Default) qml: QQuickImage(0x303bec0, "titleImage" [15:40] Cimi, iiinteresting, I wonder where it finds that image [15:41] Cimi, and if you do: [15:42] http://pastebin.ubuntu.com/8054662/ [15:44] Cimi, can you add onSourceComponentChanged and onStyleChanged in Background.qml [15:44] print the values of course [15:45] Saviq, with the double print, the second one does is null [15:45] Cimi, k, got a diff for you in a mo [15:46] Saviq, it can be some async stuff [15:46] Cimi, thank you [15:47] Cimi, check this out [15:47] http://paste.ubuntu.com/8054695/ [15:48] Saviq, the darkening on the divider should be disabled in overview [15:48] Cimi, is it visible there at all? [15:48] Saviq, I think it is [15:48] Cimi, right, just the highlight [15:49] Cimi, the other is made invisible due to showSignatureLine [15:49] k will fix [15:49] Saviq, I saw a dark line iirc before [15:49] I will test later [15:49] Cimi, it's inside the divider which is invisible, so that dark line might've been the highlight is all [15:50] mterry: hey, I think this one is ready: https://code.launchpad.net/~mzanetti/unity8/new-lockscreen-design/+merge/230478 [15:51] mzanetti, ok will review after lunch [15:54] Saviq, FAIL! : qmltestrunner::GenericScopeView::test_header_style(Default) property status [15:54] Actual (): 1 [15:55] this is before setting scope though [15:55] Cimi, well, yeah, that's the idea [15:56] Cimi, you can check on sourceComponent that it's null [15:56] Cimi, basically you need to wait for the Background to unload from the previous scope [15:57] Saviq, in cleanup? [15:57] Cimi, nah, because that's the only test looking at the background [15:57] Cimi, so just at the beginning of the test [15:59] Saviq, it is not enough [15:59] Saviq, despite that, I still have random failures [16:00] Saviq, can I put a wait and a fixme? [16:00] Cimi, it's not failing on jenkins, so just leave it be [16:00] Cimi, does it fail for you under xvfb too? [16:02] Saviq, no [16:03] Cimi, so yeah, leave it be [16:04] Cimi, does it fail in trunk too? [16:06] mzanetti, can you link me to the visual designs you based new-lockscreen-design off of? [16:10] Saviq, wtf: if I run unity8 with run.sh, previews are fine [16:11] Saviq, if i run with start unity8-dash BINARY=$PWD/builddir/src/Dash/unity8-dash ARGS=-mousetouch [16:11] Cimi, yeah, and how's that weird? [16:11] the index is not sent [16:11] Cimi, run.sh results in system-wide dash being started [16:11] oh fuck [16:11] Cimi, it's like that since dash-as-app [16:12] I had no idea [16:12] there's a branch fixing this particular issue https://code.launchpad.net/~saviq/unity8/tweak-runscript [16:12] Cimi, but not ready yet [16:12] 'cause run_on_device doesn't work still [16:17] Saviq, the index issue is the usual issue with bindings and loader [16:17] Saviq, how do we workaround those problem? [16:17] Cimi, what's "the usual issue with bindings and loader"? [16:18] Saviq, currentIndex can be set from genericScopeView and from inside PrevireListView [16:18] where sometimes we had a proxy [16:19] basically what happens is that, when you click on an app [16:19] 1) this sets the loader property currentIndex to the index of the app [16:19] Cimi, not sure what you mean, but if you mean that sedding index doesn't "register" [16:19] Cimi, because it's too early [16:19] 2) then onLoaded it sets a binding to the item [16:19] Cimi, and then it resets to 0 when model is loaded [16:20] but inside previewListView, the currentIndex is set to 0 [16:20] so it loses [16:20] Saviq, pretty much [16:21] Saviq, how do we deal with this issue? [16:21] Cimi, then you need a "init" property in the PreviewListView or something, and a separate property for the initial index [16:21] Cimi, and on model loaded you need to set it to that index [16:21] I see [16:22] Cimi, it's basically a lack in ListView API, it should have an initialIndex property [16:22] and inside the listview, currentIndex : root.initialValue [16:22] got it [16:22] Cimi, yeah, something of the sort [16:22] thanks [16:24] Cimi, reviewed, only tests left [16:25] Saviq, ok, monday :P [16:25] Cimi, yeah, if you can fix the previews folks would be happy monday morning though [16:26] Saviq, yeah [16:26] Saviq, but your review seems long [16:26] and I am frankly tired [16:26] Cimi, tired is a state of mind ;) [16:26] started quite early today too [16:26] hah [16:26] Cimi, yeah, ok, not a huge issue when you know about it [16:35] Saviq, on model loaded? [16:35] how? [16:35] Cimi, onCountChanged > 0 probably [16:35] Cimi, or > initialIndex for that matter [16:36] Cimi, or onModelChanged can be enough === gatox is now known as gatox_lunch [16:37] Saviq, countChanged [16:37] mterry, can I ask you for a blind ACK on https://code.launchpad.net/~saviq/unity8/fix-notification-indicator-title/+merge/230971 [16:38] mterry, just look at your phone ;) [16:38] Saviq, http://paste.ubuntu.com/8055088/ [16:38] that seems to work [16:39] Cimi, yeah, good enough [16:39] Saviq, onModelChanged is too early [16:39] Cimi, it's kinda wasteful 'cause it will load the first delegate and destroy it straight away [16:39] Saviq, onCount works [16:39] Saviq, done [16:39] Cimi, but what can you do... [16:39] mterry, tx [16:40] mterry, could use a less blind one of https://code.launchpad.net/~saviq/unity8/fix-horizontal-list-activation/+merge/230985 if you're up for it (and MacSlow isn't in the middle of it already?) [16:40] Saviq, https://bugreports.qt-project.org/browse/QTBUG-12576 ? [16:41] Saviq, mterry: I'm not on that one [16:41] Cimi, yeah, that assumes that model is static [16:41] Saviq, in fact I tried and not works [16:41] Cimi, if it's assigned anywhere after onCompleted, you're screwed [16:41] Cimi, yeah, it wouldn't [16:41] Saviq, sure I can look [16:42] Cimi, 'cause it's reset on model change (for good reasons) [16:49] Saviq, ok I should have fixed also no overview in settings [16:49] Saviq, next week cosmetic changes, but functionality is there [16:49] Cimi, coolz, thanks, have a good weekend [16:49] Saviq, when you arrive monday? [16:50] Cimi, I'm in Sunday night [16:50] Saviq, how come tryGenericScopeView gives an empty view? (or is that something on my end?) [16:50] mterry, yeah, there's no scope by default [16:50] mterry, I fixed that in scope settings branch [16:51] Cimi, sounds like maybe why the test started failing? ;) [16:51] Saviq, Cimi: thankks [16:51] mterry, we generally do tryDash to get a more complete experience [16:51] Saviq, I tried removing that [16:51] Saviq, it doesn't make difference [16:52] Saviq, I'll fix your review things then pop in to the office [16:52] better to skip rush hour if I can [16:52] Cimi, I imagine we'll be quite busy (there's actually a schedule!) [16:52] Cimi, but yeah, see you there [16:52] ah! [16:52] ok [17:04] Saviq, are we putting the latest revisions on silo 17? [17:04] Cimi, yeah, I'll rebuild it soon [17:04] Cimi, will just land already approved stuff through 18 first [17:05] in an effort to get green CI again... [17:06] * greyback_ eow [17:06] o/ === alan_g is now known as alan_g|EOW [17:12] facundobatista, can you top-ack https://code.launchpad.net/~saviq/unity-scope-scopes/fix-overview-search-mapping/+merge/230966 please? [17:13] Saviq, with top-ack you mean approve the merge proposal? [17:13] facundobatista, yup :) [17:14] Saviq, I can't [17:14] facundobatista, right, though so, will find another victim, thank you :) [17:14] (don't have launchpad permissions to do it) [17:15] mzanetti, did you resolve the hang on run_on_device ? [17:16] Saviq: well, not resolve... I commented away the -jsdebugger arg [17:16] ah that [17:29] mterry, btw that's the branch (lp:~macslow/unity-notifications/fix-1354406), which will allow exposing a notification's triggering app-name on the renderer-side. This is just the backend-portion needed to fix LP: #1354406. Adding the frontend (renderer) bits is very easy once this landed. [17:30] Launchpad bug 1354406 in unity8 (Ubuntu) "PIN-locked phone becomes unresponsive after simultaneous alarms" [High,In progress] https://launchpad.net/bugs/1354406 [17:30] mterry, should that turn out to be needed, I can provide that too === gatox_lunch is now known as gatox [17:44] MacSlow, yeah if we implement it like design wants, we'll need that on frontend === _morphis is now known as morphis [20:11] mterry, did you see bug #1357230 btw? [20:11] bug 1357230 in Unity 8 "After booting, indicators and launcher can't be pulled in over Greeter" [Critical,Confirmed] https://launchpad.net/bugs/1357230 [20:11] Saviq, working on it right now, I think it's because LightDM.Greeter.authenticated is nonNOTIFYable [20:11] mterry, ktx, just wanted to make sure it's on your radar === salem_ is now known as _salem