| davecheney | thumper: grrr | 00:06 |
|---|---|---|
| davecheney | this canWatch("") thing is really pernicious | 00:06 |
| davecheney | gonna take some more time | 00:06 |
| * thumper looks in a dictionary | 00:06 | |
| davecheney | keep finding more test cases that fail whenever I make AuthAlways demand a valid tag | 00:07 |
| thumper | heh | 00:07 |
| thumper | it will be worthwhile | 00:07 |
| thumper | you're doing a good job | 00:07 |
| thumper | keep it up :) | 00:07 |
| menn0 | now that's what I call Managing :-p | 00:07 |
| menn0 | and Github is broken... | 00:27 |
| menn0 | Storage server temporarily offline. See http://status.github.com for GitHub system status. | 00:27 |
| menn0 | the graphs on that page show a sudden spike in Exceptions | 00:28 |
| waigani | I'm getting random prs going offline e.g: https://github.com/juju/juju/pull/499 | 00:30 |
| waigani | and https://github.com/juju/juju/pull/517 | 00:31 |
| waigani | can others see those prs? | 00:32 |
| waigani | oh, haha menn0 I just read your messages above | 00:32 |
| waigani | that would explain it | 00:32 |
| menn0 | haha | 00:33 |
| menn0 | status.github.com is now broken too :) | 00:33 |
| menn0 | "Service Unavailable" | 00:33 |
| menn0 | it's back | 00:33 |
| menn0 | and now they have a note that they know something is wrong with some repos | 00:34 |
| menn0 | awesome | 00:36 |
| menn0 | thumper: my merge passed its test run but CI was unable to perform the merge because the repo on Github is borked ("Repository offline") | 00:37 |
| menn0 | thumper: once Github is back will a manual merge be possible? | 00:38 |
| thumper | hmm... | 00:38 |
| thumper | I'd say go with CI doing it again | 00:38 |
| thumper | github say some repos are borked? | 00:39 |
| menn0 | thumper: yep. See the email I just forwards to juju-dev. | 00:41 |
| menn0 | thumper: the web stuff seems to be fine but interacting with the repo isn't working. | 00:41 |
| thumper | :( | 00:42 |
| menn0 | thumper: it's back again | 00:42 |
| menn0 | can someone have a quick look over this? It's the 1.20 backport of the tools version change that's going in to trunk. https://github.com/juju/juju/pull/538 | 00:44 |
| menn0 | thumper: the bot won't pick up the PR that it's already tested | 00:59 |
| menn0 | thumper: any chance you can click the merge button (I thought team leads could do this) | 00:59 |
| menn0 | thumper: the tests passed here: http://juju-ci.vapour.ws:8080/job/github-merge-juju/328/ | 00:59 |
| menn0 | thumper: the PR is here: https://github.com/juju/juju/pull/535 | 01:00 |
| thumper | wallyworld_: do you know how to kick this bot? | 01:01 |
| wallyworld_ | wot | 01:01 |
| wallyworld_ | bot is kicked | 01:03 |
| thumper | wallyworld_: ta | 01:04 |
| thumper | nice | 01:04 |
| wallyworld_ | you just need a "Build Failed: blah" comment | 01:04 |
| wallyworld_ | to tell the bot that a $$ $$ is valid | 01:04 |
| wallyworld_ | a second $$ $$ i should say | 01:05 |
| wallyworld_ | thumper: could i get you to look at this pr. it's a 1.20 only fix to address an lxc startup issue https://github.com/juju/juju/pull/539 | 01:45 |
| thumper | ack | 01:45 |
| wallyworld_ | ta | 01:45 |
| davecheney | thumper: menn0 waigani https://github.com/juju/juju/pull/540 | 01:48 |
| davecheney | ^ quite a nice solution i think | 01:49 |
| * thumper afk for bit from 2pm | 01:50 | |
| wallyworld_ | axw: once you finish your maas branch changes, i just wanted to have a quick chat about copying tools | 02:03 |
| axw | wallyworld_: sure | 02:03 |
| wallyworld_ | ta, just ping me | 02:03 |
| * bigjools cracks joke about copying wallyworld_ | 02:03 | |
| * wallyworld_ tells bigjools to FO | 02:04 | |
| axw | wallyworld_: changes uploaded, ready to chat when you are | 02:08 |
| wallyworld_ | axw: i'll just lgtm first, one sec | 02:09 |
| wallyworld_ | axw: i'm still not sure why we need to pass in the series to the tools match, when we get the series from the tools we are matching on. the only reson i can see ottomh is so that we get the error if there is more than one series | 02:11 |
| axw | wallyworld_: ah, right | 02:12 |
| axw | I don't know why I did that now | 02:12 |
| axw | wallyworld_: I've taken it out, that was nonsense AFAICT | 02:13 |
| wallyworld_ | ok, i've marked it as lgtm | 02:13 |
| axw | thanks | 02:13 |
| wallyworld_ | join you in stand up | 02:13 |
| menn0 | axw or wallyworld_: can you do a 10s look at this please? https://github.com/juju/juju/pull/538 | 02:14 |
| wallyworld_ | sure | 02:14 |
| wallyworld_ | 10, 9, 8, .... | 02:14 |
| menn0 | it's the 1.20 backport of the agent.conf tools version change that just went in | 02:14 |
| menn0 | axw: thanks | 02:23 |
| axw | np | 02:23 |
| axw | jcastro: https://plus.google.com/102738380796586573408/posts/BD1bYop5x7z | 02:51 |
| axw | (the post I got you to review) | 02:52 |
| axw | wallyworld_: ^^ finally published | 02:52 |
| wallyworld_ | axw: \o/ - i was meaning to ask you about that but kept forgetting | 02:52 |
| axw | wallyworld_: was waiting for a new 1.20 release | 02:53 |
| wallyworld_ | ah, yes | 02:53 |
| davecheney | axw: appears to be truncated | 02:56 |
| davecheney | Work on llgo has been progressing, mostly due to Pe... | 02:56 |
| axw | oh ffs | 02:57 |
| axw | the link dropped | 02:57 |
| axw | davecheney: thanks, fixing | 02:57 |
| axw | jcastro: wallyworld_: davecheney: https://plus.google.com/+AndrewWilkinsTheFirst/posts/EfTDNXS4SET | 02:59 |
| menn0 | davecheney, wallyworld_: bug 1358078 sorted for trunk and 1.20 \o/ | 03:16 |
| mup | Bug #1358078: cmd/juju: juju bootstrap --upload-tools on a fresh environment triggers upgrade mode <juju-core:Fix Committed by menno.smits> <juju-core 1.20:Fix Committed by menno.smits> <https://launchpad.net/bugs/1358078> | 03:16 |
| wallyworld_ | great :-D | 03:16 |
| wallyworld_ | thank you | 03:16 |
| davecheney | nnnice | 03:17 |
| menn0 | wallyworld_: just for you :) https://github.com/juju/juju/pull/541 | 03:55 |
| wallyworld_ | oh goody | 03:55 |
| davecheney | thumper: if you have a momemnt, i've replied to your comments, https://github.com/juju/juju/pull/540 | 03:57 |
| thumper | davecheney: ack | 04:10 |
| menn0 | wallyworld_: thanks for the review. merging now. | 04:11 |
| wallyworld_ | np, thaks for fixing | 04:12 |
| davecheney | thumper: thanks for the review | 04:14 |
| davecheney | one more coming up real soon now | 04:14 |
| thumper | kk | 04:14 |
| davecheney | it's very similar | 04:16 |
| davecheney | what I think happened is we started out with the common.AuthFunc | 04:17 |
| davecheney | which says "this authoriser" can read/write/view/etc this entity (tag) | 04:17 |
| davecheney | but common.Environ{,Machines}Watcher are really "global" | 04:17 |
| davecheney | things | 04:17 |
| davecheney | this is also indicatated that Authtorizer.AuthEnvionWatcher is not derived from the entity of the authoriser | 04:18 |
| davecheney | it's actually some special permission bit stored in the database | 04:18 |
| davecheney | menn0: nice cleanup of the upgrade stuff | 04:20 |
| davecheney | +1 | 04:20 |
| menn0 | davecheney: cheers | 04:22 |
| thumper | waigani: can you email matty and say you'll take over the EnvUser work? | 04:37 |
| thumper | axw, wallyworld_: do you know if fwereade is working this week? I normally leave before he would start | 04:38 |
| wallyworld_ | yes he is | 04:38 |
| thumper | ok.. | 04:38 |
| waigani | thumper: this branch: https://github.com/juju/juju/pull/432 | 04:38 |
| thumper | cheers | 04:38 |
| thumper | waigani: yes | 04:38 |
| waigani | thumper: okay, I was on call reviewer today. I'll make a start on it tomorrow. | 04:38 |
| thumper | waigani: can I get you to email him before EOD today, so he'll see it? | 04:39 |
| waigani | thumper: doing it now | 04:39 |
| thumper | cheers | 04:39 |
| thumper | waigani, davecheney, menn0: fyi - I have friday off | 04:39 |
| waigani | okay, thanks for the heads up | 04:39 |
| * thumper just realised that I also have a meeting friday morning... | 04:40 | |
| thumper | hmm... | 04:40 |
| menn0 | waigani, davecheney: party time! | 04:40 |
| * thumper emails rick_h__ et al | 04:40 | |
| menn0 | wallyworld_: aaaaaaand here's the 1.20 port: https://github.com/juju/juju/pull/542 | 04:46 |
| wallyworld_ | thanks menn0 | 04:48 |
| menn0 | wallyworld_: thanks. I'll leave you alone for the rest of the day :) | 04:48 |
| wallyworld_ | promise,promises | 04:48 |
| davecheney | thumper: https://github.com/juju/juju/pull/543 | 04:59 |
| thumper | davecheney: done, and now I'm off to guardians of the galaxy | 05:03 |
| thumper | \o/ | 05:03 |
| davecheney | TheMue: danka | 05:04 |
| davecheney | enjoy | 05:04 |
| davecheney | i really hope this is the last little fucker | 05:05 |
| menn0 | davecheney: thumper was gone when you replied so autocomplete got the wrong person :) | 05:05 |
| davecheney | oopas | 05:06 |
| davecheney | TheMue: sorry mate | 05:06 |
| === urulama-_ is now known as urulama | ||
| davecheney | wallyworld_: Fetched 8,775 kB in 5s (1,593 kB/s) | 05:37 |
| davecheney | Reading package lists... | 05:37 |
| davecheney | + sudo apt-get upgrade -y | 05:37 |
| davecheney | is there any way to stop the bot | 05:37 |
| davecheney | doing apt-get update/upgrade for every CI run ? | 05:37 |
| davecheney | that isn't necessary | 05:37 |
| davecheney | https://github.com/juju/juju/pull/545 | 05:50 |
| davecheney | anyone for a little one ? | 05:50 |
| davecheney | it's pretty uncontravesial | 05:50 |
| wallyworld_ | davecheney: apt updates are necessary to pull in all the deps required | 05:54 |
| davecheney | wallyworld_: nah | 05:55 |
| davecheney | why is it updating the kernel and building an initrd | 05:55 |
| wallyworld_ | the instances started to run the test aren't necessarily up to date | 05:55 |
| davecheney | that is a waste of time | 05:55 |
| wallyworld_ | sure, but besides the kernel it also pulls in other dependencies that are needed AFAIK | 05:56 |
| dimitern | morning all | 05:56 |
| axw | wallyworld_: my memory is hazy, why do we need auto-upload on bootstrap? why not just require people to --upload-tools? | 06:19 |
| wallyworld_ | axw: from memory, it was "too hard" and the out of the box experience should be that it Just Works if there are no matching prepackaged tools available | 06:20 |
| axw | wallyworld_: mk. I'm not sure it holds its weight given that it only applies to dev builds | 06:21 |
| axw | it's a bit of a PITA to try to get it to work the same way in my new branch | 06:22 |
| wallyworld_ | i'm not personally wedding to the idea of it being automatic - it was done because of user requests | 06:22 |
| wallyworld_ | wedded | 06:23 |
| wallyworld_ | we can look to get your stuff landed and see if it can be tastefully added back in | 06:23 |
| fwereade | wallyworld_, axw: IMO --upload-tools is pretty fundamentally broken | 06:23 |
| wallyworld_ | i wish we could drop it | 06:24 |
| wallyworld_ | but we've been told we can't | 06:24 |
| fwereade | wallyworld_, axw: but the magical fall back to locally available tools is a good thing | 06:24 |
| axw | fwereade: remind me why --upload-tools is fundamentally broken? | 06:26 |
| TheMue | Morning | 06:34 |
| TheMue | dimitern: I'm at a funeral this morning. So I'll start after lunch. :( | 06:36 |
| dimitern | TheMue, oh :( alright then | 06:36 |
| TheMue | dimitern: I would like to discuss your idea then. IsManual is special to machines, so I would place it at machiner.Machine, not agent.Entity. | 06:37 |
| TheMue | dimitern: Will ping you then. | 06:37 |
| dimitern | TheMue, ok, we'll discuss it | 06:37 |
| TheMue | dimitern: Thanks | 06:38 |
| Beret | wallyworld_, anyway we can get whatever fix you guys deem appropriate for https://github.com/juju/utils/pull/22 in 1.20.x ? | 06:58 |
| wallyworld_ | Beret: i think so. by the looks of the comment from kapil, the approach needs to be re-thought. we can try and get it done for 1.20.6 | 07:00 |
| Beret | thanks | 07:01 |
| wallyworld_ | i'm hoping that 1.20.6 might be able to be released this time next week | 07:01 |
| Beret | +1 | 07:01 |
| Beret | we're trying 1.20.5 but from the looks of the bug fix list, it should be pretty solid | 07:01 |
| Beret | hoping so | 07:01 |
| wallyworld_ | we're still struggling a bit to inderstand fully the lxc issues being seen | 07:01 |
| Beret | that's the only thing really outstanding still right? (other than this apt retry thing) | 07:02 |
| wallyworld_ | there's a few other smaller bugs | 07:02 |
| wallyworld_ | Beret: if there's any extra info that can be provided for bug 1354027 that would be great eg contents of /var/lib/juju/containers when it fails | 07:03 |
| mup | Bug #1354027: LXC was not created, no errors, no logs -> pending state. <cloud-installer> <landscape> <juju-core:Triaged> <juju-core 1.20:Triaged> <https://launchpad.net/bugs/1354027> | 07:03 |
| Beret | wallyworld_, ok, we'll see what we can do | 07:07 |
| wallyworld_ | thanks :-) | 07:07 |
| fwereade | axw, sorry, I missed your question | 07:07 |
| axw | fwereade: hey, it was | 07:08 |
| axw | fwereade: remind me why --upload-tools is fundamentally broken? | 07:08 |
| fwereade | axw, the biggest issue with upload-tools is that it's the core reason tools distribution was always so awful | 07:08 |
| fwereade | axw, it was a separate code path written *really* early on | 07:08 |
| fwereade | axw, and the developers were *always* using upload-tools | 07:09 |
| fwereade | axw, and so the real code paths... well, they barely even existed, and certainly weren't mature, when we first released | 07:09 |
| fwereade | axw, then users found out about upload-tools | 07:09 |
| fwereade | axw, which obscures really important info, like *which damn build is running* | 07:10 |
| fwereade | axw, but let them actually use juju | 07:10 |
| fwereade | axw, so it got kinda promoted | 07:10 |
| fwereade | axw, and hangs around our necks to this day | 07:11 |
| axw | ok | 07:11 |
| fwereade | axw, finding local tools of matching version and using those automatically, though? that's fine IMO | 07:11 |
| axw | fwereade: with the auto upload stuff, I'm trying to avoid having providers call back into common bootstrap code to "ensure tools" | 07:12 |
| axw | I think I can do it, it's just a bit messy | 07:12 |
| axw | in my new branch, environs/bootstrap finds all the available tools, and presents them to provider's Bootstrap | 07:12 |
| axw | that chooses an arch & series and reports that back | 07:12 |
| fwereade | axw, it's always a tough call but I could probably get behind a bit of extra duplication across the providers if we actually simplify what's happening | 07:13 |
| axw | common code then uploads if necessary | 07:13 |
| fwereade | axw, that sounds good | 07:13 |
| fwereade | axw, slightly better fit with what we do for normal machines | 07:13 |
| voidspace | speaking of upload-tools, I think backup is broken if you use it (at least I'm seeing a path issue for mongodump that only seems to happen with upload-tools) | 07:28 |
| voidspace | and that makes it a real pain to test changes to restore... | 07:28 |
| voidspace | jam: TheMue: dimitern: standup? | 10:46 |
| dimitern | sorry, brt | 10:47 |
| jam | voidspace: dimitern, brt, | 10:50 |
| === cliff-hm is now known as cliff-eat | ||
| === cliff-eat is now known as cliff-hm | ||
| voidspace | jam: I don't think you succeeded in pushing your changes | 11:32 |
| voidspace | jam: github thinks that branch is identical to master | 11:32 |
| jam | void | 11:32 |
| voidspace | https://github.com/jameinel/juju/compare/test-local-backup | 11:32 |
| jam | voidspace: master is, but 'test-local-backup' has the interesting stuff | 11:32 |
| voidspace | jam: according to github compare "juju:master and jameinel:test-local-backup are identical." | 11:32 |
| === gsamfira1 is now known as gsamfira | ||
| voidspace | ooh, it looks like restore might be working against an amazon juju | 11:34 |
| jam | voidspace: committing helps | 11:34 |
| voidspace | backup failed until I linked in the commands, but restore has not failed in the same way that restore failed against canonistack | 11:34 |
| voidspace | jam: :-) | 11:34 |
| voidspace | local will definitely be faster | 11:35 |
| voidspace | jam: I was booted out | 12:18 |
| voidspace | jam: https://github.com/voidspace/juju/compare/backup-ssh | 12:23 |
| voidspace | ericsnow: ping | 12:41 |
| voidspace | ericsnow: have you worked on the old backup plugin? | 12:41 |
| TheMue | back again (together with a heavy thunderstorm) | 12:58 |
| jam | TheMue: welcome back, we missed you. How's it going? | 13:06 |
| TheMue | jam: it’s ok, has been the father of a good friend I know for more than 30 years now | 13:15 |
| jam | TheMue: do you have a bug number for the LXC IPv6 issues? | 13:21 |
| jam | I want to raise it in the networking discussion. | 13:21 |
| TheMue | jam: yep, https://bugs.launchpad.net/juju-core/+bug/1358376 | 13:23 |
| mup | Bug #1358376: IPv6 connectivity of LXC containers <ipv6> <lxc> <network> <juju-core:New> <https://launchpad.net/bugs/1358376> | 13:23 |
| ericsnow | natefinch, wwitzel3: standup? | 14:00 |
| wwitzel3 | ericsnow: yep | 14:01 |
| natefinch | ericsnow: coming | 14:01 |
| === ChanServ changed the topic of #juju-dev to: https://juju.ubuntu.com | On-call reviewer: see calendar | Open critical bugs: 1358768 | ||
| sinzui | natefinch, I just reported bug 1358768. Can you find an engineer to fix the regressions | 14:18 |
| mup | Bug #1358768: No tools found in i386 and ppc64el unit tests <ci> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1358768> | 14:18 |
| natefinch | sinzui: will do | 14:32 |
| ericsnow | natefinch: 1-on-1? | 14:34 |
| natefinch | ericsnow: oh yeah, ok | 14:34 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| natefinch | dammit, I'm getting 500s from github trying to look at commits on juju/juju | 17:35 |
| wwitzel3 | natefinch: I was getting that earlier through the browser | 17:36 |
| wwitzel3 | natefinch: though everything through the git command line seemed to be working ok | 17:36 |
| katco | natefinch: wwitzel3: i know they had some storage issues last night | 17:36 |
| wwitzel3 | doesn't help for looking at PRs | 17:36 |
| wwitzel3 | katco: ahh, probably some residual issues from that then | 17:37 |
| katco | wwitzel3: https://status.github.com/ | 17:37 |
| katco | wwitzel3: natefinch: 0:28 UTC: We're investigating problems accessing a small percentage of repositories. | 17:38 |
| natefinch | katco, wwitzel3 : thanks | 17:41 |
| === BradCrittenden is now known as bac | ||
| natefinch | rick_h__: have some time today to talk about charm feature flags? We need to implement support for them, probably this week. | 18:29 |
| rick_h__ | natefinch: sure thing | 19:01 |
| rick_h__ | natefinch: free from now for the next couple of hours | 19:01 |
| natefinch | rick_h__: half hour? trying to unblock CI | 19:01 |
| rick_h__ | natefinch: rgr, shoot me a link when you're ready | 19:02 |
| natefinch | sinzui: fix applied.... required revert of https://github.com/juju/juju/pull/536 | 19:06 |
| natefinch | sinzui: I didn't look too deeply into the cause of the bug, possibly something simple... looks like we're restricting the list of returned tools based on the current architecture... but figured Andrew can fix it when he's on and re-submit. | 19:07 |
| sinzui | thank you natefinch | 19:08 |
| natefinch | sinzui: where do the CI machines keep godeps? I wrote a test that runs godeps and ensures dependencies.tsv matches what godeps outputs.... but the test fails in CI because it can't find godeps. | 19:18 |
| === Ursinha is now known as Ursinha-afk | ||
| sinzui | natefinch, godeps is not available. It is installed to create the tarball, then it is removed because Ubuntu doesn't want it packaged | 19:23 |
| sinzui | natefinch, we need to add godeps to the makefile maybe to ensure it is available for tests | 19:24 |
| sinzui | natefinch, or we tell ubuntu that godeps is now a requirement | 19:24 |
| natefinch | sinzui: how can we run the tests if we don't run godeps first? Sorry, maybe CI was the wrong word... wherever the unit tests get run | 19:26 |
| natefinch | sinzui: I presume there's a machine where we pull down the code, run godeps to set the correct revisions on all the repos, and then run go test. That's the machine I need to be compatible with my test | 19:27 |
| natefinch | sinzui: see here: https://github.com/juju/juju/pull/495 | 19:27 |
| sinzui | natefinch, we test the release, not the code. we test that tarball made in a previous step. | 19:30 |
| sinzui | natefinch, run-unit-test runs make install-dependencies after unpacking the tarball under test to get the deps | 19:31 |
| sinzui | natefinch, Since you name have a test that requires godeps, I think I can justify that the tarball include it. | 19:32 |
| natefinch | sinzui: ok, thanks. Please dump it in $PATH or $GOPATH/bin - those are the only two logical places where developers would have it. | 19:43 |
| sinzui | oh, natefinch, the tarball cannot contain /bin because then the tarball is not a source tarball. | 19:45 |
| sinzui | natefinch, I think we need to change the test rules to build... | 19:45 |
| sinzui | nm, we already call build | 19:45 |
| sinzui | natefinch, I will make changes in a few hours to include godeps in the tarball. | 19:46 |
| sinzui | I will ping you when it is ready | 19:46 |
| natefinch | sinzui: thanks. This is just the tarball we dump on the test machine for testing... we wouldn't be including godeps in the package, right? | 19:46 |
| sinzui | NO | 19:47 |
| sinzui | natefinch, this is the real tarball | 19:47 |
| sinzui | since golang cannot be trusted to always build the same tarball (Ubuntu's opinion) we make it once, we test it as the release, and if it passes, I can release it | 19:47 |
| sinzui | We cannot tamper with the tarball's contents once we make it | 19:48 |
| natefinch | sinzui: ok, sure. If ubuntu's rules require that we include a whole bunch of crap that the actual application doesn't even use, just because it's used to test the application, so be it. I'm tired of trying to fight that fight. | 19:49 |
| sinzui | natefinch, that is indeed the reason they wanted it removed | 19:49 |
| sinzui | natefinch, why doesn't the juju Makefile ensure godeps is installed? | 19:50 |
| sinzui | natefinch, I can make that change too | 19:50 |
| natefinch | sinzui: it looks like on july 7th, it was changed so that it wouldn't install it unless a certain env variable was set | 19:50 |
| sinzui | natefinch, the Makefile or make-package-with-tarball.bash, or run-unit-tests? | 19:52 |
| natefinch | sinzui: https://github.com/juju/juju/blob/master/Makefile#L36 | 19:52 |
| sinzui | natefinch, sorry. I was looking at 1.20. | 19:54 |
| sinzui | natefinch, okay, I will get this change into 1.20 and change run-unit-tests to call it | 19:54 |
| natefinch | sinzui: the godeps build target I think will fail if you don't have the actual code.... possibly it'll just go download all the code for all the dependent repos. | 19:56 |
| natefinch | sinzui: I think the latter | 19:56 |
| sinzui | natefinch, I see it doing go get launchpad.net/godeps | 19:56 |
| sinzui | natefinch, and I can add a step to install it if need be in run-unit-test. | 19:56 |
| natefinch | sinzui: there's two steps, go get launchpad.net/godeps and then godeps -u dependencies.tsv | 19:56 |
| sinzui | I see both in the current Makefile | 19:57 |
| natefinch | sinzui: yes, the second one, godeps -u, will go get all the source code for Juju and set the repos up to be at the correct revision | 19:57 |
| natefinch | (well, it'll get all the source code for juju that isn't under github.com/juju/juju) | 19:58 |
| === urulama is now known as uru-afk | ||
| natefinch | sinzui: *I* don't care that it'll do that.... just warning you that it will, in case that will either a.) fail, or b.) be a problem for some other reason | 19:59 |
| sinzui | natefinch. The making of the tarball 15 minutes before is more likely to catch the problem | 20:00 |
| sinzui | natefinch, when thumper drops a tab, the tarball doesn't build, testing ends immediately because there is nothing to release | 20:01 |
| sinzui | natefinch, So i think think this test will always pass in ci | 20:01 |
| sinzui | natefinch, and the git-merge-juju will do the same since the tarball is made before the unit tests are run from it | 20:02 |
| natefinch | sinzui: This test will *currently* always pass CI, I believe.... but it could fail if we stop running godeps -u first, which is a nice thing to test. Mainly it's for developers who may forget to run godeps -u | 20:04 |
| === Ursinha-afk is now known as Ursinha | ||
| natefinch | rick_h__: do you have time now? | 20:15 |
| rick_h__ | natefinch: sure thing | 20:15 |
| natefinch | rick_h__: https://plus.google.com/hangouts/_/canonical.com/moonstone?authuser=1 | 20:15 |
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| thumper | fwereade: around? | 20:34 |
| * thumper is off to see the physio at 10 | 21:28 | |
| waigani | thumper: AdminUser is defined as a const string in state. Do we want to ditch that and make AdminUser a names.UserTag("admin") ? | 22:11 |
| waigani | thumper: or do we want to build the tag everywhere AdminUser is used? | 22:11 |
| waigani | i.e. names.UserTag(state.AdminUser) | 22:12 |
| waigani | doh just saw thumper is at physio | 22:12 |
| === mup_ is now known as mup | ||
| thumper | waigani: back | 22:42 |
| thumper | waigani: no, we don't want to do that | 22:42 |
| thumper | waigani: I actually have a directive to change the admin user to be the username of the user bootstrapping | 22:42 |
| waigani | thumper: okay, I've just built the usertag where I needed | 22:42 |
| waigani | thumper: I commented another question on the PR for you | 22:43 |
| thumper | which PR? | 22:43 |
| waigani | thumper: 432 | 22:45 |
| waigani | thumper: https://github.com/juju/juju/pull/432/files | 22:45 |
| thumper | kk, otp with hazmat | 22:45 |
| waigani | thumper: basically, are we ready to append env to usernames i.e. bob@local and should I look at doing that in this PR? | 22:46 |
| thumper | waigani: not yet | 22:46 |
| thumper | followed by "it depends" | 22:46 |
| waigani | thumper: I'm good with "not yet" | 22:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!