| rick_h__ | huwshimi: +1 to wht hatch said. Make the parent token deal with show/hide of the widget | 00:54 |
|---|---|---|
| rick_h__ | huwshimi: also heads up, I added a card, there's supposed to be a 'more menu' on each unit on hover as well. | 00:55 |
| rick_h__ | huwshimi: I'm not sure how that works with this 'hover' thing though. it seems a bit messy | 00:55 |
| rick_h__ | huwshimi: but the idea is that's how we expose the 'destroy unit' control for each unit in a machine/container. | 00:55 |
| huwshimi | rick_h__: OK, np | 00:56 |
| rick_h__ | huwshimi: also wanted to poke you about expenses | 01:16 |
| huwshimi | rick_h__: Oh yes, thanks, I need to do that :) | 01:16 |
| rick_h__ | :) | 01:18 |
| hatch | huwshimi: if you'd like I can take a look at what you've got so far | 01:41 |
| huwshimi | hatch, rick_h__: So, if the click handler is on the machine view, how do I figure out what object to attach the more menu to? Just do a bunch of dom queries? The parent could be an unplaced unit, a machine token, a container token, a unit on a container token, a column header etc. | 02:40 |
| huwshimi | I guess on the dots icon I could attach a data-type="unplaced-unit" data-id='wordpress/0' | 02:42 |
| hatch | huwshimi: hey sorry I was outside | 02:45 |
| hatch | yep you're correct | 02:45 |
| hatch | that information will go along for the ride with the click event so you'll have it all available in the handler | 02:45 |
| huwshimi | yuck | 02:46 |
| huwshimi | ok :) | 02:46 |
| hatch | huwshimi: you can also query the parent | 02:46 |
| hatch | e.currentTarget.ancestor('.token') | 02:46 |
| hatch | for example | 02:46 |
| hatch | but the former is much more performant | 02:46 |
| hatch | because you don't need to do any additional queries | 02:46 |
| huwshimi | hatch: That's true, but I'd have to run through a bunch of different DOM queries till it matched the correct type | 02:46 |
| hatch | the tokens aren't all identical? | 02:47 |
| huwshimi | The parent could be an unplaced unit, a machine token, a container token, a unit on a container token, a column header etc | 02:47 |
| huwshimi | It's not just tokens ^ | 02:47 |
| hatch | right, but can't you tell what it is by querying the container of it? They don't all share a common class? | 02:47 |
| huwshimi | Why would they? | 02:48 |
| hatch | in any effect the 'best' is to include the metadata on the element being clicked | 02:48 |
| huwshimi | yeah | 02:48 |
| hatch | it's not yuck, it's really the most performant way of doing it | 02:48 |
| hatch | at that point you can even instantiate the widget and render it all at once instead of instantiating when we render the machine view | 02:49 |
| huwshimi | hatch: Well, it's going to require making sure we copy and paste the correct html all over the place | 02:49 |
| huwshimi | (can't even use a partial as we need to set the data attributes) | 02:50 |
| hatch | partials can have fields | 02:50 |
| hatch | handlebar properties that is | 02:50 |
| huwshimi | Oh | 02:50 |
| huwshimi | Like a 'with foo=bar' kind of thing? | 02:51 |
| hatch | no just like normal handlebars templates | 02:51 |
| hatch | it would also be super easy to figure out if you forgot to add it to your respective template in the handler ` if (e.currentTarget.getAttribute('data-type') === '') { console.error('yo messed up dude'); } | 02:52 |
| hatch | huwshimi: http://yuilibrary.com/yui/docs/handlebars/#partials | 02:53 |
| huwshimi | hatch: I guess on each view that will contain a more menu we could pass some standard attrs, 'more-menu-id' and 'more-menu-type' or something | 02:53 |
| hatch | I don't understand | 02:54 |
| hatch | the ... will be rendered in the token | 02:55 |
| hatch | the token knows what kind it is | 02:55 |
| hatch | and what it's id is | 02:55 |
| hatch | so it can pass that into it's template when it generates the ... | 02:55 |
| huwshimi | hatch: Yes, but it's not always a token! | 02:55 |
| hatch | ok so the only special case is the headers? | 02:56 |
| huwshimi | no | 02:56 |
| hatch | what are the other areas where it needs to be shown that's not a token? | 02:57 |
| huwshimi | well, there are three types of token to begin with | 02:58 |
| hatch | ok that doesn't matter | 02:58 |
| hatch | each token will know what it is and what it's id is | 02:58 |
| huwshimi | I know, but what I'm saying is we need to pass parameters with standard names so the partial can use them | 02:59 |
| huwshimi | It's not a problem, it's just something we have to do | 02:59 |
| hatch | oh right - but that can be within the token though | 02:59 |
| hatch | nothing special needs to be passed around | 02:59 |
| hatch | just data it already has | 02:59 |
| huwshimi | I didn | 03:00 |
| hatch | the header menus though could have individual listeners if that makes it easier | 03:00 |
| hatch | there is only 2(3?) of them | 03:00 |
| huwshimi | I'm not talking about passing that around, I'm just saying when we render the html we have to set the params, that's all | 03:00 |
| hatch | ohh right | 03:00 |
| hatch | we keep a reference to the token collections in the MV, right? | 03:01 |
| huwshimi | yes | 03:02 |
| huwshimi | so a trivial lookup once you have all the data | 03:03 |
| hatch | excellent | 03:03 |
| rick_h__ | huwshimi: you can setup data on the init | 03:03 |
| hatch | rick_h__: thought you'd be interested to know I'm looking at typescript for the gui...ooooooo...... :) I ran into some type related issues doing this stuff today, would have been nice if we had them defined | 03:05 |
| hatch | :) | 03:06 |
| rick_h__ | want types, do Go :P | 03:06 |
| huwshimi | rick_h__: Differently to have them set through data-id data-type? | 03:06 |
| hatch | rick_h__: haha, go2js :D | 03:06 |
| rick_h__ | huwshimi: sorry, was thinking that the widget is init from the View and it knows who it is. | 03:06 |
| huwshimi | yeah :( | 03:07 |
| rick_h__ | huwshimi: but sounds like you guys had a long chat about things | 03:07 |
| huwshimi | :) | 03:07 |
| rick_h__ | I'd have each token deal with it's own responsbiilty myself (until we hit a scale issue) | 03:08 |
| hatch | I still think it should have a single menu which it just renders into the different spots so we only have to instantiate one :) | 03:08 |
| rick_h__ | though I'm very nervous on all this 'hover' stuff | 03:08 |
| rick_h__ | hatch: :( | 03:08 |
| hatch | but I think I'm losing that battle lol | 03:08 |
| rick_h__ | hatch: but now you've basically got a global | 03:08 |
| * hatch hands out flyers | 03:08 | |
| hatch | well in the mv, yes, but there will only ever be a single tooltip window open at once | 03:09 |
| rick_h__ | hatch: I'm all for trying to cheat performance but I'm +1 on making it work in a clean way first and then optimize | 03:09 |
| rick_h__ | hatch: yea, but the complexity of it having to know about all 'types' it could be/etc is just so messy to me | 03:09 |
| * huwshimi has no idea what to do now :) | 03:10 | |
| rick_h__ | I'm going to talk with Luca about this hover stuff | 03:10 |
| rick_h__ | I think that's going to be a disaster, click is the way to go | 03:10 |
| hatch | lol | 03:10 |
| hatch | huwshimi: do what you were already doing | 03:10 |
| rick_h__ | just have to figure out something for units | 03:10 |
| huwshimi | hatch: Except that you and rick have different opinions :) | 03:11 |
| rick_h__ | huwshimi: sorry, don't mean to complicate this for you. | 03:11 |
| hatch | I had already stepped down on my idea in favour of meeting in the middle on having 1M click event handlers | 03:11 |
| rick_h__ | heh, when we have the 1M machines/units we'll have other issues :P | 03:11 |
| hatch | lol | 03:12 |
| rick_h__ | seriously though, we know how we'd optimize this stuff. It moves the same code up the stack one layer from token, to column, to MV itself. | 03:12 |
| rick_h__ | but each one gives us a trade off of debugging/complexity it seems to me | 03:12 |
| hatch | huwshimi: each token instantiates its own menu, one click handler for all ...'s, render the menu when the handler says so | 03:13 |
| huwshimi | OK, I'm going to abandon this for now and move onto something else | 03:13 |
| rick_h__ | huwshimi: hatch call? | 03:13 |
| rick_h__ | huwshimi: sorry, don't get frustrated with it :) | 03:13 |
| hatch | :) sorry huwshimi it was a discussion, didn't mean to change your mind | 03:13 |
| rick_h__ | +1 | 03:13 |
| hatch | you were doing the right way | 03:13 |
| huwshimi | rick_h__: It's not a problem, I just don't want to keep re-coding it :) | 03:13 |
| rick_h__ | this is just hatch and I going back/forth | 03:14 |
| rick_h__ | huwshimi: understood | 03:14 |
| rick_h__ | huwshimi: what are you implementing? | 03:14 |
| huwshimi | rick_h__: I have not idea any more :) | 03:14 |
| rick_h__ | huwshimi: I didn't make out the final decision in the back trace | 03:14 |
| rick_h__ | https://plus.google.com/hangouts/_/gym44xuoo2zqrcqjpb2hdgfmhaa?authuser=1 | 03:14 |
| huwshimi | rick_h__: Maybe I should leave it for today and tomorrow you and hatch can make a plan, and then I'll implement that | 03:14 |
| hatch | joining | 03:15 |
| hatch | it was so nice and sunny there huwshimi | 03:23 |
| hatch | haha | 03:23 |
| huwshimi | :) | 03:25 |
| huwshimi | hatch: This is a webcam of the city: http://www.rosebay.tased.edu.au/webcam/medium.jpg | 03:26 |
| huwshimi | hatch: Most of the snow has melted | 03:27 |
| hatch | huwshimi: you have green grass.....there was no snow | 03:27 |
| hatch | lol | 03:27 |
| huwshimi | hatch: We really only have snow at the top of the mountain | 03:28 |
| hatch | and wow, maybe I'll move there, I bet the kiteboarding on that lake would be awesome | 03:28 |
| hatch | lake....ocean whichever :) | 03:29 |
| huwshimi | that's actually a river up from the sea :) | 03:29 |
| hatch | quite the river :) | 03:30 |
| huwshimi | hatch: I live about the center of that shot | 03:31 |
| huwshimi | You can kind of see my hosue | 03:32 |
| hatch | better watch out, come winter I may just show up at your house :D | 03:32 |
| hatch | I'll be on the news "some strange Canadian is going door to door asking for a huwshimi" | 03:32 |
| huwshimi | :) | 03:33 |
| huwshimi | hatch: It's winter here now, about 12C | 03:33 |
| hatch | 22 here now, but you can feel winter is coming in the mornings | 03:34 |
| hatch | the crisp morning air is starting | 03:34 |
| huwshimi | pleasant | 03:34 |
| hatch | yeah it's really nice, it's fly season though | 03:34 |
| hatch | bleh | 03:34 |
| hatch | I think I prefer mosquitos | 03:35 |
| hatch | mosquitoes | 03:35 |
| huwshimi | hatch: Are they mexican mosquitoes? | 03:37 |
| hatch | ours are the size of your spiders.... | 03:37 |
| hatch | lol | 03:37 |
| hatch | not sure if that makes them mexican or not :) | 03:37 |
| huwshimi | hatch: Every menu has a close-on-click-outside event, should I only attach this when the menu is opened and detached when it is closed? | 04:14 |
| hatch | huwshimi: yeah that would be best | 04:15 |
| huwshimi | ok | 04:15 |
| hatch | huwshimi: since you're using widgets there is a bindUI method which you can call that you can use to attach your events, then you'll need to create an unBindUI method to do the opposite :) | 04:17 |
| hatch | it would normally be done on destroy but we aren't destroying them | 04:17 |
| huwshimi | yeah | 04:18 |
| hatch | huwshimi: I'm going to head out now, any q's or anything before I do? | 04:56 |
| huwshimi | hatch: All good, Thanks for all your help! | 04:59 |
| hatch | np, sorry to get you side tracked for a bit there :) | 04:59 |
| hatch | have a good night | 04:59 |
| hatch | cya | 04:59 |
| === urulama-_ is now known as urulama | ||
| urulama | frankban: morning | 07:57 |
| frankban | urulama: hi | 07:57 |
| frankban | urulama: I replied to your last review comment, thanks for the review! | 07:57 |
| urulama | frankban: the archive size is ok then. and URL.Reference is to be resolved on the API level? | 07:59 |
| frankban | urulama: we expect the url to be already resolved at the time meta endpoints are invoked | 08:00 |
| urulama | frankban: thought so, just checking. thanks for the PR. | 08:00 |
| frankban | urulama: cool, landing it | 08:01 |
| urulama | frankban: the /meta/bundles-containing is probably similar to this one | 08:02 |
| urulama | rogpeppe1: morning, sir :) | 08:03 |
| rogpeppe1 | urulama: yo! | 08:03 |
| frankban | urulama: yeah, it has some similarities, and I think it could live in relations.go as well | 08:03 |
| urulama | rogpeppe1: how was your extended weekend? | 08:03 |
| rogpeppe1 | frankban: hiya | 08:03 |
| rogpeppe1 | urulama: very fine, thank you | 08:03 |
| frankban | morning rogpeppe1 | 08:03 |
| urulama | frankban: exactly, i think it could go there as well | 08:04 |
| frankban | urulama: cool | 08:04 |
| rogpeppe1 | urulama: i'm in Whitby and there's a folk festival going on... | 08:04 |
| urulama | rogpeppe1: uuuuu, sounds nice! doing any performaces? | 08:04 |
| rogpeppe1 | urulama: not really, a bit of playing for some sword dancers with one spot at the late night extra on friday night, but not too much | 08:05 |
| urulama | rogpeppe1: i would love to get a picture of that, if possible :) i'll tell my boy, he'll love it (huge Zelda game fan and fan of swords) | 08:06 |
| rogpeppe1 | urulama: they're kinda strange swords | 08:06 |
| rogpeppe1 | urulama: they've got a handle at each end | 08:07 |
| * urulama automatically associates UK with knights (of the round table) :) | 08:07 | |
| rogpeppe1 | urulama: this kind of thing: https://www.youtube.com/watch?v=3WJKiMe-Czk | 08:08 |
| urulama | rogpeppe1: wow, so many hands! | 08:12 |
| rogpeppe1 | urulama: it works well in small spaces - perfect for english pubs | 08:12 |
| rogpeppe1 | urulama, frankban: i'm updating the charm API document to cover PUT to the bulk request endpoints | 08:14 |
| urulama | rogpeppe1: this one? PUT meta/$endpoint[$otherflags] | 08:15 |
| rogpeppe1 | urulama: yup | 08:15 |
| rogpeppe1 | urulama: and the $id/any endpoint too | 08:16 |
| urulama | rogpeppe1: if we update meta enpoint, the revision should bump up automatically, right? | 08:18 |
| rogpeppe1 | urulama: my current thought is that is does not | 08:18 |
| rogpeppe1 | urulama: i think the revision should pertain to the archive, not the metadata | 08:18 |
| urulama | rogpeppe1: but with changing the meta, one can change the interfaces that are required and exposed, which probably is a new version | 08:19 |
| urulama | rogpeppe1: or config | 08:19 |
| rogpeppe1 | urulama: no, a PUT to the metadata cannot change any of the charm or bundle metadata | 08:19 |
| rogpeppe1 | urulama: the only thing we're going to allow a PUT to, for the moment, is extra-info | 08:20 |
| urulama | rogpeppe1: aaaa, ok. then it makes sense | 08:20 |
| rogpeppe1 | urulama: if you want to update the charm or bundle metadata, you will need to upload a new archive | 08:20 |
| urulama | jujugui: i'll be unavailable next hour as we have an induction session | 08:54 |
| rogpeppe1 | urulama: ok | 08:54 |
| frankban | rogpeppe1: for expand-id, I am not sure by reading the spec if we want to return a 404 in the case the given URL cannot be resolved | 09:04 |
| rogpeppe1 | frankban: what do you think we should do? | 09:05 |
| frankban | rogpeppe1: if we want to avoid changing the URL resolving in the router, then we can keep returning a 404. but we must change the second example in the spec | 09:06 |
| frankban | (wordpress-34) | 09:06 |
| * rogpeppe1 looks | 09:06 | |
| frankban | rogpeppe1: if we return a 404, when you provide a fully qualified URL I'd expect that URL to be included in the results | 09:07 |
| rogpeppe1 | frankban: interesting question | 09:07 |
| rogpeppe1 | frankban: currently, that would work ok | 09:07 |
| rogpeppe1 | frankban: as when the URL is fully specified, we don't make a round-trip to check that it's actually there | 09:08 |
| frankban | rogpeppe1: yeah, so we have an inconsistency. precise/no-such-42 would return a 200-empty-list result, while just "no-such" a 404 not found error | 09:13 |
| rogpeppe1 | frankban: i wonder if we should return a 404 for any expand-id request that expands to no ids | 09:15 |
| frankban | rogpeppe1: one solution could be returning a 404 if the list is empty | 09:15 |
| frankban | heh | 09:15 |
| frankban | rogpeppe1: here is the result: https://github.com/juju/charmstore/pull/76 I need to be afk for a while, see you later | 09:40 |
| rogpeppe1 | frankban: brilliant, thanks. | 09:40 |
| rogpeppe1 | frankban: looking | 09:40 |
| urulama | rogpeppe1, frankban: wouldn't it make sense for expand-id on a fully qualified charm url to return 200 and the same url? why 404? | 09:46 |
| urulama | rogpeppe1, frankban: and for any "no-such-charm", either with series or without, would result in 404 | 09:46 |
| rogpeppe1 | urulama: what if the id is fully qualified, but there is no charm with that id? | 09:47 |
| urulama | rogpeppe1: what sense does it make to expand-id on an id that does not exist? | 09:48 |
| urulama | get non-exitising-name should return 404, get non-exiting-name/expand-id as well | 09:49 |
| rogpeppe1 | urulama: we need to define the API's behaviour in that case | 09:49 |
| rogpeppe1 | urulama: so expand-id on a fully qualified charm url might return 404 when there are no results, right? | 09:49 |
| urulama | rogpeppe1: i would say so, because the ID itself in that url is not valid | 09:50 |
| rogpeppe1 | urulama: ok. i think that was the plan, so i'm not quite sure what you're suggesting. | 09:50 |
| urulama | rogpeppe1: just jumping late into the conversation :) (and as i saw returning 200 on precise/no-such-42) | 09:52 |
| rogpeppe1 | urulama: that was frankban talking about previous behaviour, i think. | 09:52 |
| urulama | rogpeppe1: regarding bson.M vs bson.D ... it is always better to use bson.M? | 09:54 |
| rogpeppe1 | urulama: I always use bson.D except when I actually need the map-like capabilities of bson.M | 09:55 |
| rogpeppe1 | urulama: creating a slice is cheaper than creating a map | 09:55 |
| urulama | rogpeppe1: ok, tnx, noted ;) | 09:55 |
| rick_h__ | morning party people | 11:27 |
| rick_h__ | urulama: rogpeppe1 but with extra-info can we update that sans-upload? | 11:28 |
| rogpeppe1 | rick_h__: yes | 11:28 |
| rick_h__ | urulama: rogpeppe1 we're looking at using that mechanism to update charms with test results, etc | 11:28 |
| rick_h__ | ok cool | 11:28 |
| rogpeppe1 | rick_h__: that's the raison d'etre of extra-info | 11:29 |
| rick_h__ | oh heh, needed to keep reading the history there you guys cover that :) | 11:29 |
| frankban | rogpeppe1: should we use bson.D eve in the cases bson.M is more representative of the concept we are expressing? e.g. we need to map keys to values | 11:36 |
| frankban | rogpeppe1: e.g. bson.M{"baseurl": id} | 11:36 |
| rogpeppe1 | frankban: if bson.M is providing some actual program-construction value, then by all means use it. | 11:37 |
| rogpeppe1 | frankban: but in general, bson.D is exactly equivalent in representation | 11:37 |
| rogpeppe1 | frankban: it represents a mapping of keys to values just like bson.M does | 11:37 |
| rogpeppe1 | frankban: but it's a little more efficient, so i prefer to use it, all other things being equal | 11:38 |
| frankban | rogpeppe1: I read bson.M{"baseurl": id} slightly better than bson.D{{"baseurl", id}}, but perhaps it's just because I am used to express this kind of queries as a key/value, rather thank i[0]/i[1] | 11:40 |
| rogpeppe1 | frankban: yeah, bson.M is cognitively closer to what we're trying to represent, but i don't think that means we have to use it. | 11:41 |
| frankban | rogpeppe1: in this case the query is really easy to read anyway, so I'll just make the change for efficiancy | 11:41 |
| rogpeppe1 | frankban: thanks | 11:41 |
| frankban | efficiency even | 11:41 |
| urulama | rogpeppe1, frankban: would this apply to the PR75 as well? I guess bson.M and bson.D are properly used there, but maybe take another look | 11:43 |
| * rogpeppe1 looks at PR75 | 11:44 | |
| rogpeppe1 | frankban, urulama: yeah, i'd use bson.D there | 11:45 |
| frankban | urulama: would you like to take a look at https://github.com/juju/charmstore/pull/76? | 11:55 |
| rogpeppe1 | frankban, urulama: in a very quick-and-dirty benchmark, bson.D is about twice as quick as bson.M: http://paste.ubuntu.com/8088225/ | 11:55 |
| urulama | frankban: i think that you and rogpeppe1 already covered it, so, i think its +1 | 11:56 |
| frankban | urulama: cool thanks | 11:56 |
| frankban | rogpeppe1: I'd be interested in the meaning of "twice as quick" in the context of a full request/db query/response | 11:59 |
| rogpeppe1 | frankban: sure, it's probably lost in the noiser | 11:59 |
| rogpeppe1 | frankban: but it's nice to be efficient when there's no cost in doing so | 12:00 |
| rogpeppe1 | s/noiser/noise/ | 12:00 |
| frankban | rogpeppe1: +1 except in the cases there is some other cost, like readability. but perhaps it's just me, perhaps I am just not used to things like "}}}}," ;-) | 12:01 |
| rogpeppe1 | frankban: :-) | 12:02 |
| rogpeppe1 | frankban: i don't think it's too bad. | 12:02 |
| rick_h__ | frankban: can't you tell at a glance that's 5, no I mean 4 closing braces? :P | 12:03 |
| frankban | heh | 12:04 |
| rick_h__ | frankban: if you get some downtime, think you can help jrwren_ out and peek at his merge proposals on quickstart this week? | 12:04 |
| rick_h__ | frankban: help clear out the slack stuff pending and might be good to see if it can land and make sure we get a final quickstart release for the cycle in the near future. | 12:05 |
| * urulama needs to grab some food | 12:07 | |
| * rick_h__ sends some leftovers to urulama | 12:07 | |
| frankban | rick_h__: I remember I reviewed all those slack cards | 12:07 |
| rick_h__ | frankban: oh did you? awesome, I'll maybe bug jrwren_ about them then. | 12:08 |
| urulama | rick_h__: :D :D | 12:11 |
| frankban | rick_h__: I did it before London. I did not receive other emails re those branches | 12:11 |
| rick_h__ | frankban: ok, I was just looking at the board and figured it might be cool to move those forward. I'll check up on it thanks. | 12:11 |
| frankban | rick_h__: thank you | 12:12 |
| * rogpeppe1 grabs some lunch too | 12:13 | |
| jrwren_ | frankban: did you review them a second time? I've been delaying nagging you about them. I did address all 3. | 12:37 |
| jrwren_ | but since rick_h__ is nagging for me, I should probably nag. | 12:38 |
| jrwren_ | err, I mean asking ;] | 12:38 |
| frankban | jrwren_: I reviewed them once, then did not receive any signal they are ready for re-review. If they are ready, I'll take another look at them asap | 12:39 |
| jrwren_ | frankban: Yes, please do. | 12:39 |
| frankban | jrwren_: ok | 12:39 |
| rick_h__ | oh luca, o'buddy o'pal | 12:57 |
| luca | rick_h__: heya :) | 13:00 |
| rick_h__ | luca: got time for a quick chat? | 13:01 |
| luca | rick_h__: in a meeting for the next 2 hours | 13:01 |
| rick_h__ | I want to get your brain on it asap :) | 13:01 |
| rick_h__ | luca: ok, if you get free ping me otherwise we can chat tomorrow | 13:01 |
| luca | rick_h__: will do | 13:02 |
| rick_h__ | ty much | 13:02 |
| jcsackett | rick_h__: i see a bunch of cards in tracking for GUI, but they seem to be defects in our code (e.g we're not tracking another project) what's up with those? | 13:58 |
| kadams54 | rick_h__: got a question for you when you have a moment. | 13:58 |
| rick_h__ | jcsackett: I pulled them aside as I think they were worked on but not verified yet | 13:59 |
| rick_h__ | jcsackett: working on the board, will update htem | 14:00 |
| rick_h__ | kadams54: otp, will ping when off | 14:00 |
| jcsackett | rick_h__: so i can tell you the one for "dispatched urls" had some investigation done, but we concluded it's blocked until we release MV 1.0, so we're rid of the ghost inspector. happy to chat with you about details if you want. | 14:05 |
| rick_h__ | jcsackett: ok cool, will move it back into the on deck | 14:06 |
| rick_h__ | jcsackett: can you update the bug with any notes to help getting it started and the MV 1.0 reasons/etc? | 14:06 |
| rick_h__ | kadams54: free, what's up? | 14:06 |
| jcsackett | rick_h__: sure. | 14:09 |
| frankban | rick_h__, bac: I'd like your opinion on https://code.launchpad.net/~evarlast/juju-quickstart/which-juju/+merge/227238 . Do you have a minute to take a look? thanks | 14:18 |
| rick_h__ | frankban: looking | 14:19 |
| rick_h__ | frankban: oh hmm, interesting. *thinking* | 14:20 |
| rick_h__ | frankban: jrwren_ so the issue is sudo $JUJU, so I'd just stop that. Don't allow it. It's an older scenario and we can say the feature isn't backwards compatible. | 14:22 |
| jrwren_ | frankban: I completely missed that first comment. | 14:22 |
| rick_h__ | frankban: jrwren_ so if a user has $JUJU set and we need to 'sudo $JUJU' we output a warning and don't use it | 14:22 |
| rick_h__ | frankban: jrwren_ bac thoughts? | 14:22 |
| frankban | rick_h__: sounds reasonable, given we have a use case for this feature. use a compiled version of juju? I am still worried about point 2) in my comments | 14:25 |
| rick_h__ | frankban: yea, I think with the call for testing and such we'll have to get past #2. For CI for instance, we'd easily use $JUJU=xxxx to test against upcoming Juju versions | 14:26 |
| rick_h__ | frankban: I'd not shout the feature from the hill tops, but I think it makes sense to support it | 14:26 |
| jrwren_ | I want the sudo feature for myself :) | 14:26 |
| frankban | rick_h__, jrwren_, coll then +1 | 14:27 |
| jrwren_ | I'd rather doc it with a giant warning or something. | 14:27 |
| rick_h__ | jrwren_: what for? We don't need sudo in modern lxc, this will be released in utopic quickstart, not any earlier versions | 14:27 |
| jrwren_ | rick_h__: quickstart local? | 14:27 |
| jrwren_ | rick_h__: err, just bootstrap local. | 14:28 |
| rick_h__ | jrwren_: yea, isn't the sudo requirement for local bootstrap gone? | 14:28 |
| rick_h__ | well, at least quickstart doing it | 14:28 |
| rick_h__ | juju deals with sudo now, we don't have to | 14:28 |
| jrwren_ | rick_h__: oh, but I see. yes, that is the difference. | 14:28 |
| jrwren_ | in that case I agree with all the concerns and I should update the PR. | 14:29 |
| rick_h__ | jrwren_: ok, let me know if I'm off in my thinking. | 14:29 |
| rick_h__ | jrwren_: frankban ok, so we're +1 on ignore $JUJU on any sudo call paths, respecting it otherwise, and making sure we hide it from non-test users ) | 14:30 |
| rick_h__ | :) | 14:30 |
| jrwren_ | rick_h__: No, I think the two points in frankban's initial comment are still important and shall be addressed. | 14:30 |
| jrwren_ | rick_h__: s/No/Yes/ :) | 14:31 |
| frankban | rick_h__, jrwren_: added a new comment summarizing this chat | 14:31 |
| rick_h__ | ty frankban | 14:31 |
| rick_h__ | thanks for the updates jrwren_, sorry for the complication. | 14:31 |
| rick_h__ | and thanks for the good call/catch on sudo frankban! | 14:31 |
| hatch | I just used local yesterday and needed to enter my pw | 14:36 |
| hatch | on 1.20.1 | 14:36 |
| jrwren_ | hatch: right. juju invoked sudo on your behalf. you didn't have to invoke juju with sudo, did you? | 14:37 |
| hatch | jrwren_: no, but I did have to type my pw | 14:38 |
| hatch | so it still rquired sudo | 14:38 |
| rick_h__ | hatch: yes, but it's not quickstart's issue so it's not an attack vector | 14:47 |
| hatch | every time i see "attack vector" I think of a top down airplane game | 14:47 |
| hatch | pew pew | 14:47 |
| rick_h__ | pew! | 14:47 |
| frankban | :-) | 14:48 |
| frankban | jrwren_: https://code.launchpad.net/~evarlast/juju-quickstart/support-lxc-clone/+merge/227250 done | 14:49 |
| jrwren_ | frankban: thanks! | 14:49 |
| rick_h__ | jujugui call in 10, please update kanban | 14:49 |
| luca | rick_h__: I’m free for a call | 14:57 |
| rick_h__ | luca: standup time | 14:57 |
| rick_h__ | luca: can ping afterwards | 14:58 |
| luca | rick_h__: ok | 14:58 |
| rick_h__ | jujugui call time in 2 | 14:58 |
| rick_h__ | Makyo: kadams54 frankban ^ | 14:59 |
| rick_h__ | antdillon: ^ | 14:59 |
| kadams54 | joining | 14:59 |
| rick_h__ | doh! | 15:13 |
| rick_h__ | come on chrome, go go go | 15:13 |
| rick_h__ | geeze, what's a guy have to do to run a meeting around here? | 15:15 |
| urulama | rick_h__: the FX are great :) | 15:15 |
| rick_h__ | man, I wish I had a recording of how I sounded :P | 15:49 |
| kadams54 | My inlaws had a problem with their landline phone awhile back. It would make them sound like a chipmunk, but only the person on the other end could hear it. It was also sporadic, so one minute you'd be having a normal conversation, the next, Alvin and the chipmunks. | 15:52 |
| kadams54 | It was awesome. | 15:52 |
| rick_h__ | hah | 15:52 |
| jcsackett | so, if we have a machine with the only uncommitted unit of an uncommitted service, and we delete that machine, should we just reset the unit as an unplaced unit, or should we clear the service? | 15:55 |
| rick_h__ | jcsackett: I'd reset it as an unplaced unit | 15:56 |
| rick_h__ | and then they can remove it from there if they like | 15:56 |
| jcsackett | rick_h__: ok, that was the way i was headed. | 15:56 |
| frankban | jrwren_: reviewed the third branch, it looks good with minor changes, thank you | 16:09 |
| hatch | luca: hey the svg rendering bug you reported - was the image you had stitched together? The only way I can reproduce it is if one icon straddles the bottom of the browser so that only part of it is rendered | 16:11 |
| hatch | so I can't get two icons to not render properly | 16:12 |
| luca | hatch: I didn’t stitch them together, that just how they appear in the listing | 16:13 |
| luca | hatch: I’ll send you another pic of the same bug | 16:13 |
| luca | hatch: check you email | 16:14 |
| hatch | thx | 16:15 |
| luca | hatch: sent another too | 16:15 |
| hatch | woah I haven't seen that one | 16:15 |
| luca | hatch: it might show it a little better | 16:15 |
| luca | hatch: yeah, it all happened at the same time | 16:15 |
| luca | hatch: it started during the London sprint | 16:15 |
| hatch | *sigh* I've been researching chrome svg rendering bugs but I can't reproduce anything like this using any svg's that aren't ours | 16:15 |
| jrwren_ | frankban: thanks again. | 16:15 |
| hatch | but they also don't happen in any other browser.... | 16:16 |
| luca | hatch: It seemed to happen when my browser updated | 16:16 |
| luca | hatch: and it can be consistently reproduced on other peoples browsers in the web team | 16:16 |
| hatch | luca: yeah it's definitely a chrome bug, but nothing that matches this has been filed (and not subsequently fixed) and any other svg's but our icons don't exhibit the same problem | 16:18 |
| luca | hatch: ok | 16:19 |
| luca | hatch: so we can’t fix it? | 16:19 |
| hatch | luca it also seems to only happen with certain icons | 16:19 |
| hatch | the wordpress icon for example is really bad, but the icon for ubuntu-repository-cache doesn't appear to exhibit the issue | 16:19 |
| luca | hatch: yeah, I couldn’t work out why it would effect some and not others | 16:19 |
| hatch | I'll put my notes in the bug and we can revisit, I'm guessing there is something wrong with how some of the svg's are created | 16:20 |
| hatch | and with how chrome's new rendering works | 16:20 |
| luca | hatch: the MySQL icon on the service block doesn’t respond the zoom, thats why it looks wrong | 16:20 |
| luca | hatch: sent you another img | 16:21 |
| hatch | odd I can't reproduce that one | 16:22 |
| hatch | luca can you add these images to the bug? | 16:22 |
| luca | sure | 16:23 |
| hatch | thanks, it's very odd, even in osx with the same version of chrome i can't reproduce what you see | 16:23 |
| hatch | I wonder if you have some extension which may be making it worse heh | 16:24 |
| hatch | oops, I ate too many nibs | 16:48 |
| rick_h__ | hatch: I get it based on zoom levels sometimes. | 16:49 |
| rick_h__ | hatch: it's not an extension, it seems something in chrome/svg resizing or something | 16:49 |
| hatch | rick_h__: right, I just can't reproduce the same issues so was just trying to find some reasoning behind that | 16:50 |
| hatch | you'd think identical os's and browser versions would do the same thing haha | 16:50 |
| rick_h__ | hatch: heh | 16:50 |
| rick_h__ | I get it on linux in the dev edition | 16:50 |
| hatch | Chrome in Ubuntu is such a mess | 16:50 |
| rick_h__ | :) | 16:50 |
| hatch | when I drag a window it goes transparent | 16:50 |
| urulama | jujugui: have a nice evening | 17:00 |
| hatch | cya urulama | 17:00 |
| hatch | u 2 | 17:00 |
| frankban | and you | 17:00 |
| * rogpeppe1 is done for the day too. | 17:02 | |
| rogpeppe1 | g'night all | 17:02 |
| rick_h__ | BradCrittenden: ? | 18:13 |
| rick_h__ | BradCrittenden: I bailed out, going to get lunch. | 18:14 |
| BradCrittenden | ok | 18:14 |
| === BradCrittenden is now known as bac | ||
| rick_h__ | BradCrittenden: I think we should try to get some time with someone from #is | 18:14 |
| bac | rt | 18:14 |
| rick_h__ | bac: I think you're right that the config and test fails, not sure if it ever passed tbh | 18:14 |
| kadams54 | hatch: So… I need to query whether a radio button is selected. I know we *just* went through this a few months back, but I'm having a senior moment on the details. | 18:14 |
| hatch | kadams54: you have to loop through each one | 18:15 |
| hatch | because phantomjs lameness | 18:15 |
| bac | rick_h__: in the bug i see tom has added: the application topology is apache2 -> squid -> haproxy -> charmworld-app | 18:15 |
| kadams54 | hatch: Yeah, but it wasn't enough to check for the "checked" attribute because that doesn't change from what's set in the HTML. | 18:15 |
| hatch | kadams54: not the attribute, the js property | 18:16 |
| hatch | input.get('checked') | 18:16 |
| kadams54 | Yeah, OK, that works… | 18:20 |
| kadams54 | Seems like last time things weren't that clean, but for this case :-) | 18:20 |
| * hatch hangs head | 18:21 | |
| hatch | kadams54: your modularization branch totally destroys my work from yesterday lol | 18:22 |
| kadams54 | Yay! | 18:22 |
| kadams54 | ;-) | 18:22 |
| kadams54 | What happened? | 18:22 |
| hatch | I rewrote the methods you moved | 18:22 |
| hatch | I just have to manually re-apply my commits | 18:23 |
| hatch | kadams54: did you make any changes to these methods or just moved them? | 18:24 |
| kadams54 | Just moved | 18:24 |
| hatch | phew | 18:24 |
| hatch | :) | 18:24 |
| kadams54 | hatch: just did a diff to make sure. I made one change for readability: https://pastebin.canonical.com/115591/ | 18:29 |
| hatch | ahh ok thanks, well that space doesn't exist anymore :) | 18:30 |
| hatch | ok taking lunch, I'll fix this later | 18:31 |
| hatch | bbl | 18:31 |
| kadams54 | hatch: ping me when you're back. | 18:49 |
| rick_h__ | bac: ok, that makes sense except that haproxy was exposed | 19:01 |
| rick_h__ | bac: oh, but you exposed that right? | 19:01 |
| bac | rick_h__: yeah, i exposed haproxy myself which was a mistake | 19:05 |
| rick_h__ | bac: gotcha | 19:11 |
| rick_h__ | fabrice: ! | 19:11 |
| rick_h__ | fabrice: who let you around here :P | 19:11 |
| fabrice | it's public :) | 19:11 |
| rick_h__ | fabrice: hey, you still coming over here the 15th right? | 19:11 |
| fabrice | yep ! | 19:12 |
| rick_h__ | urulama: isn't around right now but need to introduce you guys :) | 19:12 |
| rick_h__ | fabrice: cool, you're the last one to join the party | 19:12 |
| urulama | rick_h__: i am :) | 19:12 |
| rick_h__ | oh, he is | 19:13 |
| fabrice | yes I wish I could joined early but french laws are a pain ! | 19:13 |
| rick_h__ | urulama: fabrice starts the 15 :P | 19:13 |
| rick_h__ | fabrice: gotcha, all good. Nice to see you hanging around | 19:13 |
| urulama | fabrice: nice to meet you, and i understand you, i'm also from EU :) | 19:13 |
| fabrice | where ? | 19:13 |
| urulama | fabrice: slovenia | 19:14 |
| rick_h__ | heh, solvenia, france, UK, italy. The team's gone all internation | 19:14 |
| rick_h__ | hatch: and canada don't count :P | 19:14 |
| rick_h__ | international that is | 19:14 |
| fabrice | you mean that american think Canada is a US state ! | 19:15 |
| rick_h__ | the 51st! we've just not claimed it yet | 19:15 |
| rick_h__ | at least the good parts :P | 19:15 |
| urulama | :) | 19:15 |
| rick_h__ | I hear toronto is kind of cool | 19:15 |
| fabrice | I lived there 3 years and it is | 19:16 |
| urulama | fabrice: where in France do you live? | 19:18 |
| fabrice | French Riviera in Grasse | 19:19 |
| rick_h__ | man, france and italy. I need to get some wine shipments started from you and frankban :) | 19:19 |
| rick_h__ | be the impartial comparison to see what is better! | 19:19 |
| hatch | rick_h__: fabrice used to live in Canada :P so THERE! | 19:19 |
| jrwren_ | as lone mercan in that group,I'm aiming for a good cowboy nickname. | 19:19 |
| rick_h__ | hatch: he knew enough to get out! | 19:20 |
| hatch | rick_h__: yeah and he sure didn't go south :P | 19:20 |
| rick_h__ | jrwren_: I'm thinking something with john wayne in it | 19:20 |
| jrwren_ | rick_h__: yee haw! | 19:20 |
| hatch | lol | 19:20 |
| fabrice | I really like Canadians really nice people | 19:20 |
| hatch | kadams54: I'm back | 19:20 |
| hatch | *snicker* | 19:20 |
| fabrice | urulama: Ljubljana? | 19:20 |
| hatch | that can't be a real name | 19:21 |
| urulama | fabrice: close (as everything is close here), Novo mesto | 19:21 |
| urulama | hatch: it is, it's simple to say :) | 19:21 |
| hatch | urulama: lol suuuuure | 19:21 |
| fabrice | tell the name of your town :) | 19:21 |
| rick_h__ | lol | 19:21 |
| rick_h__ | here we go | 19:21 |
| hatch | Saskatoon Saskatchewan | 19:21 |
| rick_h__ | he makes up this place | 19:22 |
| hatch | bahaha | 19:22 |
| hatch | lol | 19:22 |
| rick_h__ | it's from a kids book, we're sure | 19:22 |
| kadams54 | guihelp: what's the right way to trigger a nav event? I did some grepping but didn't find any obvious examples… | 19:23 |
| hatch | what's a nav event? | 19:23 |
| hatch | like changeState? | 19:23 |
| fabrice | Saskatchewan vs Ljubljana who will win the pronounciation game ? | 19:23 |
| hatch | haha | 19:23 |
| kadams54 | In my card… clicking on "View machines" needs to navigate to the machine view panel. | 19:23 |
| hatch | yeah that's changeState | 19:24 |
| hatch | kadams54: in the inspector there is a changeState call in the scale up to show the mv | 19:24 |
| hatch | look there | 19:24 |
| urulama | fabrice: had to look up Grasse. I spent two weeks close, in the Sophia Antipolis Sciecnce Park, on a visit ... but was aaaages ago ... | 19:24 |
| hatch | looks beautiful there | 19:25 |
| hatch | I vote there for the next sprint in the summer :) | 19:25 |
| fabrice | great idea ! | 19:26 |
| urulama | hatch: remember, we had Lisbon, Budapest and Dublin, but ended up in Brussels. Don't suggest French riviera, we'll end up somewhere in Belarus :) | 19:26 |
| fabrice | rick_h can take back some wine | 19:26 |
| hatch | urulama: hahahaha | 19:26 |
| kadams54 | Hmm, most of the changeState examples are setting stuff in sectionA… I'm guessing I need to set something for sectionB? | 19:27 |
| rick_h__ | urulama: :/ you're making the idea of 2wks there hard to get my head around | 19:27 |
| hatch | kadams54: I wasn't kidding, it's right there :) https://github.com/juju/juju-gui/blob/develop/app/views/viewlets/scale-up.js#L155 | 19:28 |
| kadams54 | hatch: hah, OK, I found it just about the same time. | 19:28 |
| kadams54 | Was temporarily put off by changeState stuff in service-inspector.js… | 19:28 |
| kadams54 | Excellent, thanks | 19:28 |
| hatch | https://www.google.ca/maps/place/Grasse,+France/@43.523504,6.943188,3a,75y,90t/data=!3m5!1e2!3m3!1s7429787!2e1!3e10!4m2!3m1!1s0x12cc25fe3958edfb:0x117727988cf82e2d | 19:28 |
| hatch | it's a little far away from Grasse, but we should have our sprint right here | 19:29 |
| hatch | at this exact spot | 19:29 |
| * hatch starts packing tent | 19:29 | |
| kadams54 | As long as there's power and wifi. | 19:29 |
| bac | rick_h__: if you've got two weeks in brussels at least go to amsterdam for the weekend. easy train ride. | 19:29 |
| hatch | kadams54: who needs either of those, pen and paper - planning spring! ;) | 19:30 |
| hatch | sprint* | 19:30 |
| urulama | rick_h__: you sure it's two weeks and that the coding/lead stuff don't overlap? | 19:30 |
| kadams54 | What's this about Brussels? | 19:30 |
| kadams54 | Is that the October sprint? | 19:30 |
| rick_h__ | urulama: so it's possible for me and maybe you it's two weeks, but TBD | 19:30 |
| rick_h__ | kadams54: it's not 100% yet, but looking likely | 19:31 |
| * urulama starts to shiver on the thought of being in Brussels for 14 days ... | 19:31 | |
| rick_h__ | kadams54: working with 3 places to get space | 19:31 |
| hatch | urulama: what's wrong with brussels? | 19:31 |
| urulama | hatch: you'll see :) | 19:31 |
| rick_h__ | hatch: your branch up for review? Seems to have went boom? | 19:31 |
| urulama | hatch: or maybe you'll like it | 19:31 |
| hatch | rick_h__: huge conflict with the code kyle landed | 19:32 |
| hatch | fixing now | 19:32 |
| rick_h__ | hatch: cool lty | 19:32 |
| urulama | fabrice: anyway, happy that you'll join, fun times ahead | 19:32 |
| kadams54 | I live my life according to HTCWJ… | 19:33 |
| kadams54 | How To Conflict With Jeff | 19:33 |
| fabrice | urulama: Thanks ! I am quite eager now to start | 19:34 |
| fabrice | fun is always better | 19:34 |
| hatch | kadams54: it's clear you've been working with rick_h__ for too long then :P | 19:35 |
| rick_h__ | I like to lead by example | 19:35 |
| hatch | hahaha | 19:36 |
| kadams54 | Michiganders have always had a… special… relationship with Canadians. | 19:36 |
| hatch | it's an 18h travel time for me to get to brussels .....oh boy | 19:36 |
| hatch | hopefully some better flights become available when it gets ironed out | 19:36 |
| rick_h__ | hatch: time to get a tablet | 19:37 |
| hatch | rick_h__: yeah - although Air Canada provides power plugs in their planes | 19:37 |
| hatch | so keeps the laptop all charged up | 19:37 |
| fabrice | Brussels is good I can speak French | 19:37 |
| hatch | I speak enough French to introduce myself to everyone | 19:37 |
| hatch | then walk away | 19:38 |
| hatch | because that's all I have | 19:38 |
| hatch | :D | 19:38 |
| hatch | urulama: from a travel site """Wherever else you go in Belgium, allow at least a little time for BRUSSELS, which is undoubtedly one of Europe’s premier cities. Certainly, don’t let its unjustified reputation as a dull, faceless centre of EU bureaucracy deter you:""" | 19:39 |
| hatch | lol | 19:40 |
| urulama | :) | 19:40 |
| urulama | hatch: there are good sides of Brussels | 19:55 |
| urulama | hatch: this one http://deliriumcafe.be | 19:56 |
| urulama | :) | 19:56 |
| fabrice | good beer too ! | 19:56 |
| urulama | jujugui: gn | 19:58 |
| urulama | fabrice: see you around, and on 15.9. latest :) | 19:58 |
| === urulama is now known as uru-afk | ||
| fabrice | have a nice evening/night | 20:16 |
| fabrice | ttyt | 20:17 |
| rick_h__ | jujugui I'm out. Have a good night all. | 20:35 |
| hatch | cya rick_h__ you too | 20:35 |
| bac | later rick_h__ | 20:36 |
| hatch | jujugui they are working on the power again, and they said I will lose power soonish | 20:53 |
| bac | hatch: don't you have a monster UPS? | 20:54 |
| hatch | jujugui I'll need two reviews for https://github.com/juju/juju-gui/pull/504 plz and thanks | 21:11 |
| kadams54 | hatch: looking | 21:11 |
| hatch | thanks | 21:15 |
| kadams54 | hatch: Oh this requires a real env. Sorry, my… um… keyboad is busted… yeah, that's it. Totally does not work. | 21:18 |
| kadams54 | ;-) | 21:19 |
| hatch | haha | 21:21 |
| hatch | kadams54: lxc env's are pretty fast | 21:21 |
| kadams54 | Yeah… | 21:22 |
| kadams54 | This will be less painful once I get around to setting up a dedicated Ubuntu desktop. | 21:22 |
| kadams54 | But for now I have to run lxc within a VM | 21:22 |
| kadams54 | Or go ec2 | 21:22 |
| hatch | so we r going to lose power again here so I'm just going to call it quits for a couple hours until these guys are done, I'll be back on later to pick up the hours | 21:26 |
| hatch | kadams54: feel free to send me an email or just comment in the pr if you have any q's or anything | 21:27 |
| kadams54 | OK | 21:27 |
| kadams54 | Why are you losing power? | 21:27 |
| hatch | kadams54: they are installing fiber into our neighbourhood | 21:28 |
| hatch | and the people drilled through all of the power lines when doing the directional drilling | 21:28 |
| hatch | so the power company is going bit by bit fixing them | 21:28 |
| kadams54 | Ah. This is what our area looks like right now: http://cl.ly/image/382F1E2v432O | 21:29 |
| kadams54 | So I'm not sure if we're going to keep power either :-) | 21:29 |
| hatch | haha | 21:29 |
| hatch | well best of luck to you :) | 21:29 |
| hatch | bbl, cya | 21:30 |
| === mup_ is now known as mup | ||
| huwshimi | Morning | 22:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
