| === chihchun is now known as chihchun_afk | ||
| === _salem is now known as salem_ | ||
| === chihchun_afk is now known as chihchun | ||
| === salem_ is now known as _salem | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| elopio | ping ubuntu-qa: can I please get a review here? | 15:38 |
|---|---|---|
| elopio | https://code.launchpad.net/~canonical-platform-qa/mediaplayer-app/fix1359040-skip_seekbar/+merge/231508 | 15:38 |
| robotfuel | elopio: I will | 15:39 |
| elopio | thanks robotfuel | 15:39 |
| === roadmr is now known as roadmr_afk | ||
| elopio | ping ubuntu-qa: I need two more reviews: | 15:54 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/ubuntu-autopilot-tests/oneline_accounts_window/+merge/231472 | 15:54 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/ubuntu-autopilot-tests/launcher/+merge/231473 | 15:54 |
| elopio | rvr: rhuddie: maybe you? | 15:54 |
| rhuddie | elopio, sure, I'll take a look | 15:56 |
| Nothing_Much | balloons: I got the login screen for the Live desktop for ubuntu-desktop-next, but can't figure out what the login and password is | 16:06 |
| Nothing_Much | are* | 16:06 |
| balloons | Nothing_Much, that means unity8 fails to start | 16:07 |
| Nothing_Much | balloons: oh, that's the greeter? | 16:08 |
| balloons | Nothing_Much, look at the wiki: https://wiki.ubuntu.com/Unity8DesktopIso. "If the image boots to a greeter login, it's likely that the unity8 session fails to start (that's the case in VMs for example) " | 16:08 |
| balloons | that's what is happening yes?> | 16:08 |
| Nothing_Much | ah, yep | 16:09 |
| Nothing_Much | gonna put the iso on my second desktop then | 16:09 |
| balloons | kk, hopefully it works better | 16:12 |
| Nothing_Much | from what I've heard, nvidia hardware has the second best mir support from nouveau | 16:13 |
| elfy | afternoon peeps | 16:14 |
| Nothing_Much | Howdy elfy | 16:14 |
| elopio | rhuddie: thanks for the review. I tried ubuntu-app-stop and it doesn't stop the apps. Maybe I'm using it wrong. | 16:16 |
| elopio | rhuddie: do you know how to close the dialer-app with ubuntu-app-stop ? | 16:16 |
| rhuddie | elopio, this seems to work ok: ubuntu-app-stop dialer-app | 16:17 |
| elfy | hi Nothing_Much - keeping busy I see :) | 16:21 |
| === paulproteus_ is now known as paulproteus | ||
| Nothing_Much | kernel panic on hardware for ubuntu-desktop-next | 16:23 |
| Nothing_Much | drm_kms_helper: panic occurred | 16:23 |
| Nothing_Much | frozen | 16:23 |
| balloons | bah, so neither desktop worked? | 16:24 |
| Nothing_Much | not the VM or the hardware | 16:24 |
| Nothing_Much | I don't have my hardware on the hardware page of the Ubuntu QA team yet | 16:25 |
| elopio | rhuddie: hum, it works, you are right. | 16:25 |
| === _salem is now known as salem_ | ||
| elopio | rhuddie: I updated the MP. Waiting for Jenkins to confirm. | 16:30 |
| rhuddie | elopio, great | 16:30 |
| Nothing_Much | hmm.. can't seem to authenticate to the ubuntu wiki for some reason | 16:31 |
| Nothing_Much | oh there it goes | 16:33 |
| elfy | you have to feed the hamster to use the wiki Nothing_Much ... | 16:35 |
| elfy | other wise the wheel stays still :p | 16:35 |
| Nothing_Much | it's workin' now | 16:36 |
| Nothing_Much | though I can't edit to add my hardware to the permanent table | 16:37 |
| Nothing_Much | nvm | 16:45 |
| === salem_ is now known as _salem | ||
| === roadmr_afk is now known as roadmr | ||
| === TheRedMage is now known as MassuguGo | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| elopio | robotfuel: could you resurrect this? https://code.launchpad.net/~chris.gagnon/autopilot/add_press_duration_to_touch_devices/+merge/212265 | 18:49 |
| robotfuel | elopio: I'll see if I can get to it. I am very busy right now with writing new long running tests. | 18:59 |
| robotfuel | and new battery tests | 18:59 |
| elopio | robotfuel: I can branch it and continue myself, if you prefer. | 19:00 |
| robotfuel | elopio: okay but talk to thomi, autopilot is slower than the qml timer. he had some plans for it. | 19:01 |
| elopio | ack. | 19:01 |
| balloons | elopio, ok so I reproduced the issue with calendar.. it's the silly drag thing again | 19:03 |
| elopio | balloons: I'm not sure what you are talking about. I know about two calendar issues, one because the current day is not visible and one because the text area is not deleted. | 19:04 |
| balloons | elopio, sorry.. the text area deletion issue brendand reported | 19:04 |
| elopio | is that a new one, or just one of the other two were not properly diagnosed? | 19:04 |
| elopio | I'm confused | 19:07 |
| balloons | elopio, sorry... I realize now explaining is a bit difficult. But remember https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1343916? | 19:08 |
| ubot5 | Ubuntu bug 1343916 in Ubuntu Calendar App "Autopilot swipe_into_view method can open copy/paste dialog" [Undecided,Fix released] | 19:08 |
| elopio | balloons: I remember. | 19:09 |
| balloons | The workaround we placed in calendar I think might be causing problems now while editing.. it seems the 'click' we put in makes the cursor wind up in the middle of the text | 19:09 |
| balloons | anyways, I have a few ideas to fix it I'll try out. I'm thinking something will end upstream in the toolkit though | 19:10 |
| elopio | balloons: I think that's not it, because we start deleting the contents of the textfield after the swipe | 19:12 |
| elopio | I think that instead of pressing the END key, we need to press CTRL+END | 19:12 |
| balloons | elopio, sure.. and we could also consider doing that each time? | 19:12 |
| elopio | which is cheating, because END is not on the OSK, but it's our only option until autopilot has a long press. | 19:12 |
| balloons | right, indeed.. I was browsing the OSK | 19:13 |
| elopio | balloons: what do you mean with each time? | 19:13 |
| elopio | it's needed only for text areas, as textfields don't have multiple lines. | 19:13 |
| balloons | elopio, I'm surprised we don't use the 'x' for textfields | 19:13 |
| elopio | balloons: we use it when it's available. | 19:14 |
| elopio | there are text fields that don't have it. | 19:14 |
| balloons | must have been my eyes missing it in calendar.. I thought we did.. anyways | 19:14 |
| balloons | what I was saying is we shouldn't loop forever pressing end.. if we are at the beginning and the textfield isn't empty, press end again | 19:15 |
| elopio | balloons: what I was going to do was to just press CTRL+END once. | 19:16 |
| elopio | that keeps the loop simple, I think. | 19:16 |
| balloons | and give up after a bit of iterating like that | 19:16 |
| balloons | i'll try your ctrl end | 19:16 |
| elopio | now that's a good check. If we are at the start and it's still not empty, fail instead of keep trying. | 19:17 |
| elopio | balloons: I was going to start the branch on the toolkit for it. Do you mean you will try as in: you will do the branch on the toolkit? | 19:17 |
| elopio | or should I continue? | 19:17 |
| balloons | elopio, yes it's needed no matter what | 19:17 |
| balloons | elopio, go ahead and do it to the toolkit if you wish.. i was going to add a custom override to cal first to play with it | 19:18 |
| elopio | ok. | 19:18 |
| balloons | i'm happy to do a toolkit mp too | 19:18 |
| balloons | I'm sure you are busy :-) | 19:18 |
| balloons | you can review it then | 19:18 |
| elopio | balloons: shouldn't take a lot of time. It should be ready before I go for lunch. | 19:20 |
| elopio | lately I'm not that busy. Just waiting for branches to land, mostly. | 19:20 |
| balloons | elopio, heh, well in that case . . :-) | 19:20 |
| elopio | balloons: https://code.launchpad.net/~canonical-platform-qa/ubuntu-ui-toolkit/fix1359167-empty_multiline_textarea/+merge/231626 | 20:10 |
| balloons | elopio, yep looks like what I wanted. But what do you think of trying to clear it more than once? You feel that would hide bugs? | 20:11 |
| balloons | mmm | 20:12 |
| elopio | balloons: do you mean, after we reached the start of the text field, try again to go to the end? | 20:12 |
| balloons | elopio, right.. this would hide potential issues.. but it would also smooth out one-off glitches with things | 20:13 |
| balloons | it's a tough thing.. I guess I'm not for it | 20:13 |
| elopio | balloons: I would prefer to raise the exception I added in case we can't clear it. | 20:13 |
| elopio | it would just happen if we fail to select_all, or if we fail to go_to_end | 20:13 |
| balloons | elopio, yep, same.. | 20:13 |
| elopio | so I would like to know why we failed, and fix it. | 20:14 |
| balloons | I was thinking I would want to do something else but yep, I'm with you.. | 20:14 |
| balloons | we should do a review for other potential infinite loops.. never a good thing | 20:14 |
| elopio | balloons: I tend to assume too much, so the helpers are full of potential infinite loops. | 20:15 |
| elopio | but I'm not sure where to stop. | 20:15 |
| elopio | in this case, for example, if BackSpace fails, we will be in an infinite loop because the cursor position won't advance. | 20:15 |
| balloons | something to slot into my brain when I review your mp's | 20:15 |
| elopio | I'm not sure if it's save to assume backspace will move the cursor, or not. | 20:16 |
| balloons | nope. I would fail if the cursor position doesn't move when we expect it to | 20:16 |
| balloons | and have a seperate exception for it. | 20:17 |
| elopio | balloons: ok, I'll add that check. | 20:17 |
| balloons | you agree? as the helpers we really need to handle all loop paths | 20:17 |
| elopio | balloons: more or less. I think that if we are fully test driven we can assume that some things will work. And that if they fail, we will get a clear error somewhere. The problem is that with our current runner, if an assumption is broken and we are in a loop, the run will be killed without useful results. | 20:21 |
| elopio | balloons: I pushed the change, please take a look. | 20:21 |
| === salem_ is now known as _salem | ||
| balloons | mm text length.. I worry about timing issues with your if statement, but yes that looks good | 20:22 |
| balloons | I'm going to try this against the calendar app | 20:23 |
| === fginther` is now known as fginther | ||
| === _salem is now known as salem_ | ||
| ianorlin | gah there was a bug affecting an image today that makes alt f2 not appear that I reported it staus had changed to fix commited but now I can't find the bug on launchpad to report in tracker | 22:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!