| elopio | thomi: robotfuel told me to ping you about https://bugs.launchpad.net/autopilot/+bug/1268782 | 00:25 |
|---|---|---|
| elopio | I want to fix it, but he said that the pressed time will take longer on autopilot than on QML, and that you had some ideas. | 00:25 |
| ubot5 | Ubuntu bug 1268782 in Autopilot "tap method of Touch device doesn't have press_duration arg" [Undecided,New] | 00:25 |
| thomi | elopio: you can't make it accurate, for sure | 00:26 |
| thomi | just reading the bug now | 00:26 |
| elopio | thomi: I know that, but I don't expect the difference to be more than 0.5 seconds. | 00:27 |
| thomi | elopio: right, your proposed solution in the bug comments sounds sensible to me | 00:27 |
| elopio | on qml it's unlikely they will make one response for a press of 1 second, and a different one for a press of 1.5 | 00:27 |
| thomi | from memory Chris had a MP that was good, but I objected to the test | 00:27 |
| elopio | thomi: I was going to take over chris' mp and update it. I don't see your objections there. | 00:28 |
| thomi | I probably got veebers to do the review | 00:29 |
| thomi | yeah, testing it with a Qml app seems really awkward | 00:29 |
| thomi | but I'll leave that to veebers, since he's the AP guy these days | 00:29 |
| elopio | veebers: any suggestions of what kind of tests would you like? When I filed the bug, I was just thinking of using the fake sleep. | 00:30 |
| veebers | hey elopio o/, let me read the scrollback quickly | 00:39 |
| veebers | elopio: aye, I agree that testing that sleep was called as expected is an acceptable test. | 00:42 |
| elopio | veebers: ack, I'll assign the bug to myself. | 00:42 |
| veebers | elopio: autopilot doesn't guarantee millisecond responses (ui, out of process testing, dbus etc.) | 00:42 |
| veebers | elopio: As soon as a test as a 'waiting for a potentially slow emulator' comment I get cautious | 00:43 |
| veebers | elopio: awesome, thanks for resurrecting that and taking it on :-) | 00:43 |
| elopio | that's fine as humans also can't have that precision. If there's a problem with the UI because we are waiting some more milliseconds than we should, that's a UI bug. | 00:44 |
| veebers | elopio: exactly, and it would (should!) be covered by something that's not an autopilot test | 00:45 |
| === vrruiz_ is now known as rvr | ||
| === om26er is now known as om26er|doctor | ||
| === om26er|doctor is now known as om26er | ||
| elopio | veebers: this is ready for your inspection | 22:18 |
| elopio | https://code.launchpad.net/~canonical-platform-qa/autopilot/fix1268782-press_duration/+merge/231678 | 22:18 |
| veebers | elopio: sweet, i'm just on the move between offices at the moment so will take a look once I've re-setup | 22:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!