=== salem_ is now known as _salem
=== _salem is now known as salem_
=== Zhenech_ is now known as Zhenech
=== Zhenech_ is now known as Zhenech
=== salem_ is now known as _salem
Saviqaaand we're back to red CI07:08
jbermudesDoes anyone know how difficult it would be to edit the unity-2d-launcher to have the tooltip text always showing next to the icon like a label?07:10
Saviqjbermudes, shouldn't be too difficult, dig in this file http://bazaar.launchpad.net/~unity-2d-team/unity-2d/trunk/view/head:/shell/launcher/LauncherItem.qml07:13
mzanettiSaviq: doesnt look so red to me07:15
Saviqmzanetti, MacSlow's fix for notifications got merged like 10mins ago07:15
Saviqbut it didn't have the necessary skip() in the tests it affected :/07:16
mzanettiSaviq: mind removing your Needs Fixing here? https://code.launchpad.net/~mzanetti/unity8/new-lockscreen-design/+merge/23047807:17
Saviqmzanetti, will check07:17
* mzanetti things this looks quite bad now...07:17
MacSlowmzanetti, Saviq: what's missing?07:19
SaviqMacSlow, your workaround broke a test verifying that the animation is happening07:20
SaviqMacSlow, so it's missing a skip()07:20
MacSlowSaviq: but didn't it pass Jenkins yesterday?07:22
SaviqMacSlow, no07:23
MacSlowSaviq, so how could it get merged then?07:23
SaviqMacSlow, https://code.launchpad.net/~macslow/unity8/disable-opacity-animation-1354406-workaround/+merge/231588/comments/56356507:23
SaviqMacSlow, because jenkins pass isn't required for a merge07:23
Saviqnewsflash, we've had non-passing jenkins for like the past month ;)07:24
Saviqand that didn't stop us from landing things07:24
Saviqbut I kinda hoped for this situation to end for at least some time...07:25
mzanettiMacSlow: guess why there is a point "did CI ran pass?" in the checklist07:25
jbermudesSaviq: Thanks, I'll take a look07:26
mzanettiMacSlow: now we only would need use that07:26
MacSlowmzanetti, for unity8 there's no ci-related bullet-point in the required checklist07:28
mzanettiMacSlow: you didn't ever do a review so far?07:28
SaviqMacSlow, https://wiki.ubuntu.com/Process/Merges/Checklists/Unity8#preview07:29
Saviq" * Did CI run pass? If not, please explain why."07:30
SaviqMacSlow, in the review one, not submission07:30
MacSlowSaviq, mzanetti: I was referring to the submission-checklist07:30
SaviqMacSlow, when submitting, you don't know if CI will pass, so would be kinda weird07:31
MacSlowSaviq, indeed07:31
SaviqMacSlow, and we don't want to require you to run all the tests locally, because that what we have CI for07:31
tsdgeosMacSlow: lp:~macslow/unity8/fix-1348092 does not merge cleanly07:35
MacSlowtsdgeos, I look into that once I've sorted out the current qml-test failure07:36
MacSlowSaviq, I can't see the relation between the current qml-test failure of notifications and the disabled animations07:38
* MacSlow looks for sugar and caffeine07:39
SaviqMacSlow, well, those tests passed yesterday, don't today, they're in notifications...07:41
SaviqMacSlow, most probably something depends on opacity07:41
SaviqMacSlow, so yeah, your workaround broke sounds in notifications07:42
tsdgeosSaviq: i'm going to discard https://code.launchpad.net/~unity-team/unity8/category-transition-speed-fix/+merge/20389807:43
MacSlowSaviq, *sigh* yeah07:43
tsdgeosit's old by nic d'offay and we don't even have FilterGrid.qml anymore07:43
Saviqtsdgeos, kk07:43
tsdgeosso it's not that's its of much interest to keep around07:44
MacSlowSaviq, fixed it07:46
tsdgeosSaviq: comments on https://code.launchpad.net/~nick-dedekind/unity8/indicator-polishing/+merge/228700/comments/563749 ?08:09
Saviqtsdgeos, https://blueprints.launchpad.net/ubuntu-ui-toolkit/+spec/time-formatter08:10
SaviqRegistered by Michał Sawicz on 2013-12-1008:10
tsdgeosbut meanwhile08:10
tsdgeosdo we want to use dgettext with indicator domain to save us the trouble of carrying different translations08:11
tsdgeosand risk them breaking if indicator changes08:11
Saviqtsdgeos, yeah, just commented08:13
Saviq@unity, change of plans for landing priorities: http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu&q=landing-01608:13
Saviqplease if one of those branches is yours in review (or yours in the first place), drive it to a close08:14
* Saviq finds it difficult to not see inline comments in *current* diff in LP08:15
MacSlowSaviq, mzanetti: Here's the fix... AP- and qml-tests pass locally... https://code.launchpad.net/~macslow/unity8/qmltest-tweak-for-1354406-workaround/+merge/23168708:16
tsdgeosmarcustomlinson: ping08:17
mzanettiMacSlow: interesting.... did you try if only removing line 40 in this second diff would be enough to work around the issue?08:17
mzanettiI could imagine that this layer.enabled stuff is the thing that makes it slow08:17
SaviqMacSlow, why comboButton.text = comboRepeater.count >= 3 ? comboRepeater.itemAt(2).actionLabel : "" ?08:19
Saviqmzanetti, in theory layer is only enabled during transitions (to make the fade nicer), but I imagine this could have an impact indeed08:20
mzanettiSaviq: reading the the "fix" I had a hard time to see how it could be related tbh08:21
mzanettiSaviq: now that I see that it implcitly disables that layering I kinda get a feeling about it08:21
mzanettiSaviq: I think what happens is that it stacks multiple of those layer.enabled = true on top of each other, animating each's opacity08:22
mzanettiwhich then makes the hardware suffer too much08:22
mzanettiso all the workaround does is to disable that transition08:22
Saviqmzanetti, but it's not about it getting slow08:23
mzanettiits not?08:23
Saviqmzanetti, it's about it getting stuck completely08:24
Saviqmzanetti, and why would a layer be so hardware intensive, it only renders once and then animates opacity on a single texture (instead of all the children)08:24
mzanettidunno... but why would a NumberAnimation on opacity lock up the device08:25
mzanettithe layer.enabled is the closest thing I could think of...08:25
MacSlowmzanetti, it speeds it up... at least it seemed to speed up the qmltest-run08:27
MacSlowSaviq, avoids QWARNs08:27
Saviqmzanetti, it doesn't *lock up* the device08:27
Saviqmzanetti, it confuses the modal overlay08:27
Saviqmzanetti, so device works just fine, you can even still dismiss the invisible notification if you know when to tap, and all goes back to normal08:28
MacSlowmzanetti, Saviq: what happens is that the opacity-animation gets stuck at value 0... everything else just runs fine08:29
MacSlowmzanetti, Saviq: e.g. one can still interact with the invisible snap-decision and tap the button to proceed08:29
Saviqlooks like a missing glyph in Ubuntu mono, too08:30
MacSlowmzanetti, typo?! with dead-keys :)08:30
mzanettiMacSlow: hah... you have no idea what typos I'm capable of08:30
MacSlowmzanetti, :)08:30
mzanettiactually I scratched my screen above that ḿ before, thinking it would be dirt08:31
mzanettididn't know this was possible08:31
MacSlowtsdgeos, I'll now look into making lp:~macslow/unity8/fix-1348092 merge and pass ... again :)08:51
CimiSaviq, scope settings and overlay padding review :)08:58
SaviqCimi, and why is it me that has to do them? :P08:59
SaviqCimi, settings I'll do08:59
CimiSaviq, because a bird one day told me to push people to get reviews :)08:59
Saviqoverlay padding - wonder if we need a test in testCard08:59
SaviqCimi, *people*, not *Saviq*08:59
SaviqCimi, we've broken the margins so many times now I'd like to have those autotested please09:00
CimiSaviq, in a separate branch09:00
Saviqmzanetti, ah btw, if you have concerns about the lockscreen design, please do screenshots and ask kemmko to have a look09:00
Saviqmzanetti, before and after that iss09:00
dednicktsdgeos: ack on the datetime not updating. not same bug as my branch fixes, but looking into if it's a unity8 issue.09:01
tsdgeosSaviq: what does https://code.launchpad.net/~pitti/unity8/use-langpack/+merge/231390 actually do/mean09:01
Saviqtsdgeos, see description09:01
Saviqtsdgeos, https://lists.launchpad.net/ubuntu-phone/msg08566.html09:02
tsdgeosSaviq: so we'll lose all the .po from the repo?09:02
Saviqtsdgeos, no09:02
Saviqtsdgeos, that basically means .mo are shipped separately, meaning a) can be installed per-language, not per-package; b) can be updated as translations in launchpad are updated09:03
Saviqwithout upstream release09:03
Saviqtsdgeos, we will lose .mo from  the binary packages09:03
CimiSaviq, but how do we do a test in testCard when the containers and items are dinamically generated?09:08
SaviqCimi, testCard uses cardcreator09:09
CimiSaviq, yes09:09
Saviqgreyback, hey man, so... seems like Daniel's lifecycle got in before surface sizing, how about we rebase and land them together?09:10
CimiSaviq, ah I see how we can do it09:10
greybackSaviq: ok09:11
CimiSaviq, using calculation of x and width of title item and noticing the position of it compared to the right edge of the bigger container09:11
SaviqCimi, bingo!09:18
Saviqexclamation mark09:18
tsdgeosSaviq: http://paste.ubuntu.com/8104832/ quick MR to add i18n.tr to the ones in /qml/Panel/Indicators ?09:23
Saviqtsdgeos, dev tools, we don't want to translate those09:23
tsdgeosah damn09:24
Saviqtsdgeos, Clear and Empty I think are gone already09:24
tsdgeosi always forgot client is a dev tool09:24
Saviqdednick, ↑?09:24
tsdgeosSaviq: they'll be gone with https://code.launchpad.net/~nick-dedekind/unity8/indicator-polishing/+merge/22870009:24
tsdgeoswhich is still in progress09:24
tsdgeosbut o09:24
dednickSaviq: ?09:26
dednickyes, will be gone.09:26
dednickif that's what you're asking09:27
tsdgeosmzanetti: https://code.launchpad.net/~mzanetti/unity8/new-lockscreen-design/+merge/230478/comments/56378109:34
mzanettitsdgeos: shouldn't that happen automatically?09:34
* mzanetti doesn't even know how to do that09:35
tsdgeosmzanetti: it should in the ideal world09:35
tsdgeoswe live in the sad world09:35
tsdgeosmzanetti: make knows09:35
tsdgeosactually no, not make09:35
tsdgeosyes make too09:36
tsdgeoseither make unity8.pot or just run po/update-unity-pot09:36
mzanettiwell, just running "make" doesn't09:36
Saviqmake pot_file09:36
tsdgeosah that09:36
tsdgeosthe cmake file is confusing09:36
mzanettitsdgeos: pushed09:36
mzanettitsdgeos: that's cause its cmake :)09:36
tsdgeosleast confusing of the buildsystems if you ask me09:37
Saviqmzanetti, tsdgeos, it *could* happen automagically, but if it happens automagically on each MP then we'll be flooded with pot-only changes09:37
tsdgeosSaviq: and noone will care09:37
mzanettiSaviq: don't we have like daily launchpad translations commits anyways?09:37
Saviqif it happens on package build, then it doesn't end up in our trunk09:37
Saviqmzanetti, translations, not templates09:37
Saviqmzanetti, LP doesn't know how to extract the strings09:37
Saviqif it doesn't end up in our trunk, it doesn't end up on translations.lp.com09:38
Saviqso useless09:38
tsdgeoswhich is sad given how i maintain something created more than 10 years ago that does already that :D09:38
tsdgeosbut that's a different story09:38
Saviqtsdgeos, well, we just lack convention, completely agree09:38
Saviqtsdgeos, slight problem is, some projects might require additional deps to generate the templates09:39
tsdgeosSaviq: if i can get volunteers to agree on convention, i'm pretty sure we can get paid developers to agree on them ;)09:39
Saviqtsdgeos, so it's not just a case of "aaah, execute that script"09:39
tsdgeosit really is09:39
tsdgeosyou just need to have the available deps on the server09:39
Saviqtsdgeos, except you don't have the right to install them on the machine that executes it09:40
Saviqtsdgeos, anyway, I do have an idea that will work, just need to flesh it out with the train folks09:40
Saviqtsdgeos, as I believe this should happen in train, just after merging all the MPs09:41
tsdgeosi'm just saying this is far from an unsolvable problem09:41
Saviqtsdgeos, sure09:41
Saviqtsdgeos, ideally we'd have the same for qmltypes09:41
Saviqtsdgeos, although these, arguably, should come with the changes to plugins09:41
tsdgeosqmltypes should be just part of make09:41
Saviqtsdgeos, can't be09:41
Saviqtsdgeos, because requires all the *runtime* dependencies of a plugin09:42
Saviqand anyway IMO generated stuff != build-time generated09:42
Saviqnot necessarily at least09:43
tsdgeosSaviq: honestly, if i am compiling somethign i may as well have the runtime dependencies09:44
tsdgeosotherwise i'll have a problem in 5 seconds after i try to run the thing i compiled09:44
tsdgeosunless i'm the build servers of course09:44
Saviqtsdgeos, if *you* are, maybe, if a build machine does, not so much09:44
Saviqtsdgeos, yes exactly09:44
tsdgeoswell there's something called conditional building09:44
Saviqtsdgeos, we can make ./build.sh09:44
Saviqto do qmltypes too09:44
Saviqtsdgeos, but we can't put them in ALL09:45
tsdgeoswe can09:45
tsdgeoscmake can do it if you have the dependencies09:45
tsdgeosbut it's ok09:45
Saviqtsdgeos, but if they're checked into trunk anyway, it's a waste, and if there's only one that can't be built build-time, they need to be checked in09:45
tsdgeosit's not like i have any use for those qmltypes files :D09:45
Saviqyou kinda do, assuming QtC can actually find them ;P09:46
tsdgeosthe translations are a much more pressing issue09:46
tsdgeosSaviq: and assuming i use QtC ;)09:46
Saviqtsdgeos, WAH!?09:46
Saviqtsdgeos, yeah, I'll talk to landing guys today09:46
mzanettiSaviq: can we programmatically run scopes (from outside unity)09:51
mzanettiSaviq: like using a script or something to load a newly installed scope09:51
mzanettiand display it09:51
Saviqmzanetti, scope tool09:51
Saviqmzanetti, point at the .ini file09:51
mzanettion the phone too?09:52
Saviqmzanetti, on phone just go to overview09:52
mzanettiSaviq: programmatically09:52
Saviqmzanetti, it'll be there09:52
Saviqmzanetti, what do you want to achieve? :)09:52
mzanettiSaviq: clicking play in QtC and showing the scope09:52
mzanettiso actually zbenjamin, not me09:52
Saviqmzanetti, we should add a url handler to unity8-dash09:53
* zbenjamin reads backlog09:53
mzanettiSaviq: makes sense09:53
Saviqmzanetti, and when deploying the scope, he'd restart scope-registry and url-dispatch scope:///scopename09:53
Saviqzbenjamin, ↑09:53
mzanettiyep, sounds sane09:54
zbenjaminSaviq: oook thanks, going to try that!09:54
mzanettiSaviq: doesn't say how to register it though09:55
Saviqmzanetti, https://wiki.ubuntu.com/URLDispatcher -ish09:55
mzanettizbenjamin: ok... so seems requires some change in unity8-dash, shouldn't be too hard, but needs to be done still09:56
Saviqmzanetti, http://bazaar.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk/view/head:/ubuntu-system-settings.url-dispatcher09:56
mzanettiright... got it09:56
zbenjaminmzanetti: ok so its not there yet, because the scopes team said its all in place (or does the scope start but not come up yet)09:56
Saviqinstalled into /usr/share/url-dispatcher09:56
Saviqzbenjamin, their side's there09:56
Saviqzbenjamin, ours isn't, but should be maybe 20 lines diff09:57
mzanettiyeah... and most of it { and }09:57
mzanettistill... tbd09:57
zbenjaminSaviq: ok and eta when i can get this?09:57
zbenjaminSaviq: we should have that before RTM09:57
mzanettizbenjamin: you could try to add it yourself ;)09:57
* zbenjamin hides09:57
zbenjaminmzanetti: ugh ;)09:58
mzanettizbenjamin: well, its just adding that hook file to unity8 and then adding this: http://developer.ubuntu.com/api/qml/sdk-14.10/Ubuntu.Components.UriHandler/ to Dash.qml09:58
zbenjaminmzanetti: ok, let me see09:59
Saviqtsdgeos, can you tell zbenjamin what he'd need to do with scope:/// uris from url dispatcher? Scopes.performQuery or something?10:02
Wellarkmzanetti: thanks for reminding about the SIM unlock situation10:03
tsdgeosSaviq: not sure i understand question/context10:03
Wellarkit's basically the same thing I talked about introducing the dual sim support.10:03
tsdgeosi mean, yes, i'm sure i don't understand  it :D10:03
Wellarkto the backend10:03
Wellarkthat will fix it also10:03
Saviqtsdgeos, we'll get a scope:/// url from url-dispatcher10:03
Saviqtsdgeos, what do we need to do with it so that Scopes gives up openScope or gotoScope?10:03
Wellarkmzanetti: care to do the review tomorrow?10:03
mzanettiWellark: sure10:04
tsdgeosSaviq: good question10:04
tsdgeoslet me see10:04
Wellarkmzanetti: thanks!10:04
Saviqtsdgeos, I'm slightly worried it's Scope::performQuery10:04
tsdgeosi am not sure10:04
tsdgeosit was for a brief moment10:04
Saviqtsdgeos, so we'd need to grab the first scope and call that (yuck)10:04
Saviqtsdgeos, it's whatever the header links do10:04
tsdgeosbut then mhr3 changed it i think10:04
Saviqtsdgeos, nah, it's still Scope::performQuery10:05
tsdgeosactualy yes10:05
tsdgeosyou're right10:05
tsdgeosit's only 2 / and not 3 it seems though10:05
tsdgeos./qml/Dash/ScopesOverview.qml:450:                    scope.performQuery("scope://com.canonical.scopes.clickstore");10:05
Saviqyeah that's fine10:05
zbenjaminmzanetti: i just wonder where to add the hook, does unity come with its own manifest file?10:05
tsdgeosor maybe both work10:05
Saviqtsdgeos, no10:06
Saviqtsdgeos, scope name is the hostname part in there10:06
Saviqtsdgeos, but that's fine, only problem I'm seeing is that it's on Scope:: and not Scopes::10:06
MacSlowSaviq, mzanetti: it passed on jenkins... https://code.launchpad.net/~macslow/unity8/qmltest-tweak-for-1354406-workaround/+merge/23168710:06
tsdgeostaht's by design10:06
tsdgeosas openScope is also in scope10:07
tsdgeosnot in scopes10:07
Saviqtsdgeos, well, yeah, broken design IMO :P10:07
tsdgeosa design i don't really agree much with tbh10:07
tsdgeosbut it's the design10:07
Saviqok so we need to grab the current scope and performQuery() on that10:07
Saviqtsdgeos, well, reason kinda is that we open the temp scope inside GSV10:07
Saviqtsdgeos, when we go for a stack, I think we'll be able to move up to Scopes10:08
tsdgeoslet's see10:08
Saviqso /me thinking DashContent.qml: UriHandler { onOpened: currentItem.scope.performQuery(uris[0]) }10:09
Saviqzbenjamin, ↑ something like this, unless tsdgeos vetoes10:10
tsdgeosyeah makes sense10:10
zbenjaminSaviq: ok10:10
larsuseb128: your warning comes from the fact that qt tries to load the icon with a size of (32,0) first10:12
larsuthen, when it doesn't find it, it runs the same query again with 32,3210:12
=== vrruiz_ is now known as rvr
larsuah, QSize::isValid() returns true for sizes that are 0 in one dimension, but QIcon::pixmap() from such a size returns an invalid pixmap10:15
zbenjaminSaviq: where do i need to put the hook/url dispatcher file ?10:15
Saviqzbenjamin, /usr/share/url-dispatcher10:16
zbenjaminSaviq: i don't see a manifest file or any other files like this in the unity8 tree10:16
Saviqzbenjamin, see how ubuntu-system-settings does it10:16
Saviqzbenjamin, not sure if there's a post-inst required, url-dispatcher should pick them up automagically I'd say10:16
zbenjaminSaviq: ok10:17
Saviqzbenjamin, yeah, just install it into /usr/share/url-dispatcher10:17
Saviqzbenjamin, with schema: "scope"10:17
zbenjaminSaviq: ok so i put the file there, probably unity.url-dispatcher and then just register with the QML component to the URL?10:18
seb128larsu, 0? weird...10:19
seb128larsu, is the custom component buggy for doing a call with 0?10:19
Saviqzbenjamin, unity8-dash.url-dispatcher please, and yeah, the above in DashContent.qml10:19
larsuseb128: ya... "If requestedSize is a valid size, the image returned should be of that size."10:19
zbenjaminSaviq: ah now i see the APP_ID is used as selector10:19
larsuseb128: no, qt does this even when I explicitely set sourceWidth and Height10:19
Saviqzbenjamin, right10:20
seb128larsu, that seems buggy...10:20
Saviqlarsu, seb128, that's why Icon has a workaround10:20
Saviqthat it only sets source *after* both sourceSize.width and .height are > 010:20
zbenjaminSaviq: thx10:20
mzanettizbenjamin: sorry... just saw you message now (doing operator tests atm)10:20
zbenjaminmzanetti: np Saviq helped me to figure it out10:20
larsuSaviq: what do you mean by after? Does property ordering matter? Or in onComponentComplete?10:21
Saviqlarsu, it just goes source: width > 0 && height > 0 ? blah : ""10:21
larsuSaviq: that's ... annoying10:21
Saviqlarsu, it is, that's declarative for you10:21
Saviqlarsu, fwiw, sourcesize 0 is valid10:22
Saviqlarsu, just not for an icon from a theme :|10:22
larsuI wonder if I should just use width=height?10:22
larsuI'd do that in StatusIcon anyway...10:23
Saviqlarsu, that's still a binding10:23
larsuSaviq: I mean in the image provider10:23
Saviqlarsu, no, StatusIcon supports non-square icons10:23
Saviqit's its whole purpose, really10:23
Saviqlarsu, but yeah, in the theme image provider10:23
Saviqlarsu, it makes sense to just go =10:23
Saviqlarsu, there's a but, though10:23
larsuSaviq: it doesn't load my icon when I don't set sourceWidth10:23
Saviqlarsu, that will still call the provider twice...10:24
Saviqlarsu, StatusIcon??10:24
larsuI might have patched it ... a bit10:24
Saviqlarsu, works in indicators...10:24
Saviqand elsewhere in the shell?10:24
* larsu wonders why this is so complicated10:24
larsuSaviq: I've simply removed the custom theme lookup in StatusIcon and I can't find where it used to set the width...10:26
Saviqlarsu, because icon themes do not support non-square icons...10:27
Saviqlarsu, it didn't10:27
larsuah, it loads the image directly10:27
* larsu gets it now, thanks10:27
Saviqlarsu, yes10:27
Saviqlarsu, it's a stupid/nasty hack, but it works ;P10:27
larsuya... :/10:27
Saviqlarsu, need to come up with how we start supporting non-square assets in the theme10:28
larsudoes the fdo spec care about that?10:28
larsuor is it just qt not handling this right?10:28
Saviqlarsu, no, the theme only has "size"10:28
Saviqlarsu, the theme definition I mean10:29
Saviqlarsu, so (without reading the spec, though) it seems like it only supports squares10:29
larsuya, makes sense10:29
tsdgeosspec assumes squares everywhere10:29
tsdgeoswhy would anyone want non square icons... :D10:30
Saviqtsdgeos, you know who to talk to?10:30
SaviqI can tell you ;)10:30
tsdgeosi'm not an expert in the field10:30
tsdgeosmy opinion is the one of a simple user10:30
Saviqtsdgeos, sil2100, bug #135966710:31
ubot5bug 1359667 in Canonical Upstream To Distro "There should be a hook mechanism available" [Undecided,New] https://launchpad.net/bugs/135966710:31
tsdgeosSaviq: looks sane10:32
Saviqtsdgeos, confirm please10:32
sil2100Saviq: thanks :)10:33
larsuSaviq: does requesting an image with a width of 0 usually mean "preserve aspect"? I might just implement that in the icon theme provider then10:35
Saviqlarsu, yes10:47
Saviqlarsu, there's a few intricacies, see http://qt-project.org/doc/qt-5/qml-qtquick-image.html#sourceSize-prop10:47
Saviqlarsu, the problem is though how do you select an image from the theme10:47
Saviqlarsu, you'd have to assume "size" to be either height or width10:48
SaviqFWIW in our use cases it's always height AFAICT10:48
=== MacSlow is now known as MacSlow|lunch
larsuk, thanks10:49
Saviqgreyback, didn't reply to my other inline comments on purpose or missed them?11:01
greybackSaviq: sorry I find inline comments easy to miss11:02
greybackok found 'em11:03
Saviqgreyback, yeah, ctrl+F $reviewer is what I do, totally agree though11:04
greybackSaviq: "Fire. Exclamation mark." we don't like expressing surprise/astonishment?11:10
Saviqgreyback, j/k, there was a significant count of exclamation marks in your MP is all ;)11:11
* greyback going to start putting emoticons in his code now11:12
zbenjaminSaviq: is there any way i can see unity output on the phone?11:15
zbenjaminSaviq: i mean stdout/stderr11:16
zbenjaminmzanetti: ^11:16
mzanettizbenjamin: ./cache/upstart/unity8.loh11:17
zbenjaminmzanetti: in phablet home?11:17
zbenjaminmzanetti: ok, how is there url-dispatcher command called?11:22
zbenjaminor is it located not in the path?11:22
CimiSaviq, tests added https://code.launchpad.net/~cimi/unity8/overlay-right-padding/+merge/23158611:23
mzanettizbenjamin: hmm... that's called when you do Qt.openUrlExternally() in qml, or with QDesktopService::openUrl() or similar11:24
mzanettizbenjamin: how to do that in python, I have no clue11:24
zbenjaminmzanetti: ook there is /usr/lib/arm-linux-gnueabihf/url-dispatcher/url-dispatcher11:24
mzanettiyeah... I guess you can invoke that with a aparam too11:25
mzanettihaven't ever done it myself though11:25
zbenjaminmzanetti: not working11:25
mzanettiSaviq: do you know=11:26
zbenjamin** (process:11117): ERROR **: Unable to connect to D-Bus: Could not connect: Connection refused11:26
mzanettizbenjamin: you are trying that in a user session, right?11:26
mzanettinot with adb shell as root or similar11:26
tsdgeospstolowski: https://code.launchpad.net/~aacid/unity8/expandable_model_not_array/+merge/23170811:26
zbenjaminmzanetti: yes11:26
tsdgeosSaviq: is there any chance we can get https://code.launchpad.net/~aacid/unity8/expandable_model_not_array/+merge/231708 in in next mega-merge? i did a mistake in the test of expandable that means the code is also wrong11:27
zbenjaminmzanetti: ** (process:11361): WARNING **: Unable to get name 'com.canonical.URLDispatcher'  thats what i get now11:28
tsdgeoszbenjamin: you already have one running?11:29
mzanettitsdgeos: what he tries is to invoke some url from command line11:29
mzanettido you know how that works?11:29
tsdgeosnope sorry :/11:29
mzanettitedg: is that even possible?11:29
zbenjamintsdgeos: from python would be fine as well11:29
Cimitsdgeos, I can review that11:30
tsdgeosCimi: please11:30
mzanettitedg: we're trying to invoke some url from *not* Qt :) cli or python ideally11:30
tsdgeosSaviq: there's also the question if we want to show the [+]/[-] button if there's only less than "collapsible-widgets" and they are all very small (i.e. the [+][-] does nothing) or we just let the scope author use the stuff correctly11:31
zbenjaminmzanetti: actually i would prefer python ;)11:31
mzanettizbenjamin: I guess a dbus call would do then...11:31
tsdgeosmzanetti: why not from Qt?11:32
tsdgeosi mean all the Qt part does is11:32
mzanettitsdgeos: 'cause we'd need to build a binary just for this11:32
tsdgeoswhich i imagine would be the same a command line or python thing would do11:32
mzanettiok... not from c/c++11:33
mzanettiand not from qml11:33
Cimitsdgeos, doc for it?11:33
tsdgeosCimi: doc?11:33
Cimitsdgeos, where is it stated that is not an array?11:33
tsdgeoswe don't use arrays11:33
Cimitsdgeos, just to double check we are doing the right thing11:33
tsdgeoswe use models11:33
Cimitsdgeos, and was not a bug in model11:33
tsdgeosCimi: such thing does not exist11:34
facundobatistaDo you know how to take a screenshot from the phone?11:34
pstolowskitsdgeos, thanks11:34
tsdgeosfacundobatista: there's a command line app11:34
zbenjamintsdgeos: its for the SDK launcher to support running scopes from QtCreator, we have a python based script for launching apps, now we need the same for scopes11:34
zbenjamintsdgeos: thats why python11:34
tsdgeosfacundobatista: in the pc11:34
facundobatistatsdgeos, I tried "phablet-screenshot foo.png" but doesn't work11:34
tsdgeosfacundobatista: on the pc?11:34
Cimitsdgeos, https://docs.google.com/a/canonical.com/document/d/1NmiM4UCnJgf6IEawmfyTOHRNAA5ZGrqpyrPqPOibwc8/edit#heading=h.i0usbmllncqr11:35
tsdgeosfacundobatista: used to work11:35
tsdgeosCimi: yes that is all we have11:35
tsdgeosCimi: doesn't say it's a model, but it's the same structure as "previews":   "widgets":11:35
tsdgeosand "previews":   "widgets": is a model11:35
facundobatistatsdgeos, http://linkode.org/Aew2csBJKyWB7AbIJh4Qw1  maybe I'm missing a package?11:35
tsdgeosso ours should be too11:35
Cimitsdgeos, ok11:36
tsdgeosfacundobatista: thsi is whati get http://paste.ubuntu.com/8105576/11:36
Cimitsdgeos, makes sense11:36
tsdgeosfacundobatista: mayeb11:36
Cimitsdgeos, where can I find a previewExpandable to test?11:40
tsdgeosCimi: besides the testcase?11:40
Cimitsdgeos, yes11:40
tsdgeosyou need to compile "lots of stuff11:40
Cimireal one11:40
tsdgeospstolowski: ↑↑↑↑11:40
tsdgeoswell, let me just copy11:40
Cimioh arg11:40
Cimitsdgeos, let's wait a silo then11:40
tsdgeosthen run scope-A from demo/scope-A subdirectory of scopes-api with unity-scope-tool11:40
Cimitsdgeos, approved11:41
Cimitsdgeos, we should get all in a silo and test11:41
tsdgeosor you can compile it11:42
tsdgeosit takes 15 min11:42
pstolowskiCimi, it's still WIP on my side, but yeah, should work already11:42
zbenjaminmzanetti: seems dbus call it is, hopefully the interface won't change between images :/11:43
mzanettizbenjamin: unlikely11:43
karniHave you guys seen this problem where after you kill an app (swipe away), you try to launch it again, it looks like it's starting, and then it just disappears? I could share unity8.log if someone's interested or have seen a similar problem.11:45
karniif I use ubuntu-app-launch directly from adb shell, the app launches properly11:46
karnibut not from the dash, after I swipe it away11:46
karnimhall119: ↑11:46
karnifacundobatista: phablet-screenshot is in phablet-tools package11:50
facundobatistakarni, yes, but I'm getting http://linkode.org/Aew2csBJKyWB7AbIJh4Qw111:51
facundobatistakarni, I'm currently upgrading the tablet to see if that fixes it11:51
karnifacundobatista: right. sorry, I've no idea what causes that problem.11:51
Saviqzbenjamin, you want unity8-dash, not unity8.log12:00
Saviqtsdgeos, sure12:00
Saviqzbenjamin, mzanetti `url-dispatcher scope://scopename` is all you need12:01
Saviqurl-dispatcher might be in url-dispatcher-tools though, not on the phone by default12:01
mzanettiSaviq: well, there is sone url-dispatcher binary12:01
Saviqmzanetti, that's the service12:02
Saviqunfortunately named the same12:02
Saviqhence the "can't get name"12:02
mzanettiand no matter how you call it, it just prints a dbus-message and that's it12:02
Saviqbut it's not on $PATH for a reason12:02
Saviqmzanetti, that's the service12:02
Saviqmzanetti, it's already running12:02
mzanettimight be useful to say so :)12:02
Saviqmzanetti, you need the other end of that12:02
mzanettiyeah, I understand.12:02
Saviqmzanetti, it's not like you're supposed to look in /usr/lib for executables ;)12:02
mzanettiSaviq: well... that's what I thought too until recently12:03
mzanettibut seems that happens a lot around here :)12:03
Saviqmzanetti, like where?12:04
Saviqanyway, /me back to food still12:04
Cimimzanetti, if you want, I can do this https://bugs.launchpad.net/unity8/+bug/135915712:10
ubot5Ubuntu bug 1359157 in Unity 8 "Spread shadows under apps uses a synchronously loaded very big PNG (808x1320)" [Undecided,New]12:10
mzanettiCimi:  I have the assets here already... will fix it12:12
Cimimzanetti, cool12:12
=== _salem is now known as salem_
mlankhorsthey does anyone here remember what package failed with the llvm 3.5 changes? I want to retest manually before uploading next mesa built against 3.5-rc312:36
mlankhorstmy previous testcase no longer appears to work (online-account-ui)12:40
zbenjaminSaviq: can we then include the url-dispatcher-tools? the idea is that the developer should never have to enable his image to be writeable12:42
Saviqzbenjamin, it's probably best that you just invoke dbus-send, url-dispatcher-tools isn't meant to be there in the images AFAIK, we'll have to talk to tedg about this12:44
=== MacSlow|lunch is now known as MacSlow
zbenjaminSaviq: ok12:44
zbenjaminSaviq: i added this to DashContent.qml     Connections {    target: UriHandler      onOpened: dashContentList.currentItem.scope.performQuery(uris[0])    }12:45
zbenjaminSaviq: after invoking the url the Dash crashed i guess12:45
zbenjaminSaviq: its gone now12:46
Saviqzbenjamin, should've respawned12:48
tsdgeosmterry: https://code.launchpad.net/~mterry/unity8/notify-authenticated/+merge/231022/comments/56388012:48
zbenjaminSaviq: nope, just black12:48
Saviqzbenjamin, and is there a .crash file for unity8-dash in /var/crash ?12:48
Saviqzbenjamin, if you have a branch, please push/MP it and we'll have a look12:49
zbenjaminSaviq: i have no branch yet , i hacked the files on the phone ;)12:49
Saviqzbenjamin, you made it crash, now's a good time to make a branch then ;)12:50
zbenjaminSaviq: pfffft ;)12:50
mterrytsdgeos, replied12:51
tsdgeosmterry: would that test have catched this bug?12:51
Saviqgreyback, you need to resubmit with lifecycle as a prerequisite12:52
pstolowskiSaviq, hey, can we land this https://code.launchpad.net/~stolowski/unity-scopes-shell/favorite-scopes/+merge/230824 ?12:53
mterrytsdgeos, hrm maybe not, because that new test is in the WithPin test.  Alright, you got me.  :)  I'll add a brief test in this branch12:53
tsdgeosmterry: ;)12:53
tsdgeosmterry: only if it's not a lot of work12:54
Saviqpstolowski, sure, ACKed12:54
Saviqpstolowski, if you want, you can land, otherwise I'll land when unity8 adapts12:54
mterrytsdgeos, I think I'll just add a tiny test to confirm that various properties are correct, nothing complicated12:54
greybackSaviq: the qtmir branch? They merge cleanly already, so it prereq really needed?12:56
Saviqgreyback, for completeness, and then you'd add your entry to the changelog12:57
greybackSaviq: completeness, ok. Isn't changelog added by train though?12:57
Saviqgreyback, not if it's being touched12:57
greybackSaviq: ok12:58
mterrytsdgeos, done12:59
tsdgeosmterry: oki, another very small thing at https://code.launchpad.net/~mterry/unity8/no-lock-during-call/+merge/22799613:00
mterrytsdgeos, I just updated the qmltypes now13:01
mterrytsdgeos, awesome thanks!13:04
tsdgeosanyone else is missing a review?13:05
tsdgeosfrom a quick look at them seems most of them are already picked by someoene13:05
pstolowskiSaviq, thanks. it's ok to land with unity813:08
pstolowskithostr_, ^13:08
thostr_pstolowski: ack, thanks13:09
kgunnSaviq: sorry i didn't land anything other than the workarounds, would it help if i worked on landing what's approved while you do "other stuff"13:11
kgunne.g. silo1613:12
zbenjaminSaviq: lp:~zeller-benjamin/unity8/scope-url13:14
Saviqkgunn, there's some review / tweaking work needed in silo 16 still13:14
Saviqkgunn, which is what I'm after now13:14
Saviqkgunn, it's fine (re landing fixes), only our ci is red again because of that ;P13:15
greybackSaviq: ok my 3 branches rebased on top of dandrader's13:19
greybackwaiting for him to update changelogs whenever he appears13:19
Saviqgreyback, whyy? you just add an entry in yours instead?13:21
Saviqgreyback, just in your branches, now that you merged his13:21
greybackSaviq: completeness? :)13:21
Saviqgreyback, go `dch "initial surface sizes"` or so13:21
Saviqgreyback, but his branches shouldn't be changed just because yours ar based on his?13:22
mzanettiSaviq: :) is my device now going to flash whenever I press the volume down button?13:28
greybackSaviq: changelog on qtmir pushed13:28
kgunnSaviq: what's red on ci ?13:28
kgunnunity8 or something else ?13:29
Saviqkgunn, MacSlow's workaround broke notification sounds13:29
Saviqkgunn, for which there's a test that now fails13:29
Saviqmzanetti, read my review13:30
mzanettiSaviq: yeah, didn't really get that comment :)13:30
MacSlowkgunn, Saviq: well I've fixes in MPs up to sort out all issues which came up13:33
SaviqMacSlow, sure, I'm just complaining to kgunn that he was sloppy :P13:34
Saviqbut maybe the situation required some of it ;)13:34
kgunnit did remove the pressure13:34
MacSlowkgunn, Saviq: I got everybody's back covered still :)13:34
Saviqkgunn, yeah, I know, which is why I didn't mention it yesterday and let it all through, but want to fix it again asap13:35
Saviqgreyback, waait13:35
Saviqgreyback, you don't need a changelog entry for *qtmir*13:36
MacSlowkgunn, Saviq: although no progress yet on the real issue of the opacity-animation getting stuck... but I'd rather see the workound-fix and MPs for LP: #1348092 land13:36
Saviqgreyback, only for unity-api13:36
ubot5Launchpad bug 1348092 in Unity 8 "rtm design updates for notifications" [High,In progress] https://launchpad.net/bugs/134809213:36
Saviqgreyback, deps between qtmir and unity8 are handled by the -impl-foo virtuals13:36
Saviqgreyback, that is, unless you wanted a qtmir 0.4.2 anyway13:36
greybackSaviq: I did13:37
Saviqgreyback, but yeah, no need for Daniel's entry there13:38
Saviqgreyback, let me clarify one thing13:38
Saviqwith sil13:38
Saviqsil2100, two MPs, second (in order of merging) of them touches changelog, the other does not, will the first one's commit message be appended to the changelog anyway?13:39
sil2100Saviq: hmm, I would expect it to, yes, but let me dive into the code and make sure it does13:40
Saviqsil2100, nw, we'll find out soon enough :)13:40
Saviqgreyback, so yeah, sorry, I miscommunicated, for a *particular MP* changelog isn't used if it's touched13:41
Saviqgreyback, so please drop Daniel's entry from your MP13:41
sil2100If it doesn't, it's a bug ;) But this part of CI Train code is a bit specifically written, so it's always hard to easily check and modify13:41
Saviqs/isn't used/is used/13:42
Saviqgreyback, as long as Daniel's branch doesn't touch changelog, his commit msg will be added to your v0.4.213:42
greybackSaviq: ok13:42
greybackSaviq: ok, for unity-api, daniel adds custom changelog, so my branch on top does not touch changelog13:47
greybackfor qtmir, Daniel does not touch changelog. My branch on top does however, bumping version number13:47
greybackI was updating u8, forgot where I am with that, but will get it in shape13:48
Saviqgreyback, yeah, thanks13:52
zbenjaminSaviq: did you see my branch? or who is the right person to look at it?13:58
tsdgeosmzanetti: is https://code.launchpad.net/~mzanetti/unity8/smaller-dropshadow-asset/+merge/231729 really dependant on your prerequisite?14:16
tsdgeosor you're just chaining it for easy merging14:16
mzanettitsdgeos: easy merging14:16
mzanettitsdgeos: it'll conflict otherwise14:16
=== alan_g is now known as alan_g|tea
Cimidednick, standup14:31
=== om26er is now known as om26er|doctor
=== alan_g|tea is now known as alan_g
Saviqmterry, hey, lp:~mterry/unity8/sim-unlock-on-boot conflicts with lp:~mterry/unity8/sim-unlock-on-boot could you please chain them?14:40
mterrySaviq, try again?14:41
Saviqmterry, Text conflict in tests/qmltests/tst_Shell.qml14:43
Saviq1 conflicts encountered.14:43
mterrySaviq, yeah but you copy and pasted the same url14:44
mterrySaviq, which two conflict?14:44
Saviqmterry, aah14:44
Saviqmterry, lp:~mterry/unity8/notify-authenticated14:44
mterrySaviq, OK, will chain14:44
mterrySaviq, updated notify-authenticated to include sim-unlock-on-boot14:47
Saviqmterry, thanks15:12
Saviqmterry, will you resubmit with prerequisite too?15:17
mterrySaviq, oh I figured that would be unnecessary paperwork, but I can do15:20
Saviqmterry, it ensures correct ordering of merges :)15:21
mterrySaviq, done15:22
Saviqmterry, thanks15:22
mterry(including re-setting the commit message -- so annoying that that's lost on a resubmit)15:22
Saviqmterry, +115:23
mterrySaviq, btw I'm gone tomorrow and Monday.  I don't think there's anything waiting on me, but just so you know15:35
Saviqmterry, how about the u-s-c crash?15:36
mterrySaviq, ah, you said moving toward me as if the diagnostics for where the fault lay weren't settled yet, so I hadn't started looking.  I can look today and do a brain dump on the bug15:38
Saviqmterry, yeah, please do15:38
mterryCimi, speaking of, I'm out tomorrow and Monday, so if the location-page merge is still in limbo, can you please find someone to finish it up?15:41
dandraderSaviq, Ha! I think I have a way to reproduce the mysterious no mouse-event bug (or something similar to it)15:45
Saviqdandrader, oh!15:46
=== gatox is now known as gatox_lunch
=== om26er|doctor is now known as om26er
Saviqgreyback, what's with https://code.launchpad.net/~gerboland/qtmir/lttng/+merge/231750, why's that resubmitted too? and why do I see a changelog entry there ¿?16:06
greybackSaviq: rebased on top of something else in the silo. changelog remnant of something, removing16:08
Saviqgreyback, yeah, was no need to rebase though?16:08
Saviqno conflict I mean16:08
Saviqgreyback, I know, you hate me today16:08
Saviqgreyback, I wanted the rebase on Daniel's lifecycle because there were conflicts16:09
greybackI'm making a clear path of MRs, so there's no ambiguity16:09
Saviqgreyback, yeah, but now I need to rebuild again ;)16:09
Saviqanyway, doing16:09
greybacksorry about that16:10
Saviqgreyback, so yeah, at least my approach is to only chain MPs that are, or have the potential to, conflicting16:10
greybackand no I don't hate you, I understand your approach16:10
greybackI just dislike that the system requires such an approach16:11
Saviqgreyback, otherwise you're locking your branches in an order, and if one of the bottom ones does not land for whatever reason, the rest is blocked16:11
Saviqgreyback, meaning that there's more than one MP in parallel at any given point? or?16:11
greybackI just don't trust that "potential to" thing16:11
greybackit's hard to predict16:11
Saviqgreyback, well, it's not like you can't resubmit when it happens16:12
greybackSaviq: this chaining approach is effectively compensating for lack of a proper trunk16:12
greybackand yes I understand the arguments for and against16:12
greybackand what you're doing is the best we can do. Just the amount of shepherding you have to do is unreal16:12
Saviqgreyback, I'm playing with a modified devel approach in my mind16:13
Saviqgreyback, but any single devel/staging branch gets us into a "only one landing happening at a time" too, because without testing a set of projects (like unity-api,qtmir,unity8 in a single silo) all together, they shouldn't get into staging/devel even IMO16:15
Saviqgreyback, but we could go for a hybrid approach16:16
greybackSaviq: yep that I get too.16:16
Saviqgreyback, if you want, I can describe what I've in mind16:17
greybackI'd love a dedicated branch of trunk, with the MRs applied, that you could pass to the silo somehow. And would land in a way that would not screw up the history16:17
greybackSaviq: well I'm holding off opining until the promised next iteration appears16:17
Saviqgreyback, airline will not change that16:17
Saviqgreyback, but yeah, that's what I was thinking of a hybrid approach, a branch that's clean *on top* of trunk, that would get pulled, not merged, with any additional MPs put on top16:18
Saviqgreyback, so we'd stage self-contained branches, that would get pulled (not merged) onto trunk, on top of that would go any additional MPs in the silo16:20
greybackSaviq: sounds like a dev branch per silo16:20
greybackif we can pull onto trunk, then yes I like that16:20
Saviqgreyback, yeah, except I wouldn't do it per silo16:20
Saviqgreyback, MPs that require other project changes would not get staged16:21
Saviqgreyback, we'd only staged top-ack'ed, self-contained MPs16:21
SaviqI'd still target them against trunk16:21
Saviqbut somewhat manually stage on lp:unity8/staging16:21
Saviqso they remain Approved until they land in trunk16:21
Saviqso that there's no confusion between Merged into trunk and Merged into staging/devel, as there generally is16:22
greybackSaviq: there'll be multiple such branches so. And conflicts will remain easy to happen and miss16:22
Saviqgreyback, which ones? those that require other projects?16:22
Saviqgreyback, they could get staged if the relevant projects had staging too16:23
Saviqgreyback, they'd get staged together16:23
Saviqthis would have to be in sync so that you can actually build trunks against trunks, stagings against stagings16:24
Saviqgreyback, but that also means we'd need to sync releases between projects16:24
greybackthat's what the train is for :)16:24
greybackI need to chew on the idea more16:24
Saviqgreyback, well, yeah, but how can you stage something that you haven't properly tested (and by properly with packages built by lp)16:25
Saviqgreyback, if we staged all of them together, that would then mean all the projects will only be landed when the slowest one's staging lands16:26
Saviqso the slowest one starts blocking others16:26
Saviqwhich is why I'd lean towards not staging non-self-contained changes16:26
Saviqdandrader, if you could have another look at https://code.launchpad.net/~gerboland/qtmir/lttng/+merge/231750 - greyback pushed a few commits more16:34
Cimimzanetti, did you see my comment on the right padding branch?16:35
* mzanetti looking16:35
mzanettiCimi: GRID_UNIT_PX=1616:39
Cimimzanetti, hah16:40
mzanettiCimi: so not sure if your change is actually the culprit16:40
mzanettiCimi: fails in trunk too... mind fixing it nevertheless? Your branch is close enough16:42
dandraderSaviq, done16:47
Cimimzanetti, I don't know why results are wrong at different gu16:48
Cimimzanetti, might be me using mapToItem wrong16:48
Saviqdandrader, thanks16:48
=== alan_g is now known as alan_g|vt
mzanettiCimi: hmm... ok... then I'll have a look at some point here.16:52
mzanettiCimi: any idea why testGenericScopeView fails on Jenkins?16:52
Cimimzanetti, nope16:52
mzanettifails here too16:53
Cimimzanetti, something here is crazy16:57
Cimimzanetti, titleToCard.x @ 8gu is 6416:57
Cimi@16 is 16???16:57
mzanettiCimi: I don't really know what it what atm16:59
=== alan_g|vt is now known as alan_g
Cimimzanetti, var titleToCard = title.mapToItem(card, 0, 0, title.width, title.height);17:01
Cimimzanetti, the x of this Item does crazy things when changing GU17:01
=== gatox_lunch is now known as gatox
mzanettiyeah... I mean I don't know where the tile in the card is etc17:02
mzanettistill trying to figure17:02
Cimimzanetti, is the title you see... doesn't visually change position17:02
Cimimzanetti, unless is relative to a previous load17:02
Cimimzanetti, it's a race!17:03
Cimimzanetti, I added wait(1000) after the waitForRendering17:04
Cimimzanetti, it might be because title is the variable in the TestCase, and not calculated there17:04
dandraderMirv, so I wanna propose a patch for merging into qtdeclarative-opensource-src. Should it go to lp:ubuntu/qtdeclarative-opensource-src or lp:ubuntu/utopic-proposed/qtdeclarative-opensource-src17:04
mzanettiCimi: indeed... makes it pass here too with the wait17:04
mzanettihuh... this seems a bit strange indeed17:05
mzanettiaren't those objects destroyed all the time?17:05
mzanettiI wonder how this works at all17:06
mzanettiah... because card changes17:06
Cimimzanetti, they are defined in the UnityTestCase...17:06
Cimicard changes maybe too late17:06
Cimiand the binding is still working17:06
Cimiwith previous card17:06
mzanettiCimi: yeah, I guess you want an init() here that somehow makes sure everything is updated17:07
mzanettiCimi: maybe something like tryCompareFunction( testcase.title != null|undefined )17:08
mzanettihmm... no its not17:08
mzanettiwell, you'll figure something :)17:08
Cimimzanetti, yeah... tomorrow :)17:08
Cimigym time17:08
CimiI'll be back later to review mterry branch anyway17:09
dandraderSaviq, Mirv do you know what I'm doing wrong? http://paste.ubuntu.com/8107713/ how do I target lp:ubuntu/utopic-proposed/qtdeclarative-opensource-src ?17:10
Saviqdandrader, try utopic, not utopic-proposed17:12
dandraderSaviq, btw, do you know if I should target lp:ubuntu/qtdeclarative-opensource-src or lp:ubuntu/utopic-proposed/qtdeclarative-opensource-src ?17:13
Saviqdandrader, what you *should* target is https://code.launchpad.net/~kubuntu-packagers/kubuntu-packaging/qtdeclarative-opensource-src17:14
Saviqdandrader, only the packaging branch, not the auto-import17:14
Saviqdandrader, those are packaging-only branches, they don't carry source17:15
dandraderSaviq, and what's that then? https://code.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src17:16
Saviqdandrader, every time a package is uploaded into ubuntu17:16
Saviqdandrader, the changes get pushed there as a commit17:16
dandraderSaviq, "This page is for a packaging branch for a program in Ubuntu. Changes should be made here to Ubuntu packaging or for changes specific to Ubuntu's needs. Changes to the program in general should be made on the upstream branch"17:16
dandradersounds like what I want...17:16
Saviqdandrader, indeed :)17:16
Saviqdandrader, but in this case, because there *is* a packaging branch17:17
Saviqdandrader, you should target that17:17
Saviqdandrader, truth be told I don't think the /ubuntu/ branches are used for anything else than tracking changes in the packages that go into distro17:18
Saviqthey might have been before, but not these days17:18
=== alan_g is now known as alan_g|EOD
Mirvdandrader: just a quick note that Saviq is right, offer an additional patch against kubuntu-packaging debian/ only branch. but first please do git clone ssh://danieldandrada@codereview.qt-project.org:29418/qt/qtdeclarative.git and propose it to upstream (instructions in wiki) so that we don't change in a thing like touch handling from upstream17:30
Mirv(I checked that you've an account for pushing MP:s to Qt)17:31
dandraderMirv, so I should propose upstream *before*  proposiing the ubuntu packaging patch?17:32
Mirvdandrader: yes, always. in case of urgencies we may not necessarily wait for it to be accepted but the normal procedure would be to wait that upstrem accepts it and then cherry-pick it from there.17:34
Mirvbut since proposing is ~easy, it's nicer to git fetch "proposed upstream patch" at least from the upstream tracker17:35
Mirvplus we don't make other Qt 5 users in derivatives raise eyebrows in non-upstream patches appearing, now that KDE5 is full steam also17:36
=== dandrader is now known as dandrader|afk
ajalkaneCan anyone give me some indicators where to start off with fixing this bug: https://bugs.launchpad.net/hud/+bug/1165420 (Unable to access indicators from HUD)19:05
ubot5Ubuntu bug 1165420 in hud (Ubuntu) "Unable to access indicators from HUD" [High,Confirmed]19:05
ajalkaneIt's driving me crazy19:05
=== dandrader_ is now known as dandrader
mterryCimi, try the location branch now, I read the file directly and present in a Label20:15
mterryCimi, much nicer, I just didn't know it was relatively easy to load a file in Qml20:15
Cimimterry, can you remove the quote in bug reports?20:53
mterryCimi, the bit about location?20:54
Cimifor location20:54
mterryCimi, sure.  I've asked design what we should do, they are considering combining the two pages.  but until then, removing the excess line is fine20:55
mterryCimi, done20:55
Cimimterry, excellent thx20:56
Cimimterry, I would combine the two pages20:56
Cimiyeah not now :)20:56
CimiI think it makes sense20:56
Cimimterry, the stuck is messed up20:58
mterryCimi, stuck?20:58
Cimimterry, stack20:59
mterryCimi, how do you mean?20:59
Cimimterry, to reproduce20:59
Cimimterry, check "t & c"20:59
Cimimterry, tap on link to read them20:59
Cimimterry, even try the webview21:00
Cimimterry, now go back21:00
Cimimterry, continue21:00
Cimimterry, here goes back to wifi21:00
Cimimterry, or other combinations...21:01
mterryCimi, works for me..21:02
Cimidunno then...21:02
mterryCimi, you updated all the changed files from the branch update?21:03
Cimimterry, I can approve but we need another eye21:04
Cimimterry, definitely not working for me21:05
Cimimterry, do you have a sim card?21:05
mterryCimi, :(21:05
mterryCimi, no21:05
CimiI also have that page in the stack21:05
Cimiah ok21:05
Cimiso we are same situation21:05
CimiI will try recording21:06
Cimimterry, we should print the stack... but I cannot now21:17
Cimimterry, https://drive.google.com/file/d/0BzO8ZDfBk9UKaWI0MWFLaG52TUk/edit?usp=sharing21:18
dandraderMirv, so I should propose upstream *before*  proposiing the ubuntu packaging patch?21:30
dandrader^^^^ weird. I accidentally resent a previous message. ignore it21:34
=== shiznix_ is now known as shiznix

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!