| huwshimi | rick_h__, hatch: Changes are up! https://github.com/juju/juju-gui/pull/498 | 00:12 |
|---|---|---|
| rick_h__ | huwshimi: you split on -, but the template doesn't have a - in the class? | 00:21 |
| rick_h__ | huwshimi: commented to be more clear | 00:22 |
| huwshimi | rick_h__: The class gets prebuilt in the render step: https://github.com/juju/juju-gui/pull/498/files#diff-9dcc1a3a6fc72b434afc0c7c14ec9556R108 | 00:23 |
| huwshimi | rick_h__: So you end up with classes such as moreMenuItem-0, moreMenuItem-1 etc. | 00:24 |
| rick_h__ | huwshimi: ah, gotcha | 00:24 |
| rick_h__ | huwshimi: cool, missed it thanks | 00:24 |
| huwshimi | np | 00:24 |
| rick_h__ | huwshimi: comment on a test but looks good apart from that | 00:24 |
| huwshimi | rick_h__: Great, I'll take a look | 00:24 |
| rick_h__ | huwshimi: thanks for the updates! | 00:25 |
| huwshimi | rick_h__: No problems! | 00:25 |
| huwshimi | rick_h__: Like this? https://github.com/huwshimi/juju-gui/commit/f252894d6ce4c2763444f7ae4242b8e1a32380e0 | 00:29 |
| huwshimi | rick_h__: I have to duck out for a minute to do my tax, but if that last change is all good is it time for a rebase and a shipit? | 00:38 |
| hatch | huwshimi: I'm back, did you need any reviews or anything? | 01:42 |
| huwshimi | hatch: You could do a final check over the changes I made this morning ( the callback stuff) | 01:53 |
| hatch | sure I'm just doing homework now heh | 01:54 |
| huwshimi | :) | 01:56 |
| hatch | huwshimi: one comment | 01:57 |
| hatch | I was going to comment on some of the label stuff as a joke but I thought you might throw your computer across the room | 01:57 |
| hatch | :P | 01:57 |
| huwshimi | hatch: I would have gone over to your house | 02:05 |
| huwshimi | hatch: shipit? | 02:07 |
| hatch | yup | 02:08 |
| huwshimi | yay! | 02:08 |
| hatch | haha | 02:11 |
| huwshimi | Merged! | 02:55 |
| rick_h__ | luca: <3 nice round of bugs thanks | 11:16 |
| luca | rick_h__: hehe no problem. | 11:24 |
| * frankban lunches | 12:31 | |
| === uru_ is now known as urulama | ||
| hatch | mornin all | 13:48 |
| rick_h__ | sssshhhhhh hatch :P | 13:49 |
| hatch | oh did I break the silence? | 13:49 |
| hatch | well serves ya'll right!!!! Should be all millin about n'such | 13:49 |
| hatch | luca: you were busy :) | 14:03 |
| hatch | good bug reports | 14:03 |
| luca | hehe, morning hatch | 14:03 |
| hatch | the inspector health bar was interesting | 14:07 |
| hatch | I'm not sure where that went | 14:07 |
| luca | hatch: lol | 14:07 |
| hatch | I created a card, it must be a styling issue | 14:07 |
| luca | hatch: nice | 14:07 |
| * hatch starts countdown until kadams54 timesout | 14:12 | |
| kadams54 | I'm actually at a friend's house today :-) | 14:12 |
| jrwren_ | I just loled at 'bad wolf' in the quickstart tests. | 14:20 |
| jcsackett | jrwren_: "bad wolf" is all over. | 14:24 |
| jcsackett | as it should be. :p | 14:25 |
| jrwren_ | this scares me. | 14:25 |
| hatch | I feel left out, I've never understood "Bad wolf" | 14:25 |
| jrwren_ | hatch: its a Doctor Who thing. | 14:25 |
| jrwren_ | hatch: its really very silly. | 14:26 |
| hatch | Ohh I've never watched enough DW to really catch the jokes | 14:26 |
| hatch | I've been meaning to | 14:26 |
| hatch | buuuuut such is life | 14:26 |
| jrwren_ | hatch: Its television. | 14:27 |
| urulama | hatch: yes, you have to exterminate all free time. | 14:28 |
| urulama | (doing it Dalek voice) | 14:28 |
| hatch | my problem with tv is that I now have sports and activities for all kinds of weather, and hacking for times when I am feeling lazy....sooooo yeah | 14:28 |
| hatch | lol | 14:28 |
| jrwren_ | that does not sound like a problem with tv... a solution maybe. | 14:32 |
| hatch | haha true | 14:35 |
| hatch | but I still pay that damn $60/mo for basic cable | 14:35 |
| hatch | because wasting money is fun! | 14:36 |
| jrwren_ | So cancel? | 14:43 |
| kadams54 | That's the great myth about cutting the cord… | 14:46 |
| kadams54 | Who needs TV? We've got Netflix! Except Netflix comes via cable… | 14:46 |
| hatch | yeah we could save about $50 but cutting out cable but there is always the one show... | 14:48 |
| hatch | I just wish I could buy them online for a reasonable price | 14:48 |
| hatch | some are available on itunes and some are available on streaming from the proviers....but neither of those are very attractive when it costs you 50% of the monthly fee for one show | 14:51 |
| frankban | guihelp: I need two reviews for https://github.com/juju/charmstore/pull/79 (charmstore/golang). Anyone? thanks! | 14:51 |
| hatch | I'll review it but my review probably counts as a -1 :) I should really get more involved in that side | 14:52 |
| frankban | hatch: appreciated | 14:53 |
| frankban | urulama, jrwren_ ^^ | 14:53 |
| urulama | frankban: looking | 14:54 |
| urulama | frankban: but i'll probably finish in the evening | 14:54 |
| hatch | I have to say I am not a fan of the no-line-limit in golang scripts | 14:54 |
| frankban | hatch: +1 | 14:55 |
| frankban | hatch: but when in Rome... | 14:55 |
| hatch | ...visit the Panthenon? | 14:55 |
| hatch | :P | 14:55 |
| jrwren_ | no-line-limit? | 14:55 |
| hatch | jrwren_: yeah like requiring a newline at 80char or 120char | 14:56 |
| jrwren_ | I follow 79 columns in any language in which I write. | 14:56 |
| jrwren_ | hatch: I'm not a fan either. | 14:56 |
| jrwren_ | sometimes gofmt makes it difficult to wrap where I want :( | 14:56 |
| frankban | hatch: :-) | 14:56 |
| hatch | yeah gofmt makes my code look like garbage lol, I'm THAT guy who disagrees with gofmt :D | 14:57 |
| rick_h__ | hatch: +1 | 14:57 |
| jrwren_ | I feel you just have to learn to get along with go fmt | 14:57 |
| hatch | jrwren_: well, with any linter really :) | 14:57 |
| hatch | gofmt is just.....well..... | 14:58 |
| Makyo | jujugui call in 2 | 14:58 |
| frankban | hatch: it's still better than our js linter IMHO | 14:58 |
| hatch | frankban: haha, well as long as you stay away from chaining it's ok | 14:58 |
| frankban | hatch: I only hate column indentation in structs, which makes me also unhappy when reviewing code | 14:59 |
| hatch | ohh I like that :) | 14:59 |
| rick_h__ | antdillon: jcsackett standup | 15:00 |
| jcsackett | already on. :p | 15:00 |
| jcsackett | was on before you were, dude. :p | 15:00 |
| bac | sorry rick_h__ i missed all of the license management discussion | 15:13 |
| hatch | https://www.youtube.com/watch?v=kfVsfOSbJY0 | 15:16 |
| hatch | w00t http://ariya.ofilabs.com/2014/08/phantomjs-2-and-javascript-goodies.html | 15:17 |
| hatch | mobile in Belgum http://www.belgacom.be/en/id_t_px_max/personal/products-and-services/proximus-telephony/paygo-max.html?tabnav=1 | 15:29 |
| urulama | hatch: wth! my ears! | 15:30 |
| urulama | hatch: add WARNING to such links, please :) | 15:30 |
| rick_h__ | bac: let me know if you get a good connection and want the low-down | 15:31 |
| rick_h__ | bac: basically: make sure any new 3rd party libs have a license, look for those during reviews where someone adds a 3rd party dep | 15:31 |
| hatch | urulama: hahaha that's rick_h__'s friday theme song | 15:31 |
| bac | rick_h__: yeah, i figured that would be the outcome. thanks. | 15:32 |
| rick_h__ | what is my friday theme song? | 15:32 |
| hatch | see the youtube link | 15:32 |
| rick_h__ | wtf, how did you get to this from me? | 15:33 |
| rick_h__ | or anything I said | 15:33 |
| jrwren_ | I prefer the starcraft 2 spoof. | 15:33 |
| rick_h__ | OMG this is awful | 15:34 |
| rick_h__ | maybe that's the comparison you were looking for | 15:34 |
| hatch | I vote that you find a wig and a convertible | 15:34 |
| bac | hatch: wow the belgian pay/go is uncheap | 15:34 |
| jrwren_ | rick_h__: https://www.youtube.com/watch?v=jzq2O54LLIw much better. | 15:34 |
| hatch | bac only marginally more than three I think | 15:34 |
| hatch | in the uk | 15:34 |
| rick_h__ | hatch: unlimited data on three though | 15:35 |
| bac | hatch: but with three you got unlimited data. is there a plan on that site i missed? | 15:35 |
| bac | yeah, what rick_h__ siad | 15:35 |
| bac | s/siad/said/ | 15:36 |
| hatch | jrwren_: hahahaha this is awesome | 15:36 |
| jrwren_ | hatch: you follow sc2? | 15:36 |
| hatch | jrwren_: I used to be into it but it's been a while | 15:37 |
| hatch | after a while I hit my skill limit and would just get owned in every match | 15:37 |
| jrwren_ | hatch: big even in Detroit this weekend. I have tix. I'm going this evening :) | 15:37 |
| hatch | so I kind of lost interest | 15:37 |
| hatch | oh cool :) | 15:37 |
| hatch | jrwren_: I've always thought the APM's were a little ridiculous, you don't need to click every damn tile on the way to where you want it to go just to get your APM up :) | 15:40 |
| jrwren_ | hatch: I never bothered with that. I've been told its a means of practice so that you can micro at those speeds when needed. | 15:41 |
| hatch | also a means to carpel tunnel | 15:41 |
| hatch | lol | 15:41 |
| === urulama is now known as uru-afk | ||
| jrwren_ | frankban: updated https://code.launchpad.net/~evarlast/juju-quickstart/which-juju/+merge/227238 and https://codereview.appspot.com/132770043 | 16:47 |
| * rick_h__ runs for lunch | 16:49 | |
| kadams54 | We've got a CI build that's been running for 16 hours… http://ci.jujugui.org:8080/job/juju-gui/1668/ | 16:57 |
| hatch | heh nice | 16:57 |
| hatch | kill it | 16:57 |
| kadams54 | I can kill it, but I suspect subsequent builds will fail | 16:57 |
| kadams54 | And they are | 16:58 |
| kadams54 | There's a hung thread that's hanging onto a port | 16:58 |
| hatch | say what? | 16:59 |
| kadams54 | strike that… the last two failures seem to be legit | 16:59 |
| hatch | :) | 16:59 |
| hatch | that's not to say it WONT break heh | 16:59 |
| kadams54 | We'll see… if this build makes it to the selenium tests, I bet it fails. | 16:59 |
| kadams54 | Same thing happened to me earlier in the week and Rick had to kick something on the server. | 17:00 |
| hatch | yeah it doesn't kill the pending server | 17:01 |
| hatch | yup | 17:01 |
| hatch | addrinuse | 17:01 |
| hatch | rick_h__: can you kill the server in ci? | 17:01 |
| hatch | kadams54: you might as well kill all the runs | 17:01 |
| rick_h__ | hatch: sure thing | 17:04 |
| hatch | rick_h__: before you run away could you put instructions on what to do in this case? | 17:05 |
| hatch | I'll set up my machine for it, I just don't want to end up with CI down for a week heh | 17:05 |
| rick_h__ | hatch: killed | 17:05 |
| hatch | thanks ^ kadams54 | 17:06 |
| rick_h__ | who has ssh on there, jcsackett ? | 17:06 |
| rick_h__ | bac: but he's out next week as well I think | 17:06 |
| rick_h__ | oh, bac is around yay | 17:06 |
| hatch | rick_h__: I thought the keys were in the wiki? | 17:06 |
| rick_h__ | hatch: not the ssh keys, those have to be added | 17:07 |
| rick_h__ | bac: and jcsackett I think can add keys and ssh in | 17:07 |
| hatch | oh ok sounds good | 17:07 |
| rick_h__ | but all I do is 'ssh ubuntu@ci.jujugui.org' and then run 'ps' and look for the server and 'sudo kill XXXXX' | 17:07 |
| hatch | oh ok simple enough thanks | 17:08 |
| hatch | jcsackett: hey are you around? | 17:35 |
| frankban | jrwren_: reviewed | 17:38 |
| frankban | done for the day, have a great weekend all! | 17:38 |
| rick_h__ | have fun frankban | 17:38 |
| jrwren_ | frankban: thanks. Have a great weekend. | 17:38 |
| rick_h__ | ok, I'm out jujugui, have a good time and catch you all later | 17:46 |
| kadams54 | Have a good time rick_h__! | 17:46 |
| hatch | cya rick_h__ enjoy your holiday | 17:52 |
| jcsackett | hatch: i am around now. | 18:18 |
| jcsackett | hatch: have been for a bit, actually, but i am bad about checking for hilights when i get back from lunch. :p | 18:19 |
| hatch | jcsackett: hey sorry | 18:36 |
| hatch | the area I'm working on will likely conflict with the stuff you are doing | 18:36 |
| hatch | do you have anything I can look at yet? | 18:36 |
| hatch | if not no problem I'll just bench what I have until yours lands | 18:50 |
| jcsackett | hatch: what are you poking at? | 19:10 |
| jcsackett | i can push up one thing, and then the only other thing to beware of is not touching _onUnitChange in machine view panel. | 19:11 |
| jcsackett | i *think* | 19:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!