[00:12] rick_h__, hatch: Changes are up! https://github.com/juju/juju-gui/pull/498 [00:21] huwshimi: you split on -, but the template doesn't have a - in the class? [00:22] huwshimi: commented to be more clear [00:23] rick_h__: The class gets prebuilt in the render step: https://github.com/juju/juju-gui/pull/498/files#diff-9dcc1a3a6fc72b434afc0c7c14ec9556R108 [00:24] rick_h__: So you end up with classes such as moreMenuItem-0, moreMenuItem-1 etc. [00:24] huwshimi: ah, gotcha [00:24] huwshimi: cool, missed it thanks [00:24] np [00:24] huwshimi: comment on a test but looks good apart from that [00:24] rick_h__: Great, I'll take a look [00:25] huwshimi: thanks for the updates! [00:25] rick_h__: No problems! [00:29] rick_h__: Like this? https://github.com/huwshimi/juju-gui/commit/f252894d6ce4c2763444f7ae4242b8e1a32380e0 [00:38] rick_h__: I have to duck out for a minute to do my tax, but if that last change is all good is it time for a rebase and a shipit? [01:42] huwshimi: I'm back, did you need any reviews or anything? [01:53] hatch: You could do a final check over the changes I made this morning ( the callback stuff) [01:54] sure I'm just doing homework now heh [01:56] :) [01:57] huwshimi: one comment [01:57] I was going to comment on some of the label stuff as a joke but I thought you might throw your computer across the room [01:57] :P [02:05] hatch: I would have gone over to your house [02:07] hatch: shipit? [02:08] yup [02:08] yay! [02:11] haha [02:55] Merged! [11:16] luca: <3 nice round of bugs thanks [11:24] rick_h__: hehe no problem. [12:31] * frankban lunches === uru_ is now known as urulama [13:48] mornin all [13:49] sssshhhhhh hatch :P [13:49] oh did I break the silence? [13:49] well serves ya'll right!!!! Should be all millin about n'such [14:03] luca: you were busy :) [14:03] good bug reports [14:03] hehe, morning hatch [14:07] the inspector health bar was interesting [14:07] I'm not sure where that went [14:07] hatch: lol [14:07] I created a card, it must be a styling issue [14:07] hatch: nice [14:12] * hatch starts countdown until kadams54 timesout [14:12] I'm actually at a friend's house today :-) [14:20] I just loled at 'bad wolf' in the quickstart tests. [14:24] jrwren_: "bad wolf" is all over. [14:25] as it should be. :p [14:25] this scares me. [14:25] I feel left out, I've never understood "Bad wolf" [14:25] hatch: its a Doctor Who thing. [14:26] hatch: its really very silly. [14:26] Ohh I've never watched enough DW to really catch the jokes [14:26] I've been meaning to [14:26] buuuuut such is life [14:27] hatch: Its television. [14:28] hatch: yes, you have to exterminate all free time. [14:28] (doing it Dalek voice) [14:28] my problem with tv is that I now have sports and activities for all kinds of weather, and hacking for times when I am feeling lazy....sooooo yeah [14:28] lol [14:32] that does not sound like a problem with tv... a solution maybe. [14:35] haha true [14:35] but I still pay that damn $60/mo for basic cable [14:36] because wasting money is fun! [14:43] So cancel? [14:46] That's the great myth about cutting the cord… [14:46] Who needs TV? We've got Netflix! Except Netflix comes via cable… [14:48] yeah we could save about $50 but cutting out cable but there is always the one show... [14:48] I just wish I could buy them online for a reasonable price [14:51] some are available on itunes and some are available on streaming from the proviers....but neither of those are very attractive when it costs you 50% of the monthly fee for one show [14:51] guihelp: I need two reviews for https://github.com/juju/charmstore/pull/79 (charmstore/golang). Anyone? thanks! [14:52] I'll review it but my review probably counts as a -1 :) I should really get more involved in that side [14:53] hatch: appreciated [14:53] urulama, jrwren_ ^^ [14:54] frankban: looking [14:54] frankban: but i'll probably finish in the evening [14:54] I have to say I am not a fan of the no-line-limit in golang scripts [14:55] hatch: +1 [14:55] hatch: but when in Rome... [14:55] ...visit the Panthenon? [14:55] :P [14:55] no-line-limit? [14:56] jrwren_: yeah like requiring a newline at 80char or 120char [14:56] I follow 79 columns in any language in which I write. [14:56] hatch: I'm not a fan either. [14:56] sometimes gofmt makes it difficult to wrap where I want :( [14:56] hatch: :-) [14:57] yeah gofmt makes my code look like garbage lol, I'm THAT guy who disagrees with gofmt :D [14:57] hatch: +1 [14:57] I feel you just have to learn to get along with go fmt [14:57] jrwren_: well, with any linter really :) [14:58] gofmt is just.....well..... [14:58] jujugui call in 2 [14:58] hatch: it's still better than our js linter IMHO [14:58] frankban: haha, well as long as you stay away from chaining it's ok [14:59] hatch: I only hate column indentation in structs, which makes me also unhappy when reviewing code [14:59] ohh I like that :) [15:00] antdillon: jcsackett standup [15:00] already on. :p [15:00] was on before you were, dude. :p [15:13] sorry rick_h__ i missed all of the license management discussion [15:16] https://www.youtube.com/watch?v=kfVsfOSbJY0 [15:17] w00t http://ariya.ofilabs.com/2014/08/phantomjs-2-and-javascript-goodies.html [15:29] mobile in Belgum http://www.belgacom.be/en/id_t_px_max/personal/products-and-services/proximus-telephony/paygo-max.html?tabnav=1 [15:30] hatch: wth! my ears! [15:30] hatch: add WARNING to such links, please :) [15:31] bac: let me know if you get a good connection and want the low-down [15:31] bac: basically: make sure any new 3rd party libs have a license, look for those during reviews where someone adds a 3rd party dep [15:31] urulama: hahaha that's rick_h__'s friday theme song [15:32] rick_h__: yeah, i figured that would be the outcome. thanks. [15:32] what is my friday theme song? [15:32] see the youtube link [15:33] wtf, how did you get to this from me? [15:33] or anything I said [15:33] I prefer the starcraft 2 spoof. [15:34] OMG this is awful [15:34] maybe that's the comparison you were looking for [15:34] I vote that you find a wig and a convertible [15:34] hatch: wow the belgian pay/go is uncheap [15:34] rick_h__: https://www.youtube.com/watch?v=jzq2O54LLIw much better. [15:34] bac only marginally more than three I think [15:34] in the uk [15:35] hatch: unlimited data on three though [15:35] hatch: but with three you got unlimited data. is there a plan on that site i missed? [15:35] yeah, what rick_h__ siad [15:36] s/siad/said/ [15:36] jrwren_: hahahaha this is awesome [15:36] hatch: you follow sc2? [15:37] jrwren_: I used to be into it but it's been a while [15:37] after a while I hit my skill limit and would just get owned in every match [15:37] hatch: big even in Detroit this weekend. I have tix. I'm going this evening :) [15:37] so I kind of lost interest [15:37] oh cool :) [15:40] jrwren_: I've always thought the APM's were a little ridiculous, you don't need to click every damn tile on the way to where you want it to go just to get your APM up :) [15:41] hatch: I never bothered with that. I've been told its a means of practice so that you can micro at those speeds when needed. [15:41] also a means to carpel tunnel [15:41] lol === urulama is now known as uru-afk [16:47] frankban: updated https://code.launchpad.net/~evarlast/juju-quickstart/which-juju/+merge/227238 and https://codereview.appspot.com/132770043 [16:49] * rick_h__ runs for lunch [16:57] We've got a CI build that's been running for 16 hours… http://ci.jujugui.org:8080/job/juju-gui/1668/ [16:57] heh nice [16:57] kill it [16:57] I can kill it, but I suspect subsequent builds will fail [16:58] And they are [16:58] There's a hung thread that's hanging onto a port [16:59] say what? [16:59] strike that… the last two failures seem to be legit [16:59] :) [16:59] that's not to say it WONT break heh [16:59] We'll see… if this build makes it to the selenium tests, I bet it fails. [17:00] Same thing happened to me earlier in the week and Rick had to kick something on the server. [17:01] yeah it doesn't kill the pending server [17:01] yup [17:01] addrinuse [17:01] rick_h__: can you kill the server in ci? [17:01] kadams54: you might as well kill all the runs [17:04] hatch: sure thing [17:05] rick_h__: before you run away could you put instructions on what to do in this case? [17:05] I'll set up my machine for it, I just don't want to end up with CI down for a week heh [17:05] hatch: killed [17:06] thanks ^ kadams54 [17:06] who has ssh on there, jcsackett ? [17:06] bac: but he's out next week as well I think [17:06] oh, bac is around yay [17:06] rick_h__: I thought the keys were in the wiki? [17:07] hatch: not the ssh keys, those have to be added [17:07] bac: and jcsackett I think can add keys and ssh in [17:07] oh ok sounds good [17:07] but all I do is 'ssh ubuntu@ci.jujugui.org' and then run 'ps' and look for the server and 'sudo kill XXXXX' [17:08] oh ok simple enough thanks [17:35] jcsackett: hey are you around? [17:38] jrwren_: reviewed [17:38] done for the day, have a great weekend all! [17:38] have fun frankban [17:38] frankban: thanks. Have a great weekend. [17:46] ok, I'm out jujugui, have a good time and catch you all later [17:46] Have a good time rick_h__! [17:52] cya rick_h__ enjoy your holiday [18:18] hatch: i am around now. [18:19] hatch: have been for a bit, actually, but i am bad about checking for hilights when i get back from lunch. :p [18:36] jcsackett: hey sorry [18:36] the area I'm working on will likely conflict with the stuff you are doing [18:36] do you have anything I can look at yet? [18:50] if not no problem I'll just bench what I have until yours lands [19:10] hatch: what are you poking at? [19:11] i can push up one thing, and then the only other thing to beware of is not touching _onUnitChange in machine view panel. [19:11] i *think*