| === uru-afk is now known as urulama | ||
| urulama | morning, frankban | 08:52 |
|---|---|---|
| frankban | hi urulama | 08:52 |
| urulama | regarding my comment on support for start/end in /meta/stats, i guess i mixed it with /stats/counter | 08:53 |
| urulama | https://docs.google.com/a/canonical.com/document/d/1TgRA7jW_mmXoKH3JiwBbtPvQu7WiM6XMrz1wSrhTMXw/edit#bookmark=id.9k72szsuel9z | 08:53 |
| urulama | which is probably the endpoint for the results for web (charm broswer), like downlaods in the last 7 days, 30 days, half year, all time ... | 08:54 |
| frankban | urulama: yeah, so the stats counter already works for some of that | 09:02 |
| urulama | frankban: yes, great side-effect :) | 09:06 |
| frankban | urulama: do we really want to allow deletion of partial ids? | 11:48 |
| urulama | frankban: deletion? | 11:48 |
| frankban | urulama: yes, DELETE archive | 11:48 |
| frankban | This deletes the given charm or bundle with the given id. If the id does not mention a specific series or revision, all the series and revisions of the given id are deleted. | 11:49 |
| urulama | frankban: good point. | 11:49 |
| urulama | frankban: it does make sense from the API point of view. But maybe it is best to delete only concrete api and request a user to do /expand-id and iterate on all | 11:50 |
| urulama | s/concrete api/concrete charm | 11:51 |
| urulama | frankban: maybe we could do two phase process. delete on charm id just removes a charm from being available, but not from the store. and one needs to "confirm" later to remove all "deleted" charms from the store permanently? | 11:52 |
| frankban | urulama: +1 | 11:52 |
| frankban | urulama: uhm, I'd be not inclined to add state to the server. | 11:54 |
| frankban | urulama: +1 on having to specify a fully qualified url, but I'd be -1 on the two steps process: it complicates the server and also the client | 11:55 |
| urulama | frankban: ok. then let's just do fully qualified url part (gonna change the docs) | 11:55 |
| frankban | urulama: thank you | 11:55 |
| urulama | frankban: working on DEL part of archive? | 12:15 |
| frankban | urulama: yes | 12:17 |
| frankban | urulama: creating a card | 12:17 |
| urulama | frankban: tnx | 12:23 |
| * urulama cooks lunch | 12:31 | |
| bac | jujugui: the internet man is on his way. i may be going on and off line a bit in the next hour as he attempts to fix the problem. | 12:58 |
| urulama | bac: good luck | 13:08 |
| urulama | bac: i found out yesterday, that 100/10 line here costs only 5eur more then my current 10/10 ... will go upgrade soon | 13:09 |
| urulama | (per month) | 13:09 |
| jrwren_ | frankban: updated https://code.launchpad.net/~evarlast/juju-quickstart/which-juju/+merge/227238 and https://codereview.appspot.com/132770043 | 13:42 |
| frankban | jrwren_: cool | 13:42 |
| frankban | jrwren_: why there is no Delta from patch set in reitveld? | 13:43 |
| frankban | jrwren_: how do you update the mp on reitveld? | 13:43 |
| * jrwren_ looks. | 13:43 | |
| jrwren_ | frankban: lbox propse | 13:43 |
| frankban | jrwren_: uhm, that's what we are supposed to do, weird... | 13:43 |
| frankban | jrwren_: ok, I'll take a look ASAP | 13:44 |
| hatch | morning all | 13:47 |
| jrwren_ | morning hatch and all | 13:47 |
| hatch | jrwren_: so I watched some of those starcraft games this weekend, those guys are a little nuts | 13:47 |
| hatch | haha | 13:47 |
| hatch | I'd probably die in their scouting runs :P | 13:48 |
| jrwren_ | hatch: you watched live stream? did you see me in the crowd? :) | 13:48 |
| hatch | I did, but no I didn't see you, the crowd was really dark and the feed was actually quite poor quality | 13:48 |
| jrwren_ | hatch: Awesome. I hope you enjoyed it. It was very fun to be there live. | 13:49 |
| hatch | yeah I bet, I couldn't stop laughing at the start "aww they think they are real sports people" | 13:49 |
| hatch | lol | 13:49 |
| jrwren_ | hatch: They have higher revenue than the NHL. | 13:50 |
| hatch | well, maybe the league but not the players :) | 13:50 |
| jrwren_ | hatch: truth! | 13:50 |
| hatch | watching some talk was like bringing be back to highschool haha | 13:50 |
| jrwren_ | hatch: how so? | 13:51 |
| hatch | oh, well they were like 17 | 13:51 |
| hatch | so they talked like they were 17 haha | 13:51 |
| hatch | no doubt about the skills though | 13:51 |
| jrwren_ | hatch: ha! Yes. A lot of the players are very young. | 13:51 |
| hatch | It seems to be a very balanced game, even if one screwed up earlier in the game that wasn't a sure thing that they were going to lose | 13:52 |
| hatch | it was possible to come back sometimes | 13:52 |
| hatch | and the best-of-three was a good idea | 13:52 |
| jrwren_ | yup. | 13:54 |
| hatch | they need to have an old-person league | 13:55 |
| hatch | haha | 13:55 |
| hatch | or maybe a minimum salary so that old people with families can compete :D | 13:56 |
| hatch | kids don't have any money, if they want to get real money intot he sport they need adult competitors :) | 13:56 |
| urulama | frankban: i'll take a look at the PR right after the call | 13:59 |
| frankban | urulama: cool, I am updating it with another test | 13:59 |
| frankban | urulama, jrwren_ : https://github.com/juju/charmstore/pull/80 is now ready for review | 14:03 |
| jrwren_ | hatch: I am pretty sure they know what they are doing, but I do wish for an old person league so I can play ;) | 14:03 |
| hatch | jcsackett: you in yet? Can you kick ci and then kill the node server? | 14:11 |
| jcsackett | hatch: as in restart the jenkins service? | 14:11 |
| jcsackett | sure. | 14:11 |
| jcsackett | hatch: though i know nothing of a node server. | 14:12 |
| hatch | jcsackett: when you kill the running tests in CI you then need to ssh into the machine and do a ps for the node server | 14:14 |
| hatch | kill it | 14:14 |
| hatch | then the tests will run again | 14:14 |
| hatch | if you don't it'll just give an ERRADDRINUSE error | 14:14 |
| jcsackett | hatch: it would appear restarting the jenkins process handles that; as there's no node in ps output. | 14:15 |
| hatch | oh interesting | 14:15 |
| jcsackett | hatch: i'm starting a build manually to make sure things can pass (or fail for the right reasons) | 14:16 |
| hatch | I triggered another build of huws branch | 14:16 |
| hatch | oh hahah | 14:16 |
| jcsackett | nm, i see your build. :0 | 14:16 |
| * hatch is speedy this am | 14:16 | |
| hatch | it must have been kiting yesterday - 9C 35KM winds and pooooooouuuring rain | 14:17 |
| hatch | set up was bruuuuuuutal | 14:17 |
| jcsackett | ...that's interesting, your build died almost instantly, hatch. i've started another--i think it might have been a bad sha. | 14:18 |
| hatch | ohh maybe | 14:19 |
| jcsackett | hrm. | 14:19 |
| jcsackett | and this one died another way. fun. | 14:19 |
| hatch | jcsackett: looks like npm issues | 14:19 |
| hatch | to the twitters!!!! | 14:20 |
| jcsackett | yup. | 14:20 |
| hatch | hmm no reports of it being down | 14:21 |
| jcsackett | i suspect it's a problem with CI. | 14:27 |
| jcsackett | largely b/c i don't like jenkins. | 14:27 |
| jcsackett | or, more correctly, largely b/c jenkins doesn't like me. :p | 14:29 |
| hatch | lol is it REALLY jenkins fault? Or is it that Jenkins is so magical you have no idea what broke? :) | 14:29 |
| jcsackett | jenkins isn't really magical; it's just awkward. | 14:29 |
| jcsackett | but it's so awkward i have no idea what's broken. | 14:29 |
| hatch | haha true | 14:31 |
| hatch | jrwren_: highschool doesn't start at 8:30 there? | 14:31 |
| rick_h_ | morning party people | 14:32 |
| jrwren_ | hatch: quite often 7:30ish | 14:32 |
| hatch | mornin mr vacation man | 14:32 |
| hatch | jrwren_: that's just nuts! elementary is 9 and hs is 8:30 here | 14:33 |
| urulama | rick_h_: :) how's it going? | 14:33 |
| jrwren_ | hatch: Canada is better than the US in almost every aspect. | 14:33 |
| hatch | haha, well education is handled at the provincial level......buuuuut I'll take it!!! | 14:33 |
| rick_h_ | hatch: howdy, want to do me a favor? I didn't get the luca bugs turned to cards before I left | 14:34 |
| rick_h_ | hatch: can you create those, with gui class of service, etc today please? | 14:34 |
| hatch | rick_h_: sure | 14:34 |
| rick_h_ | hatch: ty much | 14:34 |
| hatch | now go vacate | 14:34 |
| hatch | vacation? | 14:34 |
| hatch | vacationation? | 14:34 |
| hatch | not sure what the act of vacationing is | 14:34 |
| rick_h_ | hatch: sore, very sore. | 14:34 |
| hatch | rough plane ride? | 14:34 |
| rick_h_ | the whole walk bus carry a 4yr thing is getting long | 14:34 |
| rick_h_ | naw, just putzing around SF | 14:34 |
| rick_h_ | google and the bus drivers seem to like to disagree on how to get somewhere | 14:34 |
| hatch | oh haha | 14:34 |
| hatch | yeah 4y/o are getting big | 14:35 |
| hatch | :) | 14:35 |
| rick_h_ | yea, he gets tired by the EOD makes carrying a 40# lump a bit exhausting to my own day lol | 14:35 |
| rick_h_ | but having fun, beautiful weather. Did the bay boat tour thing yesterday | 14:36 |
| hatch | oh nice - get some good pics? | 14:36 |
| rick_h_ | we'll see, took a ton. | 14:36 |
| hatch | awesome | 14:37 |
| hatch | where to today? | 14:37 |
| frankban | jrwren_: review done | 14:37 |
| jrwren_ | frankban: thanks. | 14:38 |
| rick_h_ | hatch: Cal acadamey of science, japanese tea gardens, and hoping to hit up a fishing pier down by the golden gate for some sunset pics | 14:38 |
| hatch | more walkin! | 14:39 |
| hatch | maybe you can get the kit some rollerskates :) | 14:39 |
| hatch | kid* | 14:39 |
| rick_h_ | lol | 14:39 |
| rick_h_ | hopefully he grows some strong leg muscles :P | 14:39 |
| hatch | haha that's also an option | 14:40 |
| hatch | although probably not nearly as entertaining | 14:40 |
| hatch | friends of ours are teaching their daughter how to rollerblade | 14:40 |
| hatch | holy is that funny :) of course she can't see us laugh :D | 14:41 |
| rick_h_ | there you go, he sees kids with a scooter and wants one | 14:41 |
| rick_h_ | I need to see if a store around here has one of those | 14:41 |
| hatch | oh yeah, those are STILL big | 14:41 |
| rick_h_ | then again I might end up carrying a scooter and a boy back to the apt | 14:41 |
| hatch | who would have thought... | 14:41 |
| hatch | hahaha | 14:41 |
| jcsackett | hatch: so, i ran manually via ssh, and got the npm erradinuse thing this time, but ps show's no node--is it a different process? | 14:46 |
| hatch | ^ rick_h_ CI is borked again.....wasn't it the node process that was still running? | 14:47 |
| jrwren_ | I need one more OK: https://codereview.appspot.com/132770043/ | 14:48 |
| rick_h_ | hatch: it'll either be a python or .sh process that starts the node one | 14:48 |
| hatch | jcsackett: ^ | 14:48 |
| jcsackett | dig. | 14:49 |
| jcsackett | thanks. | 14:49 |
| rick_h_ | jenkins 50559 0.0 0.1 41348 8164 ? S Aug22 0:00 python ../bin/http_server.py 8888 | 14:49 |
| rick_h_ | jcsackett: hatch often it's more clean to | grep jenkins | 14:49 |
| jcsackett | rick_h_: yeah, found it, killed it. thanks. | 14:51 |
| hatch | cool thanks | 14:53 |
| jcsackett | whoo! looks like tests might be running. i'll try restarting a build in a moment. | 14:53 |
| hatch | jujugui call in 5 kanban it up! | 14:56 |
| hatch | jcsackett: Makyo I see you guys have both interacted with this bug - I think it's resolved? https://bugs.launchpad.net/juju-gui/+bug/1340666 | 14:56 |
| mup | Bug #1340666: Clicking the destroy icon does not destroy the machine or container <juju-gui:Triaged by makyo> <https://launchpad.net/bugs/1340666> | 14:56 |
| jcsackett | hatch: no idea if it's fix released, but Makyo was definitely working on it weeks ago, and it sure seems like the trash icon deletes things on develop. | 14:57 |
| jcsackett | hatch: pretty sure its safe to mark as fix committed | 14:58 |
| hatch | thanks | 14:58 |
| hatch | jujugui call now | 14:59 |
| hatch | hey huwshimi | 15:01 |
| bac | i forgot to point out my new glasses! you are all crisper today. | 15:08 |
| jcsackett | bac: nice. :) | 15:08 |
| jcsackett | bac: are they also warby parker? | 15:09 |
| bac | hey hatch how was my audio? internet fixer came today | 15:09 |
| hatch | jujugui sorry I forgot to mention I created cards for all of lucas bugs last week so there are a lot of cards in project 1 - some can be combined, lemme know if you have any questions about them | 15:09 |
| bac | jcsackett: no, another boutique i found: costco | 15:09 |
| hatch | bac: it was actually pretty good | 15:09 |
| bac | jcsackett: they refused to use my old frames. :( | 15:09 |
| frankban | urulama: do we have a card for logging in the charmstore? | 15:09 |
| bac | jcsackett: and i had the "dr nick" of opticians do the exam. pony tail and everything. | 15:10 |
| urulama | frankban: no | 15:10 |
| frankban | urulama: ok do you want me to create one? | 15:11 |
| urulama | frankban: we discussed it a bit with Roger, as we want to log the events in such a way, that they can be easily processed, even map-reduce style | 15:11 |
| bac | hatch: they replaced the ethernet connector that plugs into the antenna. it is a) PoE and 2) exposed to the elements. they should just proactively replace them every six months. | 15:11 |
| urulama | frankban: so, there's no card for that, yet | 15:11 |
| hatch | bac: heh yeah maybe you could grab a few and do it yourself :) or pre-schedule the replacements | 15:11 |
| urulama | frankban: on what level did you mean to do it? | 15:11 |
| frankban | urulama: I am not tackling that now, but my branch includes a TODO (add logs), so I must ensure a card at least exists for logging | 15:12 |
| jcsackett | so, much as "bad wolf" has become the default error message for tests, "yelling goats" should be our new random string. | 15:12 |
| urulama | frankban: aaa, the new rules ;D | 15:12 |
| urulama | frankban: i'll put one on deck | 15:13 |
| frankban | urulama: thanks! | 15:13 |
| bac | hatch: for the price of a set of crimpers that isn't a bad idea | 15:13 |
| hatch | bac: I also wonder if they have 'weather proof' ones | 15:15 |
| hatch | like maybe putting some of that heat-shrink-wrap stuff over it | 15:15 |
| hatch | lazyPower: I upgraded the Ghost version in my charm this weekend and started looking into testing - can you remind me of what tests I'd need to get it promulgated in trusty? | 15:37 |
| kadams54 | jujugui: hey all, sorry I missed standup today. | 15:39 |
| bac | jrwren_: second review on your quickstart branch. you should be good to go now. | 15:39 |
| hatch | it's ok, you now owe us all coffee and doughnuts | 15:39 |
| hatch | :P | 15:39 |
| kadams54 | Count on it. | 15:40 |
| hatch | kadams54: :P Did you have anything to note about your branch? | 15:40 |
| kadams54 | I'll steal them from the hotel's breakfast at the next sprint. | 15:40 |
| kadams54 | ;-) | 15:40 |
| hatch | lol | 15:40 |
| jrwren_ | bac: Thank you. | 15:40 |
| kadams54 | hatch: No, not really. I spent most of my day on Friday working to get the last piece of the unplaced units work landed. | 15:41 |
| hatch | ok cool | 15:41 |
| kadams54 | hatch: Which it did. And that makes me very happy. But now it's time to forge on and get this MV stuff wrapped up :-) | 15:41 |
| hatch | kadams54: if you look at the kanban I created cards for all of luca's bugs last week, so there is a ton to choose from, some can be combined as well so if you are looking for something take a peek at the red ones :) | 15:43 |
| kadams54 | Excellent :-) | 15:44 |
| urulama | frankban: done the PR review, had some comments, but when resolved, LGTM! Tnx. | 15:50 |
| frankban | urulama: thanks | 15:50 |
| hatch | oo mongo is getting document level locking | 16:06 |
| hatch | that'll be nice | 16:06 |
| hatch | first step to transactions :) | 16:07 |
| frankban | urulama: I am thinking about your suggestion to delete the blob first and the entity after | 16:08 |
| frankban | urulama: I made it like that because from the user perspective it's better to have a 404 (no entity) rather than an entity found and then a weird error because the blob is not there | 16:09 |
| urulama | frankban: ah ... nevermind the comment, the code is correct. i somehow mixed referece=blob name, enitty=blob in my mind :) | 16:11 |
| urulama | frankban: removing the comment | 16:12 |
| frankban | urulama: thanks | 16:19 |
| urulama | jujugui: EOD for me. have a good day | 16:32 |
| frankban | good night urulama | 16:32 |
| hatch | night urulama | 16:33 |
| urulama | btw, anyone watched Guardians of the Galaxy or Lucy? can't decide which one to go to watch today (both look good for some brain-shut-down time) :D | 16:33 |
| kadams54 | urulama: Guardians, for sure. | 16:34 |
| urulama | kadams54: tnx, Guardians it is :) | 16:35 |
| hatch | urulama: heard great things about gotg, let me know :) | 16:39 |
| urulama | hatch: sure thing | 16:39 |
| urulama | A fresh advice from my friend: don't carry the kid on your shoulders when he's having an ice cream :D :D | 16:39 |
| hatch | haha | 16:41 |
| jrwren_ | What shall I do when make test runs fine for me, but lbox submit runs make test and it fails? It seems we have different source files. | 16:51 |
| hatch | jrwren_: be sure you update your local source with the remote source | 16:51 |
| hatch | that used to happen to me when the remote source and my source had diverged so the tests were no longer valid | 16:52 |
| hatch | (not sure if that's the case here) | 16:52 |
| jrwren_ | i'll bzr pull upstream then. | 16:53 |
| jrwren_ | thanks hatch | 16:57 |
| hatch | worked? | 16:57 |
| jrwren_ | yes | 16:57 |
| kadams54 | jrwren_: that's good, because my suggestion was gonna be to throw something out the window. | 17:00 |
| hatch | jrwren_: great :) glad to help | 17:00 |
| === jrwren_ is now known as jrwren | ||
| hatch | mbruzek: are you using the Ghost charm for your blog? | 17:08 |
| lazyPower | hatch: he sure is :) | 17:11 |
| hatch | awesome - ok now that people are actually using it, I'll put some more effort into it haha | 17:11 |
| hatch | lazyPower: did you see my previous q about the tests? | 17:11 |
| lazyPower | hatch: and re: your question this morning - bare minimum of unit tests, but we'd like to see amulet tests (you can choose one or the other depending on yoru skill level.) | 17:11 |
| hatch | there isn't really a ton of code, I think i'll just go for amulet tests | 17:12 |
| lazyPower | hatch: i'll ping you later this week about it, but i'm going to be moving my ghost blog from an ansible deployment to the juju charm, and document the process of how easy it was to get moving with juju to migrate a ghost blog. | 17:12 |
| hatch | tbh I'm not entirely sure how to unit test shell-outs heh | 17:12 |
| lazyPower | so expect some more heat around your charm. | 17:12 |
| lazyPower | you cant. | 17:12 |
| hatch | great (about using the charm) | 17:13 |
| lazyPower | system calls can be stubbed if you're reading response data from the call | 17:13 |
| hatch | boo (about unit testing shell-outs) | 17:13 |
| lazyPower | otherwise, you're just assuming it happened and gave a zero return code. that's about it. | 17:13 |
| hatch | yeah - the code wasn't written with testing in mind so I may have to do some refactoring | 17:13 |
| hatch | but i'll start with the amulet tests | 17:13 |
| hatch | integration tests are the most important | 17:13 |
| hatch | proving that it actually works | 17:13 |
| lazyPower | that's an excellent place to get moving. I'm looking forward to that merge landing in the queue | 17:13 |
| lazyPower | if you want any help/pointers on amulet, feel free to reach out. mbruzek is also an amulet master | 17:14 |
| hatch | the version in my gh repo is running ghost 5.0 btw | 17:14 |
| hatch | er | 17:14 |
| hatch | 0.5.0 | 17:14 |
| lazyPower | i'm a -stable kinda guy. I use whats in the charm store unless i *really* need something else, and then i deploy from personal namespace. I'm getting away from doing local charm deployment as much as possible | 17:14 |
| lazyPower | the overhead of remembering to upgrade charms locally is something I can't be asked to do | 17:14 |
| hatch | haha np - I'll try and get on those tests quickly | 17:15 |
| hatch | probably wont be until wednesday though | 17:15 |
| lazyPower | no rush :) | 17:15 |
| lazyPower | I may wait until you land your amulet tests before id o the migration so i can highlight the fact its a tested charm | 17:15 |
| lazyPower | and make sure you ping whomever does your review to update the quality info on ghost, that'll give you another star on quality | 17:15 |
| lazyPower | we *should* be doing that anyway, but i typically forget :( | 17:15 |
| hatch | sure that's fine | 17:16 |
| mbruzek | Hey hatch just got back from lunch catching up on the scroll back. I AM using ghost and I CAN help you with amulet. | 17:48 |
| hatch | mbruzek: I was asking specifically about the ghost charm :) because I wrote it and wasn't going to put a ton of time into it until others were using it :) | 17:59 |
| mbruzek | hatch, I am using the ghost charm. | 17:59 |
| hatch | excellent - well please file any bugs or feature requests on the GH repo :) | 18:00 |
| hatch | https://github.com/hatched/ghost-charm | 18:00 |
| mbruzek | GH ? Not Bazzar ? | 18:00 |
| hatch | the gh repo is the source of truth, lp is just a compile-to target :) | 18:01 |
| hatch | mbruzek: so how do you have your env set up? Are you using mysql/apache? | 18:01 |
| mbruzek | roger that. | 18:01 |
| mbruzek | Actually no. | 18:01 |
| mbruzek | don't get mad | 18:02 |
| mbruzek | But I am using haproxy | 18:02 |
| mbruzek | I realize this is not a way to do it in production. | 18:02 |
| mbruzek | But I am using the haproxy charm and ghost charm to run my blog | 18:03 |
| hatch | that's fine :) | 18:03 |
| hatch | haproxy works pretty well | 18:03 |
| hatch | you should look into using mysql though | 18:03 |
| mbruzek | why? sqlite not going to keep up? | 18:04 |
| hatch | if you're just using the built in sqlite db, you'll have to manually transfer everything if you ever upgrade the charm | 18:04 |
| hatch | harder to do backups...etc | 18:04 |
| mbruzek | hatch, I had a question about the configuration. When I tried to set the "host" to the actual IP address my blog goes dark. | 18:05 |
| hatch | mbruzek: yeah typically you want to just leave it at 0.0.0.0 and let the image handle it | 18:06 |
| hatch | tbh I can't think of a time when you'd want to specify the ip | 18:06 |
| mbruzek | hatch OK that is what it is set to now | 18:06 |
| hatch | but maybe if you were running some fancy network set up and you wanted it to use a specific ip | 18:06 |
| hatch | are you running haproxy and ghost on the same machine? | 18:07 |
| mbruzek | hatch yes. | 18:07 |
| mbruzek | juju deploy cs:precise/haproxy --to 0 | 18:07 |
| mbruzek | juju deploy cs:precise/ghost --to 0 | 18:08 |
| mbruzek | juju add-relation ghost haproxy | 18:08 |
| mbruzek | It was as simple as those three commands. | 18:08 |
| mbruzek | hatch, I will look at adding mysql. | 18:08 |
| hatch | mbruzek: awesome - yeah just curious really :) | 18:09 |
| hatch | mbruzek: so if you switch to mysql you'll have to manually port the posts over | 18:09 |
| hatch | (sorry) that's not done in the charm yet | 18:10 |
| mbruzek | Oh darn, all 2 of my blog postings | 18:10 |
| hatch | haha - mbruzek I am very interested in that procedure though - I'm sure others will need to do the same | 18:11 |
| hatch | keeping the blog post id's the same (if it doesn't automatically) | 18:11 |
| hatch | etc | 18:11 |
| hatch | I'd even like to include it in the readme if it's small enough, or an a supplementary file in the charm even | 18:11 |
| hatch | OR | 18:11 |
| hatch | if it's really easy, PR's accepted :P | 18:11 |
| hatch | (the charm is in javascript) :D | 18:12 |
| * mbruzek shivers | 18:12 | |
| hatch | hah yeah it was a challenge in some places but it's written in JS because Ghost is a js project | 18:14 |
| mbruzek | understood. | 18:14 |
| hatch | evening fabrice | 18:53 |
| fabrice | evening ! | 18:53 |
| Makyo | jujugui need some reviews/QA (especially QA) on clearing ECS changes https://github.com/juju/juju-gui/pull/508 | 18:55 |
| hatch | Makyo: I'll take one | 19:00 |
| hatch | got to grab some lunch first | 19:00 |
| Makyo | Sure | 19:00 |
| kadams54 | Makyo: working on my own PR but as soon as I wrap that up I'll dive into the QA queue. | 19:11 |
| kadams54 | guihelp: my own PR for QA: https://github.com/juju/juju-gui/pull/509 | 19:26 |
| hatch | jcsackett: I found an easier way to accomplish what I needed https://github.com/hatched/juju-gui/commit/9da0a126618b4a86f94e1f9a806bcc25102ae24f does this conflict with what you're working on? | 20:05 |
| hatch | if it does....it's a race to see who lands first :P | 20:07 |
| jcsackett | hatch: not even a little bit. | 20:37 |
| hatch | jcsackett: great - my original version was much bigger | 20:37 |
| hatch | heh | 20:37 |
| hatch | I've also found an issue with the token rendering that will need a refactor post 1.0+ | 20:38 |
| hatch | the tokens are never cleaned up even if they don't exist any longer (the machine is destroyed) | 20:38 |
| hatch | they aren't shown in the dom, but they are still instantiated | 20:38 |
| jcsackett | hatch: fun times. | 20:42 |
| hatch | kadams54: spin up a juju env, I'll need a qa shortly :) | 20:55 |
| kadams54 | lol | 20:55 |
| hatch | jujugui lf reviews and a qa https://github.com/juju/juju-gui/pull/510 | 20:59 |
| hatch | kadams54: this is the fix to the bug you found in the last branch | 21:00 |
| * kadams54 warms up his wrecking ball | 21:00 | |
| kadams54 | Which begs the question… how exactly do you warm up a wrecking ball? I mean, besides the Miley Cyrus way. | 21:01 |
| kadams54 | hatch: On it. | 21:01 |
| hatch | lol | 21:02 |
| hatch | Makyo: review done | 21:53 |
| hatch | I'll hold off on qa until the bug kadams54 found is fixed | 21:53 |
| hatch | there was one issue | 21:53 |
| Makyo | Cool, thanks | 21:54 |
| hatch | kadams54: I don't understand your comment - it sounds like the issue that the previous branch fixed | 22:02 |
| hatch | the tokens should never disappear | 22:02 |
| hatch | just update | 22:02 |
| hatch | kadams54: can you check to make sure you have cleared your cache and all that | 22:06 |
| huwshimi | Morning | 23:03 |
| hatch | oh huwshimi I thought you were working the night shift ;) | 23:05 |
| hatch | or, I suppose the graveyard shift | 23:05 |
| huwshimi | :) | 23:05 |
| huwshimi | hatch: I replied to your comments | 23:06 |
| hatch | thanks going back through again | 23:10 |
| hatch | the test failure was a legit one | 23:10 |
| hatch | ^ huwshimi | 23:10 |
| hatch | huwshimi: +1'd with a comment request | 23:11 |
| huwshimi | hatch: Oh, all I can see is that the build was aborted. I'll run locally | 23:12 |
| hatch | huwshimi: http://ci.jujugui.org:8080/job/juju-gui/1678/console | 23:14 |
| hatch | CI hang so there was a bunch of messed up runs | 23:14 |
| hatch | hung* | 23:14 |
| huwshimi | oh I see | 23:15 |
| huwshimi | hatch: ugh, it runs fine locally :( | 23:17 |
| hatch | huwshimi: try running test-prod | 23:18 |
| huwshimi | ah ok | 23:18 |
| huwshimi | oops, silly mistake | 23:20 |
| huwshimi | kadams54: If you're around, just need a +1 on my branch if you're happy: https://github.com/juju/juju-gui/pull/507 | 23:26 |
| hatch | huwshimi: imho if he doesn't pop in in the next couple hours - jfsi | 23:31 |
| hatch | :) | 23:31 |
| huwshimi | :) | 23:31 |
| huwshimi | hatch: Well there was a QA OK and no code comments... | 23:31 |
| hatch | huwshimi: the other thing is that when you're submitting branches that are multiple cards, can you put in the pr, the cards which are in that branch, or inversely the pr in the cards | 23:32 |
| hatch | maybe he thought your code was perfecto! | 23:32 |
| hatch | so perfect in fact the +1 was not even necessary | 23:35 |
| huwshimi | hatch: Yep, I put the pr in both cards, I can do the opposite as well if that helps | 23:39 |
| hatch | oh I missed that heh | 23:41 |
| hatch | my workflow is usually from GH to kanban | 23:41 |
| huwshimi | hatch: Yeah, me too, I'll put the titles in a comment or something | 23:45 |
| hatch | just fyi the title and the body of the first post are what gets written into the git log for the merge commit | 23:46 |
| hatch | so that's why we have been putting the qa comments in an extra comment | 23:46 |
| huwshimi | hatch: Yeah, I thought I could do it with the QA comment | 23:46 |
| huwshimi | hatch: I wish cards had unique ids, would make this stuff much easier | 23:46 |
| hatch | ugh I know | 23:46 |
| hatch | well....they do | 23:46 |
| hatch | but they aren't really accessible hah | 23:46 |
| huwshimi | concrete just about to be poured under the house for my new office :) | 23:49 |
| hatch | you are getting a basement? | 23:49 |
| hatch | I'm not entirely sure how concrete gets poured under a house without there also being a big hole :) | 23:49 |
| huwshimi | well yes, the garage under the house is being converted into a room for me to work in | 23:50 |
| hatch | ohh interesting | 23:52 |
| hatch | don't you park in your garage? | 23:52 |
| hatch | :) | 23:52 |
| huwshimi | hatch: I just park in the driveway, it's a bit too small | 23:52 |
| hatch | ahh gotcha | 23:54 |
| hatch | well yay! in that case :) | 23:56 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!