| jtv | (Hopefully) simple review: https://code.launchpad.net/~jtv/maas/control-dhcpd/+merge/232029 | 03:29 |
|---|---|---|
| bigjools | got it | 03:29 |
| jtv | Merci. | 03:29 |
| bigjools | jtv: what has been extracted? I was expecting a sea of red | 03:30 |
| jtv | Just a few call_and_check calls, that's all. | 03:31 |
| bigjools | so the control stuff is really new? | 03:31 |
| jtv | Along with some of the patching in tests. | 03:31 |
| jtv | Yes, just simple wrappers for those call_and_check functions. | 03:32 |
| jtv | *calls. | 03:32 |
| bigjools | right | 03:32 |
| jtv | Ah, I see now: should have said "extract functions for [...] *and put them* into their own module." | 03:33 |
| bigjools | I'm not sure you need all these functions do you? | 03:34 |
| bigjools | it's really bloating the code | 03:34 |
| jtv | Well the point is that the bloat is nicely out of the way. | 03:38 |
| jtv | If you need to write a new test for "this restarts the DHCP server," you no longer need to write a test for a particular sudo command being issued. You just assert that the restart function gets called. | 03:39 |
| bigjools | see my suggestion | 03:39 |
| * bigjools eats, bbiab | 03:42 | |
| bigjools | jtv: email me @gmail if you want a follow up, I'll be AFK for a bit but my phone will ding | 03:44 |
| bigjools | jtv: back | 04:45 |
| jtv | ok | 04:45 |
| jtv | bigjools: could I ask you for another small review? There's bigger stuff in the pipeline as well but this is easy prep: https://code.launchpad.net/~jtv/maas/dhcp-test-trivia/+merge/232034 | 07:11 |
| === CyberJacob|Away is now known as CyberJacob | ||
| bigjools | looking | 07:31 |
| trash | Hmm, when using ' amd64/hwe-s ' architecture on the precise release, I get architecture not support by selected mirror while installing. What am I doing wrong? | 12:20 |
| trash | There you can see the syslog: http://i.imgur.com/0E2TVXR.png | 12:21 |
| === CyberJacob is now known as CyberJacob|Away | ||
| === matsubara is now known as matsubara-lunch | ||
| === ubot5` is now known as ubot5 | ||
| === roadmr is now known as roadmr_afk | ||
| === matsubara-lunch is now known as matsubara | ||
| === roadmr_afk is now known as roadmr | ||
| === mwhudson_ is now known as mwhudson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
