[03:29] (Hopefully) simple review: https://code.launchpad.net/~jtv/maas/control-dhcpd/+merge/232029 [03:29] got it [03:29] Merci. [03:30] jtv: what has been extracted? I was expecting a sea of red [03:31] Just a few call_and_check calls, that's all. [03:31] so the control stuff is really new? [03:31] Along with some of the patching in tests. [03:32] Yes, just simple wrappers for those call_and_check functions. [03:32] *calls. [03:32] right [03:33] Ah, I see now: should have said "extract functions for [...] *and put them* into their own module." [03:34] I'm not sure you need all these functions do you? [03:34] it's really bloating the code [03:38] Well the point is that the bloat is nicely out of the way. [03:39] If you need to write a new test for "this restarts the DHCP server," you no longer need to write a test for a particular sudo command being issued. You just assert that the restart function gets called. [03:39] see my suggestion [03:42] * bigjools eats, bbiab [03:44] jtv: email me @gmail if you want a follow up, I'll be AFK for a bit but my phone will ding [04:45] jtv: back [04:45] ok [07:11] bigjools: could I ask you for another small review? There's bigger stuff in the pipeline as well but this is easy prep: https://code.launchpad.net/~jtv/maas/dhcp-test-trivia/+merge/232034 === CyberJacob|Away is now known as CyberJacob [07:31] looking [12:20] Hmm, when using ' amd64/hwe-s ' architecture on the precise release, I get architecture not support by selected mirror while installing. What am I doing wrong? [12:21] There you can see the syslog: http://i.imgur.com/0E2TVXR.png === CyberJacob is now known as CyberJacob|Away === matsubara is now known as matsubara-lunch === ubot5` is now known as ubot5 === roadmr is now known as roadmr_afk === matsubara-lunch is now known as matsubara === roadmr_afk is now known as roadmr === mwhudson_ is now known as mwhudson