| === alecu_ is now known as alecu | ||
| Cimi | mooorning | 06:59 |
|---|---|---|
| Saviq | oi! | 07:09 |
| Cimi | Saviq, have some time? | 07:10 |
| Saviq | Cimi, what up> | 07:10 |
| Cimi | Saviq, I was wondering if we should allocate some height when the string summary is empty | 07:10 |
| Saviq | Cimi, we shouldn't need to, when it's empty, it should be 0 high | 07:11 |
| Cimi | Saviq, or if we should just behave like summary is not there at all | 07:11 |
| Saviq | Cimi, not there at all | 07:11 |
| Saviq | Cimi, basically the card needs to be as compact as possible while maintaining margins and such | 07:11 |
| Cimi | Saviq, I will simply change then the boolean hasSummary into checking for carddata | 07:11 |
| Cimi | both I mean | 07:12 |
| Cimi | that will work | 07:12 |
| Saviq | Cimi, yeah, it definitely needs to be "runtime" as that depends on cardData indeed | 07:12 |
| mzanetti | Saviq: hey | 07:32 |
| mzanetti | Saviq: so seems thre is an issue with the Dialog in the Lockscreen | 07:33 |
| mzanetti | apparently the Notification (snap decision) is still on top of that | 07:33 |
| mzanetti | now, I could try fiddling with z ordering and such... but I guess there could be issues in the future? | 07:34 |
| Saviq | mzanetti, well, notifications are on top of greeter, too, not sure where the problem with that is? | 07:43 |
| mzanetti | Saviq: well, notifications are on top of the Dialog too :) | 07:43 |
| mzanetti | Saviq: at least the UITK one | 07:43 |
| mzanetti | so I'll probably try to reuse that code without PopupUtils and just paint it above the lockscreen myself | 07:44 |
| Saviq | mzanetti, what's "the Dialog in the Lockscreen"? | 07:44 |
| mzanetti | the "This is your last attempt" dialog | 07:44 |
| Saviq | mzanetti, and why would notifications not be on top of it? | 07:44 |
| Saviq | z-axis "on top" I assume? | 07:45 |
| mzanetti | yes | 07:45 |
| mzanetti | so the notification (the lockscreen itself) is above the Dialog it opens | 07:45 |
| mzanetti | so you won't see the dialog | 07:45 |
| tsdgeos | is altnav broken in all scopes? | 07:46 |
| mzanetti | Saviq: is it actually wanted that notifications are on top of modal dialogs? | 07:46 |
| asac | altnav? | 07:46 |
| Saviq | tsdgeos, go to ebay, change department | 07:47 |
| * asac had the feeling something was broken in scopes, but didnt have a word | 07:47 | |
| mzanetti | :) | 07:47 |
| tsdgeos | Saviq: but why is it showing all the time? | 07:47 |
| tsdgeos | Saviq: it shows empty in apps | 07:47 |
| Saviq | tsdgeos, hmm? | 07:47 |
| Saviq | tsdgeos, does not, here | 07:48 |
| * Saviq just flashed | 07:48 | |
| tsdgeos | Saviq: my pc http://i.imgur.com/7OAB8it.png | 07:48 |
| tsdgeos | dist-upgraded a minute ago | 07:48 |
| Saviq | tsdgeos, trunk doesn't behave like that here, updating now | 07:50 |
| Saviq | (nor any of my phones) | 07:50 |
| tsdgeos | asac: altnav is the "Alternative Navigation", the old departments are now "nav" and "altnav" | 07:50 |
| Saviq | asac, do you have the same tsdgeos posted above? | 07:50 |
| Saviq | @unity anyone else seeing what tsdgeos is? | 07:51 |
| * Saviq wonders if it's a click scope release | 07:51 | |
| tsdgeos | Saviq: i get it everywhere | 07:51 |
| Saviq | tsdgeos, ¿? | 07:51 |
| tsdgeos | well not everywhere | 07:51 |
| tsdgeos | but everywhere that has navigation | 07:51 |
| tsdgeos | say ebay too | 07:52 |
| dednick | been a while since i've upgraded | 07:52 |
| tsdgeos | maybe i have some broken manually installed package | 07:52 |
| tsdgeos | let me make sure i reinstall the scopes plugin | 07:52 |
| dednick | i haven't got that many click packages installed though | 07:53 |
| tsdgeos | Saviq: ok, ignore it's my own bug | 07:54 |
| Saviq | tsdgeos, thank you | 07:54 |
| Saviq | asac, what's broken in scopes for you? | 07:54 |
| asac | Saviq: its weird... the pics seem to be empty etc. | 07:57 |
| asac | and content ... not sure; i think i --wipe installed and went out | 07:58 |
| asac | and then was only on H connection | 07:58 |
| asac | and thats how things fell over a bit and it took many retries until i ended up with pics on youtube etc. | 07:58 |
| asac | right now its all ok ... but I am on wifi and it wasnt that OK last night even on wifi. maybe #4 really helped | 07:59 |
| asac | ignore for now | 07:59 |
| Saviq | asac, bug #1357321 | 08:04 |
| ubot5 | bug 1357321 in Unity 8 "scope images do not load in HSDPA or 3G" [Undecided,Confirmed] https://launchpad.net/bugs/1357321 | 08:05 |
| tsdgeos | easy fix https://code.launchpad.net/~aacid/unity8/fix_gsv_navigationShown/+merge/232671 | 08:07 |
| asac | Saviq: yay :) thx | 08:08 |
| Saviq | tsdgeos, so it's a bug in trunk? | 08:10 |
| tsdgeos | Saviq: yes/no | 08:10 |
| tsdgeos | Saviq: i think the variable is not really needed | 08:10 |
| tsdgeos | i.e. the places is used the black rectangle we show on navigation should fix | 08:11 |
| tsdgeos | but i decided to play safe | 08:11 |
| Saviq | tsdgeos, so why are you seeing it but not me? :D | 08:11 |
| tsdgeos | ah no no | 08:11 |
| tsdgeos | sorry | 08:11 |
| tsdgeos | that's a different thing | 08:11 |
| Saviq | ah ok | 08:11 |
| tsdgeos | this just fixes a warning in command line | 08:11 |
| Saviq | got it | 08:12 |
| tsdgeos | my other thing was that i deleted an necessary visible: | 08:12 |
| tsdgeos | :D | 08:12 |
| tsdgeos | also i could do with some branch reviewing | 08:13 |
| Saviq | mzanetti, on dialogs vs. notifications... notifications *are* modal dialogs | 08:13 |
| tsdgeos | again i have like 10 branches pending merge | 08:13 |
| Saviq | tsdgeos, because they're all one-liners ;P | 08:13 |
| Saviq | tsdgeos, will try and do some of them | 08:13 |
| mzanetti | Saviq: right... so what should happen when a modal dialog opens a modal dialog? :D | 08:13 |
| Saviq | mzanetti, so, the lockscreen should not be a snap decision is all, but because it is | 08:14 |
| Saviq | mzanetti, yeah, the dialog should show up on top, not sure why it doesn't? | 08:14 |
| * Saviq always felt reparenting to root was gonna bite us in the a$$ | 08:15 | |
| mzanetti | Saviq: well, afaik (and I still need to investigate more) PopupUtils reparents the dialog to the main window's root | 08:15 |
| mzanetti | Saviq: +1 on that | 08:15 |
| Saviq | mzanetti, still, sounds like it's a simple z-ordering issue then? | 08:16 |
| Saviq | biab | 08:16 |
| mzanetti | Saviq: yes, it probably is... | 08:16 |
| Saviq | mobo replacement service... | 08:16 |
| mzanetti | :D | 08:16 |
| Cimi | Saviq, I am not convinced we should behave like there is no summary | 08:30 |
| Cimi | Saviq, afaics, summary might enable a different look for the card | 08:30 |
| Cimi | Saviq, so if we have art + title + summary is different than art + title | 08:31 |
| Cimi | Saviq, how shall we behave on those? | 08:31 |
| Cimi | having a mix of two states? | 08:31 |
| tsdgeos | paulliu: can you review https://code.launchpad.net/~aacid/unity8/removeUnusedHasAttributes/+merge/232100 ? | 08:35 |
| tsdgeos | Cimi: since you commented on them, maybe you can do https://code.launchpad.net/~aacid/unity8/clickBlackStuffOverview/+merge/232431 and https://code.launchpad.net/~aacid/unity8/dashOverviewFromTempScopePreview/+merge/232378 ? | 08:39 |
| tsdgeos | Cimi: your commit message is wrong | 09:23 |
| Cimi | tsdgeos, change it | 09:24 |
| tsdgeos | well what was wrong with mine? | 09:24 |
| tsdgeos | or there was none? | 09:24 |
| Cimi | tsdgeos, there was none | 09:24 |
| tsdgeos | ok, thanks | 09:24 |
| tsdgeos | improved | 09:24 |
| Saviq | Cimi, summary forces background, and it still should | 09:37 |
| Cimi | Saviq, ok, I will try to just play with right height | 09:38 |
| === Trevinho_ is now known as Trevinho | ||
| dednick | Saviq: ping | 09:57 |
| === lool- is now known as lool | ||
| Saviq | dednick, hey | 09:59 |
| dednick | Saviq: do you know if there are any ubuntu-app-launch logs anywhere? ie logging requests for app starts ? | 09:59 |
| Saviq | dednick, it should be just a job | 10:00 |
| Saviq | dednick, check out in ~/.cache/upstart/application.log | 10:00 |
| === irsol_ is now known as irsol | ||
| dednick | Saviq: but that's the app log isn't it? not the "upstart log" | 10:00 |
| Saviq | dednick, anything upstart would print ends up in there | 10:01 |
| dednick | Saviq: ok | 10:01 |
| Saviq | dednick, what I do when I don't know is just rm ~/.cache/upstart/* | 10:02 |
| Saviq | dednick, and then check out what's new there after I've done what I wanted ;) | 10:02 |
| dednick | Saviq: yup, that's what i did, but dont get anything interesting. was hoping to get a command line execution log or something | 10:07 |
| Cimi | how do I rerun scopes backends? | 10:12 |
| === greyback__ is now known as greyback | ||
| Cimi | Saviq, music and video scopes are empty for me | 10:22 |
| Cimi | Saviq, how do I restart the service? | 10:23 |
| Cimi | is it scopescanner? | 10:23 |
| Cimi | mediascanner | 10:23 |
| Cimi | still empty after killing mediascanner | 10:23 |
| Cimi | weird | 10:24 |
| Cimi | anyone? | 10:27 |
| * Cimi reboots | 10:27 | |
| Cimi | w00t I have artists | 10:29 |
| Cimi | the empty icon looks so bad | 10:29 |
| Cimi | it has borders in it | 10:29 |
| === zoktar_ is now known as zoktar | ||
| === popey_ is now known as popey | ||
| Saviq | another day, another mobo... /me lost the nV GPU | 10:49 |
| Cimi | ouch | 10:49 |
| Saviq | let | 10:49 |
| Saviq | 's see what will Santa bring on Monday then... | 10:49 |
| Saviq | *one* of them has to work fine | 10:49 |
| Cimi | Saviq, lp:~unity-team/unity8/fix-vertical-journal | 10:50 |
| Cimi | Saviq, is still clip by sth | 10:50 |
| Cimi | Saviq, you busy with the motherboard or you can try that? | 11:00 |
| === MacSlow is now known as MacSlow|lunch | ||
| Saviq | Cimi, yeah, trying | 11:01 |
| Cimi | Saviq, is the ResponsiveVerticalJournal that clips | 11:02 |
| Saviq | Cimi, not exactly, but yeah, expandedHeight == collapsedHeight, which is wrong | 11:07 |
| Saviq | Cimi, BUT | 11:07 |
| Saviq | I'm looking | 11:07 |
| === me4oslav_ is now known as me4oslav | ||
| Saviq | Cimi, looks to me like CardVerticalJournal is misssing + 2*rowSpacing in expanded and collapsedHeight | 11:13 |
| Saviq | Cimi, *or* verticalhournal should include those in its implicitHeight maybe | 11:13 |
| Saviq | because that's what actually puts in the top and bottom margins, right tsdgeos? | 11:14 |
| tsdgeos | reading | 11:14 |
| Saviq | tsdgeos, basically, vjournal's implicitHeight == card height (when there's only one card, say) | 11:16 |
| Saviq | tsdgeos, but it seems to add spacing on top, should add it below, too, so implicitHeight is actually the whole thing | 11:17 |
| tsdgeos | Saviq: well, there's the anchor margin in ResponsiveVerticalJournal.qml, no? | 11:17 |
| Saviq | tsdgeos, is there? | 11:17 |
| Saviq | tsdgeos, right, so that's where it's missing | 11:17 |
| * Saviq forgot there's one more abstraction in the middle | 11:18 | |
| tsdgeos | why is it missing? | 11:19 |
| Saviq | tsdgeos, it's missing in implicitHeight | 11:19 |
| Saviq | tsdgeos, Cimi, ResponsiveVerticalJournal.implicitHeight does not take the margins into account | 11:19 |
| tsdgeos | i don't understand why | 11:19 |
| Saviq | tsdgeos, because it adds them on top/bottom | 11:19 |
| Saviq | tsdgeos, and it takes vj's implicitheight directly | 11:19 |
| Saviq | tsdgeos, RVJ adds margins above/below VJ | 11:20 |
| Saviq | tsdgeos, but its implicitHeight does not take them into account | 11:21 |
| Saviq | its == RVJ's | 11:21 |
| Saviq | tsdgeos, you disagree? | 11:22 |
| tsdgeos | i'm trying to undedstand why the test works then | 11:22 |
| Cimi | Saviq, it is still not enough I think | 11:22 |
| Saviq | Cimi, we need to find where does the huge top margin come from | 11:23 |
| Saviq | Cimi, is all | 11:23 |
| Cimi | ok | 11:24 |
| Saviq | tsdgeos, the test works slightly the other way | 11:25 |
| Saviq | tsdgeos, it never looks at RVJ.implicitHeight | 11:25 |
| tsdgeos | correct | 11:25 |
| Saviq | so we're not testing it is all | 11:25 |
| tsdgeos | http://paste.ubuntu.com/8177838/ shows the problem | 11:27 |
| Cimi | Saviq, in the meanwhile, I pushed | 11:27 |
| === _salem` is now known as _salem | ||
| Cimi | Saviq, genericScopeView | 11:27 |
| === _salem is now known as salem_ | ||
| Cimi | line 212 | 11:30 |
| Cimi | topMargin: name != "" ? 0 : units.gu(2) | 11:30 |
| === Zhenech_ is now known as Zhenech | ||
| Cimi | Saviq, tsdgeos did you see topMargin: name != "" ? 0 : units.gu(2) ? | 11:32 |
| Cimi | there are network splits I dont know if you read me | 11:32 |
| tsdgeos | Cimi: yes, that is on purpose | 11:33 |
| Saviq | Cimi, yeah, that's because there's no category header | 11:33 |
| Saviq | Cimi, it could've been 1 maybe | 11:33 |
| Cimi | Saviq, this created the big padding at top | 11:33 |
| Saviq | Cimi, but it's actually consistent with https://drive.google.com/drive/#folders/0B2WkkoWiZT_TcW44R0poQ1llcHc/0B2WkkoWiZT_TeEIyZG9VXzA2ZVk/0B8T-xKCA6bikQ1pIME9nNmUxM3c/0B71w9p1v_aX4Q0ZTZnpmWF9qSWc/0B71w9p1v_aX4SmxGN3l1aHBIcTA/0B8I8ZVKH-8SsalVsbjFCd0l3bGs | 11:34 |
| Saviq | Cimi, it's the rest of the dash that isn't... | 11:34 |
| Saviq | if only stupid google let you zoom a file in to what is actually at least 100% | 11:34 |
| Saviq | instead of "oh, it's higher than your screen, it can't make sense to zoom it even more" like WTF really? | 11:34 |
| Cimi | Saviq, what yo I need to append to open it with the right account? | 11:35 |
| Cimi | on the linlk | 11:35 |
| Saviq | ?authuser=1? | 11:35 |
| Cimi | I try | 11:36 |
| Cimi | Saviq, or just link me a file | 11:36 |
| Saviq | Cimi, same thing, if it's protected | 11:36 |
| Saviq | Cimi, can you see https://docs.google.com/a/canonical.com/file/d/0B8I8ZVKH-8SsUklLM1o4UXZCVXc/edit ? | 11:37 |
| Saviq | Cimi, I changed it to be public | 11:37 |
| Cimi | Saviq, I can | 11:39 |
| dandrader | wow, vkb nicely animates up and down now | 11:44 |
| tsdgeos | Saviq: what do you think of the coment i just made in the https://bugs.launchpad.net/unity8/+bug/1363052 bug? | 11:51 |
| ubot5 | Ubuntu bug 1363052 in Unity 8 "dash overview misbehaves when there's only the apps scope" [Low,Triaged] | 11:51 |
| Saviq | tsdgeos, I think scrolling it would be fine, assuming it would stick to the middle | 11:52 |
| Saviq | tsdgeos, like it should be centered horizontally with width: Math.min(implicitWidth, parent.width) | 11:52 |
| Saviq | tsdgeos, so that you can still drag and overshoot it, just it sticks in the center | 11:52 |
| Saviq | s/implicitWidth/contentWidth/ | 11:53 |
| === dandrader is now known as dandrader|afk | ||
| === Pici` is now known as Pici | ||
| === ssweeny` is now known as ssweeny | ||
| Cimi | this PageHeaderLabelTest__test_popover that is always failing | 12:46 |
| Cimi | is because of SDK? | 12:46 |
| Saviq | Cimi, yes, fixed in Albert's branch | 12:46 |
| Saviq | mterry_, hey, did you see plars reported that unlock script doesn't work? | 12:47 |
| Saviq | mterry_, it looked like it didn't get dbus details | 12:47 |
| Saviq | uh oh | 12:49 |
| Saviq | failed to add storage device | 12:49 |
| Saviq | quite persistent, too... | 12:49 |
| tsdgeos | Saviq: it wokred here when i tried yetteaday | 12:49 |
| Saviq | tsdgeos, I mean the notification | 12:49 |
| Saviq | tsdgeos, it's messing with our autopilot tests | 12:49 |
| tsdgeos | ah | 12:50 |
| Saviq | tsdgeos, and I don't *have* any storage device... | 12:50 |
| tsdgeos | that may be | 12:50 |
| Saviq | what was the name of that package... | 12:50 |
| Saviq | ciborium | 12:51 |
| mterry_ | Saviq, I did... I tested quite heavily so I'm hoping that was a mistake, but I'd like to talk to plars about it. plars? | 12:52 |
| plars | mterry_: hi, I have that phone set up still, but have a meeting starting in 20 min | 13:06 |
| mterry_ | plars, mako or otherwise? | 13:06 |
| plars | mterry_: this is on mako, but I'm happy to try it on krillin, needs to work everywhere but I'm not sure why it would work on one and not the other | 13:07 |
| plars | mterry_: what did you test on? | 13:08 |
| mterry_ | plars, I tried on both, just checking | 13:08 |
| mterry_ | plars, did you directly call the unlock-device script or do it via the ./run-smoke script? | 13:08 |
| plars | mterry_: I was using run-smoke | 13:09 |
| plars | mterry_: wanted to capture the full setup the way it's used | 13:09 |
| === dandrader|afk is now known as dandrader | ||
| mterry_ | plars, I'll try again with latest code | 13:11 |
| mterry_ | plars, I did test run-smoke | 13:11 |
| plars | mterry_: I'll do some more testing with it here as well | 13:12 |
| dandrader | Saviq, do we have written anywhere about the format of commit messages (short summary, then empty line, then long description if any) | 13:44 |
| dandrader | ? | 13:44 |
| Saviq | dandrader, no | 13:45 |
| dandrader | Saviq, but we are using this format right? | 13:45 |
| Saviq | dandrader, yes | 13:52 |
| dandrader | Saviq, ok, will add it to the checklist | 13:52 |
| dandrader | review checklist | 13:53 |
| tsdgeos | Saviq: where's that weird notification in autopilot coming from? | 13:53 |
| Saviq | tsdgeos, ciborium | 13:53 |
| tsdgeos | Saviq: what's that? | 13:53 |
| Saviq | tsdgeos, you mean the storage one? | 13:53 |
| tsdgeos | yeah | 13:53 |
| Saviq | tsdgeos, our storage manager | 13:53 |
| dandrader | Saviq, but we have some conflicting information as mterry_ just told me that some people were asking for verbose, detailed change log entries. and since we generate them out of the first line of commit messages, that would mean looooong first lines | 13:54 |
| Saviq | dandrader, doesn't have to be first line | 13:54 |
| dandrader | which I don't agree with btw | 13:54 |
| Saviq | dandrader, it's up to the first empty line | 13:54 |
| tsdgeos | Saviq: so how does one run autopilot tests now? | 13:55 |
| Saviq | tsdgeos, reboots and hopes that stuff's good again ;) | 13:55 |
| mterry_ | Saviq, dandrader: uh, that format of commit messages doesn't match historical practices for debian/changelog entries | 13:55 |
| tsdgeos | Saviq: prfff | 13:55 |
| mterry_ | dandrader, Saviq: is the complaint about long first lines just a style thing or a tooling problem or what? | 13:56 |
| Saviq | tsdgeos, adb shell gdbus introspect --system -p -d org.freedesktop.UDisks2 -o /org/freedesktop/UDisks2/block_devices/mmcblk0 /org/freedesktop/UDisks2/block_devices/mmcblk0p2 | grep System | 13:56 |
| Saviq | tsdgeos, what's that say? | 13:56 |
| tsdgeos | i don't know | 13:56 |
| tsdgeos | i rebotted | 13:56 |
| Saviq | tsdgeos, so that needs to say "true" | 13:56 |
| Saviq | tsdgeos, if it doesn't, means udev rules didn't stick | 13:56 |
| Saviq | tsdgeos, Sergio is on it | 13:56 |
| tsdgeos | well, i have a unittest failing in CI but not ondesktop | 13:57 |
| tsdgeos | need to get it to happen on the phone so i can try to fix it | 13:57 |
| tsdgeos | readonly b HintSystem = true; | 13:58 |
| tsdgeos | is what i got | 13:58 |
| Saviq | mterry_, is something like https://launchpad.net/ubuntu/+source/unity8/8.00+14.10.20140814.1-0ubuntu1 | 13:59 |
| Saviq | like this actually a useful changelog? | 13:59 |
| Saviq | mterry_, IMO changelog should be a summary, you get full history from the commit log | 14:00 |
| Saviq | mterry_, there's things that we should potentially include in the changelog (like dependency changes) | 14:00 |
| Saviq | mterry_, but I don't think explaining the whole change is so useful to be there? | 14:00 |
| mterry_ | Saviq, I understand why you'd say that, but I believe the preference in the Ubuntu project is for verbose changelogs | 14:00 |
| Saviq | mterry_, you can still do verbose changelogs | 14:01 |
| Saviq | mterry_, it will take the commit message up to the first newline | 14:01 |
| Saviq | empty | 14:01 |
| Saviq | not newline | 14:01 |
| Saviq | emptyline | 14:01 |
| mterry_ | Saviq, sure... but you were just arguing against verbosity I thought? | 14:01 |
| Saviq | mterry_, against oververbosity | 14:01 |
| mterry_ | You wanted a "summary" | 14:01 |
| Saviq | mterry_, yeah, summary != one line | 14:02 |
| Saviq | mterry_, I just don't think all of the details that go with a commit message (because they reference code, for example), go with a changelog | 14:02 |
| mterry_ | Saviq, again, I think the preference of the Ubuntu project is to be more verbose rather than less verbose. But I hear you about code. For example, I usually omit the rationale behind specific code decisions and such, leaving them to the MP | 14:03 |
| Saviq | mterry_, but well, if that's what Ubuntu is after, then we should tell sil2100, he's the one who agreed and implemented the short version in the train ;D | 14:03 |
| dandrader | mterry_, Saviq, I've no option on unity8's debian/changelog as I'm not a consumer of it. But I am a consumer of commit messages, and when I do a "bzr log" or "bzr qlog" I wanna glance at what has recently happened and changed. so short summaries. but then I stumble upon a whole "paragraph in a line" biography that takes me a minute to digest | 14:03 |
| Saviq | mterry_, it was really bad in the changelogs generated by it because it dropped newlines and such | 14:03 |
| dandrader | s/option/opinion | 14:04 |
| mterry_ | Saviq, well if the landing team is happy, I won't gainsay them. I was under the impression they had explicitly asked for more verbosity | 14:04 |
| sil2100 | Saviq, mterry_: you can override that if you want ;) | 14:04 |
| sil2100 | Saviq, mterry_: if you want to include the whole commit-message, just check a flag during the build job and done | 14:04 |
| mterry_ | dandrader, that sounds like a tooling problem that doesn't wrap lines? | 14:04 |
| Saviq | mterry_, not really | 14:04 |
| Saviq | mterry_, even if it wrapped but was a whole long sentence | 14:04 |
| Saviq | mterry_, that's a commit msg problem | 14:05 |
| dandrader | mterry_, no. I don't wanna read a whole paragraph (wrapped or not) just to know roughly what a commit is about | 14:05 |
| mterry_ | Saviq, OK sure. So now we're fighting run on sentences? | 14:05 |
| mterry_ | Whatever, I don't mean to sound obstructionist. | 14:05 |
| dandrader | mterry_, I want a summary | 14:05 |
| dandrader | a short description | 14:05 |
| mterry_ | I also want readable commit logs and such | 14:05 |
| Saviq | mterry_, I don't think one prevents the other | 14:06 |
| dandrader | mterry_, if I am indeed interested in this specific commit. then I would go and read the whole story | 14:06 |
| Saviq | mterry_, maybe we just need a wiki page that will summarize what we want on a commit message :) | 14:06 |
| mterry_ | dandrader, except there's not a very easy mapping | 14:06 |
| dandrader | mterry_, but that's not the case when I'm just listing all commits | 14:06 |
| dandrader | mterry_, a short description/summary doesn't have to be accurate | 14:07 |
| dandrader | mterry_, that's why you put a long description below | 14:07 |
| mterry_ | Saviq, yeah for sure, we should have some guidance in a wiki somewhere. I was merely cautioning against (A) formatting in a way that isn't normal for debian/changelog and (B) recommending not being verbose | 14:07 |
| Saviq | mterry_, oh no, I recommend being verboes | 14:09 |
| Saviq | mterry_, just how much of that ends up in debian/changelog is the debate here | 14:09 |
| Saviq | mterry_, like this is an extreme example and pure tsdgeos fault for just randomly pasting stuff in commit msgs, but still https://launchpad.net/ubuntu/+source/unity8/7.90+14.10.20140703.1-0ubuntu1 ;) | 14:10 |
| Saviq | mterry_, but really I think where this started from really is the fact that the train flattened the commit msg into changelog | 14:11 |
| Saviq | mterry_, so if you had a list of some sort, it would get inlined | 14:11 |
| Saviq | and totally not readable | 14:11 |
| tsdgeos | Saviq: it's not my fault our tools suck | 14:11 |
| tsdgeos | that was nicely formatted on my end | 14:11 |
| mterry_ | Saviq, well let's be more explicit than "verbose" -- I think we both agree that details of the code are rarely suitable. But sounds like maybe we have a different idea of exactly where the line does go :) | 14:11 |
| kgunn | lol | 14:11 |
| Saviq | mterry_, I think the landing team would mostly appreciate a list of dependency changes | 14:12 |
| mterry_ | Sure. And that might want to be called out in the checklist or something. Very easy to forget that (for me at least) | 14:12 |
| Saviq | tsdgeos, yeah, problem is it's indented and wrapped, would have to become real smart to deal with indents and reflowing the text because it's trying to fit within 80 lines and such... | 14:13 |
| Saviq | mterry_, yup | 14:13 |
| Saviq | s/lines/columns/ | 14:13 |
| mzanetti | Saviq: hey, this one should be ready for review: https://code.launchpad.net/~mzanetti/unity8/rework-launcher-backend/+merge/232200 | 14:14 |
| === olli_ is now known as olli | ||
| Saviq | mzanetti, ON A FRIDAY!? | 14:15 |
| mzanetti | :D | 14:15 |
| * Saviq sees QDebug where not needed | 14:15 | |
| mzanetti | oops. | 14:16 |
| Saviq | +888/-1089 that I like | 14:16 |
| mzanetti | Saviq: as usual... if it doesn't work its probably too much code | 14:17 |
| Saviq | mzanetti, don't mention pot on MP comments | 14:20 |
| mzanetti | ? | 14:20 |
| Saviq | superseeds | 14:20 |
| mzanetti | still not following | 14:21 |
| Saviq | mzanetti, super*seeds* | 14:23 |
| Saviq | mzanetti, has nothing to do with superseding ;) | 14:23 |
| mzanetti | oh | 14:23 |
| tsdgeos | i need debian/* help | 14:23 |
| Saviq | tsdgeos, hitme | 14:23 |
| tsdgeos | why the packages of https://code.launchpad.net/~aacid/unity8/scopes_more_things_on_memory/+merge/232185 don't depend on qml-module-ubuntu-connectivity ? | 14:23 |
| Saviq | tsdgeos, because you put it in build deps only | 14:24 |
| Saviq | tsdgeos, you need that in runtime deps instead | 14:24 |
| tsdgeos | Saviq: i need it in build deps too | 14:24 |
| Saviq | tsdgeos, for unity8-private most probably | 14:24 |
| tsdgeos | or testCardFoo will fail | 14:24 |
| Saviq | tsdgeos, well, mock it for testCardFoo | 14:24 |
| tsdgeos | it's not a mock | 14:25 |
| Saviq | tsdgeos, ideally that is | 14:25 |
| tsdgeos | it's checking the thing that creates the card | 14:25 |
| tsdgeos | i mean basically checking the component can be created | 14:25 |
| Saviq | tsdgeos, well, do you not want to test the functionality too? in testCard? | 14:25 |
| Saviq | tsdgeos, that it actually does the right thing? | 14:25 |
| tsdgeos | that's a different story :D | 14:26 |
| Saviq | tsdgeos, in any case, the primary place where qml-module depends should be | 14:26 |
| Saviq | tsdgeos, is *runtime* depends of the relevant package | 14:27 |
| tsdgeos | ok | 14:27 |
| Saviq | tsdgeos, be it unity8, unity8-common or unity8-private | 14:27 |
| Saviq | tsdgeos, in your case it's unity8-private, because that's where the plugin goes | 14:27 |
| Saviq | tsdgeos, _and_ build.sh | 14:27 |
| Saviq | tsdgeos, because we can't auto-install runtime deps unfortunately | 14:27 |
| Saviq | tsdgeos, then, if your test fails still, means you either should mock it (ideally, but probably not for like the whole of Ubuntu.Components...), or add to Build-Depends | 14:28 |
| === alan_g is now known as alan_g|tea | ||
| tsdgeos | Saviq: ok | 14:28 |
| pstolowski | tsdgeos, hey, can you take a look when you have a moment? https://code.launchpad.net/~stolowski/unity-scopes-shell/expandable-widget/+merge/231865 | 14:28 |
| cwayne | Saviq: ping | 14:29 |
| * tsdgeos clicks | 14:30 | |
| tsdgeos | pstolowski: i don't know much of the internals of unity-scopes-shell tbh | 14:32 |
| tsdgeos | pstolowski: what do you want me to do? | 14:32 |
| pstolowski | tsdgeos, ah, ok, fair enough.. i'll ask petewoods to review on monday | 14:38 |
| tsdgeos | pstolowski: i mean the code looks good from the "i know nothing about this but it doesn't look crazy" | 14:38 |
| tsdgeos | :D | 14:38 |
| Saviq | cwayne, poing | 14:38 |
| cwayne | Saviq: could a scope:// url be used from another scope's preview action? | 14:39 |
| cwayne | like for a 'see more' button or something | 14:39 |
| pstolowski | tsdgeos, :) no worries | 14:40 |
| Saviq | cwayne, yeah, that works already | 14:41 |
| * Saviq wonders where it's implemented... | 14:41 | |
| Saviq | pstolowski, do you remember? actions that do canned scopes? | 14:42 |
| cwayne | Saviq: i tried it yesterday (with the silo for url-dispatcher) and I could get it to work from url-dispatcher from cli, but not from a scope | 14:43 |
| === dandrader is now known as dandrader|afk | ||
| pstolowski | Saviq, cwayne yes, that should work, just set "uri" attribute of action to be a scope uri (please use CannedQuery + to_uri() rather than hardcoding scope:// strings) | 14:44 |
| cwayne | hm, ok, and so i could do that to a specific department then | 14:44 |
| === alan_g|tea is now known as alan_g | ||
| === dandrader|afk is now known as dandrader | ||
| cwayne | pstolowski: so i set it from cannedquery touri, and clicking the button does nothing :/ | 14:54 |
| pstolowski | cwayne, can you pastebin the code where you construct the preview? | 14:56 |
| cwayne | pstolowski: i just set the action URI to CannedQuery.ToURI() (its in go though) | 14:57 |
| cwayne | which is setting the URI to scope://com.canonical.scopes.poi_poi?q= | 14:57 |
| pstolowski | cwayne, you;re right, something broke :(, i've just checked with click scope where we have such action button for scopes | 15:02 |
| pstolowski | cwayne, let me check one more thing.. it appears to be working in scopes scope (when you open a preview for a scope, and hit "Search" button) | 15:03 |
| === om26er is now known as om26er|dinner | ||
| pstolowski | cwayne, it appears to be working only for favorited scopes for some reason | 15:07 |
| Saviq | pstolowski, oh :| | 15:09 |
| Saviq | pstolowski, we reaaally need to redo the Scopes model... I really feel like it should just give me canned queries and we should go: getScopeForQuery(query) every time | 15:10 |
| pstolowski | Saviq, I recall we had issues with executing canned query for temp pages before.. | 15:10 |
| cwayne | pstolowski: even that's not working for me | 15:10 |
| pstolowski | cwayne, try to 're-visit' the scope and preview | 15:11 |
| pstolowski | cwayne, also, can you tail -f /home/phablet/.cache/upstart/unity8-dash.log while clicking the button? | 15:12 |
| cwayne | pstolowski: UbuntuWindow::handleSurfaceFocusChange(focused=false) | 15:13 |
| cwayne | UbuntuWindow::handleSurfaceFocusChange(focused=true) | 15:13 |
| cwayne | Got scope URI "scope://com.canonical.scopes.poi_poi?q=&dep=bus" | 15:13 |
| pstolowski | cwayne, yeah, so shell plugin receives it | 15:14 |
| pstolowski | cwayne, anyway... this is a bug | 15:14 |
| pstolowski | cwayne, can you open it against unity-scopes-shell? | 15:14 |
| cwayne | i certainly can | 15:15 |
| cwayne | pstolowski: oh its already there https://bugs.launchpad.net/unity-scopes-shell/+bug/1335761 | 15:16 |
| ubot5 | Ubuntu bug 1335761 in unity-scopes-shell "[Dash] Activating a preview with a scope URI for the current scope doesn't send you back to the results view" [High,Confirmed] | 15:16 |
| pstolowski | cwayne, yeah, this is related | 15:21 |
| === dandrader is now known as dandrader|lunch | ||
| mterry_ | Saviq, wait... your checklist commit guidelines... You did exactly what I didn't want you to do -- you are recommending a format that leaves only the summary in debian/changelog | 16:02 |
| mterry_ | Right? | 16:03 |
| mterry_ | Ah, I guess you aren't. Because this is the "Commit Message" field in the MP which all goes to the changelog, I suppose | 16:03 |
| Saviq | mterry_, that was dandrader|lunch's entry btw | 16:06 |
| mterry_ | Saviq, ah sorry, you had mentioned editing the wiki | 16:06 |
| Saviq | mterry_, and, no, it doesn't go whole to the changelog | 16:07 |
| mterry_ | Saviq, ah ok... | 16:07 |
| Saviq | mterry_, by default, in the train, it goes until the first empty line | 16:07 |
| mterry_ | Saviq, so yeah, I don't like those recommendations | 16:07 |
| Saviq | mterry_, yeah, amend it please so that it allows more verbosity | 16:08 |
| Saviq | or recommends rather than allows | 16:08 |
| === elopio_ is now known as elopio | ||
| mterry_ | Saviq, ok updated, explaining that one section goes to debian/changelog and the other doesn't, including a reminder to mention any new dependencies | 16:13 |
| * mterry_ goes to lunch | 16:15 | |
| === robru_brb is now known as robru | ||
| === om26er|dinner is now known as om26er | ||
| === gatox is now known as gatox_lunch | ||
| === gatox_lunch is now known as gatox | ||
| === john-mca` is now known as john-mcaleely | ||
| === dandrader|lunch is now known as dandrader | ||
| bregma | so, Unity8 on the desktop is dead again after today's update... no frames get rendered | 20:06 |
| bregma | any thoughts on the cause this time? | 20:06 |
| bschaefer | :( | 20:13 |
| Saviq | bregma, can you check in apt history what packages got upgraded? | 21:11 |
| bregma | Saviq, | 21:12 |
| bregma | <ChrisTownsend> bregma: These are all of the packages that got upgraded/installed when this started to occur: http://pastebin.ubuntu.com/8181861/ | 21:12 |
| bregma | Chris backed out the unity8 changes and the problem still occurred | 21:12 |
| bregma | my guess is the libreoffice and linux kernel packages are innocent | 21:13 |
| bregma | another clue is it works OK from an LXC container but not on the bare metal | 21:14 |
| bregma | anyway, we're closing for the long weekend now, we'll get back on the trail Tuesday | 21:14 |
| Saviq | bregma, I'll try and have data for you before that | 21:16 |
| bregma | cool | 21:19 |
| === irsol_ is now known as irsol | ||
| === salem_` is now known as _salem | ||
| === mhall119_ is now known as mhall119 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
