| === urulama-afk is now known as urulama | ||
| rick_h_ | morning all | 11:22 |
|---|---|---|
| frankban | morning rick_h_ | 11:22 |
| * frankban lunches | 11:40 | |
| rick_h_ | frankban: did you take a peek at the updates to the charm from hazmat? Can those be landed? (around the proxy settings) | 12:14 |
| frankban | rick_h_: yes I reviewed the branch. hazmat mentioned he want to wait for further live tests/qa before landing those. I assured my availability to do a charm release after those changes are landed | 12:16 |
| rick_h_ | frankban: ah ok, missed the waiting stuff. I added a card to tracking on that for now thanks | 12:17 |
| frankban | rick_h_: thanks | 12:17 |
| hazmat | frankban, there are some fixes post the initial pull request, let me update | 12:20 |
| hazmat | nevermind there in the merge proposal | 12:21 |
| hazmat | frankban, should i go ahead and just merge to lp:~juju-gui/charms/trusty/juju-gui/trunk ? | 12:22 |
| hazmat | or do you want a separate mp targeting that branch first | 12:22 |
| frankban | hazmat: please go ahead and merge it into the dev branch, I'll work on a charm release in the afternoon | 12:24 |
| hazmat | ugh.. i forget how slow bzr is ;-) | 12:25 |
| frankban | heh, the charm repo is pretty big also | 12:26 |
| rick_h_ | luca: do you have hover over info for https://bugs.launchpad.net/juju-gui/+bug/1360169 | 12:27 |
| mup | Bug #1360169: Hover overs are missing from most of the interface <juju-gui:Triaged> <https://launchpad.net/bugs/1360169> | 12:27 |
| rick_h_ | luca__: oh, guess this was going on yesterday, it got caught up in my email backlog and seemed longer than that | 12:27 |
| hazmat | frankban, done | 12:31 |
| frankban | hazmat: thanks | 12:32 |
| rick_h_ | frankban: after that gui charm release feel like helping wrap up MV this week? | 12:34 |
| frankban | rick_h_: sure no problem | 12:35 |
| rick_h_ | frankban: awesome | 12:35 |
| rick_h_ | hazmat: charmworld seems chugging along happier today. Is your stuff all set? | 12:35 |
| hazmat | rick_h_, yup. all good, thanks | 12:57 |
| frankban | hazmat: charm released | 14:13 |
| hazmat | frankban, danke | 14:14 |
| hazmat | er. grazie ;-) | 14:14 |
| frankban | :-) | 14:15 |
| hatch | yaaaaaaawwwwnnnnn | 14:18 |
| hatch | morning all | 14:18 |
| urulama | good morning, hatch :) | 14:18 |
| rick_h_ | morn | 14:18 |
| hatch | so glad to be back at work...needed a break from the holiday haha | 14:20 |
| rick_h_ | frankban: hatch up for a pre-standup chat? | 14:37 |
| kadams54 | hatch: per your comment on PR#523… can you point me to the HTML for the boolean checkboxes? I found some style rules for .config-field.boolean in juju-inspector.less, but am failing to find the corresponding HTML. | 14:37 |
| hatch | rick_h_: frankban sure just lemme grab my coffee, 2 mins | 14:37 |
| frankban | rick_h_: sure | 14:38 |
| rick_h_ | frankban: hatch ok, meet you in the standup room | 14:38 |
| hatch__ | rick_h_: technical difficulties, trying again | 14:42 |
| hatch__ | kadams54: service-configuration.partial or something | 14:42 |
| kadams54 | Thanks, I did look at that but wasn't 100% sure it was the right place. I'll comment further on the PR. | 14:43 |
| === hatch__ is now known as hatch | ||
| rick_h_ | jujugui call in 2 | 14:59 |
| rick_h_ | jujugui kanban away please | 14:59 |
| hatch | lol | 15:14 |
| hatch | what's martins nick? | 15:14 |
| rick_h_ | mhilton and he's not in here atm | 15:15 |
| hatch | ahh ok I see in the other channel | 15:15 |
| hatch | kadams54: is there a website somewhere which outlines 'why' your approach works? I think my feelings will be assuaged if I can read up on this technique vs the more commonly known single element one | 15:18 |
| hatch | the css is quite a bit more complex so I'm worried about future dev coming in and not knowing what's going on | 15:18 |
| kadams54 | hatch: http://code.stephenmorley.org/html-and-css/styling-checkboxes-and-radio-buttons/ | 15:18 |
| kadams54 | Covers both approaches | 15:19 |
| hatch | I should really look into how google does the paper elements stuff | 15:19 |
| hatch | they have some really cool radio/checkboxes | 15:19 |
| kadams54 | I can do some digging into that… | 15:21 |
| hatch | kadams54: ok so how about if you just put a comment in the css with this url to explain the technique? | 15:23 |
| kadams54 | hatch: sounds good. | 15:23 |
| kadams54 | I was thinking I could also add classes to the <span>s which could also clarify their purpose. | 15:24 |
| hatch | ahh yeah that could also help | 15:24 |
| hatch | it is pretty cool though | 15:25 |
| kadams54 | hatch: so… paper cheats. | 15:26 |
| kadams54 | hatch: it ditches <input> all together in favor of a combination of <div>s and a <canvas>. | 15:27 |
| hatch | animated gifs? | 15:27 |
| kadams54 | Hah, no. | 15:27 |
| hatch | oh haha, really? | 15:27 |
| hatch | interesting.... | 15:27 |
| hatch | kadams54: probably because styling inputs on mobile is le'stupid and canvas is going to be pixel perfect every time | 15:28 |
| kadams54 | hatch: https://gist.github.com/kadams54/5e52c25281b364f97b8f | 15:28 |
| kadams54 | I think they only use canvas for the ripple effect that happens when you toggle a button. | 15:28 |
| kadams54 | All the more traditional stuff is all <div>s | 15:28 |
| kadams54 | They seem to rely heavily on aria markup to make up for the lack of semantic markup. | 15:29 |
| hatch | I think that the ripple is just layered on top of whatever it's containing | 15:29 |
| kadams54 | http://www.polymer-project.org/components/paper-radio-button/demo.html | 15:29 |
| hatch | we should use these heh | 15:30 |
| hatch | so pretttttyyyy | 15:30 |
| kadams54 | hatch: Yeah, the ripple is the canvas. The button itself is just two <div>s, .offRadio and .onRadio. | 15:30 |
| kadams54 | .onRadio gets a "fill" class when active. | 15:30 |
| hatch | interesting | 15:30 |
| hatch | well in any effect, I've +1'd it | 15:30 |
| kadams54 | I suspect the animation is just CSS transitions | 15:30 |
| kadams54 | Not sure how I feel about ditching basic HTML elements all together. | 15:31 |
| hatch | yeah - I'm guessing that's because of mobile | 15:31 |
| hatch | styling input elements on mobile is really poorly supported | 15:32 |
| kadams54 | More so than on desktop? | 15:34 |
| kadams54 | I mean, we're already basically hiding the native element and then either sticking in a background image or styling some <span>s to take its place. | 15:34 |
| kadams54 | Largely because desktop browsers vary pretty widely in how (or in the case of Safari, even if) they support styling form elements. | 15:35 |
| hatch | yeah because you have to remember that there are about 1M different browsers on android | 15:35 |
| hatch | and that most are complete garbage and don't get updated....ever | 15:35 |
| kadams54 | *sigh* | 15:35 |
| hatch | it's better now with chrome on android | 15:36 |
| hatch | but I'm guessing that there are a lot of people who are still using the default browser | 15:36 |
| hatch | no whatever free phone they 'bought' :P | 15:36 |
| rick_h_ | jujugui make sure you get your travel filed. I think I approved everyone that requested. If you've not please do that and let me know if you hit issues | 15:42 |
| hatch | oh crap I forgot heh thanks | 15:42 |
| hatch | rick_h_: my flights when searching on flights.google changed $700 in one day | 15:42 |
| hatch | they went back down again | 15:42 |
| hatch | but I was like....wth | 15:42 |
| rick_h_ | hatch: then file now :P | 15:42 |
| hatch | lol | 15:43 |
| rick_h_ | I thought I approved yours :P | 15:43 |
| hatch | you did, I just guessed on the price because of that | 15:43 |
| hatch | (it's down again) | 15:43 |
| hatch | BUY BUY BUY | 15:43 |
| hatch | ehh but the flights suck.... | 15:44 |
| hatch | jujugui, just confirming, the airport is BRU ? | 15:47 |
| rick_h_ | mhilton: did you find the invite for leankit? | 15:54 |
| rick_h_ | mhilton: make sure to check the spam folder | 15:54 |
| * rick_h_ finds email to make sure he didn't typo the email addr | 15:54 | |
| kadams54 | jujugui: looking for a second review/QA on https://github.com/juju/juju-gui/pull/523 | 16:04 |
| kadams54 | rick_h_: ready to chat about constraints when you are. | 16:06 |
| rick_h_ | kadams54: k, on the phone atm but can chat later. Not sure when this one will be over | 16:07 |
| urulama | jujugui: bye, have fun | 16:51 |
| rick_h_ | urulama: have a good night | 16:51 |
| === urulama is now known as urulama-afk | ||
| rick_h_ | kadams54: call is over, want to chat now or after lunch? | 17:05 |
| kadams54 | Just getting ready to grab lunch, so after? | 17:06 |
| rick_h_ | kadams54: rgr | 17:06 |
| * rick_h_ goes to lunch | 17:06 | |
| Makyo | jujugui need some reviews and QA: https://github.com/juju/juju-gui/pull/527 (turned out way easier than I initially made it) | 17:10 |
| kadams54 | Makyo: I'll take a look | 17:11 |
| Makyo | kadams54, thanks, will look at yours as well. | 17:12 |
| hatch | lazyPower: noone wants to answer your AU question :) | 17:27 |
| hatch | probably because the answer would suck lol | 17:27 |
| hatch | ok reviews done, conflicts resolved.....now to qa again | 17:31 |
| Makyo | kadams54, good catch, I should've noticed that. | 17:49 |
| kadams54 | Makyo: np | 17:49 |
| hatch | jujugui fyi chrome's latest update adds a complex 'ssl warning' page like FF has had for a while - it's now a multi step process to dismiss | 18:01 |
| rick_h_ | hatch: :( | 18:01 |
| hatch | very | 18:02 |
| hatch | jujugui in testing my branch after pulling in the latest develop changes I can no longer place a unit on a 'root container' - is this to be expected? | 18:05 |
| hatch | I don't recall this limitation so - bug? | 18:05 |
| rick_h_ | hatch: hmm, seems like it. Can you git biset from where you're at on that one please? | 18:07 |
| hatch | yep on it, will report back | 18:07 |
| rick_h_ | hatch: ty much | 18:07 |
| hatch | could have been a bad conflict resolution here as well.. | 18:07 |
| rick_h_ | kadams54: back from lunch? | 18:13 |
| kadams54 | Yup | 18:13 |
| rick_h_ | kadams54: standup hangout? | 18:13 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1364549 | 18:13 |
| mup | Bug #1364549: Cannot destroy services with no deployed units <juju-gui:New> <https://launchpad.net/bugs/1364549> | 18:13 |
| kadams54 | rick_h_: joining | 18:13 |
| hatch | rick_h_: https://bugs.launchpad.net/juju-gui/+bug/1364558 | 18:41 |
| mup | Bug #1364558: Unable to place an unplaced unit on root container <juju-gui:New> <https://launchpad.net/bugs/1364558> | 18:41 |
| rick_h_ | hatch: k thx | 18:43 |
| rick_h_ | Makyo: hatch either of you QA kadams54 branch so it can land? | 18:47 |
| hatch | Makyo: did according to the pr | 18:47 |
| Makyo | Yes +1 | 18:47 |
| rick_h_ | Makyo: ah, looks like you did, can you add a little more on that qa note per our friday chat the other week | 18:47 |
| rick_h_ | kadams54: and this can shipit then? | 18:48 |
| Makyo | Ah, sure | 18:48 |
| rick_h_ | Makyo: ty much | 18:48 |
| kadams54 | rick_h_: yup | 19:03 |
| hatch | lunching | 19:13 |
| * rick_h_ runs away for today night all | 20:20 | |
| hatch | cya rick_h_ | 20:23 |
| hatch | jujugui lf a review and qa on https://github.com/juju/juju-gui/pull/524 plz and thanks (before something else lands and causes more conflicts :P ) | 22:18 |
| hatch | rick_h_: any preference to my next card? | 22:21 |
| huwshimi | Morning | 23:03 |
| hatch | morning huwshimi | 23:14 |
| hatch | huwshimi: if you have some time today it would be awesome if you could review and qa https://github.com/juju/juju-gui/pull/524 | 23:22 |
| huwshimi | hatch: Sure! | 23:23 |
| hatch | thanks - the code is pretty cryptic without the whole thing in your head so really the important parts are that it qa's properly :) | 23:24 |
| huwshimi | hatch: OK no problems :) | 23:24 |
| hatch | I hope we have some time after 1.0 to do some refactoring on this now that we know how it's supposed to work | 23:25 |
| hatch | we can dramatically simplify it with a rewrite ....er....refactor.....er.....enhancement :P | 23:25 |
| hatch | huwshimi: also your travel should have been approved (assuming you filed for it) rick said this morning just fyi | 23:28 |
| huwshimi | yep, just about to confirm my flight | 23:28 |
| hatch | it's going to take me 16H | 23:28 |
| hatch | how about you? :) | 23:28 |
| huwshimi | 28 | 23:29 |
| huwshimi | Might be 33 on the way back | 23:30 |
| hatch | jeesh | 23:31 |
| hatch | huwshimi: you must be really high up in your airliner frequent flyer program :) | 23:33 |
| rick_h_ | hatch: either one of the bugs (unable to place on a root container, add to my canvas not working in MV) or the limiting options based on provider or the ecs conflict work needed. | 23:53 |
| hatch | rick_h_: the add to canvas in mv is not a bug....at least I couldn't reproduce it | 23:53 |
| rick_h_ | hatch: frankban is taking up one of the issues (limiting based on provider or ecs/conflict stuff) so might see what card is taken in the morning | 23:53 |
| hatch | yeah that'll work | 23:53 |
| rick_h_ | hatch: so it works for you? You see unplaced units or machines start to appear? | 23:53 |
| hatch | machines appear | 23:54 |
| rick_h_ | oh heh yea I guess it does. wtf | 23:54 |
| hatch | I'm also not sure about the closing the inspector help text thing....what does that mean? | 23:54 |
| rick_h_ | awesome then, yay | 23:54 |
| hatch | :) | 23:54 |
| rick_h_ | hatch: so every time you close/reopen the inspector by clicking on a service you get that help text | 23:55 |
| rick_h_ | I think that after you dismis it, it should stay dismissed | 23:55 |
| rick_h_ | I figured that's more a UX front thing that we could get huwshimi or kadams54 or someone to peek at | 23:55 |
| hatch | sure | 23:55 |
| hatch | one more | 23:55 |
| hatch | q | 23:55 |
| rick_h_ | shoot | 23:56 |
| hatch | machines should not have roll over hover states - don't we want to allow them to drop on machines? | 23:56 |
| hatch | I have an unplaced unit, I drop it on a machine, it asks me to create a container....etc etc etc | 23:56 |
| rick_h_ | hatch: sure, but right now the roll overs completely hide the create machine. I was thinking that what we could do is enforce the clicking of the machine first | 23:56 |
| huwshimi | was just about to ask the same question :) | 23:56 |
| rick_h_ | and then you can drop on root container | 23:56 |
| rick_h_ | but right now no one notices the create machine/container header because as soon as you drag you run over machines and they get bright big color changes | 23:57 |
| rick_h_ | I talked to ale/luca about it this morning and they're pondering things but we agreed to start out by trying to hide the hover grey background change | 23:57 |
| rick_h_ | at least then all options are treated equal | 23:57 |
| rick_h_ | and there's less moving bits to distract you | 23:57 |
| hatch | hmm interesting... | 23:58 |
| hatch | ok thanks for clearing those up :) | 23:58 |
| rick_h_ | np, happy to entertain other ideas | 23:59 |
| hatch | I have none, I just didn't think it was an actual issue, but I see now how it could be | 23:59 |
| huwshimi | rick_h_: Maybe could you add a few more details to the card, just so whoever picks it up knows what to do? | 23:59 |
| rick_h_ | heh, it's a case of it bugged the heck out of me in QA so I made noise to UX :P | 23:59 |
| rick_h_ | huwshimi: sure thing | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!