| cwayne1 | anyone around that might be able to help me with s-jenkins permissions? | 00:28 |
|---|---|---|
| imgbot | === trainguards: IMAGE 221 building (started: 20140904 02:05) === | 02:05 |
| popey | you know it's time for bed when you see that message | 02:09 |
| imgbot | === trainguards: RTM IMAGE 15 building (started: 20140904 03:05) === | 03:05 |
| === Ursinha is now known as Ursinha-afk | ||
| robru | BLAM! https://code.launchpad.net/~robru/cupstream2distro/readability-cleanup/+merge/233284 got it down from 1234 pep8 violations to 825 (all of citrain/ directory is fixed but nothing outside of it, like cupstream2distro/ directory or tests/ directory). merged it like that for now (with the remaining 825 whitelisted) because I'm out of time. need to push | 03:08 |
| robru | this to production and make sure nothing exploded. | 03:08 |
| robru | fginther: any chance you're still around? found a bug in the autolanding job, fixed it, how can i rerun it? i reapproved the branch but it doesn't seem to be working... | 03:16 |
| === Ursinha-afk is now known as Ursinha | ||
| fginther | robru, what's the MP? | 03:17 |
| fginther | robru, https://code.launchpad.net/~robru/cupstream2distro/readability-cleanup/+merge/233284 is running right now | 03:19 |
| robru | fginther: oh ok thx, just impatient i guess | 03:19 |
| popey | fginther: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1357983/+merge/232630 | 03:25 |
| popey | that passed CI, then when I top approved it complains it failed ci? | 03:25 |
| popey | I am confused. | 03:26 |
| popey | hmm | 03:26 |
| robru | popey: the autolanding job is different than the ci job, so it's probably misconfigured or something. not sure. | 03:27 |
| popey | will look again in the morning when I am awake | 03:30 |
| popey | ta | 03:30 |
| imgbot | === trainguards: IMAGE 221 DONE (finished: 20140904 03:45) === | 03:45 |
| imgbot | === changelog: http://people.canonical.com/~ogra/touch-image-stats/221.changes === | 03:45 |
| sergiusens | thanks, will do rtm tomorrow morning | 03:48 |
| robru | sergiusens: you're welcome! | 03:50 |
| Mirv | morning | 04:05 |
| robru | Mirv: Heya! | 04:07 |
| Mirv | robru: heya heya! | 04:08 |
| robru | Mirv: i just did a massive pep8 overhaul on ci train. Shouldn't have any semantic change unless i made a mistake. Keep an eye out for goofy syntax errors when running Jenkins jobs, should be easy to fix | 04:08 |
| Mirv | robru: pep8 and funny syntax, check. | 04:09 |
| robru | I ran a few jobs already and it seemed sane, but there's lots of code paths that are just totally untested | 04:09 |
| Mirv | yeah, I see you've touched almost everything. anyway, they should be easy to fix if something is wrong. | 04:10 |
| robru | Mirv: yeah ;-) | 04:10 |
| robru | Mirv: not done yet! I fixed about 400 out of 1200 pep8 violations. Will try to get the rest tomorrow | 04:11 |
| Mirv | robru: ok, a jolly amount of things to fix, there | 04:13 |
| imgbot | === trainguards: RTM IMAGE 15 DONE (finished: 20140904 04:20) === | 04:20 |
| imgbot | === changelog: http://people.canonical.com/~ogra/touch-image-stats/rtm/15.changes === | 04:20 |
| === tvoss is now known as tvoss|test | ||
| === tvoss|test is now known as tvoss | ||
| brendand | thostr_, hello | 07:20 |
| thostr_ | brendand: hi | 07:20 |
| sil2100 | eh, need to do an emergency drive to the vet, I should be back for the meeting | 07:34 |
| Mirv | :( | 07:37 |
| brendand | thostr_, i'm hoping to sign off silo 13 soon | 07:42 |
| brendand | thostr_, for the new stuff it lands, did you or charles add a test case to the test plan? | 07:43 |
| sil2100 | Back | 08:06 |
| bzoltan | Mirv: sil2100: I am done with the UITK validation. All test logs are backed up, the UITK does not cause any regression. I have pulled out the header animation because that would have caused psorblems for few tests. | 08:09 |
| bzoltan | Mirv: sil2100: So the UITK for Ubuntu archive in silo12 is good to go. When it lands I will start the RTM testing. | 08:10 |
| sil2100 | bzoltan: excellent! | 08:10 |
| sil2100 | Mirv: did you press the publish button on it already? ;) | 08:10 |
| sil2100 | Mirv: ok, let me handle the pressing | 08:11 |
| sil2100 | bzoltan: just a quick one - the merges need approval :) | 08:11 |
| sil2100 | bzoltan: re running ;) | 08:14 |
| sil2100 | bzoltan: publishing o/ | 08:14 |
| sil2100 | Thanks again for the hard work! | 08:15 |
| bzoltan | sil2100: cool, thanks | 08:15 |
| bzoltan | sil2100: it was not hard :) hard is running a marathon :) it was just long. | 08:15 |
| Mirv | bzoltan: good stuff! | 08:22 |
| Mirv | sil2100: thanks! | 08:22 |
| sil2100 | bzoltan: yeah ;) But it takes up precious time and resources anyway | 08:23 |
| Mirv | bzoltan: sil2100: might not be anything dangerous, but err zoltan launched non-rtm new build 20 mins ago in landing-012? and that not-yet-built rebuild was actually what got published? | 08:25 |
| Mirv | while the rtm silo build is from yesterday | 08:25 |
| bzoltan | Mirv: that was my testing script change | 08:25 |
| bzoltan | Mirv: I added the -p archive handling to make the stock image testing possible | 08:26 |
| Mirv | bzoltan: aha, right. still, it wasn't finished yet in the PPA so now it got copied not completely built. a smoke-test would have been nice too, but well, indeed the change is nothing to worry about! | 08:26 |
| bzoltan | Mirv: I got the message that the build was successful... | 08:27 |
| bzoltan | Mirv: strange | 08:27 |
| * ogra_ gets meeting coffee | 08:27 | |
| Mirv | and there is some non-true dependency wait now in the archive build :S https://launchpad.net/ubuntu/utopic/+source/ubuntu-ui-toolkit/1.1.1227+14.10.20140904-0ubuntu1 | 08:27 |
| Mirv | let's see... | 08:27 |
| Mirv | sil2100: ^ bzoltan is btw right, he did get utopic "Packages built" from the bot basically right after clicking build. | 08:28 |
| Mirv | that might be a regression on how the "built" status is fetched, related to the sync silo fixing | 08:28 |
| sil2100 | Damn | 08:29 |
| sil2100 | Mirv: we didn't change how the build status is fetched | 08:29 |
| Mirv | anyway, we've a meeting to do so let's see after that if the archive builds have started themselves :) | 08:29 |
| Mirv | sil2100: it says "building" and then Finished: SUCCESS.. eh. https://ci-train.ubuntu.com/job/ubuntu-landing-012-1-build/37/console | 08:29 |
| sil2100 | Mirv: this is the thing we mentioned, either something changed in LP API or something... we even made it more restrictive because of problems like this and it didn't help :| | 08:30 |
| sil2100 | ygh | 08:31 |
| sil2100 | Wait | 08:31 |
| bzoltan | Mirv: I was a bit surprised, but I thought that the builders are on steroid... in pbuilder the armhf takes 20minutes | 08:31 |
| sil2100 | THis one is just wrong | 08:31 |
| Mirv | sil2100: yeah, it's not even that, it's just wrong :) | 08:31 |
| bzoltan | sil2100: it is indeed wrong | 08:31 |
| thostr_ | brendand: that was mostly bug fixes | 08:31 |
| thostr_ | brendand: so, test plan hasn't changed | 08:32 |
| brendand | thostr_, there was something about hardware alarm support? | 08:32 |
| thostr_ | brendand: but silo 13 is about power changes | 08:34 |
| brendand | thostr_, i'm looking at the changelog | 08:34 |
| thostr_ | brendand: that was mostly about displaying the right icons depending on the power level | 08:34 |
| brendand | thostr_, sorry - it's powerd 'hardware wakeup support' | 08:35 |
| Mirv | robru: we might have some small regressions from the changes :) | 08:35 |
| jibel | I know that utopic-proposed is not the focus, but I cannot unlock a SIM card on 221 and that'll probably land in ubuntu-rtm soon. | 08:37 |
| jibel | on mako | 08:38 |
| thostr_ | brendand: ah right. I'd need to check whether charles has updated it | 08:53 |
| thostr_ | brendand: there is no specific test case for that. Actually, I think we're missing a holistic alarms test plan (which covers multiple components) | 08:56 |
| thostr_ | brendand: do we have other examples of such kind of integration tests? | 08:57 |
| brendand | thostr_, i'm sure there are plenty of examples :) | 09:02 |
| thostr_ | brendand: sure, but where? | 09:02 |
| brendand | thostr_, not written down anywhere that i know of | 09:03 |
| brendand | thostr_, there must be a test plan for alarms in one of the applications or indicators | 09:03 |
| brendand | thostr_, you should probably link to that | 09:03 |
| thostr_ | or we just create an alarms test plan which we then reference in indicator, powerd, clock app, PIM, ... | 09:05 |
| bzoltan | Mirv: great to see that I can use the rtm images just as the utopic images... so i can add PPAs and stuff :) cool | 09:05 |
| brendand | thostr_, sure - but i'm just saying that other test plans might already have those test cases, so if you look there you might get some inspiration | 09:06 |
| brendand | Mirv, oh is citrain script fixed? | 09:06 |
| Mirv | bzoltan: !! nice, it was annoying | 09:07 |
| Mirv | brendand: which script? | 09:07 |
| brendand | Mirv, what's bzoltan talking about? | 09:07 |
| bzoltan | Mirv: one thing i do not get thu .. the RTM and non RTM PPAs | 09:07 |
| Mirv | sil2100: bzoltan: I found the dependency problem, we need a package promoted to main -> moving to #ubuntu-release | 09:07 |
| Mirv | brendand: oh, you mean that.. yes, bzoltan did new fixes to his testing script | 09:08 |
| john-mcaleely | new krillin tarball pushed | 09:08 |
| brendand | Mirv, okay - i'm just curious to know if anyones hacked together a simple way to add silos | 09:08 |
| bzoltan | brendand: adding silos to what? | 09:09 |
| ogra_ | john-mcaleely, thanks ! | 09:10 |
| popey | davmor2: do you have a clean phone you can test my dialer issue on? | 09:10 |
| popey | (on that hasn't made any calls) | 09:10 |
| brendand | bzoltan, "great to see that I can use the rtm images just as the utopic images... so i can add PPAs and stuff :) cool" - what did you mean? | 09:10 |
| sil2100 | Mirv: wait, what? Oh man, the packaging changes didn't have any new dependencies added | 09:10 |
| sil2100 | Mirv: actually there was no UITK packaging diff | 09:11 |
| bzoltan | brendand: during tha last RTM validation the add-apt-repository did not work on RTM images | 09:11 |
| Mirv | sil2100: or, maybe this happened already before and we don't catch them before manual rebuilds in archive? | 09:11 |
| Mirv | oh my | 09:11 |
| davmor2 | popey: no but I will do when I comme back at 11 | 09:11 |
| popey | kk | 09:11 |
| Mirv | bzoltan: sil2100: qml-module-qt-labs-settings is in universe | 09:11 |
| popey | will file bug, not done yet | 09:11 |
| Mirv | but comes from a main source package | 09:11 |
| sil2100 | Mirv: or maybe that was that additional test change that bzoltan did? | 09:11 |
| Mirv | sil2100: no, it wasn't | 09:12 |
| bzoltan | sil2100: no, I just fixed my shells cript what does the test plan | 09:12 |
| sil2100 | bzoltan: ok, so it must have been around for longer | 09:12 |
| Mirv | https://launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/1.1.1214+14.10.20140826-0ubuntu1 also had the dep already | 09:12 |
| sil2100 | hmm, why we didn't get any MIR here... | 09:13 |
| Mirv | sil2100: binary packages from approved main source packages are moved to main on request | 09:13 |
| Mirv | in general | 09:13 |
| brendand | bzoltan, yes that's right - what did you do to fix that? | 09:17 |
| bzoltan | brendand: :) i did not do anything. It just works now :) | 09:19 |
| Mirv | so apt-add-repository now works on rtm too | 09:21 |
| brendand | Mirv, hmm interesting. i haven't seen any movement on those bugs | 09:23 |
| brendand | psivaa, i have a device freshly flashed with -proposed now | 09:23 |
| brendand | psivaa, what steps does the ci loop go through? | 09:23 |
| psivaa | brendand: if you haven't used the provision.sh script in lp:ubuntu-test-cases/touch then it might be more manual work. i'd rather do 'scripts/provision.sh -i touch_stable -w' from the branch | 09:29 |
| psivaa | http://bazaar.launchpad.net/~ubuntu-test-case-dev/ubuntu-test-cases/touch/view/head:/README-cli.rst has information too | 09:29 |
| brendand | bzoltan, em - you better be careful. our testing shows it adds the wrong ppa | 09:35 |
| brendand | bzoltan, i.e. the utopic one | 09:35 |
| bzoltan | brendand: Well.. that was one question I asked ... what is the diff between the rtm and non rtm PPAs... because on the PPA page they are the same | 09:35 |
| bzoltan | brendand: Mirv: sil2100: RTM -> https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu-rtm/landing-012 | 09:36 |
| psivaa | brendand: dont forget to include your network file in provision.sh (for magners-wifi) | 09:36 |
| bzoltan | brendand: Mirv: sil2100: NON RTM -> https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-012 | 09:36 |
| sil2100 | bzoltan: yeah, so LP doesn't yet properly update the description :| | 09:36 |
| ogra_ | bzoltan, rtm binaries are built against the rtm archive ... | 09:36 |
| bzoltan | brendand: Mirv: sil2100: and in both cases the PPA is ppa:ci-train-ppa-service/landing-012 | 09:36 |
| sil2100 | bzoltan: but anyway, you need to use ppa:ci-train-ppa-service/ubuntu-rtm/landing-012 for RTM | 09:37 |
| bzoltan | sil2100: OK, thanks | 09:37 |
| sil2100 | bzoltan: although apt-add-repository won't work, so I guess brendand always adds the PPA manually | 09:37 |
| sil2100 | :< | 09:37 |
| sil2100 | Oh geez | 09:42 |
| * sil2100 just saw what happened to the citrain code | 09:43 | |
| sil2100 | I mean, visually | 09:43 |
| sil2100 | It now looks terribly on my sublime editor | 09:43 |
| Mirv | sil2100: brendand: should we maybe get QA signoff also for the utopic mediascanner2/thumbnailer landing, because of the past regressions? | 09:55 |
| popey | psivaa: could you (or someone else?) trigger ci for the "update components" merges from akiva at the bottom of this list please? http://people.canonical.com/~dpm/core-apps-sponsoring/ - he's not in the teams so it didn't trigger automatically... | 09:57 |
| brendand | Mirv, technically no - since we aren't in traincon for utopic - are we? | 10:02 |
| psivaa | popey: akiva is added to allowed users now in core app jenkins | 10:02 |
| popey | thank you. will that magically autotrigger? | 10:02 |
| === psivaa changed the topic of #ubuntu-ci-eng to: Train support: trainguards | Vanguard: psivaa | Train Dashboard: http://bit.ly/1mDv1FS | QA Signoffs: http://bit.ly/1qMAKYd | Known Issues: ♫ I feel more awesome than an awesome possum ♫" | ||
| brendand | sil2100, add-apt-repository ppa:ci-train-ppa-service/ubuntu-rtm/landing-012 doesn't work | 10:03 |
| psivaa | popey: yes, it should | 10:04 |
| davmor2 | popey: right wiping in progress did you file a bug in the end? | 10:07 |
| brendand | sil2100, so far the only way we know that works is adding by hand. if you know an automated way it would be really good to hear | 10:08 |
| popey | davmor2: bug 1365400 | 10:08 |
| ubot5 | bug 1365400 in dialer-app (Ubuntu) ""Recent" pull-up confusing on new phone" [Undecided,New] https://launchpad.net/bugs/1365400 | 10:08 |
| popey | psivaa: thanks | 10:08 |
| * brendand could probably whip something up with launchpadlib | 10:08 | |
| sil2100 | brendand: yeah, so as I said | 10:12 |
| Mirv | brendand: yeah. I'll just try it a bit on my own. | 10:13 |
| davmor2 | sil2100: right fresh Wipe I'm going to see if reboots re show the wizard | 10:15 |
| davmor2 | popey: no joy but there is an update to the recent page that might be stopping it now | 10:18 |
| davmor2 | popey: you now get all and missed | 10:18 |
| popey | davmor2: you can't reproduce it? | 10:18 |
| popey | on krillin ? | 10:19 |
| davmor2 | popey: not on current image I can't | 10:19 |
| popey | well thats odd | 10:19 |
| popey | you have a SIM in it? | 10:19 |
| davmor2 | popey: yes | 10:20 |
| popey | ah well | 10:20 |
| sil2100 | brendand: how's the AP-test going? | 10:20 |
| davmor2 | popey: as I say there was an update to the recent page that may be stopping it now | 10:20 |
| brendand | sil2100, still in progress | 10:21 |
| davmor2 | popey: did you have the all missed in the gap at the top when you first saw the issue? | 10:21 |
| popey | davmor2: right, but i dont see how you can have different dialer-app if we're on the same image | 10:22 |
| popey | https://www.youtube.com/watch?v=ubrTjVKU6eM | 10:23 |
| brendand | psivaa, sil2100 - provision.sh ran and the wizard is still there | 10:32 |
| brendand | psivaa, sil2100 - http://paste.ubuntu.com/8232013/ | 10:32 |
| sil2100 | uh | 10:33 |
| psivaa | brendand: ok, 'phablet-config welcome-wizard --disable' does not work then | 10:33 |
| psivaa | ? | 10:33 |
| brendand | psivaa, does it need to reboot? | 10:33 |
| psivaa | brendand: 1 sec | 10:34 |
| lool | sil2100: hey, robru has reset silo 10 yesterday, but it still lists packages and seems to be confused | 10:35 |
| lool | sil2100: all is merged (by hand) though; I'll delete the packages from the PPA or can you reset the state of the silo in a harder way? | 10:36 |
| brendand | psivaa, after i reboot the wizard is gone - but should provision.sh have done that? | 10:36 |
| psivaa | brendand: no, the device reboot is part of running a particular test | 10:37 |
| brendand | psivaa, ok | 10:37 |
| sil2100 | lool: hey! Let me take a look | 10:38 |
| psivaa | brendand: 'scripts/run-autopilot-tests.sh -a mediaplayer_app' should start the AP testing | 10:39 |
| lool | does someone have the lp snippets for creating RTM PPAs? | 10:39 |
| sil2100 | lool: yeah, I have some | 10:39 |
| brendand | psivaa, where is reboot-and-unlock.sh? | 10:40 |
| sil2100 | lool: if you want to create an RTM PPA for a team, then use: lp.people['some-team'].createPPA(distribution=lp.distros['ubuntu-rtm'], name='thename') | 10:40 |
| lool | thanks | 10:40 |
| sil2100 | lool: btw. silo 10... did you merge in all the changes by hand already? | 10:41 |
| lool | sil2100: yes | 10:41 |
| psivaa | brendand: http://bazaar.launchpad.net/~ubuntu-test-case-dev/ubuntu-test-cases/touch/files/head:/utils/host/ | 10:41 |
| sil2100 | lool: and all packages in the archive, right? (double confirming) | 10:42 |
| sil2100 | lool: if yes, then I clean the silo :) | 10:42 |
| sil2100 | (I assume so) | 10:44 |
| sil2100 | lool: ok, so I do a silo clean without processing merges | 10:44 |
| lool | sil2100: all in the archive | 10:44 |
| brendand | psivaa, what runs phablet-config writable-image? | 10:45 |
| * sil2100 off to lunch | 10:46 | |
| davmor2 | sil2100: so I'm on reboot number 4 no sign of the wizard on 16 | 10:47 |
| psivaa | brendand: the -w flag in provison.sh: | 10:47 |
| psivaa | psivaa:touch$ grep -wr "phablet-config writable-image" | 10:47 |
| psivaa | scripts/provision.sh: phablet-config writable-image $CUSTOMIZE | 10:47 |
| davmor2 | sil2100: do you know if rsalveti and kenvandine were disabling the wizard with phablet-config? | 10:48 |
| === om26er_ is now known as om26er | ||
| brendand | psivaa, ah do you guys set that normally? | 10:49 |
| popey | psivaa: https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1357983/+merge/232630 runs fine on my desktop but fails in jenkins.. any ideas? | 10:50 |
| brendand | psivaa, can you show me the call to provision.sh that jenkins uses? | 10:53 |
| psivaa | popey: the failing ones are, touch and mako jenkins jobs. on desktop (amd64) it passes in jenkins too | 10:54 |
| psivaa | brendand: in http://dev-jenkins.ubuntu-ci:8080/job/utopic-touch_stable-krillin-smoke-daily/64/consoleText : | 10:55 |
| psivaa | touch/scripts/provision.sh -i touch_stable -w | 10:55 |
| === MacSlow is now known as MacSlow|lunch | ||
| brendand | psivaa, ok i'll try that now | 10:56 |
| brendand | psivaa, now we'll see | 10:58 |
| psivaa | brendand: ack. did you change the network file information in provision script? | 10:59 |
| brendand | psivaa, yep i specified -n | 11:00 |
| psivaa | brendand: ack | 11:00 |
| popey | psivaa: sorry, I don't understand | 11:01 |
| psivaa | popey: the failing jenkins jobs are: https://jenkins.qa.ubuntu.com/job/generic-click-autopilot-utopic-touch/343/? and http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/484 which are not running on the desktop. but jenkins results for desktop arch is passing as it does to you locally | 11:07 |
| psivaa | popey: so i'd think running the test on mako locally would help | 11:08 |
| popey | psivaa: ok. | 11:08 |
| cjwatson | psivaa: Is there a way I can retrigger CI on https://code.launchpad.net/~mvo/click/lp1219912-build-exclude/+merge/219716 ? The rebuild link (http://s-jenkins.ubuntu-ci:8080/job/click-devel-ci/2/rebuild) has apparently expired or something and now gives me a 404 | 11:37 |
| psivaa | cjwatson: let me check | 11:37 |
| cjwatson | (and yes, I'm on the right VPN | 11:37 |
| cjwatson | ) | 11:37 |
| psivaa | cjwatson: because the first job ran a little while ago and somehow the old builds in this job have been cleaned, we are unable to retrigger the build. | 11:45 |
| psivaa | cjwatson: i have now triggered a build with the info from MP | 11:45 |
| psivaa | cjwatson: should work. but i'll keep a watch | 11:45 |
| psivaa | hmm that has thrown a conflict in the merge | 11:47 |
| sil2100 | brendand: so, any luck with the autopilot problem ;/ ? | 11:47 |
| psivaa | cjwatson: could the conflict resolved and committed to the MP? that should trigger a build automatically too | 11:47 |
| sil2100 | brendand: it's the wizard's fault? | 11:47 |
| === ubot5` is now known as ubot5 | ||
| === psivaa changed the topic of #ubuntu-ci-eng to: Train support: trainguards | Vanguard: cihelp | Train Dashboard: http://bit.ly/1mDv1FS | QA Signoffs: http://bit.ly/1qMAKYd | Known Issues: ♫ I feel more awesome than an awesome possum ♫" | ||
| === om26er is now known as om26er|afk | ||
| === MacSlow|lunch is now known as MacSlow | ||
| Mirv | sil2100: could you see/ack landing-014 packaging changes? I tested a bit locally since it's thumbnailer again, music/video seemed fine also after reboot | 12:14 |
| sil2100 | Mirv: let me take a look - I wouldn't require a formal QA sign-off for that, but yeah, good that you're trying to proceed safely ;) | 12:14 |
| sil2100 | Mirv: packaging wise it looks ok, so a +1 | 12:19 |
| sil2100 | Mirv: I also see that thumbnailer does not include any new deps, so it should be fine :) | 12:20 |
| sil2100 | plars: hey! | 12:22 |
| sil2100 | brendand: ping | 12:26 |
| === cjwatson_ is now known as cjwatson | ||
| cjwatson | psivaa: thanks for whatever you did there | 12:28 |
| psivaa | cjwatson: np :), had to manually copy to the fields in 'Build' since 'Rebuild' dint work. | 12:29 |
| cjwatson | psivaa: if you could do the same for https://code.launchpad.net/~mvo/click/framework-info/+merge/220199, or tell me how to do it, that'd be lovely | 12:31 |
| Mirv | sil2100: thanks! | 12:31 |
| ogra_ | brendand, did you get anywhere yet ? | 12:32 |
| ogra_ | looking at thw wizard upstart job i see a "stop" at the top of the pre-start script ... i wonder if thats shouldnt be "{ stop; exit 0; }" instead ... | 12:33 |
| psivaa | cjwatson: it's filling 'landing_candidate', 'merge_proposal' and 'candidate_revision' with the information 'bzr+ssh://ps-jenkins@bazaar.launchpad.net/~mvo/click/framework-info', 'https://code.launchpad.net/~mvo/click/lp1360582-honor-enum-only-trusted/+merge/233001' and '507' in 'Build now' option. | 12:35 |
| psivaa | cjwatson: i've done it for the above now. | 12:35 |
| psivaa | and that merge has no conflicts, so it should go well | 12:36 |
| brendand | sil2100, ogra_ - i see 'scripts/run-autopilot-tests.sh: 104: scripts/run-autopilot-tests.sh: subunit2junitxml: not found' | 12:36 |
| brendand | maybe i need to install that though | 12:37 |
| ogra_ | brendand, well, but why would that have any influence on the wizard | 12:37 |
| brendand | ogra_, it doesn't - just it's the only issue i see so far with -proposed | 12:38 |
| brendand | ogra_, everything seems fine from here | 12:38 |
| ogra_ | oh, so you couldnt reproduce ? | 12:38 |
| ogra_ | i thought oyu could | 12:38 |
| cjwatson | psivaa: thanks | 12:40 |
| sil2100 | brendand: so you couldn't reproduce the issue we're seeing yet? | 12:43 |
| brendand | sil2100, i wonder could it have something to do with phablet-tools? | 12:44 |
| brendand | perhaps i should update that and check again | 12:45 |
| plars | sil2100: hi, good morning | 12:45 |
| ogra_ | plars, we're desparately trying to find out why krillin rtm doesnt unlock | 12:48 |
| ogra_ | (since image 14) | 12:48 |
| === charles_ is now known as charles | ||
| kenvandine | if i rebuild rtm silo 3 (line 11) will that grab the latest packages from utopic? | 13:07 |
| kenvandine | it includes fixes for the bugs that kept it from passing QA before, but it also includes much more | 13:07 |
| sil2100 | Mirv: still trying to figure out what is broken with the build jobs, but something is reproducibly broken - the watch-ppa script only runs once | 13:08 |
| === josepht changed the topic of #ubuntu-ci-eng to: Train support: trainguards | Vanguard josepht | Train Dashboard: http://bit.ly/1mDv1FS | QA Signoffs: http://bit.ly/1qMAKYd | Known Issues: ♫ I feel more awesome than an awesome possum ♫" | ||
| sil2100 | Mirv: but at least I confirmed now that the refactoring is the source of the problem - reverting it fixed stuff for proposed | 13:13 |
| sil2100 | robru: ^ | 13:13 |
| kenvandine | sil2100, see my question about rtm silo 3? | 13:14 |
| sil2100 | kenvandine: hey! Let me take a look | 13:15 |
| kenvandine | sil2100, i think the bugs that made it fail QA are fixed in utopic now | 13:15 |
| kenvandine | can i just rebuild that silo ? | 13:15 |
| sil2100 | kenvandine: so, the feature of sync silos retargetting ubuntu automatically is currently not yet deployed as we have some problems there, so we probably have to retarget the silo to utopic instead | 13:15 |
| sil2100 | kenvandine: let me just do that :) | 13:16 |
| sil2100 | kenvandine: you'll get a new silo probably | 13:16 |
| kenvandine | ok, thx | 13:16 |
| sil2100 | kenvandine: you want both unity8 and u-s-s from utopic, right? | 13:16 |
| kenvandine | i think unity8 has to go with it... but can you keep the current unity8? | 13:17 |
| kenvandine | not sure what else might have landed | 13:17 |
| sil2100 | Ouch | 13:17 |
| sil2100 | Crap, ok, too late :| | 13:17 |
| kenvandine | no worries | 13:17 |
| kenvandine | probably fine :) | 13:17 |
| davmor2 | Saviq: we have a problem with silo 007 | 13:39 |
| Saviq | davmor2, hit me | 13:39 |
| davmor2 | Saviq: the phone never seems to time out and suspend after running 3 alarms, So it looks like the nested code might of crashed something | 13:40 |
| davmor2 | Saviq: phone has been on the apps screen now for about 10minutes | 13:40 |
| davmor2 | apps scope even | 13:41 |
| Saviq | davmor2, huuumph, that's unexpected | 13:41 |
| cyphermox_ | kenvandine: hey, were you planning a landing today for u-s-s that my merge could go in with? :) | 13:42 |
| kenvandine | cyphermox_, i already have your branch in a silo :) | 13:42 |
| Saviq | davmor2, the code there has nothing to do with any suspend logic :| | 13:42 |
| cyphermox_ | kenvandine: cool | 13:42 |
| Saviq | davmor2, as it's unity-system-compositor that deals with that now | 13:42 |
| davmor2 | Saviq: only crashes are mtp, trust store and location so there is no powerd being killed | 13:42 |
| davmor2 | Saviq: and this only happened after the 3 alarms went off, prior to that it suspended | 13:43 |
| Saviq | davmor2, looks to me like something's holding the screen on cookie | 13:43 |
| Saviq | davmor2, AlbertA, is there any way to query the display state (and reason)? | 13:44 |
| Saviq | AlbertA, like to check what's keeping the display on? | 13:44 |
| asac | sil2100: can you confirm that lool's silo for the location stuff made it into rtm? | 13:47 |
| lool | asac: it did not (yet) | 13:48 |
| sil2100 | asac: no, it's not yet tested | 13:48 |
| lool | exactly | 13:48 |
| sil2100 | asac: but the silo has some packages in it | 13:48 |
| asac | lool: run with it please | 13:49 |
| asac | we are unblocked once this is in | 13:49 |
| asac | for custom | 13:49 |
| asac | sil2100: tx | 13:49 |
| Mirv | sil2100: ok. it must be something delicate, possibly in version number handling / storage or something. | 13:51 |
| sil2100 | Mirv: it seems to be something with the PPA package fetching, parts that weren't touched in ages o_I | 13:51 |
| sil2100 | Mirv: i.e. the PackageInPPA class | 13:52 |
| === om26er|afk is now known as om26er | ||
| Mirv | sil2100: the only thing I see there in http://pastebin.ubuntu.com/8233668/ is that it introduces a new variable 'packages', but it shouldn't probably clash with anything? maybe a bit longer name would be better anyway | 14:02 |
| sil2100 | Mirv: doesn't look like it, I'm trying to sniff around for the cause still | 14:03 |
| didrocks | - if not packages_not_in_ppa and not packages_building and not packages_failed: | 14:05 |
| didrocks | + if not (packages_not_in_ppa and packages_building and packages_failed): | 14:05 |
| didrocks | that's obivously wrong | 14:05 |
| didrocks | obviously* | 14:05 |
| didrocks | if not (A OR B) == if not A and not B | 14:06 |
| didrocks | when refactoring for pep8 is nice, people should still be careful | 14:06 |
| sil2100 | Damn, Robert..! | 14:06 |
| sil2100 | didrocks: hah, love your keen eye for those ;) | 14:06 |
| didrocks | sil2100: peer review would have avoided that, I bet :) | 14:07 |
| Saviq | davmor2, is it reproducible? can you give me steps to repro? | 14:07 |
| sil2100 | didrocks: yeah, well, I would probably moan about it if I was to review the code, as I don't like the refactoring - in my opinion it makes the code less readable | 14:07 |
| sergiusens | ah, de morgan | 14:08 |
| didrocks | sil2100: same here… and it screws as well bzr blame | 14:08 |
| didrocks | sil2100: but review the code… keep telling you that :p | 14:08 |
| didrocks | and offered my help multiple times | 14:08 |
| didrocks | anyway, another topic | 14:08 |
| sil2100 | didrocks: yeah, well, it was robru's change anyway and I wasn't asked for a review ;) | 14:08 |
| sil2100 | It was happening during my night too! Couldn't even notice! | 14:09 |
| didrocks | sil2100: pushing the change | 14:09 |
| davmor2 | Saviq: I can reboot and see if I have the same issue. But basically I installed the silo set three alarms for the same time let the phone suspend the 3 alarm notifications display I dismissed all three and that was it in that state | 14:09 |
| sil2100 | didrocks: thanks :) | 14:09 |
| didrocks | yw :) | 14:09 |
| * sil2100 gets back to rebasing his branches in progress to the recent changes | 14:09 | |
| sil2100 | It's also another thing that such changes make much more complicated | 14:10 |
| seb128 | sil2100, how come it's fine that robru (or others) commit changes to production code without review? | 14:10 |
| seb128 | that seems buggy | 14:10 |
| sil2100 | seb128: yeah, we need to get this sorted out - normally other than bugfix changes have a test-period in preprod too, which didn't happen here | 14:12 |
| didrocks | seb128: and I think especially when you didn't author the code and the author keeps proposing about reviewing the changes :) | 14:12 |
| didrocks | sil2100: pushed btw | 14:14 |
| Saviq | davmor2, that sounds totally unrelated to what the silo brings... I'll try out here | 14:14 |
| davmor2 | Saviq: the three alarms tests the nest notifications right? | 14:14 |
| davmor2 | nested even | 14:15 |
| davmor2 | Saviq: after reboot screen blanks I'll trigger the three alarms again | 14:15 |
| Saviq | davmor2, no | 14:16 |
| Saviq | davmor2, nested prompts are when you go to a paid app not having an U1 account | 14:17 |
| Saviq | davmor2, then the pay ui displays and triggers the account prompt | 14:17 |
| Saviq | davmor2, see https://wiki.ubuntu.com/Process/Merges/TestPlan/pay-service | 14:17 |
| Saviq | davmor2, there's nothing like "nest notifications" | 14:18 |
| davmor2 | Saviq: hmm okay, in that case a found a different bug | 14:20 |
| davmor2 | Saviq: you know you only set unity8 as things to test though right hence the confusion nested prompt the only thing I could think of was it was a proper fix for the multiple notifications :( | 14:21 |
| bzoltan | sil2100: could you help me to understand what blocks the UITK here http://people.canonical.com/~ubuntu-archive/proposed-migration/update_excuses.html ? | 14:26 |
| bzoltan | Mirv: ^ | 14:26 |
| sil2100 | bzoltan: yeah, so it's what Mirv mentioned in the morning... | 14:27 |
| sil2100 | bzoltan: we need qml-module-qt-labs-settings to be included in main :| | 14:27 |
| bzoltan | sil2100: What that `out of date` means and who will do what and when? | 14:27 |
| bzoltan | sil2100: and who should/could do that? | 14:28 |
| sil2100 | bzoltan: because of the bug in CI Train the packages got pushed to the archive as source packages, so they started building there... and there it popped up that we're missing a package in main to actually correctly build it | 14:28 |
| sil2100 | bzoltan: Mirv poked on -release, not sure if he got any news on that | 14:28 |
| sil2100 | Mirv: ^ ? | 14:28 |
| sil2100 | bzoltan: we need to fill in a MIR for it | 14:29 |
| sil2100 | Not sure if Mirv did that | 14:29 |
| sil2100 | Let me make sure | 14:29 |
| bzoltan | sil2100: I have no idea what MIR is | 14:29 |
| sil2100 | bzoltan: Main Inclusion Request | 14:29 |
| sil2100 | bzoltan: anyway, we'll have to do that if anything... it was an old issue that was not noticed since we build all packages in the silos usually, and those don't have those blockades :| | 14:30 |
| bzoltan | sil2100: who should/could do that? | 14:30 |
| sil2100 | bzoltan: ok, I see we don't need a MIR probably | 14:33 |
| sil2100 | Let me re-ping someone | 14:33 |
| === Ursinha changed the topic of #ubuntu-ci-eng to: Train support: trainguards | Vanguard: Ursinha | Train Dashboard: http://bit.ly/1mDv1FS | QA Signoffs: http://bit.ly/1qMAKYd | Known Issues: ♫ I feel more awesome than an awesome possum ♫" | ||
| === Kaleo_ is now known as Kaleo | ||
| bzoltan | sil2100: I am happy to do whatever it takes. just ping me if I need to fill something or do something. | 14:35 |
| sil2100 | bzoltan: hah, ok, that was fast ;) | 14:37 |
| Saviq | davmor2, I'm looking at rtm#16 without silo 7, same behavior | 14:37 |
| Saviq | davmor2, whatever woke up the phone for the alarms is holding the display on | 14:38 |
| Saviq | davmor2, you can see by going "powerd-cli display on", if nothing held the screen on, it'd be cookie 0 (or 1, don't remember) | 14:38 |
| davmor2 | charles: ^ | 14:38 |
| Saviq | davmor2, it's cookie 3 for me | 14:38 |
| cjwatson | sil2100,bzoltan: it's done; builds should auto-retry in a bit (publisher plus half-hourly cron job) | 14:39 |
| davmor2 | Saviq: no worries I'll carry on testing now then, thanks for the help debugging though | 14:39 |
| davmor2 | pmcgowan, bfiller: is there a reason that notes is still in the image I thought it was being dropped? | 14:41 |
| pmcgowan | davmor2, we are currently discussing, will probably drop it fro image and CI | 14:45 |
| lool | would someone have the snippet for uploading to RTM PPAs? | 14:47 |
| ogra_ | [ubuntu-rtm] | 14:49 |
| ogra_ | fqdn= upload.ubuntu.com | 14:49 |
| ogra_ | method= ftp | 14:49 |
| ogra_ | incoming= /ubuntu-rtm | 14:49 |
| ogra_ | login= anonymous | 14:49 |
| ogra_ | lool, ^^ | 14:49 |
| lool | ogra_: does that work with PPAs? | 14:50 |
| ogra_ | lool, ah, no ... that needs extra runes ... i just modified my ppa entry in dput.cf | 14:50 |
| ogra_ | [ppa] | 14:50 |
| ogra_ | fqdn= ppa.launchpad.net | 14:50 |
| ogra_ | method= ftp | 14:50 |
| ogra_ | #incoming= ~%(ppa)s/ubuntu | 14:50 |
| ogra_ | incoming= ~%(ppa)s | 14:50 |
| ogra_ | login= anonymous | 14:50 |
| ogra_ | .... | 14:50 |
| ogra_ | needs the ubuntu dropped there | 14:51 |
| bzoltan | cjwatson: thank you | 14:52 |
| davmor2 | ogra_: you know they invented this thing call paste.ubuntu.com to save flooding channels ;) | 14:52 |
| bzoltan | sil2100: I am in the middle of the RTM validation, so no problem yet | 14:52 |
| ogra_ | davmor2, thats boring and wouldnt annoy you as much :P | 14:52 |
| ogra_ | (sorry) | 14:52 |
| davmor2 | ogra_: hahaha | 14:53 |
| cjwatson | lool: the dput in trusty-proposed/utopic doesn't need manual changes there | 14:53 |
| lool | I'm using dput-ng actually | 14:54 |
| lool | since a couple of weeks | 14:54 |
| cjwatson | ah, somebody should probably update that, since I didn't | 14:54 |
| ogra_ | oh, so modern ! | 14:54 |
| lool | I think I was subject to propaganda from planet debian prior to debconf | 14:54 |
| cjwatson | oh, actually, ScottK already did | 14:54 |
| lool | it seems to have fairly trivial to convert json files | 14:54 |
| cjwatson | so likewise, you need either utopic or trusty-proposed of dput-ng | 14:54 |
| lool | oddly, it didn't complain about 14.09 though | 14:54 |
| lool | I have utopic version | 14:54 |
| cjwatson | dput(-ng) doesn't know how to complain about that | 14:55 |
| lool | am I supposed to uplaod to ppa:ubuntu-rtm/owner/name ? | 14:55 |
| cjwatson | the lookup is up to LP | 14:55 |
| cjwatson | ppa:owner/ubuntu-rtm/name | 14:55 |
| lool | ok; I'll drop my customizations then | 14:55 |
| === boiko_ is now known as boiko | ||
| cjwatson | https://launchpadlibrarian.net/179794265/dput-ng_1.7_1.7ubuntu1.diff.gz looks right | 14:55 |
| brendand | sil2100, can you help me find the .deb for the latest version of unity8-autopilot in utopic? | 14:55 |
| lool | cjwatson: I thought /incoming would be /ubuntu-rtm rather than /ubuntu | 14:56 |
| brendand | sil2100, it's for the AP issue | 14:56 |
| sil2100 | brendand: latest in utopic? apt-get download unity8-autopilot doesn't work? | 14:56 |
| lool | well I guess that's still valid for uploads to ubuntu-rtm | 14:56 |
| brendand | sil2100, but i'm running rtm :) | 14:56 |
| brendand | sil2100, i just want to install that .deb to make sure it fixes the issue | 14:56 |
| sil2100 | brendand: ah ;) | 14:56 |
| brendand | sil2100, anyway my hands are free now i think i can look | 14:57 |
| brendand | sil2100, but if you know of the top of your head that would be useful | 14:57 |
| sil2100 | brendand: so, you can use that command on your desktop and then adb push maybe? But in case you need the link itself, I can provide it :) | 14:57 |
| brendand | sil2100, ah yeah good point | 14:57 |
| sil2100 | brendand: https://launchpad.net/ubuntu/+archive/primary/+files/unity8-autopilot_8.00%2B14.10.20140903.1-0ubuntu1_all.deb <- but the link just in case | 14:57 |
| charles | Saviq, davmor2, you say the alarm wakeup isn't releasing its "display on" cookie after the alarm is dismissed? | 14:58 |
| Saviq | charles, that seems to be the case, yes | 14:58 |
| sil2100 | brendand: so you think we need those with the latest Mir? :) | 14:58 |
| davmor2 | charles: after several alarms I was using 3 at the same time | 14:58 |
| * Saviq tries with 2 now, phone started suspending again after a time | 15:00 | |
| charles | Saviq, davmor2, so to reproduce this, I just need to set an alarm, let it go off, and then the screen won't timeout to black on its own? | 15:00 |
| Saviq | charles, current confirmed case is 3 alarms at the same time, all dismissed | 15:00 |
| davmor2 | charles: 3 alarms at the same time | 15:00 |
| charles | davmor2, Saviq, ack I'll try that | 15:01 |
| sil2100 | didrocks: hey! Do you know if dch can be somehow forced to increment an already released top-most version instead of appending a new entry? ;) The manual doesn't say anything about that | 15:01 |
| charles | davmor2, Saviq, what image are you testing with? | 15:02 |
| Saviq | charles, rtm#16 on krillin | 15:02 |
| charles | Saviq, thanks | 15:02 |
| davmor2 | charles: ditto | 15:03 |
| plars | brendand: sil2100: ogra_: I'm trying the https://launchpad.net/ubuntu/+source/unity8/8.00+14.10.20140828.1-0ubuntu1 based debs on top of rtm right now after successfully reproducing it at home with the older one | 15:06 |
| Mirv | bzoltan: sil2100: I didn't get anyone back on the release channel | 15:06 |
| sil2100 | plars: ACK :) | 15:06 |
| plars | brendand: sil2100: ogra_: I suspect we're just going to need an updated unity8-* in rtm to fix this | 15:06 |
| sil2100 | Mirv: no worries, cjwatson already picked it up | 15:06 |
| plars | there were some critical fixes that were still outstanding | 15:07 |
| sil2100 | plars: that would be good to hear, since we have some landings ready with that | 15:07 |
| Mirv | sil2100: yeah, I read, that's what I thought would happen eventually. great! | 15:07 |
| sil2100 | plars: brendand was checking that as well | 15:07 |
| plars | sil2100: brendand: ogra_: ok, confirmed... I'm watching an autopilot test run right now with that combination - successfully unlocked | 15:07 |
| brendand | plars, thanks | 15:08 |
| sil2100 | plars: excellent | 15:08 |
| sil2100 | Too bad the mir deps didn't mention that it required the new unity8 | 15:08 |
| sil2100 | plars, brendand: thanks guys! | 15:08 |
| ogra_ | plars, oh, awesome ! | 15:08 |
| Saviq | davmor2, charles, yeah, killing datetime service makes it suspend again | 15:08 |
| Saviq | charles, 2 alarms were enough here | 15:08 |
| Saviq | probably a leaked display hold | 15:08 |
| * Saviq tries 1 | 15:09 | |
| cjwatson | Mirv: I didn't notice your earlier query because jetlag, basically | 15:11 |
| cjwatson | sorry about that | 15:12 |
| Mirv | cjwatson: no problem, I didn't expect you to be around with that amount of jetlag anyway | 15:12 |
| Saviq | davmor2, charles, if I use just one alarm it's all fine, so it seems like there's a hold per alarm set up, but only one gets cleared | 15:15 |
| davmor2 | Saviq: that sounds like a good possibility | 15:16 |
| charles | Saviq, davmor2, just FYI, I'm seeing it too. Haven't tracked it down yet | 15:21 |
| charles | davmor2, is there a ticket for this yet? | 15:21 |
| * charles remembers who he's talking to. of course there's a ticket. | 15:21 | |
| charles | davmor2, what's the bug # for this? | 15:22 |
| davmor2 | charles: not yet but I can trigger one in a minute | 15:22 |
| Ursinha | sil2100: didrocks, about the pep-8 changes... it's long due | 15:24 |
| Ursinha | sil2100: didrocks, I haven't contributed much with that because I just can't read that code | 15:24 |
| Ursinha | so better now than never | 15:24 |
| sil2100 | Ursinha: well, not sure if this time is good for it since we have still some RTM changes to do, and it's breaking the standard workflow | 15:25 |
| sil2100 | Ursinha: I would expect such changes to happen later and most probably discussed | 15:25 |
| sil2100 | Ursinha: when there's no haste | 15:25 |
| Ursinha | sil2100: but why is that breaking the workflow? the changes introduced/revealed bugs? | 15:26 |
| sil2100 | Ursinha: yeah, it broke one thing, but also I have a lot of branches that are work-in-progress, and such big changes require me to manually rebase to make them mergeable again ;) | 15:26 |
| sil2100 | Ursinha: as it completely changes the layout of the code basically | 15:27 |
| sil2100 | Ursinha: (not to mention my personal opinions about code-readability in this form ;D) | 15:27 |
| Ursinha | sil2100: maybe you should coordinate a bit better with robru as he's working with you on citrain and I assume your changes might break his as well? :) that's an honest observation | 15:27 |
| Ursinha | sil2100: there should be absolutely no arguing about using pep-8 when coding python, but that's my personal opinion :) | 15:27 |
| sil2100 | Ursinha: I always inform about features I develop on meetings, so robru is aware of anything that I implement ;) | 15:28 |
| sil2100 | I never push out something without telling about it first | 15:28 |
| sil2100 | While this, well, I didn't hear anything about it - Robert only informed me about unit-test work he'll be doing | 15:28 |
| robru | sil2100: I dunno, on several occaisions I woke up to find NameErrors in your production code | 15:28 |
| Ursinha | sil2100: informing isn't coordinating :) I'm not saying you are doing it wrong, but as we have more than one person working on the same codebase that is something nice to think about | 15:28 |
| sil2100 | robru: that was a bugfix going wrong | 15:28 |
| sil2100 | robru: it's hard to inform about every hotfix I'm doing ;) | 15:29 |
| robru | sil2100: the reality is that our timezones are so different, we're going to always be working while the other is sleeping. please don't complain about work I do while you sleep :-P | 15:29 |
| sil2100 | robru: just tell me you intend to do such big changes! It's not a 10-line diff, it's OVER 9000! | 15:29 |
| sil2100 | ;) | 15:29 |
| robru | sil2100: today I'm going to implement a pyflakes checker | 15:30 |
| robru | and if I have time I'm going to widen the pep8 checker to the whole tree, not just citrain/ directory | 15:30 |
| Ursinha | it got me thinking, sil2100, how many branches do you have in progress at once? that's crazy to do when you're not the only one modifying the code | 15:30 |
| sil2100 | Ursinha: well, I don't say I miss coordination, I miss being informed | 15:30 |
| davmor2 | charles: https://bugs.launchpad.net/indicator-datetime/+bug/1365557 | 15:30 |
| ubot5 | Ubuntu bug 1365557 in Indicator Date and Time "Multiple alarms set at the same time trigger the screen to nolonger blank" [Undecided,New] | 15:30 |
| sil2100 | Ursinha: currently there are 3 branches | 15:30 |
| sil2100 | Ursinha: and usually I was the only one working on CI Train code so I just got used to that ;) | 15:31 |
| Ursinha | sil2100: the rest of us miss coordination because you both need to change that code and if you don't coordinate things break and we all suffer :) that's my point | 15:31 |
| sil2100 | Ursinha: I only know about me and robru as the ones doing changes in CI Train code, with me tweaking on it for the most recently - if I'm not aware of anyone else working on something I don't coordinate because I don't know who to coordinate with :) | 15:32 |
| ralsina_ | sil2100: something strange with silo rtm-11 it appears assigned to me in the spreadsheet and the dashboard for push-client but it seems to contain system-settings instead | 15:32 |
| sil2100 | Ursinha: in the past it was only didrocks doing uploads | 15:32 |
| sil2100 | ralsina_: ah, it might have been freed in the meantime, one moment ;/ | 15:33 |
| * sil2100 again couldn't finish his branch with improvements here | 15:33 | |
| ralsina_ | sil2100: cool, I was away for a couple of days, so I could just start another landing later, no big deal really :-) | 15:33 |
| Ursinha | sil2100: I know, but now there is you and robru working on it (and could be more people)... all I'm saying is that's maintained by more than one person now and needs some change in the "process", to avoid things such one breaking the other's work | 15:34 |
| Ursinha | specially considering you both live in such different timezones | 15:34 |
| sil2100 | Ursinha: I agree here indeed, that's why I actually mentioned that I would like to be informed about if any changes are to be made so I can prepare myself | 15:36 |
| sil2100 | Ursinha: especially big ones | 15:36 |
| Ursinha | sil2100: fair enough | 15:36 |
| sil2100 | Maybe not any changes, but big ones for sure! | 15:36 |
| Ursinha | sil2100: but let's not disagree on pep-8 and pyflakes :P | 15:37 |
| sil2100 | Ursinha: I'm not a pythonist, I will just leave it up to you and robru with the expertise here ;p I'm just saying that the style is not completely good for me eyes! | 15:38 |
| Ursinha | unless you have a superwide ultra high resolution monitor, having that crazy long lines is impossible to read :) | 15:38 |
| robru | sil2100: yeah, I'm not sure what your problem is with pep8, but it is the Gold Standard for writing python code that is actually readable by other python programmers. so this change made a huge positive impact on readability for potential future maintainers of this code (including myself). Now that I can actually read what's going on in the code I might be | 15:39 |
| robru | able to contribute more going forward. | 15:39 |
| sil2100 | ralsina_: you needed ubuntu-push there, right? | 15:39 |
| ralsina_ | sil2100: yes | 15:39 |
| Ursinha | robru: yes yes | 15:40 |
| sil2100 | robru: good to know, well, I must say that for instance I like wrapping lines only when it makes sense, not like for every argument if the list is bigger | 15:40 |
| sil2100 | robru: since my eyes work pretty good on things that are a bit 'wider', in like one line | 15:40 |
| brendand | thostr_, 'powerd-cli test' fails one test with silo 13 | 15:41 |
| brendand | charles, ^ | 15:41 |
| robru | sil2100: not sure how that can be -- it's clearly easier to scan down a straight line than to read things from a cloud-jumble that spans vertically and horizontally | 15:42 |
| Ursinha | sil2100: it's hardcoded in my brain that the only width that makes sense is less than 80 chars :P (which might be a bit outdated, I know, but this is how a pythonist learns to read code) | 15:42 |
| robru | sil2100: also like, the absurdly long lines found in citrain would wrap on my screen and break the flow of the python indentation. you need to be able to see the indentation clearly to understand the structure of the code. are you reading the code in a maximized widescreen window? because I split my widescreen in two columns (still over 100 chars wide!) but | 15:43 |
| robru | citrain code wrapped so badly. there were lines that wrapped *TWICE* on my screen, totally illegible | 15:43 |
| Ursinha | sil2100: and now for something slightly different: how do you handle external contributions to cu2d? do people need to come to you and request review, how does that work? | 15:43 |
| robru | Ursinha: I don't think we've had an external contribution since april ;-) | 15:43 |
| sil2100 | Indeed ;) | 15:43 |
| Ursinha | let's say I want to contribute, what I have to do? | 15:44 |
| sil2100 | robru: well, I think citrain suffered from the editor syndrome! | 15:44 |
| plars | ogra_: sil2100: how soon could we expect to see a rebuild with the updated unity8 bits? | 15:44 |
| Ursinha | *do I | 15:44 |
| robru | sil2100: btw I'm going to try to resurrect this one at some point: https://code.launchpad.net/~mathieu-tl/cupstream2distro/cleanup-on-kill/+merge/213728 | 15:44 |
| sil2100 | robru: since on my sublime editor the code was perfectly readable | 15:44 |
| robru | sil2100: send me a screenshot :-P | 15:44 |
| sil2100 | robru: one moment ;) | 15:44 |
| Ursinha | I use vim :) even on the best editor ever you still have the screen size limitation, that's why I don't understand | 15:45 |
| Ursinha | many parts of the code seriously exceed my widescreen monitor on its highest resolution :) | 15:45 |
| robru | Ursinha: he must have a 30" screen so he can display the full length of the lines without wrapping ;-) | 15:45 |
| robru | or maybe a 30' screen... | 15:45 |
| sil2100 | I used vim previously, but then noticed the wonders of sublime and use it for code mostly ;) | 15:46 |
| plars | robru: add a pep8/pyflakes test for anything landing in citrain :) | 15:46 |
| sil2100 | Damn, I'm surrounded by pythonists! | 15:46 |
| sil2100 | Get away! Shoo! SHOO! | 15:46 |
| sil2100 | ;) | 15:47 |
| Ursinha | sil2100: man, that's ubuntu land, we're mostly pythonists :P | 15:47 |
| plars | sil2100: seriously, I used to think pep8 was a waste of time many years ago until I worked with james_w and salgado on a project and they insisted it was a good idea to enforce it from day 1. I'm a convert now | 15:47 |
| * sil2100 is a C person | 15:48 | |
| * sil2100 is soo oldschool | 15:48 | |
| Ursinha | sil2100: I also code in C, but when I code in python I do that like a pythonist | 15:48 |
| Ursinha | I wouldn't dare to write C code like pythin | 15:48 |
| Ursinha | python | 15:48 |
| robru | plars: that's what this flamewar is about! I just implemented a hard requirement on pep8 yesterday and I'm doing pyflakes today | 15:48 |
| plars | robru: awesome! | 15:48 |
| robru | plars: thanks, yeah I agree the code was a disaster, totally unreadable | 15:49 |
| brendand | sil2100, feel lucky that robru doesn't apply hyper-pep8 | 15:49 |
| plars | I haven't really looked at the citrain code, but if I get some spare cycles, I'd be happy to help bring it into compliance if some of that is still needed | 15:49 |
| brendand | sil2100, where people start bringing you up on pep8 'violations' that the tool doesn't even check | 15:49 |
| brendand | sil2100, and sometimes even decide to interpret pep8 in their own special way | 15:50 |
| brendand | :) | 15:50 |
| sil2100 | Yeah, I might have to read up on all of this, please remember that my Python experience is limited | 15:50 |
| Ursinha | plars: robru will certainly love you :) | 15:50 |
| sil2100 | Before I only used it for advanced scripting purposes and autopilot | 15:50 |
| charles | brendand, looking at it | 15:51 |
| sil2100 | robru: http://people.canonical.com/~lzemczak/subl.png | 15:51 |
| Ursinha | sil2100: that's okay, I wasn't born knowing perfect python (I still don't have perfect python), but thing is always try to improve your techniques :) I know change is hard, but some are for the greater good :P | 15:52 |
| robru | Ursinha: ^ he has wrap turned off... | 15:53 |
| Ursinha | sil2100: ah, having a line broke with "\" usually means something is clearly wrong that even one with high tolerance to long strings is bothered | 15:53 |
| Ursinha | robru: to me that would be even worse | 15:53 |
| Ursinha | imagine having to roll the screen horizontally? | 15:54 |
| sil2100 | hah, I have wrapping enabled sometimes | 15:55 |
| robru | sil2100: Ursinha http://i.imgur.com/Jm1pU4l.png before and after. | 15:55 |
| sil2100 | Damn imgur doesn't work for me today | 15:55 |
| sil2100 | Ok, but anyway, I go back to code | 15:55 |
| Ursinha | left image makes me feel good | 15:57 |
| robru | sil2100: ok anyway, I have an idea that can help strike a balance here. if we move the definition of the super-long strings to the top of the file, they'll be less indented and thus require less wrapping. and then in the code we can just reference them as global variables, which will fit easily on one line. That way we get a nice win/win of less wrapping, | 15:57 |
| robru | but still shorter lines, and better readability. | 15:57 |
| Ursinha | s/left/right/ | 15:57 |
| Ursinha | robru: yes, e.g. moving predefined messages there and use the variables | 15:57 |
| sil2100 | robru: well, I don't mind it being as it is now, since I guess that's the standard - just saying that it's not good for my eyes ;) | 15:58 |
| Ursinha | sil2100: you'll get used to that, I promise :) | 15:58 |
| sil2100 | robru: it might be because I sometimes work with code in 'blocks', and I got used to the blocks as they were, while now it's different - will have to get used to that | 15:58 |
| sil2100 | I liked to it as the author meant it | 15:59 |
| robru | sil2100: yes, I work with the code in "blocks", and the blocks were impossible to read because all the wrapped lines made it impossible to scan the indentation and see the structure of the file ;-) | 16:00 |
| sil2100 | hah, yeah, I got used to it and was able to work with it :) Maybe my brain was somehow compatible with that | 16:00 |
| Ursinha | sil2100: I don't know how sublime works but it might have a pep-8 plugin that can help you there | 16:01 |
| Ursinha | sil2100: I have that enabled on my vim and I can check it easily | 16:01 |
| sil2100 | plars: pong! | 16:02 |
| plars | sil2100: oh, brt | 16:02 |
| sergiusens | there shouldn't be hot fixes in the train code as there aren't hot fixes in the actual product | 16:16 |
| ogra_ | sergiusens, but it makes the whole thing so much more exciting ! | 16:21 |
| sergiusens | lol | 16:23 |
| sergiusens | sil2100: autopilot went to pep8 conversion after we started clickifying too ;-) | 16:23 |
| sergiusens | 80 line limit makes 3 way merges faster to read as well | 16:24 |
| sergiusens | just use the coding standard of the language | 16:24 |
| plars | fginther: how much chaos would it create for you if ogra_ lands the adb changes today? | 16:27 |
| plars | psivaa: ^ fyi - I'll handle the remaining 2 changes or so that we need for ubuntu-device-flash to pass it the --password option and use the new password in the sudoers setup script | 16:27 |
| psivaa | plars: ack, thanks. let me know if i need to review anymore of those. | 16:29 |
| fginther | plars, today is as good as any | 16:29 |
| sil2100 | sergiusens: hah, nice, it seems I missed out all the pep8-bits in python projects ;) | 16:29 |
| plars | fginther: I'll cc you when I have a branch so you can make sure to pick up those too, will probably be just a couple of lines | 16:30 |
| fginther | plars, thanks | 16:30 |
| sil2100 | sergiusens: since I was playing with autopilot while it was still as it was before | 16:30 |
| Saviq | trainguards: can you please restart this build https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-019/+build/6321642 | 16:33 |
| sil2100 | Saviq: sure | 16:33 |
| sil2100 | Saviq: done | 16:34 |
| davmor2 | Saviq, sil2100: finally silo 007 is ready to rock | 16:34 |
| sil2100 | davmor2: \o/ | 16:34 |
| Saviq | davmor2, good stuff | 16:34 |
| sil2100 | robru: I'll publish that ^ | 16:34 |
| Saviq | kgunn, ↑ | 16:34 |
| elopio | plars: could you check why not all the browser tests are running? | 16:34 |
| robru | sil2100: ok | 16:34 |
| elopio | and balloons: could you release a new reminders version to the store so it doesn't get stuck anymore. | 16:34 |
| elopio | ? | 16:34 |
| plars | elopio: none of the autopilot tests are running due to the screen unlock problem | 16:34 |
| sil2100 | robru, Saviq, davmor2: published | 16:35 |
| balloons | elopio, plars reminders was released yesterday right after it merged | 16:36 |
| balloons | music app and terminal also got updates | 16:36 |
| plars | balloons: awesome! | 16:37 |
| elopio | balloons: thanks. | 16:52 |
| didrocks | Ursinha: robru: sil2100: anyway, my only point is that as you don't really know the code, you should do peer reviews. if you change the logic and not only the wrappig like here, you should double check. (on another note: don't disable tests if you make a change that don't make them passing). That's more best practice than pep8 IMHO | 16:52 |
| elopio | plars: I didn't know there was a screen lock problem. So I'll check again after that is solved. | 16:52 |
| robru | didrocks: yes my intention is to review the disabled tests and fix them correctly. it's just that I wanted to gate MPs on the unit tests ASAP and you can't do that if you have a bunch of failing ones. | 16:56 |
| didrocks | yeah, would have been better to not break them first but oh well :) | 16:57 |
| didrocks | robru: but still, I'm serious, peer reviews, the code of fix that I had to do shouldn't happen if the change is being seriously reviewed | 16:57 |
| robru | didrocks: yeah I agree, would have loved to not break it in the first place, but here we are... :-/ | 16:58 |
| robru | didrocks: also peer reviews are nice, but will cripple our team. sil and I are in such different time zones, every small change would take 2 days to ping back and forth with reviews. | 16:58 |
| robru | didrocks: so at least we can settle for auto-reviews from jenkins | 16:58 |
| didrocks | but Ursinha canhelp, right? | 16:58 |
| didrocks | can* | 16:58 |
| robru | didrocks: Ursinha is afraid to look at the code... well maybe now that we have pep8 she can help more ;-) | 16:59 |
| robru | didrocks: also Ursinha is in my timezone, so we have nobody to review for sil | 16:59 |
| didrocks | "afraid"… ok | 16:59 |
| didrocks | I did propose to help in peer reviews multiple times | 16:59 |
| robru | didrocks: seriously the code was unreadable before pep8, and Ursinha agrees. it's the main reason I haven't contributed much yet, because i literally could not read it as it was. | 17:00 |
| didrocks | robru: rather than waited then, pep8 fixes could have come way better | 17:01 |
| didrocks | It's funny to see the ranting when the origin of the discussion is a stupid simple logic error which has nothing to do with pep8 when the refactoring was done here | 17:01 |
| Ursinha | I'm not afraid to look at that code, I just fear I'd break something because that's really hard to read and not all tests pass | 17:02 |
| robru | didrocks: right, I made a small logic error at the same time I was doing pep8, sorry for that. | 17:02 |
| didrocks | Ursinha: all tests did pass when I left, for the record | 17:02 |
| Ursinha | didrocks: I caught at least twice tests not passing on trunkl | 17:02 |
| didrocks | Ursinha: on which revs? | 17:02 |
| Ursinha | I'm not pointing fingers, that wouldn't help us here, I'm only saying I didn't want to break anything as that was production | 17:03 |
| robru | didrocks: dunno, you had some special mojo for running the tests or something. I never saw tests passing at any point. | 17:03 |
| cjwatson | I entirely agree on peer reviews, although I will say that large refactoring commits often receive only very cursory review, out of necessity - one reason for the religion of trying to split up commits into logical pieces as much as possible | 17:03 |
| didrocks | robru: you never told me that tests never passed for you, not sure how you did tests your changes in the past then | 17:03 |
| didrocks | robru: but you should have asked me, and this offer still stands | 17:03 |
| Ursinha | didrocks: a while ago, I pointed the problems to sil2100 and he worked on fixing one of them.. my point is that if we had tarmac or something to gate that these would have been caught earlier, and that's fine, we're improving this all as we move, right? | 17:04 |
| robru | didrocks: that's the point. I never tested changes ever. neither did sil. we've been live-editing production since you stepped down. | 17:04 |
| didrocks | Ursinha: agreed on having a bot to perform the merges | 17:04 |
| didrocks | robru: hoping you will go to better practice now then | 17:04 |
| cjwatson | I think I commented on the tests being broken when I last had occasion to change citrain; I made sure that the tests passed in the region I was working on and that I didn't regress anything, but I wasn't in a position at the time to go and drain the swamp too | 17:04 |
| Ursinha | didrocks: again, I'm not pointing fingers, I'm explaining one of the reasons why I have avoided touching the code | 17:05 |
| cjwatson | (and I did add a test for the thing I was doing) | 17:05 |
| Ursinha | I was in a very similar position as cjwatson | 17:05 |
| robru | didrocks: yes, I worked long hours yesterday to implement autolanding for lp:cupstream2distro, gated on tests passing, and with code style quality checks so that the code can actually be enforced to be readable ;-) | 17:05 |
| Ursinha | I fixed the test in the area I was working on but it would take me more than that to fix it all | 17:05 |
| robru | cjwatson: yes I remember vividly you wrote some tests but complained of dozens of test failures. I was afraid to even look. | 17:06 |
| cjwatson | I didn't have a problem running the tests, though, and the errors I could see didn't look like test runner issues, they were just buggy tests or similar ... | 17:06 |
| didrocks | cjwatson: integration tests that needs a special setup, right? | 17:06 |
| cjwatson | but it was a while back | 17:06 |
| robru | cjwatson: thanks a bunch for the tests you did write | 17:06 |
| cjwatson | didrocks: well, I didn't do a full search, there may have been some of those, but some things were just busted with no good reason | 17:06 |
| didrocks | Ran 198 tests in 17.027s | 17:07 |
| didrocks | rev 590 (the last one I touched) | 17:07 |
| cjwatson | that was in July though | 17:07 |
| didrocks | then, integration tests needs a pbuilder | 17:07 |
| bfiller | robru: yesterday pretty sure ubuntu-keyboard got published to both ubuntu and ubuntu-rtm but only seeing it on ubuntu 0.99.trunk.phablet2+14.10.20140902.1-0ubuntu1 | 17:07 |
| bfiller | robru: can you check on it's rtm status? | 17:07 |
| Ursinha | didrocks: you've been away for a while and I'm sure people did what they could to learn the codebase and keep up | 17:07 |
| didrocks | cjwatson: yeah, but as the discussion were "we didn't touch the tests because they never passed", I wanted to answer to that | 17:07 |
| didrocks | Ran 81 tests in 10.077s on integration tests | 17:08 |
| cjwatson | bfiller: speaking of which, your query about the initial RTM sync was escalated to me, but it doesn't look like you responded to https://lists.launchpad.net/ubuntu-phone/msg09627.html | 17:08 |
| robru | bfiller: indeed rtm is behind, not sure why, hang on | 17:08 |
| didrocks | however, you need to have this pbuilder setup locally | 17:08 |
| Ursinha | didrocks: I never knew how to setup the env to run the integration tests | 17:09 |
| bfiller | cjwatson: yeah it got resolved as we released another version of the package that got synced to both | 17:09 |
| didrocks | Ursinha: you never asked AFAIK :) | 17:09 |
| didrocks | but I can help you tomorrow if you need | 17:09 |
| Ursinha | didrocks: I did, a long ago :) | 17:09 |
| robru | didrocks: are there instructions on how to set up the pbuilder anywhere? can you perhaps write a script that automates the creation of that pbuilder environment so people other than you can run those scripts? | 17:09 |
| bfiller | cjwatson: sorry didn't response | 17:09 |
| didrocks | robru: I'm happy to guide you to do it | 17:09 |
| Ursinha | didrocks: again, I'm not complaining, just saying I couldn't find docs or anything to learn how to do that | 17:09 |
| cjwatson | bfiller: ok, so it was just that package and not others? | 17:09 |
| Ursinha | didrocks: and that would help people to be able to fix tests if they could run them | 17:10 |
| bfiller | cjwatson: that package was the only one that I knew about | 17:10 |
| cjwatson | ok | 17:10 |
| didrocks | Ursinha: they could ask as well, not like IRC was a wall :) | 17:10 |
| didrocks | and then, that help building the doc which wasn't there | 17:10 |
| Ursinha | didrocks: man, do you understand my point? | 17:10 |
| robru | cjwatson: oh, are you syncing it? or should I set up a silo to sync it? | 17:10 |
| Ursinha | I'm saying that is one of the reasons, and that's about it | 17:10 |
| Ursinha | that only means we should fix that | 17:10 |
| Ursinha | *we* | 17:10 |
| cjwatson | robru: no, just following up on an older thread | 17:10 |
| robru | bfiller: what are the source package names that are missing? just ubuntu-keyboard? | 17:11 |
| didrocks | Ursinha: I do, do you understand that telling "I didn't do anything because there was no doc and I was afraid to look at and never asked for this" is kind of a weak argument as well? | 17:11 |
| didrocks | Ursinha: hence the "if you need help, I can help you guiding" | 17:11 |
| didrocks | and what I always told since I left here | 17:11 |
| bfiller | robru: actually ubuntu-keyboard-* there are like 20 of them. I can get the exact names if you'd like | 17:11 |
| Ursinha | didrocks: I asked for this, but as the other people here we have plenty of things to do, so I'm kindly suggesting "let's write docs" | 17:11 |
| robru | didrocks: ok, please when you get some time (tomorrow) I'll appreciate an email with step by step instructions of what commands to run to create the pbuilder necessary to run the integration tests. | 17:11 |
| didrocks | robru: sure, if you remind me in any way, I'll do it | 17:12 |
| robru | bfiller: no no those are the binary package names. they all come from ubuntu-keyboard I think. | 17:12 |
| cjwatson | hmm, it'd be useful if I set up some way to get rmadison output for rtm, wouldn't it? | 17:12 |
| bfiller | robru: http://pastebin.ubuntu.com/8242325/ | 17:12 |
| robru | didrocks: well you should write a note for yourself, I won't wake up until your shift is over and you'll be out of time again... | 17:12 |
| cjwatson | bfiller: we always want source package names for this kind of stuff really | 17:13 |
| didrocks | robru: I have a note for now, but ping me in case you don't receive anything | 17:13 |
| robru | didrocks: ok thanks | 17:13 |
| bfiller | cjwatson, robru: yup, ubuntu-keyboard is the source pkg | 17:13 |
| didrocks | yw | 17:13 |
| robru | sil2100: what's the syntax for syncing from utopic rather than a silo? 'sync:utopic,something-something source_package_name'? | 17:14 |
| cjwatson | ok, rmadison shows ubuntu-rtm/14.09 now | 17:14 |
| robru | cjwatson: thanks | 17:14 |
| sil2100 | robru: it's 'sync:distro,series package package' | 17:14 |
| sil2100 | robru: so sync:ubuntu,utopic foo bar | 17:15 |
| Ursinha | didrocks: you can check your pvt logs, we discussed integration tests on 2014-05-02 as I couldn't find instructions on how to do that... so don't say I never asked, please :) | 17:15 |
| robru | sil2100: thanks | 17:16 |
| robru | bfiller: ok, new ubuntu-keyboard building in rtm 16: https://ci-train.ubuntu.com/job/ubuntu-rtm-landing-016-1-build/2/console | 17:16 |
| didrocks | Ursinha: right, and I answered you | 17:16 |
| didrocks | finishing up with "do not hesitate if you have any question!" after you saying you are looking to it :) | 17:16 |
| didrocks | so, I assumed you set it up :) | 17:16 |
| bfiller | robru: thanks | 17:17 |
| robru | bfiller: you're welcome! | 17:17 |
| Ursinha | didrocks: you had no obligation of checking back if I got there or not, I'm only saying I did ask due to lack of docs, that was my point the entire time :) | 17:17 |
| Ursinha | so let's write docs now and we'll all be happy and fine | 17:17 |
| didrocks | Ursinha: agreed | 17:18 |
| didrocks | robru: actually, I gave the command to create the setup environment | 17:19 |
| didrocks | chroot-tools/.pbuilderrc | 17:19 |
| didrocks | robru: # Just use it to create the cowbuilder with: sudo HOME=. DIST=<wanted_dist> cowbuilder --create --debootstrapopts --variant=buildd | 17:19 |
| didrocks | and that should be enough (with pwd=chroot-tools) | 17:19 |
| didrocks | robru: let me just find which dist I used for those tests (that will maybe need to be adapated, to be more generic will be better) | 17:20 |
| robru | didrocks: I guess raring, I saw that a lot in the tests | 17:20 |
| didrocks | robru: yeah, I would say so, let me confirm, one sec | 17:20 |
| * robru needs some breakfast | 17:21 | |
| didrocks | robru: right raring, I have in ubuntu-developer-tools-center a better way for having a "fake" distro, you can maybe get some inspiration from there | 17:21 |
| didrocks | robru: enjoy your breakfast! | 17:21 |
| rsalveti | are we using the train to land train changes? | 17:26 |
| rsalveti | that would be fun | 17:26 |
| rsalveti | fun for me to watch, of course :-) | 17:27 |
| robru | rsalveti: thankfully it's not self aware | 17:27 |
| robru | rsalveti: but we are at least now gating MPs against citrain so that they don't regress citrain's own tests. | 17:27 |
| rsalveti | robru: right | 17:27 |
| rsalveti | yeah, the pep8 discussion was a bit surprising, we got a bug, sure, but just fix it, no big deal | 17:28 |
| sil2100 | It wasn't a discussion, no worries, since no one was discussing if the pep8 switch is necessary or not | 17:28 |
| sil2100 | It was more like about communication (that we will now communicate better) and about taste ;) | 17:29 |
| ogra_ | rsalveti, trainspotting ? | 17:29 |
| rsalveti | right | 17:29 |
| rsalveti | ogra_: :-) | 17:29 |
| * ogra_ thinks we need to re-define the line length for pep8 anyway so code fits in the terminal app | 17:30 | |
| Ursinha | ogra_: I think that was under discussion a while ago | 17:31 |
| sil2100 | As pep8 is the right way to go from what I see and I can understand that, as I was a great zealot of writing C code complying to ANSI C in my old days ;) | 17:31 |
| ogra_ | turning it to 20chars ? | 17:31 |
| ogra_ | :) | 17:31 |
| sil2100 | ogra_: ;p | 17:31 |
| sil2100 | ogra_: what terminal size are you using man ;p | 17:31 |
| ogra_ | sil2100, whatever fits on my phone screen :P | 17:31 |
| rsalveti | 80 columns is fine unless you're doing c++ | 17:33 |
| rsalveti | for c++ you need like 280 | 17:33 |
| rsalveti | or more | 17:33 |
| ogra_ | 480 | 17:33 |
| Ursinha | sil2100: thanks for understanding :) | 17:35 |
| * Ursinha hugs sil2100 | 17:35 | |
| * sil2100 just needs to adjust his eyes to a new coding style | 17:36 | |
| * sil2100 hugs Ursinha | 17:36 | |
| sil2100 | ;) | 17:36 |
| Ursinha | :) | 17:36 |
| robru | sil2100: the other benefit of 80 char lines is that you can have two windows side by side on the same screen... or one editor window and one terminal window... or two terminal windows. both unity and gnome-shell have great half-maximization features for getting windows perfectly side-by-side tiled ;-) | 17:36 |
| ogra_ | robru, get a modern laptop/monitor :P | 17:36 |
| * ogra_ can fit 4 terms with 80 chars in a row on his lappie | 17:37 | |
| robru | ogra_: 27", two terminals side by side are about 110 characters wide each. citrain code had lines so long they wrapped twice. that's like 300 char lines in python. | 17:37 |
| ogra_ | (well 3.8 ) | 17:37 |
| ogra_ | haha | 17:37 |
| ogra_ | ok, thats quite long | 17:37 |
| robru | ogra_: I guess you didn't see this earlier ;-) http://i.imgur.com/Jm1pU4l.png | 17:38 |
| ogra_ | wow 1 | 17:39 |
| ogra_ | ! | 17:39 |
| Saviq | trainguards, https://ci-train.ubuntu.com/job/ubuntu-landing-019-1-build/23/console says SUCCESS, but spreadsheet says some packages failed ¿? | 17:42 |
| Saviq | robru, oh, all the wasted space on your right terminal ;P | 17:42 |
| robru | Saviq: not wasted, it's called a margin, help readability. there's a reason books don't print words right to the very edge of the page :-P | 17:43 |
| Saviq | robru, but not half of the page ;) | 17:43 |
| Saviq | robru, don't get me wrong, I'm all for wrapping, but 80 columns is just so 1990 | 17:44 |
| Saviq | even with two terminals as you have them, 100, even 120 would be good enough | 17:44 |
| robru | Saviq: I admit 100 could be ok, but I just wanted to follow a standard | 17:44 |
| Saviq | grr ^W | 17:44 |
| robru | Saviq: I admit 100 could be ok, but I just wanted to follow a standard | 17:45 |
| Saviq | robru, yeah yeah, I know | 17:45 |
| kgunn | davmor2: you around | 17:45 |
| Saviq | 80 is just too limiting IMO, leads to very artificial wrapping | 17:45 |
| Ursinha | Saviq: you are a C++ programmer, I presume? :P | 17:46 |
| popey | fginther: any idea what's going on here? https://code.launchpad.net/~rpadovani/reminders-app/bottomEdge/+merge/231118 - see last comment | 17:46 |
| * kgunn wants to put Saviq and duflu in cage match fight over 80 col use | 17:46 | |
| Ursinha | Saviq: hmm, where do you see packages failed in the spreadsheet? it's line 45, right? | 17:47 |
| fginther | popey, looking | 17:47 |
| Saviq | Ursinha, hmm it must've updated now | 17:48 |
| Saviq | Ursinha, it was weird 'cause it said "Packages built\nSome packages failed to build" in the dashboard, but yeah, good now, sorry for the noise | 17:48 |
| Ursinha | Saviq: no problem, that's a weird error if all packages built, thanks for letting us know anyway | 17:49 |
| Saviq | Ursinha, I tend to think of myself as a pragmatic programmer :P | 17:49 |
| Ursinha | :P | 17:50 |
| Ursinha | I agree 80 might be outdated, but as robru I like standards :P | 17:50 |
| Ursinha | better than no standards :) | 17:50 |
| Saviq | Ursinha, and having to wrap like what you see at the end of https://code.launchpad.net/~saviq/unity8/dash-geometry/+merge/233354 is IMO not pragmatic | 17:51 |
| Saviq | nor does it help readability | 17:51 |
| Ursinha | Saviq: I'd wrap that differently :) | 17:52 |
| Ursinha | it's indeed confusing | 17:52 |
| Saviq | Ursinha, wrapping after = \ is not that much better either | 17:52 |
| Saviq | and sure, I could use shorter names, but that doesn't help readability either | 17:52 |
| Ursinha | Saviq: I'd start the line with a ( and put the rest in the next line, identing format parameters below that | 17:53 |
| Saviq | Ursinha, standards, you said? :D | 17:53 |
| Ursinha | there are no definitive rules on how to do that, I just try to make it more readable, not only break the line when it reaches 80 for the sake of it | 17:53 |
| Ursinha | yeah, but it varies from project to project :) | 17:54 |
| Ursinha | there are the main standards and the project ones, Launchpad has a very nice styling guide for example | 17:54 |
| Saviq | aaanyway... on another topic... | 17:55 |
| Saviq | we seem to have an issue with changelogs in synced packages... we skipped one release into rtm (because they were close to one another) | 17:56 |
| Saviq | and now the changelog is kinda weird because it doesn't include the previous release... | 17:57 |
| Saviq | https://launchpad.net/ubuntu-rtm/+source/unity8/8.00+14.10.20140903.1~rtm-0ubuntu1 | 17:57 |
| Saviq | wonder if the changelog rewrite should rewrite the changelog to include all the changed bits since last ubuntu-rtm release... | 17:57 |
| Saviq | changelog rewrite rewrite the changelog, yeah, that's not confusing at all | 17:57 |
| ogra_ | that sentence could need another "rewrite" sprinkled in | 17:58 |
| ogra_ | or two .. or three | 17:58 |
| robru | Saviq: oh yeah, when you see two different statuses like that in the dashboard, the smaller one underneath is just a stale one from the spreadsheet, which is slower to update. the larger, top one is considered canonical. | 18:00 |
| robru | considered authoritative | 18:01 |
| Saviq | robru, ktx | 18:01 |
| robru | Saviq: you're welcome | 18:01 |
| davmor2 | kgunn: I am now] | 18:02 |
| rsalveti | sil2100: why did we land ubuntu-ui-toolkit without the -gles version? | 18:03 |
| sil2100 | rsalveti: we landed the -gles as well, at least it was published along with UITK | 18:06 |
| rsalveti | sil2100: hm, not in ubuntu | 18:07 |
| sil2100 | rsalveti: maybe it got somehow lost? Let me check | 18:07 |
| rsalveti | https://launchpad.net/ubuntu/+source/ubuntu-ui-toolkit-gles | 18:07 |
| sil2100 | hmmm | 18:07 |
| sil2100 | ubuntu-ui-toolkit-gles (1.1.1227+14.10.20140904-0ubuntu1) is in no known space (and time) | 18:07 |
| sil2100 | rsalveti: so, I see the rsync file had the -gles, so it either had to be rejected from the archive or something happened on snakefruit | 18:08 |
| sil2100 | https://ci-train.ubuntu.com/job/ubuntu-landing-012-2-publish/25/artifact/packagelist_rsync_landing-012-utopic/*view*/ | 18:08 |
| sil2100 | hmmm | 18:08 |
| sil2100 | Too bad we don't get e-mails if things get rejected | 18:09 |
| sil2100 | slangasek: hey! Do you remember if snakefruit had any logs of all the copy2distro runs it was doing? | 18:13 |
| slangasek | sil2100: this wouldn't be something I would have known, but I could look | 18:16 |
| sil2100 | slangasek: I remember something like that, maybe it was didrocks that mentioned it one time in the past, hmm | 18:16 |
| === om26er_ is now known as om26er | ||
| slangasek | sil2100: well, the most recent log is always written to public_html, but http://snakefruit.canonical.com/~ubuntu-archive/cicopy.log is a 403 | 18:20 |
| slangasek | sil2100: and I'm not finding any other logs here | 18:21 |
| sil2100 | slangasek: thanks | 18:22 |
| davmor2 | mterry: in the welcome wizard there seems to be a really noticeable delay in the in the number pad rising for the pin is this something you've seen? | 18:22 |
| sil2100 | I wonder what could be the problem, let me dig in further | 18:22 |
| sil2100 | slangasek: hm, could I ask you to put one file in snakefruit in a moment? I guess it might have been rejected because the -gles packages have some hacks in them, and in that case we were doing source copies | 18:23 |
| slangasek | ok | 18:24 |
| sil2100 | slangasek: could you put this http://people.canonical.com/~lzemczak/packagelist_rsync_landing-012-utopic into the incoming/ directory? Don't remember where exactly it was on snakefruit, but I would guess somewhere in cu2d or something | 18:29 |
| sil2100 | slangasek: I once asked you for some rsync file uploads there so you'll probably know where that is ;) | 18:29 |
| slangasek | sil2100: done | 18:30 |
| sil2100 | slangasek: thanks! | 18:31 |
| sil2100 | rsalveti: ok, let's see if it publishes it now | 18:31 |
| sil2100 | rsalveti: what I suspect happened is that it got somehow rejected as because of a small bug we published the source packages instead of the built binaries | 18:31 |
| mterry | davmor2, I bet that's because we restart maliit between those pages, so that it knows in which language to display the OSK | 18:32 |
| sil2100 | rsalveti: and as we know the -gles counterparts have some neat things inside to make the -gles sync easier | 18:32 |
| mterry | davmor2, probably something we could do to make that nicer | 18:32 |
| sil2100 | rsalveti: I can't tell for sure if that was it, but if it gets published now we'll know that something similar could have happened | 18:32 |
| sil2100 | (no logs of what happened) | 18:32 |
| sil2100 | rsalveti: ubuntu-ui-toolkit-gles (1.1.1227+14.10.20140904-0ubuntu1) is in the proposed pocket <- \o/ | 18:45 |
| rsalveti | sil2100: awesome, thanks! | 18:47 |
| sil2100 | rsalveti: yw! Thanks for noticing, didn't expect it to get rejected | 18:49 |
| rsalveti | sil2100: np | 19:01 |
| cjwatson | Saviq: The changelogs on Launchpad's distrosourcepackage pages have long been broken in that kind of way. I wouldn't advise putting any effort into working around it. If you look at the debian/changelog in the package, it appears to have the "skipped" release | 19:01 |
| cjwatson | slangasek: the URL is http://people.canonical.com/~ubuntu-archive/cicopy.log not snakefruit.c.c, but it only has the most recent attempt; I don't know of a historical log OTTOMH | 19:02 |
| sil2100 | Saviq: I might try making this better btw. as I can generate the package with a -v, but it might be a bit tricky due to some specific things we're doing for rtm | 19:03 |
| sil2100 | Saviq: but I'll keep that in mind | 19:03 |
| cjwatson | oh, it's true that -v might help | 19:04 |
| cjwatson | it's still an LP bug IMO, it could perfectly well work this out | 19:05 |
| cjwatson | (he says handwaving furiously; no doubt there are performance implications and I don't immediately know whether it would be the sort of thing that could only be fixed for future uploads) | 19:06 |
| pmcgowan | kenvandine, silo 17 can publish | 19:06 |
| slangasek | cjwatson: ack | 19:07 |
| Saviq | sil2100, cjwatson, got it, thanks | 19:09 |
| robru | pmcgowan: sorry I'm a little behind on the publishings, I'll get to that. | 19:12 |
| robru | pmcgowan: eh, that branch has a Needs Fixing from seb and no further commits to fix seb's concerns. | 19:14 |
| kenvandine | pmcgowan, the MP still isn't approved | 19:15 |
| kenvandine | pmcgowan, a few hours ago seb128 gave it another needs fixing... | 19:17 |
| kenvandine | not sure if the issue he found was addressed | 19:17 |
| pmcgowan | oh | 19:17 |
| kenvandine | pmcgowan, it was the same complaint seb had last week | 19:18 |
| robru | sergiusens: you got utopic1 | 19:20 |
| sergiusens | ty | 19:21 |
| robru | yw ;-) | 19:21 |
| robru | bfiller: camera-app building in rtm8 https://ci-train.ubuntu.com/job/ubuntu-rtm-landing-008-1-build/11/console | 19:24 |
| bfiller | robru: cheers | 19:24 |
| robru | bfiller: you're welcome! | 19:25 |
| kenvandine | pmcgowan, also... it looks like that silo needs to be rebuilt anyway | 19:26 |
| kenvandine | pmcgowan, the previous landing was merged into trunk an hour ago | 19:27 |
| robru | kenvandine: ugh, can you pocket copy silo rtm16 into 14.09-proposed? citrain is too stupid to publish it: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu-rtm/landing-016 | 19:27 |
| kenvandine | but the ppa was rebuilt 4 hours ago | 19:27 |
| kenvandine | robru, are you sure it needs a copy? | 19:28 |
| kenvandine | and if so... how do i do that? | 19:28 |
| kenvandine | copy-package or something? | 19:28 |
| sergiusens | yeah | 19:28 |
| robru | kenvandine: yeah, same way you'd ever upload anything to -proposed ;-) | 19:28 |
| kenvandine | oh... a dput? | 19:28 |
| robru | kenvandine: I'm sure I could spend my entire shift debugging why citrain refuses to publish it since it's clearly built in the PPA. | 19:28 |
| kenvandine | i thought there was a fancy tool for it :) | 19:28 |
| robru | kenvandine: I guess copy-package. i'm not a core dev, you should know this stuff ;-) | 19:29 |
| kenvandine | i've never done copies :) | 19:29 |
| robru | kenvandine: yeah, it's just like... configged a silo for that one project, built that project, PPA clearly has that project built, bfiller tested it. go to publish "can't publish this! It didn't build!" yes citrain, I TOTALLY BELIEVE YOU. | 19:29 |
| kenvandine | a dput should work though | 19:29 |
| robru | kenvandine: dput would work but you'd have to dget the package first. copy-package should be able to do it in one step | 19:30 |
| cjwatson | dput would also require a rebuild. | 19:31 |
| cjwatson | copy-package --from=~ci-train-ppa-service/ubuntu-rtm/landing-016 --suite=utopic --to=ubuntu-rtm --to-suite=14.09-proposed -b <list of source packages> | 19:32 |
| cjwatson | make sure your lp:ubuntu-archive-tools checkout is reasonably up to date | 19:32 |
| kenvandine | ok | 19:33 |
| kenvandine | cjwatson, can i do copy-package as core dev? or is that archive admin? | 19:33 |
| cjwatson | anyone who can upload something can also specify it as a copy target | 19:33 |
| kenvandine | cool | 19:33 |
| cjwatson | (hence, self-service syncs from Debian - it's the same system) | 19:34 |
| kenvandine | yeah, i do those | 19:34 |
| cjwatson | in that case there's a special syncpackage tool for it, but it winds up as the same API calls. copy-package does less handholding but is more powerful | 19:35 |
| kenvandine | robru, done! | 19:35 |
| cjwatson | including the -b option which you need here to avoid rebuilding | 19:35 |
| kenvandine | cjwatson, thanks | 19:35 |
| cjwatson | np | 19:36 |
| cjwatson | huh, I said --suite=utopic which was wrong, should have been --suite=14.09. did that somehow magically work or did you correct my typo? | 19:37 |
| kenvandine | i did it right :) | 19:37 |
| kenvandine | i saw what you did there | 19:37 |
| cjwatson | oh good, reality is aligned with expectations | 19:37 |
| cjwatson | always nice when that happens | 19:37 |
| kenvandine | indeed | 19:37 |
| robru | kenvandine: cjwatson: thanks | 19:40 |
| robru | no! | 19:42 |
| sil2100 | ;D | 19:45 |
| sil2100 | Ok, I think it's time to EOD already, see you tomorrow o/ | 19:46 |
| ToyKeeper | Do we have a bug for the dash occasionally getting stuck in a permanent "still starting" loop? | 19:58 |
| tedg | robru, Can I get a silo for line 48 please? | 20:15 |
| robru | tedg: ok you got 2 | 20:20 |
| robru | no wait | 20:20 |
| robru | crap | 20:20 |
| robru | tedg: conflicts with silo 8 | 20:20 |
| tedg | Oh, uhg. | 20:21 |
| tedg | charles, ^ | 20:21 |
| tedg | I guess I'll mark that one as not ready until rsalveti's silo lands then. | 20:22 |
| robru | tedg: poke rsalveti to test that ;-) | 20:22 |
| robru | tedg: also one URL is a branch not an MP, please fix that. | 20:23 |
| tedg | robru, Oops, fixed. | 20:24 |
| kenvandine | pmcgowan, i kicked a rebuild of silo 17, since we know it's outdated anyway | 20:26 |
| pmcgowan | kenvandine, why? | 20:26 |
| kenvandine | it hasn't been rebuild since the last settings landing | 20:26 |
| kenvandine | so it doesn't included everything that's in trunk | 20:26 |
| pmcgowan | but we still need an mr fix right? | 20:26 |
| kenvandine | yeah | 20:26 |
| kenvandine | or at least some understanding of the problem | 20:27 |
| kenvandine | pmcgowan, did you test it? | 20:27 |
| pmcgowan | kenvandine, no | 20:27 |
| kenvandine | ok | 20:27 |
| kenvandine | seb was seeing blank rows and such | 20:27 |
| pmcgowan | dbarth, chatting about your mr, didnt work for seb | 20:27 |
| pmcgowan | oh I did test it a while ago and saw similar, figured it was early days | 20:28 |
| kenvandine | dbarth, it was the same problem seb commented about on friday | 20:28 |
| dbarth | pmcgowan: i saw | 20:32 |
| dbarth | but i wonder if he tested the right packages | 20:32 |
| dbarth | i re-tested with the packages from silo 17, and the 2 broken entries i had are now properly filtered | 20:33 |
| pmcgowan | I can try it again once it builds | 20:33 |
| dbarth | pmcgowan: the packages in the ppa should already work | 20:33 |
| kenvandine | dbarth, ok, it didn't look like the commits since his comment fixed that | 20:33 |
| dbarth | the build was finished around 6pm CET this afternoon | 20:34 |
| kenvandine | yeah, just out dated | 20:34 |
| dbarth | i imagine | 20:34 |
| kenvandine | dbarth, it finished 3 hours past the last merge to trunk | 20:34 |
| dbarth | ? | 20:34 |
| dbarth | theer was no merge, was it? | 20:35 |
| pmcgowan | dbarth, kenvandine his comment is before jenkins made new packages | 20:35 |
| * pmcgowan gets the debs | 20:36 | |
| dbarth | i can confirm with him tomoow, but if we want to clear this silo, it's quick to check | 20:36 |
| kenvandine | ok | 20:36 |
| kenvandine | dbarth, we still need the rebuild, to get in sync with trunk | 20:37 |
| dbarth | ah | 20:37 |
| pmcgowan | oh so I should wait for the silo | 20:39 |
| kenvandine | dbarth, sorry, we kept on trucking with landings since your branch wasn't approved yet | 20:41 |
| dbarth | kenvandine: ok, if it rebuilds, we can test soon anyway | 20:51 |
| kenvandine | dbarth, ok... i need to get a quick landing in front of you again... sorry | 20:52 |
| kenvandine | dep issue for rtm landings | 20:52 |
| dbarth | kenvandine: it's a consipracy or what? ;) | 20:54 |
| kenvandine | dbarth, haha... sorry :) | 20:55 |
| lool | ah hey folks | 20:55 |
| lool | sorry I should have discussed this here | 20:55 |
| kenvandine | hey | 20:56 |
| lool | kenvandine: do we need permission to go with this? | 20:57 |
| lool | kenvandine: dbarth said it's ok to land this first | 20:57 |
| lool | kenvandine: if you dont mind, would you land it? | 20:57 |
| kenvandine | lool, so to quickly handle this dep, i'll change the dep to add the ~ | 20:57 |
| lool | yeah | 20:57 |
| kenvandine | lool, will do | 20:57 |
| lool | just suffix the current one with a ~, that should work | 20:57 |
| lool | and it's good practice all the time BTW, including in bdeps etc. | 20:58 |
| lool | kenvandine: thanks! | 20:58 |
| kenvandine | lool, can you give me an approval on the MP? | 20:59 |
| kenvandine | lool, indeed | 20:59 |
| lool | kenvandine: sure thing | 20:59 |
| kenvandine | Tweak the depends for accountsservice-ubuntu-schemas to handle a "~" version | 20:59 |
| kenvandine | whoops | 21:00 |
| kenvandine | https://code.launchpad.net/~ken-vandine/ubuntu-system-settings/dep_tweak/+merge/233426 | 21:00 |
| kenvandine | copy/paste bug :) | 21:00 |
| kenvandine | lool, i'll jockey this through quickly | 21:00 |
| lool | kenvandine: approved | 21:00 |
| kenvandine | lool, silo 11 | 21:02 |
| kenvandine | wow... right as 11 freed up :) | 21:03 |
| kenvandine | dbarth, after this lands and merges, i'll make sure your silo gets a rebuild | 21:04 |
| kenvandine | so it's ready for testing when you get up tomorrow :) | 21:04 |
| ToyKeeper | robru: It seems I no longer have write access to the spreadsheet. Could you add access for me, or mark row 39 as QA approved? | 21:08 |
| robru | ToyKeeper: one sec | 21:09 |
| robru | ToyKeeper: hm, it says it was shared with you already, are you perhaps not logged in? | 21:10 |
| ToyKeeper | Yes, it's possible. I was out for long enough I've had a bunch of sessions expire. | 21:10 |
| robru | ToyKeeper: anyway i marked it as approved for you, if you still can't access after signing in, file that with RT or something, because that's just weird. | 21:10 |
| ToyKeeper | robru: Thanks. :) | 21:11 |
| robru | ToyKeeper: you're welcome | 21:11 |
| dbarth | kenvandine: cool | 21:12 |
| popey | fginther: any progress? | 21:12 |
| dbarth | kenvandine: thanks | 21:12 |
| kenvandine | dbarth, np... sorry for needing to jump in front :) | 21:12 |
| kenvandine | dbarth, you have a good night | 21:12 |
| robru | ogra_: you gonna need RTM for that as well? | 21:12 |
| ToyKeeper | Huh, weird. SSO just responded in both english and in a language I don't recognize. | 21:12 |
| ogra_ | robru, yep | 21:12 |
| robru | ogra_: ok you got utopic14 | 21:13 |
| ogra_ | thanks ! | 21:13 |
| fginther | popey, looks healthy again | 21:13 |
| fginther | popey, go for ti | 21:13 |
| fginther | it | 21:13 |
| robru | ogra_: you're welcome | 21:15 |
| robru | alright I gotta run some errands, back in an hour or so, cyphermox can cover landings if anybody needs anything urgently ;-) | 21:15 |
| cyphermox_ | o/ | 21:16 |
| popey | fginther: kk | 21:18 |
| balloons | fginther, it seems the prints don't appear for the failures for python3; https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/fix-1359167/+merge/233387/comments/569665 | 21:26 |
| popey | fginther: failed http://91.189.93.70:8080/job/generic-mediumtests-utopic-weather-app/90/console | 21:26 |
| popey | does that need a merge from trunk? | 21:27 |
| rsalveti | tedg: robru: charles: should be done with my silo in a few | 21:36 |
| rsalveti | robru: will trigger another image, ok? | 21:37 |
| rsalveti | ubuntu touch | 21:37 |
| tedg | rsalveti, Did you see my comments on the MR? | 21:38 |
| cyphermox_ | rsalveti: robru is out for a bit | 21:38 |
| rsalveti | tedg: not yet | 21:38 |
| cyphermox_ | rsalveti: feel free to trigger a new image, I don't think there'd be any blockers | 21:38 |
| rsalveti | tedg: I'm not checking for audio-sink because at that point there's no way to not have an audio-sink | 21:39 |
| rsalveti | tedg: but can add a check if you prefer | 21:39 |
| fginther | popey, yes, that just needs a merge to trunk and someone to resolve the conflict in that MP | 21:40 |
| rsalveti | tedg: and the manual test needs to be part of pulseaudio, not the indicator | 21:40 |
| tedg | rsalveti, I think because you're dereferencing it (thus would crash) in the next line, it's important. | 21:40 |
| rsalveti | already covering that | 21:40 |
| rsalveti | tedg: sure, it's just that if that fails, you have way bigger problems :-) | 21:41 |
| rsalveti | but no worries, will update | 21:41 |
| fginther | balloons, I fixed the missing test results and reran that MP | 21:41 |
| * fginther swears at jenkins | 21:41 | |
| balloons | :-) | 21:41 |
| sergiusens | fginther: do we have a jenkins replacement already? | 21:45 |
| sergiusens | :-D | 21:46 |
| balloons | fginther, anyways on the py3 thing, it looks like we'll just need to coordinate mp's with you switching the jobs over.. the debian packaging and cmake just need to be told to go to python3. That's why the massive failures. At least I get it now | 21:52 |
| fginther | balloons, ack | 21:57 |
| fginther | balloons, is elopio's MP ready to land soon? | 21:58 |
| pmcgowan | kenvandine, I tested the debs from the silo, not sure if its working correctly or not | 21:59 |
| rsalveti | tedg: mind checking the mr again? | 22:00 |
| pmcgowan | I dont get blank lines, but I granted webbrowser access and it doesn show in the list | 22:00 |
| rsalveti | tedg: https://code.launchpad.net/~rsalveti/indicator-datetime/adding-media-role/+merge/233299 | 22:00 |
| pmcgowan | kenvandine, but camera does | 22:00 |
| * tedg clicks | 22:00 | |
| balloons | fginther, we have to land my https://code.launchpad.net/~nskaggs/ubuntu-calendar-app/fix-1359167/+merge/233387 first, which has the py3 conversion in it | 22:01 |
| tedg | rsalveti, Cool, thanks, looks good. | 22:02 |
| rsalveti | tedg: thanks | 22:02 |
| imgbot | === trainguards: IMAGE 222 building (started: 20140904 22:10) === | 22:10 |
| cyphermox_ | rsalveti: you wanna help with mtp so I'm not the only one to have tested the fixes? | 22:15 |
| cyphermox_ | (it's silo 10) | 22:15 |
| cyphermox_ | sergiusens: how did your testing go for mtp? | 22:15 |
| sergiusens | cyphermox_: approved the mp, didn't you see? | 22:15 |
| cyphermox_ | I did | 22:16 |
| cyphermox_ | but you didn't test the silo | 22:16 |
| sergiusens | cyphermox_: oh, you didn't ask me to ;-) | 22:16 |
| sergiusens | cyphermox_: I can though, utopic or rtm? | 22:16 |
| cyphermox_ | utopic silo 10 | 22:17 |
| cyphermox_ | sergiusens: it's jsut a formality since you already built it and everything | 22:17 |
| rsalveti | it seems sergiusens will test it :-) | 22:17 |
| cyphermox_ | ack | 22:17 |
| sergiusens | cyphermox_: I didn't actually ;-) | 22:17 |
| sergiusens | cyphermox_: I grabbed the jenkins build | 22:17 |
| cyphermox_ | as long as I'm not the only one to test my own code... | 22:17 |
| sergiusens | rsalveti: well you can help with krillin and utopic | 22:18 |
| sergiusens | I've just flashed that again | 22:18 |
| rsalveti | what is the fix? | 22:18 |
| sergiusens | rsalveti: copy to sdcard | 22:18 |
| rsalveti | cool | 22:18 |
| sergiusens | rsalveti: and switch lang to french, music will be translated | 22:19 |
| sergiusens | and so on | 22:19 |
| ogra_ | really ? | 22:21 |
| cyphermox_ | ogra_: yes? | 22:21 |
| * ogra_ always wanted to hear his songs in french | 22:21 | |
| ogra_ | i have to try that ! | 22:21 |
| cyphermox_ | I made sure you could only translate to french though, that's to help with the master plan of making Ubuntu Touch french-only, and finally establish our language as the one true Ubuntu language :) | 22:22 |
| ogra_ | does the artist need to be able to speak french to have the lyrics translated ? | 22:22 |
| ogra_ | or does it just work on the fly with all music ? | 22:23 |
| ogra_ | :) | 22:23 |
| sergiusens | cyphermox_: ogra_ x-use-langpacks makes the langpacks not be in the deb though, right? | 22:25 |
| sergiusens | the mo's that is | 22:26 |
| ogra_ | the .mo/.po files | 22:26 |
| ogra_ | right | 22:26 |
| sergiusens | so I can't test the lang until we get one of those released | 22:26 |
| sergiusens | but jenkins ignores that flag and it worked there | 22:26 |
| cyphermox_ | ogra_: it's highly experimental on-the-fly translation ;D | 22:26 |
| sergiusens | so it's all good | 22:26 |
| ogra_ | cyphermox_, lol | 22:26 |
| cyphermox_ | no need to know how to speak french, it will work | 22:27 |
| cyphermox_ | you'll magically understand everything too, because it will appear as though it's the original language | 22:27 |
| ogra_ | babelfrench ! | 22:27 |
| ogra_ | *twiddle* | 22:35 |
| * ogra_ vomits over the broken changelog that came out of the silo | 22:55 | |
| ogra_ | so annoying | 22:56 |
| ogra_ | (was kind of pointlless that i used -v when generating it ... the silos always cut off the end :( ) | 22:56 |
| alecu | hi trainguards. A click-scope silo landed about three hours ago in rtm via sync:xxx. Do you guys know why it does not show up when trying to apt-get upgrade it in a clean rtm image? | 23:07 |
| ogra_ | plars, if i dont manage to land the adbd change in rtm tonight, will you get along ? | 23:20 |
| sergiusens | robru: ^ can I get the rtm instance setup now? | 23:21 |
| ogra_ | (it is still migrating to utopic and til i get the rtm silo ready i'll have been fallen asleep) | 23:21 |
| sergiusens | also, if I click build, is there auto logic for it to do the copy for me? | 23:21 |
| sergiusens | or is sync:X not meant for us? | 23:21 |
| cyphermox_ | sergiusens: i setup your rtm instance nao | 23:29 |
| sergiusens | thanks | 23:30 |
| cyphermox_ | is it already in the spreadsheet? | 23:30 |
| cyphermox_ | there i get my answer | 23:30 |
| sergiusens | cyphermox_: did rsalveti get a change to test mtp as well; or is it all on me? | 23:30 |
| cyphermox_ | all you I think | 23:31 |
| cyphermox_ | well, I did too | 23:31 |
| sergiusens | cyphermox_: but I'm drinking a 9% beer at this hour :-P | 23:31 |
| rsalveti | not yet | 23:31 |
| ChickenCutlass | sergiusens: 9%. wimp | 23:31 |
| cyphermox_ | I'm finishing up a very very tiny amount of port :/ | 23:31 |
| sergiusens | well it has my ack | 23:31 |
| sergiusens | ChickenCutlass: we should have team dinner at a good brewery ;-) | 23:32 |
| ChickenCutlass | sergiusens: trust me — I will work it out | 23:32 |
| sergiusens | \o/ | 23:32 |
| ChickenCutlass | sergiusens: all the other teams will be jealous | 23:32 |
| sergiusens | or just do a beer tour | 23:32 |
| sergiusens | hop into brewery, drink, hop out | 23:32 |
| sergiusens | I don't care about dinner | 23:32 |
| sergiusens | :) | 23:32 |
| ChickenCutlass | sergiusens: right — just a prezel here and there | 23:33 |
| ogra_ | phew | 23:33 |
| sergiusens | works for me | 23:33 |
| ogra_ | how painful that was | 23:33 |
| ChickenCutlass | ogra_: is it done | 23:33 |
| sergiusens | doneded | 23:33 |
| ogra_ | 3h silo munching vs a 30sec upload | 23:33 |
| ogra_ | ChickenCutlass, i know :) | 23:33 |
| ogra_ | ChickenCutlass, but only the utopic part | 23:34 |
| ChickenCutlass | ugh | 23:34 |
| ogra_ | rtm is another cycle like this | 23:34 |
| cyphermox_ | sergiusens: nitpicking, but your DH_GOLANG_INSTALL_ALL change isn't in changelog | 23:34 |
| ogra_ | plus QA | 23:34 |
| sergiusens | ogra_: maybe after the crunch, we should migrate adb (the parts we care about) to go | 23:34 |
| ogra_ | which is why i'll give up now ... i wont survive another 3h tonight | 23:34 |
| ogra_ | sergiusens, god forbid ! | 23:34 |
| ogra_ | clean C | 23:35 |
| ogra_ | :) | 23:35 |
| sergiusens | cyphermox_: argh, I could add it | 23:35 |
| cyphermox_ | ogra three hour of what? | 23:35 |
| cyphermox_ | sergiusens: don't bother | 23:35 |
| sergiusens | probably some checker would do some good at the jenkins level | 23:35 |
| * sergiusens ping fginther for MORE work :-) | 23:35 | |
| cyphermox_ | checker for this stuff? | 23:35 |
| cyphermox_ | it's not really something you can work out programmatically | 23:36 |
| ogra_ | cyphermox_, getting a silo ... uploading ... building ... testing on two devices ... finding an issue ... spending 10min on a fix ... start over .... | 23:36 |
| sergiusens | cyphermox_: well the packaging ack check at the jenkins level might help me notice I need to update it | 23:36 |
| ogra_ | overall i started 3h ago | 23:36 |
| cyphermox_ | sergiusens: I guess | 23:36 |
| sergiusens | ogra_: you are finally enjoying the train! | 23:36 |
| ogra_ | and the silo stuff stole half my changelog :( | 23:36 |
| sergiusens | ogra_: again... welcome to the train ;-) | 23:36 |
| cyphermox_ | ogra_: if you set changelog in your changes it shouldn't touch it | 23:37 |
| ogra_ | sergiusens, well, usually i dont need to land in both distros at the same time | 23:37 |
| sergiusens | ogra_: heh :-) | 23:37 |
| ogra_ | sergiusens, its absolutely fine if you can do it as a side job and leave it do its stuff while you do something else | 23:37 |
| ogra_ | it only gets painful if you have to watch it all the time | 23:38 |
| sergiusens | ogra_: oh, I can't do that; stuff rots that way | 23:38 |
| cyphermox_ | rsalveti: did you plan to test mtp or should I set it to testing pass now? | 23:38 |
| rsalveti | cyphermox_: still doing some other stuff, so feel free to give +1 | 23:38 |
| sergiusens | cyphermox_: I'm +1 on that | 23:38 |
| cyphermox_ | ack, marking as done | 23:38 |
| sergiusens | fixes one of those blockers in the email, so good | 23:38 |
| ogra_ | cyphermox_, i did two revisions ... created the .changes file with -v to have them both in .... only the one liner of the second change ends up in the final package ... the 20 page novel for the former revision is gone | 23:39 |
| sergiusens | ogra_: that may be part of the "hot fix" to prevent changelogs from version 0 to present :-P | 23:39 |
| cyphermox_ | rsalveti: want to ack packaging changes? https://ci-train.ubuntu.com/job/ubuntu-landing-010-2-publish/lastSuccessfulBuild/artifact/packaging_changes_mtp_0.0.4+14.10.20140904-0ubuntu1.diff | 23:41 |
| cyphermox_ | or sergiusens | 23:41 |
| sergiusens | cyphermox_: I'm not core | 23:41 |
| sergiusens | just ppu | 23:41 |
| rsalveti | cyphermox_: looks fine | 23:41 |
| cyphermox_ | you aren't? | 23:41 |
| sergiusens | cyphermox_: no, not sure if I have rsalveti's blessing still :-P | 23:41 |
| cyphermox_ | dude. | 23:41 |
| cyphermox_ | dum de dum.. | 23:42 |
| sergiusens | i know :-) | 23:42 |
| rsalveti | sergiusens: you always had my +1 :P | 23:43 |
| sergiusens | rsalveti: you said I should wait ;-) | 23:43 |
| sergiusens | rsalveti: I did a thread Join and waiting for that to finish | 23:43 |
| rsalveti | ahah, just said what people would tell you anyway | 23:43 |
| * sergiusens checks who's on the board these days | 23:44 | |
| cyphermox_ | robru: I don't want to touch things you may have already been working on, not sure if I just push the buttons for dbarth's silo 17 | 23:46 |
| kenvandine | cyphermox_, don't publish silo 17 | 23:48 |
| cyphermox_ | kenvandine: ah, thanks for letting me know :) | 23:48 |
| kenvandine | I don't think the MP is approved yet | 23:49 |
| kenvandine | and seb had problems with it | 23:49 |
| kenvandine | and i just published settings in silo 11 | 23:49 |
| imgbot | === trainguards: IMAGE 222 DONE (finished: 20140904 23:50) === | 23:50 |
| imgbot | === changelog: http://people.canonical.com/~ogra/touch-image-stats/222.changes === | 23:50 |
| ogra_ | look, an image | 23:50 |
| kenvandine | cyphermox_, i'm not sure why the spreadsheet listed the MP as ready, since it had never been approved | 23:50 |
| ogra_ | 2am here ... i guess the rtm side has to wait til tomorrow morning | 23:50 |
| * ogra_ gies to bed ... | 23:51 | |
| ogra_ | *goes | 23:51 |
| * kenvandine toggled that back to no :) | 23:51 | |
| sergiusens | ogra_: or *dies ? | 23:51 |
| cyphermox_ | ack | 23:51 |
| ogra_ | sergiusens, hah | 23:51 |
| ogra_ | close :) | 23:51 |
| kenvandine | lool, i just published silo 11 | 23:51 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
