| smoser | harlowja, JayF lp:~smoser/cloud-init/os-vd-cleanup | 01:20 |
|---|---|---|
| smoser | https://code.launchpad.net/~smoser/cloud-init/os-vd-cleanup | 01:20 |
| harlowja | cool | 01:22 |
| harlowja | just one problem ;) | 01:23 |
| harlowja | smoser i think u want to use the raw json loads here then | 01:24 |
| harlowja | http://bazaar.launchpad.net/~cloud-init-dev/cloud-init/trunk/view/head:/cloudinit/sources/helpers/openstack.py#L224 | 01:24 |
| harlowja | util.load_json doesn't allow non-dicts as the root type | 01:24 |
| harlowja | so u might want to switch that to just json.loads as the function | 01:25 |
| === praneshp_ is now known as praneshp | ||
| === harlowja is now known as harlowja_away | ||
| === zz_gondoi is now known as gondoi | ||
| smoser | harlowja_away, i think i just fixed that http://bazaar.launchpad.net/~smoser/cloud-init/os-vd-cleanup/revision/1013 | 14:41 |
| JayF | looking at that now smoser | 16:34 |
| JayF | the vd merge req from late yesterday afternoon | 16:34 |
| === harlowja_away is now known as harlowja | ||
| harlowja | smoser checking | 17:09 |
| smoser | JayF, the idea would be to keep the _pure available, and we'd read the networking information from there as it would not be under cloud-init. | 17:10 |
| harlowja | smoser looks good | 17:11 |
| JayF | you know how I said I was looking at it | 17:11 |
| harlowja | those the root types u wanted, no numbers and such i guess | 17:11 |
| JayF | what I meant was I opened it in a tab and got distracted for 40m | 17:11 |
| JayF | he | 17:11 |
| JayF | *heh | 17:11 |
| JayF | Is there a way in LP to view a diff of a branch vs the master? | 17:12 |
| JayF | or do I have to pull that revision down to see a diff | 17:12 |
| smoser | JayF, you have to propose it for mergint. | 17:13 |
| smoser | JayF, http://paste.ubuntu.com/8320474/ | 17:14 |
| JayF | smoser: lgtm -- so the idea is that I can add a hook, that checks to see if self.vendordata_pure is a dict, and if so, if it contains vd['network_magic_string'] and if so, take that data and do things with it | 17:16 |
| smoser | JayF, yeah. the "hook" is already there really | 17:18 |
| smoser | you'll just improve the code that does it for 'interaces' | 17:19 |
| smoser | results['network_config'] = self._read_content_path(net_item) | 17:19 |
| smoser | that stuff | 17:19 |
| smoser | in cloudinit/sources/helpers/openstack.py | 17:19 |
| JayF | makes sense | 17:19 |
| === gondoi is now known as zz_gondoi | ||
| === zz_gondoi is now known as gondoi | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!