| nik90 | elopio: ping me when you are online. We can discuss https://code.launchpad.net/~canonical-platform-qa/ubuntu-clock-app/xvfb_and_qml_tests/+merge/234421 | 14:46 |
|---|---|---|
| elopio | ping nik90 | 15:02 |
| nik90 | elopio: hey | 15:02 |
| nik90 | elopio: I was looking at your MP in the morning | 15:02 |
| nik90 | elopio: and when opening it in qtc, I noticed Qml tests disabled: xvfb-run not found | 15:03 |
| nik90 | this was on my laptop which has xvfb installed | 15:03 |
| elopio | nik90: hello. I was just trying to run the tests with xvfb, because fginther said they failed for him on CI. | 15:06 |
| elopio | but lets see... On qtcreator, on the build -> make menu | 15:07 |
| elopio | I only see check, autopilot, install, uninstall. How do I get to run make test? | 15:07 |
| nik90 | me too | 15:07 |
| nik90 | I used to do it manually from terminal | 15:07 |
| nik90 | so I used to do mkdir builddir && cd builddir | 15:07 |
| nik90 | cmake .. && make | 15:07 |
| nik90 | then make test | 15:07 |
| balloons | elopio, fyi, francis's experiments are not in the normal clock app CI jobs | 15:09 |
| elopio | nik90: making from the builddir doesn't work because cmake is creating the files on the root of the branch. | 15:09 |
| elopio | http://paste.ubuntu.com/8327808/ | 15:10 |
| elopio | balloons: you mean that they are not run on MPs? | 15:10 |
| nik90 | elopio: the steps I mentioned above works for me | 15:11 |
| nik90 | elopio: well the tests don't run since I am trying to run this on trusty | 15:12 |
| nik90 | elopio: but make test correctly shows the tests | 15:12 |
| balloons | elopio, no they are not atm. francis tried but didn't succeed in getting them to run.. | 15:13 |
| balloons | they are not in the mp jobs | 15:14 |
| elopio | nik90: I might had a cmake cache or something. Now it's writing the files on the builddir. | 15:14 |
| elopio | and yes, make test works. | 15:14 |
| elopio | so I'm not sure where are you getting the message that xvfb is not found. | 15:15 |
| nik90 | elopio: so when you opened it in qtc, how did you run the tests? | 15:16 |
| nik90 | elopio: since I don't see tests in the build->make menu | 15:17 |
| elopio | nik90: I didn't run them from qtc. That was my first question. | 15:17 |
| nik90 | elopio: ah ok..I don't think it will work with qtc, or atleast that's not the goal. | 15:17 |
| nik90 | elopio: command line works | 15:17 |
| elopio | nik90: I'm confused :) | 15:20 |
| elopio | but if you think it's ok, I'm ok. | 15:20 |
| nik90 | elopio: I am a bit confused as well :P | 15:20 |
| nik90 | elopio: ok so previously one couldn't run qml tests in qtc. | 15:20 |
| nik90 | elopio: when you changed the cmake files, I figured you added a custom target for make tests to make it runnable from within qtc. | 15:21 |
| nik90 | elopio: but I see that wasn't the case, which is why I said it is okay | 15:21 |
| elopio | nik90: well, make test doesn't need a custom target. I thought qtc would find it anyway. | 15:23 |
| elopio | and in your initial implementation, you didn't have a custom target either. | 15:23 |
| nik90 | yup I didn't | 15:24 |
| elopio | I could add one to see what happens. | 15:24 |
| nik90 | its just a luxury, so if you want to go ahead | 15:24 |
| elopio | hum, but then add_test I think wouldn't work. | 15:25 |
| elopio | zbenjamin: how can we run make test from qtcreator? | 15:25 |
| zbenjamin | elopio: well you could add a custom run configuration that executes make test in the builddirectory | 18:00 |
| === zbenjamin is now known as 6JTAAFWR0 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!