=== _salem is now known as salem_ | ||
=== salem_ is now known as _salem | ||
mzanetti | greyback: good morning. I addressed all your comments in the qtmir merge. | 09:28 |
---|---|---|
greyback | mzanetti: cool thanks | 09:28 |
greyback | mzanetti: ah sorry I didn't realize there was a unity8 branch to go with it | 09:29 |
mzanetti | greyback: no worries | 09:30 |
mzanetti | greyback: if you want to test, it should be enough to copy Shell.qml from that unity8 branch to the device | 09:30 |
mzanetti | no need to build a package | 09:30 |
greyback | mzanetti: yep | 09:30 |
mzanetti | huh... why does "df -h" not show my partitions any more? | 09:37 |
mzanetti | only virtual file systems in there | 09:38 |
facundobatista | Hola | 11:10 |
mzanetti | Saviq: hey, want to have a look at those so we can get it approved before you're away: https://code.launchpad.net/~unity-team/unity8/two_see_more_bugfix/+merge/234340/comments/572776 | 11:12 |
mzanetti | its really minor things | 11:12 |
=== MacSlow is now known as MacSlow|lunch | ||
=== _salem is now known as salem_ | ||
=== MacSlow|lunch is now known as MacSlow | ||
greyback | mzanetti: lifecycle fixes approved | 12:44 |
MacSlow | Saviq, can you have a quick look at https://code.launchpad.net/~macslow/unity-notifications/synchronous-notification/+merge/229060 | 13:07 |
MacSlow | Saviq, I'm confused about that "automatic" merge that just happened | 13:08 |
Saviq | MacSlow, you pushed to trunk | 13:09 |
Saviq | MacSlow, https://code.launchpad.net/~unity-api-team/unity-notifications/trunk | 13:09 |
MacSlow | How? | 13:09 |
MacSlow | Crap! | 13:09 |
Saviq | MacSlow, will you resolve or shall I? | 13:11 |
MacSlow | just doing that | 13:11 |
MacSlow | Saviq, hm... kind of stuck with fixing the accidental merge... | 13:29 |
Saviq | MacSlow, can I overwrite trunk? | 13:30 |
Saviq | MacSlow, ugh, you overwrote? | 13:30 |
Saviq | MacSlow, https://code.launchpad.net/~ps-jenkins/unity-notifications/ubuntu-utopic-proposed should be the good thing | 13:31 |
MacSlow | Saviq, correct | 13:31 |
Saviq | MacSlow, so yeah, take that branch and overwrite trunk | 13:32 |
Saviq | MacSlow, and fix your bash history and push locations ;) | 13:32 |
MacSlow | Saviq, yeah... hell knows how that happened... I always explicitly do "bzr push lp:~macslow/bla..." | 13:33 |
MacSlow | Saviq, hm... fixed... but lp:unity-notifications on launchpad did not yet update | 13:40 |
Saviq | MacSlow, indeed, it will catch up | 13:43 |
MacSlow | phew... lp also updated now | 13:45 |
mzanetti | greyback: thanks! | 13:48 |
greyback | Saviq: we need an opinion: void fn(int var) { Q_UNUSED(var); } OR void fn(int) {} | 14:10 |
dandrader | Saviq, is that part of our word-of-mouth coding guidelines/ http://paste.ubuntu.com/8327396/ | 14:12 |
dandrader | ? | 14:12 |
Saviq | dandrader, greyback, Q_UNUSED generally leads to Q_UNUSED being left around when it is, in fact, used | 14:13 |
Saviq | I don't have a strong opinion but was leaning towards /**/ | 14:14 |
dandrader | Saviq, you mean later someone actually starts using a parameter but forgets to remove the corresponding Q_UNUSED() line? | 14:14 |
Saviq | dandrader, yes | 14:14 |
dandrader | Saviq, greyback, hmm, makes sense | 14:15 |
mterry | mzanetti, do you know how to anchor an element of the shell to the OSK? Normally you can ask for that behavior if you have a MainView, but we don't | 14:20 |
Saviq | dandrader, greyback, I'm not even sure we need the /* */, after all you're only an F4 away from the header | 14:20 |
mzanetti | mterry: Qt.inputMethod.rect or something like this | 14:21 |
Saviq | mzanetti, not in shell | 14:21 |
mzanetti | yeah, works in apps too | 14:21 |
Saviq | unless it's back with qtmir? | 14:21 |
mzanetti | oh... in the shell | 14:21 |
Saviq | mzanetti, Qt.inputMethod didn't work before qtmir, does it work again now? | 14:21 |
dandrader | Saviq, "F4", are you talking Qt-Creator? | 14:21 |
mzanetti | Saviq: mterry: there is an InputMethod item in Shell.qml | 14:21 |
mzanetti | you can probably anchor to that | 14:21 |
Saviq | dandrader, yes, but $your_ide's_shortcut works, too ;) | 14:21 |
* dandrader is old school and doesn't use such niceties | 14:22 | |
mterry | mzanetti, interesting, will try thanks! | 14:22 |
dandrader | mostly because vim doesn't do it reliably :D | 14:22 |
mterry | Saviq, aren't you supposed to be on holiday? | 14:23 |
Saviq | mterry, starting tomorrow | 14:23 |
mterry | Saviq, hrm... OK then, carry on ;) | 14:23 |
=== Malsasa_ is now known as Malsasa | ||
mzanetti | Saviq: https://code.launchpad.net/~unity-team/unity8/two_see_more_bugfix/+merge/234340/comments/572865 | 14:32 |
Saviq | mzanetti, yeah, saw that, will have a look | 14:32 |
mzanetti | Saviq: ok... I see (re sync MP) | 14:33 |
mzanetti | Saviq: is silo 11 about to land? | 14:33 |
Saviq | mzanetti, you tell me ;) | 14:34 |
mzanetti | ah ok | 14:34 |
Saviq | mzanetti, but no | 14:34 |
mzanetti | I thought you'll land that still today | 14:34 |
Saviq | mzanetti, there's a bunch of unapproved branches | 14:34 |
mzanetti | ack | 14:34 |
=== salem_ is now known as _salem | ||
=== dandrader is now known as dandrader|afk | ||
=== _salem is now known as salem_ | ||
dednick | mzanetti, satorisany idea how to catch individual role changes for model data in qml? | 14:48 |
dednick | Saviq: ^ | 14:48 |
dednick | * any idea | 14:48 |
mzanetti | dednick: ? | 14:48 |
mzanetti | emit dataChanged(index, index, QVector<int> roles) | 14:49 |
dednick | mzanetti: doesnt seem to work with Connections { target: modelData; onXXXChanged: {} } | 14:49 |
mzanetti | ah | 14:49 |
mzanetti | no. that won't do | 14:49 |
mzanetti | hmm | 14:49 |
mzanetti | dednick: you can do this: | 14:49 |
dednick | or onModelDataChanged | 14:49 |
mzanetti | property var foobar: model.barbaz | 14:49 |
mzanetti | onFooBarChanged | 14:49 |
dednick | mzanetti: yeah. though so | 14:49 |
mzanetti | not totally elegant though | 14:49 |
dednick | mzanetti: ok, thanks | 14:49 |
Saviq | MacSlow, https://code.launchpad.net/~unity-team/unity8/notifications-audio-no-play-empty/+merge/234486 | 14:53 |
MacSlow | Saviq, on it... | 14:54 |
Saviq | MacSlow, no worries, not pressing | 14:56 |
Saviq | @unity ↑ important to note; bool("") === false, but bool(QUrl("")) === true | 14:56 |
Saviq | I'd say a QTBUG really | 14:56 |
kgunn | wtf... | 14:57 |
mzanetti | I think QUrl("") actually only sets the path | 14:57 |
mzanetti | so there might be a valid authority or protocol string somewhere | 14:58 |
Saviq | dandrader|afk, mterry, paulliu http://pastebin.ubuntu.com/8327743/ | 15:01 |
Saviq | mzanetti, think it defaults to file:// ? | 15:01 |
MacSlow | Saviq, it is a bit odd | 15:01 |
MacSlow | Saviq, I mean the need for this kind of fix | 15:01 |
mterry | Saviq, sigh... fixed | 15:02 |
mzanetti | Saviq: likely, but I didn't verify | 15:02 |
Saviq | MacSlow, well, that's a different thing, our media components didn't deal well with playing an empty string (to be fixed) | 15:02 |
Saviq | MacSlow, but still we shouldn't even call play() on it | 15:02 |
mzanetti | Saviq: actually file:/// to be precise :D | 15:02 |
Saviq | mzanetti, you're kidding? | 15:03 |
mzanetti | ah no... "" might be 2 / only | 15:03 |
Saviq | mzanetti, that would be your slash | 15:03 |
Saviq | mzanetti, meaning your root directory | 15:03 |
mzanetti | :D | 15:03 |
MacSlow | Saviq, btw... approved | 15:04 |
Saviq | MacSlow, t | 15:04 |
Saviq | x | 15:04 |
MacSlow | Saviq, jenkis will take a while I guess | 15:04 |
Saviq | MacSlow, yeah | 15:04 |
MacSlow | Saviq, but since your branch is so fresh it should cleanly merge | 15:05 |
Saviq | MacSlow, yeah well, let's see if something in silo 11 conflicts | 15:05 |
greyback | dandrader|afk: FYI https://code.launchpad.net/~dandrader/unity-api/splash/+merge/233288 fails on CI | 15:11 |
mzanetti | Saviq: hey, do we actually have the gesture cancellation in place yet? | 15:15 |
mzanetti | we don't, right? | 15:16 |
paulliu | Saviq: ok. removed tags. Thanks. | 15:16 |
mzanetti | Saviq: IMO bugs like these are are misleading because they aren't so much of an issue any more when that is fixed: https://bugs.launchpad.net/ubuntu-ux/+bug/1368702 | 15:16 |
ubot5 | Launchpad bug 1368702 in ubuntu-ui-toolkit (Ubuntu) "[SDK] HEADER ISSUE: Back arrow needs to be moved further to the right and also have a larger invisible touch target" [Undecided,New] | 15:16 |
greyback | mzanetti: we don't have gesture cancellation | 15:17 |
Saviq | mzanetti, no | 15:20 |
Saviq | mzanetti, we don't have it I mean, and correct, that bug would be less important if we had it | 15:21 |
=== dandrader|afk is now known as dandrader | ||
mzanetti | Saviq: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1368702/comments/1 | 15:21 |
ubot5 | Launchpad bug 1368702 in unity8 (Ubuntu) "[SDK] HEADER ISSUE: Back arrow needs to be moved further to the right and also have a larger invisible touch target" [Undecided,New] | 15:21 |
Saviq | dandrader, do you have the new python version of the strip tags script? | 15:22 |
Saviq | dandrader, 'cause you seem to have the most of the two bad tags that are still travelling around | 15:22 |
dandrader | Saviq, I'lll download it again | 15:22 |
Saviq | dandrader, http://people.canonical.com/~msawicz/unity8/strip-u8-tags.py | 15:23 |
Saviq | dandrader, and remember you need to strip both local and remote, as tag deletion doesn't travel with commits | 15:23 |
Saviq | josharenson, please strip tags on lp:~josharenson/unity8/fix_panel_minute_count and any local checkouts you might have | 15:24 |
Saviq | josharenson, http://people.canonical.com/~msawicz/unity8/strip-u8-tags.py | 15:24 |
josharenson | saviq, ack... | 15:24 |
josharenson | has that script been updated recently? | 15:24 |
dandrader | Saviq, could you name a branch that has bad tags? | 15:25 |
dandrader | Saviq, I'm running it and it's not printing anything | 15:25 |
dandrader | Saviq, ah, finally got some tags in lp:~dandrader/unity8/real_header_splashscreen | 15:26 |
dandrader | s/got/found | 15:26 |
dandrader | Saviq, ahhhh! strip-u8-tags.py doesn't run on the current dir by default. you have to specify "strip-u8-tags.py ." | 15:29 |
Saviq | dandrader, http://pastebin.ubuntu.com/8327743/ | 15:29 |
dandrader | Saviq, now it's explained why I wans't finding anything locally | 15:29 |
Saviq | dandrader, oops, sorry, should probably make it work like that :) | 15:29 |
dandrader | Saviq, or print out an error like "please specify a directory" | 15:31 |
Saviq | dandrader, yeah, you know... that script was only supposed to live for a week or so :P | 15:31 |
Saviq | then it got rewritten in py, and was supposed to only live another week... | 15:31 |
dandrader | Saviq, all my branches should be clean now | 15:32 |
Saviq | dandrader, thanks | 15:33 |
josharenson | greyback, ready when you are | 15:33 |
=== salem_ is now known as _salem | ||
greyback | josharenson: https://plus.google.com/hangouts/_/canonical.com/gerry | 15:34 |
Saviq | josharenson, no, as long as you had the .py version | 15:34 |
dandrader | greyback, oh, right. should be fixed now (let's see what jenkins says next) | 15:40 |
mterry | greyback, how do I find out where the OSK is on screen (from the shell code) -- we used to have OSKController, now we have InputMethod, but it doesn't seem to give info on where on the screen is actually being drawn | 15:49 |
greyback | dandrader: thanks | 15:59 |
greyback | mterry: hmm. OSK is actually a maximized surface like any other (non-fullscreen) app surface, with lots of transparency. Shell doesn't know from that how big the OSK is | 16:00 |
Saviq | greyback, that's why we have the keyboard communicator socket? | 16:01 |
greyback | mterry: if InputMethod doesn't tell you, I'm not sure there's any other place to get that info right now | 16:01 |
Saviq | or... had... | 16:01 |
greyback | Saviq: yep | 16:01 |
mterry | greyback, I looked into how anchorToKeyboard works and it's doing "Qt.inputMethod.visible ? Qt.inputMethod.keyboardRectangle.height : 0" | 16:01 |
Saviq | greyback, do we have access to ↑ now? | 16:01 |
mterry | greyback, does that seem likely to work? | 16:01 |
mterry | Didn't in my quick test, but I'm probably doing something wrong, since that's what the SDK uses | 16:01 |
greyback | mterry: yeah that works for apps. I don't see any reason why it would not work for unity8 too, there may be somethinkg missing in the QPA for it | 16:02 |
Saviq | greyback, it didn't work before qtmir because shell was never focused | 16:02 |
greyback | mterry: if it's what the SDK uses, I'm sure we can make it work for shell | 16:02 |
Saviq | and it *did* work before that because Qt didn't care | 16:02 |
Saviq | and then it started caring | 16:02 |
greyback | Saviq: now the unity8 "Window" should be focused, or at least we can persuade Qt that it is | 16:03 |
mterry | greyback, so you're saying there may be qtmir work for this? | 16:03 |
Saviq | greyback, yeah, that'd be grand | 16:03 |
greyback | mterry: a little yeah | 16:03 |
mterry | greyback, OK. I think I'll go with a workaround for now, then file a qtmir bug about it for proper solution | 16:04 |
greyback | mterry: thanks | 16:05 |
=== dandrader_ is now known as dandrader|lunch | ||
=== _salem is now known as salem_ | ||
mterry | greyback, btw that Qt.inputMethod.keyboardRectangle.height trick did work after all -- forgot to get back to you on that | 19:32 |
greyback | mterry: it works? Oh great | 19:32 |
* greyback draws satisfying line through task in his TODO list | 19:32 | |
=== dandrader_ is now known as dandrader | ||
dandrader | greyback, what would be the best way to refer to an image in /usr/lib/$ARCH/qt5/qml/Ubuntu/Components/Themes/Ambiance/artwork/ | 20:22 |
dandrader | greyback, ^^^ that's about your comment https://code.launchpad.net/~dandrader/unity8/real_header_splashscreen/+merge/233286/comments/571898 | 20:23 |
dandrader | from unity8 | 20:24 |
greyback | dandrader: nothing easy springs to mind. But it's late here, so I'm not thinking hard right now | 20:37 |
dandrader | greyback, I think the only way would be to have a wrapper component there in Ubuntu/Components/Themes/Ambiance so unity8 could import it | 20:38 |
dandrader | like just an Image with a preset source | 20:38 |
dandrader | greyback, so easier to copy over like Florian did | 20:39 |
greyback | dandrader: could this be a component in the SDK, instead of copying all this stuff over? A kinda private component | 20:39 |
dandrader | greyback, are you talking about PageHeadStyle and MainViewStyle? | 20:41 |
greyback | yep | 20:41 |
dandrader | greyback, they are :D | 20:41 |
dandrader | greyback, but for the splash screen we needed modified versions of them | 20:41 |
dandrader | greyback, so they were copied over and modified | 20:41 |
dandrader | greyback, I believe mainly so that it's not tied to the theme of the qml scene but to a hardcoded one | 20:42 |
dandrader | greyback, florian left some todo's there about how it should be ideally in the future | 20:42 |
dandrader | greyback, but the way the sdk is implemented at the moment does not support such flexibility | 20:43 |
dandrader | greyback, thus the copy-over-and-modify approach | 20:43 |
greyback | dandrader: is a pity. I just forsee design changes in SDK happening that break this trick | 20:44 |
dandrader | greyback, error prone as it will have to be updated every time their sdk counterparts change, but it-just-works(Tm) | 20:44 |
dandrader | greyback, ditto | 20:44 |
greyback | dandrader: I'm not going to block this. I just dislike copying the images, so would like to explore all options before just copying | 20:54 |
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader | ||
=== PyAr is now known as alecu | ||
=== zoktar_ is now known as zoktar | ||
=== irsol_ is now known as irsol | ||
=== zoktar is now known as 77CAAFYCY | ||
=== salem_` is now known as _salem | ||
=== jamesh is now known as 6JTAAFV9I | ||
=== zbenjamin is now known as 6JTAAFWR0 | ||
=== hggdh is now known as 6JTAAFWBI |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!