| === jcsackett_ is now known as jcsackett | ||
| rick_h_ | morning huwshimi | 02:23 |
|---|---|---|
| huwshimi | :) | 02:25 |
| rick_h_ | I can haz orange box! :) | 02:30 |
| huwshimi | rick_h_: oh really?! In your house? | 02:40 |
| rick_h_ | huwshimi: yea, jcastro brought one home from his sprint but is taking swap days mon/tues | 02:40 |
| rick_h_ | so I ran out to steal it for his swap days for GUI MV testing and screenshot/video'ing | 02:41 |
| huwshimi | rick_h_: Nice one! | 02:41 |
| rick_h_ | yea, so busy two days coming up. Have to take it back Tues night | 02:41 |
| huwshimi | rick_h_: I thought he lived on the other side of the country? | 02:44 |
| huwshimi | well, other end | 02:44 |
| rick_h_ | huwshimi: no, he's 1.4hrs away from me | 02:44 |
| huwshimi | rick_h_: Oh right, nice | 02:44 |
| === uru_ is now known as urulama | ||
| fabrice | Hi everyone | 06:28 |
| fabrice | First Day :) | 06:29 |
| huwshimi | fabrice: Hello! Welcome | 06:31 |
| fabrice | Thanks | 06:31 |
| huwshimi | fabrice: You're on urulama's team? | 06:34 |
| fabrice | I suppose | 06:34 |
| fabrice | and you ? | 06:35 |
| huwshimi | fabrice: haha, OK, urulama is around so he can probably tell you more | 06:35 |
| huwshimi | fabrice: I'm on rick_h_'s team, but the two work very closely. | 06:35 |
| urulama | hi there fabrice | 06:36 |
| fabrice | yo | 06:37 |
| urulama | did you manage to get SSO working? | 06:37 |
| urulama | and have access to mail, wiki, docs? | 06:38 |
| fabrice | no just logging to irc 2 minutes ago I am waiting for vanguard but I said I would start at 9am | 06:39 |
| urulama | ok, np | 06:39 |
| urulama | fabrice: when you're up and running, let me know | 06:39 |
| urulama | fabrice: i'll be jumping in and out today, we have some issues with floods here :) | 06:39 |
| huwshimi | urulama: That doesn't sound good! | 06:40 |
| urulama | huwshimi: no big deal, rain stopped yesterday, but there are some leaks in the basement and at my fathers house as well. | 06:41 |
| urulama | huwshimi: it's just underground water being to high, luckily we're not near river | 06:41 |
| fabrice | still it doesn sound good | 06:42 |
| fabrice | BTW http://altcoinpress.com/2014/09/irc-freenode-network-hacked/ | 07:21 |
| fabrice | you should probably change your password | 07:22 |
| frankban | morning urulama, rogpeppe1 | 08:01 |
| frankban | welcome fabrice! | 08:01 |
| urulama | morning frankban | 08:01 |
| urulama | jujugui: fabrice joined today | 08:01 |
| rogpeppe1 | frankban: yo! | 08:01 |
| rogpeppe1 | frankban: welcome! | 08:02 |
| frankban | fabrice: ^^^ ;-) | 08:02 |
| urulama | fabrice: if you want to address all people at once, we use jujugui alias here | 08:02 |
| frankban | also guihelp | 08:02 |
| fabrice | frankban: thanks ! | 08:03 |
| urulama | fabrice: mhilton joined 14 days ago, so the process is probably still fresh in his head, you can ask him as well | 08:04 |
| mhilton | welcome fabrice | 08:05 |
| rick_h_ | morning everyone | 11:02 |
| rick_h_ | fabrice: welcome to the party | 11:02 |
| rick_h_ | ! | 11:02 |
| fabrice | rick_h_: yo! | 11:02 |
| fabrice | rick_h_: morning | 11:03 |
| rick_h_ | hope the boostrapping is going well fabrice | 11:05 |
| rick_h_ | let us know if you need a hand. | 11:05 |
| rick_h_ | calender invites coming your way shortly if you're not already on them | 11:05 |
| fabrice | rick_h_: sso sorted, looking at the wikis, and fighting with HP Cloud for mission #1 :) | 11:06 |
| rick_h_ | fabrice: understood, all good. There's a lot to boot up on. | 11:07 |
| * frankban lunches | 11:50 | |
| === fabrice is now known as fabrice|lunch | ||
| kadams54 | guihelp: need eyes on https://github.com/juju/juju-gui/pull/548 - it's a pretty small change and should be a quick review/QA. | 13:07 |
| urulama | fabrice: ping ... hangouts? | 13:08 |
| rick_h_ | kadams54: rgr looking | 13:08 |
| fabrice | urulama: I am on it | 13:08 |
| rick_h_ | kadams54: if you get a sec can you peek at frankban's as well for a second review and qa? | 13:08 |
| kadams54 | Sure. I'm also looking over huw's stuff. | 13:08 |
| rick_h_ | kadams54: can you provide some background in that pull request? | 13:08 |
| rick_h_ | kadams54: I'm not sure what I'm looking at and what it's about | 13:09 |
| kadams54 | Sure. | 13:09 |
| rick_h_ | kadams54: assume it's around the bug 1368650? | 13:09 |
| mup | Bug #1368650: adjust date and time is static <Photos:New> <https://launchpad.net/bugs/1368650> | 13:09 |
| kadams54 | rick_h_: Correct. | 13:09 |
| kadams54 | I'm editing the PR to add more context. | 13:10 |
| rick_h_ | kadams54: cool thanks. Yea some tie in from PR to bug/context is + | 13:10 |
| kadams54 | OK, initial comment/description has been fleshed out, so context will be preserved in merge commit. | 13:11 |
| rick_h_ | kadams54: ty much | 13:12 |
| rick_h_ | jcsackett: around? | 13:26 |
| rick_h_ | jcsackett: I need to change to develop on precise, you mention it works with @sha? | 13:26 |
| frankban | kadams54: thanks for taking a look at my branch | 13:34 |
| kadams54 | frankban: yup, np | 13:34 |
| jcsackett | rick_h_: yes | 13:44 |
| jcsackett | if you do the @sha of a commit, that works on precise. | 13:44 |
| rick_h_ | jcsackett: so does it need just the sha or the url@sha? | 13:44 |
| jcsackett | so just pick the most recent one for develop. | 13:44 |
| rick_h_ | ok ty | 13:44 |
| jcsackett | rick_h_: "https://github.com/name/juju-gui.git @sha" | 13:44 |
| rick_h_ | ah the space dammit | 13:45 |
| luca | rick_h_: did I send an email out last week about the added services sidebar? | 13:52 |
| rick_h_ | luca: yes | 13:52 |
| rick_h_ | luca: and I've got it put away atm | 13:52 |
| rick_h_ | luca: but will break it down later this week | 13:52 |
| rick_h_ | luca: we had a quick chat on it I think | 13:53 |
| luca | rick_h_: ok, I was just looking for it and couldn’t find it in my email so was just wondering hehe | 13:53 |
| luca | rick_h_: no worries | 13:53 |
| luca | rick_h_: could you tell me what I called the email? lol | 13:53 |
| * rick_h_ goes to look | 13:53 | |
| rick_h_ | luca: hmm, not sure. The one I find now is back Aug 13th | 13:54 |
| luca | rick_h_: I think I possibly just spoke to you about it but didn’t actually email | 13:54 |
| luca | rick_h_: so I’ll email it out now then :) | 13:55 |
| rick_h_ | luca: ok, I remember seeing two images | 13:55 |
| rick_h_ | figured they came in email | 13:55 |
| luca | rick_h_: yeah, I showed them to you in IRC | 13:55 |
| rick_h_ | oh, then ok | 13:56 |
| kadams54 | guihelp: anyone know where juju logs are stored on OS X? | 13:59 |
| rick_h_ | kadams54: juju log? | 14:00 |
| rick_h_ | kadams54: what are you doing/getting a log for? | 14:00 |
| frankban | kadams54: what logs? local env? | 14:00 |
| rick_h_ | kadams54: if it's a bootstrap issue add --debug to the bootstrap command | 14:00 |
| rick_h_ | kadams54: if you're deploying something there's debug-log and unit logs on the unit coming up | 14:00 |
| kadams54 | rick_h_, frankban: I've found tailing the logs to be helpful when setting the gui source | 14:01 |
| kadams54 | Yeah, the unit logs | 14:01 |
| frankban | kadams54: so juju debug-log -e ec2 should do the trick | 14:01 |
| kadams54 | debug-log reports 'Output from "make distfile" sent to /var/log/juju/make-distfile…' | 14:02 |
| rick_h_ | kadams54: right so that means it's running the tarball generation/etc | 14:03 |
| kadams54 | I'm assuming I'd need to juju ssh -e mytest to see the contents of that log? | 14:03 |
| rick_h_ | kadams54: right | 14:03 |
| === fabrice is now known as fabrice|coffee | ||
| rick_h_ | juju ssh juju-gui/0 | 14:03 |
| rick_h_ | it's basically a 'be patient' log line | 14:04 |
| rick_h_ | it takes a bit | 14:04 |
| * rick_h_ is waiting at that same line heh | 14:04 | |
| rick_h_ | hatch: around? | 14:08 |
| rick_h_ | hatch: makyo_ I need a volunteer for a hot orange box bug please | 14:08 |
| rick_h_ | hatch: makyo_ https://bugs.launchpad.net/juju-gui/+bug/1369576 | 14:10 |
| mup | Bug #1369576: juju-gui MV shows subordinate services as unplaced units <juju-gui:Triaged> <https://launchpad.net/bugs/1369576> | 14:10 |
| kadams54 | frankban: All done with QA. You're good to go. | 14:10 |
| frankban | kadams54: thanks! | 14:10 |
| hatch | rick_h_: I am | 14:11 |
| hatch | odd though I am not getting dings... | 14:11 |
| rick_h_ | hatch: please see bug ^ asap please | 14:11 |
| rick_h_ | hatch: I assume it's a small part of how we identify unplaced units as missing on attribute | 14:11 |
| rick_h_ | hatch: ping me when you have a fix up please and will qa/land so we can unblock for demo shots/etc | 14:12 |
| hatch | sure - do we have a running instance I can see? | 14:12 |
| rick_h_ | hatch: will post a screenshot in a sec, I'm installing a screenshot tool | 14:12 |
| hatch | oh ok so I'm going to have to fix it blind? haha | 14:13 |
| rick_h_ | hatch: I list out 4 sub services. Add wordpress and ntp subordinate and see how it shows? | 14:14 |
| hatch | yup on it | 14:14 |
| rick_h_ | hatch: I mean if it all works in sandbox then ok, but it's not quite blind | 14:14 |
| rick_h_ | hatch: https://www.dropbox.com/s/oitc0icdf6oruu9/Selection_001.png?dl=0 | 14:15 |
| hatch | sandbox does not show the sub in the unplaced units column....spinning up local | 14:16 |
| rick_h_ | hatch: rgr | 14:16 |
| hatch | rick_h_: did you get the orangebox at your place? | 14:22 |
| === fabrice|coffee is now known as fabrice | ||
| hatch | welcome fabrice | 14:23 |
| fabrice | hatch: thanks ! | 14:23 |
| rick_h_ | hatch: yes, sitting at it right now | 14:23 |
| rick_h_ | been working on getting it setup all morning and let the bugs and fun begin | 14:23 |
| rick_h_ | hatch: http://paste.ubuntu.com/8350773/ is the dump of the services object | 14:24 |
| hatch | rick_h_: awesome...you take any selfies? rick and oranebox in the car....rick and orange box eating breakfast..... :P | 14:24 |
| rick_h_ | no, was going to when I get MV up and running do a little pic saying "Tired of looking at juju status...we've got something good coming just for you" | 14:24 |
| rick_h_ | but then it looks fugly because of these subordinates and I'm in go go go debug mode | 14:24 |
| hatch | it should be named.....Obey | 14:25 |
| * rick_h_ goes on to keep testing stuff | 14:25 | |
| hatch | :) | 14:26 |
| hatch | ok I think I found where to fix this...just need the real env to test | 14:26 |
| hatch | rick_h_: new bug https://bugs.launchpad.net/juju-gui/+bug/1369588 | 14:31 |
| rick_h_ | hatch: rgr, makyo_ can you look? It seems related to your remove relation UX/etc you were doing | 14:32 |
| hatch | rick_h_: also I cannot reproduce on local....how did you get those ntp units to be unplaced? | 14:32 |
| rick_h_ | hatch: deployed via the deployer (a bundle) and then I simply loaded the page | 14:33 |
| hatch | hmm ok lemme see if I have to deploy them | 14:33 |
| hatch | oh geeze deploying the ghost relation didnd't work | 14:35 |
| hatch | and then making the relationi post deploy locked up the gui... | 14:35 |
| rick_h_ | jcsackett: going to file this new bug your way. sorry but want to shake these orangebox bugs out while I've got it today/tmorrow | 14:35 |
| rick_h_ | jcsackett: guessing there's a missed event stopper in the drop there | 14:35 |
| jcsackett | rick_h_: this subordinate thing? | 14:36 |
| rick_h_ | jcsackett: no, different one | 14:36 |
| hatch | jujugui where is the gui source located on the instance again? /me can't remember | 14:37 |
| jcsackett | rick_h_: link? | 14:38 |
| frankban | hatch: /var/lib/juju-gui/juju-gui IIRC | 14:38 |
| hatch | thx | 14:38 |
| rick_h_ | jcsackett: https://bugs.launchpad.net/juju-gui/+bug/1369593 | 14:39 |
| jcsackett | rick_h_: i see. i'll check if i can reproduce on a non orangebox live env; otherwise this could be a fun one. | 14:40 |
| rick_h_ | jcsackett: yes, please check locally, or check ec2 | 14:40 |
| rick_h_ | jcsackett: I think ec2 should be similar | 14:40 |
| * jcsackett nods | 14:40 | |
| rick_h_ | kadams54: one for your next card please https://bugs.launchpad.net/juju-gui/+bug/1369601 | 14:44 |
| kadams54 | rick_h_: rgr | 14:44 |
| hatch | blarg I can't even create a relation between a service and a subordinate.... rick_h_ this is going to take a bit longer than expected | 14:44 |
| rick_h_ | hatch: understood | 14:44 |
| hatch | juju-info relation added between wordpress and wordpress | 14:45 |
| hatch | *facepalm* | 14:45 |
| rick_h_ | hatch: can you not create it in the cli or the gui or both? | 14:45 |
| hatch | yeah via the cli works | 14:47 |
| hatch | but I still don't get unplaced units | 14:48 |
| hatch | maybe it has to be done via a bundle... | 14:48 |
| hatch | rick_h_: stupid q but there are no errors in the console right? | 14:49 |
| rick_h_ | console is disabled | 14:50 |
| hatch | jujugui call in 10 | 14:50 |
| rick_h_ | hatch: nothing I can tell atm | 14:50 |
| hatch | rick_h_: ok np....there are a few things I can try still then I'll have to put together a bundle and try that | 14:50 |
| hatch | ahah I got it | 14:50 |
| rick_h_ | hatch: :/ ok but really you can't relate a subordinate via cli? | 14:51 |
| hatch | w00t | 14:51 |
| hatch | well I can reproduce it | 14:51 |
| rick_h_ | hatch: yay | 14:51 |
| rick_h_ | ish | 14:51 |
| hatch | no I can create the sub relation via the cli...cannot via the gui | 14:51 |
| hatch | will create a new bug | 14:51 |
| hatch | for that | 14:51 |
| hatch | apparently we didn't test subordinates | 14:51 |
| hatch | haha | 14:51 |
| rick_h_ | yea, we never do :/ | 14:51 |
| rick_h_ | but it's blocking me getting a single screenshot of the real stuff here so guess it's time to look | 14:52 |
| hatch | https://bugs.launchpad.net/juju-gui/+bug/1369606 | 14:54 |
| rick_h_ | jujugui call in 1 go time | 14:58 |
| rick_h_ | kadams54: ^ | 14:59 |
| rick_h_ | frankban: ^ | 15:00 |
| rick_h_ | fabrice: the hangout url is in teh calendar item | 15:00 |
| fabrice | yep coming | 15:00 |
| * makyo_ steps out for a few | 15:20 | |
| === makyo_ is now known as Makyo | ||
| urulama | rick_h_: what about cloudfoundry demo? i remember ben talking about CF bundle | 15:20 |
| hatch_ | rick_h_: just to confirm - we never want to show ubordinates in the mv? | 15:21 |
| hatch_ | urulama: ME FIRST!! | 15:21 |
| * urulama hides :D | 15:21 | |
| hatch_ | haha | 15:21 |
| kadams54 | rick_h_: I'm not able to reproduce https://bugs.launchpad.net/juju-gui/+bug/1369601 - tried both locally and on ec2 | 15:21 |
| * hatch_ got no sleep last night....someone kept texting me last night to "go smoke a dub" | 15:21 | |
| hatch_ | blocked number....wouldn't stop texting | 15:22 |
| kadams54 | hatch_: no do not disturb feature on your phone? | 15:22 |
| hatch_ | kadams54: I needed the alarm to still go off in the morning | 15:22 |
| kadams54 | iPhone's doesn't prevent alarm from going off, just prevents others from contacting via phone or text. | 15:23 |
| hatch_ | but I haven't set up the 'important' people for dnd either...I shoud probably do that | 15:23 |
| hatch_ | kadams54: tbh I have no idea...I've never used it...I just assumed | 15:23 |
| kadams54 | hatch_: my dnd turns off at 7 AM. Alarm goes off at 6:51 AM :-) | 15:24 |
| hatch_ | haha nice... so can you set 'important' people for the dnd? | 15:24 |
| rick_h_ | urulama: oh hmm, will see if that's on here | 15:26 |
| rick_h_ | hatch_: rgr | 15:26 |
| rick_h_ | hatch_: they're kind of nutty as they're on every instance and so we agreed (for now) that subordinates aren't on mv | 15:26 |
| rick_h_ | kadams54: k, looking at what i did again | 15:26 |
| hatch_ | ok sounds good | 15:26 |
| rick_h_ | kadams54: hmm, yea does it every time. duplicated it in the sandbox on comingsono | 15:28 |
| rick_h_ | kadams54: jump back in standup? | 15:28 |
| kadams54 | rick_h_: sure | 15:28 |
| rick_h_ | jujgui are you supposed to be able to destroy a machine with services on it? | 15:33 |
| kadams54 | rick_h_: I think you can destroy an uncommitted one and then the services go back to being unplaced units. Seems like JC worked on that card awhile back. Not sure about uncommitted. | 15:35 |
| rick_h_ | yea, this is a committed/running machine. Working backwards, first unit, then container see if I can get to machihne | 15:36 |
| kadams54 | Wow, we have both token-container.[js|handlebars] and container-token.[js|handlebars] | 15:36 |
| rick_h_ | lol but of course | 15:37 |
| hatch_ | rick_h_: if you have deployed services then you have to remove the services first before destroying the machine | 15:39 |
| hatch_ | we don't have a --force enabled in the GUI | 15:39 |
| rick_h_ | ok yea, you have to remove the units, and then the containers, and then the machine | 15:39 |
| hatch_ | rick_h_: do we want to show subordinates in the machine/container columns? atm subordinates don't have their machines set | 15:40 |
| rick_h_ | hatch_: no, I don't think we show them in either location | 15:40 |
| fabrice | going to care of family now, hopefully come back this evening tty soon | 15:41 |
| rick_h_ | hatch_: for MV, subordinates don't show atm and we can address it post-release if it turns into an issue | 15:41 |
| hatch_ | rick_h_: ok np I'm just trying to pick the best place to fix this | 15:41 |
| rick_h_ | hatch_: understood | 15:42 |
| * rick_h_ goes to the dr apt biab | 15:46 | |
| hatch_ | ok so the real issue (5 whys) is that the unit doenst get it's subordinate status set | 15:47 |
| * hatch_ is just talking outloud | 15:48 | |
| kadams54 | jujugui is it ever possible to have a machine that's got a different committed/uncommitted state than its root container? | 16:01 |
| jcsackett | kadams54: i don't think so. | 16:01 |
| jcsackett | the root container *is* the machine. | 16:01 |
| kadams54 | jcsackett: sure doesn't seem like it ought to be | 16:01 |
| kadams54 | OK, I'm going to go ahead and assume that's true and leave a comment in the code: "jcsackett said this was OK" | 16:01 |
| * jcsackett laughs | 16:02 | |
| hatch_ | kadams54: the root container doesn't exist...just like jcsackett said :) | 16:05 |
| kadams54 | guihelp: https://github.com/juju/juju-gui/pull/552 is ready for QA and review <-- I think this is an orange box one? | 16:11 |
| hatch_ | frankban: so when the units delta comes in ntp's service shows it as NOT being a subordinate...but then the GUI shows it as a subordinate...do you know if services subordinate statuses are updated after the initial services delta? | 16:25 |
| frankban | hatch_: service info is updated each time something changes, I can take a look at juju-core to check whether the subordinate flag is sent later, but I'd guess you already know the answer | 16:27 |
| hatch_ | yeah...so this is kind of a problem heh | 16:28 |
| hatch_ | but I guess I can add something in the handler to go through it's units to mark them as subordinates | 16:28 |
| hatch_ | odd that it's not send originally | 16:28 |
| hatch_ | because a service can't ever change from a subordinate | 16:28 |
| hatch_ | ahh when the service is created it doesn't send us the information | 16:31 |
| hatch_ | and we don't have the charm information yet either | 16:31 |
| Makyo | jujugui quick review/qa on asterisks in inspector: https://github.com/juju/juju-gui/pull/547 | 16:38 |
| kadams54 | heading out for a run, bbiab | 16:39 |
| hatch_ | frankban: would you be able to take a look to see if we could get the services subordinate status when we get the data? It looks like the only way we know about it is because we compare against the charm | 16:47 |
| hatch_ | I'm guessing there is a reason why this information was missing though... | 16:48 |
| frankban | hatch_: taking a look at the code | 16:48 |
| hatch_ | thanks - I'm assuming this because there isn't a single ws frame with the subordinate status in it | 16:50 |
| frankban | hatch_: I confirm the is_subordinate info is not included in serviceInfo. also unitInfo does not have that information. I guess that's because the is_subordinate is actually an attribute on the charm, rather than the service | 16:52 |
| hatch_ | yeah....see I can easily fix this bug by doing cross db queries....but that just feels wrong when we should really have this information available on the unit | 16:52 |
| hatch_ | ok np thanks for looking, I'll keep on trying to find the best place to add this info | 16:53 |
| frankban | hatch_: np, FWIW the service has a charmUrl, and it should not be hard in theory to add the information you need in _setDefaultsAndCalculatedValues | 16:57 |
| hatch_ | frankban: at that point we don't have the charm info yet | 16:58 |
| hatch_ | heh | 16:58 |
| hatch_ | it's an unfortunate sequence of events it seems | 16:59 |
| frankban | hatch_: oh, so we need to know if a unit is from a subordinate charm, in the machine view, but we call charmInfo only when the charm is displayed in the inspector, something like that? | 17:04 |
| hatch_ | frankban: well I haven't ironed out the exact sequence of events but when mv is rendered the units do not have subordinate information but the services do | 17:10 |
| hatch_ | so I'm trying to find where the services get updated with that information | 17:10 |
| hatch_ | but not having much luck | 17:10 |
| hatch_ | frankban: if you know where that happens I'm totally open for input haha | 17:13 |
| frankban | hatch_: I suppose models/charms.js? | 17:15 |
| hatch_ | right i just can't find where it updates the service | 17:15 |
| hatch_ | np I'll find it | 17:15 |
| hatch_ | :) | 17:15 |
| hatch_ | it's in these 100k lines somewhere :) | 17:16 |
| frankban | :-) | 17:19 |
| frankban | hatch_: I am looking as well, and it's really not clear when and above all IF the "subordinate" service attr is set | 17:20 |
| === hazmat` is now known as hazmat | ||
| hatch_ | frankban: exactly - it appears to be done as a side effect somewhere heh | 17:34 |
| frankban | hatch_: surely it is set when a ghost service is created | 17:36 |
| hatch_ | frankban: but the ghost service isn't created when it comes over the delta | 17:36 |
| frankban | hatch_: it seems something happens when handling endpoints in store/endpoints.js | 17:40 |
| frankban | hatch_: done for the day, good luck and have a nice evening! | 17:40 |
| hatch_ | thanks you too, cya tommorow | 17:41 |
| kadams54 | Why is it that I never see any API requests on my sandbox in web inspector? I would expect to see some WebSockets requests to go through… (Note that this is in Chrome Canary.) | 17:44 |
| kadams54 | Does the fakeenv prevent that? | 17:44 |
| hatch_ | kadams54: I'm not sure I understand | 17:51 |
| hatch_ | sandbox simulates juju | 17:51 |
| hatch_ | so it doesn't need to make any reqyests | 17:51 |
| kadams54 | OK, sorry, for some reason I had it in my head that fakebackend.js was running in Node on the server, but it looks like it runs in the client instead. | 17:52 |
| hatch_ | ohh....yeah we only use node for devtools | 17:52 |
| hatch_ | the guiserver backend is python | 17:53 |
| kadams54 | You're talking about in a real env, right? | 17:53 |
| hatch_ | yeah | 17:54 |
| hatch_ | on jujucharms for example it's 100% client side | 17:54 |
| hatch_ | and for being single threaded still scales to thousands of units :) | 17:55 |
| rick_h_ | jujugui back andd all | 18:26 |
| rick_h_ | kadams54: comment on your pr but looks good thanks for the update | 18:26 |
| hatch_ | rick_h_: I'm still working on the fix for the bug - getting closer | 18:26 |
| rick_h_ | hatch_: awesome | 18:26 |
| hatch_ | it can be fixed trivially - but a real fix goes all the way back to delta parsing | 18:27 |
| hatch_ | so the real fix takes more time :) | 18:27 |
| rick_h_ | hatch_: hmm, do we need to have a chat on it then? | 18:27 |
| rick_h_ | hatch_: I need a 'visible' fix today if we can get a hack up | 18:27 |
| hatch_ | sure standup? | 18:28 |
| hatch_ | rick_h_: the mass scale up UI in mv shows that you can add extra units for subordinates....do we have a bug for this already? I thought we did but I can't find it | 18:51 |
| rick_h_ | hatch_: good call, will add one | 18:51 |
| rick_h_ | going to file a drive by in there as well. I think it should be alphabetical. I don't recall why we didn't | 18:52 |
| rick_h_ | kadams54: go ahead and ship your branch and I'll do qa when I update the gui here in a few | 19:00 |
| kadams54 | rick_h_: trying to figure out the CI test failure | 19:01 |
| rick_h_ | kadams54: ah cool | 19:01 |
| hatch_ | somehow I managed to bork the xy annotations in my env making it so that the GUI will no longer render stuff | 19:02 |
| rick_h_ | wheeee | 19:03 |
| hatch_ | {"Type":"Client","Request":"SetAnnotations","Params":{"Tag":"service-wordpress","Pairs":{"gui-x":"NaN","gui-y":"NaN"}},"RequestId":15} | 19:03 |
| hatch_ | not sure how to recover from this besides destroy the whole env? | 19:04 |
| rick_h_ | set it? | 19:04 |
| rick_h_ | oh, or you mean if that's there it won't place at all? | 19:04 |
| hatch_ | I can set annotations? | 19:04 |
| hatch_ | yeah the gui just throws errors so nothing gets rendered to the canvas | 19:04 |
| hatch_ | guess this is another bug...it should fail gracefully heh | 19:05 |
| rick_h_ | yea | 19:05 |
| rick_h_ | need some steps to reproduce before we can file it though | 19:06 |
| hatch_ | ssh into box, open js file, create syntax error in juuuuust the right spot | 19:07 |
| hatch_ | :) | 19:07 |
| rick_h_ | lol | 19:07 |
| hatch_ | crap oh well tearing down... | 19:07 |
| rick_h_ | ok then we can leave that as a low thing to fix one day | 19:07 |
| hatch_ | rick_h_: I need to grab some lunch - here is the patch if you'd like to give it a go https://gist.github.com/hatched/daab82c9b132f38ed406 | 19:10 |
| rick_h_ | hatch_: can you push it into a branch I can set in the gui? | 19:11 |
| hatch_ | should work for switching from service to mv and loading right into mv | 19:11 |
| hatch_ | oh sure | 19:11 |
| rick_h_ | hatch_: rgr | 19:11 |
| hatch_ | rick_h_: https://github.com/juju/juju-gui/pull/554 | 19:12 |
| hatch_ | rick_h_: https://github.com/hatched/juju-gui.git sub-unplaced-1369576 | 19:12 |
| hatch_ | it busted when I was doing the qa so I am not 100% sure but should work for the photos :) | 19:13 |
| hatch_ | will finish it up as soon as I get back....just starving | 19:13 |
| hatch_ | haha | 19:13 |
| kadams54 | rick_h_: got the test failure straightened out and shipping. | 19:17 |
| kadams54 | rick_h_: FYI, I also have a time off request heading your way soon. | 19:17 |
| rick_h_ | kadams54: awesome ty | 19:20 |
| hatch_ | hey rick_h_ did that fix get you going? | 19:45 |
| rick_h_ | otp atm | 19:50 |
| jcsackett | rick_h_: have you tried orangebox with the trusty charm, or just precise? | 20:11 |
| rick_h_ | jcsackett: it's only precise because that's what it runs atm | 20:11 |
| jcsackett | rick_h_: dig; i reproduced on precise, was working on the bug with root containers. switch to a deployment with the trusty charm b/c it's easier to work with branches, and discovered (at least on ec2) you can't drop at all. | 20:12 |
| jcsackett | (at least in google-chrome) | 20:13 |
| rick_h_ | jcsackett: hmm, that's odd that they're diff | 20:13 |
| jcsackett | rick_h_: i concur. i haven't dug into that occurence yet, but made a note to look further into it when i'm done with this bug. | 20:13 |
| jcsackett | for now i'll work with sha1s on precise. | 20:13 |
| hatch_ | jcsackett: what bug r u working on? | 20:17 |
| jcsackett | hatch_: https://bugs.launchpad.net/juju-gui/+bug/1369593 | 20:17 |
| mup | Bug #1369593: dropping an unplaced unit on the root container of a new machine in MV reloads the page <juju-gui:In Progress by jcsackett> <https://launchpad.net/bugs/1369593> | 20:17 |
| hatch_ | interesting - I've never had that happen | 20:18 |
| hatch_ | nor not being able to drop | 20:18 |
| jcsackett | hatch_: real env only. | 20:20 |
| jcsackett | hatch_: if you have a real env running the trusty gui charm, i would love to see if it's reproducible. | 20:21 |
| jcsackett | (ec2, to be the same setup) | 20:21 |
| hatch_ | sorry I don't atm but will soon | 20:21 |
| hatch_ | local though | 20:21 |
| hatch_ | jcsackett: in local I can't even drop on the root container if i'ts uncommitted | 20:43 |
| hatch_ | heh | 20:43 |
| hatch_ | no error | 20:43 |
| jcsackett | hatch_: on trusty? | 20:43 |
| hatch_ | yup; | 20:43 |
| jcsackett | yeah, that's what i saw too. | 20:43 |
| jcsackett | they're not droppable at all in develop now. no idea why. | 20:43 |
| jcsackett | hatch_: is a container? | 20:43 |
| hatch_ | I recall seeing a bug around this - it's because we disabled dropping to create containers when not on maas | 20:43 |
| jcsackett | or is drag-and-drop broken across everything. | 20:43 |
| jcsackett | aaaah. | 20:43 |
| hatch_ | so I'm guessing it's because of that | 20:43 |
| jcsackett | can you drop on the machine token? | 20:44 |
| hatch_ | trying | 20:44 |
| hatch_ | nope but I can drop on the machine header | 20:44 |
| jcsackett | hrm. so it's not precise/trusty. it's a commit that's landed in the last day. | 20:45 |
| jcsackett | because i've now updated and on precise i'm seeing the same behavior. | 20:45 |
| hatch_ | well I'm going to get back to working on my fix | 20:45 |
| jcsackett | rick_h_: ^ i'm going to pursue this b/c it now blocks the bug you filed. | 20:45 |
| hatch_ | lemme know if you need another test dummy | 20:45 |
| rick_h_ | jcsackett: rgr | 20:45 |
| jcsackett | hatch_: will do. | 20:45 |
| hatch_ | man I wish it was faster to pull down and switch branches heh | 20:46 |
| jcsackett | hatch_: +1 | 20:48 |
| hatch_ | there must be a way to fetch a diff from what's in the charm and what you want to fetch then run the build | 20:49 |
| hatch_ | in theory that would only take a couple mins at most | 20:49 |
| hatch_ | (assuming it's possible) | 20:49 |
| jcsackett | so, i'm seeing a note that "we don't allow hulk smash" now in the machine view's set droppable code. is that accurate? | 20:55 |
| jcsackett | rick_h_, hatch_ ^ | 20:55 |
| jcsackett | doesn't sound right. | 20:55 |
| hatch_ | jcsackett: originally yes | 20:55 |
| hatch_ | but I think we did a 180 on that | 20:55 |
| rick_h_ | yea, 180, we do allow it | 20:56 |
| jcsackett | hm. the comment git blames from earlier this month, but i suppose it may have just been moved around. | 20:56 |
| hatch_ | jcsackett: yeah I wish (maybe there is) a way to get a history of blames heh | 20:57 |
| jcsackett | ok, so yeah, this is just a case that if containers aren't allowed, none of the machine tokens are made drop-able; the root container token should still be a drop target though. | 20:57 |
| hatch_ | jcsackett: agreed | 20:58 |
| jcsackett | hatch_: we can always set container tokens to be droppable, can't we? in a situation where containers aren't supported, the *only* container tokens are going to be root containers, right? | 21:02 |
| hatch_ | hmm | 21:03 |
| hatch_ | jcsackett: the only issue I can think of is if someone were to somehow create a container | 21:04 |
| hatch_ | but as long as we make sure they can't do that via the cli or the gui then we should be ok | 21:04 |
| jcsackett | hatch_: i mean, if they somehow create a container via the gui when they can't, that's a bug. | 21:05 |
| jcsackett | hatch_: we can't ensure they don't via the cli though. | 21:05 |
| hatch_ | right, but if they create one by the cli (somehow) then we will render it and they will be able to drop on it | 21:05 |
| jcsackett | hatch_: yeah. | 21:05 |
| jcsackett | and we can't ensure that can't happen, so i'll just make sure only the roots get enabled. | 21:05 |
| hatch_ | so imho it's better to be explicit....juuuuust in case | 21:06 |
| hatch_ | heh | 21:06 |
| jcsackett | makes for an uglier conditional, but oh well. | 21:06 |
| hatch_ | rick_h_: ok I have finished qa'ing my 'hack' and found that it doesn't work when loading mv directly because it's rendered before we have the charm data for the service | 21:12 |
| hatch_ | so we will have to delay loading unplaced tokens until we get all of the services charm data back...which is kind of waky heh | 21:12 |
| rick_h_ | hatch_: :/ | 21:14 |
| rick_h_ | ok, off the phone, wtf happened while away? | 21:15 |
| hatch_ | it...alll...went...for...shit | 21:15 |
| hatch_ | :P | 21:15 |
| hatch_ | want to hop back on a call and chat about this? | 21:15 |
| rick_h_ | jcsackett: so you're good on your bug, you can always drop on the root container and that's borked atm? | 21:15 |
| rick_h_ | hatch_: k, fine but not sure my ears can take it :P | 21:15 |
| hatch_ | haha | 21:15 |
| rick_h_ | jcsackett: ^ | 21:15 |
| === urulama is now known as urulama-afk | ||
| Makyo | jujugui quick review and QA in real env https://github.com/juju/juju-gui/pull/555 - can be LXC, but has to be real | 21:57 |
| hatch_ | jujugui I need a single review (no qa) https://github.com/juju/juju-gui/pull/554 | 22:28 |
| hatch_ | Makyo: I can do your review now if you still need | 22:28 |
| hatch_ | woah look all the pr's | 22:32 |
| jcsackett | rick_h_: dropping on root container didn't work, i have a commit that fixes that, and now i cannot reproduce the initial bug. | 22:41 |
| jcsackett | rick_h_: can you try 44d19f6ecdf1efc1ce27a5f807abb563e7d93ac7 from my github repo on the orangebox, and see if you can reproduce it? | 22:42 |
| jcsackett | (assuming you're around...) | 22:42 |
| hatch_ | he went to pick kid up a bit ago | 22:42 |
| jcsackett | ah. i was heading back to the house then. | 22:43 |
| hatch_ | jcsackett: if you want a break can you review mine? no qa necessary | 22:43 |
| jcsackett | hatch_: looks good. | 22:47 |
| hatch_ | word | 22:47 |
| jcsackett | hatch_: any chance you can look at my PR? i forgot to ping in the channel earlier today. | 22:48 |
| jcsackett | test failure on it is spurious. | 22:48 |
| * hatch_ hulk smashes CI "SPURIOUS THIS!!!!!" | 22:53 | |
| * jcsackett laughs | 22:53 | |
| huwshimi | Morning | 23:02 |
| hatch_ | ahoy | 23:03 |
| hatch_ | huwshimi: I'll slowly be getting to your qa's - there were osme bugs with the orange box which were critical to get landed today | 23:04 |
| huwshimi | hatch_: No problems | 23:04 |
| huwshimi | Thankyou | 23:04 |
| jcsackett | going afk all. ciao. | 23:10 |
| hatch_ | cya jcsackett | 23:14 |
| hatch_ | rick_h_: I have shipped the critical fix after a review so you should have it in develop for qa soonish | 23:14 |
| === mup_ is now known as mup | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
