=== kgunn is now known as Guest14808 === _salem is now known as salem_ === kgunn is now known as Guest35270 === salem_ is now known as _salem [07:45] Cimi: can you top approve https://code.launchpad.net/~aacid/unity8/bug1365929/+merge/234795 ? seems autopilot tests are all broken again in CI for no reason [07:46] tsdgeos, done [07:48] Cimi: you're going to the office today? [07:48] tsdgeos, yup [07:48] Cimi: can you please ask them to think on the transitions for https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1368670 ? [07:48] tsdgeos, having my coffee now (much better at home than there :P) [07:48] Launchpad bug 1368670 in unity8 (Ubuntu) "[Dash] Simplify 'Manage Dash' area" [Critical,Triaged] [07:48] tsdgeos, transitions? [07:49] tsdgeos, for the back button? [07:49] and for open [07:49] Dash overview has an amazing open transition [07:49] tsdgeos, open is like a reply command in messages [07:49] where the current dash item just fades into the dash item in the list [07:49] tsdgeos, I believe will be like in contacts [07:49] thiis can't happen here [07:49] tsdgeos, you pull the list from the bottom [07:49] so i want them to tell me what needs to happen in both open and close [07:50] tsdgeos, that bottom edge will probably go away after RTM anyway [07:50] tsdgeos, there are other plans... [07:50] good for after RTM [07:51] i thought we all cared for before RTM [07:51] tsdgeos, yes we do [07:51] because if something is unusable it has to be fixed [07:51] then let's make not things that are unusable [07:51] tsdgeos, but this is not the final bottom swipe [07:51] tsdgeos, this will eventually go as a menu button in the header [07:51] tsdgeos, and bottom edge will probably contain feed customisation [07:51] eventually is not now :) [07:52] i want to know what we do now [07:52] tsdgeos, two stages [07:52] tsdgeos, 1st, now, we have a list of feeds in the bottom edge [07:52] tsdgeos, 2nd, we move this list as a button on the header [07:52] tsdgeos, and the bottom edge will become something else, related to feed customisation [07:53] tsdgeos, for rtm we care of 1 [07:53] so we need to have proper transitions for 1 [07:53] don't we? [07:53] tsdgeos, I think will be like in contacts/messaging [07:54] tsdgeos, you pull the listview over the dash [07:54] way simpler than now [07:54] get them to confirm and write it on the bug or somewhere pelase [07:55] tsdgeos, ok [08:06] tsdgeos, which branches to review today? [08:07] tsdgeos, mzanetti we have a long list of branches, we need to land land land [08:07] on it i guess :d [08:07] Cimi: then go ahead and test silo 11 [08:07] and fix the issues in there :P [08:08] afk for a bit, shower [08:08] :D [08:11] hah! I think my N4 is recovering! It flashes red again after being plugged into the wall charger for >10 hours now [08:13] \o/ [08:18] Cimi: for the image gallery click thing, please double check if we can kill the ¿duplicated? FIXME in qml/Dash/Previews/PreviewImageGallery.qml i tried yesterday and it seems we don't need it [08:33] dednick: good morning [08:33] dednick: testing silo11, indicators don't seem to connect [08:39] marcustomlinson: https://code.launchpad.net/~marcustomlinson/unity8/handle_null_preview/+merge/234054/comments/574267 [08:49] dednick: ok... have to drop the indicator-polishing branch from the silo then [08:50] tsdgeos, having look soon, going to the office in a bit [08:50] ok [08:50] packing devices... [08:52] Cimi: please unapprove this: I don't have permissions: https://code.launchpad.net/~nick-dedekind/ubuntu-settings-components/indicator-polishing/+merge/229083 [08:53] mzanetti, why? [08:54] because it breaks the indicators [08:55] dednick: are you please taking care of https://code.launchpad.net/~larsu/unity8/stop-using-statusicon/+merge/234502 ? [09:04] mzanetti, but this morning we are supposed to merge the indicators together [09:11] mzanetti: erm. hm. that's weird [09:12] Cimi: ? [09:12] dednick: https://code.launchpad.net/~dandrader/unity8/post-prompts-in-prompts-tweaks/+merge/233377 ? [09:12] mzanetti, nick has a branch to go with that [09:12] mzanetti, currently need fixing [09:13] Cimi: mzanetti is testing the silo [09:13] mzanetti: i'm actually on holiday today. i'll be out for a bit, then can try take a look [09:13] Cimi: ah... that might be the issue [09:13] Cimi: seems the other branch is not in the same silo [09:13] mzanetti, ok [09:13] dednick: ^ [09:13] dednick: so maybe nothing you need to fix. [09:14] tsdgeos: it was approved but not top approved because it's failing CI [09:14] autopilot is broken [09:14] stupid autopilot and stupid CI randomly break all the time [09:14] tsdgeos: yeh. i've approved it already [09:14] top i mean [09:17] mzanetti: supposedly all the required branches are in the silo === vrruiz_ is now known as rvr [09:21] mzanetti: can confirm it's not connecting :/ [09:21] i mean, i confirm [09:22] damnit. was working a couple of days ago [09:23] dednick: same here with my lifecycle fixes branch... i could swear it was working when we reviewed it [09:23] had to go from the silo too [09:23] mzanetti: hm. looks like my unity8 polishing branch isn't part of the silo [09:23] yeah... that's what cimi told me before too [09:23] file:///usr/share/unity8//Panel/Indicators/DefaultIndicatorPage.qml:177:5: Type MenuItemFactory unavailable [09:23] file:///usr/share/unity8//Panel/Indicators/MenuItemFactory.qml:454:9: Type MessageMenuItemFactory unavailable [09:23] file:///usr/share/unity8//Panel/Indicators/MessageMenuItemFactory.qml:81:13: Menus.SimpleTextMessageMenu is not a type [09:24] Shouldn't be looking for SimpleTextMessageMenu [09:24] i gota run. be back in 30 [09:25] MacSlow: so no filtering at all for notification length? [09:25] seems you went from 2 lines to "any lines" [09:25] :D [09:33] tsdgeos, in https://code.launchpad.net/~unity-team/unity8/croppedImageMinimumSourceSize/+merge/233319 [09:33] when we do visible: false [09:33] what brings it back to true? [09:33] tsdgeos: when you have some time, may I ask you to give this one a look? https://code.launchpad.net/~mzanetti/unity8/launcher-dont-hide-on-dash/+merge/233038 [09:35] don't read my mind ;) [09:35] mzanetti: the test fails [09:35] may not be your fault though [09:35] let's see trunk [09:35] tsdgeos, I don't know really know what can come through with these class-2 sms [09:36] MacSlow: sure but it was 10 for snap notifications and 2 for rest, now is infinite for any? [09:36] tsdgeos, since nobody complained (or filed bugs) once the 10-line limit was in place, I initially thought "Just go back to this." [09:38] MacSlow: honestly i don't know enought about the subject to give a better opinion, is there anyone else we should talk to? [09:39] tsdgeos, I was hoping to get more input from Design or the dialer-app folks. [09:39] MacSlow: ping them to death :D [09:39] tsdgeos, I too know nothing about the sms-standard [09:41] tsdgeos, well there was a lengthy eMail-thread yesterday with no real output in that regard... so I assume they still try to figure it out. [09:41] Cimi: in artImage? [09:41] MacSlow: ok [09:43] mzanetti: test also fails in master, not your dowin [09:43] doing [09:48] tsdgeos, looks like even the folks working on the ofono-bit for sms don't know for sure the limits. So for the time being 2-line limit for non-snap-decision and unlimited for snap-decisions sounds like the best compromise. [09:49] MacSlow: who creates snap-decisisons? [09:49] can "random apps" do? [09:49] tsdgeos, no... confined/regular apps can't do that [09:49] so it's mainly "us" [09:49] tsdgeos, correct [09:49] looks the best compromise yes [09:49] if you do that i'll approve [09:50] tsdgeos, for example [09:50] Cimi: noone, artImage is always non visible since it's part of a shape [09:50] ok [09:51] tsdgeos, cool [09:51] tsdgeos, I don't have time to test the branch widely, did you? works well? [09:52] works for me yes [09:52] but honestly somebody should :D [09:52] test it moar [09:53] tsdgeos, wmall comment [09:53] small [09:54] ahhhhhhh [09:54] i think i know why the autopilot tests are broken [09:54] the damn notification about sd thing [09:54] did that get fixed? [10:00] tsdgeos, we want to have cards with mascot without the ubuntushape [10:06] Cimi: yes [10:06] Cimi: artImage is not the mascot [10:37] MacSlow: does https://code.launchpad.net/~macslow/unity8/synchronous-notification/+merge/229059 have a bug or something? what do i try? [10:39] tsdgeos, no it's a pure feature... you can either test it with the icon-value.py Python-script from the corresponding lp:~macslow/unity-notifications/synchronous-notification branch or install lp:~macslow/indicator-sound/synchronous-notification on your device and use the volume-buttons [10:40] MacSlow: i don't think we should accept new code without bugs associated to them at this point to be honest [10:40] if the feature is so important that it needs to get in [10:40] i want a critical bug marked as rtm [10:40] what do others think? [10:40] @unity: ↑ [10:41] tsdgeos: hah... I bet that's the easiest thing to get (the critical bug) :D [10:41] tsdgeos: but I agree with you [10:41] this has to stop [10:41] tsdgeos, mzanetti: don't tell me [10:41] MacSlow: who "asked" for this feature? [10:41] but in the end its kgunn to decide [10:41] mzanetti, true [10:42] well let's convince him [10:42] per are post feature-everything [10:42] yeah, I told him yesterday already [10:42] we want new stuff, fine, let it be in critical bugs [10:42] and I think he had a talk with olli about it too [10:42] mzanetti, implicitly I did too :) [10:42] i want a paper trail when people ask why we were adding features such late [10:42] with kgunn not with olli [10:43] MacSlow: so again, who asked for this feature? and when? [10:43] mzanetti, design and pat [10:44] mzanetti, around last time in London [10:44] tsdgeos: uh... I guess this is required for making the SIM pin unlock behave properly [10:44] mzanetti: : is it? i think it's mainly for sound notifications, no? [10:45] mzanetti: synchronous-notification?! no... that's for the volume-button feedback [10:45] well, atm we have to close the SIM pin dialog and reopen it [10:45] which kills the shaking animation for instance [10:45] mzanetti, https://www.youtube.com/watch?v=VBhxf2iQK8o [10:46] preview 21... duuude :D [10:46] mzanetti, although the visuals are of course updates now... that screencast isn't the latest [10:46] mzanetti, what? [10:47] mzanetti, 21 is the volume one... [10:47] * MacSlow looks again... [10:47] maybe I miss-pasted [10:47] nono... video is fine I guess [10:47] ah ok [10:47] was just wondering if the notifications have so many feature that you can actually get 21 videos out of it [10:47] I struggled with 1 for the right edge [10:48] MacSlow: so https://code.launchpad.net/~macslow/indicator-sound/synchronous-notification/+merge/229061 ? [10:48] mzanetti, I started counting very early... just take a look at preview 1 :) btw... preview != feature [10:49] tsdgeos, yeah it's basically three branches all in all [10:49] MacSlow: and who is reviewing indicator-sound and the notifications one [10:49] ? [10:50] tsdgeos, dednick would be the one for indicator-sound I guess [10:50] MacSlow: then get him to do it, and address tedg's question too === MacSlow is now known as MacSlow|lunch [11:17] Cimi: answered/addressed comments in https://code.launchpad.net/~aacid/unity8/category_view_invisible_in_preview_mode/+merge/231844 [11:25] Trevinho, c'e' un modo per disabilitare le gestures da unity? [11:25] mouse [11:25] mi apre la dash con due dita :'((( [11:26] o alt tab [11:26] Holas [11:40] MacSlow|lunch: please nominate someone to review https://code.launchpad.net/~macslow/unity8/swipe-dismiss-snap-decisions/+merge/233347 [11:55] MacSlow|lunch: things are changing quickly for sure, its fine to work on the vol notif, but those guys are correct in that its not top priority [11:55] https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1232633 [11:55] Launchpad bug 1232633 in unity8 (Ubuntu) "[system] Changing volume doesn't show feedback on the phone" [High,In progress] [11:56] MacSlow|lunch: ...so for next 2-3 weeks priority should be on our "critical" + tag rtm14 [11:57] it may mean, you don't get MP review love [11:57] on a "high" === MacSlow|lunch is now known as MacSlow [12:01] Guest35270, ok... but it's not like I only started on that just a few days ago... for notifications, due to their architecture, make me stretch between backend, frontend and apps, which makes keeping it all tight in a timely manner very hard. [12:02] Guest35270, incoming changes beyond certain dates don't help either [12:29] MacSlow: i hear you, we're all coping... === kgunn is now known as Guest35530 === _salem is now known as salem_ === facundobatista is now known as sala === sala is now known as facundobatista [12:55] Cimi: no... Mi pare di no, s'era discusso riguardo aggiungere la possibilità di disabilitarlo, ma per ora è hardcoded [12:57] Trevinho, dude... wrong channel I bet :) [12:57] MacSlow: no, it's just that Cimi tempts me :D [12:58] Trevinho, don't give in... resist ;) [13:01] mterry: what do you think of https://bugs.launchpad.net/bugs/1370473 ? [13:01] Launchpad bug 1370473 in unity8 (Ubuntu) "The edge demo with a pin is confusing" [Undecided,New] [13:01] mterry: can you nominate someone to review https://code.launchpad.net/~mterry/unity8/tablet-security/+merge/234219 ? [13:02] tsdgeos, commented [13:03] mterry: okidoki [13:03] tsdgeos, you mean can I volunteer someone to review it for me? :) Seems mean [13:04] mterry: well noone has voluteered by himself in almost a week and we need someone to review :D [13:04] mterry: given we don't have Michał i'd appreciate if you know who you think would have more knowledge of the code to review it [13:05] mterry: also i am wondering if we need to care for this at the moment [13:05] where we are time pressed by the phone [13:05] if this is tablet-only [13:05] mterry: maybe we can shelve it to post rtm? [13:06] tsdgeos, one of the theoretical attacks there was actually a phone that plugs into a larger screen to switch to tablet mode (not even sure if that's possible right now, but just in case) [13:06] tsdgeos, so it's not just tablet changes [13:06] hmpf [13:06] ok [13:07] tsdgeos, (get to locked-down emergency dialer, switch to tablet mode, dialer goes to sidestage and you are in session) [13:08] mzanetti, do you have time to review a branch? https://code.launchpad.net/~mterry/unity8/tablet-security/+merge/234219 [13:09] mterry: I started to look at it... but seems a big one. not sure how fast I'll get to it [13:09] mterry: but I'll put it on my todo [13:09] mterry: the other, with the pasphrase design, I belive that breaks some SIM pin lock stuff [13:10] mzanetti, guh! does it use retryText? [13:12] mterry: yes [13:12] mterry: well, not sure if it does already.. but its supposed to at least [13:12] mterry: not sure where Wellark is with that though [13:13] mzanetti, I see... I didn't see it being used in the code === Malsasa_ is now known as Malsasa === dandrader is now known as dandrader|afk [13:42] greyback, is the word autosuggestion box [13:42] greyback, it always counts for height [13:43] Cimi: yeah? Ok, so OSK needs fixing to correctly calculate the visible height of the OSK [13:43] nice find [13:44] greyback, it took me 5 mins to figure out, 2 hours to install the emulator :D [13:44] greyback, thought the emulator was slower, is quite fast! [13:44] Cimi: emulator? Don't you have phones? [13:44] greyback, yes, but I hoped the emulator was slower to highlight the issue [13:46] Cimi: so the autosuggest box idea is a guess, based on what you are seeing? [13:47] greyback, if I disable the autosuggest and other features (simple keyboard), the blank area follows the osk [13:47] Cimi: ok good [13:48] greyback, if I enable the autosuggest, but in some cases is disabled (wifi password), i can see that when I close the keyboard, the blank area starts from 2-3 gu more, (where the autosuggestion box is, even if is invisible) === dandrader|afk is now known as dandrader [13:48] greyback, in oxide is still slow, but maybe we can do something different there [13:49] Cimi: check out lp:ubuntu-keyboard qml/Keyboard.qml and the reportKeyboardVisibleRect() function [13:49] greyback, sure [13:49] greyback, would it be possible to anchor the keyboard to application height? [13:50] greyback, that way the keyboard will disappear a bit more slowly, but the issue will be completely gone [13:50] Cimi: possible yes. But resizing application windows is (1) slow and (2) not what every application wants [13:50] greyback, oxide apparently does [13:50] greyback, and is the worst case so far [13:50] Cimi: I can't comment on how apps do things [13:52] greyback, oxide does, if you try with here maps, you see how the controls on screen move on top when the osk pops in [13:53] greyback, in this case, if the application developer can decide where to anchor the osk, it might be a great workaround [13:53] Cimi: it's not possible right now [13:55] mterry: i'm not sure i understand your reasoing on the LANGUAGE thing [13:55] but i see what you have done works [13:55] mzanetti, so you say to be careful about the API for lockscreen, but if the notification code doesn't use the properties I change, what would be the problem? (were we waiting to hook up replyText once the backend provided it?) [13:55] and have a reasoning [13:56] so i think we can just approve it :D [13:56] tsdgeos, what about it doesn't make sense? [13:56] mterry: yes [13:56] mterry: it is not that it does not make sense, it's just a long sentence! [13:56] tsdgeos, heh [13:56] mterry: also i'm pretty sure those worked at some point [13:56] since we used to have that problem for some other test [13:56] and got fixed [13:57] tsdgeos, huh... I figured they got added for a reason, but following them through, it didn't seem to work [13:57] can't really remember now what was the test that failed without them [13:57] greyback, indeed, in Keyboard.qml you can see that wordRibbon is always taken into account regardless is visible or not [13:57] let me check === Guest35530 is now known as kgunn [13:58] Cimi: looking forward to your patch :) [13:58] greyback, I will ping the maintainer :) [13:59] Cimi: dude come on, you're almost there, just write the fix and submit [13:59] ah the time formatter test [14:01] tsdgeos, oh -- why were they working then without this change ...? [14:01] mterry: because it works :D [14:01] mterry: see http://paste.ubuntu.com/8365199/ [14:02] ahh [14:02] but it has a [14:02] add_custom_target(${_test} env "LC_ALL=C" ${testCommand}) [14:03] greyback, it can be tricky, I have to ask them [14:04] tsdgeos, yeah.. just found that myself [14:04] tsdgeos, right *after* trying to set DEFAULT_PROPERTIES... [14:04] mterry: want to do something regardging that? or should i just approve? [14:04] tsdgeos, err, rather PROPERTIES ENVIRONMENT [14:05] tsdgeos, I can try to clean that up [14:06] mterry: great :) [14:14] tsdgeos, what is the output of your locale? [14:14] i.e. running 'locale' [14:14] mterry: http://paste.ubuntu.com/8365268/ [14:14] tsdgeos, heh, in my en_US locale, the time test didn't fail, just wanted to test that my changes work [14:20] tsdgeos, ah turns out that bit of code doesn't go through add_qml_test anyway. So I only removed the unnecessary set_test_property line but kept the manual env LC_ALL=C bit [14:21] oki [14:25] tsdgeos, thanks! [14:25] pstolowski, do you know if any scope uses the zoomable image? [14:31] Cimi, dunno [14:32] Cimi: in preview? [14:32] cwayne, yes [14:33] Hi! are these playback controls coming from Unity8 ? https://bugs.launchpad.net/ubuntu/+source/indicator-sound/+bug/1370129/+attachment/4205411/+files/sound.png [14:33] Launchpad bug 1370129 in indicator-sound (Ubuntu) "With music-app closed, the controls in the sound menu are dummy" [Undecided,New] [14:49] josharenson: so you said you had issues with unity8 on the desktop? [15:00] tsdgeos, yeah I can't seem to get the settings app to open [15:00] its also taking a much longer amount of time than usual to launch the shell [15:00] josharenson: in the destkop from unity8? [15:00] yes [15:00] we've never had that working afaik [15:00] ah [15:01] * josharenson reads bug again [15:01] or have we? [15:01] josharenson: wait wait, is it unity8 as the shell or unity8 run as app in another shell? [15:01] does the store work? [15:01] as app [15:03] so check out https://bugs.launchpad.net/ubuntu/+source/qtmir/+bug/1354564 [15:03] Launchpad bug 1354564 in unity8-desktop-session (Ubuntu) "Keyboard no longer works in Unity8 desktop session" [Undecided,Confirmed] [15:03] and I'm trying to follow steps in #13 === kgunn is now known as Guest81961 [15:19] cwayne, so? === gatox is now known as gatox_lunch === dandrader is now known as dandrader|lunch === gatox_lunch is now known as gatox === dandrader|lunch is now known as dandrader [17:57] Cimi: mzanetti: kgunn_: hi! in saviq's absence, who is coordinating landings in unity8? We got a fix for an annoying bug in Payments that we'd like to land soon: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1362622 [17:57] Launchpad bug 1362622 in unity8 (Ubuntu) "When cancelling a purchase the progress bar doesn't disappear in the preview" [Critical,In progress] [18:01] alecu: so mzanetti has a silo up, do you have a reviewed/approved/tested branch ? or does it still need to go thru the review cycle ? [18:02] kgunn_: dobey made the branch, I reviewed and tested on my mako with devel-proposed. Since it's a branch for unity8 saviq usually does a review too. [18:03] alecu: ah ok, I'll put it on my todo [18:03] kgunn_: mzanetti: I don't mind being added as lander and doing the testing of this feature on both devel-proposed and rtm [18:04] alecu: ok. I'll put it into the next silo and let you know [18:04] mzanetti: great, thanks. === dandrader is now known as dandrader|bbl === salem_ is now known as _salem === dandrader|bbl is now known as dandrader === kgunn is now known as Guest93957 [23:56] what is the correct way to install unity-notifications? [23:57] * josharenson trying make install like I should have before asking... doh