=== chriadam|away is now known as chriadam [01:30] what's the best way to wrap the basic button text in qml? [01:32] minshallj, oh hey [01:32] minshallj, here are Three ways [01:32] that I know of [01:33] a) Bad Way - Set the button properties to automatically wrap at a certain width [01:33] b) Set the text to HTML/CSS formatting, and use
[01:34] c) Set the text to regular, and just use \n [01:34] minshallj, Does that answer your question? [01:34] I think so, I'll try it out, thanks Akiva-Thinkpad [01:34] minshallj, let me know how it works out [01:38] I guess I'll use the newline. I just thought there might be an easy property to set, like Text has wrapMode, but Button just has a text: field. [01:39] Akiva-Thinkpad: can a) set the button's text to wrap at the button's width? [01:40] minshallj, oh good question. [01:40] minshallj, do you mean that you can set the width to which the text will wrap, ie the margins inside the button? [01:41] yes [01:43] minshallj, I do not know off the top of my head, however in this case I think it is easiest to make a custom button at this point. [01:43] create a new file, first component Item{} [01:44] and within that, put a Shape{} and a Text{} in it, like a label or something [01:44] then what you would do is set the texts anchors to points inside the button [01:44] ok, sounds good [01:44] so the button just isn't advanced enough to be stand alone === chriadam is now known as chriadam|away [03:27] bah [06:41] good morning everyone :) [06:56] mihir: morning [06:59] mihir: I am going split our mp into multiple small ones for easy review. They will depend on one other and should go in a particular order. [07:01] nik90: yeah , was thinking of same, shall we split views , so we ca?n do it lil faster [07:10] Yes [07:11] mihir: also name the branches as 1-branch name, 2-branch name and so on to indicate the order [07:11] nik90: okay [07:11] nik90: i'll do that.. [07:11] i'll start with day view first.. [07:12] mihir: let the header actions go first? [07:12] nik90: okay :) agreed followed by other changes. [07:12] We need that in all the views as prerequisitite [07:13] * mihir__ pulls latest branch [07:13] nik90: i'll put each branch in ubuntu-cal-dev [07:15] Yes definitely [07:24] good morning [07:25] good morning [07:27] mihir__: fix https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/ColorPopUpModify/+merge/235205 ...a small typo [07:28] my vm got crazy today , haha [07:39] what is the correct C++ lib for parsing the xml for scope development? [07:45] mihir__: I made my MP https://code.launchpad.net/~nik90/ubuntu-calendar-app/tweak-event-color/+merge/235137 to be small as well. [07:46] mihir__: it now only adds bg color to the events [07:51] nik90: ohkie , then by tonight we'll have 5-8 branches hehe [07:51] mihir__: :-), I will help [07:51] mihir__: did you already start with the first split? [07:52] nik90: without that it is not possible hehe :D [07:52] nik90: yes..i have started [07:52] mihir__: ok go odd-numbered..so you do 1-mp, 3-mp and so on [07:52] mihir__: i will take even-numbered ones [07:53] nice idea.. [07:53] so lets number now so we don't get conflict [07:53] mihir__: so ping me when you are done with the first mp. I will then get started on the second one [07:54] mihir__: 1-move-common-actions [07:54] nik90: okay got it , http://paste.ubuntu.com/8378130/ [07:54] feel free to change order [08:18] nik90: i proposed a branch https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/1-RemovedDuplicateHeaders/+merge/235246 [08:18] popey: ping [08:18] nik90: did you see kunal's comment :-/ [08:18] ? [08:19] mihir__: yeah I will explain..it should be fine [08:19] nik90: okay thanks :) [08:19] btw, still do we need separate branches , if he has already reviewed ? [08:21] nik90: lets get it merged one by one :) so we don't end up in merging in all branches [08:21] ok [08:22] nik90: thanks :) [08:22] mihir__: can you quickly review https://code.launchpad.net/~nik90/ubuntu-calendar-app/tweak-event-color/+merge/235137 === dholbach_ is now known as dholbach [08:22] * mihir__ do the review [08:22] mihir__: it now only adds bg color to events..no opacity, or font tweaks or anythign of that sort [08:27] nik90: reviewed and top approved [08:28] thnx [08:35] mihir__: does https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/1-RemovedDuplicateHeaders/+merge/235246 require any AP changes? [08:36] nik90: nope, we added objectName as previously so no ap changes [08:36] same as previously* [08:36] mihir__: cool [08:37] hi [08:41] nik90: ping [08:42] mihir__: I am here, you don't need to ping ;P [08:44] mihir__: shall I start the next one? looks like 1-RemovedDuplicateHeaders is almost good to go [08:44] nik90: instead of you wrote common header can't we just use EventAction {} , i just tried and worked [08:44] nik90: like this ,http://paste.ubuntu.com/8378345/ [08:45] mihir__: that would mean you are instantiating a EvenAction{} in every view individually [08:45] mihir__: while now, we instantiate it once in the calendar.qml file and then just past it to different view as required [08:45] hmmm okay i got that , thought differnetly [08:46] nik90: yeah you can go ahead with the second one :) [08:46] mihir__: could you provide me a code diff to that..I can understand better then [08:46] can you just review 1st and merge [08:46] I am just waiting on kunal's reply [08:47] mihir__: btw can you remove "120 + // #FIXME: This action doesn't seem to be visible!" that issue is no longer present [08:48] nik90: http://paste.ubuntu.com/8378373/ [08:48] mihir__: if you do ^^ then do you still see the "Calendar Today" action? [08:49] nik90: yes , i also tried to move that today action to Event Action and it worked on my machine [08:49] mihir__: but the today action is not a generic one though..its trigger function varies depending on the view [08:51] nik90: ohh yes , i forgot that ,VAR is diff , from diff views [08:54] nik90: let me know once you done with second branch , i'll go out and come back within an hour or so [08:54] sure [08:54] * mihir__ hates his ISP [09:07] Yo ho ho, 'n' shiver me timbers! 'appy Friday 'n' 'appy Talk Like a Pirate Day! Yaaarrr! :-D [09:08] mihir__: hey there's an issue with your branch [09:08] nik90: what is that? [09:09] nik90: i'll check once i come back.. [09:09] Jenkins didn't like my MR hehee [09:09] ;) [09:09] JamesTait: Arrr, its that day again :) [09:09] mihir__: http://paste.ubuntu.com/8378489/ [09:10] mihir__: it is a real failure [09:10] mihir__: you copies the wrong trigger functions [09:10] s/copies/copied [09:31] dpm, mzanetti bug 1371516 [09:31] bug 1371516 in Online Accounts setup for Ubuntu Touch "Please add an API to know how many compatible but not authorized yet accounts there are" [Undecided,New] https://launchpad.net/bugs/1371516 [09:31] mardy, what do you think? ^^ [09:41] mihir__: I fixed the issues in your branch [09:43] thanks rpadovani [10:27] beuno, is https://bugs.launchpad.net/developer-portal/+bug/1355807 a priority right now? or some time soon? [10:27] Launchpad bug 1355807 in Developer registration portal "Make interface i18n'able" [Undecided,New] [10:39] rpadovani: hi! I commented on bug 1371516, and closed it; please discuss also with mpt, if you really think that that feature is needed [10:39] bug 1371516 in Online Accounts setup for Ubuntu Touch "Please add an API to know how many compatible but not authorized yet accounts there are" [Undecided,Invalid] https://launchpad.net/bugs/1371516 [10:43] mardy, thanks. I think that using includeDisabled will help me to implement a better workflow, and for now is enough === chihchun is now known as chihchun_afk [10:54] nik90: ohh shit, :( [10:54] nik90: that was bad mistake hehe [10:55] nik90: i just came back home, have ou started working on 2nd? [10:55] you* [11:07] mihir__: yeah it is actually harder splitting the branches than i expected [11:07] mihir__: but I am almost done [11:07] mihir__: but you will have to be really really careful and test since we are essentially building from scratch. [11:08] mihir__: would you be able to test in the office? If not I can propose the branches [11:08] nik90: yup i found the same, so i again informed do we really need to split after kunal's comment? [11:09] mihir__: well I am done with week view.. just fixing the ap tests now [11:09] nik90: can't we go with same branch again , or it is not advisible ? [11:09] mihir__: all that is left is day view, month and year view [11:09] ohkie :) [11:09] mihir__: which same branch? [11:10] the main from which we are splitting [11:10] mihir__: not advisable [11:10] hmmm okay [11:10] mihir__: tbh each of these split branches makes more sense when you look at it [11:10] review it* [11:10] let me know once you do with it, i'll then work on other [11:11] i'll review and test that first , once that get merged i'll work on other, [11:11] ok [11:21] mihir__: https://code.launchpad.net/~ubuntu-calendar-dev/ubuntu-calendar-app/2-Improve-WeekView/+merge/235271 [11:22] mihir__: I going to create 3-Improve-DayView since it is closely related to week view. You can then start on 4-Improve-MonthView. Sounds ok? [11:22] you can even do the year view bit in that branch [12:06] yay my phone should be here today not saturday! === _salem is now known as salem_ [12:30] dholbach, it isn't, it will be soon [12:33] beuno, thanks [12:38] nik90: ping [12:38] mihir__: pong [12:38] hey , i am going to review your MR now [12:39] mihir__: cool. I fixed all AP issues. The tests should pass now [12:39] mihir__: did you get my previous comments about the dayview branch? [12:40] nik90: yeah i saw that , continue [12:40] mihir__: cool. So you will be taking care of month and year and the rest. [12:40] nik90: sure :) [12:44] nik90: you planning to change timer in Dayview ? [12:44] mihir__: timer? [12:44] the time which is in center , we made it on left pane right? [12:45] mihir__: yes I did that in the day view branch [12:45] mihir__: it wasn't necessary in the week view branch [12:45] nik90: okay :) no issue [12:45] it'll change in weekview as well right ? [12:51] yes [12:52] mihir__: weekview uses that component as well [12:53] nik90: one of AP is failing i guess on your MR [12:53] >>> calendar_app.tests.test_weekview.TestWeekView.test_selecting_a_day_switches_to_day_view [12:54] nik90: when do you want clock pushing to the store? [12:54] popey: may be at the end of the day? [12:54] popey: jenkins autolanding was failing yesterday due to bug in phablet-tools [12:54] popey: I think it just got pushed to utopic-proposed. Once that lands, I can merge 2-3 MPs [12:55] popey: balloons commented about that in dpm's reboot translation branch [12:55] mihir__: can you give me a hand with the failing test pls. you wrote it so you might know better [12:56] nik90: i am looking into it wait [12:56] mihir__: thnx [12:59] nik90: yeah, thats what triggered me asking. [12:59] nik90: lets do it later then. [12:59] popey: yup. ack [12:59] nik90: it is dependency to day view [13:00] mihir__: hmm :/ [13:01] mihir__: can you disable and then test then [13:01] mihir__: I will enable it in the day view branch [13:01] I just pushed the day view branch as well [13:03] nik90: [13:03] okay i reverted it [13:03] now i day view branch just make that change in last AP as you did in weekview [13:03] ok [13:04] nik90: to be precices , http://paste.ubuntu.com/8379669/ [13:04] i pushed the changes [13:04] cool thnx [13:06] nik90: let this get approved and then i'll take a look at dayview [13:06] mihir__: ok [13:44] hi [13:46] mihir: hey the week view branch passed :) [13:47] mihir: if you were happy with the review can you approve it.. Not top approve. [13:47] mihir: same with the day view [13:47] Mirv: mean while you can already start on the year view branch parallelly if you want [13:48] nik90: doing it, and why not Top Approv ? [13:48] approve* [13:48] mihir: I thought may be kunal might have some thoughts [13:48] nik90: okay, [13:49] mihir: actually if you want go ahead and top-approve since he did approve during the meeting yesterday [13:50] nik90: ok :) [13:50] nik90: yes sure , i'll top approve this :) and once it merged..you can merge trunk with day view [13:50] Mirv: oops ...it is so confusing with both of you nicks :P [13:51] mihir: that wont be necessary [13:51] mihir: the week view is a prerequisite of the day view branch [13:51] mihir: so it should all work out fine [13:51] okay === chihchun_afk is now known as chihchun [14:05] nik90: popey i was trying this with eventDetails , howz this ,http://i.imgur.com/aCD6z6u.png ? [14:07] nik90: can day view looks cool :) [14:08] mihir: I like the eventDetails page. Can you remove those bold words like Location, Guests, and Remind Me? Replace them with ListItem.Header as that's what we need to use there. [14:08] nik90: yup that is in progress :) [14:08] mihir: ah cool [14:09] mihir: also it would be better if it read "personal calendar" instead of just "personal" [14:09] will make it more clear to the user what that is [14:09] nik90: sure :) [14:16] nik90: i'll push Month and yearview changes in a while [14:17] yeah sure no worries [14:17] I am bit busy now with clock anyway ;) [14:40] nik90, so mind if I switch roles and quiz you now? I'm curious about ActivityIndicator in my app. I'd like some animation to appear, but I'm not seeing anything when it's 'active' [14:41] balloons: :) [14:42] balloons: you don't see the activityindicator at all? [14:42] nik90, I set visible and running to a property. Then I set the property to true, and I would expect to see the circle animation, yes? [14:43] balloons: yes [14:43] balloons: could it be that the activity indicator is hidden beneath some elements? May be just try setting visible and running to true and see if it appears [14:44] balloons: if not, then console output the property which is assigned to the running property to see if it changes correctly [14:45] nik90: what if we want to put appened text in i18n.tr ? [14:46] from JS [14:46] mihir: I remember reading about it a long time back but cannot remember exactly how. [14:46] ahhh , hmmm :| [14:46] mihir: is it not possible in the UI after JS returns the value? [14:47] i might need to use in two cases [14:47] i am assigning value from JS , say take example of calendar [14:47] Personal (Comes from JS object) + "Calendar" [14:47] so i need to put the last append in i18n [14:47] nik90, http://paste.ubuntu.com/8380290/ [14:49] mihir: then do it like i18n.tr("%1 Calendar").arg(valuefromjsobject) [14:49] balloons: it looks good..checking on my desktop [14:50] ahh , that was simple :| [14:51] but i see, i18n works from JS too ,i didn't knew that [14:52] ohh, I see it finally in my actual app. But it's small and appears in the upper left corner [14:52] balloons: ah ofound the mistake in your sample app [14:52] excellent [14:52] balloons: it should be "true" and not "True" [14:52] balloons: as for your positioning that should be easy to do [14:52] perhaps I should black out the screen and center it? [14:52] balloons: if you want it deadcenter in your app, then something like "anchors.centerIn = parent" [14:53] it's waiting for a network refresh after pressing a button [14:53] balloons: yes, you can create a Rectangle{ color: "Black"; opacity: 0.5; anchors.fill: parent } [14:53] balloons: and then add the activity inside the rectangle [14:54] right.. thanks, I think that's what I'm after [14:54] balloons: you want me create a sample code for that? should take 30 secs [14:55] nik90, I wonder about the visible setting? visible: ActivityIndicator.visible [14:55] for the rectangle.. sure [14:56] 1 sec === Laney is now known as Guest37661 [14:58] balloons: http://paste.ubuntu.com/8380368/ [14:58] ahh.. silly me, use the id === chihchun is now known as chihchun_afk [14:58] cool, so I was right on.. thanks nik90 ! [14:59] balloons: indeed :) [14:59] balloons: oh one more thing [15:00] balloons: you don't need to change the activity indicator visiblity setting [15:00] balloons: it is automatically hidden when not running and vice versa [15:03] nik90, awesome thanks. One other question, can I lock them out of the UI while it's running? [15:04] I see I can still push things.. I'm trying to prevent double submissions [15:04] balloons: lock them? [15:04] nik90, prevent them from interacting with UI elements [15:04] balloons: you could disable the button when it is retrieving stuff from the network [15:04] balloons: but I suspect there should be a better way of doing this for all input elements at once [15:04] I could hide them all as well [15:05] but what would you do? [15:05] I could put it in a popup? [15:05] * balloons tries the dialog [15:05] dialog would be your best bet [15:06] it automatically dims your screen for you..so it is a modal window [15:06] preventing input to elements in the background [15:06] nik90: mihir also... let me know if you want me to push a new calendar update to the store, we're quite a few revs behind [15:06] be good to get testing of calendar over the weekend too [15:07] popey, i was asked to drop calendar and was planning to ask CI to remove the tests [15:07] popey: by tonight , i guess we're working on splitting the MR [15:07] mihir: if you get the year view stuff done this weekend, we can push an update to the store [15:07] nik90: i am about to finish that [15:08] ogra_: wow really? [15:08] ogra_: does that mean it wouldn't be part of the default image? [15:10] nik90: mihir looks like they want to trim down some of the default apps on device [15:11] it will of course still be in the store [15:11] and we may indeed re-add it to the image. [15:11] popey: ohhh :| [15:11] ok [15:11] that's sad [15:11] yes [15:11] Yeah. [15:12] worst decision ever if you ask me [15:12] any specific reason ? [15:12] quality / usability [15:12] the work you guys have been doing is stellar [15:12] ah man with all the cool UI improvements calendar it is shaping so nicely and a strong contender [15:12] yeah. [15:12] Lets discuss this at the sprint. [15:13] (I mean, I'm not saying don't discuss now) [15:13] I mean, when we're sat around a table and have design people in the room, that'll make life easier. [15:13] popey: if we can get more usabiltiy case we are ready to improve this [15:14] All of the apps are under constant re-evaluation [15:14] hmmm okay [15:14] nik90, perhaps you could demo with the dialog if it would be quick? I didn't get it to go like I wanted [15:15] balloons: sure, 1 min [15:15] popey: btw, did you look at details screenshot i provided ? [15:15] it's entirely possible for the vendor to say just ship the basic 6 apps dialer, browser, messaging, contact, clock, and no more [15:15] mihir: been in meetings (and am in one right now) ☻ will do. [15:15] nik90: i pushed, lets Jenkins run [15:15] popey: okay great , but device without calendar :-/ (just wondering) [15:15] so yeah, ogra_ go ahead and un-seed calendar, and we'll continue working on the usability over the coming weeks to refine it. [15:16] its in the store. [15:16] two clicks away ☻ [15:16] popey: okay :) [15:16] popey, ok, i'll have to talk to CI still [15:16] we're not removing it from the store. [15:16] ok [15:16] thanks ogra_ [15:17] popey: no issues, let make it that way we can add this again in default :) [15:17] popey: also the calculator :-? [15:17] ogra_: is calendar the only one you've been asked to remove? [15:17] and notes [15:17] ok [15:17] thanks [15:19] popey: http://i.imgur.com/7udUxcB.png , [15:20] why does it say "17:30 18:30"? is that start/end time? [15:21] yup [15:21] needs a "-" between [15:21] looks veeeery much like the android calendar ☻ [15:21] ohh yeah [15:21] popey: took reference from that ☻ [15:21] so "17:30 - 18:30" [15:22] also , it looks more readable the information you wants get top [15:22] yes, i agree === lan3y is now known as Laney [15:25] mihir: how does the dialog look when shrunk down to phone size? [15:27] balloons: http://paste.ubuntu.com/8380567/ [15:27] * mihir grabs screenshot [15:28] nik90, could you take a look at https://www.dropbox.com/s/75m718bljgtvoml/2014-09-19%2015.22.40.mp4?dl=0 [15:29] popey: http://imgur.com/23bykim [15:29] charles: sure [15:29] mihir: nice! [15:30] popey: :) it is still WIP :) [15:30] charles: I noticed this last night as well [15:30] charles: did you by chance change the timezone of the phone before you did this? [15:31] nik90: yes. specifically, I changed the timezone of the phone /after/ the clock app was launched [15:31] nik90, haven't tried it yet with changing the timezone /before/ launching clock app === balloons_ is now known as balloons [15:32] charles: I have a hunch on where the issue might light, will try it out and see how it goes [15:32] nik90, cool === balloons is now known as Guest35774 [15:33] mihir: it's looking good already, thank you! [15:34] nik90: Jenkins passed MR, could you please review it ? [15:34] popey: i have one question [15:34] mihir: yeah in a bit [15:34] mihir: go for it. [15:34] popey: can we remove the location image? [15:35] popey: i don't think it make sense :| [15:35] yes, I would. [15:35] generally , in location we have conference room name or something like that, never keep the map location [15:35] yeah. [15:35] * popey pre-emptively points killer at beuno === Guest35774 is now known as balloons_ [15:36] popey: so is it okay, we remove the location image , correct ? [15:39] mihir: is it possible to determine what kind of location it is in the field? [15:40] does it come from EDS as a LAT/LONG? [15:40] popey: it is simple text :) [15:40] so if i say meeting at IRC it tries to find IRC in map [15:41] i would remove it then, as we don't really use it properly. [15:41] we don't have LAT/LONG , and i am not sure weather EDS supports that [15:41] nik90: agree? [15:42] popey: I was thinking may be we should try to check if the entered location is a valid location and hide it only for invalid cases. But I cannot of a way to do that check programmatically [15:42] think* [15:42] balloons_, elopio, was there a bug for removing patching of the mediascanner2 db? [15:42] yeah, someone could put "London office" or "London", and it wouldn't know the difference [15:42] exactly [15:43] sure then we could remove it [15:43] so we should just display the text? [15:43] and remove the map? [15:43] yes [15:43] nik90: but at this stage , it doesn't make sense i guess, because [15:43] +1 [15:43] nik90: we are not giving any suggestion to while entering location [15:43] mihir: would that be hard to do? [15:44] well, remember that the use case of adding events on device is more "quickly add an event" [15:44] nik90: but considering use case, how would you use location [15:44] whereas you're more likely to be viewing events created elsewhere [15:44] popey: true [15:44] where there _may_ be a location defined [15:44] nik90, I got dc'd for a bit, lost my nick ;-) did you respond on the dialog example/ [15:45] popey: but the issue is also that the image is not interactive [15:45] ahayzen: not from me. I switched context to try to patch the home dir, and that didn't end well either. [15:45] balloons_: yes, [15:45] balloons_: http://paste.ubuntu.com/8380567/ [15:45] nik90: exactly, so if say lets do it Korea, but where in korea, what location [15:45] elopio, hah i was gonna have a look at it to at least remind myself of what the situation was...if i can see anything obvious i'll report a bug and detail what i find [15:45] nik90: popey it would make more sense ,if we allow user to choose location from map while creating an event. [15:46] thanks ahayzen. [15:46] mihir: well that's not an issue since as popey said if an user creates an event in google calendar online, it suggests nearby places [15:46] mihir: so the location data coming in will be accurate [15:46] does google calendar really not add any location metadata when you put some sane location in? [15:47] popey: it suggests nearby places [15:47] it must most likely [15:47] since calendar app shows the correct location in the image rather quickly [15:48] popey: while creating from web [15:48] popey: it gives you suggestion as you type [15:49] popey: i am not sure , in corportate Gmail does that give you list of conferece room, like Exchange server does? [15:51] * popey tries [15:51] doesnt seem to, no. [15:53] popey: nik90 this is in web calendar , http://imgur.com/EgnjMyW [15:53] so it suggest based on what you type [15:54]