[01:18] <hatch__> huwshimi: how goes the battle?
[01:19] <huwshimi> hatch__: Setting up handlebars...
[01:20] <Makyo> bleck, that stupid test took forever, know what I'm doing on catchup week.
[01:20] <Makyo> jujugui if anyone's around, https://github.com/juju/juju-gui/pull/578 is ready for rereview
[01:20] <hatch__> Makyo:  the notification tests?
[01:20] <hatch__> huwshimi:  setting it up....that should be easy???
[01:20] <hatch__> I suppose maybe not heh
[01:20] <hatch__> Makyo:  sure
[01:21] <hatch__> Makyo:  why the changes to pass the index through?
[01:22] <Makyo> hatch__, per rick_h_ 's comment
[01:22] <huwshimi> hatch__: It's not a problem, just a little hassle, having not done it before
[01:22] <hatch__> Makyo:  gotcha
[01:22] <hatch__> huwshimi: ahh yes
[01:22] <hatch__> huwshimi:  you've sure been dipping ways out of your comfort zone lately :) good to see
[01:22] <Makyo> No tests around _waitOnLevel or whatever.  Will have to get some in there.
[01:22] <huwshimi> hatch__: There's 70 thousand ways to set it up
[01:23] <hatch__> lol tis true...tis true
[01:23] <hatch__> considering it's just a templating language there are also as many different processors hah
[01:24] <huwshimi> hatch__: I've gone for a non-YUI way to reduce the dependency
[01:27] <rick_h_> hatch__: yea, the idea is to help the user tell stacks of changesets apart a little to help make the notification seem like it's not a true repeat/etc
[01:28] <hatch__> rick_h_:  yeah np I just didn't see the comment
[01:35] <hatch__> so running Ubuntu on metal on this thing I get 3.5H battery life max....running Ubuntu in Parallels I get 5.5H max
[01:35] <hatch__> lol
[04:44] <huwshimi> rick_h: Reading your blog post and got to the first screenshot of the machine view and now that we've removed the "Machines" title from the top of the list it makes it unclear that what you're looking at is a list of machines.
[04:45] <rick_h_> huwshimi: yea, I break it down into smaller bits, I just think the screenshot will get pushed down to 600px or so and you won't really read it at that level
[04:45] <rick_h_> so each screenshot after that is just a 'section' 
[04:45] <rick_h_> to aid in blog-friendly sizing
[04:45] <huwshimi> rick_h_: I think this is a problem with the interface, not with your post
[04:45] <rick_h_> huwshimi: oh, you mean the machine column poist?
[04:45] <rick_h_> bah
[04:46] <rick_h_> huwshimi: I think it'll be more clear with the hardware info there 
[04:46] <rick_h_> huwshimi: and the nav button is machine
[04:46] <rick_h_> huwshimi: so in usage I think it'll be ok, but we'll find out from the users for sure. 
[04:47] <huwshimi> rick_h_: You can figure it out, but it's now implicit
[04:47] <rick_h_> huwshimi: true
[04:54] <rick_h_> ok, /me is toast and going to head to bed. See you all for release day tomorrow. 
[04:57] <huwshimi> rick_h_: Night
[11:31] <rick_h_> morning 
[11:54]  * rick_h_ heads to take boy to day care and move to coffee shop for emergency injections
[12:19]  * rick_h_ is back
[12:27] <jcsackett> Makyo: you around/available to chat?
[12:27] <rick_h_> jcsackett: probably a bit early yet. Anything I can help with?
[12:27] <rick_h_> jcsackett: I'd expect him in about 1.5hr ish
[12:28] <jcsackett> rick_h_: i'm cleaning up tests, looking in test_environment_view.js
[12:28] <jcsackett> it has tests for "remove relation" and "confirm" buttons, which are gone with MV (we just have the delete icon on the relation now when you click, and no confirm.
[12:29] <rick_h_> jcsackett: ah ok
[12:29] <jcsackett> i'm trying to figure out if this needs to be rewritten, or if we have tests for the new function and these can just be deleted.
[12:29] <jcsackett> i'm also trying to make sure i'm right about what these are testing. :p
[12:30] <rick_h_> jcsackett: gotcha, check out 969dd69e7c52d911b55d98ceda37e97465af9c7e
[12:30] <jcsackett> line 1004 or thereabouts "must be able to remove a relation between services" if you want to look.
[12:30] <rick_h_> jcsackett: and c9beb0576b03fdd395a4dfd3085f68963d173d06
[12:31] <rick_h_> jcsackett: and 5b6a94999f21c1039d86f89bc4cb9f263439602a 
[12:31] <rick_h_> jcsackett: and 45f9c937529e87b9adadb257a3d21d9f1b822066
[12:31]  * jcsackett laughs
[12:31] <jcsackett> this is a lot hashes. :p
[12:31] <rick_h_> jcsackett: so those have commits that seem to be about removing relation stuff
[12:31] <rick_h_> well, it's 4 commits
[12:31] <rick_h_> and I'd check and see what tests those commits have in them
[12:31] <rick_h_> and it might point you towards the idea that it's well tested elsewhere
[12:31] <rick_h_> or it might give you no hope and have you thinking of rewriting what's there
[12:32] <jcsackett> rick_h_: what's the best way to look at what changed in a single commit? "git diff sha1" shows me the diff between my branch and that sha, which is not great.
[12:32] <rick_h_> jcsackett: 'git log -p $sha'
[12:33] <jcsackett> rick_h_: fantastic, thanks.
[12:34] <rick_h_> kadams might be interested in those commits as well I guess
[12:39] <jcsackett> huzzah, did need to rewrite, but just remove the parts about confirming, since the parts about removing are still valid.
[12:40]  * jcsackett continues on
[12:40] <rick_h_> jcsackett: yay
[12:55]  * jcsackett groans at tests that pass on test-prod locally and fail on jenkins
[12:56] <rick_h_> jcsackett: hmm, that's new
[12:57] <jcsackett> rick_h_: has to be an isolation thing; the tests legitemately don't have an ecs set up, so that failure should happen, but doesn't happen locally.
[12:57] <jcsackett> which is fun.
[12:57] <jcsackett> should be an easy fix, at least.
[12:57] <rick_h_> jcsackett: heh, /me can't wait for a week of cleanup...
[12:58]  * jcsackett nods
[13:11] <jcsackett> rick_h_: oh this is annoying.
[13:13] <rick_h_> jcsackett: ugh, notifier tests hitting timing issues on you. Retry :/
[13:13] <rick_h_> that one is the #1 code to get ripped out 
[13:16] <rick_h_> bac: when you're up and about appreciate some english skills on the blog post please. 
[13:16] <rick_h_> bac: since it was written a bit late I don't trust myself :)
[13:17] <bac> rick_h_: i'm about
[13:17] <bac> rick_h_: looking now
[13:17] <rick_h_> bac: sorry, meant that more as a 'when you have time, no rush' than anything
[13:19] <bac> rick_h_: you prefer comments or edit in place?
[13:19] <rick_h_> bac: feel free to edit in place
[13:19] <bac> rt
[13:19] <rick_h_> bac: comments if you're not sure or it's a big change you'd suggest. I can go update it. 
[13:30] <rick_h_> kadams54: how goes, did the relation stuff make any better sense later on?
[13:33] <kadams54> rick_h_: Going well. Should be wrapping up on it soon.
[13:33] <rick_h_> kadams54: awesome
[13:34]  * rick_h_ heads back home from the coffee shop
[13:39] <jcsackett> jujugui: can i get one more review and QA on https://github.com/juju/juju-gui/pull/580
[13:54] <rick_h_> hazmat: getting ping'd by PR and such on machine view stuff and the question came up about comparing to tools available for puppet/chef. It looks like chef is in silent development mode. Is there anything I should make sure to watch as something similar I'd be expected to know/compare it to?
[13:54] <rick_h_> hazmat: last stuff I poked around was the basic ui for docker and I guess the AMZ stuff that has the ability to build out the services. 
[14:16] <frankban> guihelp: need reviews for https://github.com/juju/juju-gui/pull/581 anyone?
[14:17] <rick_h_> frankban: looking
[14:17] <frankban> thanks
[14:17] <rick_h_> frankban: have a sec to chat as well? standup room when you get a sec
[14:17] <frankban> rick_h_: sure joining
[14:23]  * frankban bbiab
[14:50] <hatch> jujugui call in 10
[14:50] <rick_h_> says you :P
[14:52] <hatch> 8?
[14:52] <hatch> :)
[15:00] <rick_h_> jujugui call now!
[15:00] <rick_h_> wheee
[15:00] <rick_h_> rogpeppe: ^
[15:33] <hatch> looks like the save config command no longer sends only the changed fields...but instead sends all of them
[15:33] <hatch> not really an issue but we may want to look into that
[15:40] <hatch> wait nm ignore that
[15:45] <jcsackett> rick_h_: can you look at my reply on https://github.com/juju/juju-gui/pull/582 when you have a chance? want to make sure we're on the same page.
[15:47] <rick_h_> jcsackett: looking at the diff there's the green lines of adding in the stuff in taht if statement
[15:47] <rick_h_> rmrelation_dialog.hide()
[15:47] <rick_h_> ...
[15:47] <rick_h_> jcsackett: so it appears that only the if itself was removed vs the code it contained?
[15:48] <jcsackett> rick_h_: bah, misread side-by-side.
[15:48] <jcsackett> rick_h_: you're right. updating.
[15:48] <rick_h_> jcsackett: cool, thanks for the double check
[15:48] <jcsackett> rick_h_: removing flags gets a bit confusing. :p
[15:48] <rick_h_> 100%
[16:07] <kadams54> guihelp: Looking for reviews and QA on https://github.com/juju/juju-gui/pull/583
[16:07] <kadams54> hatch: ^^^ I'm sure you'll have an opinion :-)
[16:08] <hatch> kadams54: heh I'll look a little later
[16:08] <kadams54> hatch: oh yeah, heads down… get back to work! ;-)
[16:09] <kadams54> Going to lunch and then starting in on lots of QAing <- jcsackett, frankban 
[16:09] <rick_h_> frankban: Makyo if you guys could peek at ^ that'd be great please. The relation stuff is tricky 
[16:10] <frankban> kadams54: looking
[16:10] <Makyo> rick_h_, kadams54 sure
[16:10] <rick_h_> ty all
[16:13] <jcsackett> kadams54: thanks.
[16:43] <Makyo> jujugui any further thoughts on https://github.com/juju/juju-gui/pull/577 ?  It's trivial, may just ship it
[16:43] <rick_h_> Makyo: feel fre
[16:44] <Makyo> Cool, thanks
[16:50] <frankban> kadams54: reviewed
[16:51] <frankban> kadams54: I have to go in 5, if my branch looks good to you please feel free to shipit later
[16:51] <kadams54> frankban: Thanks! Will do.
[16:53]  * rick_h_ goes to make up some lunch
[17:04] <rogpeppe> jaasteam: trivial lppublish bug fix: https://github.com/juju/charmstore/pull/117
[17:06] <rogpeppe> if anyone is, like me, interested in studying the current charm and bundle "corpus", here's a script that downloads all charms and bundles: http://paste.ubuntu.com/8419426/
[17:06] <hatch> phew I think all done this now
[17:06] <hatch> what a mess
[17:07] <hatch> oh well
[17:08] <hatch> *stretch*
[17:11] <rogpeppe> and here *are* all currently known bundles, in one lump: http://paste.ubuntu.com/8419463/
[17:12] <hatch> rick_h_: so far the only known bug this will create moving forward is that once you resolve a conflict the setConfig record is still there even if the value which was changed is no longer changed - but it is set to the appropriate values as a workaround
[17:12] <hatch> but I figure that this is a limited use case anyways....and that isssue is even MORE limited
[17:12] <hatch> heh
[17:15] <hatch> Marky Mark and the Funky Bunch - Good Vibrations (feat. Loleatta Holloway)
[17:15] <hatch> https://www.youtube.com/watch?v=-eSN8Cwit_s
[17:17] <urulama-afk> so, rogpeppe, how are we going to deal with the first "cloud" charm, as it has orangebox bundle inside?
[17:19] <rogpeppe> urulama-afk: it would turn into two charms with the names ~kirkland/bundle/transcode-cluster-cloud and ~kirkland/bundle/transcode-cluster-orange-box
[17:19] <rogpeppe> s/two charms/two bundles/
[17:19] <urulama-afk> rogpeppe: ok, and to my actual question: can we reference one bundle from another?
[17:20] <rogpeppe> urulama-afk: no, bundles can only refer to charms
[17:20] <rogpeppe> urulama-afk: unless... oh yes, there might be some kind of inheritance thing going o
[17:21] <rogpeppe> urulama-afk: but only within a set of bundles within the same file
[17:21]  * rogpeppe tries to remember where the original bundle specification was documented
[17:21] <rogpeppe> hazmat: any idea?
[17:22] <urulama-afk> rogpeppe: so instead of juju deploy ~kirkland/bundle/transcode-cluster, we need juju deploy ~kirkland/bundle/transcode-cluster-orangebox and then ~kirkland/bundle/transcode-cluster-cloud
[17:22] <urulama-afk> rogpeppe: is that correct?
[17:22] <rogpeppe> urulama-afk: the first one wouldn't be valid anyway
[17:23] <rick_h_> hatch: yea, sounds good to me 
[17:27] <hatch> jujugui I need two QA's on this branch https://github.com/juju/juju-gui/pull/584 no review yet - I still need to write the tests, but the qa should have quite a bit of exploratory work around it.
[17:38] <jcsackett> hatch: can "modifyUnits" in service-overview.js be removed? it's part of the old scale up system, right?
[17:38] <hatch> sec otp
[17:38] <jcsackett> line 511, or thereabouts when you have a moment.
[17:39] <hatch> ok looking
[17:41] <hatch> jcsackett: yeah looks like it was only part of the old stuff
[17:41] <jcsackett> hatch: whoo. that's good news, means i can start resolving some test issues by ripping that out. :)
[17:41] <hatch> awesome - also the template and the _modifyUnits stuff
[17:41] <jcsackett> hatch: second question for you, b/c i can't remember. is this one of our spurious issues? http://ci.jujugui.org:8080/job/juju-gui/1943/console
[17:42] <hatch> I'm pretty sure the spurious ones were only in ie now
[17:42] <jcsackett> fantastic. why doesn't this show the failure output in a useful fashion? :p
[17:42] <hatch> jcsackett: yeah that looks like a real error
[17:42] <rick_h_> jcsackett: don't think so. It has a failure on 'ecs methods - is instantiable'
[17:43] <jcsackett> rick_h_: where are you seeing that?
[17:43] <jcsackett> i've stared at this so much i just see text without meaning.
[17:43] <hatch> in the sauce video
[17:43] <rick_h_> jcsackett: clicking on the link to the sauce labs, clicking on the screenshots
[17:43] <jcsackett> aaaah
[17:43] <hatch> or the screenshots
[17:43] <hatch> heh :)
[17:43] <rick_h_> start with screenshots and then go to video when they skip what you want to see ime
[17:45] <jcsackett> ok, i badly need lunch and then i'll return to this.
[17:55]  * hatch puts his HTC One in his front pocket and goes to lunch without any fear of it bending...
[17:55] <rick_h_> lol
[17:56] <kadams54> lol 
[17:58] <hatch> :D
[18:00] <hazmat> rick_h_, re competing guis.. see panamax.io for docker from telco centurylnk
[18:00] <rick_h_> hazmat: ty
[18:01] <hazmat> rick_h_, also ansible tower though its a different focus
[18:03] <hazmat> re puppet/chef the chef ui is as minimalist as ever.. no changes really. salt has halite (https://github.com/saltstack/halite) which is also minimal but functionaly.. there's a couple more polished ones for puppet 
[18:46] <hatch> we really need a better container story...
[18:54] <rick_h_> hatch: you up for air or want to pass on meeting today?
[18:55] <hatch> ummm I have nothing to chat about, could keep on this test fixing unless u have something?
[18:55] <rick_h_> hatch: rgr
[18:55] <rick_h_> hatch: sounds good, thanks
[18:58] <hatch> jujugui speaking of which I still need some qa's on my PR so we can get it landed as soon as I finish these tests
[18:59] <kadams54> hatch: QA-ing another card right now; I can start in on yours in about 10 minutes or so.
[18:59] <hatch> cool thx
[19:00] <hatch> my qa is time consuming - lots of possible interactions
[19:00] <hatch> so wanted to get as much of a head start as possible :)
[19:00] <kadams54> hatch: my favorite kind :-)
[19:15] <rick_h_> hatch: post YUI javascript session added to brussels and noted you'll have research to present. 
[19:16] <hatch> as marky mark would say "word-to-your-motha"
[19:16] <Makyo> ...
[19:16] <rick_h_> ummm, wow
[19:16] <hatch> Makyo: did you miss my previous link to the video?
[19:16] <hatch> lol
[19:16] <hatch> ok maybe that was only funny in my head
[19:17]  * hatch goes back to clown college 
[19:17] <Makyo> Hahaha
[19:19] <hatch> ok after wiping the tomatoes off my face after that performance I'm going back head down to get this finished :)
[19:29] <Makyo> Deploying the mongo bundle to local provider was a bad idea.  My laptop is supremely unhappy.
[19:32] <hatch> :) io is probably hammered
[19:36] <Makyo> It just turned off :P
[19:36] <hatch> lol nooooo
[19:37] <hatch> jujugui we have tests for conflicts in the inspector constraints UI....this doesn't even exist any longer does it? cc jcsackett
[19:37] <jcsackett> hatch: there's constraints editing stuff in the scale up UI--if it's not that, then no.
[19:37] <hatch> right....but that's not databound
[19:37] <hatch> so ok this is all for the old UI
[19:38] <hatch> ctrl+a del+
[19:40] <hatch> it's so nice working directly in Ubuntu
[19:45] <rick_h_> hatch: <3
[19:46] <hatch> :)
[19:50] <rick_h_> jcsackett: how you doing? need a hand duping tests on that one branch still or anything?
[19:52] <jcsackett> rick_h_: i was able to replicate them, with some pain, locally, and i think i fixed them. watching CI again now.
[19:52] <jcsackett> rick_h_: and fortunately working on the last of the mv work as i wait, so things continue along.
[19:52] <jcsackett> rick_h_: that stupid branch, man.
[19:52] <rick_h_> jcsackett: ok, ping if you need anything
[19:53] <rick_h_> Makyo: did you replicate frankban's QA issue at all?
[20:02] <Makyo> rick_h_, Oh, hm, I didn't try that.  Back up and running, will focus.
[20:04] <Makyo> rick_h_, it's existing, shouldn't block kadams54 - I'll get on that right now.
[20:08] <rick_h_> Makyo: ty!
[20:13] <rick_h_> kadams54: can you let me know when you address frankban's comments then and go ahead and land that one please?
[20:14] <kadams54> rick_h_: sure. Was planning on doing that after I finished QA on hatch's PR.
[20:14] <rick_h_> kadams54: ok cool thanks
[20:14] <hatch> ugh just waisted an hour on tests which don't matter
[20:15]  * hatch throws a "our test suite is a mess" hissy fit
[20:19] <hatch> kadams54: I'm just about ready to push up the tests - any big issues?
[20:19] <kadams54> hatch: Don't know.
[20:20] <kadams54> hatch: Or: yes.
[20:20] <hatch> wait I lied...I have another failing test
[20:20] <hatch> there is an issue?
[20:20] <kadams54> hatch: I ran into an uncaught error while just trying to deploy mysql. I'm not sure if it's on your branch or a regression in develop. I'm checking develop now.
[20:21] <hatch> hmm I can deploy it here so I hope it's develop heh
[20:23] <kadams54> guihelp: well fudge. develop seems to have a pretty serious regression on it. This is what I get when I just try to drag-n-drop a service to the canvas (selecting auto-deploy in the deploy summary for the units):
[20:23] <kadams54> "Uncaught TypeError: Cannot read property 'apply' of undefined", environment-change-set.js:244
[20:24] <rick_h_> kadams54: I can replicate here, in the function call the env is a list vs a single environment
[20:25] <rick_h_> jujugui http://paste.ubuntu.com/8420601/ is the breakage point and the value of env is a list of two items long
[20:25] <kadams54> rick_h_: Maybe introduced by the multi-ecs work then? I haven't done any deeper digging (bisecting) so that's purely a guess.
[20:25] <rick_h_> yep, here  Y.soon(Y.bind(this._commitNext, this, [env, currentIndex]));
[20:26] <rick_h_> that is broken and passing env, index around as env
[20:26] <rick_h_> _commitNext: function(env, currentIndex) { is the signature
[20:26] <rick_h_> so the [] is not needed
[20:26] <rick_h_> or is off or something
[20:27] <hatch> +129  −390   awww yeah
[20:28] <rick_h_> kadams54: ok, keep going on QA, I'm going to do a quick test removing the [] and make sure that fixes it
[20:29] <kadams54> rick_h_: will do
[20:31] <hatch> jujugui my branch is completely finished now and ready for reviews/qa https://github.com/juju/juju-gui/pull/584
[20:35] <rick_h_> hatch: rgr
[20:39] <hatch> rick_h_: where is your test :PPP
[20:39] <hatch> rick_h_: what would you like me on?
[20:40] <rick_h_> hatch: so general QA and reach out if anyone needs a hand like jcsackett with the FF or Makyo with the relation line issue. 
[20:41]  * hatch opens arms "come to me with your problems"
[20:41] <rick_h_> hah
[20:42] <hatch> I can hop on some more reviews once your fix lands
[20:42] <hatch> the ci box is just burrrrnin
[20:42] <rick_h_> we've got 5 branches in the queue to get through CI and then I can work on the release tonight at the coffee shop
[20:44] <kadams54> jujugui: FYI, I'm going to have to leave for dinner/family stuff around 5, but should be back on around 6.
[20:45] <rick_h_> kadams54: ok, what's left on your plate between now and 5?
[20:45] <hatch> I cleared my schedule (because it was SOOOO full) for tonight if we need extra backup
[20:45] <rick_h_> hatch: hah, no kiting to celebrate pre-release?
[20:46] <hatch> no wind!
[20:46] <kadams54> rick_h_: I just addressed frankban's comments on my PR#583. Hopefully the merge build will go through fine and I'll be able to ship that.
[20:46] <rick_h_> kadams54: ok cool
[20:46] <rick_h_> kadams54: then enjoy dinner and if anything goes boom we'll get it covered. Thanks for the work today!
[20:46] <kadams54> rick_h_: Currently QAing Jeff's in a real env (i.e., off his branch and not with latest from develop merged in) and trying to figure why I'm not seeing an orange exclamation mark.
[20:47] <rick_h_> kadams54: ok, I'm loading a live env as well atm
[20:47] <kadams54> Yeah, that's why I'm not yelling at hatch yet :-)
[20:47] <kadams54> Since you didn't run into any problems.
[20:48] <rick_h_> kadams54: yea, maybe check the source and it's a build issue where the css has an issue or something
[20:48] <Makyo> jujugui https://github.com/juju/juju-gui/pull/586 quick relations thing, just moving some code to the right place.
[20:49] <rick_h_> Makyo: looking while the source updates on jeff's live env
[20:49]  * Makyo runs to exercise dogs real quick
[20:49] <kadams54> *sigh* Just had to explain to my second grader that whacking the iPhone is not going to solve the problems he's experiencing.
[20:49] <rick_h_> lol
[20:50] <rick_h_> "does it bend?! I mean blend?!"
[20:50] <hatch> lol
[20:51] <kadams54> He seems determined to prove that even 5Ses are prone to bending…
[20:51] <kadams54> Provided you whack them repeatedly when Minecraft freezes up.
[20:51] <hatch> give him an 80's Nintendo controller - those things were bullet proof
[20:51] <rick_h_> "I TOLD you this one's dead I need a new one!"
[20:51] <hatch> haha
[20:51] <kadams54> Too bad the cartredges weren't ;-)
[20:51] <hatch> truth
[20:51] <hatch> but the crt tv screens were very strong so you could huck that controller at it
[20:52] <kadams54> None of the "Wiimote through the brand new flatscreen" problems.
[20:52] <hatch> exactly....things just aren't made like they used to be
[20:54] <rick_h_> woot! hatch qa ok on a live env here
[20:54] <kadams54> hatch: I don't see any related CSS. Does the orange exclamation mark come from _showConflictUI?
[20:54] <hatch> yusssss
[20:54] <rick_h_> orange point works for me
[20:54] <hatch> kadams54: it's always been there
[20:54] <rick_h_> in both dev and live lxc env
[20:54] <hatch> that was all the oldschool UI I just hooked up
[20:55] <kadams54> Ok
[20:56] <kadams54> Holy crap hatch, you weren't kidding when you said CI was on fire.
[20:57] <hatch> haha yup
[20:57] <rick_h_> shhhh, she's behaving at the moment
[20:57] <rick_h_> go baby go!
[20:57] <hatch> lol right
[20:58] <kadams54> hatch, rick_h_: Well I gotta pack up. I'll have to circle back on Jeff's branch and the problems I'm having later tonight. I'll also check on my PR and make sure the merge build went through OK.
[20:58] <kadams54> It may take until 6 before that thing actually builds :-)
[20:58] <hatch> haha
[20:58] <kadams54> See ya'll in a bit.
[20:58] <rick_h_> kadams54: all good, Makyo can you do a second opinion  on hatch's branch please?
[20:58] <rick_h_> hatch: you looking to be a second on Makyo's branch?
[20:59] <rick_h_> hatch: I did QA so just need second review
[20:59] <hatch> on it
[21:01] <rick_h_> jujugui wife is tied up at work so I have to get the boy. Carry on and I'll be back shortly. 
[21:04] <jrwren_> I'm EOD. I'll chat ya'll tomorrow.
[21:04] <hatch> cya jrwren_
[21:26] <jcsackett> hatch: can you look at the cursed branch? it finally finished its CI run and now has *more* errors.
[21:26] <jcsackett> at this point i think i might be breaking it rather than fixing it.
[21:27] <hatch> jcsackett: haha ok looking
[21:34] <hatch> jcsackett: very odd....
[21:34] <jcsackett> Not so much odd as a damn mess. 
[21:35] <hatch> jcsackett: can you land it in smaller bits? Or is this all required?
[21:35] <jcsackett> I mean, that *is* one small bit. 
[21:37] <hatch> yeah I mean there isn't much code changes for all the tests that need changing
[21:37] <hatch> are all the test changes necessary with that code change?
[21:39] <hatch> jcsackett: well the good news is that I can reproduce the failure locally
[21:39] <jcsackett> Really? Cause I can't. That passed. 
[21:39] <jcsackett> What did you do?
[21:40] <hatch> just ran them in FF
[21:40] <hatch> failed hard first run
[21:40] <hatch> that's where they are failing in CI too
[21:40] <hatch> they pass fine for you?
[21:41] <jcsackett> Yeah. Or I wouldn't have submitted. 
[21:41] <rick_h_> hatch: can you pick it up since you can dupe please?
[21:41] <rick_h_> jcsackett: and you can run with the otehrs 
[21:42] <jcsackett> Works for me, if that works for hatch. 
[21:42] <rick_h_> I'll bribe him with a mouse 
[21:42] <hatch> lol
[21:43] <hatch> you could pay for my geekdesk? :P
[21:43] <hatch> yeah I'll take over on this
[21:43] <rick_h_> lol, man price of a bribe is going way up
[21:43] <rick_h_> jcsackett: can you get hatch the starter commit sha?
[21:43] <hatch> haha - other cheaper options include a PS4
[21:43] <rick_h_> jcsackett: I think maybe all the work to 'make them pass' might have left things worst than they started out at
[21:43] <hatch> Destiny for PS4
[21:43] <hatch> hmm....that's all for now
[21:44] <hatch> I will just start from scratch
[21:44] <hatch> jic
[21:44] <jcsackett> hatch: i can send you the initial branch. 
[21:44] <hatch> nah it's ok I got the commits
[21:46] <jcsackett> hatch: basically just grab the app/app.js flag stuff. the endpoints bit can be ignored.
[21:46] <jcsackett> and it's the app setting the ecs on by default that started all this fallout.
[21:47] <hatch> cool
[21:54] <Makyo> We wearing jenkins out?
[21:54] <rick_h_> npm out
[21:55] <rick_h_> npm is getting angry at all the downloading
[21:55] <Makyo> Boo
[21:58] <rick_h_> Makyo: how went the QA of hatch's stuff?
[21:59] <Makyo> Oh, it went okay, one sec.
[22:09] <rick_h_> Makyo: lint error in your branch killing CI
[22:09] <rick_h_> Makyo: sorry, I misread it the first time I looked
[22:09] <rick_h_> test/test_environment_view.js: line 1032, col 51, Missing semicolon. (W033)
[22:09] <rick_h_> Makyo: ^
[22:10] <Makyo> rick_h_, ack, on it
[22:13] <rick_h_> jujugui I'm going to head off to the coffeee shop for CHC tonight. I'll check in from there in 45ish. Makyo if QA goes well please ship hatch's and if anyone sees kadams back ask about his branch. He's pushed another commit of comments, but not sure if it's ready foir landing
[22:13] <Makyo> Sounds good.  SEe ya later
[22:16] <hatch> jcsackett: so here is the problem....as far as what's causing it...I have no idea       `  http://0.0.0.0:8888/login/undefinedapi/3/search/interesting `
[22:17] <jcsackett> hatch: should i run my localhost for that, or is taht something else?
[22:17] <jcsackett> oh!
[22:17] <jcsackett> i missed the undefined.
[22:17] <jcsackett> that's...*really* weird.
[22:17] <hatch> it happens when I add the ecs to the env
[22:18] <hatch> for the endpoints
[22:18] <hatch> (which needs to be done else it fails even sooner)
[22:25] <hatch> jcsackett: even if I skip the ecs and just stub out the deployer bar instantiate method I get the same issue
[22:25] <hatch> going to take a bit longer
[22:26] <jcsackett> hatch: if you're still grinding after i finish off the other flag locations i'll start poking back at it.
[22:33] <hatch> jcsackett: ok so for some reason the test is passing...but then comes back and fails in the 'after' because the url was changed to /login
[22:35] <hatch> lol
[22:36] <hatch> jcsackett: solved that one
[22:36] <hatch> the env had no creds so it would redirect the user away
[22:39] <jcsackett> hatch: interesting.
[22:39] <jcsackett> i wonder why removing the mv flag would cause that.
[22:40] <hatch> who the heck knows
[22:43] <hatch> another failure down....
[22:43] <hatch> lets see if this works
[22:43] <hatch> oo it passed all the tests in debug
[22:44] <jcsackett> hatch: hopefully you won't have my situation where that means *nothing*. :p
[22:44] <hatch> hahaha
[22:44] <jcsackett> and if it does, i'm removing my LXC and going to go the vagrant route.
[22:44] <jcsackett> er, and if you don't, rather.
[22:45] <hatch> well my fixes are totally different than yours
[22:45] <hatch> well...same idea
[22:45] <hatch> different approach
[22:47] <hatch> jcsackett: well....it failed spectacularly in the browser
[22:47] <jcsackett> hatch: i'm sorry to hear that.
[22:47] <hatch> like...ka....fricken...boom!
[22:48] <hatch> good news
[22:48] <hatch> different tests failed
[22:48] <hatch> lol
[22:48] <hatch> progress??
[22:53] <hatch> oo only 15 failures in the browser now
[22:53] <hatch> why are they always part of notifications...sonofa
[23:01] <hatch> jcsackett: got it
[23:01] <jcsackett> hatch: nice.
[23:01] <jcsackett> i can review it.
[23:01] <hatch> just running lint then I'll push up
[23:06] <hatch> jcsackett: https://github.com/juju/juju-gui/pull/587
[23:06]  * hatch crosses fingers it works in CI
[23:07] <rick_h_> poor poor CI
[23:07]  * rick_h_ remembered that he needs to generate the changelog...o...m...g
[23:07] <hatch> lol
[23:09] <rick_h_> woot! my big picture frames of the CA trip shipped. 
[23:09] <rick_h_> Tomorrow is going to be win win win
[23:09] <hatch> riiiight on
[23:09] <hatch> amazon.com has the playstation pkg I want but they won't ship to Canada :///////
[23:11] <hatch> I could understand if amazon.ca had them....but seriously they ship from the same damn warehouse
[23:12] <hatch> oh I also have to do that blog post tonight
[23:12] <rick_h_> hatch: :P
[23:13] <rick_h_> hatch: though you can do friday as well if you need
[23:13] <rick_h_> hatch: do it during the day tomorrow
[23:13] <rick_h_> hatch: lots of time :)
[23:15] <rick_h_> lol https://www.youtube.com/watch?v=IROcoJeVfSI#t=348 well my new motox won't bend at least :)
[23:16] <hatch> gooood idea
[23:18] <rick_h_> ok, land all the things, anger the CI gods for a few more branches
[23:18] <rick_h_> time to get changelogging
[23:21] <hatch> I can't believe I'm watching this
[23:22] <rick_h_> lol
[23:22] <rick_h_> I didn't have sound so you've got more info than me
[23:24] <hatch> 3 branches to go......go go ci go
[23:33] <jcsackett> rick_h_: are we comfortable releasing without all the MV cleanup done?
[23:34] <hatch> jcsackett: I don't think there would be much issue
[23:34] <hatch> some code bloat but I don't think there is any real side effects
[23:34] <hatch> not that you were asking ME
[23:34] <hatch> :P
[23:35] <rick_h_> jcsackett: yes
[23:35] <rick_h_> jcsackett: and I think we can plan on another release next week
[23:35] <rick_h_> jcsackett: with some cleanup and bug fixes/etc
[23:36] <rick_h_> jcsackett: so don't go all night if you're not going to make it
[23:36] <rick_h_> well, I take that back. Don't go all night even if you will make it
[23:37] <hatch> haha
[23:37] <jcsackett> rick_h_: i'm going to keep hacking at this b/c i'm mad at it, but good to know. :)
[23:38] <rick_h_> jcsackett: it's 7:30pm man. Go to dinner followed by bed 
[23:38] <rick_h_> if we hit any issues tomorrow I'll need you all to help
[23:38] <rick_h_> jcsackett: and getting this done isn't going to change anything release-wise
[23:38] <rick_h_> seriously, go rub your wife's feet or something :P
[23:38]  * jcsackett laughs
[23:38] <hatch> OR
[23:38] <hatch> she could rub yours!
[23:38] <jcsackett> she's not home yet. when she gets home, i'll kick off.
[23:39] <jcsackett> hatch: that's not going to happen. :p
[23:39] <hatch> lol well it was worth a try
[23:40] <rick_h_> ok commit log isn't all that bad actually
[23:40] <rick_h_> since 1.1.1 we've basically worked out $#$#@ off on MV
[23:49] <hatch> oh no huw today
[23:50] <rick_h_> oh yea, it's his thurs
[23:50] <rick_h_> he's finally swap daying london
[23:51] <hatch> yeah I got to do that!!
[23:51]  * hatch looks at calendar
[23:55] <hatch> ugh my branch failed
[23:56] <hatch> wth it passed in everything locally
[23:56] <rick_h_> hatch: yea, giving it another shot
[23:56] <hatch> nah it'll fail
[23:56] <rick_h_> hatch: but if you want to see if you can dupe that'd be cool
[23:56] <hatch> I know how to fix it
[23:56] <hatch> but I can't dupe
[23:56] <rick_h_> party
[23:56]  * rick_h_ runs away
[23:56] <hatch> so will just have to be a hope and a dream hah
[23:56] <rick_h_> hah, hopes and dreams, we're UI Engineering