| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| ahoneybun | the new update to click-reviewers-tools did not fix my errors | 03:15 |
|---|---|---|
| mihir | Good Morning all :) | 04:36 |
| === chihchun is now known as chihchun_afk | ||
| zsombi | nik90: ping | 05:28 |
| zsombi | nik90: dunno what happened recently with EDS backend, but I cannot run Alarm tests so they pass the same amount... one run stops with fatal error, one run fails 4 tests, then a next one fails only one, aso... | 05:29 |
| mihir | zsombi: ping quick question | 05:35 |
| zsombi | mihir: shoot | 05:35 |
| mihir | zsombi: who will be the right person to talk about date time indicator package issues ? | 05:35 |
| mihir | zsombi: to be precises this project , https://bugs.launchpad.net/ubuntu/+source/indicator-datetime | 05:39 |
| zsombi | mihir: charles | 05:40 |
| mihir | charles: ping | 05:40 |
| mihir | zsombi: thank you :) | 05:40 |
| zsombi | mihir: he is located in US, so he will probably respond in +7h | 05:40 |
| mihir | zsombi: ahh okay thanks for that too , i will poke him in my night time :D | 05:41 |
| zsombi | mihir: you better write an email to him :) | 05:41 |
| mihir | okay :) | 05:42 |
| === chihchun_afk is now known as chihchun | ||
| justCarakas | o/ morning all | 07:21 |
| mardy_ | rpadovani: hi! This is the reason for the crash you were seeing: https://bugs.launchpad.net/accounts-qml-module/+bug/1375161 | 07:21 |
| ubot5 | Ubuntu bug 1375161 in accounts-qml-module "Objects returned by the AccountServiceModel have wrong ownership" [High,In progress] | 07:21 |
| === mardy_ is now known as mardy | ||
| nik90 | zsombi: the most recent change to EDS was https://code.launchpad.net/~renatofilho/qtorganizer5-eds/fix-1371341/+merge/235452 | 08:33 |
| zsombi | nik90: exactly... 1) the event data update is screwed, the IDs somehow are not teh same, though when printed they look the same, but when I compare two QOrgenizerItemId's then they say they're different | 08:34 |
| zsombi | nik90: 2) tags seem not to be supported at all :D | 08:34 |
| zsombi | nik90: so the fix for tagging Todos it doesn't work :D | 08:34 |
| nik90 | zsombi: but the change to EDS happened before your tag branch. | 08:35 |
| zsombi | nik90: yes... we had not tested with eds... so that's our fault... | 08:35 |
| zsombi | nik90: I've tested only with memory manager, and that works | 08:35 |
| nik90 | oh | 08:36 |
| zsombi | nik90: btw everything works with that | 08:36 |
| JamesTait | Good morning all; happy International Translation Day! :-D | 08:36 |
| zsombi | nik90: look at this: http://pastebin.ubuntu.com/8464441/ | 08:36 |
| zsombi | nik90: teh cookies look teh same when printed with toString() | 08:37 |
| zsombi | nik90: but they are compared as QOrganizerItemIds | 08:37 |
| zsombi | nik90: and that gives false on == | 08:37 |
| zsombi | nik90: wow.... there's something wrong.... | 08:39 |
| nik90 | I was told by renato that previous to his patch, recurring alarms were saved with the wrong format and as such they stopped working after a while | 08:39 |
| nik90 | it was also confirmed by charles | 08:39 |
| zsombi | nik90: I do get that... but there's something else that is wrong still! | 08:41 |
| nik90 | zsombi: if you revert your tag branch, does that fix the tests? | 08:41 |
| zsombi | nik90: why is it so that if I compare two QOrganizerItemIds which show the same when toString()-ed, they differ | 08:42 |
| zsombi | nik90: nope | 08:42 |
| zsombi | nik90: and this only happens if I'm getting the organizer IDs from EDS!!! | 08:43 |
| nik90 | hmm | 08:45 |
| zsombi | nik90: huhh???! If I run teh tst_alarms from QtC, I don't get warning, that the alarm is not in the list... but if I run it from the terminal I get them... | 08:47 |
| mivoligo | mzanetti: hi | 08:54 |
| mzanetti | mivoligo: hi | 08:54 |
| mzanetti | mivoligo: I think I broke the google drive :D | 08:54 |
| mivoligo | mzanetti: how so? | 08:55 |
| mzanetti | mivoligo: I renamed the file color-specifications to color-specifications.txt | 08:55 |
| mzanetti | and then all the content from the folder disappeared | 08:55 |
| mivoligo | :D | 08:55 |
| mzanetti | oh look | 08:55 |
| mzanetti | its back | 08:55 |
| mzanetti | really couldn't access anything any more yesterday | 08:55 |
| mivoligo | but the name is not changed | 08:56 |
| mzanetti | yeah. I pressed back in the browser until I came back to the file and renamed it back, hoping it would restore things... | 08:57 |
| mzanetti | let me try again :) | 08:57 |
| mivoligo | mzanetti: drive does not have a clue how to open the text file :D | 08:57 |
| mzanetti | well. not it its not named .txt | 08:57 |
| mzanetti | which is why I renamed it | 08:57 |
| mzanetti | oh... doesn't work with .txt either | 08:57 |
| mivoligo | yep, asks me to select an app to open it | 08:58 |
| mzanetti | yay for the web | 08:58 |
| mzanetti | please give random app x access to all your docs | 08:59 |
| mivoligo | maybe rename it to .html ;) | 09:00 |
| mivoligo | mzanetti: now I broke the drive :D | 09:05 |
| mzanetti | still working here :D | 09:05 |
| mivoligo | mzanetti: right, it's back after refreshing | 09:05 |
| mzanetti | yesterday it didn't come back even after relogin for me | 09:06 |
| mivoligo | changing to html does not help too :D | 09:06 |
| mivoligo | mzanetti: anyway, I'm with the question regarding enemy destruction effect | 09:08 |
| mivoligo | mzanetti: can you use multiple images in the particles effect or should it be only one? | 09:09 |
| mzanetti | good question | 09:09 |
| mzanetti | I guess I can use multiple | 09:09 |
| mzanetti | but this was really only the first and only time I ever used the particleeffect | 09:09 |
| mzanetti | it looks it can do quite a lot of things | 09:10 |
| mzanetti | mivoligo: what do you mean with using multiple images? | 09:11 |
| mzanetti | mivoligo: a different one per enemey | 09:11 |
| mzanetti | or mixing multiple images into one explosion? | 09:11 |
| mivoligo | mzanetti: yes | 09:11 |
| mzanetti | hmm | 09:11 |
| mzanetti | which one? | 09:11 |
| mzanetti | :D | 09:11 |
| mzanetti | well, in any case, both should be possible | 09:12 |
| mzanetti | not sure how it behaves performance wise | 09:12 |
| mivoligo | :) multiple in one explosion some nuts, bolts, cogs | 09:12 |
| mzanetti | :D | 09:12 |
| mzanetti | yeah. I guess I can do that | 09:12 |
| mivoligo | mzanetti: I'm slow with writing :) | 09:13 |
| mivoligo | even more now with one of my finger out of play :) | 09:13 |
| mzanetti | did you hurt yourself? | 09:15 |
| mivoligo | mzanetti: yes | 09:15 |
| mzanetti | :( | 09:16 |
| mivoligo | no worries, I'll be fine :) | 09:16 |
| mzanetti | ok | 09:16 |
| mivoligo | mzanetti: had a chance to review the merge proposals? | 09:16 |
| mzanetti | mivoligo: no... I was lazy yesterday... needed a rest | 09:18 |
| mivoligo | mzanetti: no problem, you deserve it :) | 09:18 |
| mzanetti | lol. looking at my mailbox today morning, not sure if everyone agrees there | 09:19 |
| mivoligo | hehe | 09:20 |
| mzanetti | A friend of mine came back from holidays yesterday and I asked him to play the game. he got totally addicted | 09:21 |
| mivoligo | mzanetti: GOOD :d | 09:21 |
| EscabarPerreiro | hi | 09:21 |
| mivoligo | mzanetti: one more thing | 09:21 |
| mzanetti | hit me | 09:22 |
| mivoligo | mzanetti: I thought about the level background on the welcome screen and I think it's useless. I'd go with just an artwork specific for a levelpack | 09:23 |
| mzanetti | mivoligo: ok | 09:24 |
| mzanetti | mivoligo: in levelpack.json, there is already a entry, levelSelectorBackground | 09:24 |
| mzanetti | mivoligo: we can use that | 09:24 |
| mivoligo | mzanetti: is it that random enemy in the background? | 09:25 |
| mzanetti | well, yeah, initially I intended to use it as background behind the level selection. but then we switched over to show random enemies/towers | 09:26 |
| mzanetti | I never bothered to remove that property so it still exists (in the code too) | 09:26 |
| mivoligo | mzanetti: ah, ok, so we can use it | 09:26 |
| mivoligo | mzanetti: I'm planning to work on that today | 09:26 |
| mzanetti | awesome | 09:27 |
| mzanetti | mivoligo: just so that I can plan next steps a bit. what's the state with the next level backgrounds? | 09:27 |
| mivoligo | mzanetti: nothing ready yet | 09:27 |
| mzanetti | mivoligo: ok | 09:28 |
| mivoligo | mzanetti: I'd like to finish with the UI first | 09:28 |
| mzanetti | mivoligo: yeah, that's fine. | 09:28 |
| mivoligo | mzanetti: btw, have your friend finished the game? | 09:29 |
| mzanetti | mivoligo: so I've started over again with the levels, and noe changed it that in the first world we only use normal enemies, in the second world the -blue ones come in | 09:29 |
| mzanetti | mivoligo: then we have the red ones still, and orange/aubergine | 09:30 |
| mzanetti | mivoligo: so the idea would be that maybe the general theme of the next worlds might line up a bit with that | 09:30 |
| mivoligo | mzanetti: I guess I can do couple more diffrent kinds of enemies | 09:31 |
| mzanetti | mivoligo: like, the red ones come in in a "hot" world, with fire or whatever | 09:31 |
| mzanetti | mivoligo: just an idea, to think about while still busy with the general ui | 09:31 |
| mivoligo | ok | 09:31 |
| mzanetti | mivoligo: not sure yet if we need more... | 09:32 |
| mzanetti | mivoligo: maybe a -big variant to have sort of like a boss at the end of each world... | 09:32 |
| mzanetti | but that's all still a bit open | 09:33 |
| mivoligo | mzanetti: ok, good idea | 09:33 |
| mivoligo | mzanetti: afk for now, I'll ping you if I finish the welcome screen artwork | 09:34 |
| mzanetti | mivoligo: ok. see you later | 09:34 |
| mihir | nik90: rtm-proposed is latest right ? | 10:22 |
| nik90 | mihir: I think so..I mean I think utopic devel-proposed should be slightly ahead but not for long | 10:24 |
| nik90 | mihir: try "ubuntu-device-flash --list-channels" to see all available channels | 10:24 |
| mihir | nik90: okay. | 10:24 |
| DanChapman | mzanetti: hey for your bcc request, would you say the user email should be visible in the recipients lists when composing or just add it at submission time and save some screen space | 10:30 |
| mzanetti | DanChapman: other mail clients do show it usually | 10:30 |
| mzanetti | but yeah... the screen space saving might be an argument... | 10:31 |
| mzanetti | DanChapman: I'd be happy either way, as long as the outcome is that I have my own messages listed in the same mail thread | 10:32 |
| DanChapman | mzanetti: ok well i will make a note to just have it visible for the time being then and see if the space is needed. Thanks :-) | 10:36 |
| mzanetti | thank you :) | 10:37 |
| mihir | hey bfiller | 10:42 |
| mihir | sorry , balloons | 10:42 |
| === karni is now known as karni-afk | ||
| zsombi | nik90: I think I'm back to the same problem we were in the beginning, that the QtOrganizer request completion signals are emitted after the actual request is completed. | 11:00 |
| zsombi | nik90: like when I update an event, I get the waitForFinished() conplete and then I get the itemChanged() signal emitted... which is stupid, because the request completion should also report what got completed... | 11:01 |
| ahayzen | popey, ping | 11:09 |
| popey | ahayzen: pong | 11:10 |
| ahayzen | popey, whats the best way to ping jouni to reply to comments on the spec? | 11:10 |
| === karni-afk is now known as karni | ||
| ahayzen | popey, is he around on irc/hangouts? | 11:11 |
| ahayzen | popey, or is only around on email? | 11:11 |
| popey | hmm, he usually is around. | 11:11 |
| * popey pokes him | 11:12 | |
| popey | ahayzen: if he's not on irc then ping him a mail. i invited him to our daily stand-up too | 11:13 |
| ahayzen | popey, ok...whats his irc nick? | 11:14 |
| popey | jouni_ iirc | 11:14 |
| popey | he may be afk right now | 11:14 |
| ahayzen | popey, cool thanks | 11:14 |
| mihir_ | nik90, which is latest one ubuntu-touch/ubuntu-rtm/14.09-proposed-customized | 11:29 |
| mihir_ | ubuntu-touch/ubuntu-rtm/devel-proposed-customized | 11:29 |
| nik90 | ubuntu-touch/ubuntu-rtm/devel-proposed | 11:29 |
| nik90 | 'or just go with ubuntu-touch/ubuntu-rtm/14.09-proposed | 11:29 |
| nik90 | both are the same | 11:29 |
| mihir_ | nik90, okay thanks | 11:30 |
| * mihir_ create new emulator :D | 11:30 | |
| ahayzen | Hey, Is the 'correct' way to make the background colour of the app a solid colour to set the backgroundColor and headerColor to the same value in the MainView? | 11:59 |
| ahayzen | popey, should i poke francis about enabling jenkins or will he see the work item? | 12:05 |
| popey | I thought balloons had already. fginther .. were you aware of https://blueprints.launchpad.net/music-app/+spec/music-remix-2.0 ? (specifically the ones with your name on) ☻ | 12:06 |
| ahayzen | popey, ah cool if balloons already has :) ... just wanted to ensure it was on his radar | 12:06 |
| popey | yeah, +1 | 12:06 |
| zsombi | charles: sire, we have a problem... QtOrganizer EDS backend doesn't support tags :/ | 12:12 |
| zsombi | nik90: help understand https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1365876 | 12:33 |
| ubot5 | Ubuntu bug 1365876 in Ubuntu UI Toolkit "Hour value of new alarm always jitter during scrolling." [Undecided,New] | 12:33 |
| popey | ahayzen: jounih ^ | 12:39 |
| ahayzen | jounih, hey | 12:39 |
| jounih | heya | 12:47 |
| ahayzen | jounih, i was wondering if you could respond to my comments on slide 2 regarding the small toolbar, when you have a moment? | 12:48 |
| jounih | sure i’ll do it now | 12:49 |
| ahayzen | jounih, thanks :) | 12:49 |
| jounih | re: the media control icons, they are all in the icon theme | 12:49 |
| jounih | media-playlist- prefixed | 12:49 |
| jounih | svgs | 12:49 |
| jounih | you can call them with the icon SDK component | 12:49 |
| ahayzen | jounih, ok so media-playlist-{forward,previous,play,pause} ? | 12:49 |
| * ahayzen tries that | 12:50 | |
| jounih | media-playback-pause | 12:50 |
| jounih | media-playback-start-rtl | 12:50 |
| jounih | media-playback-start | 12:50 |
| jounih | media-playback-stop | 12:50 |
| jounih | media-playlist-repeat | 12:50 |
| jounih | media-playlist-shuffle | 12:50 |
| ahayzen | jounih, ah sweet at the moment we have svgs in a images directory so we can get rid of those :) | 12:51 |
| jounih | yep | 12:52 |
| jounih | you can colourise these icons with the icon component to any colour you want | 12:52 |
| renatu | dpm, hi | 12:53 |
| === rpadovani_ is now known as rpadovani | ||
| renatu | dpm, thanks for review my mr: https://code.launchpad.net/~renatofilho/mediaplayer-app/translators-comments/+merge/165260 | 12:53 |
| ahayzen | jounih, regarding the empty state have you seen what we do currently? i wonder if we should do something similar | 12:53 |
| renatu | dpm, I am not using launchpad to translate the app because it is ver unstable, I am getting timeout every time that I submit a change | 12:54 |
| renatu | dpm, after submit suggestions for the hole dialer-app and it did not get saved, the guy from brazilian translator team, told me to do the changes direct on the po file | 12:55 |
| jounih | ahayzen: empty state for what sorry? | 12:55 |
| ahayzen | jounih, for the toolbar let me take a screenshot... | 12:55 |
| zsombi | renatu: dude, we have a problem! QtOrganizer doesn't save the tags at all!! | 12:56 |
| jounih | ahayzen: ah you mean if you have nothing playing or queued? I think we should hide the play bar in that instance | 12:56 |
| zsombi | renatu: beside that, each request is completed before the change() signal woudl come! | 12:56 |
| renatu | zsombi, let me take a look | 12:56 |
| ahayzen | jounih, yeah ... this is what the toolbar looks like currently when nothing is the queue https://docs.google.com/file/d/0B3XynHVKfrvMNzFQaWltdTJJcGc | 12:57 |
| jounih | ahayzen: ah ok. yeah could be a nice thing to have | 12:58 |
| ahayzen | jounih, i wonder if we should have the new controls and then that text with no cover art or something? | 12:58 |
| renatu | zsombi, I can not grantee the signal order I send the change singal when I receive it from eds | 12:58 |
| dpm | renatu, yeah, unfortunately Launchpad has timeouts, and it's something that's being looked at, but it's not a trivial fix. I know it's a real pain :/. However, I've never heard about suggestions not being saved or data being lost - the timeouts happen after saving the translations. If it's a new bug, I'd suggest submitting it. In any case, my point was that if you choose to translate offline, you don't need to commit it, you can just upload a .po fi | 12:58 |
| dpm | le using the web UI. | 12:58 |
| zsombi | renatu: I've digged in with this bug https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1364949 | 12:59 |
| ubot5 | Ubuntu bug 1364949 in qtorganizer5-eds (Ubuntu) "Editing alarm sounds doesn't actually change them" [Undecided,New] | 12:59 |
| zsombi | renatu: but you shoudl not complete a request while teh signal from EDS is not received | 12:59 |
| renatu | zsombi, since this is a async operation the change signal can be fired late after the request finished | 12:59 |
| jounih | ahayzen: you probably only need the play button and the text prompting to hit play to shuffle for an empty state. Either that or hide the toolbar | 12:59 |
| ahayzen | jounih, ok | 13:00 |
| renatu | zsombi, I received ok from eds, then I return the results | 13:00 |
| zsombi | renatu: and that's teh problem, because I call fetch after the request ends, and meanwhile that is working I get teh update, and they get messed | 13:00 |
| zsombi | renatu: but ok might not mean that teh actual work got complete. It gets complete when the signal is received, then you complete the request... | 13:00 |
| renatu | zsombi, well ok means the change is complete but not that the signal was fired | 13:01 |
| ahayzen | jounih, ok and the other point do we want the progress bar? ... this is what it looks like currently (the orange thing) https://docs.google.com/file/d/0B3XynHVKfrvMUjVDSzVXN2lwd0E | 13:01 |
| ahayzen | jounih, oh just seen ur comment on the doc... is ^^ the sortof thing you were thinking? | 13:02 |
| renatu | zsombi, the problem is that I relaying on eds signals, I can not fire a signal by myself otherwise you will receive 2 signals | 13:02 |
| zsombi | renatu: the change is complete, but because O do not get teh update, I cannot refresh the alarm data, meaning I get the old data still. if I put a wait of 400 msecs (on my machine) then I get the data updated... | 13:02 |
| === rmescandon is now known as rmescandon-lunch | ||
| jounih | ahayzen: that works, can you make it blue and a bit thinner? | 13:03 |
| zsombi | renatu: you don't need to fire two signals, just catch the signal in the request and close the request when the signal is received | 13:03 |
| renatu | zsombi, I understand you problem, this change will be very complex | 13:03 |
| zsombi | renatu: like save, save ok, then connect o itemChanged() and when that comes, you complete teh request | 13:03 |
| ahayzen | jounih, yeah :) .. the same blue as on the now playing? (could you comment with the hex code of that in the doc?) | 13:04 |
| zsombi | renatu: I got it, but that's the way a request works... | 13:04 |
| renatu | zsombi, I will need make sure that this change is related with my request, and there is now easy way to do that | 13:04 |
| zsombi | renatu: beside that, tags :) | 13:04 |
| jounih | ahayzen: yeah same colour/height as this bar - https://www.dropbox.com/s/qcy0excb3rtympy/music_now_playing.jpg?dl=0 - will comment in the doc with hex | 13:04 |
| renatu | zsombi, I will check the tags right now | 13:04 |
| zsombi | renatu: how about connect the request-related signal to your request only when you know EDS is OK with that | 13:04 |
| ahayzen | jounih, thanks :) | 13:05 |
| ahayzen | jounih, and just to double check the blocks you see in some of those dropbox files roughly equate to 1GU ? | 13:05 |
| renatu | zsombi, sorry I did not understand what do you mean | 13:05 |
| jounih | ahayzen: can you please use UbuntuColors.blue | 13:05 |
| jounih | ahayzen: yeah the grid view blocks are 1GU each | 13:06 |
| ahayzen | jounih, yep :) | 13:06 |
| ahayzen | jounih, gimme a second i'll update all the things and rescreenshot :) | 13:08 |
| jounih | coolio | 13:09 |
| zsombi | renatu: so, you could have your own QOrganizerAbstractRequest derived one, where you have a slot which is connected to the EDS signal fired. in this slot you complete the request. | 13:13 |
| ahayzen | jounih, https://drive.google.com/file/d/0B3XynHVKfrvMMEVDUW5Sd291d1k | 13:13 |
| renatu | zsombi, but if for example , a sync operation is happening at the same time and it changes eds during my request, I will need make sure that this change came from my request and not a external one | 13:15 |
| renatu | or a different app | 13:15 |
| ahayzen | jounih, hmm i think things look a bit close together i'll check the margins are right... | 13:15 |
| renatu | zsombi, btw every time that you cann engine->saveItems its return the new items already | 13:17 |
| renatu | *call | 13:17 |
| zsombi | renatu: yeah... if you use the sync API... but I'm using teh async one | 13:18 |
| renatu | the request will contain the new items too | 13:18 |
| renatu | the request items will be updated to the new ones | 13:18 |
| renatu | zsombi, look the sync func implementation: http://paste.ubuntu.com/8465976/ | 13:19 |
| renatu | its uses the async implementation | 13:20 |
| jounih | ahayzen: thanks. I assume I’m just looking at the bottom play bar since the rest of the design is old? | 13:20 |
| zsombi | renatu: ok, and the fun is that itemChanged() comes after that waitForRequestFinished() and we use that signal in the models... | 13:20 |
| ahayzen | jounih, yep :) i'm only working on one component at a time | 13:20 |
| ahayzen | jounih, this is a bit closer https://drive.google.com/file/d/0B3XynHVKfrvMRV9CTi0yeDhBbUE | 13:20 |
| ahayzen | jounih, i think the margin between the cover art and labels is too big now though.. | 13:20 |
| renatu | zsombi, I do not see a problem with that, since the model will request the items only after the itemChanged is received | 13:21 |
| zsombi | renatu: because I don't want to refresh teh entire list view when one item changes | 13:21 |
| renatu | and at this point the items will be already updated | 13:21 |
| renatu | zsombi, but you have the ids of the items that changed | 13:21 |
| renatu | on the singal | 13:21 |
| zsombi | renatu: the problem is with the tests. I do only fetch teh changed data when teh itemChanged() comes. | 13:22 |
| ahayzen | jounih, is it 1.5 GU between the cover art and text on this image? https://www.dropbox.com/sh/hwpmf9i8f8axysd/AABy8dttpsKu7fxB01jKEAQra#lh:null-music_playbar_gridview.jpg | 13:22 |
| renatu | zsombi, on the tests you can use the intens on the request->items() | 13:23 |
| jounih | ahayzen: looks alright, i would increase the margin between the media controls more to make them easier to tap. What text size do you have atm? | 13:23 |
| ahayzen | jounih, whatever the default is...what should i set it to? | 13:23 |
| jounih | ahayzen: also please colorise the media control icons to white | 13:23 |
| zsombi | renatu: no, because the alarm API should NEVER use the backend's stuff to test :) | 13:23 |
| ahayzen | jounih, the second one i colorised them? https://docs.google.com/file/d/0B3XynHVKfrvMRV9CTi0yeDhBbUE | 13:23 |
| zsombi | renatu: it must always use the Alarm API to test the backend :) | 13:24 |
| renatu | zsombi, I am not saying to use backend specific stuff | 13:24 |
| zsombi | renatu: so, in order to get the changes I must use teh backend then | 13:24 |
| jounih | ahayzen: could you please use Small font size, and Regular font weight for the playbar text? | 13:24 |
| ahayzen | jounih, yep | 13:24 |
| jounih | ahayzen: artist name solid white, album name solid white, 40% opacity | 13:25 |
| jounih | sorry song name | 13:25 |
| jounih | thanks | 13:25 |
| ahayzen | jounih, cool | 13:25 |
| jounih | ahayzen: after that i think the playbar is good | 13:26 |
| ahayzen | jounih, i'll send u another screeny when done.. | 13:26 |
| jounih | ahayzen nice! thanks | 13:26 |
| ahayzen | jounih, no problem :) | 13:26 |
| renatu | zsombi, I created a unit test and looks like that the tags is getting saved correct | 13:27 |
| zsombi | renatu: then for some reason I do not get them using event.tags() | 13:27 |
| zsombi | renatu: I get some trash there | 13:27 |
| renatu | zsombi, let me share my test with you | 13:27 |
| ahayzen | jounih, https://docs.google.com/file/d/0B3XynHVKfrvMMGtOUE5pSDBYdGM | 13:28 |
| jounih | ahayzen: i think it’s good to go! the cover art is throwing me off a bit but i’m sure it’ll look good with most things :) | 13:29 |
| renatu | zsombi, https://code.launchpad.net/~renatofilho/qtorganizer5-eds/save-tags/+merge/236512 | 13:29 |
| jounih | ahayzen: maybe increase the distance between the media controls even more? so that people won’t tap two at once | 13:29 |
| ahayzen | jounih, cool :) yeah i'll try it at 3GU .. so the long term plan is to always have this bar shown right? | 13:30 |
| jounih | ahayzen: yes I think it would make sense it to have it persistent | 13:31 |
| zsombi | renatu: and this works... | 13:31 |
| ahayzen | jounih, ok and to confirm what was our stance on when there is nothing in the queue? | 13:31 |
| ahayzen | jounih, hidden or show the play button with some text? | 13:31 |
| renatu | zsombi, works, let me try something different | 13:31 |
| jounih | ahayzen: I like the text + play button idea | 13:32 |
| zsombi | renatu: try to set a QStringList | 13:32 |
| ahayzen | jounih, ok i'll do that now then :) | 13:32 |
| zsombi | renatu: it's weird, as I don't get that tag when the itenChanged() comes... | 13:35 |
| renatu | zsombi, let me try that | 13:35 |
| === karni is now known as karni-lunch | ||
| zsombi | renatu: I'll try to see whether teh tag is there when the save completes | 13:35 |
| ahayzen | jounih, thats at 3GU with some different cover art https://docs.google.com/file/d/0B3XynHVKfrvMQ0J0a2RxckNiYmc | 13:36 |
| jounih | ahayzen: nice, works for me :) | 13:36 |
| ahayzen | jounih, sweet :) thanks for the pointers ... i'll have a go at that empty state thing | 13:37 |
| jounih | is the cover art provider now getting high res album art? or should I hassle the unity guys again | 13:37 |
| jounih | thanks ahayzen, my pleasure | 13:37 |
| renatu | zsombi, I can confirm that the tags is broken when retrieving with a new Request | 13:37 |
| ahayzen | jounih, erm well it gets embedded art and then falls back to online... but i've requested (and is WIP) to get any cover art in the same directory such as Folder.jpg | 13:37 |
| zsombi | renatu: yep, I can also confirm that the alarm tag is there after teh save completes... | 13:38 |
| jounih | ahayzen: ok. What’s the online art resolution? | 13:38 |
| ahayzen | jounih, i'm not sure of the exact dimensions but we use the same as the scopes now | 13:38 |
| jounih | ahayzen: ok. does it look blurry/pixelated? | 13:38 |
| zsombi | renatu: maybe I skip that update, and simply fire update signal when save completes... | 13:38 |
| zsombi | renatu: then we hit two flies teh same time... | 13:39 |
| ahayzen | jounih, depends how big ur trying to make it aha ... i'll see if i can find the exact size | 13:39 |
| jounih | ahayzen: cool. yep as long as it’s high quality enough for our “now playing” view it’s good. thanks | 13:39 |
| ahayzen | jounih, 350x350 pixels it looks | 13:40 |
| jounih | ahayzen: ok should be good enough I guess | 13:40 |
| ahayzen | jounih, yeah should be enough for now | 13:40 |
| * ahayzen waits for super super high DPI screens | 13:41 | |
| jounih | :) | 13:41 |
| popey | well.. a friend got an oppo find 7 over the weekend, and I'm trying to convince him to port ubuntu to it... | 13:41 |
| popey | that's got a silly high res screen | 13:42 |
| ahayzen | jounih, what font size would you use for that empty state message? | 13:42 |
| jounih | ahayzen: try Medium or Large | 13:43 |
| ahayzen | popey, like we have 1080p displays on our phones..but a lot of laptops are 720p lol :/ | 13:43 |
| ahayzen | jounih, will do, will you be around if i ping one across in a bit? | 13:43 |
| jounih | ahayzen: sure | 13:43 |
| ahayzen | jounih, thanks :) | 13:43 |
| jounih | i can hang out on this channel if this is where the action is | 13:44 |
| ahayzen | jounih, that would be really useful if you could :) | 13:45 |
| renatu | zsombi, fixd | 13:47 |
| renatu | fixed | 13:47 |
| zsombi | nais :) | 13:47 |
| === rmescandon-lunch is now known as rmescandon | ||
| renatu | zsombi, pushed into the same branch | 13:49 |
| zsombi | renatu: looks pretty simple :D | 13:50 |
| renatu | zsombi, yes EDS does not use the same field type for categories as it uses for comments | 13:51 |
| renatu | zsombi, just changed that | 13:51 |
| renatu | zsombi, thanks for point me that | 13:52 |
| zsombi | renatu: thx for fixing it :) | 13:52 |
| ahayzen | jounih, https://drive.google.com/file/d/0B3XynHVKfrvMSm5aRzFJQzZPWlU ? | 13:53 |
| zsombi | renatu: so the only thing remaining is the delay between the request and the itemChanged() signal.... | 13:53 |
| zsombi | renatu: but perhaps I will not rely on that signal at all... | 13:53 |
| zsombi | renatu: as it is painful | 13:54 |
| zsombi | renatu: the only problem I see is to find the place a new event is inserted... | 13:54 |
| renatu | zsombi, thanks, I will keep the bug open until I have a good solution for that | 13:54 |
| jounih | ahayzen: can you give the text 2gu margin on the left. And I think we could say “Tap to shuffle music” and make the whole bar a touch area (leave the icon there too though) | 13:54 |
| ahayzen | jounih, ok agreed | 13:55 |
| renatu | zsombi, what do you mean? | 13:55 |
| zsombi | renatu: like when I add a new item, that is not reported as itemChanged() as it was no prev item with the same ID registered... so I have to deal differently with those | 13:56 |
| zsombi | renatu: if I do not rely on the itemChanged() anymore | 13:56 |
| zsombi | renatu: or I simply do sthing for testing purposes only.... | 13:56 |
| zsombi | renatu: that woudl be easier | 13:56 |
| ahayzen | jounih, like so https://drive.google.com/file/d/0B3XynHVKfrvMdzdRcVY0VFJkSzA | 13:57 |
| jounih | ahayzen: looks good to me | 13:58 |
| ahayzen | jounih, yey thanks :) | 13:58 |
| === _salem is now known as salem_ | ||
| zsombi | renatu: charles: still, the bug seems not to work, as if I change the sound, EDS reports as being changed, but the sound played by indicator-datetime seems to be the original one | 14:15 |
| zsombi | renatu: charles: talking about this bug https://bugs.launchpad.net/ubuntu/+source/qtorganizer5-eds/+bug/1364949 | 14:15 |
| ubot5 | Ubuntu bug 1364949 in qtorganizer5-eds (Ubuntu) "Editing alarm sounds doesn't actually change them" [Undecided,New] | 14:15 |
| * zsombi bbl | 14:18 | |
| === karni-lunch is now known as karni | ||
| dpm | popey, looks like folks are looking forward to another set of core apps hack days? https://plus.google.com/103255629963793469067/posts/UDPnD6jRdZN :-) | 14:40 |
| dpm | popey, perhaps we can reach out to Boren to help out with Music | 14:41 |
| popey | ooh | 14:41 |
| === gatox is now known as gatox_lunch | ||
| elopio | artmello_: thanks for your review. Can you please top-approve it? https://code.launchpad.net/~canonical-platform-qa/gallery-app/qmltests1/+merge/235390 | 15:33 |
| elopio | oh, I'm missing the checklist. One second... | 15:33 |
| elopio | now it's ready. | 15:37 |
| elopio | ping ogra_, the external drives application is yours, right? | 15:40 |
| ogra_ | elopio, sergiusens | 15:40 |
| sergiusens | elopio: what up? | 15:41 |
| elopio | sergiusens, or ogra_ you might know, what's the name of the project in launchpad? | 15:41 |
| sergiusens | elopio: ciborium | 15:41 |
| elopio | sergiusens: I'm going to change the translation of the app in spanish to unidades externas. | 15:41 |
| elopio | https://bugs.launchpad.net/ubuntu-translations/+bug/1353226 | 15:41 |
| ubot5 | Ubuntu bug 1353226 in Ubuntu Translations "[dash] On the dash the available space for app names is too small" [Medium,Triaged] | 15:41 |
| sergiusens | elopio: do as you wish ;-) I didn't do the translations :-P | 15:41 |
| sergiusens | elopio: I think it was vrruiz | 15:42 |
| === gatox_lunch is now known as gatox | ||
| ahayzen | jounih, what is the font size for the cards? is it small again? | 16:00 |
| jounih | ahayzen: yep, small | 16:00 |
| ahayzen | jounih, cool thanks | 16:01 |
| ahayzen | jounih, for the Albums tab are we expecting to use the cardview? | 16:01 |
| * ahayzen has been using that page to prototype | 16:01 | |
| jounih | ahayzen: I think we could use the cardview for everything for now. Maybe some of the views would work better as a listview but we can start off with cards for everything | 16:03 |
| jounih | what do you think? | 16:03 |
| ahayzen | jounih, my understanding was the 'start' page would be cardview... the albums would be cards.... the artists and songs tabs make sense to be a list i think...and the playlists is up for debate | 16:03 |
| jounih | ahayzen: playlists definitely cards - albums and playlists are very similar. OK to use listview for artists and songs - i’ll need to provide a design for that, i’ll do it now | 16:04 |
| ahayzen | jounih, yep agreed thanks :) | 16:05 |
| ahayzen | jounih, FYI our initial implementation is unlikely to have the differing heights...we are likely to investigate this further in if we have time etc | 16:06 |
| jounih | ahayzen: I think we really really want the organic cards.. should be pretty easy | 16:06 |
| ahayzen | jounih, heh maybe ... we're using GridView at the moment which i *think* only allows the same height... but i'll investigate this over the next few days | 16:07 |
| jounih | yeah we’ll need a new component for it. Maybe that’s something nekhelesh could work on, would be nice to use in other apps too | 16:07 |
| jounih | QML gridview won’t do it AFAIK | 16:07 |
| ahayzen | jounih, it is a special gridview hehe i'll post a screenshot in a sec | 16:08 |
| jounih | ok | 16:08 |
| ahayzen | jounih, this is basically what the WIP looks like at the moment (i'm trying to sort out the margins/label sizing etc) https://docs.google.com/file/d/0B3XynHVKfrvMSmlvRV80d3pCZ00/edit | 16:18 |
| nik90 | ahayzen: you need to use a QML FlowLayout. That should fix it | 16:18 |
| ahayzen | nik90, ooo any docs for that? ... | 16:19 |
| ahayzen | nik90, oh as in the Flow {} ? https://developer.ubuntu.com/api/qml/sdk-14.10/QtQuick.Flow/ | 16:19 |
| nik90 | http://qt-project.org/doc/qt-5/qml-qtquick-flow.html | 16:19 |
| nik90 | yeah | 16:19 |
| jounih | ahayzen: cool looking good! I can see one SDK thing we need to fix. The staggered grid instead of … would be really really good | 16:19 |
| ahayzen | nik90, interesting i'll see if i can port over my cardview ^^ that is using GridView to that | 16:20 |
| nik90 | ahayzen: cool. | 16:20 |
| ahayzen | jounih, what is the SDK thing? | 16:21 |
| jounih | ahayzen: the divider below the header.. the white bottom highlight on it is too bright. Will ask the SDK guys if we have access to that. What are you using as your base theme? SuruDark? | 16:21 |
| ahayzen | jounih, well i asked this earlier... | 16:22 |
| ahayzen | "Hey, Is the 'correct' way to make the background colour of the app a solid colour to set the backgroundColor and headerColor to the same value in the MainView?" | 16:22 |
| ahayzen | jounih, as we aren't sure if we are setting the bg correctly anyway? we just set the bg and header colour to the same value? | 16:22 |
| ahayzen | nik90, do you know ^^ ? | 16:23 |
| ahayzen | jounih, but if we are doing it correctly, like an SDK thing | 16:23 |
| jounih | ahayzen: i guess that works, i’m not sure what the correct way of doing it is, we can ask the SDK guys tomorrow | 16:23 |
| ahayzen | unless t1mp is still about? | 16:23 |
| nik90 | ahayzen: if you set the background color, it should be sufficient | 16:23 |
| jounih | it’s a small thing - the staggered grid view would have more impact | 16:23 |
| nik90 | ahayzen: only for gradients we used to set header, background and footer color | 16:23 |
| ahayzen | jounih, hehe yeah but we're still aiming for pixel perfect right ;) | 16:24 |
| ahayzen | nik90, ah right... hmm i thought i had to set the header colour otherwise it was like white though or something | 16:24 |
| jounih | yep. I think the divider bottom highlight is something that is exposed in the theming - we’ve talked about it before with the SDK guys. Let’s ask them tomorrow when they are around | 16:24 |
| ahayzen | jounih, cool :) | 16:25 |
| ahayzen | popey, meeting time? | 16:31 |
| popey | yeah, hangout? | 16:31 |
| popey | jounih: dpm ^? | 16:31 |
| ahayzen | popey, yeah let me migrate to my room.... | 16:31 |
| jounih | sure | 16:31 |
| jounih | give me 2 mins | 16:31 |
| popey | k | 16:32 |
| ahayzen | popey, i'm about now :) | 16:34 |
| popey | https://plus.google.com/hangouts/_/canonical.com/music-app-daily?authuser=1 | 16:34 |
| popey | should be in the calendar invite | 16:34 |
| dpm | popey, can't make it today, sorry | 16:34 |
| popey | ok | 16:34 |
| popey | np | 16:34 |
| ahayzen | arg why is it using my brookes google | 16:35 |
| * ahayzen shakes fist | 16:35 | |
| zsombi | nik90: this bug is invalid I guess, right? https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1268599 | 16:40 |
| ubot5 | Ubuntu bug 1268599 in Ubuntu UI Toolkit "Deleting Alarms does not update the alarm manager count" [Undecided,New] | 16:40 |
| popey | dpm: added task to bp for you to add remix to the sponsoring page.. | 16:40 |
| nik90 | zbenjamin: yeah | 16:41 |
| dpm | popey, ok, sounds good, will add tomorrow morning | 16:44 |
| seb128 | who is working on the calc application? | 16:52 |
| seb128 | wondering what is blocking https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1365564/+merge/233400 | 16:53 |
| seb128 | but I see somebody else commented on the mp today asking that as well | 16:53 |
| nik90 | zsombi: you are cleaning up all the old alarm bugs? | 16:58 |
| zsombi | nik90: all teh bugs, I decided to becoem a cleansweep now :D | 16:58 |
| nik90 | zsombi: lol..my inbox is getting spammed | 16:59 |
| popey | seb128: design, i asked for them to review it. | 16:59 |
| zsombi | nik90: sorry :D | 16:59 |
| nik90 | np | 17:00 |
| * nik90 packs to go home | 17:01 | |
| seb128 | popey, thanks | 17:01 |
| brendand | popey, hey do you have that bug about the video scope being broken? | 17:06 |
| popey | brendand: bug 1375349 was made | 17:07 |
| ubot5 | bug 1375349 in Unity Media Scanner Scope "Can't launch videos on mako utopic #261" [Critical,New] https://launchpad.net/bugs/1375349 | 17:07 |
| mihir_ | popey, why i am not seeing clock on fresh RTM image? | 17:16 |
| popey | oh really? | 17:17 |
| popey | ogra_: where is the rtm changelog page like your changelog? | 17:17 |
| ogra_ | mihir_, the last rtm image was a device tarball rebuild | 17:17 |
| ogra_ | rootfs is identical to the last one | 17:18 |
| ogra_ | popey, http://people.canonical.com/~ogra/touch-image-stats/rtm/ | 17:18 |
| mihir_ | ogra_, that means ? i didn't get that | 17:18 |
| mihir_ | ogra_, so you mean i should install them from store? | 17:18 |
| ogra_ | mihir_, that means there is no new software in the rootfs | 17:18 |
| ogra_ | only kernel and drivers got updated | 17:19 |
| popey | just updating my device... | 17:19 |
| ogra_ | (device tarball = android container, kernel and drivers) | 17:19 |
| mihir_ | popey, scrennie , http://i.imgur.com/5aaMAS3.png | 17:19 |
| ogra_ | (rootfs tarball = OS and software/apps) | 17:19 |
| mihir_ | ogra_, okay understood | 17:19 |
| ogra_ | you should see a new calendar in the updates from the store though | 17:20 |
| mihir_ | ogra_, yeah i can do that from store..but i couldn't even see Clock so was wondering what it is. | 17:20 |
| mihir_ | popey, out of the box , are you facing this issues with imgur and ubuntu screen caputre , the copy to clipboard doesn't work :| | 17:21 |
| popey | oh, thats the emulator.... | 17:21 |
| popey | i dont know why the emulator would be missing the clock - is that the x86 one? maybe we haven't got an x86 clock click? | 17:22 |
| * popey chuckles at "clock click" | 17:22 | |
| mihir_ | popey, yes it is x86 | 17:25 |
| mihir_ | popey, ahhh seriously .. | 17:26 |
| popey | could be, just a guess | 17:26 |
| * mihir_ get calendar from store | 17:26 | |
| mihir_ | popey, strange not able to find it from store | 17:28 |
| popey | you won't. the version in the store is armhf | 17:32 |
| mihir_ | popey, okay so i'll create emulator with i386 | 17:33 |
| popey | you mean armhf? | 17:33 |
| popey | or you could just branch the code and build an i386 click? | 17:33 |
| mihir_ | popey, will that work with x86 emulator ? | 17:35 |
| popey | x86 is i386 effectively, so yes. | 17:35 |
| === pat_ is now known as Guest93253 | ||
| mihir_ | popey, okay will , thanks for clarification. | 17:37 |
| mihir_ | popey, one quick question regarding event Reminder, would you like to have "No Reminder" and "On Event Start" then other reminder options or just "No Reminder" and other options ? | 17:45 |
| mihir_ | balloons, again is this related to wait time , http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/607/artifact/calendar_app.tests.test_new_event.NewEventTestCase.test_add_new_event_with_default_values.ogv ? | 17:52 |
| balloons | mihir_, looks like the app loaded and things started working | 17:53 |
| balloons | where is that from? | 17:53 |
| mihir_ | balloons, didn't get you :| | 17:53 |
| balloons | ahh https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/rewriteGetRecurrenceString/+merge/236013 | 17:53 |
| mihir_ | balloons, https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/rewriteGetRecurrenceString/+merge/236013 | 17:53 |
| vitimiti | hi | 17:54 |
| mihir_ | balloons, because in that MR there no change regarding newEvent stuffs | 17:58 |
| mihir_ | is* | 17:59 |
| balloons | mihir_, I re-triggered it | 18:04 |
| balloons | let's see what happens | 18:04 |
| mihir_ | balloons, thanks. | 18:05 |
| mihir_ | charles, pin | 18:05 |
| mihir_ | charles, ping* | 18:05 |
| mihir_ | balloons, got it , there was typo and i missed after saving it | 18:32 |
| balloons | mihir_, :-) | 18:32 |
| * mihir_ hates new keyboard :( | 18:32 | |
| sammo | I get stuck in a loop when trying to connect my device to qt creator. It detects it and then unmounts and disappears. | 18:36 |
| sammo | Does anyone have any ideas about that? | 18:36 |
| * ahoneybun ubuntu phone says "no sim" when there is one in there | 18:36 | |
| ahoneybun | now to reinstall ubuntu | 18:40 |
| ahoneybun | http://www.ign.com/articles/2014/09/30/microsoft-announces-windows-10?utm_campaign=fbposts&utm_source=facebook | 18:42 |
| * ahoneybun laughs are "Task View" | 18:42 | |
| ahoneybun | *at | 18:42 |
| mihir_ | anybody facing issues adding contacts in emulator ? | 18:50 |
| mihir_ | balloons, ping | 19:24 |
| balloons | mihir_, pong | 19:24 |
| mihir_ | balloons, we're missing these dependency on Jenkins machine : qtdeclarative5-qtcontacts-plugin | 19:25 |
| mihir_ | qtcontact5-galera | 19:25 |
| mihir_ | balloons, did anything got changed on machine? | 19:25 |
| balloons | mihir_, no nothing should have changed.. that sounds odd | 19:25 |
| mihir_ | balloons, wait let me re-check | 19:26 |
| balloons | packages might have changed, so those might not be pulled in automatically anymore | 19:26 |
| mihir_ | balloons, okay issue is something diff. | 19:31 |
| mihir_ | balloons, if you see last two Jenkins run of diff MR , Failure is same | 19:31 |
| mihir_ | balloons, http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/612/testReport/calendar_app.tests.test_new_event/NewEventTestCase/test_delete_event_must_remove_it_from_day_view/ | 19:32 |
| mihir_ | balloons, though tests passes on my machine | 19:33 |
| balloons | mihir_, you could change return self.select_single(NewEvent, objectName='newEventPage') to a wait_select and the same with DeleteConfirmationDialog, objectName='deleteConfirmationDialog') | 19:34 |
| balloons | if you feel like they are timing out that is | 19:35 |
| mihir_ | balloons, okay , let me try that but it fails on both MR so was wondering waiting is the only issue :| | 19:35 |
| balloons | mihir_, looking at the video I see the popup comes up just barely.. it's possible | 19:36 |
| balloons | there's animation there, I'm not sure it's being accounted for | 19:36 |
| mihir_ | balloons, you mean in DeleteConfirmation ? | 19:37 |
| balloons | mihir_, yea, just looking at the traceback you linked | 19:37 |
| balloons | File "/usr/lib/python3/dist-packages/calendar_app/__init__.py", line 658, in delete | 19:37 |
| mihir_ | balloons, okay it hasn't since long time | 19:37 |
| mihir_ | balloons, okay let me try then | 19:38 |
| mihir_ | balloons, added lets see , if it works , i'll push separate MR for this change. | 19:44 |
| mihir_ | balloons, that worked :D | 19:47 |
| balloons | mihir_, :-) | 19:49 |
| balloons | pesky pesky things | 19:49 |
| mihir_ | balloons, would you mind to review this MR ,https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/addingWaitTime/+merge/236598 ? | 19:56 |
| balloons | mihir_, I would add root.wait_select_single(DayView, objectName='dayViewPage') in as well in the delete method | 19:59 |
| balloons | hmm | 19:59 |
| balloons | mihir_, also, return root.select_single(NewEvent, objectName='newEventPage') to a wait | 20:00 |
| balloons | that's in edit ^^ | 20:00 |
| balloons | mihir, hey you did come back, heh. I thought maybe you had gone so I finished the mp | 20:18 |
| mihir | balloons, pushed the change | 20:23 |
| balloons | mihir, hey you did come back, heh. I thought maybe you had gone so I finished the mp | 20:24 |
| balloons | mihir, so I add all my tweaks and made a new mp | 20:24 |
| mihir | balloons, okay no issues i got disconnected | 20:25 |
| mihir | interent issues | 20:25 |
| balloons | mihir, yea.. no worries. But hopefully all those tweaks will stop the random failures | 20:25 |
| mihir | balloons, thanks a lot :) | 20:25 |
| renatu | hey nik90 are you around? | 20:28 |
| nik90 | renatu: hey, yeah | 20:28 |
| nik90 | renatu: just sent you an email :P | 20:28 |
| renatu | nik90, I got your email | 20:29 |
| renatu | nik90, about the number 2 | 20:29 |
| renatu | nik90, is working fine for me | 20:29 |
| renatu | nik90, which version are you using? | 20:29 |
| nik90 | renatu: I made a typo there..it doesn't work in the dialer app when I press the buttons (rtm devel-proposed mako) | 20:29 |
| renatu | nik90, about number 3, I agreed with the designers to not implement that, this will be very complex to do and they are happy with the current implementation | 20:30 |
| nik90 | renatu: ah okay. I can let my designer know about this. | 20:31 |
| renatu | nik90, to make it to disappear you need to get the focus back, just call item.forceActiveFocus() | 20:31 |
| mihir | balloons, is this because i pushed in older MR ? | 20:32 |
| nik90 | renatu: ok..so for the flickable that I use in the clock page, if the user scrolls (or flicks), I should do forceActiveFocus() to hide the bottom edge. Sounds simple enough. | 20:32 |
| nik90 | renatu: but I cannot debug why the bottom edge does not have the focus when openning the clock app. | 20:32 |
| nik90 | renatu: considering you call the forceActiveFocus() in the loader. | 20:32 |
| balloons | mihir, ? this is the autolanding: http://91.189.93.70:8080/job/ubuntu-calendar-app-autolanding/377/ it should land fine I think | 20:33 |
| renatu | nik90, yes this is trick, I do not know if there is a QML function to say who has the focus :D | 20:33 |
| nik90 | renatu: :) | 20:33 |
| nik90 | renatu: in the address book, did it just work? because it looks like we (clock and addressbook) use a flickable in the page with the bottom edge. | 20:34 |
| nik90 | renatu: so I would expect similar results | 20:34 |
| renatu | nik90, yes is working fine on address-book | 20:34 |
| renatu | nik90, I do not know if boiko did something different on dilaer-app | 20:35 |
| boiko | renatu: nik90: I don't need active focus on the bottom edge page in dialer-app | 20:36 |
| nik90 | boiko: but bug 1357945 says that the bottom edge hint in the dialer app should be visible at all times and be hidden when a user presses on the number buttons. | 20:37 |
| ubot5 | bug 1357945 in Ubuntu Clock App "[bottom edge] Current bottom edge hint timeout makes it difficult to read the bottom edge action" [High,In progress] https://launchpad.net/bugs/1357945 | 20:37 |
| nik90 | boiko: the last part doesn't work as expected though | 20:37 |
| renatu | nik90, yes we know that | 20:38 |
| nik90 | renatu: ah ok | 20:39 |
| renatu | Kaleo, do you know if is possible to debug the current focused item? We want to know which item has the focus | 20:39 |
| nik90 | renatu: I have managed to fix issue 2 in the clock app by calling forceActiveFocus() where needed. Issue 3 isn't valid due to the reasoning you mentioned above. | 20:40 |
| nik90 | renatu: so only issue left is the bottom edge hint not being shown when clock app is opened. | 20:40 |
| nik90 | yay | 20:40 |
| renatu | nik90, great , we just need to know which item is stealing the focus | 20:41 |
| nik90 | yes | 20:41 |
| renatu | nik90, btw the item could be in the alarm pages, since the page is loaded | 20:41 |
| * nik90 checks if alarm page has any input fields | 20:41 | |
| nik90 | renatu: in the alarms page, there is not input text fields...however I do show the checkbox in the case of multiselection view. | 20:42 |
| renatu | nik90, check if the check bottoms | 20:42 |
| nik90 | renatu: didn't follow...check bottoms? | 20:43 |
| renatu | nik90, check if the checkbox is receiving the focus | 20:43 |
| renatu | since they are visible | 20:43 |
| nik90 | ah | 20:43 |
| * nik90 checks | 20:43 | |
| renatu | nik90, there is the "settings" button on the main page | 20:44 |
| renatu | nik90, I am not sure about the "Add city button" | 20:44 |
| nik90 | renatu: both AddCityButton and Settings button are AbstractButtons | 20:45 |
| renatu | nik90, is the abstract button a FocusScope ?? | 20:45 |
| renatu | let me check the implementation | 20:45 |
| nik90 | it inherits ActionItem which in turn inherits StyledItem | 20:46 |
| renatu | nik90, try to add: onActiveFocusChanged: console.debug("Has focus:" + activeFocus) on both | 20:49 |
| renatu | nik90, :D | 20:49 |
| nik90 | renatu: ah...I tried onFocusChanged instead of onActiveFocusChanged | 20:49 |
| nik90 | renatu: no debug statements for the buttons. | 20:50 |
| nik90 | wait why were you happy? :P | 20:50 |
| renatu | nik90, I am not happy. yet | 20:51 |
| renatu | nik90, try with checkbox | 20:51 |
| nik90 | renatu: checkbox doesnt have it either | 20:52 |
| nik90 | when I press the checkbox, it says it has active focus. But when I go back to the main clock page, it looses active focus. | 20:53 |
| nik90 | and the bottom edge stays shown then. | 20:53 |
| renatu | nik90, the bottom edge page call forceActiveFocus when collapsed | 20:54 |
| mihir | balloons, again it needs some modifications, wait_single should be wait_select_single i believe | 20:54 |
| renatu | this will make the tab to appear | 20:54 |
| nik90 | ok | 20:54 |
| mihir | balloons, that's why it it failed again. | 20:54 |
| balloons | mihir, hehe.. yes indeed | 20:55 |
| mihir | balloons, sorry for bugging you for small tweaks hehe :) | 20:55 |
| renatu | nik90, ok, you will need to comment part of the code until you find who is stealing the focus | 20:55 |
| renatu | nik90, sorry I do not know how to help on that | 20:55 |
| balloons | mihir, pushed rev 488. Please approve it | 20:55 |
| nik90 | renatu: no worries, I will try to find out where the issue is | 20:55 |
| nik90 | renatu: thxn for your help | 20:56 |
| mihir | balloons, done :D | 20:56 |
| renatu | nik90, btw I have a new MR for bottom edge: https://code.launchpad.net/~renatofilho/address-book-app/fix-1375513/+merge/236522 | 20:57 |
| nik90 | renatu: Yeah I saw. I will integrate that as well. | 20:57 |
| mihir | renatu, you got a min ? | 20:58 |
| renatu | yes | 20:58 |
| mihir | renatu, need some info regarding this bug https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1372599 | 20:59 |
| ubot5 | Ubuntu bug 1372599 in Ubuntu Calendar App "Wrong time zone for calendar sync" [High,Confirmed] | 20:59 |
| mihir | renatu, i am not sure whether it should go to Sync Monitor or EDS. | 20:59 |
| renatu | mihir, well we do not have support for timezones on qtorganizer-eds yes, This is new in qt. (only after 4.3), and this will affect a lot of projects | 21:01 |
| renatu | mihir, If I add support now this will break the alarms | 21:01 |
| mihir | renatu, because it is really making calendar sync (useless) | 21:02 |
| mihir | renatu, what would you suggest on this ? | 21:02 |
| renatu | mihir, to implement that I will need to discuss with szombi and charles , and bill. This will consume some time and can break a lot of stuff | 21:03 |
| renatu | mihir, sorry I do not have a solution right now | 21:03 |
| mihir | renatu, okay | 21:03 |
| renatu | mihir, just add qtorganizer5-eds as effect project | 21:03 |
| mihir | renatu, yeah i have already did that. | 21:04 |
| mihir | renatu, can you confirm that bug in eds ? | 21:04 |
| renatu | mihir, I do not know why. but I can not do that | 21:06 |
| mihir | renatu, okay | 21:06 |
| mihir | renatu, no issues , i just updated bug with our chat, hope that's fine. | 21:07 |
| renatu | mihir, humm I did notice that. I post some comments too | 21:08 |
| renatu | mihir, btw the timezones supports appear on qt 5.3 not 4.3 :D | 21:08 |
| renatu | my mistake | 21:08 |
| mihir | renatu, okay thanks :) hope that's fine :) | 21:09 |
| renatu | mihir, I will talk with bfiller about, I hope we can find some time to implement that | 21:10 |
| mihir | renatu, yes that would be great , otherwise the syncing with calendar doesn't make any sense as it'll be use less for users | 21:11 |
| mihir | nik90, finally able to run application on device :) :D | 21:12 |
| nik90 | mihir: yay! It is critical you keep it that way | 21:13 |
| nik90 | mihir: hard to digest that you have been able to only test on desktop for a phone app | 21:13 |
| mihir | nik90, yeah that's why there were back and forth reviews on MR | 21:14 |
| mihir | nik90, thanks to you for help. | 21:14 |
| nik90 | mihir: I didnt help much with your emulator issues | 21:15 |
| bfiller | renatu, mihir: yes this is a dupe of bug that was reported many months ago | 21:15 |
| mihir | nik90, but even for UI how does that looks on device , that was more helpful too :) | 21:15 |
| bfiller | I agree, google sync is quite limited by that issue | 21:15 |
| mihir | bfiller, hmm yup | 21:17 |
| mihir | bfiller, but is very critical for calendar. | 21:17 |
| bfiller | renatu: seems that is should be possible, pulling the events from google does the correct thing with the time. It's only events that you edit or create in the Calendar. Should be just converting the local time back to UTC before syncing | 21:17 |
| bfiller | mihir: not arguing that | 21:18 |
| mihir | bfiller, yeah i understand that. | 21:19 |
| nik90 | renatu: strange, I competely commented out everything in the clock page and the alarm page. https://imgur.com/G6VL59F .. and still the bottom edge doesn't get active focus. | 21:20 |
| * nik90 digs deeper | 21:20 | |
| mihir | nik90, when you get a couple of mins, could you please review this https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/RemoveGuest/ | 21:24 |
| mihir | nik90, i have made it working and it should work now :) | 21:24 |
| nik90 | mihir: sure | 21:25 |
| mihir | nik90, thanks :) | 21:25 |
| nik90 | renatu: On debugging, it seems if I use a timer and set the tip to focus to be set after 1 sec, it works :P | 21:25 |
| renatu | nik90, yes because some other item is getting the focus :D | 21:26 |
| nik90 | renatu: but I commented out everything in the clock page and alarm page. | 21:26 |
| nik90 | renatu: the only thing that was seen was the header title :) | 21:26 |
| nik90 | https://imgur.com/G6VL59F | 21:26 |
| nik90 | renatu: I didnt even leave a flickable behind :) | 21:27 |
| renatu | strange | 21:27 |
| renatu | let me finish that bug I am working on, than I will try debug the clock app with you | 21:27 |
| nik90 | renatu: I will be sleeping soon. But I created a sample project with just the bottom edge component at lp:~nik90/+junk/bottomedgefocus. I tried with both our implementations, but still the bottom edge doesn't show up on startup. | 22:10 |
| renatu | nik90, nice | 22:10 |
| nik90 | renatu: it could very well be that I am using the bottom edge component incorrectly | 22:10 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
