| alan_g | alf__: anpok I trust there's no objection to TAing https://code.launchpad.net/~alan-griffiths/mir/use-compare_exchange_weak-correctly/+merge/236557? | 10:47 |
|---|---|---|
| alf__ | alan_g: let me take a quick look | 10:48 |
| alan_g | alf__: sure, np | 10:53 |
| alf__ | alan_g: ok, TAed | 11:01 |
| alan_g | alf__: thanks | 11:02 |
| anpok | alan_g: no objections oh that was too late | 11:22 |
| alan_g | anpok: 8) | 11:22 |
| === alan_g is now known as alan_g|lunch | ||
| === dandrader is now known as dandrader|afk | ||
| kdub_ | it was a long while ago that this written, but I'm wondering why the mir.protobuf.Buffer.fds_on_side_channel (and similar) is not in the wire protocol | 12:13 |
| kdub_ | seems like the wire protocol should be the raw bytes and fds, and then it gets further parsed into the mir_protobuf.proto concepts | 12:14 |
| === dandrader|afk is now known as dandrader | ||
| === alan_g|lunch is now known as alan_g | ||
| alan_g | kdub_: It is probably that the fd passing depends on the message type - and that's just raw data in the wire protocol. | 12:48 |
| alan_g | And then the fd passing got added to one message after another. | 12:49 |
| alan_g | What you suggesting could well make sense. (Any problems will only become apparent from trying to do it.) | 12:51 |
| kdub_ | we can determine that an invocation needs to get fds from the side channel based on the message type, i'm grappling with how we can tell how many fds we need to collect before dispatching the method | 12:51 |
| kdub_ | I have a smallish MP i'll propose and see what people think about it I suppose | 12:51 |
| kdub_ | (its been a while since I considered the wire protocol), but its also strange that our events get jammed in the rpc response message type too | 12:52 |
| alan_g | that comes from thoughts about batching messages that were never fully realized | 12:53 |
| kdub_ | ah, okay. that satisfies my curiosity about it | 12:53 |
| alan_g | It will all go away when RAOF re-implements it using Wayland | 12:54 |
| kdub_ | :) sounds good to me | 12:55 |
| === chihchun is now known as chihchun_afk | ||
| robotfuel | kgunn: ping, I noticed this https://bugs.launchpad.net/ubuntu/+source/unity-system-compositor/+bug/1376324 crash on errors.u.c (has not happened during long running tests) can you triage it for me? | 15:54 |
| ubot5 | Ubuntu bug 1376324 in unity-system-compositor (Ubuntu) "/usr/sbin/unity-system-compositor:*** Error in `unity-system-compositor': free(): invalid pointer: ADDR ***" [Undecided,New] | 15:54 |
| kgunn | camako: can you pick a voluteer for that one ^ | 15:59 |
| kgunn | looks like it'd be childs play | 15:59 |
| camako | kgunn, ack | 15:59 |
| === mpt_ is now known as mpt | ||
| === chihchunl is now known as chihchun | ||
| === dandrader is now known as dandrader|lunch | ||
| === dandrader|lunch is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!