| elopio | veebers: https://code.launchpad.net/~elopio/autopilot/fix1257059-log_move/+merge/197438 | 00:22 |
|---|---|---|
| * veebers looks | 00:23 | |
| elopio | my tests are passing. I don't know why the others are failing. Any idea? | 00:23 |
| veebers | elopio: hmm, which test? there is a test that started failing all of a sudden recently | 00:24 |
| elopio | veebers: autopilot.tests.functional.test_ap_apps.QtTests.test_can_launch_upstart_app | 00:24 |
| veebers | elopio: hmm just saw that in the log. No idea sorry, looks like the app failed to launch? Shame there is no useful log there, seems like an issue | 00:25 |
| elopio | veebers: yes, failed to start. But well, when you are free you can take a look at the tests I added and tell me if that's what you expected. | 00:27 |
| veebers | elopio: line 63 would be better as super().__init__(*args, **kwargs) | 00:29 |
| veebers | elopio: or would you prefer comments in the MP | 00:30 |
| elopio | veebers: it's the same to me. | 00:30 |
| elopio | veebers: do I have to make it compatible with python 2 ? | 00:31 |
| elopio | or just calling super() is ok? | 00:31 |
| veebers | elopio: no, python3 all the way :-) | 00:31 |
| elopio | :D | 00:32 |
| elopio | updated. | 00:33 |
| veebers | elopio: sweet cheers. Looks good with a cursory look. Will give a detailed review later on, just trying to clear my plate a little | 00:35 |
| elopio | veebers: ok, thanks. | 00:36 |
| elopio | veebers: hum, something goes crazy when I call supper instead of logging.Handler. | 00:57 |
| elopio | maybe it was there for a reason. I'll investigate further a little later. | 00:57 |
| veebers | elopio: ok, perhaps I missed something and made a bad recommendation | 00:57 |
| elopio | oh, I know. Stupid | 00:57 |
| elopio | I don't need the self parameter now. | 00:57 |
| veebers | elopio: ah right, yeah :-) | 00:58 |
| === barry` is now known as barry | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!