=== mpt_ is now known as mpt [07:38] Saviq: that is very scary [07:38] tsdgeos, the image corruption? [07:38] yep [07:38] yeah it is [07:38] there were all kinds of issues with the image over thu/fri [07:39] but just confirmed it's not a file corruption [07:39] like reinstalling unity8 from .deb doesn't help [07:42] tsdgeos, to add to the weirdness, we weren't even touching the areas that broke [07:42] yeah, it's QML compilation [07:42] ? [07:42] tsdgeos, removing the cached precompiled files fixes the issues [07:43] doh [07:43] what could go wrong with caching :D [08:49] larsu: good morning. Can you take a quick look @ https://code.launchpad.net/~nick-dedekind/qmenumodel/lp1378941-disconnect-signals/+merge/238013, and top approve if you agree? [08:51] dednick: sure [08:54] dednick: approved. How does qmenumodel land? Do I need to merge manuallY? [08:54] larsu: not sure. havent done much in it in quite some time [08:54] larsu: i think it's manual. [08:59] dednick: hm, I'll wait a bit and merge if it doesn't happen automatically [08:59] thanks for the patch [08:59] larsu, dednick: that likely go through ci landing [09:00] larsu, dednick: I can put a landing up if you want [09:02] seb128: yes please, thanks [09:02] yw! [09:02] one day I'll learn how all of this is set up [09:10] larsu, they documented it recently on https://wiki.ubuntu.com/citrain/LandingProcess [09:10] larsu, I didn't read it, but maybe have a look [09:10] ah thanks, I will [09:31] dednick: did you see the bugs about the time format in i-messages? I thought those where mine at first, but you added the relative time formatter, right? [09:31] dednick: bug #1372061 and bug #1378821 [09:31] bug 1372061 in Ubuntu Translations "SMS notification: time format not translatable" [Low,Triaged] https://launchpad.net/bugs/1372061 [09:31] bug 1378821 in indicator-messages (Ubuntu) "today/yesterday label on sms and calls is incorrect" [High,New] https://launchpad.net/bugs/1378821 [09:33] larsu: hm. yes. you send the numerical time i think. [09:34] dednick: it's definitely not the service's fault, it doesn't care about timezones or relative times at al [09:34] *all [09:34] dednick: I mean time formatting in plugins/Util/relativetimeformatter.cpp [09:34] larsu: sure. it's my fault. i pulled the code from indicator-datetime. [09:35] probably doing something wrong with tz. [09:35] dednick: do you have time to fix it or should I take a look? (probably not that hard) [09:35] I wonder if the time has come to merge those classes and put them into the SDK [09:35] Saviq reminded me of that the other day [09:36] larsu: ya. been meaning to do that for awhile.. [09:37] dednick: hm, they mix strftime and qt-style time formats ... [09:37] I guess the sdk will want qt-style, but then we'll have to re-translate all those strings [09:39] larsu: ya. i just used strtime in unity8 to keep it somewhat maintainable from indicator-datetime. but i needed to make some changes anyway, so it's probably time to change to qt. [09:40] larsu: and should be exporting raw time from indicator-datetime as well. [09:40] not formatted. [09:41] ya, of course [09:41] we should have one place to format time and it should be as close to the ui as possible [09:44] dednick: is now the time to do this or should we wait until after rtm? [09:44] larsu, dednick, building in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-008 if you want to test the deb later on [09:50] seb128: thanks [11:02] seb128, hey, have you any idea why the language selection list scrolls so slow? [11:03] it looks like delegate creation is awfully heavy [11:12] greyback: ping === MacSlow is now known as MacSlow|lunch [11:16] mzanetti, was testing launcher-update-on-dconf-change last Friday using the "reset launcher" button in the settings app. it din't work with or without this patch. :-/ [11:16] mzanetti, will try with https://code.launchpad.net/~mzanetti/ubuntu-system-settings/drop-reboot-label-in-launcher-reset/+merge/236876 now [11:17] dandrader: define "didn't work" [11:18] mzanetti, the launcher contents do not change, even after a reboot [11:18] dandrader: that system settings patch only drops the label... [11:18] dandrader: you need another one in systemsettings, let me find it === shiznix_ is now known as shiznix [11:18] mzanetti, I unpinned everything and pinned just "dropping letters" [11:18] dandrader: https://code.launchpad.net/~mzanetti/ubuntu-system-settings/update-reset-launcher/+merge/234309 [11:19] dandrader: otherwise systemsettings still resets AccountsService [11:19] * mzanetti wonders why this isn't merged yet [11:19] seb128: hey, is there a reason why this isn't merged yet? https://code.launchpad.net/~mzanetti/ubuntu-system-settings/update-reset-launcher/+merge/234309 [11:19] mzanetti, ok will add drop-reboot-label-in-launcher-reset and update-reset-launcher [11:20] mzanetti: pong [11:21] greyback: hey. question: if I kill an app from cmdline. what's supposed to happen? [11:21] mzanetti: did you start that app from command line too? [11:21] greyback: no [11:21] greyback: it seems I'm intentionally not getting the applicationRemoved() because appman assumes it got lifecycled [11:22] greyback: however, the ApplicationInfo entry goes away [11:22] mzanetti: if app in foreground, app is considered to have crashed so should be removed from app list. If in background, assumed OOM struck, so kept in app list [11:22] greyback: ah ok, its the focused one [11:22] greyback: so we have a bug that if the foreground app crashes, the dash is not woken up from suspend [11:23] ah, drop-reboot-label-in-launcher-reset already brings update-reset-launcher [11:23] dandrader: yeah, one is a prereq of the other [11:23] mzanetti: I think if foreground app crashes, focusApplication is set to nullptr in qtmir [11:23] mzanetti: as that used to be the dash [11:23] dandrader: technically you only need the prereq as the other really just drops the label that says "you need to reboot" [11:23] ah ok [11:24] mzanetti: so need to change that to focus dash I guess [11:24] greyback: that helps, will try to fix. might come back though if failing [11:24] mzanetti: sure [11:26] mzanetti, I didn't look at the diffs at all :) [11:42] Saviq: dednick: besides the two minor comments i made sharedunitymenumodel looks good to me [11:43] let's wait for the CI run and approve it [11:43] tsdgeos: cool. just uploaded fixes for those. [11:48] cool [11:49] Saviq: i've uploaded latest changes to panel design branch as well. back in MP. [11:49] dednick, thanks [11:49] dednick: is that ready for review too? [11:49] tsdgeos: yup [11:50] ok, so shall i get into that one next? [11:50] Saviq: ↑? [11:50] tsdgeos: Cimi has been doing it, but could use some more eyes [11:50] tsdgeos, yes have a look [11:50] tsdgeos, yeah, go for it [11:50] tsdgeos, I will re'-review after lunch [11:50] but is tricky [11:51] ok [11:51] i [11:51] i'm off for lunch too [11:52] dednick, testing silo 10 now... http://people.canonical.com/~platform/citrain_dashboard/#?distro=ubuntu&q=landing-010 [11:53] dednick, panel icons seem to get stale straight away [11:54] Saviq: stale? [11:54] dednick, the icons don't change at all, display the first icons that were displayed [11:54] Saviq: hm. will take a look. [11:54] dednick, any from the MRs seem relevant? [11:55] dednick, also, datetime indicator empty [11:55] * Saviq reflashes to pristine [11:55] Saviq: not from the list... [11:55] dednick, yeah didn't think so [11:56] Saviq: mterrys greeter shizzle isn't there is it? [11:56] dednick, no [11:56] mzanetti, not that I know [11:56] seb128: seems its just that it was stuck in "Needs Review" and considere being finished [11:57] ...and *not* considered finshed [11:58] mzanetti, well, I was waiting on the unity8 side to land, did that happen? [11:59] seb128: yeah, long ago [11:59] mzanetti, ok, I'm putting it in the next landing then [11:59] seb128: there's multiple parts though. the fact that the launcher swiched to dconf landed a while back already [11:59] jgdx, ^ the reset launcher changeset was ok, right? seems like you looked at it by didn't top approve [11:59] seb128: the dynamic updating without reboot is not landed yet [11:59] oh [12:00] when is that landing? [12:00] seb128, t'was [12:00] seb128: hopefully soon, the code is reviewed and looks good. dandrader is doing a last test run now, so it will go into the next unity silo [12:01] k [12:04] mzanetti, after i do "reset launcher", should I get an empty launcher (ie, with nothing pinned)? [12:05] dandrader: no, you should get the default list [12:05] mzanetti, I got an empty launcher [12:05] hmm, that's not good [12:06] dandrader: where are you trying this? [12:06] mzanetti, hmm, I pinned contacts [12:06] dandrader: on the desktop? [12:06] mzanetti, and it stayed after the reset [12:06] hm, ok. something wrong then [12:06] dednick, yeah, something breaks the indicators in that silo :| [12:06] mzanetti, but dropping letters went away [12:06] mzanetti, as it's not in the default list, I suppose [12:06] Saviq: ok, i'm taking a look now. just finished flashing [12:06] mzanetti, testing on the device [12:07] dednick, thanks [12:07] dandrader: this is the default list: http://paste.ubuntu.com/8552071/ [12:08] dednick, ah crap [12:08] Saviq: did you update just the packages in silo, or do upgrade? [12:08] dednick, my fault [12:08] dednick, I resubmitted the test fix to include greeter profiles indeed [12:08] dednick, let me undo that [12:09] mzanetti, tried again: had dropping letters and phone pinned. then did the reset. had a launcher with just phone pinned [12:09] ah. hm, didnt see that on list [12:10] dandrader: what does "gsettings get com.canonical.Unity.Launcher items" tell you? [12:10] dednick, yeah, because I resubmitted, but didn't *add* the actual MR [12:10] Saviq: ok. [12:11] dednick, meaning my branch included the other [12:11] dednick, so as you were, sorry for the noise [12:11] Saviq: no prob. guess that means the greeter branch is buggy though... [12:11] dednick, well, the indicators updates weren't in the silo though, maybe that's why? [12:11] mzanetti, ['appid://dialer-app'] [12:12] :/ [12:12] i'll try the greeter silo again [12:12] dandrader: err... that's weird... seems your reset call doesn't work then [12:12] mzanetti, which is indeed what I see pinned in the launcher [12:12] dandrader: try "gsettings reset com.canonical.Unity.Launcher items" [12:12] mzanetti, I added a comment in the MP with what it seems to be happening [12:12] dandrader, mzanetti, that branch's in silo 10, was just about to test thes [12:12] this [12:13] mzanetti, at least my guess about it [12:14] ok, need to figure what's happening... dandrader, doesn't it work even if you use gsettings command line to reset it? [12:15] mzanetti, what's that command line? I don't know it [12:15] mzanetti, seems to work fine here [12:15] dandrader, what did you use? dconf? [12:16] dandrader: try "gsettings reset com.canonical.Unity.Launcher items" [12:16] Saviq, the "reset launcher" button un ubuntu-system-settings [12:16] * Saviq tries [12:16] Saviq, under the "reset phone" option [12:16] Saviq: note, the settings button isn't updated yet [12:16] mzanetti, yeah, I see that [12:16] Saviq: unless you pull in that branchhttps://code.launchpad.net/~mzanetti/ubuntu-system-settings/update-reset-launcher [12:16] since it requires a restart [12:17] mzanetti, yeah, it works with the command line! [12:17] Saviq: not even that... still resets AS [12:17] mzanetti, yeah, that too [12:17] hmm... that's even weirder then [12:17] as systemsettings calls QGSettings::reset() [12:17] mzanetti, sounds like gsettings-qt bug? [12:18] not ruling it out, although I would have said "unlikely" [12:18] but if gsettings reset works [12:18] mzanetti, actually it does not really. if I had only phone pinned it worked [12:18] aha [12:18] mzanetti, but them I unpinned everything and pinned only dropping letters [12:18] mzanetti, then the command leaves the launcher empty [12:18] hmm... crap... I think I know what it is [12:19] Saviq: sorry then... I guess you can drop it from the silo [12:19] I'll fix it today [12:19] depends on when you want to release [12:19] ok, dropping === MacSlow|lunch is now known as MacSlow [12:23] Saviq: hm. greeter profiles silo doesnt work at all for me now... u8 cycles on startup. [12:23] dednick, I don't think it's built proper [12:23] dednick, I was waiting for silo 10 to land, can kick unity8 build if you want though [12:24] Saviq: meh. it can wait [12:37] Cimi, started reviewing https://code.launchpad.net/~cimi/unity8/fix-1378920/+merge/238012 [12:38] Cimi, when I press the volume buttons (with stock image) I don't hear anything [12:38] Cimi, is that expected? [12:38] dandrader, that's not landed yet [12:39] dandrader, https://code.launchpad.net/~macslow/unity8/synchronous-notification/+merge/229059 [12:39] I also cannot reproduce bug 1378920 [12:39] bug 1378920 in unity8 (Ubuntu) "Synchronous sound notifications pause video" [High,In progress] https://launchpad.net/bugs/1378920 [12:39] using krillin r81 [12:41] dandrader, yeah, because that was reverted [12:42] dandrader, there's http://bazaar.launchpad.net/~unity-api-team/unity-notifications/trunk/view/head:/examples/sound.py you could use to trigger a notification with sound [12:43] mzanetti, can you please resubmit quicklist on top of touch ownership please === davidcalle_ is now known as davidcalle [12:43] please [12:43] dandrader, that would be enough to reproduce the video-playback-pause === dandrader is now known as dandrader|afk [12:46] Saviq: one "please" would have been enough :) [12:46] mzanetti, please :P [12:49] Saviq: https://code.launchpad.net/~mzanetti/unity8/rework-quicklist-visuals/+merge/238149 [12:49] mzanetti, tx [12:52] Saviq: it's interesting that bzr thinks line 98/99 would be my change === _salem is now known as salem_ [13:10] mzanetti, had to pull your MP from the silo after all, it conflicted elsewhere this time (stupid bzr) [13:10] /food [13:11] * mzanetti grumbles [13:15] dednick: https://code.launchpad.net/~nick-dedekind/unity8/expanded-panel-design/+merge/237031/comments/584355 === dandrader|afk is now known as dandrader [13:23] hmm, got media-hub-service eating "392%" of the phone's CPU after playing a video. [13:24] jhodapp, ↑ [13:24] dandrader, Saviq: yeah that's a logged bug already [13:25] jhodapp, good to know! [13:25] will be looking at that in the next several days [13:54] dednick: there? [13:57] tsdgeos: do you also know why testShell now disappears? [14:01] mzanetti: what do you mean disappears? [14:02] tsdgeos: I figured it... same as in testShellWithPing happened [14:02] it got changed to have a Row {} as main item [14:02] wich makes it go to 0,0 size at some point during the test run [14:05] mzanetti, fixed in my branch === boiko__ is now known as boiko [14:11] Cimi: do you know if this is by design? https://code.launchpad.net/~nick-dedekind/unity8/expanded-panel-design/+merge/237031/comments/584390 [14:13] tsdgeos, the panel? [14:13] tsdgeos, yes, approved [14:13] tsdgeos, there might be bugs in the UX, but nick is on track... [14:14] tsdgeos, he went last week to the office and reviewed with vesa, there were things to tweak, so he might be addressing them === artmello_ is now known as artmello [14:18] greyback: have time for a focus related review? https://code.launchpad.net/~mzanetti/unity8/refocus-dash-on-app-crash/+merge/238166 [14:19] mzanetti: sure [14:19] mzanetti: "interctive" - typo [14:20] greyback: where? [14:20] wah [14:20] how come it still works? [14:20] mzanetti: you decided against patching qtmir to not set the focused app to null - that was my first thought. Ok will test in a while [14:21] greyback: yeah, qtmir has a comment there: "The app disappeard. Let unity decide what to do wit it" [14:21] greyback: given that its our long term plan anyways, I decided to do that [14:21] mzanetti: gotcha [14:22] dednick: Cimi: i'm also concenrned about the high number of timers we seem to have in there [14:22] why so many? [14:26] tsdgeos, this is probably something left from the prototype [14:52] tsdgeos: Cimi: not from the prototype. the scroll timer is used for scrolling (holding mouse on area emits scrolls ever x ms). velocity timer is used to determine when velocity decreases below a threashold. alignment timer is used for a delay. [14:55] mzanetti, should https://code.launchpad.net/~mzanetti/unity8/fix_snap_decision_test/+merge/238015 get in or not? its description says "This proposal has been superseded by a proposal from 2014-10-10. " [14:56] dandrader: I just reactivated it, still need to fill in the checklist though [15:06] tsdgeos, for your dash bottom edge branch, make the bottom tab thingy catch taps please [15:06] Saviq: hey, on that branch, testwhitespace fails, but doesn't tell me where and I can't find any :/ [15:06] seen that before? [15:06] https://code.launchpad.net/~mzanetti/unity8/fix_snap_decision_test/+merge/238015 [15:06] death to the whitespace test! [15:07] checkin' [15:09] dednick, the steps from https://code.launchpad.net/~nick-dedekind/unity8/lp1336715-checkable-bindings/+merge/234503/comments/582588 still fail for me? [15:09] Saviq: hmm... I deleted everything from the file, saved it, pasted everything back saved it again [15:09] working now [15:10] maybe Josh edited the file with windows :D [15:10] mzanetti, [15:10] /home/michal/dev/canonical/unity8/repo/tests/qmltests/tst_Shell.qml: bad whitespace in multiple lines [15:10] yeah [15:10] Saviq: hm. i've been meaning to test that case. [15:10] I know its's tst_Shell [15:11] but in there, also LP diff doesn't show any changes that would contain whitespaces [15:11] mzanetti, yeah, can't see where either [15:11] Saviq: give me a minute. will try [15:12] dednick, so yeah, the kick is that they're now cross-synced [15:12] dednick, meaning that if I enable in settings, it gets disabled in indicators [15:12] wtf [15:13] dednick, basically it's a toggle [15:13] dednick: did you say you'll take care of the time bugs or do you want me to take another look? [15:13] dednick, settings sends toggle, indicator switches without checking for the real value, but maybe it's actually settings' fault [15:13] larsu: if you've got time (har har), otherwise i will try get to them later. [15:14] dednick: haha okay. I'll reassign to you for now [15:14] Saviq: it should se to the server check value rather than just switching [15:14] dednick, or that [15:15] Saviq: i'll have to check which frontend is wrong first. [15:15] dednick, k, I'm landing the silo anyway [15:15] as it's not getting worse [15:15] Saviq: ok [15:16] larsu: thanks. [15:16] greyback: hey, you reviewed this already, I just added the test now, mind reapproving? https://code.launchpad.net/~mzanetti/unity8/fix_snap_decision_test/+merge/238015 [15:17] mzanetti: sure. [15:19] Saviq: sorry was looking at the phone, what do you mean with " make the bottom tab thingy catch taps please" ? [15:20] tsdgeos, with touchOwnership I can tap through the bottom hint [15:20] the hint itself should be tappable I think [15:20] Saviq: why? [15:21] it's never been like that [15:21] tsdgeos, because otherwise people will try and tap it and it launches an app [15:21] and it's not something design requested [15:21] tsdgeos, I don't mean it should *do* anything [15:21] tsdgeos, just it shouldn't be transparent to input [15:22] ok, we had to do some extra code with dandrader to make it happen :/ [15:22] but ok [15:22] Saviq: can you make a note in the MR so i won't forget while i review dednicks code? [15:23] tsdgeos, to make the hint thingy transparent? [15:25] Saviq: well to make sure it did not conflict with the scrollarea when moving up in that area [15:25] tsdgeos, ok, I'll leave a note then [15:25] Saviq, you mean make only that tab absorb touches, but not the whole bottom area, right? [15:25] dandrader, yes [15:26] tsdgeos, ^ [15:26] dandrader, just the white thingy with ^ [15:26] Saviq: ah i thought you meant the whole area [15:26] tsdgeos, no, just the white tab hinting thingy [15:26] ok [15:26] that makes more sense [15:27] thanks [15:27] Saviq: hm. installed silo + apt install unity8 = blank screen... [15:27] I did say *tab*, *hint*, tried to explain what I mean ;) [15:27] sure sure [15:27] dednick, silo 11? [15:27] 10 [15:27] er 10... [15:27] i'm not saying it's your fault [15:27] doh [15:28] dednick, no, 10 is good [15:28] dednick, generally use `citrain device-upgrade 10` [15:28] from phablet-tools-citrain [15:28] Saviq: ah. didnt know there was that... [15:28] dednick, worked fine here every time [15:28] so not sure what got you [15:28] Saviq: will try. perhaps there is a missing dep somewhere [15:29] dednick, there's qtmir there as well [15:29] dednick, just do `citrain device-upgrade 10 $password` now [15:29] dednick, it will do the right thing [15:29] Saviq: presumably if the specific version was needed it would be deped to that? [15:30] dednick, it was, yeah [15:30] dednick, but maybe we do have some dependency problem still === dandrader is now known as dandrader|lunch [15:30] hm. perhaps my install wasn't fresh or something.. [15:30] - qtdeclarative5-qtmir-plugin (>= 0.4.3), [15:30] + qtdeclarative5-qtmir-plugin (>= 0.4.4), [15:31] or had another silo in apt [15:32] dednick, uugh... your 1500ms timer... plane mode takes more than that to activate... [15:33] Saviq: hm. but it should be updated by a subsequent trigger from dbus :( [15:33] unless dbus is being faaaar too clever [15:33] dednick, yeah, *but* [15:33] dednick, it goes on, off, on [15:33] really not great [15:33] for it's own stupidity that is [15:33] Saviq: :/ [15:34] aand now I'm out of sync [15:35] dednick, I can't land that, I'm stuck in plane mode now :| [15:35] tsdgeos, wondering if we can avoit the timers using a mousearea [15:35] ahh.. ffs [15:35] dednick, if it decides to go back, it let's the other side know it went back [15:36] lets [15:36] dednick, and we basically get a feedback loop [15:36] bloody useless [15:36] Cimi: how? as far as i undertand being pressed at a certain X has to trigger scroll [15:36] i don't see how to do that without a timer [15:37] shouldnt do that :/ only supposed to be on user interaction! [15:37] tsdgeos, reading mouse event x position of a mousearea on top? [15:37] dednick, that's just my suspicion, not saying that's what happens [15:37] dednick, pulling that MP from the silo in any case... [15:37] Cimi: and how are you going to keep scrolling? [15:38] Saviq: which one? [15:38] Cimi: need to keep scrolling without position changes [15:38] tsdgeos, https://code.launchpad.net/~nick-dedekind/unity8/lp1336715.server-value-reassert/+merge/237822 [15:39] ah couldn't find that 1500 reference [15:40] Saviq: Error reading https://launchpad.net/api/1.0/~ci-train-ppa-service/+archive/ubuntu: Not Found [15:41] although still seems to be doing something... [15:41] Saviq: http://paste.ubuntu.com/8553318/ [15:41] dednick, yeah, that didn't work [15:42] wonder if ppa:ci-train-ppa-service/ubuntu/landing-010 is correct [15:43] something is going really slow.. [15:43] dednick, you might need to reflash, something got real weird in your sources [15:43] i just did [15:43] although not a wipe [15:44] dednick, no no, no wipe necessary [15:44] dednick, apt-cache policy phablet-tools-citrain? [15:45] * Saviq gotta split for now [15:46] Saviq: 1.1+14.10.20141010-0ubuntu1 [15:46] will just do manual [15:52] Saviq, I guess https://code.launchpad.net/~macslow/unity-settings-daemon/max-volume-notification-warning/+merge/238180 needs and rtm branch too?! === gatox is now known as gatox_lunch [16:03] Saviq: qtmir-anrdoid wasn't upgraded with manual silo install. [16:04] which means the rest of mir wasn't either. [16:10] mzanetti: both u8 branches approved [16:12] greyback: thanks a lot :) [16:20] dbarth, it seems that the FB webapp asks me for user name and password every time I start it. Is this a known bug? Or is it supposed to work like that? [17:03] dandrader|lunch: i think i sorted out some more problems with that velocity calculator now. [17:03] it should be fairly quiet now :) === gatox_lunch is now known as gatox === alan_g is now known as alan_g|EOD === karni is now known as karni-afk === karni-afk is now known as karni === dandrader|lunch is now known as dandrader [19:13] dandrader: hey, the launcher dconf branch should be fixed now [19:13] thanks for catching that issue === rpadovani is now known as rpadovani|Dota [19:16] mzanetti, np. I've hit my EOD. will test it again tomorrow === salem_ is now known as _salem