| vthompson | Elleo, hey with regard to https://bugs.launchpad.net/music-app/+bug/1379817 | 01:05 |
|---|---|---|
| ubot5 | Ubuntu bug 1379817 in Ubuntu Music App "When importing 7 digital albums music-app sometimes displays "Imported files not found" when all files have been imported" [Undecided,Confirmed] | 01:05 |
| vthompson | Elleo, are you around? | 01:05 |
| Elleo | vthompson: yep? | 01:05 |
| ahayzen | vthompson, o/ | 01:05 |
| ahayzen | vthompson, have you checked out the ms2 log around the time of first import? | 01:06 |
| ahayzen | vthompson, (as i just added to the bug report) | 01:06 |
| vthompson | Elleo, I just read your update about the bug having to do with a fresh install. I wasn't able to reproduce by deleting "things" but I have a suspicion that mediascanner2 might not be watching for the new folder to be created | 01:06 |
| vthompson | ahayzen, I' | 01:06 |
| ahayzen | vthompson, i remember having something similar to this when initially creating it | 01:07 |
| vthompson | ahayzen, I've been watching the ms2 log and it quickly detects the new folder and the new contents... I just wonder if the daemon might "go to sleep" and not be so active at watcing for filesystem changes | 01:07 |
| ahayzen | vthompson, so if you restart the app does it see the file or not? | 01:07 |
| vthompson | ahayzen, I can do that next. I also went as far as restarting ms2 incase it was still watching the old directory | 01:08 |
| ahayzen | vthompson, yeah good shout | 01:08 |
| ahayzen | vthompson, what is interesting is that is picks up the second file? but not the first | 01:08 |
| vthompson | oh restart the app? yea, the app running or not does not seem to have an affect | 01:08 |
| vthompson | I thought you meant restart the device... :) | 01:09 |
| ahayzen | vthompson, yeah restart the app does it then see the first file? | 01:09 |
| vthompson | yes | 01:09 |
| ahayzen | vthompson, i mean run the failed import... restart the app..can you see it in the models | 01:09 |
| vthompson | Why do you think that'd change? | 01:09 |
| vthompson | I can't get a failed import :) | 01:09 |
| ahayzen | vthompson, oh | 01:09 |
| vthompson | I can clear a few things and it still picks up the song reliably. I could try different songs, I suppose | 01:10 |
| ahayzen | vthompson, have you tried clearing the folders and the ms2 db...then doing the process again | 01:10 |
| vthompson | Elleo, could you get us a copy of your /home/phablet/.cache/upstart/mediascanner-2.0.log file? | 01:10 |
| vthompson | I didn't clear the ms2 db yet | 01:11 |
| vthompson | ahayzen, I don't think that alone would do it.. but it might | 01:11 |
| ahayzen | vthompson, it may not remove the watches until a restart or something | 01:11 |
| vthompson | yea, I assumed that'd happen after a restart of the service... but a reboot might be my next test | 01:12 |
| Elleo | vthompson: okay, just a sec | 01:12 |
| vthompson | Elleo, awesome, thanks | 01:13 |
| vthompson | ahayzen, reboot didn't help. I'm going to let the service idle a bit | 01:16 |
| ahayzen | vthompson, interesting | 01:17 |
| Elleo | ahayzen, vthompson: attached to the bug report | 01:17 |
| ahayzen | Elleo, thanks | 01:17 |
| vthompson | Thanks :) | 01:17 |
| akiva-thinkpad | hi all | 03:28 |
| akiva-thinkpad | ahoneybun, havn't heard from you lately; whats new? | 03:40 |
| mihir | akiva-thinkpad: ping | 06:11 |
| mihir | akiva-thinkpad: something is wrong with your MP , can you check ? | 06:11 |
| akiva-thinkpad | mihir, yah sure | 06:12 |
| mihir | akiva-thinkpad: it is failing tests. | 06:12 |
| mihir | akiva-thinkpad: i believe it is not able to save event. | 06:12 |
| akiva-thinkpad | mihir, bah | 06:12 |
| akiva-thinkpad | it might be because of the bug I found, but I found that in trunk as well | 06:12 |
| akiva-thinkpad | mihir, it says with default values, but lately I have noticed in trunk, I no longer have any calendars available to choose from | 06:15 |
| akiva-thinkpad | so I can't add any events either. | 06:15 |
| mihir | akiva-thinkpad: Jenkins just passed my MP though. | 06:15 |
| akiva-thinkpad | mihir, do you think jenkins might be suffering from that as well? | 06:15 |
| akiva-thinkpad | mihir, interesting. | 06:15 |
| mihir | akiva-thinkpad: see this , it just ran few mins before https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/blankBubbleInWeekView/+merge/237069 | 06:16 |
| akiva-thinkpad | mihir, can i ask something; does jenkins do all tests when it runs, or just tests related to the code you editted? | 06:16 |
| mihir | akiva-thinkpad: it runs all test cases :) | 06:16 |
| akiva-thinkpad | okay thanks | 06:16 |
| mihir | akiva-thinkpad: try to run testcases locally. | 06:16 |
| akiva-thinkpad | mihir, how? | 06:17 |
| mihir | you on 14.10 ? | 06:17 |
| akiva-thinkpad | that would be really useful to know | 06:17 |
| akiva-thinkpad | yep | 06:17 |
| mihir | akiva-thinkpad: in your directory , navigate to /tests/autopilot/ | 06:18 |
| akiva-thinkpad | okay | 06:19 |
| akiva-thinkpad | done | 06:20 |
| mihir | autopilot3 list calendar_app | 06:20 |
| mihir | akiva-thinkpad: ^^ | 06:21 |
| akiva-thinkpad | autopilot3: error: argument mode: invalid choice: 'calendar_app/' (choose from 'run', 'list', 'vis', 'launch') | 06:21 |
| justCarakas | o/ good morning evening whatever it is at your place all | 06:21 |
| akiva-thinkpad | I take it is run? | 06:21 |
| akiva-thinkpad | mihir, | 06:21 |
| akiva-thinkpad | justCarakas, evening | 06:22 |
| akiva-thinkpad | justCarakas, did you end up finishing your app? | 06:22 |
| justCarakas | nop, I stalled, not everything is clear and I need time to find out how QML works but I'm also making an PHP framework atm to improve my skills and that has been the focus of my free time | 06:23 |
| justCarakas | maybe I'll finish it when I'm a weekend at home, but my agenda is kinda full | 06:24 |
| justCarakas | and I work a lot while traveling, and than its harder to look up qml stuff | 06:24 |
| mihir | akiva-thinkpad: yeah it is run, i thought to make you understand | 06:26 |
| akiva-thinkpad | mihir, curses you! | 06:26 |
| akiva-thinkpad | :) | 06:26 |
| mihir | akiva-thinkpad: if you want to run individual test case then you can pick name and do autopilot3 run testcaseName | 06:26 |
| akiva-thinkpad | okay this is great; thanks for taking the time to walk me through that. | 06:26 |
| akiva-thinkpad | mihir, ah very cool | 06:26 |
| mihir | akiva-thinkpad: if you want to run whole test suite just do , autopilot3 run calendar_app/ | 06:26 |
| akiva-thinkpad | mihir, quickly, merge-source and tree; I keep forgetting which one is my code, and which one is the trunks code that I merged from. | 06:28 |
| mihir | akiva-thinkpad: i lost you now :) | 06:29 |
| akiva-thinkpad | mihir, this is for conflicts in merges | 06:29 |
| akiva-thinkpad | you have >>>>>>>>>>>tree ================== >>>>>>>>>>>>>>>>>>>merge-source | 06:30 |
| mihir | akiva-thinkpad: hmm , the merge source is yours , there will be 3 files on your directory | 06:39 |
| mihir | akiva-thinkpad: check and resolve properly | 06:39 |
| seb128 | mihir, hey, could you get a pot update in calendar? | 06:48 |
| mihir | seb128: hey morning , ahh, could it wait till evening , i am at work place. if that's urgent i can get it done with help of someone. | 06:49 |
| seb128 | mihir, no hurry, it's just for the commit you did with the string fixes, we need an updated pot so they are translatable | 06:50 |
| seb128 | mihir, I pointing it in the merge request review but maybe you didn't notice | 06:50 |
| seb128 | mihir, anyway, tonight is fine, thanks! :-) | 06:50 |
| mihir | seb128: yeah i should have done that. i missed that. | 06:50 |
| === tvoss__ is now known as tvoss | ||
| dholbach | good morning | 06:53 |
| mihir | Morning dholbach :) | 06:53 |
| dholbach | hi mihir | 06:53 |
| mihir | dholbach: hello :) what's up? | 06:53 |
| dholbach | doing well - how about you? | 06:54 |
| mihir | doing great :) | 06:54 |
| === wgrant_ is now known as wgrant | ||
| rpadovani | mardy, could you ping me when you have 10 minutes please? :-) I have a core dump and a question for you | 06:58 |
| dpm | sounds like a start of an interesting conversation :) | 06:59 |
| dholbach | :-) | 06:59 |
| * mardy hides | 07:20 | |
| mardy | rpadovani: ok, tell me :-) | 07:25 |
| rpadovani | lol mardy, thanks :-) I don't find my core dump paste right now, so before the question :D If I have a list of unauthorized accounts and I want to launch the UI to enable it on click, how I could do that? | 07:26 |
| rpadovani | https://bazaar.launchpad.net/~rpadovani/reminders-app/multipleAccounts/view/head:/src/app/qml/ui/AccountSelectorPage.qml#L59 | 07:26 |
| mardy | rpadovani: unfortunately you cannot choose in advance which unauthorize account you want to prompt the user about | 07:28 |
| mardy | rpadovani: that selection happens inside Online Accounts | 07:28 |
| rpadovani | mardy, gotcha, thanks. So I have to launch it with setup.exec(), as adding a new account? | 07:29 |
| mardy | rpadovani: that's according to design, just read the first paragraph here: https://wiki.ubuntu.com/OnlineAccounts#App_access | 07:29 |
| mardy | rpadovani: exactly | 07:29 |
| rpadovani | mardy, yeah, documentation, I definitely need to read it more often :D | 07:30 |
| rpadovani | dpm, ^^ | 07:30 |
| mardy | rpadovani: in other words, I think you shouldn't even show the list of unauthorized accounts, just have a button "Add an Evernote account" or something like that | 07:30 |
| dpm | mardy, thanks. And how can I authorize an account that I've created via System Settings, then? I.e. if I 1) Create Evernote account via u-s-s-o-a 2) Start Reminders 3) If there is only an "Add account" button, how can I ever use my existing account? | 07:32 |
| mardy | dpm: press the "Add account" button :-) It will allow to select the existing account | 07:33 |
| mardy | dpm: see the wiki link above, it shows all the possible cases | 07:33 |
| rpadovani | dpm, and this was my first MR, list of available accounts, a text if there are unauthorized accounts, and the button | 07:33 |
| rpadovani | mardy, ok, thanks! About the core dump, I have it when I try to change account. I click on new account and I assign to accountService.objectHandle accountServiceHandle. It used to work, like 6 months ago, then we disabled the account switching feature so I dunno when it brokes | 07:37 |
| rpadovani | mardy, I give you the core asap | 07:37 |
| mardy | rpadovani: OK | 07:37 |
| mardy | rpadovani: is it easy to reproduce? | 07:38 |
| rpadovani | mardy, yes, just take lp:~rpadovani/reminders-app/multipleAccounts, when you start the app choose an account (you have to have 2 accounts in oa, of course), then after the login clic on the menu in the header and choose 'accounts' voice, and select the other account | 07:41 |
| rpadovani | mardy, it freezes, and after some time it crashes. My problem right now is that freezes but doesn't crash :/ | 07:41 |
| mardy | rpadovani: OK, I cannot look at it right now, but could you please file a bug with these instructions? | 07:41 |
| akiva-thinkpad | mihir, FailedTestScreenshot (image/png) -- is this saying that there is a screenshot that was taken of the failure? | 07:41 |
| rpadovani | mardy, sure | 07:41 |
| dpm | mardy, rpadovani, ack, just read the wiki. However, the "more than 1" already set up accounts seems to imply that we can read the name of the account to show a prompt from the app, but I understand that we cannot actually do that? | 07:44 |
| rpadovani | dpm, mardy if I understand right, we actually can show the name of the unauthorized account - we have a model for that - but we cannot say to OA which account we want to authorize | 07:45 |
| dpm | ah, gotcha, then what rpadovani said is actually what I meant :) | 07:46 |
| mardy | dpm, rpadovani: yes, that's correct. | 07:47 |
| dpm | mardy, then we cannot implement the "more than 1" case in the wiki? Or did we get it wrong? | 07:49 |
| mihir | akiva-thinkpad: from where you getting this error | 07:49 |
| mardy | dpm: you can | 07:50 |
| mardy | dpm: your UI should show a list of the authorized accounts, | 07:50 |
| mardy | dpm: and then a button "Add another" | 07:50 |
| mardy | dpm: that's it | 07:50 |
| dpm | mardy, and what does "Add another" do? I.e. I can see the workflow in the diagram, but I don't quite understand how after clicking "Add another" the app should authorize (or defer authorization to u-s-s-o-a) existing but unauthorized accounts | 07:52 |
| rpadovani | dpm, you can try it adding a google account and doing login in gmail webapp | 07:53 |
| akiva-thinkpad | mihir, nevermind. Anyways I found the test that my app is failing, well the remix, and when I watch it... It doesnt make sense what its trying to accomplish. Is there a way I can check what this specific test is trying to achieve? | 07:54 |
| rpadovani | dpm, mardy actually, the app doesn't crash anymore, at least on this computer. It only freezes and takes ages to switch account, but this maybe is fail of reminders backend. I'll ask to mzanetti to take a look to it next week | 07:54 |
| mihir | akiva-thinkpad: you can try to run that individual test case look at the errors , and identify where it is failing . | 07:55 |
| rpadovani | brb | 07:55 |
| akiva-thinkpad | yah its here | 07:55 |
| akiva-thinkpad | sec | 07:55 |
| mardy | dpm: the only thing the app has to do is call Setup::exec(), then all the flow is implemented in OA | 07:56 |
| dpm | mardy, ok, thanks | 07:56 |
| mardy | dpm: OA will check how many unauthorized accounts there are for the app, and decide what to show to the user | 07:56 |
| akiva-thinkpad | mihir, http://imgur.com/lVfJaY1 | 07:56 |
| akiva-thinkpad | 00:52:54.894 INFO _launcher:544 - waiting for process to exit. | 07:57 |
| mihir | akiva-thinkpad: is it music app ? | 07:57 |
| akiva-thinkpad | mihir, yep | 07:57 |
| dpm | rpadovani, I think that answers all my questions - do you have any more questions related to the multiple accounts UI, or are you good to go? | 07:57 |
| mihir | akiva-thinkpad: i have no idea of music app , thought you talking regarding calendar app :| | 07:57 |
| akiva-thinkpad | ah | 07:57 |
| rpadovani | dpm, good to go, at least when I understand why it freezes. Thanks mardy for your time! | 07:58 |
| akiva-thinkpad | mihir, ah but in this case; is it obvious to you what the issue is? | 07:58 |
| rpadovani | dpm, so, how do you want to implement that? | 07:58 |
| akiva-thinkpad | or do I have to bring it up with vic and ahayzen? | 07:58 |
| dpm | rpadovani, I guess we can just go with the sketches on the wiki page? I.e. a dialog instead of a page | 07:59 |
| mihir | akiva-thinkpad: may be try adding more logs on the functions mentioned in that traceback | 07:59 |
| mardy | dpm: if you are referring to this wiki page (https://wiki.ubuntu.com/OnlineAccounts#App_access), you don't have to implement any dialogs: all of the right-hand side of the diagram is already implemented in OA | 08:01 |
| akiva-thinkpad | mihir, so debugs? do console.log work? | 08:02 |
| mihir | akiva-thinkpad: there is different way doing in python, you can take reference from previous logging. | 08:02 |
| rpadovani | mardy, so I could easily do (if accounts.count = 1) autologin() (else accounts.count = 0 || >1) Setup.exec() | 08:03 |
| rpadovani | mardy, and switchAccount() = Setup.exec() ? | 08:03 |
| akiva-thinkpad | mihir, oh I think I found the issue... its something that is depricated. | 08:04 |
| mihir | akiva-thinkpad: hmm , were you able to find a root cause in calendar ? | 08:05 |
| mardy | rpadovani: not exactly; you should call Setup.exec() only when you want to add a new account | 08:05 |
| mardy | rpadovani: my suggestion is: | 08:05 |
| mardy | 1a) on statup, if there's only one enabled account, autologin | 08:06 |
| akiva-thinkpad | mihir, i'll go do that after. Sorry :S -- btw; I really want to thank you for being so good with merge requests and walking me through this. It honestly means a lot to me. | 08:06 |
| mardy | 1b) on startup, if there are several enabled account, present a list of them (or maybe remember the one used last time?) | 08:06 |
| mardy | 2) on the account selection page, show a list of the enabled accounts, and one "Add another evernote account" button which triggers Setup.exec() | 08:07 |
| mihir | akiva-thinkpad: no issue :) thank you for Merge request and your contribution. | 08:07 |
| rpadovani | mardy, ok, thanks. dpm sounds good to you? | 08:08 |
| akiva-thinkpad | mihir, so I am fairly certain that the test is depricated; should I delete the test, or edit it, or not touch it and speak with other maintainers? | 08:09 |
| mihir | akiva-thinkpad: i can't comment on Music app , as i am not aware about that , so it is better to talk to music app developers. | 08:09 |
| akiva-thinkpad | okay | 08:09 |
| mihir | akiva-thinkpad: that might be the case , if you have changed the functionality , you might have to remove/update your test case accordingly. | 08:10 |
| dpm | rpadovani, sounds great | 08:13 |
| DanChapman | Good Morning all :-) | 08:14 |
| rpadovani | mardy, how can I prompt the dialog to authorize an account? Setup.exec adds a new account, but if user already added it in OA? | 08:17 |
| mardy | rpadovani: no changes, always use Setup.exec() | 08:18 |
| rpadovani | mardy, gotcha thanks | 08:18 |
| rpadovani | dpm, do you want also a text that says "We found unauthorized accounts, please click on the button below to authorize it" or we leave only the "Add account" button? | 08:20 |
| dpm | rpadovani, let's keep it simple for now and use "Add another..." | 08:21 |
| rpadovani | dpm, ack. So, the code is ready, it's the first revisios I did, I have only to delete the text. I'm investigating on the freeze, so I don't push right now | 08:22 |
| dpm | thanks rpadovani! | 08:22 |
| nik90 | zsombi: hey, I did some preliminary testing of your alarm-data-adapation branch and it did not refresh the listview on adding/deleting an alarm which is awesome. However it broke the alarm switch. I wasn't able to enable/disable alarms in the clock app. | 08:39 |
| nik90 | zsombi: can you verify that on your end as well? | 08:39 |
| JamesTait | Good morning all; happy Information Overload Day! :-D | 08:49 |
| justCarakas | time to send spam :D | 08:53 |
| justCarakas | JamesTait: does that mean I can send you wikipedia pages as emails? :D | 08:53 |
| dpm | JamesTait, that's my every day! | 08:53 |
| JamesTait | justCarakas, you and everyone else. :-P | 08:56 |
| JamesTait | dpm, amen to that. | 08:56 |
| dpm | morning ogra_! What's the status of the removal of evernote-plugin-account from the seeds? Do you think it will make it to the next promoted image? | 09:00 |
| dpm | on rtm, I mean | 09:00 |
| ogra_ | dpm, it has to :) i'll ping you after the lanbding meeting so we can coordinate | 09:02 |
| * dpm hugs ogra_ | 09:04 | |
| vitimiti | Hi | 09:07 |
| nik90 | akiva-thinkpad: not sure if you tried, but you can now run apps on the emulator directly through qtc instead of the hack we did due to a bug at the time. | 09:14 |
| dpm | ahayzen, with the music remix app, is there a way to add songs to a playlist? I could only create playlists, but not populate them | 09:21 |
| ahayzen | dpm, drag a listitem to the left and click on the second icon | 09:21 |
| ahayzen | dpm, i think we're looking to add header actions to the album/artist itself so you could add the whole album/artist to a playlist as well | 09:22 |
| dpm | ahayzen, slick! I'd not noticed the swipe elements other than "Delete" :) | 09:23 |
| dpm | thanks! | 09:23 |
| ahayzen | dpm, haha no problem :) | 09:23 |
| ahayzen | dpm, yeah listitem actions are very discoverable at the moment | 09:23 |
| ahayzen | dpm, i've been working on multiselect support as well...so you would press'n'hold then tick the ones you want and click 'Add to playlist' in the header | 09:24 |
| seb128 | nik90, hey, do you have an opinion on https://bugs.launchpad.net/ubuntu-clock-app/+bug/1381429? | 09:33 |
| ubot5 | Ubuntu bug 1381429 in Ubuntu Clock App "Shouldn't code button's geometry, but rather let it adapt to the label" [Undecided,New] | 09:33 |
| * nik90 takes a look | 09:33 | |
| nik90 | seb128: The reason why I set it to 17 grid units was because the visual spec I was given had that dimension. But I agree it makes sense to make the width depend on the label + some margin. | 09:35 |
| seb128 | nik90, why a margin? buttons should be consistent in look, if they need a marging between text and borders the toolkit should do that for you | 09:36 |
| nik90 | seb128: although I will ensure in that case that the button never touches the edges of the app by using Math.min(label.width, page.width) | 09:36 |
| nik90 | seb128: true | 09:37 |
| seb128 | nik90, I doubt you are going to hit translations where that string go over the screen, but your call ;-) | 09:37 |
| nik90 | seb128: do you have a patch for this or should I fix this? | 09:38 |
| nik90 | seb128: true, I just take precautions here and there sometimes ;) | 09:38 |
| seb128 | nik90, I don't have a patch yet, I can do one if you want | 09:38 |
| seb128 | nik90, I just wanted to discuss the change in principle first | 09:38 |
| nik90 | seb128: whatever suits you, since it should just be a 2 liner code change at most. | 09:39 |
| nik90 | seb128: I will take care of this | 09:39 |
| seb128 | nik90, thanks | 09:39 |
| seb128 | let me know if you want a review/tester | 09:39 |
| nik90 | seb128: will do. | 09:39 |
| seb128 | I'm happy to adb push the qml to my device and test on french locale :-) | 09:39 |
| nik90 | :) | 09:40 |
| dpm | ahayzen, wow, looking forward to multiselect, then! | 09:51 |
| ahayzen | dpm, haha yeah not sure when we'll land that it is fun trying to integrate with the custom reorder code...will probably be in the sprint that it gets done | 09:51 |
| dpm | cool | 09:52 |
| === rmescandon is now known as rmescandon-afk | ||
| nik90 | seb128: https://code.launchpad.net/~nik90/ubuntu-clock-app/dynamic-delete-alarm-size/+merge/238407 | 09:57 |
| nik90 | seb128: I tested the code with a really long & short string and it worked as expected. | 09:58 |
| nik90 | akiva-thinkpad: sparingly? | 09:58 |
| akiva-thinkpad | nik90, yah; the music app for example last time I tried, opened, then just crashed. | 10:07 |
| akiva-thinkpad | mihir, ping -- I tried the test on trunk | 10:07 |
| nik90 | hmm that's strange | 10:07 |
| akiva-thinkpad | it failed there as well. | 10:07 |
| ahayzen | akiva-thinkpad, crashed on what? | 10:07 |
| akiva-thinkpad | ahayzen, oh hey | 10:07 |
| akiva-thinkpad | ahayzen, just running the emulator. | 10:08 |
| nik90 | akiva-thinkpad: oh btw there is one limitation | 10:08 |
| ahayzen | akiva-thinkpad, ah emulator right | 10:08 |
| akiva-thinkpad | i didnt bother to debug | 10:08 |
| nik90 | akiva-thinkpad: you can run the app on the emulator for about 15-20 times before you need to reboot the emulator | 10:08 |
| akiva-thinkpad | nik90, hmm? | 10:08 |
| akiva-thinkpad | nik90, hmmm? interesting | 10:08 |
| akiva-thinkpad | okay | 10:08 |
| nik90 | akiva-thinkpad: is is related to the app not releasing some EGL surfaces when an quits in the emulator. | 10:08 |
| nik90 | it is a known bug but no time to fix it yet | 10:08 |
| akiva-thinkpad | nik90, respectfully | 10:09 |
| akiva-thinkpad | cool thanks for explaining that | 10:09 |
| nik90 | yw | 10:09 |
| zsombi | nik90: I'll do that, good point! | 10:10 |
| nik90 | zsombi: hey, one more thing if you got time. | 10:11 |
| zsombi | nik90: shoot | 10:11 |
| nik90 | zsombi: I have been using the qtc profiler to see bottlenecks in the clock app and noticed that the edit alarm page takes a while to load because of the date time picker. Is this known? | 10:11 |
| nik90 | zsombi: the datetime picker took about 150-250 ms to load.. (cant remember exactly) | 10:12 |
| zsombi | nik90: yes, partly because of the slowness of the ListItems partly because of the PathView instantiating every single item from the model (not like ListView) and partly due to the date model handling :( | 10:13 |
| nik90 | zsombi: ah..I am trying to circumvent the issue by showing the edit alarm page and then loading the datetime picker. | 10:14 |
| nik90 | so it might seem a bit more snappy | 10:15 |
| zsombi | nik90: yep... sorry for that, we will reach those as well some time the new ListItem is ready... | 10:15 |
| === rmescandon-afk is now known as rmescandon | ||
| nik90 | zsombi: cool, no worries | 10:16 |
| zsombi | nik90: so, returning to the disabling issue, what have you experienced? no refresh on teh item? | 10:17 |
| zsombi | nik90: or that the disabling ain't got completed? | 10:17 |
| nik90 | zsombi: no it doesn't disable it at all..so I press the switch, but it doesn't change. | 10:17 |
| nik90 | zsombi: tbh I didnt further debug and console output the alarm status due to lack of time. | 10:17 |
| zsombi | nik90: I see. the tests show that disabling goes thru, so we might need to adjust the switch handling then... | 10:17 |
| nik90 | ah ok | 10:18 |
| zsombi | nik90: np, I'll take the clock app branch and test it on desktop | 10:18 |
| nik90 | ok | 10:18 |
| zsombi | nik90: you've tested on desktop, right? | 10:18 |
| nik90 | zsombi: yup only on utopic desktop vm. | 10:18 |
| zsombi | nik90: thx | 10:19 |
| ahayzen | akiva-thinkpad, you shouldn't really be removing the seek_to() from the tests | 10:21 |
| mihir | akiva-thinkpad: you talking about calendar ? | 10:30 |
| nik90 | zsombi: can you give your insight on bug 1381432. I already commented on it, but it needs to be validated by someone like you. | 10:42 |
| ubot5 | bug 1381432 in Ubuntu Clock App "Display "no active alarm" while checking" [Medium,Confirmed] https://launchpad.net/bugs/1381432 | 10:42 |
| zsombi | nik90: after the alarm-data-adaptation MR you won't need to load AlarmModel with a Loader anymore | 10:44 |
| nik90 | zsombi: really? | 10:45 |
| zsombi | nik90: yep :) | 10:45 |
| nik90 | zsombi: wow pretty cool. | 10:45 |
| nik90 | zsombi: is there a way to still know when the alarm model is ready (after fetching data)? | 10:45 |
| zsombi | nik90: and you will receive a QAbstractItemModel signal when data comes available | 10:46 |
| nik90 | zsombi: i can disable the bottom edge hint until it is ready to avoid showing false status to the user | 10:46 |
| nik90 | sweet | 10:46 |
| nik90 | I have to ask, what is the core change of the alarm-data-abstraction MR in a few words? | 10:47 |
| nik90 | How does it seem to fix a couple of bugs in one go? | 10:47 |
| zsombi | nik90: the signal is modelReset() | 10:47 |
| zsombi | nik90: well, the main change is that there is no alam cache duplication per model | 10:48 |
| akiva-thinkpad | mihir, bah my notifcation system... darn hexchat :/ Sorry | 10:48 |
| akiva-thinkpad | mihir, and yes, talking about the calendar | 10:48 |
| akiva-thinkpad | the trunk fails the tests | 10:48 |
| zsombi | nik90: then there is no alarm request handling generalized, all that has been moved to AlarmDataAdapter and AlarmsAdapter | 10:49 |
| akiva-thinkpad | ahayzen, the issue is I don't know how to fix the test. That test relies upon the old version of the toolbar | 10:49 |
| akiva-thinkpad | not toolbar, slider* | 10:49 |
| ahayzen | akiva-thinkpad, yeah the test will need to be rewritten to use the new slider | 10:49 |
| zsombi | nik90: then, alarm cache is one per app instance, all models connect to this cache and reflect all changes immediately | 10:49 |
| akiva-thinkpad | ahayzen, If you can help me through rewriting it, I would be appreciative. I don't know how to set the square as an object with the slider. | 10:50 |
| zsombi | nik90: no more fetch on alarm data change/add/remove, each of these are handled as separate model updates | 10:50 |
| nik90 | zsombi: I am using the loader atm to load the model *after* the startup animation is done since otherwise it causes the startup animation to be laggy. | 10:50 |
| ahayzen | akiva-thinkpad, i'll have a look when i get back, i'm at uni at the moment | 10:50 |
| nik90 | zsombi: ah that's cool | 10:50 |
| akiva-thinkpad | ahayzen, thanks | 10:50 |
| zsombi | nik90: the fetch will only happen when the alarm model is created, more precisely when the QML model is completed | 10:51 |
| zsombi | nik90: that results in dataChanged() emision, which btw happens even now | 10:51 |
| zsombi | nik90: sorry, modelReset()!!!!!!! | 10:52 |
| nik90 | zsombi: ah, so I can use onModelReset() to know when to show the bottom edge hint to the user then. | 10:52 |
| tvoss | probably better here | 10:52 |
| zsombi | nik90: alarm data change may result in either dataChanged() if the time is not changed or if the time change does not require the alarm cache index change | 10:52 |
| zsombi | nik90: yes | 10:52 |
| tvoss | popey, dpm ping | 10:53 |
| tvoss | popey, dpm could someone raise priority of https://bugs.launchpad.net/osmtouch/+bug/1381463 | 10:53 |
| ubot5 | Ubuntu bug 1381463 in OSMTouch "PositionSource.update() cannot be used synchronously" [Undecided,New] | 10:53 |
| zsombi | nik90: alarm addition will cause rowsAboutToBeInserted() + rowsInserted() signals | 10:53 |
| zsombi | nik90: alarm removal will cause rowsAboutToBeRemoved() + rowsRemoved() | 10:53 |
| zsombi | nik90: ah, sorry, one more mistake :D | 10:54 |
| nik90 | zsombi: ah nice..individual signals for each action..more control cool | 10:54 |
| zsombi | nik90: alarm data change may cause dataChanged() or rowsToBeMoved() + rowsMoved() signals | 10:54 |
| zsombi | nik90: depending on what data is changed | 10:54 |
| nik90 | ok | 10:54 |
| dpm | tvoss, that's an app created by a community member, not part of core apps. We don't have any permissions for setting bug priorities | 10:54 |
| zsombi | nik90: like disabling an alarm, description, soundChange results in dataChanged() | 10:55 |
| tvoss | dpm, could you reach out to the developer please? | 10:55 |
| zsombi | nik90: but date change may result in move | 10:55 |
| nik90 | zsombi: ack. | 10:55 |
| zsombi | nik90: as the date may become later/earlier than the other ones are, so the list will be rearranged | 10:55 |
| dpm | tvoss, sure, we can do that | 10:56 |
| mihir | akiva-thinkpad: Jenkins passed other MR | 10:56 |
| mihir | so that shouldn't be problem i believe | 10:56 |
| nik90 | zsombi: yeah at the moment the list is not rearranged when changing dates. thereby forcing me to go through every alarm to figure out the next closest active alarm. | 10:56 |
| nik90 | nice to know though that this will be fixed | 10:56 |
| akiva-thinkpad | mihir, but I just tried it with the trunk; it failed o_o | 10:57 |
| zsombi | nik90: you will get the model always showing the alarms in the cronological order, but disabling a passed alarm will still be as first in teh model | 10:57 |
| akiva-thinkpad | like I didnt edit the trunk at all | 10:57 |
| * akiva-thinkpad double tries it | 10:57 | |
| nik90 | zsombi: ah..ok .. I can do the search in the clock app myself | 10:58 |
| zsombi | nik90: so we may still need a filter on teh model to exclude disabled alarms? | 10:58 |
| nik90 | zsombi: that's your call since for my use case, a user might have at most 5-6 alarms which is not that hard to go through and find the closest active alarm. | 10:58 |
| zsombi | nik90: well, then we keep it as is now, because that would require some index mirroring in the model | 11:00 |
| nik90 | zsombi: fine by me | 11:00 |
| zsombi | nik90: so, all kewl features on that MR :) | 11:03 |
| nik90 | zsombi: :D | 11:03 |
| zsombi | nik90: and some code simplification as well :) | 11:03 |
| zsombi | nik90: but the model changes were requiring heavy changes in the cache | 11:04 |
| nik90 | ah | 11:05 |
| rpadovani | zsombi, hey :-) Does header is supposed to hide automagically if I have listview inside a page inside a pagestack? I know it is in a listview inside a page, but if I have also a pagestack? Because in reminders app it doesn't hide, and I don't understand why | 11:09 |
| zsombi | t1mp: ^ | 11:09 |
| zsombi | rpadovani: it supposed to, but it depends what are you doing with your ListView... | 11:10 |
| zsombi | rpadovani: like how you anchor, what else you have in the page, etc | 11:11 |
| rpadovani | zsombi, som I'll have to do a looong work of commenting out everything to understand what's going on :-) | 11:11 |
| rpadovani | thanks | 11:11 |
| zsombi | rpadovani: you better start a new Page with a ListView as content and start add more stuff to see where it breaks :) | 11:12 |
| zsombi | rpadovani: this would be a better approach :D | 11:12 |
| rpadovani | ok, I'll try this one then :-) Thanks! | 11:13 |
| t1mp | rpadovani: it should work if the ListView is anchored to the top of the page or fills the page | 11:24 |
| rpadovani | t1mp, thanks, this could be a good suggestion! | 11:25 |
| t1mp | rpadovani: that's for the auto-detection, but you don't need that if you set Page.flickable to your listview | 11:27 |
| mihir | i'll need to test then when i go back home. | 11:28 |
| mihir | akiva-thinkpad: ^^ | 11:28 |
| === simion314_ is now known as simion314 | ||
| * dpm lunches | 12:04 | |
| === _salem is now known as salem_ | ||
| seb128 | nik90, thanks, commented, looks good to me (though the pot update doesn't seem useful) | 12:25 |
| nik90 | seb128: it seems that every time i test on a device or build a click, the pot file is automatically updated even with no string change | 12:26 |
| nik90 | seb128: and I accidentally committed it the first time | 12:26 |
| nik90 | seb128: shall I revert it | 12:26 |
| seb128 | nik90, your call, it doesn't hurty | 12:26 |
| om26er | nik90, Hi! do you know where does the calculator app saves its history ? | 12:34 |
| nik90 | om26er: tbh I am not sure, it should most likely be in .local/share/com.ubuntu.calculator ? | 12:35 |
| nik90 | rpadovani: do you know ^^ ? | 12:35 |
| seb128 | speaking of which, wasn't the history notes supposed to be cleared out? | 12:35 |
| om26er | nik90, that seems like it. | 12:36 |
| nik90 | om26er: I just checked as well on my emulator. that's the location. | 12:36 |
| nik90 | seb128: I heard that...not sure who is working on that | 12:37 |
| nik90 | afaik all calc devs were moved to other projects | 12:37 |
| seb128 | nik90, well, there is https://code.launchpad.net/~rpadovani/ubuntu-calculator-app/1365564/+merge/233400 pending for a while | 12:38 |
| seb128 | popey, ^ do you know what's the status there? | 12:38 |
| nik90 | hmm looks like it is waiting on design review | 12:39 |
| m-b-o1 | dpm: hi! Have you found time to have a look at the weather app and the CMAKE rules? | 12:40 |
| akiva-thinkpad | popey, http://i.imgur.com/NilzBui.png :) I got "Up" working nicely, as well as the toolbar in the header. Now I'm just working on getting the other components in. | 12:41 |
| rpadovani | seb128, yes, popey said we need a design review on that package. Anyway, calc was set as 'stable', so I moved to other projects | 12:51 |
| nik90 | seb128: btw do you need the bug 1381429 fix to be pushed to the store today or can this wait? We just released a new clock yesterday and since then this is the only new commit that landed,. | 12:51 |
| ubot5 | bug 1381429 in Ubuntu Clock App "Shouldn't code button's geometry, but rather let it adapt to the label" [Low,Fix committed] https://launchpad.net/bugs/1381429 | 12:52 |
| seb128 | nik90, that can wait, it's looking slightly odd but not blocking anything | 12:52 |
| seb128 | the button works, the label is just truncated | 12:52 |
| nik90 | ah ok | 12:52 |
| seb128 | nik90, but feel free to fix some other bugs and do another upload ;-) | 12:52 |
| nik90 | ;) | 12:53 |
| dpm | hi m-b-o1 o/, unfortunately, I haven't. Perhaps this evening. But I want to have a look at your MP fixing the mobile links first, which I've not had the chance to look at in detail yet, but I'd still want to try to get in by tomorrow | 12:53 |
| m-b-o1 | dpm ok! | 12:54 |
| dpm | m-b-o1, quick question: I see you've got a few if/elses depending on the language code. What about the other languages that are not covered by the ifs? | 12:54 |
| dpm | I mean on the mobile links merge proposal | 12:54 |
| m-b-o1 | dpm: there was an excel sheet (or csv) from TWC, with all the links | 12:55 |
| m-b-o1 | and the domains | 12:55 |
| m-b-o1 | dpm: so only the domains from the excel sheet were implemented. Some urls-schemes in some domains are different on desktop/mobile. I've checked all links in the script | 12:56 |
| m-b-o1 | and corected them for mobile if neccessary | 12:56 |
| === rmescandon is now known as rmescandon-lunch | ||
| dpm | m-b-o1, hm, I can't recall that excel sheet, do you have it handy? | 13:01 |
| dpm | mihir, does calendar work for you on the latest ubuntu-rtm/devel-proposed image? It crashes for me on startup | 13:03 |
| dpm | It seems related to qmlscene, by looking at the logs | 13:03 |
| dpm | actually, it doesn't crash on startup, but after having started and changing to day view | 13:04 |
| m-b-o1 | dpm: you'll have a mail in a few seconds | 13:04 |
| dpm | awesome, thanks m-b-o1! | 13:04 |
| nik90 | popey, gventuri: Hey, does this splash screen for clock look okay https://imgur.com/YhMeHKv ? | 13:09 |
| nik90 | popey, gventuri: I didn't add a header since clock doesn't have one, so I changed the background color for now. | 13:09 |
| nik90 | it makes the startup transition less jarring | 13:10 |
| dpm | m-b-o1, thanks for the e-mail, I had completely forgotten that spreadsheet, I should add it to a blueprint or to the wiki | 13:10 |
| dpm | m-b-o1, do you think perhaps putting the per-language urls in a JSON file or an array and using that as a sort of lookup table might make more sense than using if/elses? | 13:12 |
| m-b-o1 | dpm: yes, probably. on the other hand the code wasn't modified a lot since we added it | 13:20 |
| m-b-o1 | dpm: but yes, a data structure would be more efficient | 13:21 |
| dpm | m-b-o1, what would you suggest, to approve as it is to minimize changes and then look at using a data structure later? | 13:22 |
| m-b-o1 | dpm: yes, I would suggest that. Redesign still looming | 13:23 |
| dpm | m-b-o1, ok, cool, thanks a lot for the discussion | 13:23 |
| m-b-o1 | dpm: looming perhaps the wrong word ;) | 13:23 |
| dpm | hahaha | 13:23 |
| dpm | brace yourselves... | 13:23 |
| m-b-o1 | dpm :)) | 13:24 |
| === rmescandon-lunch is now known as rmescandon | ||
| === karni is now known as karni-afk | ||
| akiva-thinkpad | Yes \o/ I got it working the way I want :DDDDD | 13:38 |
| * akiva-thinkpad celebrates programming victory. Its okay if you don't understand | 13:39 | |
| === karni-afk is now known as karni | ||
| gventuri | nik90: it works for me | 14:15 |
| akiva-thinkpad | hey anyone know if head.actions can do popovers? I am getting a qquickitem not being a qobject error | 14:22 |
| mzanetti | dpm: meeting? | 14:31 |
| === gatox is now known as gatox_lunch | ||
| mzanetti | dpm: that's what I call a productive meeting :) | 14:54 |
| dpm | mzanetti, indeed, Argentinian team ftw! | 14:54 |
| rpadovani | :-) | 14:55 |
| fdassdff | Is there a way to try out Dekko on the desktop? It's not in the desktop PPA AFAIK | 15:14 |
| === rmescandon is now known as rmescandon-brb | ||
| === gatox_lunch is now known as gatox | ||
| mihir | akiva-thinkpad: ping | 15:54 |
| mihir | akiva-thinkpad: were you able to resolve the issues? | 15:54 |
| akiva-thinkpad | mihir, pong | 15:54 |
| akiva-thinkpad | mihir, on the calendar? | 15:54 |
| mihir | akiva-thinkpad: yup | 15:54 |
| akiva-thinkpad | mihir, didnt try much. As said; I ran the tests on trunk, and they failed | 15:55 |
| akiva-thinkpad | so I don't know why they are passing for you. | 15:55 |
| mihir | akiva-thinkpad: hmmm..:| | 15:55 |
| akiva-thinkpad | mihir, yep; thats been a lot of what I have been doing | 15:55 |
| akiva-thinkpad | :P | 15:55 |
| mihir | akiva-thinkpad: i'll try and update you. | 15:56 |
| akiva-thinkpad | mihir, atm I am working on the filemanager app. I'm pretty proud with what Ive accomplished thus far. | 15:56 |
| === rmescandon-brb is now known as rmescandon | ||
| akiva-thinkpad | mihir, https://code.launchpad.net/~akiva/ubuntu-filemanager-app/1380575+1373346-toolbar-to-header/+merge/238470 :) | 16:03 |
| mihir | akiva-thinkpad: great :) | 16:04 |
| akiva-thinkpad | popey, dpm -- would you mind taking a look at the design here, and letting me know what needs to be tweaked? This addresses the two high importance bugs you touched upon the other day. | 16:04 |
| akiva-thinkpad | https://code.launchpad.net/~akiva/ubuntu-filemanager-app/1380575+1373346-toolbar-to-header/+merge/238470 | 16:04 |
| dpm | akiva-thinkpad, sure, looking | 16:05 |
| akiva-thinkpad | Considering that I took out the bottom toolbar to address these, the jenkins tests will break | 16:05 |
| akiva-thinkpad | thanks! | 16:05 |
| akiva-thinkpad | ahayzen, o/ | 16:05 |
| dpm | akiva-thinkpad, do you think you could create a couple of screenshots and add the links to the description? It might be easier for them if we manage to find someone from design to have a look at them | 16:06 |
| akiva-thinkpad | yah | 16:07 |
| akiva-thinkpad | will do that right now | 16:07 |
| akiva-thinkpad | dpm, can a short video suffice? | 16:07 |
| dpm | akiva-thinkpad, wow, suffice? that would be even better! :-) | 16:07 |
| akiva-thinkpad | lol :) | 16:07 |
| akiva-thinkpad | dpm, I havnt tested it on a device; I am having library problems with libtag | 16:08 |
| dpm | akiva-thinkpad, from the emulator would work equally well. What's the problem with libtag on a device? have you installed libtag-dev:armhf on the phone click chroot? | 16:09 |
| akiva-thinkpad | dpm, I tried going into phablet shell, and sudo apt-getting it | 16:22 |
| akiva-thinkpad | although i didn't append :armhf | 16:22 |
| akiva-thinkpad | i'll try that I suppose | 16:22 |
| dpm | akiva-thinkpad, you don't need it on the device | 16:22 |
| dpm | akiva-thinkpad, you only need to install it on the click chroot at build time | 16:23 |
| dpm | akiva-thinkpad, but yeah, remember to append the :armhf | 16:23 |
| akiva-thinkpad | dpm, ah so I need to go into Projects to do that | 16:23 |
| akiva-thinkpad | got it | 16:23 |
| dpm | akiva-thinkpad, yes, how did you build the app? Did you use Qt Creator? | 16:23 |
| akiva-thinkpad | dpm, yah; | 16:23 |
| akiva-thinkpad | i'll toss it in as an instruction | 16:24 |
| dpm | akiva-thinkpad, there's a README file in the file manager sources that explains everything in detail | 16:24 |
| * akiva-thinkpad is a bit new at modding that. | 16:24 | |
| akiva-thinkpad | dpm okay I'll read it now then | 16:24 |
| akiva-thinkpad | dpm, did you try the branch btw? :) | 16:24 |
| akiva-thinkpad | the one thing I didnt put in there that I wanted, was memory of child directories | 16:25 |
| dpm | akiva-thinkpad, I've not had the chance yet, but I'm really looking forward to this change :) | 16:25 |
| dpm | I'll see if I can do it this evening | 16:25 |
| dpm | akiva-thinkpad, http://bazaar.launchpad.net/~ubuntu-filemanager-dev/ubuntu-filemanager-app/trunk/view/head:/README | 16:25 |
| akiva-thinkpad | dpm, okay I'll show you a video | 16:25 |
| akiva-thinkpad | :P | 16:25 |
| akiva-thinkpad | sec | 16:25 |
| dpm | :-) | 16:25 |
| akiva-thinkpad | dpm, popey mihir http://filebin.ca/1dpmqZc83f51/Cast-_00006.mp4 | 16:32 |
| === randomcpp is now known as gcollura | ||
| dpm | akiva-thinkpad, that looks really awesome! I've done a quick, non-code review of the UI and added some comments | 16:43 |
| akiva-thinkpad | dpm, thanks | 16:44 |
| akiva-thinkpad | ahayzen, bah, vic rejected my proposal >:/ | 16:44 |
| ahayzen | akiva-thinkpad, :/ | 16:44 |
| ahayzen | akiva-thinkpad, probably best to come back to it when we start focussing on tablet/desktop | 16:45 |
| akiva-thinkpad | huh... The only issue I am trying to fix are the bloody deprecated tests | 16:45 |
| akiva-thinkpad | ahayzen, meh; I think I just left a bad impression on vic or something. Oh well~ | 16:48 |
| ahayzen | akiva-thinkpad, hah i'll see if i can figure out the tests later :/ the problem is we have a tight deadline for getting the mobile app done so we are pretty focused on that | 16:49 |
| akiva-thinkpad | ahayzen, my complaint that is his code reviews were shoddy. For example; He told me the text for the times was too large, but when I showed him the spec, it clearly showed that the text was not "small". | 16:51 |
| akiva-thinkpad | and when I brought it up, he didnt bother responding. | 16:51 |
| ahayzen | akiva-thinkpad, yeah sorry about that, that spec in particular was tricky to interpret as the height of it was larger than a device | 16:51 |
| akiva-thinkpad | blah; okay well; i'm gonna be bugged about it. No avoiding that. Okay I'm just going to drop out of it. I'll cool down eventually, and I understand that he has good intentions... But I'm sure you can understand how I feel. | 16:54 |
| akiva-thinkpad | ahayzen, anyways, good luck with the deadline. Wish I could have been of more help. | 16:54 |
| ahayzen | akiva-thinkpad, yeah i know how you feel, its difficult to get reviews past him sometimes ;) Once we get onto the tablet/desktop designs (hopefully soon) it should all calm down a bit | 16:55 |
| mihir_ | seb128, you around ? | 17:00 |
| akiva-thinkpad | ahayzen, Do you think if I can get jenkins to approve my branch, he'll come around? | 17:01 |
| akiva-thinkpad | or should I not bother? | 17:01 |
| ahayzen | akiva-thinkpad, maybe i don't know | 17:01 |
| akiva-thinkpad | okay fair enough. | 17:01 |
| mihir_ | dpm, popey anyone can do review for this MR - > https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/updatePotFiles/+merge/238479 | 17:02 |
| mihir_ | it is just pot file update. | 17:02 |
| ahayzen | akiva-thinkpad, i mean it should just be a matter of putting the objectName on the slider or something? | 17:02 |
| akiva-thinkpad | ahayzen, slider does not have the objectname property | 17:02 |
| ahayzen | akiva-thinkpad, yeah but it...did? | 17:03 |
| * ahayzen looks at diff | 17:03 | |
| ahayzen | akiva-thinkpad, yeah before it had objectName: "progressSliderShape" | 17:03 |
| akiva-thinkpad | ahayzen, but that was when the slider was manually built | 17:03 |
| ahayzen | akiva-thinkpad, try putting the test code back for seek_to and adding objectName: "progressSliderShape" to your new slider object | 17:03 |
| akiva-thinkpad | I tried changing it to that, but no potato. | 17:03 |
| akiva-thinkpad | i'll try again I suppose. | 17:03 |
| ahayzen | akiva-thinkpad, which revision did you try that at? | 17:04 |
| akiva-thinkpad | a few back, before I took out the code. It was today though. | 17:04 |
| akiva-thinkpad | progressSliderShape refers to the square that slides along the slider | 17:04 |
| akiva-thinkpad | ahayzen, so I need to reference that specific part of the slider, which I have no idea how to do now that it is a self contained component. | 17:05 |
| akiva-thinkpad | before it was a square rect sitting on a bunch of other rects, and they all had object names. | 17:05 |
| ahayzen | akiva-thinkpad, but trunk uses a Slider {} now? | 17:06 |
| ahayzen | akiva-thinkpad, you should be able to add objectName: "progressSliderShape" ... to the object id: progressSliderMusic...and then restore the tests | 17:06 |
| akiva-thinkpad | ahayzen, yah you are on to something. I'll have to check again. | 17:06 |
| akiva-thinkpad | ahayzen, well anyways I'll look at it tomorrow. | 17:11 |
| ahayzen | akiva-thinkpad, cool sorry for this being such a mess :( | 17:12 |
| akiva-thinkpad | ahayzen, is there a set date for the rtm yet? | 17:12 |
| ahayzen | akiva-thinkpad, idk 'soon' aha | 17:12 |
| akiva-thinkpad | ahayzen, its not your fault. I only really learned how to deal with tests today, so there is a lot of merit to what he is saying. | 17:12 |
| dpm | mihir_, reviewed, thanks! | 17:15 |
| === randomcpp is now known as gcollura | ||
| mihir | akiva-thinkpad: trunk should be an issue, it just passed mine though | 17:31 |
| * mihir looks at dpm comment | 17:32 | |
| akiva-thinkpad | mihir, okay well now that I have a bit better grasp on tests, I'll take a look at this tomorrow. | 17:32 |
| mihir | akiva-thinkpad: excellent | 17:32 |
| akiva-thinkpad | thanks again for walking me through it. | 17:32 |
| mihir | dpm: I'll propose new MP for that changes , is that fine ? | 17:33 |
| dpm | mihir, I'd do at least the one for plural forms and the color key (first and last inline comments) in the same MP, as we shouldn't update the .pot file without those fixed | 17:34 |
| dpm | the rest can go in a separate MP if you prefer | 17:34 |
| mihir_ | dpm, pushed pot file changes. i am about to push MP for translators comment. | 17:38 |
| mihir_ | dpm, thanks for reviewing. | 17:38 |
| mihir_ | dpm, regarding plural i am looking into it, i guess we got code change that's why. | 17:42 |
| dpm | thanks mihir_ | 17:48 |
| mihir_ | dpm, i am planning to add Translator comments in same MP , is that fine ? | 17:48 |
| dpm | ogra_, seb128, what's required to do to add a package to the rtm archive? I.e. I'm trying to add the Catalan keyboard layout, which depends on myspell-ca, but that package is only on the ubuntu archive, but not on rtm | 17:49 |
| dpm | mihir_ let me re-look at the MP in a minute | 17:50 |
| ogra_ | dpm, we usually channel sync requests through cjwatson for such stuff | 17:50 |
| ogra_ | (but he is gone ... not sure if for the day or if he'll return) | 17:50 |
| dpm | ogra_, thanks, I'll ping him tomorrow morning | 17:51 |
| ogra_ | dpm, that wont make the milestone image then though | 17:51 |
| ogra_ | (but not seeing your keyboard change in a silo i assume the keyboard wont either i guess) | 17:52 |
| dpm | ogra_, yeah, I know, it's too tight for the keyboard layout to make it in anyway | 17:52 |
| ogra_ | k | 17:52 |
| dpm | but I just want to get it done. I've been working on it on my ample spare time, and I didn't manage to finish it until last night :) | 17:53 |
| mihir | dpm: hmmm no issues :) | 17:55 |
| mihir_ | popey, you around ? | 18:02 |
| nik90 | popey: can you review and approve https://code.launchpad.net/~nik90/ubuntu-clock-app/customize-splash/+merge/238484. Seems like you proposed custom splash screen for quite a number of apps ;) | 18:28 |
| nik90 | popey: it has been design approved | 18:29 |
| popey | \o/ | 18:31 |
| popey | done | 18:32 |
| nik90 | thnx :) | 18:37 |
| === tvoss is now known as tvoss|test | ||
| mihir_ | popey, most of the critical / High bugs are fixed on Calendar :D | 18:44 |
| === irv_ is now known as irv | ||
| popey | mihir_: \o/ | 18:56 |
| nik90 | Is it worth to call a reduction of 3.5ms of an item used as a delegate throughout the clock app a performance improvement :P ? | 19:01 |
| mihir | popey: could you review trivial MR , https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/MissingTranslators/+merge/238488 ? | 19:04 |
| mihir | popey: have added translator comments . | 19:04 |
| popey | done | 19:05 |
| seb128 | mihir, you around | 19:48 |
| rpadovani | nik90, hey, where you think I should report a bug about ListItemWithActions? | 19:53 |
| nik90 | rpadovani: well its a custom component written by renatu, so he would be the best person to talk to | 19:53 |
| rpadovani | and so renatu, this is a ping :-) | 19:53 |
| rpadovani | thanks nik90! | 19:53 |
| nik90 | yw | 19:54 |
| renatu | rpadovani, you can report against the address-book-app | 19:54 |
| rpadovani | renatu, thanks | 19:54 |
| nik90 | rpadovani: btw I presume you took the ListItemWithActions from addressbook and not clock? | 19:54 |
| * nik90 hopes the former | 19:54 | |
| rpadovani | nik90, sure | 19:54 |
| nik90 | cool | 19:54 |
| rpadovani | renatu, bug 1381723 | 19:57 |
| ubot5 | bug 1381723 in address-book-app "[ListItemWithActions]After the swipe of an element I expect to press anywhere to dismiss" [Undecided,New] https://launchpad.net/bugs/1381723 | 19:57 |
| === randomcpp is now known as gcollura | ||
| renatu | rpadovani, I can not reproduce this bug | 20:40 |
| renatu | rpadovani, I tried on address-book, dialer, messaging and clock app | 20:42 |
| renatu | all apps is working fine | 20:42 |
| rpadovani | renatu, I'm able to reproduce on them all, rtm on mako | 20:42 |
| renatu | rpadovani, ok let me flash my mako | 20:43 |
| renatu | rpadovani, ok now I understand | 20:44 |
| renatu | rpadovani, you want to tap anywhere in the screen | 20:44 |
| renatu | yes this is not implemented | 20:44 |
| rpadovani | renatu, yap, that is. Sorry for bad english :/ | 20:44 |
| renatu | and using a inverse mouse are can be dangerous. | 20:44 |
| renatu | and I am not sure if the designers want that | 20:45 |
| nik90 | rpadovani: hey, I got a really easy MP for you -> https://code.launchpad.net/~nik90/ubuntu-clock-app/replace-base-list-items/+merge/238502 | 21:11 |
| nik90 | rpadovani: basically replaces ListItem.Base with ListItem.Empty | 21:11 |
| vitimiti | Hi | 21:36 |
| rpadovani | nik90, approved but... you definitely need to take a look to http://qt-project.org/doc/qt-5/qml-qtquick-layouts-layout.html to drop all that anchors, we use it in reminders delegates and it's awesome (thanks mzanetti :D) | 21:47 |
| rpadovani | nik90, https://bazaar.launchpad.net/~reminders-app-dev/reminders-app/trunk/view/head:/src/app/qml/components/NotebooksDelegate.qml | 21:50 |
| nik90 | rpadovani: ah yes, I know about it. I will use it in the next MP | 22:11 |
| rpadovani | \o/ | 22:12 |
| === salem_ is now known as _salem | ||
| * vitimiti Bye | 22:51 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
