=== urulama__ is now known as urulama
=== urulama is now known as urulama___
=== dimitern is now known as dimitern_afk
hazmatdo we release updated charms for both trusty and precise?13:36
hazmatre gui13:36
rick_h_hazmat: we have been yes13:36
rick_h_http://bazaar.launchpad.net/~juju-gui-charmers/charms/precise/juju-gui/trunk/revision/100 1.2.2 GUI13:37
hatchman the gui is stable14:49
hatchI haven't come across a single unknown bug14:49
hatch(unknown being the key word there)14:50
hatchalthough Makyo I still from time-to-time get the services bouncing all over on deploy - it appears to be related to dragging at a specific point during the deploy cycle but I can't reproduce it reliably 14:51
rick_h_kadams54: hatch how we doing for releasing today? I looked at kadam's branch but the card is in coding still?14:52
kadams54I'm prepping an update on that PR that will take it out of WIP status.14:52
rick_h_kadams54: ok cool14:53
hatchyeah we should probably do a follow-up bug fix release after this one for some of those known bugs14:58
kadams54hatch, rick_h_: https://github.com/juju/juju-gui/pull/63116:08
rick_h_kadams54: ty looking in a min16:11
hatchkadams54: on it16:11
hatchkadams54: ok reviews done- mind taking a look16:24
kadams54Yeah, I looked through them. I've got a 12:30 lunch appointment here, but I'll reply in the PR.16:27
rick_h_kadams54: review done16:33
rick_h_hatch: you've got the steps then to integrate enough to QA?16:33
hatchrick_h_: yeah I'll take this work to make sure my branch works as expected - I've made a bunch of comments but it should work as expected as is then we can revisit these changes later if needed16:34
rick_h_hatch: ok cool16:35
rick_h_hatch: let me know if you need a hand 16:35
hatchI just need to find all the rules again16:37
hatchheh the interactions are complex lol16:37
hatchI replied to the angular thread :) Wrote the email at like 2am forgot to send it16:38
rick_h_hatch: :)16:38
rick_h_hatch: don't see it yet booo16:39
hatchit's long.....real long16:40
hatchmight take time go through the internets16:40
rick_h_I'll read it over lunch then :)16:40
hatchwell how do you systematically destroy angular in a short email....like c'mon16:41
hatchholy crap it works16:42
hatchwell the mv is broken....but holy crap the canvas stuff works16:43
* hatch needs a moment16:43
hatchok yeah the qa is not good wrt the mv stuff and one bug on the canvas stuff which might be related to the data being sent from this branch16:47
hatchok I found one pre-existing bug16:55
hatchI'll hop on that16:55
rick_h_hatch: cool ty17:00
rick_h_and yay 17:00
hatchI've added the qa issues to the PR17:01
hatchand created a card for the bug I'm on17:01
hatchkadams54: thanks for the replies - I replied to the one about defaults17:28
=== dimitern_afk is now known as dimitern
kadams54hatch: ping me when you're back, I have a question.18:37
kadams54guihelp: anyone know what's going on here? I set an attribute on a ModelList, but when I ask for the same attribute back, it's not set as expected. http://pastie.org/private/2npre7yetltxg4hvrtalw18:44
rick_h_kadams54: looking18:44
rick_h_kadams54: I'm not sure that's supposed to work tbh18:49
rick_h_kadams54: on using set and it reaching into the models in the list?18:49
rick_h_kadams54: I mean a model can have attrs so not sure how that would work 18:49
kadams54Yeah… that's what hatch seemed to suggest in the PR.18:50
kadams54modelList.set('foo', 'bar') would be equivalent to looping through and doing model.set('foo', 'bar')18:51
rick_h_kadams54: yea, but looking at http://yuilibrary.com/yui/docs/api/classes/ModelList.html#method_set I don't see it. I'd punt on that18:52
rick_h_kadams54: and see if you can figure out the QA issue? 18:52
kadams54Yeah, getting to that.18:52
rick_h_kadams54: and then when hatch gets back I'd like you guys to pair over a hangout and get the bits pulled in together. I'd like to try to have a qa'able branch I can qa at the coffee shop tonioght so tomorrow can be release18:53
tvansteenburghrick_h_: is this is the canonical precise juju-gui -> ~juju-gui-charmers/charms/precise/juju-gui/trunk ?19:04
tvansteenburghthat's the only one i can find19:04
rick_h_tvansteenburgh: yes19:09
rick_h_tvansteenburgh: there's a ~juju-gui which is out dev one19:10
rick_h_doh, which has this change from adam but we hadn't done a release yet so you didn't see it19:11
rick_h_tvansteenburgh: so never mind19:11
rick_h_http://bazaar.launchpad.net/~juju-gui/charms/trusty/juju-gui/trunk/revision/209 tvansteenburgh 19:11
rick_h_tvansteenburgh: we're doing a release this week with the new feature and so hadn't put out the updates from adam, sorry that caused you to dupe them19:12
tvansteenburghactually that one is not quite right19:12
tvansteenburghso i'll send you a merge anyway19:12
rick_h_oh, well then carry on :)19:12
hatchkadams54: yo19:21
kadams54hatch: Hey, digging into your QA issues right now.19:22
kadams54Pushed changes that addressed all your review feedback if you want to look those over.19:23
hatchsure will do19:23
hatchkadams54: looks good - was my memory wrong wrt the .set() on a ML?19:30
rick_h_hatch: looks like it just sets attrs on the ML object19:31
rick_h_hatch: checked out the api but didn't see anything that would do it19:31
hatchhmm darn - wonder what I'm thinking of then19:31
hatchsure seems like something like that should be possible19:32
rick_h_you can .each and .some of a list19:32
rick_h_but I think you're thinking nodelist vs modellist19:32
hatchahhhhh that's it19:32
hatchyes sorry my bad19:32
hatchkadams54: so did you want to pair on that qa debugging?19:45
rick_h_kadams54: hatch you guys settled?19:55
hatchI'm just hammering out a test for my branch - haven't heard back from kadams54 yet19:57
hatchshould have this up shortly19:57
rick_h_kadams54: around? 19:58
kadams54rick_h_, hatch: yup, sorry.20:02
rick_h_kadams54: cool, please get together with hatch to sync up your branches/qa issues and get things pulled together hopefully by EOD if at all possible20:03
kadams54hatch: we have two QA issues. I'm looking at the first. You want to dig into the second?20:04
hatchjujugui looking for a review on a small bug fix https://github.com/juju/juju-gui/pull/63220:05
hatchkadams54: can do - if you don't think they are related?20:05
kadams54No, but don't quote me on that.20:06
hatchheh ok I'll take a look with your most recent updates20:06
rick_h_hatch: kadams54 I'd like you guys to work together please. get a hangout together, and keep in sync so if we need to hatch can carry to his EOD when kadams54 EOD's and such20:06
hatchok can do20:06
kadams54hatch: standup hangout?20:08
hatchrick_h_: #632 is pretty small and easy to qa if you have time20:08
hatchkadams54: yup will join shortly20:08
rick_h_hatch: lookihng20:08
rick_h_hatch: kadams54 going afk until coffee shop time tonight. Please make sure to drop me a note on where we're at for tomorrow at EOD please21:12
hatchrick_h_: hop in standup?21:13
hatchok hopped out21:14
hatchjujugui anyone around able to do another easy review? https://github.com/juju/juju-gui/pull/63221:29
Makyohatch, on it21:30
hatchthanks 21:32
rick_h_hatch: what's up?22:46
hatchso many rules!22:46
hatchI'm trying to fix one last rule22:46
rick_h_hatch: k22:47
hatchthe mv and service view have such different rules that post release this should be refactored a bit22:47
hatchI didn't realize how different they are22:47
rick_h_hatch: did you see the highlight icons from luca as well?22:58
hatchI didn't 22:59
hatchatm I'm just focused on getting this case fixed22:59
hatchwhich is going to require some model updates22:59
rick_h_hatch: :/ what's so different on it? 23:01
hatchermahgerd - well in the service view 'related' services matter23:01
rick_h_hatch: I thought that's what this sync'ing of the state to the service/unit models was for. So that we could show/hide/highlight properly with the model as the single source of truth?23:01
hatchand we update the service model and unit model accordingly23:01
hatchunfortunately the mv doesn't care if anything is related23:01
rick_h_right, but the unit models don't need updating on the service view details23:02
hatchbut the container column AND service view do23:02
hatcher not service view23:02
hatchjust the container column23:02
hatchbut the machine column needs the machine models to be set separately23:02
rick_h_ok, but that can just be rendering differences based on the same model dta?23:02
rick_h_ugh, we can't just handle machine show/hide at render time?23:02
rick_h_if the render() call finds that none of the units are visible, it just never draws?23:03
hatchproblem is that the units use the 'related services' code to mark hidden/visible because that's what it needs for the container column23:03
hatchso we can't rely on that for the machine column23:04
hatchso the machines need their own flag23:04
hatchrick_h_: so I'm going to take a little break now, play some Destiny :) then come back later with a fresh head and get this done23:05
rick_h_hatch: ok, let me know if I can help23:05
rick_h_hatch: just thinking about that, it sounds like what we need is a triple state there. I've been hidden, I'm related to a hidden, and then false23:09
rick_h_hatch: so you can just check that field for more than a true/false and be ok23:09
rick_h_hatch: vs adding new model stuff to machines23:09
rick_h_in a way it's 6 of one, half dozen of another, but wonder if it's a bit simpler that the 'state' is in a single bit of data vs another one23:10

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!