[08:21] tsdgeos, hey, i found weird special casing for favorites in the old manage dash - https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1386698 [08:21] Ubuntu bug 1386698 in unity8 (Ubuntu) "Canned queries to favorited scopes don't preserve search query string" [Undecided,New] [08:22] tsdgeos, i'm not sure if the new one will still be affecting (probably it will, since it's Dash.qml) [08:23] pstolowski: saw it, will have a look [08:23] tsdgeos, this effectively breaks canned queries if it's a favorited scope [08:23] tsdgeos, thanks [08:44] pstolowski: seems ~aacid/unity8/list_on_bottom_swipe fixes that [08:48] tsdgeos, ok, great. let's keep the bug open till it lands and then close it. thanks [09:30] ahhh [09:30] wrong encoding back to the launcher [09:31] or maybe it never left [09:31] i get CA¡mara [09:31] instead of Cámara [09:31] * tsdgeos remembers filling a bug about this [09:34] pete-woods: ping [09:36] wops made unity8 crash [09:38] tsdgeos: hi [09:39] pete-woods: libusermetrics seems to contains lots of translatable stuff that never makes it out to the user? [09:40] tsdgeos: yes. I was too enthusiastic when adding translatable stuff. a bunch of stuff only appears to the command line tools [09:40] tsdgeos: I removed it all for the "new infographics" implementation that has never ended up being used [09:40] i see [09:41] tsdgeos: given the "old infographics" seems not to be going away any time soon, I would like to remove them, but can't land stuff like that because it's not critical / on "the list" [09:43] ok [11:18] vesar: congrats on the award :) [11:24] tsdgeos, thanks! yeah it was a nice surprise:) [11:26] vesar, not a surprise at all :) === _salem is now known as salem_ [11:39] tsdgeos, replied in https://code.launchpad.net/~saviq/unity8/revert-resolution-flickable/+merge/239354 [11:42] ok === MacSlow is now known as MacSlow|lunch [11:44] weird lp :/ [11:56] Saviq: approved, what are we missing for "the landing"? [11:56] tsdgeos, nothing, afaict [11:56] tsdgeos, I'm re-targeting to vivid now [12:07] Saviq: ah, rtm 15 finally landed? [12:08] cwayne, no, needed to retarget to vivid [12:08] cwayne, but am landing today [12:09] Saviq: wait so it wont land in rtm? [12:09] or is it going to be synced [12:09] cwayne, it will, but after a syc [12:09] sync [12:09] cwayne, just need to land it in vivid first [12:14] right, ok [12:20] Hey folks, if you have time, I have a branch targeted for 10/30 that needs a tiny review: https://code.launchpad.net/~mterry/unity8/expose-lockscreen-passphrase/+merge/239364 [12:21] @unity ^ [12:23] mterry, acked [12:24] Saviq, thanks! === _salem is now known as salem_ === MacSlow|lunch is now known as MacSlow === dandrader is now known as dandrader|afk [13:03] tsdgeos, hey there... any news on the review for https://code.launchpad.net/~macslow/unity8/swipe-to-act-fix-1358343/+merge/236091 ? === dandrader|afk is now known as dandrader [13:35] dandrader, mind to review https://code.launchpad.net/~macslow/unity-notifications/swipe-to-act-fix-1358343/+merge/238956 [13:37] MacSlow, ok [13:37] dandrader, thanks! [13:45] MacSlow, hey in the modal-snap-decision-on-greeter... do you know why we had the explicit !greeter.shown bit? Seems like we at one point wanted this behavior [13:46] tsdgeos, would you have time to have a look at bug #1386653? [13:46] bug 1386653 in unity8 (Ubuntu) "Scopes fail to launch when the network stack is not up" [Undecided,Confirmed] https://launchpad.net/bugs/1386653 [13:47] mterry, first Design wanted the snap-decisions not to be modal on the greeter... now they want it to, because of "grab out of pocket"-issues. [13:47] MacSlow, ok so just a design reversal -- are there other snap decisions that we are affecting, besides the call? [13:48] mterry, no... the motivating use-case for this change is the incoming-call snap-decision notification [13:48] MacSlow, right. I was just trying to see if there were other maybe-modal snap-decisions that would be affected by this change [13:48] mterry, I mean it will affect all snap-decisions of course, but that's not really a problem [13:49] MacSlow, right, I just didn't know which were common ones and if there were any that we really wanted to not be modal. But I can't think of one [13:50] mterry, I think initially the reason for having snap-decision notifications not being modal on greeter/lockscreen was to still provide access to the emergency-call [13:52] MacSlow, ah interesting. But users can just dismiss and then call, right? [13:52] mterry, sure [13:52] mterry, although the general "swipe-to-dismiss" is still idling in an MP [13:56] MacSlow: didn't i review it? damn [13:57] i do remember reading that code a lot :D [13:57] tsdgeos, nope... atleast nothing marked on the MP itself... I knowthat you looked at it in Washington [13:59] dandrader: i can do it if you want, i had a long look at it already, actually on my mind i had approved it :D [14:00] tsdgeos, oh, awesome. have at it! :) [14:01] tsdgeos, reassigned the review to you [14:03] Saviq: depends on whether we're happy with the photoscope fixes or not [14:04] Saviq: i find there's something weird going on, but looks like a more deep qtquick thing, i.e. i can scroll mostly fine and then it just gets slow at some "random point" [14:05] tsdgeos, 'stood, if you want to spend more time on this, do [14:06] Saviq: i'm trying to find something, at least today [14:06] MacSlow, approved the modal-snap-decisions branch, do you need to get it on a spreadsheet? [14:06] Saviq, ^? [14:07] tsdgeos, kk [14:07] (https://code.launchpad.net/~macslow/unity8/modal-snap-decision-on-greeter-fix-1378827/+merge/239376) [14:07] MacSlow, mterry, adding [14:07] mterry, Saviq: thanks! [14:12] thanks Saviq:) [14:18] Saviq, did you already select a silo for the next batch of unity8 MPs? [14:18] MacSlow, vivid silo 5 [14:19] Saviq, ah found it thx [14:26] MacSlow: why the "import QtMultimedia 5.0" in tst_SwipeToAct.qml ? [14:27] tsdgeos, hm... that looks like a copy&paste error... let me check... [14:30] MacSlow: so as i understand it, every Notification now will have a SwipeToAct just not visible unless it's x-canonical-snap-decisions-swipe, right? Wouldn't it be better to put it in a loader so that it saves some cycles? [14:31] Saviq: not sure if asking for a microptimization here ↑ [14:31] tsdgeos, makes sense, yeah, we should switch between normal buttons and swipe to act idealy [14:31] +l [14:32] tsdgeos, isn't visible: false enough (thinking back to what Gerry told us at the sprint)?! [14:32] MacSlow: no [14:32] MacSlow, CPU cycles [14:32] MacSlow: the component still needs to be created [14:32] MacSlow, it will still get created etc., just won't be put on the GPU [14:32] and then is just not painted [14:32] or on the scenegraph, that is, even [14:33] tsdgeos, Saviq: ok I'll look into chaning it to use a Loader [14:33] good, will comment on MR === charles_ is now known as charles [14:45] tsdgeos, made Loader and import changes... rev1311 [14:48] MacSlow: maybe use the active property instead of shuffling sourcecompoent? [14:49] tsdgeos, not sure what you mean [14:49] MacSlow: use the active property to enable or not the loader [14:49] instead of changing the sourceComponent property [14:50] tsdgeos, ok [14:50] MacSlow: that way you don't even need the Component wrapper [14:51] i think [14:51] :D [14:51] let me check [14:51] outch... that messes up things [14:53] tsdgeos, I don't think I can get around Component and sourceComponent [14:53] why not? [14:54] MacSlow: http://paste.ubuntu.com/8733937/ [14:54] no? [14:55] tsdgeos, ah... didn't try it like that when using the active-property... works now... [14:55] just doing few more of the tests to be sure [14:56] MacSlow: you should also change this [14:56] MacSlow: http://paste.ubuntu.com/8733964/ [14:56] i.e. [14:57] http://paste.ubuntu.com/8733966/ [15:00] tsdgeos, tested and pushed [15:01] MacSlow: you need to remove visible: !notifySwipeButton.visible [15:01] there's no such thing as notifySwipeButton [15:01] anymore [15:02] and the loader active handles that now [15:04] tsdgeos, done [15:06] MacSlow: last thing is, you should not remove the import "../Components/Flickables" as Flickables and comboList: Flickables.Flickable { [15:06] that's has nothing to do with your MR [15:06] and is being handled in a separate MR globally [15:06] besides that it looks good [15:06] tsdgeos, hm... I got errors for that last week so I removed it [15:07] please don't [15:07] or tell me which errors you have [15:07] tsdgeos, ok... I readd that line [15:07] because i don't see how this could have errors [15:10] tsdgeos, hm... works without issues now with that Flickables import re-added [15:10] tsdgeos, pushed that change too [15:15] MacSlow: and comboList: Flickables.Flickable { too please [15:16] please don't use Flickables any more [15:16] they go away in the next landing anyway [15:17] Saviq: i'm just making it so that it doesn't conflict with your next landing [15:17] it's existitng code he should not change in his MR [15:17] tsdgeos, oh ok, just noticed Flickables [15:18] tsdgeos, ok... changed that too [15:19] mzanetti, does that make sense to you http://paste.ubuntu.com/8734196/ [15:19] Saviq, tsdgeos: so I reverted the whole Flickable-relates parts [15:19] mzanetti, I noticed that the dash was showing up when doing the rotation, because it was behind the focused app and not being hidden [15:19] MacSlow, yeah, that's gonna happen in my MP, if you wanted in on that, you should've based on my branch and made it prerequisite [15:20] Saviq, I got errors last week so I chagned it in my branch... since it all fine now, I guess there were some package-update issues inbetween [15:24] dandrader: yeah... if I read it correctly it should be ok. didn't test it though [15:29] tsdgeos, top-approve too? [15:29] MacSlow: see comment :) [15:30] MacSlow: i want CI to run again === alan_g is now known as alan_g|tea [15:30] tsdgeos, my firefox keeps acting up today... probably my ISP really [15:31] tsdgeos, I saw the "Approve" mark... but not your comment [15:32] ok === alan_g|tea is now known as alan_g === dandrader is now known as dandrader|lunch [15:47] Saviq: what's up with https://code.launchpad.net/~unity-team/unity8/fix-1333187/+merge/239990 ? [15:48] Saviq: do i need to approve again? what's the changes? [15:48] tsdgeos, needed to resubmit on top of my revert [15:48] tsdgeos, I'll take care [15:48] ok [16:12] Saviq: so we have a patchset for the dbus bugs larsu and ryan found [16:13] Saviq: any idea how to proceed, i don't think i am good enough for reviewing them [16:13] by other than integrate them and make sure things don't go wrong [16:26] tsdgeos, what projects do they touch? [16:26] Saviq: qtcore [16:26] well [16:27] qtdbus === dandrader|lunch is now known as dandrader [16:27] tsdgeos, accepted upstream? [16:27] upstream wants me to review ^_^ [16:27] https://codereview.qt-project.org/#/c/98353/ https://codereview.qt-project.org/#/c/98354/ https://codereview.qt-project.org/#/c/98355/ [16:28] tsdgeos, means you're good enough for them, you're sure good enough for me [16:29] tsdgeos, if you want a second pair of eyes, tvoss should know... he did write dbus-cpp after all ;) [16:30] Saviq, one more for the silo 5 -> https://code.launchpad.net/~macslow/unity-notifications/swipe-to-act-fix-1358343/+merge/238956 [16:30] MacSlow, can it wait for the next silo? [16:31] Saviq, hm... it should at least to with https://code.launchpad.net/~macslow/unity8/swipe-to-act-fix-1358343/+merge/236091 [16:31] Saviq, although that still needs top-approval from tsdgeos [16:31] MacSlow, yeah, that's fine [16:31] MacSlow, next time then [16:32] next one should be smaller/easier hopefully [16:32] Saviq, and then it would be nice to have these two, https://code.launchpad.net/~macslow/unity8/modal-snap-decision-on-greeter-fix-1378827/+merge/239376 and https://code.launchpad.net/~tiagosh/telephony-service/swipe-to-answer/+merge/239983 all in one silo [16:33] MacSlow, sures [16:33] Saviq, as they all relate to addressing the incoming-call use-case [16:33] MacSlow, works for me, we could start building a silo already [16:33] Saviq, do you want that in an email for reference? [16:33] MacSlow, no, I've got the logs [16:34] ok [16:34] MacSlow, let's do that tomorrow morning, either it's going to be after the unity8 landing or we'll have it for testing for design ACK [16:34] Saviq, ok... that works forme [16:49] Saviq: any idea why no dbgsym package of qtdeclarative5-ubuntu-ui-toolkit-plugin ? [16:49] i thought we had of them all? [16:53] tsdgeos, let me have a look at the build [16:53] tsdgeos, that's vivid? [16:53] Saviq: yes [16:55] tsdgeos, http://ddebs.ubuntu.com/pool/universe/u/ubuntu-ui-toolkit/ any of these? [16:55] i guess the first [16:55] the name is just ifferent to make it harder? [16:56] ah no it's the same name [16:56] tsdgeos, is it different? [16:56] :S [16:56] tsdgeos, what I *think* might've happened [16:56] tsdgeos, that package wasn't built for vivid yet [16:56] tsdgeos, so it's only indexed for utopic still [16:56] ah [16:56] ok [16:58] there's some trackes of the toolkit in a bindign loop i get [16:58] will have to compile the toolkit with debug myself tomorrow then [17:04] tsdgeos, no no, you can get that package [17:04] tsdgeos, it's the same binary that's in vivid [17:04] ah [17:04] right [17:04] tsdgeos, it's just not tracked in the vivid dbgsyms repo [17:04] tsdgeos, but anyway, tomorrow, have a good evening [17:05] * tsdgeos waves === artmello_ is now known as artmello === Malsasa_ is now known as Malsasa === salem_ is now known as _salem