[08:21] <pstolowski> tsdgeos, hey, i found weird special casing for favorites in the old manage dash - https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1386698
[08:22] <pstolowski> tsdgeos, i'm not sure if the new one will still be affecting (probably it will, since it's Dash.qml)
[08:23] <tsdgeos> pstolowski: saw it, will have a look
[08:23] <pstolowski> tsdgeos, this effectively breaks canned queries if it's a favorited scope
[08:23] <pstolowski> tsdgeos, thanks
[08:44] <tsdgeos> pstolowski: seems ~aacid/unity8/list_on_bottom_swipe fixes that
[08:48] <pstolowski> tsdgeos, ok, great. let's keep the bug open till it lands and then close it. thanks
[09:30] <tsdgeos> ahhh
[09:30] <tsdgeos> wrong encoding back to the launcher
[09:31] <tsdgeos> or maybe it never left
[09:31] <tsdgeos> i get CA¡mara
[09:31] <tsdgeos> instead of Cámara
[09:31]  * tsdgeos remembers filling a bug about this
[09:34] <tsdgeos> pete-woods: ping
[09:36] <tsdgeos> wops made unity8 crash
[09:38] <pete-woods> tsdgeos: hi
[09:39] <tsdgeos> pete-woods: libusermetrics seems to contains lots of translatable stuff that never makes it out to the user?
[09:40] <pete-woods> tsdgeos: yes. I was too enthusiastic when adding translatable stuff. a bunch of stuff only appears to the command line tools
[09:40] <pete-woods> tsdgeos: I removed it all for the "new infographics" implementation that has never ended up being used
[09:40] <tsdgeos> i see
[09:41] <pete-woods> tsdgeos: given the "old infographics" seems not to be going away any time soon, I would like to remove them, but can't land stuff like that because it's not critical / on "the list"
[09:43] <tsdgeos> ok
[11:18] <tsdgeos> vesar: congrats on the award :)
[11:24] <vesar> tsdgeos, thanks! yeah it was a nice surprise:)
[11:26] <Saviq> vesar, not a surprise at all :)
[11:39] <Saviq> tsdgeos, replied in https://code.launchpad.net/~saviq/unity8/revert-resolution-flickable/+merge/239354
[11:42] <tsdgeos> ok
[11:44] <tsdgeos> weird lp :/
[11:56] <tsdgeos> Saviq: approved, what are we missing for "the landing"?
[11:56] <Saviq> tsdgeos, nothing, afaict
[11:56] <Saviq> tsdgeos, I'm re-targeting to vivid now
[12:07] <cwayne> Saviq: ah, rtm 15 finally landed?
[12:08] <Saviq> cwayne, no, needed to retarget to vivid
[12:08] <Saviq> cwayne, but am landing today
[12:09] <cwayne> Saviq: wait so it wont land in rtm?
[12:09] <cwayne> or is it going to be synced
[12:09] <Saviq> cwayne, it will, but after a syc
[12:09] <Saviq> sync
[12:09] <Saviq> cwayne, just need to land it in vivid first
[12:14] <cwayne> right, ok
[12:20] <mterry> Hey folks, if you have time, I have a branch targeted for 10/30 that needs a tiny review: https://code.launchpad.net/~mterry/unity8/expose-lockscreen-passphrase/+merge/239364
[12:21] <mterry> @unity ^
[12:23] <Saviq> mterry, acked
[12:24] <mterry> Saviq, thanks!
[13:03] <MacSlow> tsdgeos, hey there... any news on the review for https://code.launchpad.net/~macslow/unity8/swipe-to-act-fix-1358343/+merge/236091 ?
[13:35] <MacSlow> dandrader, mind to review https://code.launchpad.net/~macslow/unity-notifications/swipe-to-act-fix-1358343/+merge/238956
[13:37] <dandrader> MacSlow, ok
[13:37] <MacSlow> dandrader, thanks!
[13:45] <mterry> MacSlow, hey in the modal-snap-decision-on-greeter...  do you know why we had the explicit !greeter.shown bit?  Seems like we at one point wanted this behavior
[13:46] <Saviq> tsdgeos, would you have time to have a look at bug #1386653?
[13:47] <MacSlow> mterry, first Design wanted the snap-decisions not to be modal on the greeter... now they want it to, because of "grab out of pocket"-issues.
[13:47] <mterry> MacSlow, ok so just a design reversal -- are there other snap decisions that we are affecting, besides the call?
[13:48] <MacSlow> mterry, no... the motivating use-case for this change is the incoming-call snap-decision notification
[13:48] <mterry> MacSlow, right.  I was just trying to see if there were other maybe-modal snap-decisions that would be affected by this change
[13:48] <MacSlow> mterry, I mean it will affect all snap-decisions of course, but that's not really a problem
[13:49] <mterry> MacSlow, right, I just didn't know which were common ones and if there were any that we really wanted to not be modal.  But I can't think of one
[13:50] <MacSlow> mterry, I think initially the reason for having snap-decision notifications not being modal on greeter/lockscreen was to still provide access to the emergency-call
[13:52] <mterry> MacSlow, ah interesting.  But users can just dismiss and then call, right?
[13:52] <MacSlow> mterry, sure
[13:52] <MacSlow> mterry, although the general "swipe-to-dismiss" is still idling in an MP
[13:56] <tsdgeos> MacSlow: didn't i review it? damn
[13:57] <tsdgeos> i do remember reading that code a lot :D
[13:57] <MacSlow> tsdgeos, nope... atleast nothing marked on the MP itself... I knowthat you looked at it in Washington
[13:59] <tsdgeos> dandrader: i can do it if you want, i had a long look at it already, actually on my mind i had approved it :D
[14:00] <dandrader> tsdgeos, oh, awesome. have at it! :)
[14:01] <dandrader> tsdgeos, reassigned the review to you
[14:03] <tsdgeos> Saviq: depends on whether we're happy with the photoscope fixes or not
[14:04] <tsdgeos> Saviq: i find there's something weird going on, but looks like a more deep qtquick thing, i.e. i can scroll mostly fine and then it just gets slow at some "random point"
[14:05] <Saviq> tsdgeos, 'stood, if you want to spend more time on this, do
[14:06] <tsdgeos> Saviq: i'm trying to find something, at least today
[14:06] <mterry> MacSlow, approved the modal-snap-decisions branch, do you need to get it on a spreadsheet?
[14:06] <MacSlow> Saviq, ^?
[14:07] <Saviq> tsdgeos, kk
[14:07] <mterry> (https://code.launchpad.net/~macslow/unity8/modal-snap-decision-on-greeter-fix-1378827/+merge/239376)
[14:07] <Saviq> MacSlow, mterry, adding
[14:07] <MacSlow> mterry, Saviq: thanks!
[14:12] <vesar> thanks Saviq:)
[14:18] <MacSlow> Saviq, did you already select a silo for the next batch of unity8 MPs?
[14:18] <Saviq> MacSlow, vivid silo 5
[14:19] <MacSlow> Saviq, ah found it thx
[14:26] <tsdgeos> MacSlow: why the "import QtMultimedia 5.0" in tst_SwipeToAct.qml ?
[14:27] <MacSlow> tsdgeos, hm... that looks like a copy&paste error... let me check...
[14:30] <tsdgeos> MacSlow: so as i understand it, every Notification now will have a SwipeToAct just not visible unless it's x-canonical-snap-decisions-swipe, right? Wouldn't it be better to put it in a loader so that it saves some cycles?
[14:31] <tsdgeos> Saviq: not sure if asking for a microptimization here ↑
[14:31] <Saviq> tsdgeos, makes sense, yeah, we should switch between normal buttons and swipe to act idealy
[14:31] <Saviq> +l
[14:32] <MacSlow> tsdgeos, isn't visible: false enough (thinking back to what Gerry told us at the sprint)?!
[14:32] <tsdgeos> MacSlow: no
[14:32] <Saviq> MacSlow, CPU cycles
[14:32] <tsdgeos> MacSlow: the component still needs to be created
[14:32] <Saviq> MacSlow, it will still get created etc., just won't be put on the GPU
[14:32] <tsdgeos> and then is just not painted
[14:32] <Saviq> or on the scenegraph, that is, even
[14:33] <MacSlow> tsdgeos, Saviq: ok I'll look into chaning it to use a Loader
[14:33] <tsdgeos> good, will comment on MR
[14:45] <MacSlow> tsdgeos, made Loader and import changes... rev1311
[14:48] <tsdgeos> MacSlow: maybe use the active property instead of shuffling sourcecompoent?
[14:49] <MacSlow> tsdgeos, not sure what you mean
[14:49] <tsdgeos> MacSlow: use the active property to enable or not the loader
[14:49] <tsdgeos> instead of changing the sourceComponent property
[14:50] <MacSlow> tsdgeos, ok
[14:50] <tsdgeos> MacSlow: that way you don't even need the Component wrapper
[14:51] <tsdgeos> i think
[14:51] <tsdgeos> :D
[14:51] <tsdgeos> let me check
[14:51] <MacSlow> outch... that messes up things
[14:53] <MacSlow> tsdgeos, I don't think I can get around Component and sourceComponent
[14:53] <tsdgeos> why not?
[14:54] <tsdgeos> MacSlow: http://paste.ubuntu.com/8733937/
[14:54] <tsdgeos> no?
[14:55] <MacSlow> tsdgeos, ah... didn't try it like that when using the active-property... works now...
[14:55] <MacSlow> just doing few more of the tests to be sure
[14:56] <tsdgeos> MacSlow: you should also change this
[14:56] <tsdgeos> MacSlow: http://paste.ubuntu.com/8733964/
[14:56] <tsdgeos> i.e.
[14:57] <tsdgeos> http://paste.ubuntu.com/8733966/
[15:00] <MacSlow> tsdgeos, tested and pushed
[15:01] <tsdgeos> MacSlow: you need to remove visible: !notifySwipeButton.visible
[15:01] <tsdgeos> there's no such thing as notifySwipeButton
[15:01] <tsdgeos> anymore
[15:02] <tsdgeos> and the loader active handles that now
[15:04] <MacSlow> tsdgeos, done
[15:06] <tsdgeos> MacSlow: last thing is, you should not remove the import "../Components/Flickables" as Flickables and comboList: Flickables.Flickable {
[15:06] <tsdgeos> that's has nothing to do with your MR
[15:06] <tsdgeos> and is being handled in a separate MR globally
[15:06] <tsdgeos> besides that it looks good
[15:06] <MacSlow> tsdgeos, hm... I got errors for that last week so I removed it
[15:07] <tsdgeos> please don't
[15:07] <tsdgeos> or tell me which errors you have
[15:07] <MacSlow> tsdgeos, ok... I readd that line
[15:07] <tsdgeos> because i don't see how this could have errors
[15:10] <MacSlow> tsdgeos, hm... works without issues now with that Flickables import re-added
[15:10] <MacSlow> tsdgeos, pushed that change too
[15:15] <tsdgeos> MacSlow: and comboList: Flickables.Flickable { too please
[15:16] <Saviq> please don't use Flickables any more
[15:16] <Saviq> they go away in the next landing anyway
[15:17] <tsdgeos> Saviq: i'm just making it so that it doesn't conflict with your next landing
[15:17] <tsdgeos> it's existitng code he should not change in his MR
[15:17] <Saviq> tsdgeos, oh ok, just noticed Flickables
[15:18] <MacSlow> tsdgeos, ok... changed that too
[15:19] <dandrader> mzanetti, does that make sense to you http://paste.ubuntu.com/8734196/
[15:19] <MacSlow> Saviq, tsdgeos: so I reverted the whole Flickable-relates parts
[15:19] <dandrader> mzanetti, I noticed that the dash was showing up when doing the rotation, because it was behind the focused app and not being hidden
[15:19] <Saviq> MacSlow, yeah, that's gonna happen in my MP, if you wanted in on that, you should've based on my branch and made it prerequisite
[15:20] <MacSlow> Saviq, I got errors last week so I chagned it in my branch... since it all fine now, I guess there were some package-update issues inbetween
[15:24] <mzanetti> dandrader: yeah... if I read it correctly it should be ok. didn't test it though
[15:29] <MacSlow> tsdgeos, top-approve too?
[15:29] <tsdgeos> MacSlow: see comment :)
[15:30] <tsdgeos> MacSlow: i want CI to run again
[15:30] <MacSlow> tsdgeos, my firefox keeps acting up today... probably my ISP really
[15:31] <MacSlow> tsdgeos, I saw the "Approve" mark... but not your comment
[15:32] <tsdgeos> ok
[15:47] <tsdgeos> Saviq: what's up with https://code.launchpad.net/~unity-team/unity8/fix-1333187/+merge/239990 ?
[15:48] <tsdgeos> Saviq: do i need to approve again? what's the changes?
[15:48] <Saviq> tsdgeos, needed to resubmit on top of my revert
[15:48] <Saviq> tsdgeos, I'll take care
[15:48] <tsdgeos> ok
[16:12] <tsdgeos> Saviq: so we have a patchset for the dbus bugs larsu and ryan found
[16:13] <tsdgeos> Saviq: any idea how to proceed, i don't think i am good enough for reviewing them
[16:13] <tsdgeos> by other than integrate them and make sure things don't go wrong
[16:26] <Saviq> tsdgeos, what projects do they touch?
[16:26] <tsdgeos> Saviq: qtcore
[16:26] <tsdgeos> well
[16:27] <tsdgeos> qtdbus
[16:27] <Saviq> tsdgeos, accepted upstream?
[16:27] <tsdgeos> upstream wants me to review ^_^
[16:27] <tsdgeos> https://codereview.qt-project.org/#/c/98353/ https://codereview.qt-project.org/#/c/98354/ https://codereview.qt-project.org/#/c/98355/
[16:28] <Saviq> tsdgeos, means you're good enough for them, you're sure good enough for me
[16:29] <Saviq> tsdgeos, if you want a second pair of eyes, tvoss should know... he did write dbus-cpp after all ;)
[16:30] <MacSlow> Saviq, one more for the silo 5 -> https://code.launchpad.net/~macslow/unity-notifications/swipe-to-act-fix-1358343/+merge/238956
[16:30] <Saviq> MacSlow, can it wait for the next silo?
[16:31] <MacSlow> Saviq, hm... it should at least to with https://code.launchpad.net/~macslow/unity8/swipe-to-act-fix-1358343/+merge/236091
[16:31] <MacSlow> Saviq, although that still needs top-approval from tsdgeos
[16:31] <Saviq> MacSlow, yeah, that's fine
[16:31] <Saviq> MacSlow, next time then
[16:32] <Saviq> next one should be smaller/easier hopefully
[16:32] <MacSlow> Saviq, and then it would be nice to have these two, https://code.launchpad.net/~macslow/unity8/modal-snap-decision-on-greeter-fix-1378827/+merge/239376 and https://code.launchpad.net/~tiagosh/telephony-service/swipe-to-answer/+merge/239983 all in one silo
[16:33] <Saviq> MacSlow, sures
[16:33] <MacSlow> Saviq, as they all relate to addressing the incoming-call use-case
[16:33] <Saviq> MacSlow, works for me, we could start building a silo already
[16:33] <MacSlow> Saviq, do you want that in an email for reference?
[16:33] <Saviq> MacSlow, no, I've got the logs
[16:34] <MacSlow> ok
[16:34] <Saviq> MacSlow, let's do that tomorrow morning, either it's going to be after the unity8 landing or we'll have it for testing for design ACK
[16:34] <MacSlow> Saviq, ok... that works forme
[16:49] <tsdgeos> Saviq: any idea why no dbgsym package of qtdeclarative5-ubuntu-ui-toolkit-plugin ?
[16:49] <tsdgeos> i thought we had of them all?
[16:53] <Saviq> tsdgeos, let me have a look at the build
[16:53] <Saviq> tsdgeos, that's vivid?
[16:53] <tsdgeos> Saviq: yes
[16:55] <Saviq> tsdgeos, http://ddebs.ubuntu.com/pool/universe/u/ubuntu-ui-toolkit/ any of these?
[16:55] <tsdgeos> i guess the first
[16:55] <tsdgeos> the name is just ifferent to make it harder?
[16:56] <tsdgeos> ah no it's the same name
[16:56] <Saviq> tsdgeos, is it different?
[16:56] <tsdgeos> :S
[16:56] <Saviq> tsdgeos, what I *think* might've happened
[16:56] <Saviq> tsdgeos, that package wasn't built for vivid yet
[16:56] <Saviq> tsdgeos, so it's only indexed for utopic still
[16:56] <tsdgeos> ah
[16:56] <tsdgeos> ok
[16:58] <tsdgeos> there's some trackes of the toolkit in a bindign loop i get
[16:58] <tsdgeos> will have to compile the toolkit with debug myself tomorrow then
[17:04] <Saviq> tsdgeos, no no, you can get that package
[17:04] <Saviq> tsdgeos, it's the same binary that's in vivid
[17:04] <tsdgeos> ah
[17:04] <tsdgeos> right
[17:04] <Saviq> tsdgeos, it's just not tracked in the vivid dbgsyms repo
[17:04] <Saviq> tsdgeos, but anyway, tomorrow, have a good evening
[17:05]  * tsdgeos waves