=== arosales_ is now known as arosales === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away [15:56] jujugui call in 4 [15:56] hatch: yea! [15:59] 3 failures.....sigh [16:04] holy down to 2! [17:01] kadams54: Did we never write any tests for the setmvvisibitlity method that was moved from the servicelist to the db? [17:01] No? [17:01] ohh it was tested as a side effect [17:01] ignore me :) [17:02] I was so distraught I had to close the irc window [17:14] kadams54: have a question on your branch [17:14] What's that? [17:14] kadams54: so trying to follow, in the tests there's an assumption that agent_state == error [17:14] kadams54: but I'm not seeing that as part of the conditional? [17:15] kadams54: oh hmm, I guess it's in a function 'endpointHasError [17:15] https://github.com/juju/juju-gui/pull/640/files#diff-41da19c331704f9c770c1bcad9d31715R1411 [17:16] Line 1430 includes agent_state === 'error' [17:17] Does that answer the question? [17:17] kadams54: ah right ok [17:17] kadams54: yea, I'm cool ty [17:17] Going to comment about it in the PR, for posterity. [17:18] kadams54: rgr, also added a request on the bug update so it's clear we're hoping to fix, but could not replicate to 100% validate. [17:18] just ask them to reopen if they hit the issue again [17:20] jujugui impromptu poll irissi or weechat? [17:20] weechat [17:21] jcsackett: do you just use it within Terminal + tmux? [17:22] hatch: not even in tmux. [17:22] i mean, right now i'm using xchat, but when i use terminal irc it's weechat. [17:22] I'm getting sick of having to switch windows between editor irc and terminal [17:22] so hoping to remove one of them [17:23] irssi [17:23] * jcsackett knew that would be rick_h_'s rec. [17:23] with tmux [17:23] I keep meaning to try weechat, it's supopsed to be nice but irssi just works [17:23] hatch: truthfully, having used both i see little difference. i like weechat b/c i can script it in python instead of perl. [17:24] hmm that's definitely an advantage :) [17:24] rick_h_: weechat is nice. scripting in python (or ruby or perl but sssh) is nice. [17:24] I really wish Ubuntu had a terminal client like iTerm2 [17:24] what in iterm2 do you miss? [17:24] it's prettier :P [17:24] I don't scriptit so never bothered. I got irssi setup once long ago and just limp along like someone using windows 95 [17:24] easier to apply colours [17:25] profiles are easier to manage [17:25] it's just a better UX really [17:32] jcsackett: what does weechat use as a bouncer? znc? [17:33] hatch: gnome-terminal, while slow and somewhat bloated, has never struck me as that much weaker vs iterm2, tbh. [17:33] i hear konsole is really nice too, if you don't mind mix and matching your kde and gtk bits. [17:33] hatch: it can use any bouncer. [17:34] oh nice ok that's good [17:34] hatch: it does have some nice integration with znc--it can parse timestamps and logs sent by it and display them properly. [17:34] i don't remember the details; like rick_h_ once i got things working for the most part i stopped poking. [17:34] and I definitely don't want to mix display engine bits - I have a personal vendetta against multiple display engines :P [17:35] hatch: don't you already? you're using quassel right. pretty sure that's kde. [17:35] yeah and it ends up looking like garbage :P [17:36] I like consistency whenever possible [17:36] having apps which can use different engines is a little funky [17:38] ok so I guess I don't have a vendetta against different display engines, just mixing and matching :) [17:39] good thing open source people (myself included) don't have opinions :P [17:46] * jcsackett laughs [17:46] yes, our total impartiality and lack of opinions is really a defining feature. :p [17:47] haha [17:48] best tool for the job...so long as it's ruby on rails...for scripting my irc client [17:48] lol [18:04] jcsackett: do you use this ppa? https://launchpad.net/~nesthib/+archive/ubuntu/weechat-stable [18:04] hatch: no. [18:04] i just install from the repos. [18:06] ahh - I like the ppa's, auto keeping things up to date :) [18:07] woot! release is out, get a present [18:23] jujugui lf a review and qa on the latest added services updates https://github.com/juju/juju-gui/pull/641 [18:23] make that two [18:24] there will be a few more follow-up branches so requested changes/bugs from reviews may end up being fixed in those [18:27] kadams54: ^ mind taking a look [18:27] hatch: yeah, digging in. [18:27] thanks [18:55] jujugui: Another PR to review and QA: https://github.com/juju/juju-gui/pull/642 [18:55] hatch: ^ [18:55] will do [18:57] kadams54: comment made [19:05] grabbing lunch === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:30] Greetings juju-gui - question: we seem to have a missing recommended charm from the list on jujucharms: https://demo.jujucharms.com/trusty/hdp-tez-3/?text=tez -- https://jujucharms.com/solutions?type=charm [19:31] lazyPower: looking [19:31] rick_h_: additionally, the hdp-tez charm was updated with the rest of the big data stack, the individual charm view shows old information. https://jujucharms.com/hdp-tez/trusty -- this may be related. [19:31] lazyPower: ok, so it's there https://jujucharms.com/hdp-tez/, we're working on speeding up the solutions page and atm cut results at 150 and guessing it missed the cut [19:32] lazyPower: looking [19:32] ok, what has me confused is the old icon, and its not showing revision 3 [19:32] it may be stuck in ingest somewhere [19:32] lazyPower: so this was ingested yesterday around midnight [19:32] lazyPower: well the first ingest ran then, running every 15 after [19:32] they were updated ~ 1.5 hours ago [19:33] looks right in the gui, not on jujucharms.com - so im' thinking there's just something wonky going on with the websites meta [19:33] lazyPower: rgr, checking [19:35] lazyPower: were there others updated so I can narrow down if it's this one or any? [19:35] rick_h_: the entire big-data suite was updated. reference the updates here: https://code.launchpad.net/~bigdata-charmers [19:35] lazyPower: ok thanks [19:40] lazyPower: ok, so the rest of the suite loaded it appears. I'm filing a bug on the ingestion code and we'll check if it loads in QA and try to get logs from production. [19:40] thanks rick_h_ - sorry to be a complainer :) [19:40] lazyPower: hah broken isn't complaining [19:40] <3 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:54] Makyo: thanks a lot for the review and qa - those two ghost bugs are known and will be tackled in the immediate follow-up [19:54] hatch, rock on :+1: [19:54] thanks sir [19:54] kadams54: +1? [19:56] hatch: I'm looking at a cross-interaction bug right now [19:57] does it block landing? Could it be fixed as the follow-up? I'd like to get moving on the next fixes [19:58] hatch: http://cl.ly/image/222F3s1O252N [19:58] I'll leave it up to you as to whether or not this blocks landing [19:58] oh that is odd [19:58] lemme see if I can repro [19:59] there are also some relation lines that should be hidden that are only faded [19:59] Deploy the mongodb cluster, hide mongos and shard1, highlight configsvr, unhighlight configsvr. [20:00] ugh [20:00] * hatch crys "Why won't this end" [20:01] yeah this needs to be fixed in this branch [20:02] Then there's this, which is also fun: http://cl.ly/image/3w01042X1n2S [20:03] yeah looking at the relation stuff now [20:04] ahh I had if elses [20:04] you can be faded AND hidden [20:04] need if's without the elses [20:04] maybe [20:04] :P [20:06] ugh [20:07] I do not relish making hatch cry [20:08] hatch: need a second set of eyes/pair? [20:09] Last interaction thing I found: highlight shard1, then hide shard2. That puts things in bad state #1. Unhide shard2. Instead of fixing things somewat, that puts them in bad state #2. [20:09] Having problems uploading a screen recording right now [20:09] rick_h_: just stepping through it, my idea on how to fix does indeed fix it, but then it pops back to a broken state afterwards [20:09] it's very confusing... [20:10] hatch: let me know if talking it out/etc can help. Happy to jump on and peek [20:10] yeah gimme 15 [20:10] then we'll see [20:10] Gotta run to pick up the kids. Will be back in about 30. [20:15] rick_h_: fixed it - looks like it was caused by d3's async fading - can we ditch the fade-in/out animations for now? [20:15] add them back in later via css? [20:15] well that fixes one of the bugs [20:15] :) [20:16] hatch: sounds ok to me [20:17] great - I've already added a previous card where I removed something similar so that card can now include this too [20:29] sweet [20:29] fixed them all [20:30] trivial fixes too, boy am I happy I did this correctly [20:30] lol [20:30] was so worried I made a mistake in the architecture somewhere === kadams54 is now known as kadams54-away [20:32] kadams54-away: just fixing up the tests here then I'll push up a fixed version. Those screen recordings were immensely helpful [20:33] :( nexus 9 is a movie playing disappointment ouch. [20:34] oh really? How come? [20:35] the screen size, it letter boxes the movies so half the screen is wasted [20:35] aspect ratio fail for hd movies [20:35] oh weird that seams like a huge oversight [20:35] are you sure it's not just the movie you're watching? [20:35] I know some movies have weird ratios too [20:36] hmm, yea it's a bit less bad on another movie [20:36] but still :( [20:52] kadams54-away: ok fixes are pushed, plz try again :) [21:09] rick_h_: I'm sure you have nothing but free time right now - but the releasable lane still has cards in it ;) [21:09] * hatch runs away snickering === kadams54-away is now known as kadams54 [21:15] hatch: re-checking [21:18] thanks [21:18] now you better not find anymore bugs... :P [21:18] at least not ones that happen on deployed services :D [21:20] Well… if canvas looks all clear, I'm going to do regression testing on MV ;-) [21:21] haha if there are any mv issues they can go in a follow-up :P [21:22] Still seeing this: http://cl.ly/image/2c1v2J2P361p [21:23] It's better than it was before, but still not what I expect. [21:23] (What I expect is for nothing to happen when I "hide" shard2.) [21:24] (But maybe that's not right.) [21:26] hatch: the other interactions look good, so that's a win. [21:27] damnit [21:37] kadams54: ok I'll get back on that shortly - will you be around tonight to take another look? (assuming I can get it fixed in the next 1.5h :) ) [21:37] Yes, though not until after 8 PM Eastern. [21:38] hatch: is it 2:38 local time for you? [21:38] 3:38 [21:38] GMT -6 always [21:38] ok well I'll get as far as I can on it then push up if I solve it [21:46] kadams54: yeah your latest bug is in the code which determines what attributes get set on the models [21:46] this will take some more time to figure out I think [21:53] kadams54: what if we disabled the fade button when it is already hidden/faded ? [21:54] hatch: yeah, I was thinking through options like that, but… I'm not sure it would be any simpler to code up. [21:54] that might just introduce another level of complexity [21:54] Yup. [21:54] ok I might have a solution [21:54] maybe [21:54] heh [22:00] Morning [22:00] shit I think I fixed it [22:01] morning huwshimi [22:01] kadams54: when is your eod? [22:01] now? [22:02] hatch: 13 minutes and counting [22:02] lol start a little late? [22:02] Well, it's only a little after 5 here, so I won't be working that late. [22:03] I generally try to work later since I usually lose some time in the middle of the afternoon to pick the kids up. [22:03] oh ok :) so you're 1h ahead of me [22:03] Yes. We were 2 hours ahead until this past weekend. [22:03] I appear to have fixed the bug and maintained the other fixes [22:03] Super. [22:03] just need to figure out how to make sure we have a test for this now [22:03] I'll give it another whirl [22:03] Have you pushed the fix> [22:03] ? [22:04] I haven't [22:04] one sec [22:04] rick_h_: as afollow up to earlier with a missing unit, i have untis that have been removed that should no longer be displaying. [22:05] kadams54: pushed - do you know where the event extension tests are? [22:05] for example: https://jujucharms.com/hdp-hadoop-hive-mysql/0 - was removed [22:05] test_browser_events.js [22:05] ermahgerd that page is so pretty [22:05] kadams54: thanks iunno why I couldn't find it :) brain probably slowing down haha [22:07] ok writing the test - I REALLLLLY hope you don't find any more bugs [22:07] Me too. [22:14] no bugs so far? Man this must be good news - or there are so many it's taking you a while to catalogue them [22:14] lol [22:17] ok tests pushed === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [22:28] hatch: looks good [22:28] +1 [22:28] I'll add to PR as well [22:29] ZONG [22:29] ZOMG even [22:29] shippin that ish [22:32] hatch: MV looks good even [22:32] OK, gotta run, will check in later. [22:32] awesome - cya === kadams54 is now known as kadams54-away [23:08] lazyPower: ping around? [23:08] hatch: :P [23:08] rick_h_: i am [23:08] lazyPower: ok, how was it removed? It's there in the page you linked? Or was something else removed? [23:09] lazyPower: now the try in demo button is disabled because of an ssl issue where browser is blocking an ajax request. We've got a fix landed for that and will be doing a deploy tomorrow with webops [23:09] the bzr repository was removed, as aiui that should remove it from the charm store *but only when talking about bundles* [23:09] s/as/and/ [23:10] lazyPower: oh it *needs* to be removed? [23:10] yessir, the hdp-hadoop-hive-mysql, hdp-hadoop-pig, and hdp-hadoop-cluster bundles - as they have serial names that mean nothing to anyone. [23:11] this is part of a cleanup that the new launch shed light upon - to keep things tidy and looking nice. [23:11] tehy were mirrored in the newer bundles you see above, that mirror teh big-data-feature page nomenclature [23:11] lazyPower: ok, will file a ticket to get them removed. Can you shoot me an email with the list? [23:11] sure can, incoming [23:11] lazyPower: thanks, will get it out of there [23:12] lazyPower: copy uros on the email please [23:14] rick_h_: email deployed [23:57] hatch: Are you still around?