/srv/irclogs.ubuntu.com/2014/11/06/#juju-gui.txt

huwshimihatch: Just wondering if you know how the ambiguous relation menu is supposed to look?00:02
hatchhuwshimi: hey - it's supposed to look better00:38
hatch:)00:38
huwshimihatch: OK, better :)00:39
hatchyeah there are no mockups so just better :)00:39
huwshimialrighty then00:41
=== kadams54-away is now known as kadams54
kadams54hatch: I saw the PR of all PRs finally landed.02:46
=== kadams54 is now known as kadams54-away
=== urulama_ is now known as urulama
hatchjujugui lf a review and qa on removing the as flag https://github.com/juju/juju-gui/pull/643 14:32
jcsacketthatch: looking now.14:32
hatchthanks14:32
hatchjujugui need one more review for ^14:41
kadams54hatch: looking14:42
hatchthanks14:42
hatchrick_h_: are you ok with the flag removal landing? 14:42
rick_h_hatch: is it ready? :)14:43
rick_h_hatch: yea, I need to find time to get over to the GUI side and QA and such. Will try to do that once we get the release going today14:43
hatchwell there is one known bug - so i'd like to get the flag removed so we can catch any related bugs while doing the remaining work14:43
rick_h_hatch: rgr14:44
hatchthere were so many mv related bugs after removing the flag that I want to avoid that14:44
kadams54hatch: what's the one known bug?14:44
* kadams54 really hopes it's the card he's working on.14:44
hatchkadams54:  it's theorange card in this project14:45
hatchabout the toggling of the highlight button14:45
hatchkadams54: is that the one you are working on? I was just about to grab it14:47
kadams54No14:47
hatchok taking14:47
kadams54But I disagree  with the card that unhighlight needs to be changed to method calls14:48
hatchHuw did a great job styling the ambiguous relation dialog last night14:48
kadams54Or rather, I'm highly skeptical ;-)14:48
rick_h_because huw is awesome :)14:48
hatchhaha he is14:48
hatchkadams54: yeah first I need to figure out why it only is an issue with ghost services and not deployed ones14:48
hatchthen will figure out an appropriate fix14:48
kadams54Good stuff - looking forward to seeing it in action14:48
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
marcoceppifor manage.jujucharms.com, I only get 20 results back everytime I search which makes queries like type=approved&series=trusty worthless15:17
rick_h_marcoceppi: &limit=1000?15:18
marcoceppichanges nothing15:18
hatchkadams54: fixed it 15:19
hatchwithout changing it to a method15:19
=== kadams54 is now known as kadams54-away
=== kadams54-away is now known as kadams54
hatchjust going to write the test now and then I'll have it up15:19
kadams54hatch: sweet. What needed fixing?15:19
rick_h_marcoceppi: looking15:19
kadams54Sign me up for QA and review :-)15:20
hatchheh will do15:20
hatchyou were on the right track with your fix but looking the wrong direction ;)15:20
hatchnow the question is...does it work with relations15:22
kadams54And does it work with machine view15:23
hatch*snif* it does *snif* it's...so....beautiful15:23
kadams54And does it work when you turn highlight on for one service and hide 3 other services, two of which aren't related at all to the highlighted one.15:23
kadams54And does it work when you go in the reverse direction15:24
kadams54kadams54: snap out of it! *slap*15:24
kadams54kadams54: Thanks, I needed that.15:24
hatchyep everything is good - but ghosted services don't hide properly in the machine views15:24
hatchI'll make a card for that for you15:24
kadams54*sob*15:25
kadams54It took us a week to implement 90% of added services.15:25
hatchhah - well you know the mv stuff the best15:25
kadams54And then someone *ahem* said, "hey, could we tweak how this works?" And bam, three weeks later.15:26
hatchyeah but it's stable now 15:26
hatch:)15:26
rick_h_marcoceppi: ugh, not sure man. We've not landed any new code there in forever but yes, all queries are maxing out at 20 results. 15:26
marcoceppi\o/15:26
marcoceppicool, well that's fine for now I just won't mess with charm-tools for a bit15:27
rick_h_marcoceppi: https://api.jujucharms.com/v4/search?series=trusty&limit=600 15:27
marcoceppi:OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOo15:27
rick_h_if you need some info right now the new api has it working15:27
marcoceppiITS SO FAST15:27
rick_h_:) only the ids returned15:27
rick_h_but yea, much faster 15:27
rick_h_marcoceppi: but don't rely on this yet. It's still early and the url is going to change/etc15:27
marcoceppialso, whats the way to get just approved15:27
marcoceppior promulgated or whatever15:27
marcoceppitoo late, already dependant on it15:28
rick_h_marcoceppi: but can help https://api.jujucharms.com/v4/search?series=trusty&owner=&limit=60015:28
rick_h_marcoceppi: setting owner= (empty) will show approved15:28
marcoceppi\o/15:28
hatchkadams54: are there no tests for the onHighlightToggle methods?15:28
rick_h_marcoceppi: raising a bug on charmworld and will see. For now let me konw and we can help get you the info needed from the new api endpoint to unblock.15:28
marcoceppithat unblocks me for now15:29
kadams54hatch: There should be. One moment…15:29
hatchahh they are tested as side effects15:29
marcoceppiwon't put it in the charmtools stuff15:29
kadams54hatch: test_added_services_view.js, around line 30415:30
kadams54That tests directly.15:30
hatchwell it doesnt' send any service names15:32
hatchlooks like I'll have to modify the suite so I can test with a ghost service id too15:32
marcoceppirick_h_: thanks, here's the bug whenever you guys get time https://bugs.launchpad.net/charmworld/+bug/1390127 no real rush15:36
mupBug #1390127: All queries are limited to 20 results regardless of limit parameter <charmworld:New> <https://launchpad.net/bugs/1390127>15:37
rick_h_marcoceppi: ty15:37
rick_h_jujugui call in 8 please kanban15:53
hatchjujugui lf a review and qa https://github.com/juju/juju-gui/pull/64515:56
hatchkadams54: ^15:56
kadams54Will look after standup15:57
hatchhows your branch coming along?15:57
hatchjcsackett: I'll do the other review on huws branch15:57
hatchkadams54: your card in the maintenance lane - is it landed?16:19
kadams54hatch: ah, yeah, missed that16:21
hatchjcsackett: I'm not able to reproduce this bug any longer - could you give it a try on comingsoon to see if it's indeed fixed? https://bugs.launchpad.net/juju-gui/+bug/133909316:26
mupBug #1339093: Drag and drop failing with syntax error <juju-gui:Triaged> <https://launchpad.net/bugs/1339093>16:26
jcsacketthatch: looks fixed to me.16:27
hatchthanks, closing16:27
hatchjujugui anyone need any reviews?16:30
kadams54hatch, Makyo: https://github.com/juju/juju-gui/pull/642 is ready for reviews and QA.16:35
hatchkadams54: you didn't reply to my comment16:36
hatchactually I'm pretty confused by the override thing too16:37
kadams54hatch: I just replied to your comment.16:38
kadams54And I addressed the override thing.16:38
hatchkadams54: ok so your reply should be in a comment in the code - github is being odd and not showing replies in the code for some reason :/ 16:41
kadams54I did put a comment in the code… the XXX bit.16:41
hatchI do't see any comment about the override16:41
kadams54Oh, by "comment in the code", do you mean on the PR?16:41
kadams54Or in the code in the code?16:41
hatchright but that doesn't say why you couldn't use the real property in the template16:41
kadams54Ah, OK16:42
hatchand I still don't understand override 16:42
hatchthat api seems very....fragile16:42
kadams54It is16:42
kadams54And it's all temporary16:42
kadams54There needs to be some way to distinguish between renders that happen after a button click and those that happen on initial view render.16:43
kadams54The override flag does that job.16:43
kadams54We need to be able to tell, because in one situation (initial render) we want to override the local attributes with the service attributes. In the other (after a button click) we don't want to override.16:44
kadams54We don't want to override because the service attributes are being set to their new values asynchronously and may actually still be the old values at render time.16:44
kadams54Which would result in the just-clicked button being rendered as inactive.16:45
kadams54All of this is way too much for code that is intended to be very short-lived, so I'd rather just stick with the current XXX comment and get a card in for the long-term fix.16:45
hatchkadams54: ok review done16:47
hatchrick_h_: I'm going to work on https://bugs.launchpad.net/juju-gui/+bug/1375918 - it might take a while, I have no idea :)16:48
mupBug #1375918: units can be created without a service causing cascading failures <juju-gui:Triaged> <https://launchpad.net/bugs/1375918>16:48
hatchkadams54: maybe I'm doing something wrong but I can't get your branch to qa properly17:00
kadams54hatch: how so?17:01
hatchit doesn't work heh17:01
hatcheven after clearing cache and all that17:01
hatchit's like nothing has changed wrt the button statuses 17:01
hatchmaybe could you try rebasing your branch with develop and checking locally17:01
hatchpossible something landed that broke it?17:02
hatchfrankban: hey are you still in?17:05
frankbanhatch: yes on call17:05
hatchnp ping when you have a moment17:05
kadams54hatch: Bah, no, I broke it myself in the last commit, the one called "review feedback"17:05
hatch:) ok lemme know when it's fixed17:05
kadams54Fixed.17:08
hatchtesting17:10
hatchkadams54: +117:12
hatchdoes demo.jujucharms.com use a different font than when deployed locally?17:15
hatchthey appear to be the same17:16
hatchhttps://bugs.launchpad.net/juju-gui/+bug/139016117:19
mupBug #1390161: demo.jujucharms.com and locally deployed GUI has different weighted fonts <juju-gui:New> <https://launchpad.net/bugs/1390161>17:19
frankbanhatch: what's up?17:19
hatchfrankban: well I'm going to be working on  https://bugs.launchpad.net/juju-gui/+bug/137591817:20
mupBug #1375918: units can be created without a service causing cascading failures <juju-gui:Triaged by hatch> <https://launchpad.net/bugs/1375918>17:20
hatchso this is the one about creating units using 'new' instead of trying to guess the id17:20
frankbanhatch: ok17:21
hatchI was just wondering if there were any issues you could forsee using this approach17:21
hatchI can't htink of anything - the machine view seems to work well with it17:21
* frankban thinks17:21
frankbanhatch: the more I think about it, the more I feel that units and machines are very similar on that perspective. so I don't see problems (excluding the required changes on the ecs)17:24
hatchyeah this change is going to be substantial for sure17:24
hatchwhat I don't want to do is implement it then think of a better approach17:24
hatcheither for units or machins17:24
hatchmachines17:24
hatchnewX is certainly prettier than some random id string17:25
frankbanhatch: we can never know what's the next id assigned to new entities in juju17:25
frankbanhatch: that's why the new prefix succeeded in putting ghost machines under a different namespace, avoiding the clashes we have for units17:26
frankbanhatch: so mysql/new1, wordpress/new2 sounds reasonable and also does not look bad17:26
hatchtrue true17:26
hatchthis will all fall apart if juju gets ecs in core17:27
hatchso I suppose that's not a concern either17:27
frankbanhatch: exactly, once we have more state from juju we can avoid pretending to have a state in the browser17:28
hatchfrankban: ok thanks - I'm now more confident that I can emulate the same approach with units :)17:29
frankbanhatch: yes np17:29
hatchrick_h_: I think this is a critical regression https://bugs.launchpad.net/juju-gui/+bug/139016517:33
mupBug #1390165: container tokens are not rendered <juju-gui:New> <https://launchpad.net/bugs/1390165>17:33
hatchit exists in the released version17:33
rick_h_hatch: rgr, then please start that, I'm afk for a little bit17:33
hatchwill do17:33
hatchkadams54: I see you have picked up the card I created - were you able to reproduce the issue or do you need more details17:54
hatchre the ghost service machine token hiding17:54
kadams54Yeah, I reproduced it17:54
hatchok great17:54
hatchI'm going to grab some lunch17:54
kadams54hatch: I know why ghost machines aren't being highlighted properly. I just don't know how to fix it.18:48
kadams54Well, maybe I do.18:52
kadams54Seems that I do. Yay.18:57
hatchhaha yay19:03
hatchjujugui need one more review on https://github.com/juju/juju-gui/pull/64519:04
Makyojujugui trivial 1 review/qa for https://github.com/juju/juju-gui/pull/64619:05
hatchsure19:06
kadams54I'll look at both.19:06
kadams54Or hatch and I will split.19:06
kadams54Either way.19:06
hatchkadams54: he still needs 219:06
hatchand I need one that's not him :)19:06
hatchso yep you'll do both ;)19:06
hatch+1 Makyo19:08
kadams54Makyo, hatch: For the trifecta: https://github.com/juju/juju-gui/pull/64719:14
MakyoOn it19:14
hatchkadams54: interesting...19:14
hatchkadams54: needs tests19:15
hatch:)19:15
hatchmight as well start on that now :P19:15
kadams54hatch: got a merge conflict when trying to pull in your #64519:15
hatchahh probably in the tests?19:16
hatchok fixing19:16
kadams54hatch: IIRC, setMVVisibility was tested indirectly. I did verify that all tests passed. That said, having some direct tests would not be a bad idea, but I'd prefer to handle it in a separate card.19:16
hatchkadams54: right - but there was a bug19:17
hatchyou fixed it19:17
hatchthe tests didn't change19:17
hatchso the tests were insufficient 19:17
kadams54Not my fault the original author didn't write any direct tests :-)19:17
hatchwell even the indirect tests are likely insufficient then19:17
kadams54I agree, I just think that's outside the scope of this card.19:18
hatchhow do you figure?19:20
hatchyou didn't update the tests to test for the failure19:20
hatchso how can we be sure that the next branch that lands doesn't break it again?19:20
kadams54It would be one thing if there had been tests originally and I just needed to update them. But since they need to be written from scratch, I feel like it's a big enough chunk of work to justify a separate card.19:21
kadams54Which I will tackle next.19:21
hatchI'm pretty sure it's just an extra couple assertions in the browser events test file19:23
hatchin an existing test19:24
hatchbut if you would like to create a new test suite for the unit tests I suppose that would be more thorough 19:24
kadams54I'd like to get something pretty thorough wrapped around it.19:24
kadams54It's a pretty important bit of logic.19:24
kadams54Especially with that crazy nested looping going on.19:25
hatchconflict resolved on #64519:26
kadams54hatch: commented on #645. I'll get to work on a test suite for setMVVisibility.19:30
hatchkadams54: so I had thought of that initially but was concerned about people modifying the ghost display name then playing with the added services stuff19:32
hatchtbh I'm not sure it's an issue 19:33
hatchactually it shouldn't matter because it's in a blocking loop19:34
hatchwill make the change19:34
hatchafp is a frustrating protocol, if it's not being used it closes the connection19:35
hatchthen doesn't reopen when you try to access19:35
hatchand unfortunately there is no --keep-alive19:36
kadams54Why are you dealing with AFP?!?19:43
kadams54(Unless you mean something other than Apple Filing Protocol.)19:43
hatchlol19:43
hatchkadams54: my host os is OSX so in order to properly mount my NAS into OSX I need to use AFP19:44
kadams54You can't use SMB?19:44
hatchOSX has huge issues with mounting anything using 'normal' prototcols19:44
kadams54Apple has had AFP deprecated for years now, though they only started migrating away from it in Mavericks.19:44
kadams54But still, you're on Yosemite, so you ought to be able to use SMB.19:45
hatchare you sure you'r enot mixing it up?19:45
kadams54Pretty sure.19:45
hatchI moved to AFP in mavericks because other techniques woudln't work19:45
kadams54And you're sure the problem wasn't PIBKAC?19:45
hatchI was originally using SSHFS I believe19:46
hatchwhich was poorly supported19:46
hatchNFS etc19:46
hatchmaybe that's fixed and I can stop using this horrible bs19:47
hatchhah19:47
kadams54http://appleinsider.com/articles/13/06/11/apple-shifts-from-afp-file-sharing-to-smb2-in-os-x-109-mavericks19:47
hatchlemme check if my synology supports smb19:48
kadams54What file system are you using on your NAS?19:48
hatchahh just updated it and there is a smb219:50
hatchoption 19:50
hatchit's under Windows though19:50
hatchvery odd haha19:50
hatchwell I know what I'm going to be doing later19:51
hatchkadams54: ok updated20:04
kadams54+1'd20:07
kadams54hatch: ^20:07
hatchword20:07
hatchLinkin Park is coming to Stoon20:07
hatchw00t20:07
hatchtoo bad they likely won't be playing their first two albums wholesale :)20:07
hatchkadams54: looks like you can land #64720:11
hatchthen hopefully rick_h_ can do a real deep qa on it all :)20:12
kadams54I've got this test suite half written, so I'll get that included, just to make you happy hatch :-)20:12
hatchlol20:12
hatchI think we have all the functionality hammered out now20:13
hatchI haven't noticed any bugs since these most recent branches20:13
rick_h_wheee20:17
* rick_h_ crush qa boom20:27
hatchhaha20:37
hatchrick_h_: it's going to be probably an hour before all the pending branches land then i'll be ready for qa20:38
hatchor you could merge them into your local branch if you feel like you want to do it now :)20:38
rick_h_hatch: all good, I've got broken kid at home so won't be able to go through it well until after he goes to bed20:38
hatchhah ok np20:38
kadams54Heading out to grab an early dinner with the family. Will be back in about an hour to land #647.20:39
hatchcoolio20:39
=== kadams54 is now known as kadams54-away
hatchhmm for some reason the container tokens have a hidden class applid20:50
hatchapplied even20:50
hatchcrap I found another bug20:55
hatchok - container bug fixed and pushed to PR21:18
hatchand new bug created21:18
hatchhttps://bugs.launchpad.net/juju-gui/+bug/139022821:18
mupBug #1390228: Hiding services should update container column machine <juju-gui:New> <https://launchpad.net/bugs/1390228>21:18
=== urulama is now known as urulama__
huwshimiMorning21:58
rick_h_hatch: we're going to skip the AU call tonight if that's cool22:26
hatchyeah np22:45
hatchsorry i missed the ding22:45
huwshimihatch: You didn't miss it, we just started very early :)22:47
rick_h_go luca go 22:56
huwshimi:)22:57
=== kadams54 is now known as kadams54-away

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!