| wallyworld_ | sinzui: the first comment on that bug - i don't think juju needs to change since it already generates metadata for just one stream at a time, leaving the other stream metadata untouched | 00:01 |
|---|---|---|
| sinzui | wallyworld_, does implementing option 3 risk releasing beta1 tomorrow? | 00:25 |
| wallyworld_ | sinzui: i'll have a fix asap | 00:25 |
| sinzui | wallyworld_, As much as I don't want to write hack, I can do it in a 3 hours | 00:25 |
| wallyworld_ | sinzui: the hack will be the backup plan? | 00:25 |
| wallyworld_ | but i will have juju changed today | 00:26 |
| wallyworld_ | promise :-) | 00:26 |
| sinzui | wallyworld_, it allows my to release, then worry that juju will want to do something different next week | 00:26 |
| sinzui | wallyworld_, I like your promises, but I don't want you to rush, stress, loose sleep | 00:26 |
| wallyworld_ | i'll be fine, we're almost there | 00:27 |
| wallyworld_ | i'll have it done b the time you SOD | 00:27 |
| sinzui | okay, thank you, but if you discover blocker, remember we have a backup plan | 00:27 |
| wallyworld_ | yep, good to know :-) | 00:27 |
| wallyworld_ | just finishing 1 other bug, will get straight on to it soon | 00:27 |
| tvansteenburgh | is there something i can do to prevent this (see agent-state-info on machine 3)? http://pastebin.ubuntu.com/8859275/ | 00:37 |
| wallyworld_ | tvansteenburgh: that will be fixed in 1.21 beta1 | 00:59 |
| tvansteenburgh | wallyworld_: \o/ thanks | 01:00 |
| wallyworld_ | we expect to release the beta by early next week | 01:00 |
| tvansteenburgh | that's great news, i was about to ask :) | 01:00 |
| wallyworld_ | :-) | 01:00 |
| wallyworld_ | there's also a lot of other network fixes for maas | 01:00 |
| wallyworld_ | well juju/maas | 01:01 |
| axw | tvansteenburgh: you can delete the default VPC in your region if you don't need it; you can't undo that (without AWS support's help) | 01:23 |
| axw | that should stop the error from occurring | 01:23 |
| wallyworld_ | axw: when you have a moment :-) http://reviews.vapour.ws/r/369/ | 01:42 |
| wallyworld_ | thanks :-) | 01:50 |
| tvansteenburgh | axw: thanks for the tip, although i probably can't/shouldn't do that since these environments are owned by sinzui and co. | 02:00 |
| axw | right, probably not then ;) | 02:11 |
| wallyworld_ | axw: i'm off to lunch, so no hurry, but review appreciated http://reviews.vapour.ws/r/370/ | 02:38 |
| axw | wallyworld_: sure, enjoy | 02:42 |
| === axw_ is now known as axw | ||
| ericsnow | axw: when you have a minute could you take a look at http://reviews.vapour.ws/r/342/? It's a little guy. | 03:51 |
| axw | ericsnow: sure | 03:55 |
| ericsnow | axw: thanks | 03:55 |
| axw | ericsnow: done | 04:10 |
| ericsnow | axw: with that backups is now completely switched over to gridfs :) | 04:14 |
| axw | ericsnow: awesome :) | 04:14 |
| wallyworld_ | ericsnow: you backporting to 1.21? | 04:31 |
| ericsnow | wallyworld_: planning on it | 04:31 |
| wallyworld_ | ericsnow: awesome. curtis will be doing a beta build tomorrow | 04:32 |
| ericsnow | wallyworld_: I guess I'm planning on doing it tonight! :) | 04:32 |
| wallyworld_ | \o/ | 04:32 |
| wallyworld_ | ericsnow: or we can | 04:32 |
| wallyworld_ | once it lands, we'll backport | 04:33 |
| ericsnow | wallyworld_: well, there's more than one patch that needs backporting | 04:33 |
| wallyworld_ | ericsnow: in that case, don't worry, it can wait | 04:33 |
| ericsnow | wallyworld_: k | 04:33 |
| wallyworld_ | it will be a bit of risk | 04:33 |
| wallyworld_ | ericsnow: just in case, can you email be the rev numbers that would need merging | 04:34 |
| ericsnow | wallyworld_: will do (shouldn't be more than a handful | 04:34 |
| wallyworld_ | ok, ta | 04:34 |
| === kadams54 is now known as kadams54-away | ||
| === urulama__ is now known as urulama | ||
| ericsnow | wallyworld_: I've emailed you those rev numbers (3 of them) | 06:05 |
| wallyworld_ | thanks ericsnow :-) | 06:06 |
| ericsnow | wallyworld_: plus the one I'm commiting right now (to master) | 06:06 |
| wallyworld_ | righto | 06:06 |
| ericsnow | wallyworld_: you think I should hold off on backporting them? | 06:06 |
| wallyworld_ | ericsnow: well, it's really late for you isn't it | 06:07 |
| ericsnow | wallyworld_: sort of :) | 06:07 |
| wallyworld_ | so, we'll backport if needed, you go get some sleep | 06:07 |
| ericsnow | wallyworld_: k | 06:07 |
| wallyworld_ | have a good weekend | 06:08 |
| ericsnow | wallyworld_: also, are we okay to land http://reviews.vapour.ws/r/371/? (add .reviewboardrc to the 1.20 branch) | 06:08 |
| wallyworld_ | can't see why not | 06:08 |
| ericsnow | wallyworld_: k | 06:08 |
| ericsnow | wallyworld_: FYI, we've yet to land the restore side of backups (and we're cutting it close) | 06:10 |
| wallyworld_ | ericsnow: i was hoping to be divorced from storage, but if it's not all there, we can wait | 06:11 |
| ericsnow | wallyworld_: I meant the replacement for the juju restore CLI plugin (not storage) | 06:12 |
| wallyworld_ | ah, right, yeah that one will have to wait | 06:13 |
| ericsnow | wallyworld_: wait for what? | 06:13 |
| wallyworld_ | 1.22 | 06:13 |
| wallyworld_ | ideally we'll have a week to fully test 1.21 beta before release, which is next friday | 06:14 |
| ericsnow | wallyworld_: so does that mean we should yank the new backups (at least the CLI for it)? | 06:14 |
| ericsnow | wallyworld_: they kind of go together | 06:15 |
| wallyworld_ | yeah, i'm not across the state of play with that stuff | 06:15 |
| ericsnow | wallyworld_: okay, I'll follow up with Nate tomorrow | 06:15 |
| wallyworld_ | ta, but i imagine we'd want to revert the cli | 06:15 |
| wallyworld_ | keep curtis in the loop also | 06:16 |
| wallyworld_ | as he will be pulling th trigger on the release | 06:16 |
| ericsnow | wallyworld_: got it | 06:19 |
| wallyworld_ | ty | 06:19 |
| ericsnow | wallyworld_: have a good weekend :) | 06:20 |
| === urulama is now known as urulama__|home| | ||
| rogpeppe | does anyone know if the "format" field in metadata.yaml still has any relevance to anything? | 07:46 |
| rogpeppe | fwereade: ^ | 07:46 |
| davecheney | rogpeppe: beware format 0 charms | 07:47 |
| rogpeppe | davecheney: there are none | 07:47 |
| rogpeppe | davecheney: AFAICS - i downloaded all the charms in the charm store | 07:47 |
| rogpeppe | davecheney: hi, BTW! | 07:48 |
| rogpeppe | davecheney: do you know the difference between format 1 and format 2 ? | 07:48 |
| rogpeppe | davecheney: the only charms that i can find that explicitly mention format specify 2, which is different from our default. but we don't seem to have any logic (in the charm package anyway) that cares one way or another | 07:49 |
| fwereade | rogpeppe, davecheney: the format stuff was a long long time ago, and I thought all references to it had been purged | 07:50 |
| rogpeppe | fwereade: there are still remnants in the charm package | 07:51 |
| fwereade | rogpeppe, davecheney: I can't remember exactly what it did -- some subtle change in hook tool behaviour | 07:51 |
| fwereade | rogpeppe, I think it's safe to ignore them | 07:51 |
| fwereade | rogpeppe, the code that would have been triggering on them does not exist | 07:51 |
| rogpeppe | fwereade: i'm just writing a GetYAML method so we can marshal metadata as yaml (finally!) and i'm just making sure that I can always omit the format field. | 07:51 |
| * fwereade cheers heartily at rogpeppe | 07:52 | |
| fwereade | rogpeppe, that sgtm | 07:52 |
| rogpeppe | fwereade: cool | 07:52 |
| rogpeppe | fwereade: this means that soon you'll be able to programmatically generate charms in tests and produce their yaml metadata, which i think you might find quite useful :) | 07:53 |
| fwereade | rogpeppe, that is why I'm cheering :) | 07:54 |
| rogpeppe | fwereade: :) | 07:54 |
| davecheney | rogpeppe: i think we had this discussion in august 2012 | 08:00 |
| davecheney | and determined at the time we'd expunged them all | 08:01 |
| * rogpeppe forgets most things | 08:01 | |
| davecheney | from memory, i think the charm format affected the default output format of charm hooks ? | 08:01 |
| davecheney | and let me just say, "good riddence" | 08:01 |
| fwereade | davecheney, that sounds pretty likely | 08:01 |
| fwereade | davecheney, yeah :) | 08:02 |
| mattyw | morning folks | 08:02 |
| === liam_ is now known as Guest18751 | ||
| rogpeppe | anyone fancy a little review? https://github.com/juju/charm/pull/75 | 08:52 |
| TheMue | morning | 08:55 |
| alexisb | morning TheMue | 09:07 |
| TheMue | alexisb: hey, still in Europe? | 09:08 |
| alexisb | I dont normally get to say that to you | 09:09 |
| alexisb | yes I am in paris | 09:09 |
| TheMue | alexisb: or is you inner clock not yet adjusted back to home? ;) | 09:09 |
| TheMue | alexisb: ah, ok, I thought you were already on your flight back | 09:10 |
| === liam_ is now known as Guest78079 | ||
| rogpeppe | fwereade: https://github.com/juju/charm/pull/75 | 09:51 |
| mattyw | fwereade, are you around? | 10:23 |
| rogpeppe | fwereade: i'm not sure what you mean by making the marshaling explicit | 10:24 |
| rogpeppe | fwereade: do you mean the field names? | 10:25 |
| fwereade | rogpeppe, yeah | 10:26 |
| rogpeppe | fwereade: why is that better? we rely on the default lower casing everywhere else? | 10:26 |
| rogpeppe | s/\?$// | 10:26 |
| rogpeppe | fwereade: and the tests ensure that it's working correctly | 10:27 |
| fwereade | rogpeppe, (1) we try not to everywhere else | 10:27 |
| fwereade | rogpeppe, (2) it's hard to make those tests good | 10:27 |
| fwereade | rogpeppe, unless we do explicit checks of what gets written out, which have their own problems | 10:27 |
| rogpeppe | fwereade: the tests test round-tripping, which seems like a good-enough test to me | 10:28 |
| fwereade | rogpeppe, roundtrip tests don't detect marshalling *changes* though | 10:28 |
| rogpeppe | fwereade: yeah, i think they will | 10:28 |
| rogpeppe | fwereade: we read in with the standard ReadMeta, and check that when marshaled, and read back, we get the same thing | 10:28 |
| rogpeppe | fwereade: so if the marshaling semantics change (e.g. to not lower case the name) the test will fail | 10:29 |
| rogpeppe | fwereade: for example, if i change the "Categories" tag so that the name is "Categories", the test fails | 10:31 |
| fwereade | rogpeppe, doesn't that depend on a chain of inference across multiple tests and implementations? I'd rather just have it 100% obvious how something's going to marshal | 10:31 |
| fwereade | rogpeppe, assuming readmeta works and the readmeta test works and this test uses readmeta... | 10:32 |
| fwereade | rogpeppe, vs "that's how it marshals, done" | 10:32 |
| * fwereade has to go again anyway | 10:32 | |
| rogpeppe | fwereade: ok, i'll add explicit names, no big deal | 10:33 |
| rogpeppe | fwereade: though everything would break if yaml didn't lower-case as it marshaled (i actually don't like that behaviour, as it's doesn't fit with encoding/json, but i think it's reasonable to rely on) | 10:34 |
| rogpeppe | fwereade: and the same testing issue applies whether i make the names explicit or not. | 10:35 |
| fwereade | rogpeppe, thanks -- fwiw I've caught at least one proposed fieldname change that would have broken stuff subtly, I'd rather just make that mistake harder across the board | 10:36 |
| fwereade | rogpeppe, granted, but it's that fieldname changes don't *always* trigger hey-changing-marshalling in people's brains | 10:37 |
| fwereade | rogpeppe, this means that marshalling changes must be made explicitly, and will be seen to be explicit in review | 10:37 |
| rogpeppe | fwereade: at some point, i plan to implement a backward-compatibility checker that can ensure this kind of stuff automatically | 10:37 |
| fwereade | rogpeppe, that sounds awesome | 10:37 |
| fwereade | rogpeppe, in the meantime, be so kind as to indulge my paranoia ;) | 10:38 |
| rogpeppe | fwereade: will do | 10:38 |
| rogpeppe | fwereade: the idea is that you run all the tests, check what gets marshaled/unmarshaled, and that gives you your list of stuff that needs to be maintained correctly. | 10:38 |
| anastasiamac | jam, wallyworld_, axw: could u plz cast ur eyes over http://reviews.vapour.ws/r/357/ when u get a chance. this should cater for recomendations based on hardware and user preference | 11:06 |
| menn0 | this needs a review. it's a fix for one of the bugs that needs to be sorted for 1.21 beta1. Turns out it's a long-standing issue. http://reviews.vapour.ws/r/377/ | 11:31 |
| rogpeppe | here's a tiny PR in the charm package, if anyone wants to take a look: https://github.com/juju/charm/pull/76 | 12:12 |
| TheMue | rogpeppe: will do | 12:18 |
| rogpeppe | TheMue: ta! | 12:18 |
| TheMue | rogpeppe: lgtm | 12:21 |
| rogpeppe | TheMue: ta! | 12:21 |
| TheMue | yw | 12:21 |
| wallyworld_ | anyone know where fwreade is? | 13:06 |
| alexisb | wallyworld_, I am looking at him | 13:06 |
| wallyworld_ | alexisb: ah, in that case i really need to talk to him | 13:06 |
| wallyworld_ | fwereade: !! | 13:06 |
| wallyworld_ | a couple of things, could you please look at http://reviews.vapour.ws/r/377/ | 13:07 |
| wallyworld_ | we need to land this for 1.21 | 13:07 |
| fwereade | wallyworld_, ok, looking | 13:07 |
| wallyworld_ | it looks ok, but i have a coupleof concerns, bt may be ok | 13:08 |
| fwereade | wallyworld_, I think that LGTM, but what are the concerns? | 13:10 |
| wallyworld_ | fwereade: what happens if someone changes the number of sub ords after a relation is added | 13:10 |
| wallyworld_ | then it could become invalid | 13:10 |
| fwereade | wallyworld_, don't understand the question | 13:11 |
| fwereade | wallyworld_, a service can't change its subordinacy | 13:11 |
| wallyworld_ | fwereade: i had a couple brief other questions, quick chat? | 13:11 |
| wallyworld_ | or you may be busy | 13:11 |
| fwereade | wallyworld_, in a sprint room, private irc if you don't want to pollute here? | 13:12 |
| fwereade | wallyworld_, happy to talk ofc | 13:12 |
| fwereade | wallyworld_, just not convenient to do so out loud | 13:12 |
| fwereade | wallyworld_, also my connection is rather spotty | 13:12 |
| === urulama__|home| is now known as urulama | ||
| lazyPower | perrito666: thanks for the follow up, dimitern and ericsnow got me sorted. I should have sent un-ping ;) | 13:54 |
| perrito666 | np | 14:00 |
| perrito666 | you can thank fwereade that told me you where looking for me, he told it to me after 3 beers, but the information persisted nevertheless | 14:00 |
| wallyworld_ | perrito666: is nate around? | 14:04 |
| perrito666 | wallyworld_: there he is | 14:20 |
| dimitern | anyone can review a trivial patch to fix bug 1307677? http://reviews.vapour.ws/r/380/diff/ | 14:20 |
| mup | Bug #1307677: juju tries to use lxcbr0 when local provider is configured with kvm containers <cloud-installer> <config> <kvm> <local-provider> <juju-core:In Progress by dimitern> <https://launchpad.net/bugs/1307677> | 14:20 |
| wallyworld_ | perrito666: tis ok, i was just going to ask for a branch to be backported, but i've just done it | 14:20 |
| dimitern | cmars, TheMue, as OCR, can you have a look? ^^ | 14:23 |
| perrito666 | wallyworld_: uh, I should postpone answering to you more often | 14:23 |
| wallyworld_ | indeed :-) | 14:25 |
| lazyPower | fwereade: tap me next sprint and i'll get ya a beer | 14:25 |
| lazyPower | perrito666: same to you *hattip* | 14:26 |
| dimitern | thanks wallyworld_ ! | 14:26 |
| wallyworld_ | dimitern: np, sorry about brief comments, beena long day | 14:27 |
| wallyworld_ | is this for 1.21 also? | 14:27 |
| dimitern | wallyworld_, yeah | 14:27 |
| TheMue | dimitern: *click* | 14:27 |
| wallyworld_ | great, really happy to see these network issues get fixed | 14:28 |
| wallyworld_ | natefinch: hey | 14:29 |
| wallyworld_ | or perrito666 | 14:30 |
| natefinch | yo | 14:32 |
| wallyworld_ | hey nate | 14:33 |
| wallyworld_ | for 1.21 | 14:33 |
| TheMue | dimitern: you've got a review | 14:33 |
| dimitern | TheMue, thanks! | 14:33 |
| wallyworld_ | i landed menno's fix for bug 1382751 | 14:33 |
| TheMue | dimitern: yw | 14:33 |
| mup | Bug #1382751: non subordinate container scoped relations broken <regression> <relations> <subordinate> <juju-core:Fix Committed by menno.smits> <juju-core 1.20:In Progress by menno.smits> <juju-core 1.21:In Progress by menno.smits> <https://launchpad.net/bugs/1382751> | 14:33 |
| wallyworld_ | pr 1075 | 14:33 |
| wallyworld_ | i backported to 1.21 | 14:33 |
| wallyworld_ | and tried to land in pr 1077 | 14:33 |
| wallyworld_ | but | 14:34 |
| wallyworld_ | there was test failure, due to a missing file http://juju-ci.vapour.ws:8080/job/github-merge-juju/1229/console | 14:34 |
| wallyworld_ | i'm totally buggered, after 12:30am here | 14:34 |
| wallyworld_ | could you possibly take a look and fix the issue and land? | 14:34 |
| wallyworld_ | it should be small and easy hopefully given it's anded in master already | 14:34 |
| natefinch | wallyworld_: sure | 14:35 |
| wallyworld_ | tyvm | 14:35 |
| wallyworld_ | the goal is to get 1.21 beta blessed today | 14:35 |
| natefinch | wallyworld_: seems likely something changed between 1.21's charm.v4 revision and master's charm.v4 revision | 14:40 |
| wallyworld_ | ah could be, charm.v4 has changed, yes | 14:41 |
| === liam_ is now known as Guest54104 | ||
| wallyworld_ | natefinch: maybe also poke wayne about bug 1361316 | 14:47 |
| mup | Bug #1361316: juju status panic if state conn is shutdown || closing. <cts-cloud-review> <panic> <status> <ui> <juju-core:Triaged by wwitzel3> <https://launchpad.net/bugs/1361316> | 14:47 |
| wallyworld_ | should be a one line fix | 14:47 |
| natefinch | wallyworld_: yep, I'll ping him. he was going to start looking at it yesterday, I'll make sure he's just doing the easy fix and not the hard fix :) | 14:47 |
| natefinch | wwitzel3: ^ | 14:48 |
| wallyworld_ | yeah, juju status is messed up | 14:48 |
| wallyworld_ | even with err != nil, you are expected to still print partial status | 14:48 |
| wallyworld_ | anyone know that state of bug 1381619 | 14:48 |
| mup | Bug #1381619: Failed to destroy-environment when node is in commissioning or new state <cloud-installer> <oil> <juju-core:Triaged by mfoord> <MAAS:Incomplete> <https://launchpad.net/bugs/1381619> | 14:48 |
| wallyworld_ | comments on the bug made me think that the fix was well understood | 14:49 |
| dimitern | wallyworld_, voidspace started on that yesterday IIRC | 14:49 |
| natefinch | rogpeppe: You just changed something in charm.v4 about testing and charm repos... we're trying to backport a change from master to 1.21 and it's getting this error: ... Panic: open /home/ubuntu/juju-core_1.21-beta1/src/gopkg.in/juju/charm.v4/testing/repo/quantal/logging-principal/metadata.yaml: no such file or directory (PC=0x4144D6) | 14:49 |
| wallyworld_ | hopefully will be done today as it's marked critical for 1.21 :-) | 14:49 |
| wallyworld_ | anyways, gotta sleep, good luck with final bug fixes | 14:50 |
| rogpeppe | natefinch: looks like you've got the wrong dependencies | 14:50 |
| perrito666 | yay windows is fun | 14:51 |
| rogpeppe | natefinch: or... do you need the new changes in the charm package? | 14:51 |
| natefinch | rogpeppe: well, so 1.21 uses charm.v4 from before your latest change... | 14:51 |
| natefinch | rogpeppe: that or we make the ported fix work with charm.v4 from before your change | 14:51 |
| rogpeppe | natefinch: if that's the case, then how could my change in charm.v4 affect it? | 14:51 |
| wwitzel3 | natefinch: ok, I can add the status check and put up a review | 14:51 |
| rogpeppe | natefinch: i think you'll have to do that | 14:52 |
| natefinch | rogpeppe: the fix was made to master after your change | 14:52 |
| rogpeppe | natefinch: that's part of the backport | 14:52 |
| natefinch | rogpeppe: right, so my question is - what's different? | 14:52 |
| natefinch | wwitzel3: cool | 14:52 |
| rogpeppe | natefinch: we moved the testing charms repo from charm.v4 to juju-core | 14:53 |
| rogpeppe | natefinch: but... | 14:53 |
| rogpeppe | natefinch: that error message looks like you haven't updated the charm.v4 package | 14:53 |
| natefinch | rogpeppe: right, I'm just concerned that if we update the charm.v4 revision that 1.21 uses, that it'll break a whole lot more stuff | 14:54 |
| rogpeppe | natefinch: because charm.v4/testing/repo/quantal *should* exist in the old charm.v4 package | 14:54 |
| rogpeppe | natefinch: yes, it will. don't do that. | 14:54 |
| natefinch | oh hmm | 14:54 |
| natefinch | ok, good, so that's what I assumed | 14:54 |
| rogpeppe | natefinch: it's possible that the logging-principal test charm was added recently | 14:55 |
| natefinch | https://github.com/juju/juju/pull/1077/files | 14:55 |
| natefinch | it was added in this PR | 14:55 |
| rogpeppe | natefinch: what version of charm.v4 is being used? | 14:55 |
| natefinch | rogpeppe: f97c8d630e45651f7b39ce352dd7329082f134c4 | 14:55 |
| rogpeppe | natefinch: right, that's your problem | 14:56 |
| natefinch | well, so, I'm not sure how to fix this. If updating the charm.v4 revision will break a bunch of stuff... but this test won't work in 1.21 because charm.v4 at that revision expects the testcharm to be under its own testing/repo directory | 15:00 |
| rogpeppe | natefinch: i see the issue | 15:00 |
| natefinch | It seems like the only fix is to update 1.21's dependencies to use charm.v4 with your change | 15:01 |
| rogpeppe | natefinch: and this is also a reason that the changes we've made in charm.v4 are good - it will prevent things like this from happening again | 15:01 |
| natefinch | yes definitely | 15:01 |
| rogpeppe | natefinch: yes | 15:01 |
| natefinch | and then fix whatever else falls out of that | 15:01 |
| rogpeppe | natefinch: those changes were sweeping but pretty much automatics | 15:02 |
| rogpeppe | s/cs$/c/ | 15:02 |
| natefinch | k | 15:02 |
| rogpeppe | natefinch: and the compiler will tell you if you've gotten it wrong | 15:02 |
| rogpeppe | backporting is such fun | 15:02 |
| natefinch | what's doubly aggravating is that this is just for the test. The actual production code is fine. | 15:03 |
| natefinch | (in theory) | 15:03 |
| natefinch | well, I'm glad we made the fix so it won't happen again... too bad we hit it one last time though | 15:03 |
| ericsnow | natefinch: standup? | 15:08 |
| ericsnow | sinzui: FYI, the restore side of backups has not landed for 1.21, which renders the rest of the new backups code kind of pointless for 1.21 | 15:33 |
| ericsnow | sinzui: I'm planning on getting a change into 1.21 that simply removes the new backups CLI but leaves the rest of the backups code intact (to lessen the risk of removing so much) | 15:34 |
| ericsnow | sinzui: that patch should be up in a little bit | 15:34 |
| wwitzel3 | natefinch: http://reviews.vapour.ws/r/382/ fix for lp:1361316 | 15:35 |
| sinzui | ericsnow, thank you | 15:38 |
| wwitzel3 | also wallyworld_ if you're still around - http://reviews.vapour.ws/r/382/ | 15:40 |
| sinzui | natefinch, can you organise an effort to backport the fix for bug 1382751 to beta1 (1.21 branch)? It may be in progress already | 15:41 |
| mup | Bug #1382751: non subordinate container scoped relations broken <regression> <relations> <subordinate> <juju-core:Fix Committed by menno.smits> <juju-core 1.20:In Progress by menno.smits> <juju-core 1.21:In Progress by menno.smits> <https://launchpad.net/bugs/1382751> | 15:41 |
| natefinch | sinzui: yeah, it's in progress by me ;) | 15:42 |
| natefinch | sinzui: just updated the bug to reflect that | 15:42 |
| sinzui | you rock natefinch | 15:43 |
| natefinch | someday I'll tell the story of changing the keys on my keyboard so the bottom row spelled out "NATEROCKS" :) | 15:43 |
| natefinch | ok, well, actually, that's the whole story | 15:43 |
| sinzui | :) | 15:46 |
| wwitzel3 | thanks for the review TheMue | 15:47 |
| TheMue | wwitzel3: yw | 15:48 |
| wwitzel3 | I just got an email from Amazon trying to get me to pay $99 to stick a device in my home that will listen to everyting in my house and send all that data to them ... | 15:49 |
| wwitzel3 | I feel like they should pay me for that | 15:49 |
| voidspace | hah | 15:49 |
| voidspace | wwitzel3: what's the device called? | 15:49 |
| voidspace | I've not heard of that | 15:49 |
| wwitzel3 | Amazon Echo .. | 15:49 |
| voidspace | wwitzel3: the NSA probably did that for you for free | 15:49 |
| wwitzel3 | if it was April .. I would of thought it was a joke | 15:50 |
| voidspace | http://www.amazon.com/oc/echo | 15:50 |
| voidspace | interesting | 15:50 |
| natefinch | I saw a thing about that yesterday. It seems interesting, but don't we all have something like that in our pockets already? I guess not with a halfway decent speaker | 15:51 |
| wwitzel3 | see, the NSA did it wrong, all they needed to do was has a nice landing page and charge people for PRISM and it would of been a hit | 15:51 |
| natefinch | haha | 15:51 |
| natefinch | honestly, the main problem with this thing is that it's audio-only. You now how many times I'm going to listen to it read out a wikipedia page? | 15:52 |
| voidspace | :-) | 15:52 |
| wwitzel3 | natefinch: though it is probably more effective than when your friends read a wikipedia page off their phone, they always leave out the citation needed part :D | 15:53 |
| voidspace | axw: ping | 15:53 |
| natefinch | haha | 15:54 |
| voidspace | axw: although I really doubt you're around | 15:54 |
| wwitzel3 | voidspace: it is like 5am saturday morning, who isn't up (still) then? ;) | 15:55 |
| wwitzel3 | voidspace: since you are OCR today, mind looking at http://reviews.vapour.ws/r/382/ | 15:55 |
| voidspace | ah, am I? | 15:56 |
| wwitzel3 | voidspace: you and fwereade I believe | 15:56 |
| ericsnow | sinzui, natefinch: 1.21 backups CLI removal patch: http://reviews.vapour.ws/r/383/ | 15:56 |
| voidspace | wwitzel3: you're looking at the wrong friday I think... | 15:56 |
| wwitzel3 | voidspace: probably | 15:56 |
| wwitzel3 | voidspace: will you look anyway *eyebat* | 15:56 |
| voidspace | heh | 15:57 |
| ericsnow | wwitzel3: cmars and TheMue are OCR | 15:57 |
| voidspace | wwitzel3: seeing as I'm very unlikely to get this high priority bug completed anyway *sigh* | 15:57 |
| voidspace | wwitzel3: I think I know where in the code to fix it at any rate | 15:57 |
| natefinch | wwitzel3: you got a ship it from TheMue | 15:57 |
| wwitzel3 | voidspace: which are you working on? | 15:57 |
| voidspace | wwitzel3: there's even a comment from axw predicting that there would be a problem with the code... | 15:57 |
| wwitzel3 | natefinch: don't we still need two? | 15:57 |
| TheMue | yeah | 15:57 |
| voidspace | wwitzel3: bug #1381619 | 15:58 |
| mup | Bug #1381619: Failed to destroy-environment when node is in commissioning or new state <cloud-installer> <oil> <juju-core:Triaged by mfoord> <MAAS:Incomplete> <https://launchpad.net/bugs/1381619> | 15:58 |
| natefinch | wwitzel3: no? | 15:58 |
| wwitzel3 | oh, I was still under the impression we needed two LGTM/Ship It on reviews, ok :) | 15:58 |
| voidspace | wwitzel3: have you seen how RB renders that diff? | 15:59 |
| voidspace | ericsnow: ^^ | 15:59 |
| natefinch | wwitzel3: I don't think we've needed 2 LGTMs since before we hired you :) | 15:59 |
| voidspace | anyway LGTM *sigh* | 15:59 |
| voidspace | wwitzel3: couldn't you just remove registering the command, whilst leaving the rest of the code in there? | 15:59 |
| natefinch | ericsnow: yeah, that's what I was thinking ^ | 16:00 |
| wwitzel3 | voidspace: huh? | 16:00 |
| natefinch | wwitzel3: I think he keeps typing you instead of ericsnow | 16:00 |
| voidspace | wwitzel3: basically, only do the change in cmd/juju/main.go | 16:00 |
| perrito666 | natefinch: when I entered whoever induced me, which I believe was mgz said that 1 for trivial changes 2 for anything importan | 16:00 |
| perrito666 | t | 16:00 |
| voidspace | oh | 16:00 |
| wwitzel3 | voidspace: what? | 16:00 |
| voidspace | is it ericsnow who asked for the review | 16:01 |
| voidspace | wwitzel3: no, you asked for a review on 383 | 16:01 |
| wwitzel3 | oops | 16:01 |
| wwitzel3 | wrong thing | 16:01 |
| voidspace | wwitzel3: which removed backups | 16:01 |
| natefinch | haha | 16:01 |
| natefinch | 383 is eric's code | 16:01 |
| voidspace | ah, ok | 16:01 |
| wwitzel3 | voidspace: http://reviews.vapour.ws/r/382/ sorry .. but I apparently don't need your review anyway :P | 16:01 |
| voidspace | ericsnow: for 383... couldn't you just remove registering the command and leave everything else in place? | 16:01 |
| voidspace | wwitzel3: hah ok :-) | 16:02 |
| ericsnow | voidspace: too easy <wink> | 16:02 |
| voidspace | ericsnow: :-) | 16:02 |
| voidspace | ericsnow: if the code is good, and it's tested, why not leave it in place | 16:02 |
| ericsnow | voidspace: good point; it hadn't crossed my mind | 16:03 |
| mattyw | fwereade, you got 30 seconds? | 16:07 |
| fwereade | mattyw, yeah, more or less :) | 16:07 |
| ericsnow | voidspace: yeah, that makes for a much simpler change :) | 16:10 |
| natefinch | ericsnow: +1 | 16:11 |
| ericsnow | natefinch: could you give me a ship-it? | 16:11 |
| natefinch | ericsnow: done | 16:12 |
| ericsnow | natefinch: thanks | 16:12 |
| natefinch | ericsnow: just make sure all the tests still pass | 16:12 |
| ericsnow | natefinch: they do | 16:12 |
| natefinch | cool | 16:12 |
| voidspace | gah, virsh can't use a storage pool on another physical drive due to strange permissions problems | 16:18 |
| voidspace | but you can create a filesystem in a file and then mount that as if it's on the partition it wants it on | 16:18 |
| voidspace | and it will use that happily | 16:18 |
| voidspace | that took me nearly half a day to work out | 16:19 |
| voidspace | but now I have two maas nodes | 16:19 |
| voidspace | not using hard drive space on my boot disk | 16:19 |
| voidspace | so now I can bootstrap *and* deploy a service - to try and reproduce the bug I'm meant to be working on | 16:19 |
| wwitzel3 | voidspace: progress :) | 16:20 |
| voidspace | wwitzel3: yeah, slow and painful - but definite | 16:20 |
| voidspace | although juju bootstrap hasn't started the node | 16:21 |
| voidspace | "competent-bait" is resolutely off | 16:21 |
| voidspace | but the power reporting works, so maas could boot the node if it wanted to | 16:21 |
| voidspace | status is "Deploying" but power is off | 16:22 |
| voidspace | INFO 0 minutes ago Node powered on | 16:22 |
| voidspace | no it didn't... | 16:22 |
| voidspace | and if I switch it on it shuts down again | 16:23 |
| natefinch | voidspace: it's like one of those boxes that you turn on and a hand comes out and turns itself off. | 16:24 |
| voidspace | natefinch: unfortunately so... | 16:25 |
| voidspace | "useless box" | 16:25 |
| voidspace | very qppropriate | 16:25 |
| voidspace | nope, maas changes the node state to Deploying, they start and then shutdown almost immediately | 16:42 |
| voidspace | the only record in the logs (libvirtd, maas and qemu) is that libvirtd kills the qemu process (shuts down the node) | 16:43 |
| voidspace | commisioning works fine | 16:44 |
| voidspace | and now it's working (after another manual kvm image start) | 16:52 |
| voidspace | for no fathomable reason | 16:52 |
| voidspace | looks like pxe booting isn't working, but manual starting is now working (didn't before) | 16:54 |
| voidspace | that's good enough | 16:54 |
| voidspace | heh, so I can't quite reproduce the bug | 17:51 |
| voidspace | but if I manually release a maas node and then call destroy-environment, juju hangs | 17:51 |
| voidspace | I don't know for how long... | 17:51 |
| === kadams54 is now known as kadams54-away | ||
| voidspace | ah... | 17:52 |
| voidspace | that was releasing the bootstrap node | 17:52 |
| voidspace | *state server node | 17:52 |
| voidspace | not what I intended | 17:52 |
| voidspace | no it wasn't | 17:53 |
| voidspace | I released the right node | 17:54 |
| === kadams54 is now known as kadams54-away | ||
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| natefinch | whoever is responsible for files in Juju that are over 2000 lines long should be flogged. (really, anything over ~500 is too much) | 19:08 |
| * natefinch goes to fix a test failure at line 2440 in apiserver/client/client_test.go | 19:09 | |
| === psivaa_ is now known as psivaa-holiday | ||
| * TheMue likes the good old Smalltalk. no files and methods seldom with more than 20 lines | 19:12 | |
| natefinch | That's one of the things I like about Go - you can subdivide into as many files as you want. They're all effectively just cat'ed together by the compiler | 19:12 |
| natefinch | (per package) | 19:13 |
| TheMue | natefinch: yes, no need to put everything in one file | 19:13 |
| TheMue | natefinch: but otherwise, one file per unit of code and a rule of few lines leads to small units (classes, packages, modules, etc) | 19:14 |
| natefinch | yep | 19:14 |
| natefinch | big files aren't the end of the world, honestly, it's just a little annoying having to page through them in diffs and in the editor. Big functions are the really killer... we have some 200 line functions in Juju that I've seen. Biggest function I've seen in my career was a 1000 line behemoth, but that was a long time ago | 19:15 |
| TheMue | ouch, that really hurts | 19:16 |
| voidspace | happy weekend everyone | 19:19 |
| voidspace | g'night all | 19:19 |
| natefinch | see ya voidspace | 19:19 |
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
| natefinch | sinzui: btw, backporting https://launchpad.net/bugs/1382751 is turning out to be a big mess. It requires porting another change, and that then requires a third change.... | 21:00 |
| mup | Bug #1382751: non subordinate container scoped relations broken <regression> <relations> <subordinate> <juju-core:Fix Committed by menno.smits> <juju-core 1.20:In Progress by menno.smits> <juju-core 1.21:In Progress by natefinch> <https://launchpad.net/bugs/1382751> | 21:01 |
| sinzui | natefinch, :( | 21:03 |
| sinzui | natefinch, is the chain for pain for 1.21 or both 1.21 and 1.20? | 21:04 |
| natefinch | sinzui: I would imagine it's possibly even more difficult for 1.20, though I haven't even looked at 1.20 yet | 21:05 |
| sinzui | natefinch, okay. I really appreciate you working on this. I am not sure we will release 1.20.12...well I need to work out how since 1.21 has permanently changes streams | 21:06 |
| natefinch | sinzui: I think I have most of what needs doing done... just running the tests now, which is always its own adventure | 21:21 |
| sinzui | fab | 21:22 |
| natefinch | sinzui: so, I have PR for the prerequisite code that needs to go in before I can backport the fix | 21:40 |
| natefinch | sinzui: but it seems unwise to simply dump all this into 1.21 on Friday afternoon. What do you think? | 21:40 |
| sinzui | natefinch, if I see a pass tomorrow morning, I am happy to release. A failure may mean the antipodians have a regression to fix | 21:42 |
| natefinch | sinzui: what i hear is "merge it and we'll see what happens" ... is that correct? :) | 21:43 |
| sinzui | natefinch, yes, let's be hopeful | 21:44 |
| natefinch | sinzui: does the merge bot work on the 1.21 branch? | 21:44 |
| sinzui | natefinch, if it turns out bad, we are still are ahead of delaying until our monday | 21:44 |
| natefinch | sinzui: yep | 21:44 |
| sinzui | natefinch, yep, just works | 21:44 |
| natefinch | ok | 21:44 |
| cmars | natefinch, is reviewboard spewing lots of errors for you when you try to view this diff? http://reviews.vapour.ws/r/384/diff/# | 21:47 |
| natefinch | typ | 21:47 |
| natefinch | yup | 21:47 |
| cmars | ericsnow, any ideas? ^^ | 21:47 |
| * ericsnow looks | 21:48 | |
| cmars | natefinch, ok, just wanted to confirm. i'll review in my dev env | 21:48 |
| natefinch | sinzui: I'll hafve to finish up the second PR with the fix in the morning, I'm out of time today. It's just merging PR 1075 into 1.21 ... I've just run out of time trying to wrestle with git and github to get it to do that | 21:51 |
| sinzui | natefinch, okay, Thank you for your time | 21:51 |
| ericsnow | cmars: looks like a classic merge conflict (as the error messages imply) | 21:53 |
| ericsnow | cmars: why? I'm not immediately sure | 21:53 |
| ericsnow | cmars: I'm guessing something didn't line up right when Nate initially made his pull request, which caused RB trouble and it hasn't been able to get back on its feet to try again | 21:56 |
| cmars | ericsnow, could be the target branch is 1.21 instead of master? it doesn't look like it has a conflict | 21:56 |
| ericsnow | cmars: 1.21 is definitely the trigger, but the cause of the problem is unclear | 21:57 |
| ericsnow | cmars: FYI, other 1.21 PRs have generated proper review requests without incident | 21:57 |
| ericsnow | cmars: I wonder if Nate used rbt to post the diff | 21:58 |
| === kadams54-away is now known as kadams54 | ||
| === kadams54 is now known as kadams54-away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!