=== kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 === kadams54 is now known as kadams54-away === urulama is now known as urulama__ === urulama is now known as urulama__ [12:33] uiteam: I need two reviews and (possibly) two QAs for https://codereview.appspot.com/174790043 (quickstart/python). This is a long diff (sorry) with some interesting changes, including dropping support for juju < 1.18. Any help really appreciated. Thanks! === kadams54-away is now known as kadams54 [13:26] frankban: rgr [13:28] rick_h_: thanks === kadams54 is now known as kadams54-away [14:20] morning all [14:25] kadams54-away: can we push the call 5mins? [14:33] rick_h_: they are calling winter here now a 'polar vortex' [14:33] nearly spit my coffee out when I read that [14:37] kadams54-away: ping when you return and we can start on that AS chat === kadams54-away is now known as kadams54 [14:48] hatch: back [14:49] welcome [14:49] my coffee is almost cold [14:49] I think I need a heated cup [14:50] I just figured everything in the Canadian prairie lands was heated. [14:50] Engine heaters, heated sidewalks, heated gutters, heated cups… [14:52] hatch: yea, pretty much [14:52] haha - heated sidewalks, where do you think I live? In the rich area? [14:53] hatch: FYI, I'm in themeeting room. [14:54] oh ok, joining [14:54] maybe... [15:05] hatch: freakin' google [15:05] lol [15:05] hatch: multiuser randomly decided to time out on my canonical login [15:05] ohh yeah that happens and always during a call lol [15:06] Well, probably not randomly, but I hit my "keep me logged in" timeout [15:40] 502 https://jujucharms.com/docs/ [15:41] Bad bad gateway [15:42] whit: yea, it's not there [15:42] whit: bad link, fixed in trunk and will try to release [15:42] gotcha [15:43] cool, glad it's know [15:43] n [15:52] kadams54: I'll create the cards right now [15:52] Excellent [15:55] kadams54: ok the three steps are done [15:55] I think splitting it up into these three will make them 1 day/card [15:55] ish [15:55] +1 [15:56] Makyo: lol nice T [15:56] It was the most delightfully strange thing, I had to get it. [15:57] uiteam call in 3 [15:57] or 3 on Makyo's watch [15:58] I'm in the room, but it says no one else is there? [15:58] kadams54: odd it said you were in there but when I joined there was noone else [15:58] lol [15:58] we have crossed dimensions it seams [15:58] same place at different times@ [15:58] Now rick_h_ is here with me, but no one else. === kadams54 is now known as kadams54-away [16:49] 3000 line test file.....now where is the test I need to modify.... [16:49] :) [16:51] rick_h_: I'm going to be done this card fairly soon so just giving you some heads up so we can chat about the next step === kadams54-away is now known as kadams54 [17:12] hatch: ok [17:22] uiteam lf reviews and qa on https://github.com/juju/juju-gui/pull/650 [17:26] uiteam: anyone know a way to consistently reproduce an error notification in a local sandbox env? [17:26] kadams54: yeah just add it from the console [17:26] app.db.notifications.add({ ... }) [17:27] yep, there's a type flag on there for errors [17:28] yeah like Makyo said in the call - level: error [17:28] rick_h_: I'm ready to chat about what's next whenever you have a moment [17:28] hatch: k, joining [17:29] hatch: thanks [17:55] kadams54: that work for you? [17:55] Yup. [17:56] great [17:56] Fixed the problem, writing the test now. [17:56] awesome [17:56] notifications has been on the docket to be refactored for 2 years [17:56] lol [18:02] not it [18:03] Before I submit this PR, I want assurances that my status as "having touched it last" does not constitute de facto ownership. [18:03] lol [18:03] I can make no such promises :P [18:03] Why did that "lol" sound evil in my head? [18:03] ;-) [18:04] "git blame...it's Kyle! come on down. You're the next contenstant!" [18:04] ent [18:04] hahaha [18:04] "The price is *wrong* Bob." [18:05] Oh sorry… "The price is *wrong*, bitch." [18:10] lol [18:15] uiteam: need reviews and QA on https://github.com/juju/juju-gui/pull/651 [18:16] hatch: Looking at 650 [18:24] on it [18:25] kadams54: can you re-run the tests on this one [18:26] it looks like a spurious error - but you are also working in notifications [18:26] Yeah, let me finish QAing yours. [18:26] cool [18:26] also we can [18:27] t clear notifications anymore I guess [18:27] probably should create a bug for that kadams54 ^ [18:32] hatch: just got a chance to look at the CI failure. Still gonna re-run tests, but I'm even more sure now that it's spurious. I added a test to test-notifications.js and the failure was in test-notifier.js, so not even the same file. [18:41] yeah for sure - just want to be sure :) === kadams54 is now known as kadams54-away [18:50] uiteam still looking for one more review https://github.com/juju/juju-gui/pull/650 === kadams54-away is now known as kadams54 [18:50] hatch: working my way there [18:52] thank yas === kadams54 is now known as kadams54-away === kadams54-away is now known as kadams54 [19:24] lunching [19:44] because there is a juju-gui user and project on LP is very confusing [19:51] lets see if this time I can download the charm properly :) [19:51] hah [19:52] 138850kB 617kB/s | Fetching revisions:Inserting stream:Estimate 3486/12174 [19:52] I'm pretty sure I'm already over [19:52] rick_h_: you said it was 120MB? [19:52] something like that [19:53] yeah wth [19:53] bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk/ develop-trunk [19:53] this is what I am running [19:54] yeah I'm over 200 now [19:55] rick_h_: is lp being auto sync'd to our GH repo? [19:56] hatch: no, it's manual [19:56] https://code.launchpad.net/~juju-gui/juju-gui/develop [19:56] and huh? [19:56] that has commits from last week [19:56] looks like from the bot [19:56] hmm, no idea [19:56] I thought we setup a bit MOVED file [19:57] hmm, looks like it [19:57] heh crazy [19:57] didn't realize it was importing [19:57] lol neither did I [19:58] I'm trying to branch the repo again without the trailing / [19:59] maybe that'll make it faster [19:59] rick_h_: when you downloaded it did you have a cobzr setup? [19:59] hatch: no, I do that after the fact if I want to hack on it [19:59] hmm ok and you ran the same command that I had above? [20:00] bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk/ develop-trunk [20:00] for instance [20:00] ok I have that running right now without the trailing slash - will see where it goes to [20:03] guess I'll just let this thing run [20:03] hmph I have no idea what's going on [20:05] uiteam anyone else able to do me a favour and try and branch the guicharm to see how big it is? [20:10] abentley: hey when bzr is branching, do you know where it puts the files before it's finished? [20:14] hatch: I believe a temp dir inside the directory with a name starting with 'bzr-limbo-'. [20:15] I'm trying to branch the gui charm and here is where I'm at so far [20:15] 571695kB 616kB/s / Fetching revisions:Inserting stream:Estimate 3710/12174 [20:15] but the folder is only 56K [20:15] abentley: so I am trying to figure out if it's even downloading anything [20:16] here is the command I ran bzr branch lp:~juju-gui/charms/trusty/juju-gui/trunk develop-trunk [20:16] hatch: At that point it's creating the branch, and there are no files. [20:16] 580MB downloaded with no files? [20:16] Once it finishes creating the branch, it updates the working tree, and that's when it creates the files. [20:17] hatch: Well, it depends what files you mean. I expect there's plenty of data in .bzr. [20:18] right but shouldn't a du -ha show more than 56K? [20:19] hatch: That depends. Are you using a shared repository? That's where the bulk of the data goes. [20:20] abentley: I just created a new folder and ran that branch command [20:21] hatch: That doesn't tell me whether you're using a shared repository. What does "bzr info" say about the directory or its parent directory? [20:21] Unshared repository with trees (format: 2a) [20:21] Location: [20:21] repository: . [20:22] so no, not shared :) [20:24] Well, I suppose it's possible that the data's all in memory. Is the bzr process really huge? [20:25] not really [20:25] 100MB [20:25] ish [20:25] it's over a GB now [20:25] heh [20:26] abentley: how about this - can you get the repo size without downloading it? [20:27] hatch: no, not really, but I think I have a copy here.... [20:27] rick_h_: recently downloaded it and it was only 120MB for him hah [20:28] hatch: Yeah, 98M for me. Probably a bit stale. [20:28] *sigh* [20:28] so any ideas on what's happening now or how I may debug this? [20:29] 1068064kB 618kB/s - Fetching revisions:Inserting stream:Estimate 3969/12174 [20:29] much bigger than 120MB :) [20:29] and by the looks of that estimate there is a long way to go [20:29] :) [20:33] Not really. Sorry. jam might know, but I never worked on that repo-fetching code. [20:33] alright np thanks for the help :) [20:38] abentley: rick_h_ I figured out a 'fix' for my issue [20:38] you quit doing it wrong? :P [20:38] I needed to launchpad-login then it worked?!?!?! [20:38] 30105kB 612kB/s - Fetching revisions:Inserting stream:Estimate 283/968 [20:39] note the estimate size [20:39] wth?!? This seams like an lp bug === kadams54 is now known as kadams54-away [20:39] now we'll see if it actually stops at 120 haha [20:40] hatch: Without your lp login, "bzr branch lp:" will not use SSH, so it will use bzr's http support. It should have printed a warning about how that is slower. [20:40] abentley: it wasn't slower - it was downloading at the same rate [20:41] du -ah is now showing 100+MB [20:41] definitely a bug there somewhere [20:41] hatch: Yes, but it's not as efficient using http, so the same amount of data does not get you a branch as quickly. [20:42] but is it orders of magnitute higher? [20:42] and done [20:42] wow....that was painless [20:42] 139MB toal [20:42] total [20:42] hatch: Can be, depending on what kind of junk is in the repo. [20:42] before it was well over 1.5GB with du showing 56K [20:43] yikes [20:48] rick_h_: updated process docs :) https://github.com/juju/juju-gui/pull/652 [20:49] noted :P [20:51] oops thanks :) [20:51] shipped [20:57] what's this code in this charm....no curlies, no semicolons === kadams54-away is now known as kadams54 [21:04] https://twitter.com/github/status/531914601248882689 [21:04] hmmmm [21:04] heh, /me runs away scared [21:05] * hatch pulls down fresh versions of all his git repos....just incase [21:05] lol [21:07] hatch: lol your branch was rejected [21:08] baqhahaha [21:08] damnit [21:08] fixing [21:08] :P nothing but trouble [21:09] wait what....it says my indentation is incorrect [21:09] ohh I didn't have a line between them [21:10] trying again :) [21:39] uiteam night, I'm out. [21:46] I'm pretty sure I do not like the large hook file instead of having multiple smaller ones [21:50] hatch: +1. === BradCrittenden is now known as bac === kadams54 is now known as kadams54-away