akiva-thinkpad | balloons, cool thanks /late reply | 00:05 |
---|---|---|
josharenson | Is there an easy to install an unsigned click package? | 00:48 |
Randy_O | Is there something special about the SDK I need to do to make offline scopes? It's not in my dropdown list when making a new scopes project. | 02:17 |
=== chihchun is now known as chihchun_afk | ||
akiva-thinkpad | Randy_O, good question | 02:30 |
akiva-thinkpad | Randy_O, are you going to the UOS? There is going to be a session on scope development | 02:31 |
akiva-thinkpad | Randy_O, also; are you entering the competition? | 02:31 |
Randy__O | akiva-thinkpad, I am going to try and follow the UOS, so far I've watched the 3 videos they put on ubuntu on air, and they only show how to do online scopes | 02:33 |
akiva-thinkpad | Randy__O, still there? | 02:33 |
=== chihchun_afk is now known as chihchun | ||
dpm | good morning | 07:15 |
dpm | good morning all | 07:23 |
rpadovani | dpm, ping :-) | 07:31 |
dpm | morning rpadovani | 07:33 |
rpadovani | dpm, morning to you :-) So, a question about tags. The branch was ready, but then mzanetti arrived and rewrite all the code for the edit page, I'm waiting the merge of his branch to merge mine too. So, There is no space anymore to list all tags in the editview. Do you want a user could edit the tags of a note in the noteview, or you prefer I add a button in the new toolbar of EditNoteVitew to edit tags? The second one IMO makes mor | 07:36 |
rpadovani | e sense, but on Android you can edit tags without editing a note | 07:36 |
rpadovani | Dunno if the wall of text above makes sense, if you want I can provide you some screenshots | 07:37 |
dpm | rpadovani, it does make sense, thanks :) I was trying the prerequisite caching branch last night, so I've not yet tested the new edit mode page. I can do that now, but if you've got some screenshots, it would help me seeing your proposals on top of that | 07:38 |
rpadovani | dpm, sure, just give me some minutes | 07:39 |
dholbach | good morning | 07:46 |
rpadovani | dpm, ok, I'll focus on uriHandler but, anyway, I show you how things are going with tagsUI branch. So, this is the NoteView, as you can see there are tags at bottom: http://postimg.org/image/z6h1psh1b/ This is the EditNoteView: http://postimg.org/image/40scfauyn/ there is also a "+" near the tags, so you can add tags. When you click on + button, you have this popup to edit tags: http://postimg.org/image/4azuyn9kv/ | 07:57 |
rpadovani | But, with new mzanetti branches you have this EditNoteView: http://postimg.org/image/61iw04r3z/ | 07:57 |
dpm | rpadovani, awesome, thanks. This makes it a lot easier to review | 07:57 |
rpadovani | dpm: So, there is no more space for tags in EditNoteView. My question is: should I move the "+" button to the NoteView or I have to create a new icon to insert near mzanetti' s buttons for formatting? I think 2nd is better, but (a) the branch is blocked until mzanetti' s branch lands and (b) evernote on android use 1st | 07:59 |
dpm | rpadovani, ok, I understand it now. I've taken a note and I'll try to get a designer to look at this. For now, I'll move both the new edit view and the tags UI bugs to the next milestone, so that we can concentrate on the essential only for the current milestone | 08:03 |
rpadovani | dpm, ok :-) | 08:04 |
mihir | popey: ping !! | 08:05 |
popey | mihir: pong! | 08:09 |
mihir | popey: what would you suggest to track down new design stuffs? | 08:09 |
popey | dpm: rpadovani mzanetti did you get evernote marketing (spam) today showing off the new UI? | 08:09 |
popey | mihir: I don't understand the question. | 08:09 |
mihir | popey: shall we create new trunk , or we can merge in existing only? | 08:10 |
rpadovani | popey, we use it since a while, but I didn't receive any mail from them | 08:10 |
popey | mihir: I would continue on trunk | 08:10 |
mihir | popey: okay :) | 08:10 |
popey | rpadovani: it was general marketing spam to everyone "Take a tour of the all-new Evernote for Android!" | 08:10 |
mihir | popey: also , i'll update the Pad as per our discussion last night. | 08:11 |
popey | mihir: excellent, thanks! | 08:11 |
mihir | popey: is there anyway we can push sync things less buggy ? | 08:11 |
rpadovani | popey, ah, gotcha: but yes, dpm and I use it since a while, and I provided to mzanetti screenshots of all features of the app :-) | 08:12 |
mihir | popey: during sprint , we were able to make EDS likely more stable with help of renetu | 08:12 |
popey | heh | 08:12 |
mihir | popey: just a thought :D | 08:12 |
popey | mihir: we need to file bugs if you find them | 08:12 |
mihir | popey: hmmm okay :) | 08:12 |
mihir | i'll make sure that now onwards. | 08:12 |
dpm | popey, I've not checked my personal e-mail today yet, but I probably got it too | 08:14 |
popey | k | 08:15 |
popey | mzanetti: gonna revert that change I made about unlocking, tested enough, and whether it's placebo or real, it felt like I didn't have the same issue. | 08:27 |
mzanetti | good mornging... | 08:42 |
* mzanetti catching up with the completely red channel | 08:42 | |
popey | mzanetti: great | 08:43 |
mzanetti | popey: 1st: no, didn't get evernote spam, but yeah, rpadovani sent me some screenies | 08:47 |
mzanetti | popey: 2nd, cool, thanks for testing the change. I'll prepare a branch and get it landed then | 08:48 |
mzanetti | rpadovani: we still could add the tags feature to the toolbar in the noteeditview. I think in the middle section (add things sections) there's still space, especially now that I removed the <hr/> icon | 08:49 |
mzanetti | rpadovani: or. even better, we add it to the panel section (rightmost) and bring in a new toolbox line containing the tags ;) | 08:50 |
rpadovani | mzanetti, I love the idea to create a toolbox line for tags | 08:54 |
ahayzen | popey, FYI Victor found a massive speed improvement in thumbnailer last night, so we're going to try tweaking the new columnflow implementation as stated here https://code.launchpad.net/~andrew-hayzen/music-app/remix-rewrite-column-flow/+merge/241338/comments/593564 and there is a minor bug fix that needs to be landed, hopefully we should have it by EOD | 09:04 |
popey | ahayzen: the fix is upstream in thumbnailer? | 09:04 |
ahayzen | popey, no us sortof workaround ish bug 1391368 | 09:05 |
ubot5 | bug 1391368 in Thumbnailer "Thumbnail generation is slow when requesting a sourceSize that needs to be rescaled" [Undecided,New] https://launchpad.net/bugs/1391368 | 09:05 |
popey | ok | 09:05 |
popey | excellent. | 09:06 |
ahayzen | popey, basically we were requesting the size 330 if we request the size 512 and scale ourselves it is much faster | 09:06 |
popey | well that sounds counter intuitive! | 09:06 |
ahayzen | popey, i'll ping you if we are clear to build a click :) i know right, i guess the QML scaling is faster is faster than what ever they are using | 09:07 |
popey | ok | 09:07 |
dpm | mzanetti, o/ - let me know when you've got a few minutes to talk | 09:09 |
mzanetti | dpm: hey, now is good | 09:10 |
dpm | mzanetti, cool, so on https://code.launchpad.net/~mzanetti/reminders-app/caching/+merge/241136 I added a comment. Not a blocker or anything, it was mostly curiosity. Other than talking about that one, I tested it at worked very well | 09:12 |
mzanetti | dpm: right, yeah... that's actually QML... the scopes have the same "issue" | 09:14 |
mzanetti | dpm: so qml builds delegates from bottom up, so the bottom-most is the first one to be queried, so the first one to be fetched | 09:15 |
mzanetti | dpm: not really sure what I can do about it. Saviq had the idea of putting lpotter onto the issue to fix it in the qml listview directly. but no idea yet how feasible that is | 09:16 |
dpm | mzanetti, ok, thanks for the context, nothing critical, and I see we cannot fix it in the app, it just looked a bit unexpected. mzanetti, ok, in that case, I think I'll approve it | 09:17 |
mzanetti | dpm: thanks :) | 09:18 |
mzanetti | dpm: replied to your mail | 09:21 |
dpm | mzanetti, awesome, thanks! I think even if the new edit view could happen today, I think I'd like to limit the number of features we land on this milestone. In particular for this one, I'd like to try to find a designer to look at it, as it's a big change (and an awesome one!) from the previous UI | 09:24 |
dpm | and it'd be good to coordinate it with the tags UI too | 09:25 |
JamesTait | Good morning all; happy Origami Day! \o/ | 09:32 |
mzanetti | I wonder if there's some instructions around for the origami unicorns we had a the sprint | 09:37 |
dpm | I thought there were some online, but I've not looked very hard :) | 09:37 |
mzanetti | http://www.youtube.com/watch?v=QVSgrAl3CyU | 09:38 |
dpm | nice! | 09:38 |
mzanetti | rofl: http://www.youtube.com/watch?v=Qzeaw7UXscw | 09:39 |
dpm | the internet will never cease to amaze me | 09:39 |
dpm | mzanetti, do you see anything obvious that might need fixing in https://code.launchpad.net/~reminders-app-dev/reminders-app/uriHandler/+merge/239961 ? rpadovani had a look at it this morning, but after doing a change and debugging it, it seems it requires more investigation | 09:40 |
mzanetti | dpm: no... just reading the code I'd say it's looking good. means, I'd need to run it and hammer in some debug prints to figure what's happening | 09:41 |
mzanetti | dpm: what's the timeline? | 09:41 |
dpm | mzanetti, I'd like to see if it's something we can get into this milestone, as it'd make the scope integration easier, but if not possible, it's nothing critical and I'd move it to the next | 09:42 |
mzanetti | relase happening Thu, so having a working branch by tonight ok? | 09:42 |
mzanetti | so you can review tomorrow the whole day | 09:42 |
dpm | mzanetti, yeah, that'll work nicely if you think it's possible. | 09:43 |
mzanetti | I'm sure it is, unless we hit weirdness in the platform | 09:43 |
dpm | excellent | 09:43 |
kalikiana | t1mp: another look, please https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/ignoreExpectedWarnings/+merge/237280 I responded and pushed some changes | 09:49 |
t1mp | ok | 09:51 |
mzanetti | popey: hey, as you did quite extensive testing, can you leave some review comment here please? https://code.launchpad.net/~mzanetti/unity8/keep-suspended-while-locked/+merge/241387 | 09:58 |
popey | mzanetti: sure | 09:58 |
JamesTait | mzanetti, I also wondered about the unicorns - thanks for the link! | 10:06 |
mzanetti | :) | 10:06 |
dpm | mzanetti, could you give me some more context on this one: https://code.launchpad.net/~mzanetti/reminders-app/fix-clone-tags/+merge/241190 - I'm adding it to the list of bugs fixed in the milestone | 10:06 |
mzanetti | dpm: this is a bugfix for tags not getting saved to evernote when saving a note | 10:07 |
dpm | ah, cool, thanks | 10:07 |
dpm | mzanetti, it seems that Jenkins choke on some merge conflicts. Could you merge with trunk and re-push on https://code.launchpad.net/~mzanetti/reminders-app/caching/+merge/241136 ? | 10:40 |
mzanetti | dpm: sure | 10:41 |
mihir | popey: can you trigger Jenkins https://code.launchpad.net/~pkunal-parmar/ubuntu-calendar-app/IncubteObject/+merge/241166 ? | 12:43 |
popey | i cdan | 12:43 |
popey | -d | 12:43 |
popey | running | 12:43 |
dpm | mzanetti, another question: that scrollbars MP for Reminders - am I supposed to see scrollbars in the notes list on the phone, or was it only for desktop? As I don't seem to see any scrollbars atm | 12:49 |
mzanetti | dpm: they are there, but the grey on grey doesn't work that well :D | 12:50 |
mzanetti | dpm: you *can* see them if watching closely | 12:50 |
mzanetti | dpm: but their real value is on the desktop, where they expand when the mouse is hovering them | 12:50 |
mihir | popey: thanks. | 12:50 |
mzanetti | dpm: maybe we should file a bug against uitk, stating that scrollbar color and default MainView color is pretty much the same | 12:51 |
dpm | mzanetti, oh, yes, they're there, but indeed, you need to watch *extremely* closely | 12:51 |
dpm | +1 | 12:51 |
mzanetti | dpm: hmm... actually, we're not using the default bg color | 12:53 |
* mzanetti tries how it looks like with defaults | 12:54 | |
mzanetti | dpm: well, its marginally better, still you only see it if you're actively looking for it | 12:56 |
mzanetti | dpm: I'll file a bug | 12:57 |
dpm | cool, thanks | 12:57 |
=== MacSlow is now known as MacSlow|lunch | ||
mihir | popey: you got few mins? | 13:01 |
popey | mihir: wassup? | 13:01 |
mihir | popey: need some design clarification :P | 13:01 |
mihir | popey: if you go to presentation , and slide num 8 | 13:01 |
mzanetti | dpm: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1391503 | 13:01 |
ubot5 | Ubuntu bug 1391503 in Ubuntu UI Toolkit "ScrollBar color is not distinctive enough" [Undecided,New] | 13:01 |
mihir | number* | 13:01 |
popey | mihir: ok, one mo | 13:01 |
popey | mihir: ok | 13:02 |
dpm | thanks mzanetti! | 13:02 |
mihir | popey: in that , if you see the border should be white , that's what gorigio has written i couldn't understand that. | 13:02 |
popey | mihir: line between events | 13:03 |
popey | to separate one event from the next | 13:03 |
mihir | popey: yup that is what i have understood. | 13:03 |
popey | k | 13:03 |
mihir | so that should be white correct? | 13:03 |
popey | yes | 13:03 |
mihir | popey: okay :) | 13:03 |
mihir | gotcha | 13:03 |
popey | thanks | 13:03 |
mihir | ahayzen: ping | 13:20 |
ahayzen | mihir, pong | 13:20 |
mihir | ahayzen: i noticed that in listView , the divider never shows in full width , is it how it behaves ? | 13:21 |
ahayzen | mihir, maybe? .. i can't remember what ours looked like when we had it? | 13:21 |
mihir | ahayzen: this is how it looks , http://i.imgur.com/aoIsPq5.png | 13:22 |
mihir | i have no margins in header though. | 13:22 |
ahayzen | mihir, looks possibly right? probably best to ask the SDK folks what to expect...or look at the docs | 13:22 |
mihir | zsombi: ping | 13:23 |
mihir | ahayzen: i thought you would have used it in Music app , so pingged directly to you. | 13:23 |
zsombi | mihir: whatsup? | 13:23 |
ahayzen | mihir, i think we *did* use it...not anymore i don't think | 13:23 |
mihir | hey zsombi doing great | 13:23 |
mihir | zsombi: got some sdk question. | 13:23 |
mihir | zsombi: got few mins ? | 13:24 |
zsombi | mihir: few :) | 13:24 |
zsombi | mihir: shoot 'em | 13:24 |
mihir | zsombi: i am using ListIItemHeader , and i just noticed that it draw line with margins. | 13:24 |
mihir | http://i.imgur.com/aoIsPq5.png | 13:24 |
mihir | is it intended ? | 13:24 |
zsombi | mihir: the image doesn't tell me your question :) | 13:25 |
mihir | zsombi: if you see first Item with the date , and it has line below that. | 13:25 |
zsombi | mihir: are you using two items there? | 13:25 |
mihir | yes , one is Header another is ListItem.Standard | 13:26 |
zsombi | mihir: ok, both of them have a ThinDivider, right? the line you see is the one from Header | 13:26 |
mihir | zsombi: in ListItem.Header ThinDivider is by default , and in ListItem.Standard i have set showDivider to false. | 13:27 |
mihir | but what i want is , the ThinDivider in ListItem.Header should be of full width instead of having it with margins. | 13:27 |
mihir | zsombi: like here you see, http://i.imgur.com/otZrlVY.png | 13:28 |
mihir | the second full width line, which is ListItem.ThinDivider. | 13:28 |
zsombi | mihir: yes... there should be an MR landed in staging which fixes that, so if you need to get them edge-to-edge, you shoudl try to access it... but I guess it's not doable from Header... | 13:29 |
mihir | zsombi: hmmm so what would be the workaround for that, will it contains property for that ? | 13:29 |
mihir | bydefault it will be full width ? | 13:29 |
zsombi | mihir: the Header won't :(... | 13:30 |
* zsombi hates the ListItems :/ | 13:30 | |
mihir | zsombi: :( then what would be the workaround ? | 13:30 |
mihir | zsombi: i can use the ListItem.ThinDivider, but i can't set Header property to false as i can do with standerd list item | 13:30 |
zsombi | mihir: unfortunately teh only way would be to create a component of your own... | 13:30 |
mihir | zsombi: ahhhh , too much work would be needed just for a line :( | 13:31 |
zsombi | mihir: or we raise the thin divider bug so we can land in RTM | 13:31 |
zsombi | mihir: we must talk to popey | 13:31 |
popey | uhoh | 13:31 |
mihir | popey: read the conversation | 13:31 |
popey | yes sir! | 13:31 |
mihir | zsombi: let me raise bug to track this atleast :) | 13:32 |
zsombi | mihir: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1380766 | 13:32 |
ubot5 | Ubuntu bug 1380766 in Ubuntu UI Toolkit "revert listitem dividers to previous (no margins)" [High,Fix committed] | 13:32 |
zsombi | mihir: no need yet another bug | 13:32 |
zsombi | mihir: you better comment on this | 13:33 |
mihir | zsombi: okay done | 13:35 |
DS-McGuire | Helllo all o/ Can somebody help me with this? : askubuntu.com/questions/548108/what-framework-to-use-for-my-web-app | 13:36 |
mihir | zsombi: shall i re-open the status ? | 13:36 |
zsombi | mihir: yes | 13:36 |
mihir | popey: to summarize , we don't have way to show full width thindivider in ListeItem.Header. | 13:37 |
mihir | zsombi: done :) | 13:37 |
popey | right | 13:37 |
zsombi | mihir: ok, thx, let's hope will get picked up as top priority one | 13:37 |
mihir | zsombi: thank you. | 13:37 |
popey | zsombi: not sure how I can do that? isn't that an SDK/toolkit thing? Do you just need me to say "hey bzoltan please can the priority of bug 1380766 be raised"? | 13:38 |
mihir | zsombi: atleast showDivider property should help I believe ( Just a guess) | 13:38 |
ubot5 | bug 1380766 in Ubuntu UI Toolkit "revert listitem dividers to previous (no margins)" [High,New] https://launchpad.net/bugs/1380766 | 13:38 |
popey | I mean, it's ota-1 already, which seems pretty good? | 13:38 |
zsombi | popey: it is fixed, but you know that we cannot land anything not "wanted" to RTM... | 13:39 |
popey | well, we can, we have the wishlist | 13:39 |
zsombi | popey: should I put the bug to the list? | 13:39 |
popey | i would. | 13:39 |
popey | please ☻ | 13:40 |
zsombi | popey: ok, on teh way | 13:40 |
popey | whether pat & olli agree, is another matter ☻ | 13:40 |
popey | DS-McGuire: looks like http://askubuntu.com/questions/548108/what-framework-to-use-for-my-web-app needs jdstrand or lool to help | 13:40 |
mihir | thanks zsombi popey :) | 13:40 |
zsombi | popey: right.. | 13:40 |
DS-McGuire | popey, Are 'lool' and 'jdstand' suppose to be links? Nothing opens. | 13:44 |
popey | DS-McGuire: no, they are people | 13:44 |
DS-McGuire | OH! LOL | 13:44 |
popey | :D | 13:44 |
DS-McGuire | jdstrand, what do you think about this? | 13:45 |
* lool opens | 13:45 | |
* lool 404s | 13:46 | |
ogra_ | fix your proxy :P | 13:46 |
lool | DS-McGuire: I bet you're using "devel" or some utopic based image | 13:46 |
DS-McGuire | On my machine? | 13:47 |
ogra_ | the 14.10 framework isnt supported in the 14.04 archive, make sure to have the SDK PPA enabled | 13:47 |
ogra_ | that will get yo the right framework support | 13:48 |
lool | DS-McGuire: on the target (emulator or phone) | 13:48 |
lool | DS-McGuire: and in the chroot | 13:48 |
* lool gtg | 13:48 | |
DS-McGuire | lool, Thank you! | 13:48 |
nik90 | popey: shouldn't the core apps bump the framework version from ubuntu-sdk-14.10-qml-dev3 to ubuntu-sdk-14.10-qml? | 13:50 |
popey | I don't think the store enforces that yet for updates to apps (right beuno ?) | 13:51 |
beuno | popey, nik90, https://myapps.developer.ubuntu.com/dev/api/click-framework/ | 13:52 |
beuno | is the current status of the store | 13:52 |
beuno | so -dev3 is still available | 13:53 |
beuno | lool gets to decide when that becomes obsolete | 13:53 |
nik90 | ok | 13:53 |
beuno | nik90, it's likely coming though, I'd prepare :) | 13:53 |
nik90 | :) | 13:54 |
=== rmescandon is now known as rmescandon|lunch | ||
jdstrand | beuno: where can I file a bug to get this resolved: https://code.launchpad.net/~jdstrand/akari/akari-fixes/+merge/240667/comments/593718 | 13:59 |
jdstrand | beuno: and hi! :) | 13:59 |
* beuno looks | 14:08 | |
beuno | jdstrand, I saw that over the weekend, but it looks fixed, no? | 14:09 |
beuno | https://myapps.developer.ubuntu.com/dev/api/click-framework/ | 14:09 |
beuno | jdstrand, you can edit what the store supports here: https://myapps.developer.ubuntu.com/dev/click-frameworks/ | 14:09 |
jdstrand | beuno: hmmm, that json does look fixed | 14:11 |
jdstrand | beuno: I'm not sure how to account for https://code.launchpad.net/~jdstrand/akari/akari-fixes/+merge/240667/comments/593632 | 14:12 |
jdstrand | beuno: that comment was from 3 hours ago | 14:12 |
jdstrand | beuno: is the store preferring the old cache over the new version? | 14:12 |
beuno | jdstrand, maybe he had submitted it before? either way, I'll check, maybe the review scripts are old on the server and they are overriding the api | 14:12 |
beuno | right | 14:13 |
jdstrand | beuno: thanks | 14:13 |
beuno | jdstrand, FWIW, this is the project to file bugs for that: https://launchpad.net/software-center-agent | 14:14 |
jdstrand | ah perfect. thanks! | 14:15 |
* jdstrand jots that down for later | 14:15 | |
beuno | jdstrand, indeed it is using the old cache, we'll fix | 14:18 |
jdstrand | hmm | 14:18 |
jdstrand | beuno: the code is designed to update the cache though, right? istr that was part of the requirements. I also stole the frameworks code for apparmor, so it might be affected too | 14:19 |
beuno | jdstrand, it is, the server isn't updating it | 14:19 |
beuno | so we need it to start doing that :) | 14:19 |
nik90 | balloons, fginther: hey, I proposed a MP for the clock-app which failed in jenkins like few seconds later..https://code.launchpad.net/~nik90/ubuntu-clock-app/bump-framework/+merge/241414 Can you take a look and check what's wrong pls? | 14:22 |
jdstrand | beuno: which brings up another point-- I feel like the apparmor json should live somewhere more official | 14:22 |
jdstrand | beuno: but I don't know that it needs a full on form | 14:22 |
beuno | jdstrand, is it simple enough for it to be represented in the store like frameworks? | 14:23 |
* beuno steps out for a quick bite | 14:23 | |
jdstrand | beuno: it is simple, but not that simple: http://bazaar.launchpad.net/~click-reviewers/click-reviewers-tools/trunk/view/head:/data/apparmor-easyprof-ubuntu.json | 14:23 |
mihir | popey: does this make sense , with respect to new Agenda Design , http://i.imgur.com/egawrCX.png ? | 14:35 |
=== MacSlow|lunch is now known as MacSlow | ||
popey | mihir: nice one! | 14:38 |
popey | thats pretty much exactly as the spec | 14:38 |
mihir | popey: i just made work around for dividers :| | 14:38 |
mihir | used ListeItem.Standared instead of Header. | 14:38 |
mihir | zsombi: ^^ | 14:38 |
zsombi | mihir: well... doable, however teh font weight will not be the same... | 14:39 |
mihir | zsombi: yes i noticed that , but i did with Label inside listItem , it seems solved issue. | 14:40 |
zsombi | mihir: nice :) | 14:40 |
mzanetti | dpm: merged https://code.launchpad.net/~mzanetti/reminders-app/caching/+merge/241136 | 14:44 |
mzanetti | dpm: wait... need to update translation | 14:45 |
mzanetti | s | 14:45 |
mzanetti | dpm: I'm not sure what happened... now the branch is just 4000 lines of translations changes | 14:49 |
* mzanetti votes for not doing the pot update in the make step | 14:50 | |
mzanetti | this is really annoying when developing | 14:50 |
ajalkane | mzanetti: it is and every new developer makes the mistake of pushing changed pot files because of that | 14:51 |
mzanetti | I'd go as far as saying it happens to most experienced devs too :D | 14:51 |
rpadovani | mzanetti, because launchpad truncates diff longer than 4000 or 5000 lines on the web interface, if you use bzr diff/log or look to mail it works well | 14:59 |
dpm | mzanetti, yeah, let's disable the "build POT always" thing in the cmake | 15:00 |
mzanetti | dpm: on it | 15:00 |
dpm | ok, cool. mzanetti, I think it's just a matter of removing the ALL in the rule | 15:00 |
mzanetti | dpm: yeah, I also renamed the target so we can easily do "make translations" instead of make com.foo.bar.bar.whatnot | 15:01 |
mzanetti | dpm: https://code.launchpad.net/~mzanetti/reminders-app/dont-always-build-translations/+merge/241424 | 15:02 |
mzanetti | dpm: jenkins is happy again with this one: https://code.launchpad.net/~mzanetti/reminders-app/caching/+merge/241136 | 15:04 |
mzanetti | I reverted the translation update as it confused me and we have to do it manually anyways starting now | 15:04 |
beuno | jdstrand, if you think the store would be a good place, I could either give you a similar UI than for frameworks | 15:05 |
beuno | or straight up uploading a json | 15:05 |
jdstrand | I think straight up uploading a json would be good | 15:05 |
jdstrand | I have a script to generate it somewhere | 15:06 |
beuno | I'll sneak that in soon | 15:06 |
jdstrand | cool, thanks | 15:06 |
dpm | mzanetti, reviewed https://code.launchpad.net/~mzanetti/reminders-app/dont-always-build-translations/+merge/241424 | 15:08 |
mzanetti | dpm: done | 15:09 |
dpm | :) | 15:09 |
dpm | approved | 15:10 |
mzanetti | thanks | 15:10 |
dpm | mzanetti, on https://code.launchpad.net/~mzanetti/reminders-app/caching/+merge/241136 - can you make it so the po/ folder is the same as in trunk? I.e. revert any changes to .po files? | 15:11 |
mzanetti | I can try at least | 15:11 |
dpm | mzanetti, all .po files are overwritten daily by Launchpad, so it's not worth merging them or fixing merge conflicts. After your other branch lands, we should stop having conflicts. But on this one, I think it'd be good to have a diff reflecting only the code changes with less noise | 15:13 |
dpm | cool, thanks | 15:13 |
mzanetti | dpm: yep, done. I just copied the whole po/ folder from a fresh checkout into that branch | 15:14 |
dpm | ah, nice | 15:14 |
dpm | mzanetti, approved, then | 15:15 |
mzanetti | cool :) | 15:15 |
mzanetti | dpm: think we could get this one out of the WIP queue? https://code.launchpad.net/~dpm/reminders-app/debian-copyright/+merge/225646 | 15:17 |
mzanetti | shouldn't be hard to fix | 15:17 |
mihir | popey: whenever you get time , could you test this MP with multiple calendar on your branch ---->https://code.launchpad.net/~mihirsoni/ubuntu-calendar-app/AgendaViewFix-newDesign/+merge/241426 | 15:23 |
pindonga | jdstrand, hi there... can I ask you for some review? | 15:24 |
pindonga | https://code.launchpad.net/~ricardokirkner/click-reviewers-tools/fetch-framework-data/+merge/241427 | 15:24 |
jdstrand | pindonga: I think that is going to cause a problem on the buildds when the testsuite is run | 15:26 |
pindonga | jdstrand, why? | 15:26 |
pindonga | it's not fetching anything during tests | 15:26 |
pindonga | it's mockedout | 15:26 |
jdstrand | let me read it more carefully | 15:27 |
jdstrand | pindonga: you ran the testsuite on that? | 15:27 |
pindonga | yep, using ./run-tests | 15:28 |
jdstrand | I'm surprised it passed | 15:28 |
pindonga | why? I'm mocking out the call to read_cr_file :) | 15:28 |
pindonga | ah, but only in a single place | 15:28 |
jdstrand | not cause of anything you did, but because I thought there were more tests for that | 15:28 |
pindonga | yep, still passes | 15:28 |
pindonga | k | 15:29 |
pindonga | it passed bc I had the frameworks.json file cached in my home | 15:29 |
pindonga | when I removed that, the test hung for a sec, while fetching the file, then continued, and passed | 15:29 |
jdstrand | ah | 15:29 |
pindonga | that could be a prolem | 15:29 |
jdstrand | right, so it did fetch | 15:29 |
pindonga | it did | 15:29 |
pindonga | I'll update the mp to mock all places where fetching is done | 15:30 |
jdstrand | pindonga: curious what prompted this mp? | 15:30 |
pindonga | jdstrand, there was a pkg that failed automated reviews bc of an invalid framework, however the store displays the framework as available and valid | 15:30 |
pindonga | the problem here was that the scripts prefer to use the local data/frameworks.json file | 15:31 |
pindonga | instead of fetching the latest from the server | 15:31 |
jdstrand | and it is because data/frameworks.json exists? | 15:31 |
pindonga | l. 8-10 of the mp | 15:31 |
jdstrand | right | 15:32 |
pindonga | if we pass no local_copy to the Frameworks obj, it will fetch from the remote server if the local cached is outdated | 15:32 |
jdstrand | well, the deb packaging is going to need to be adjusted too | 15:32 |
pindonga | ? | 15:32 |
jdstrand | debian/rules: | 15:33 |
jdstrand | -$(shell python3 ./bin/update-frameworks ./data/frameworks.json) | 15:33 |
pindonga | ack | 15:33 |
jdstrand | it is doing that for the testsuite | 15:33 |
jdstrand | on the buildd (to make sure it is up to date) | 15:34 |
=== chihchun is now known as chihchun_afk | ||
popey | akiva-thinkpad: nik90 when do you want http://summit.ubuntu.com/uos-1411/meeting/22319/roundtable-creating-a-theming-standard-for-qml/ in the schedule? | 15:58 |
nik90 | popey: that's being hosted by akiva-thinkpad, I am personally fine with with anything | 16:00 |
popey | ok | 16:01 |
pindonga | jdstrand, alright, pushed changes .. I've removed the local frameworks file from the cache, run the tests and verified it's not fetched | 16:14 |
dpm | mzanetti, I'll try, but I'm not sure I'll manage this week. It's a trivial change, but it requires some time looking into the files and the copyrights | 16:22 |
mzanetti | dpm: ok. no worries then... I just was a bit in house-keeping mood today | 16:22 |
dpm | mzanetti, sure, it's good to go into that mode every now and then. The caching branch landed, btw :) | 16:23 |
=== tgm4883_ is now known as tgm4883 | ||
mzanetti | \o/ | 16:26 |
Biju | k | 16:39 |
nik90 | popey: Can you top approve https://code.launchpad.net/~nik90/ubuntu-clock-app/bump-framework/+merge/241414.. simple framework bump | 16:52 |
* popey looks | 16:52 | |
popey | done | 16:52 |
nik90 | cool, thnx | 16:53 |
sergiusens | nik90: simple is always an invitation for issues! don't jynx it :-D | 16:53 |
jdstrand | pindonga: ok, so you probably saw I committed the MP (thanks!) | 16:54 |
jdstrand | pindonga: but I have a question | 16:54 |
nik90 | sergiusens: lol | 16:54 |
jdstrand | pindonga: if I modify ~/.cache/click-reviewers-tools/frameworks.json and remove one of the frameworks, then do 'touch -d 20141010 ./frameworks.json', then run click-review /path/to/click, the frameworks.json is not getting updated | 16:55 |
jdstrand | pindonga: I was expecting it to get updated since the mtime was out of date and the contents changed | 16:56 |
jdstrand | pindonga: so, I think that your change, while needed, won't fix the issue... | 17:00 |
jdstrand | an additional change may be needed | 17:00 |
pindonga | jdstrand, ack, will check | 17:01 |
fginther | nik90, it failed due to a transient error that even failed after a couple of automatic retries. I rebuilt it again and it passed. | 17:14 |
nik90 | fginther: yeah I saw it pass and got it also top approved. Thnx for looking into it. | 17:15 |
pindonga | jdstrand, I just checked the refresh of the frameworks file | 17:17 |
pindonga | jdstrand, it uses the ctime, instead of mtime, so touching the file has no effect | 17:18 |
pindonga | I've modified my system time to be over 1 wk in the future and run the click checks and the file was properly updatd | 17:18 |
jdstrand | pindonga: is ctime the right check for this? | 17:26 |
pindonga | that I don't know | 17:27 |
pindonga | according to the docs: Return the system’s ctime which, on some systems (like Unix) is the time of the last metadata change, and, on others (like Windows), is the creation time for path | 17:28 |
pindonga | while mtime is: Return the time of last modification of path. | 17:28 |
pindonga | maybe mtime is better? (more consistent) | 17:28 |
pindonga | jdstrand, I think mtime might be better here | 17:29 |
pindonga | ctime changes when the inode changes, but if the file is completely rewritten, without changing it's name, the inode might not change, but the data will | 17:30 |
jdstrand | pindonga: I think it probably is | 17:30 |
pindonga | jdstrand, I'll submit an mp to use mtime | 17:30 |
jdstrand | awesome, thanks! | 17:30 |
=== om26er_ is now known as om26er | ||
pindonga | jdstrand, mp is ready: https://code.launchpad.net/~ricardokirkner/click-reviewers-tools/check-file-using-mtime/+merge/241443 | 18:20 |
mihir | rpadovani: ping !! | 19:20 |
mihir | to add bottom edge is it mandatory to use custom component , or we do have an option in SDK ? | 19:21 |
nik90 | mihir: you will need to use the custom component | 19:27 |
mihir | nik90: hmm okay , thank you :) | 19:27 |
mihir | is it same across the all apps , like contacts/messaging/clock? | 19:28 |
nik90 | mihir: yup | 19:28 |
nik90 | mihir: https://bazaar.launchpad.net/~phablet-team/address-book-app/trunk/view/head:/src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml | 19:29 |
mihir | nik90: great , thanks :) | 19:30 |
rpadovani | mihir, pong | 20:19 |
rpadovani | dpm, about uriHandler, I'm not able to debug it, hope mzanetti could. Do you know who other can I ask to? | 20:50 |
rpadovani | https://code.launchpad.net/~reminders-app-dev/reminders-app/uriHandler/+merge/239961/comments/593904 | 20:50 |
dslul | ciao sei italiano? posso chiederti un paio di cose? | 20:55 |
rpadovani | dslul, se vuoi paralre italiano pingami su #ubuntu-it-dev | 21:16 |
dpm | rpadovani, sorry, about to call it a day, perhaps tomorrow? | 21:17 |
dpm | I think this will need some of mzanetti's magic touch, not sure if I can help much on that one | 21:17 |
rpadovani | dpm, yes, of course, it was only to keep you informed | 21:18 |
dpm | no worries, thanks! | 21:21 |
daker | ogra_: it did fail again :/ http://paste.ubuntu.com/8948794/ | 21:36 |
akiva-thinkpad | akiva-thinkpad: nik90 when do you want http://summit.ubuntu.com/uos-1411/meeting/22319/roundtable-creating-a-theming-standard-for-qml/ in the schedule? | 21:53 |
akiva-thinkpad | popey, yah any time is fine for me | 21:54 |
t1mp | akiva-thinkpad: note that we also have theming (and a color palette) in the UITK | 22:06 |
t1mp | akiva-thinkpad: but it can be improved, and the documentation is not up-to-date yet | 22:07 |
akiva-thinkpad | t1mp, yah I saw that recently | 22:07 |
akiva-thinkpad | t1mp, one of the main issues I see is around people manually colouring the backgrounds and all that jazz. | 22:07 |
t1mp | akiva-thinkpad: most components have a Style associated with it that implement the whole looks and behavior of the component | 22:08 |
t1mp | akiva-thinkpad: the "problem" with our current styles, for apps that simply want to change some colors, is that they are quite complicated and contain a lot | 22:08 |
t1mp | not just colors | 22:08 |
t1mp | although you could create a new theme based on our theme and change only the colors in the derivatives of the styles | 22:08 |
akiva-thinkpad | t1mp: do you know how the showcase is doing the theme change? | 22:09 |
t1mp | akiva-thinkpad: so the roundtable makes a lot of sense :) | 22:09 |
t1mp | uhm, I can look it up | 22:09 |
akiva-thinkpad | I have only briefly looked at the code. | 22:09 |
akiva-thinkpad | t1mp, Yah I hope you will join us. | 22:09 |
t1mp | akiva-thinkpad: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/examples/ubuntu-ui-toolkit-gallery/Styles.qml | 22:12 |
akiva-thinkpad | t1mp, Yah i have seen this; but the question for me is how is it binding the changes to everything in the app? | 22:12 |
akiva-thinkpad | t1mp, there is also another project in the core apps that dedicates an entire qml file to theming, and you just reference that | 22:13 |
akiva-thinkpad | And the other question is whether theming should extend to Divider, ThinDivider, and UbuntuShape | 22:14 |
t1mp | akiva-thinkpad: no, those things are not stylable | 22:15 |
t1mp | neither are the new listitems (work in progress) | 22:15 |
akiva-thinkpad | t1mp, but they could be. | 22:15 |
t1mp | because you need a lot of those, and using styling would slow it down | 22:15 |
t1mp | each StyledITem uses a loader to load its style | 22:15 |
t1mp | see http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/modules/Ubuntu/Components/StyledItem.qml | 22:15 |
akiva-thinkpad | t1mp, couldnt you just replace the ubuntu components import though? | 22:15 |
t1mp | all the components set their style property using a function call that returns the proper style from the theme | 22:16 |
t1mp | akiva-thinkpad: you mean import a theme? | 22:16 |
akiva-thinkpad | t1mp, yes; effectively | 22:16 |
akiva-thinkpad | if you wanted a metro theme for example that had hard corners | 22:16 |
akiva-thinkpad | instead of the ubuntu curve | 22:16 |
t1mp | then you would have to add the import to each component? | 22:17 |
t1mp | that means you cannot change the theme on the fly any more | 22:17 |
akiva-thinkpad | t1mp, no | 22:17 |
akiva-thinkpad | so what I mean | 22:17 |
akiva-thinkpad | err theorizing | 22:18 |
t1mp | sure :) | 22:18 |
akiva-thinkpad | is that you would change the package, "import ubuntu.components 1.1" | 22:18 |
akiva-thinkpad | you would literally change the ubuntu.components package. | 22:18 |
t1mp | by the way, this is a good session to ask questions and make suggestions: http://summit.ubuntu.com/uos-1411/meeting/22358/ubuntu-ui-toolkit-feedback/ | 22:18 |
akiva-thinkpad | t1mp, sec; I think I may have committed to something else | 22:19 |
t1mp | akiva-thinkpad: uhm. You can create your own components and import your.components 1.1 instead. If they have the same API (but different theme) it will work | 22:19 |
t1mp | but then you have your own components and you have to keep them API-compatible with Ubuntu.Components | 22:19 |
akiva-thinkpad | t1mp, I am speaking more from a systemwide side. | 22:20 |
akiva-thinkpad | So instead of changing the theme of every app individually | 22:20 |
akiva-thinkpad | you could impliment a system wide theme | 22:20 |
t1mp | ah | 22:20 |
t1mp | we don't have system themes | 22:20 |
akiva-thinkpad | t1mp, but you could do it, because we do for example | 22:20 |
akiva-thinkpad | have UbuntuColors.green | 22:20 |
akiva-thinkpad | etc | 22:20 |
akiva-thinkpad | and we do have UbuntuShape {} | 22:21 |
akiva-thinkpad | If you could get people to bind every single theming colour to say one of the packages, such as | 22:21 |
t1mp | if UbuntuColors.green = "yellow" and UbuntuShape returns a triangle, then their names don't really make sense any more ;) | 22:21 |
akiva-thinkpad | color: UbuntuTheme.darkTextOnLightBackground | 22:22 |
akiva-thinkpad | t1mp, agreed | 22:22 |
akiva-thinkpad | lol; triangle | 22:22 |
t1mp | we plan to put the settings for each of the components at the top of their style file | 22:23 |
t1mp | see for example the changes I did this week to CheckBoxStyle | 22:23 |
akiva-thinkpad | so my suggestion would not be to touch that, but to create a standard , and then put it on the back burner for a developer to impliment all these theming standards. | 22:23 |
t1mp | all the colors are there at the top of the file now. So you could create your own theme with your CheckBoxStyle derived from the one in Ubuntu.Components.Themes.Ambience and then have CheckBoxStyle.qml: import Ubuntu.Components.Themes.Ambience ; CheckBoxStyle { checkedBackgroundColor: "red" } } | 22:24 |
t1mp | and you have a new theme where the checkbox is red when checked instead of green | 22:24 |
akiva-thinkpad | t1mp, yah I have seen that; the music app did that with the progress bar | 22:25 |
t1mp | yeah, having a standard is also a good idea. Lots of work though :) | 22:25 |
akiva-thinkpad | lots | 22:25 |
akiva-thinkpad | t1mp, but I would imagine, if we want to have this option as a bullet feature of Ubuntu, that we should do it now | 22:25 |
t1mp | I'm not against it, but it is something we would need to discuss more | 22:26 |
akiva-thinkpad | yah | 22:26 |
t1mp | if we can find the time to work on it :) | 22:26 |
akiva-thinkpad | t1mp, well I think getting the standard would be the only thing that would need to be done. Actually implimenting the stuff well... | 22:26 |
akiva-thinkpad | that is sort of like whitespace maintaining on the linux kernel | 22:26 |
akiva-thinkpad | that sort of stuff is dead easy. | 22:27 |
akiva-thinkpad | btw t1mp http://summit.ubuntu.com/uos-1411/meeting/22319/roundtable-creating-a-theming-standard-for-qml/ | 22:28 |
t1mp | to make it more concrete (and easier to discuss), perhaps you can write down the idea and include some code examples how you would use it? | 22:28 |
akiva-thinkpad | i'm going to try to sign up for yours. | 22:28 |
akiva-thinkpad | t1mp, will do. | 22:28 |
t1mp | akiva-thinkpad: zsombi is doing most of the work in our theming engine, try to catch him too :) | 22:29 |
akiva-thinkpad | I'll see | 22:29 |
t1mp | akiva-thinkpad: yes, they made me track lead for the app developers track.. so I try to be there for a lot of the meetings (although some of them that are later in the day I will have to miss) | 22:29 |
akiva-thinkpad | I sent a mail to the sdk team but | 22:29 |
akiva-thinkpad | well who knows; we will see | 22:30 |
t1mp | hmm, I didn't see that | 22:30 |
t1mp | where did you send the e-mail? | 22:30 |
akiva-thinkpad | t1mp, it was to the admins | 22:30 |
akiva-thinkpad | I don't know how to send the whole team a message on LP | 22:31 |
akiva-thinkpad | although I hear its possible :P | 22:31 |
t1mp | probably it is best to use the mailing lists (touch-coreapps), or catch us on irc :) | 22:31 |
t1mp | akiva-thinkpad: even better, come to the feedback sessions in the online summit :) | 22:31 |
* t1mp gotta go now | 22:31 | |
akiva-thinkpad | later | 22:31 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!